From patchwork Wed Oct 14 20:25:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "John Daley (johndale)" X-Patchwork-Id: 80801 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89C54A04DB; Wed, 14 Oct 2020 22:25:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA1581DA58; Wed, 14 Oct 2020 22:25:29 +0200 (CEST) Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) by dpdk.org (Postfix) with ESMTP id 6EE641C296 for ; Wed, 14 Oct 2020 22:25:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=889; q=dns/txt; s=iport; t=1602707128; x=1603916728; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=gaiLeKLRiIIf6slb9k2xH0cCwwNdyblfOwBwyToBThA=; b=bIWHKoS8vd/0bLbd5MLTuVvwdQdrzmhRfXoM72VXLcsuLeDbBRVm+G2/ A8UUX0CJQyMsR/qYc6YDs6MeXtVru4M1o/PnER5JhxHPGW/HuEzFuWtBR P9As9ZMHI90Yr+5BqqJ8ziAfyisUB4GKRQ6jFt7lsCpswO2N/Ywlyx4Ip Q=; X-IronPort-AV: E=Sophos;i="5.77,375,1596499200"; d="scan'208";a="582718715" Received: from alln-core-6.cisco.com ([173.36.13.139]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 14 Oct 2020 20:25:26 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-core-6.cisco.com (8.15.2/8.15.2) with ESMTP id 09EKPQiA024208; Wed, 14 Oct 2020 20:25:26 GMT Received: by cisco.com (Postfix, from userid 392789) id EE59D3FAB869; Wed, 14 Oct 2020 13:25:25 -0700 (PDT) From: John Daley To: ferruh.yigit@intel.com, arybchenko@solarflare.com Cc: dev@dpdk.org, John Daley Date: Wed, 14 Oct 2020 13:25:22 -0700 Message-Id: <20201014202522.7466-1-johndale@cisco.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Outbound-SMTP-Client: 10.193.184.48, savbu-usnic-a.cisco.com X-Outbound-Node: alln-core-6.cisco.com Subject: [dpdk-dev] [PATCH] net/enic: check return code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity issue: 363046 Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") Signed-off-by: John Daley Reviewed-by: Ferruh Yigit --- drivers/net/enic/enic_fm_flow.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c index 96ec360a85..9cea94269c 100644 --- a/drivers/net/enic/enic_fm_flow.c +++ b/drivers/net/enic/enic_fm_flow.c @@ -2232,7 +2232,11 @@ enic_action_handle_get(struct enic_flowman *fm, struct fm_action *action_in, error_with_action_handle: args[0] = FM_ACTION_FREE; args[1] = ah->handle; - flowman_cmd(fm, args, 2); + ret = flowman_cmd(fm, args, 2); + if (ret != 0) + rte_flow_error_set(error, -ret, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, "enic: devcmd(action-free)"); error_with_ah: free(ah); return ret;