From patchwork Mon Sep 28 00:00:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 78951 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A25DA04C0; Mon, 28 Sep 2020 02:01:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E729C1C23C; Mon, 28 Sep 2020 02:01:00 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3D9451C20D; Mon, 28 Sep 2020 02:00:58 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id DE0C25C0144; Sun, 27 Sep 2020 20:00:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 27 Sep 2020 20:00:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=+iXodIfrnORLq +9HTQIk8FCfJSf30GThN4dV/OaKqdo=; b=ZyVF14YVoyLrmDwDjgEYzEor8xrxK LOhtiiuKoI2WXAF+ivKA5D72TumN8uoPz+aEZ9M/qj1h7VrSVu+TzrGatwdWkYZF E5S3iZPWL3dG/rDUPEv3lR7+EPPf/m4WJ7kv5Isln1/KHfMTRjsk8OopHeFJ/BY0 V/jPCKdy/EoXZx9N6JuC8S7RYoHyRdwLExXmESsPrTBN2B6aovvV0AVDXSUErh2m o5F+1eUX8xOldCqeAT1je1kzFf/KQiFqn0dfmvVNNqFieQFG52XB+pVEoL3J5V1M sJznN1AffacWQrwG/cK8f7UZQlZfD5HW43tWbWKMJH9oXH2SON7zzow6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=+iXodIfrnORLq+9HTQIk8FCfJSf30GThN4dV/OaKqdo=; b=UVdwdEoJ 1fDILwGi20QkA2MalOqmZgmfZhV5GEMPir01BTG1RtBuJVDI5tHK5m5HuK20cXXJ +hgLNQE6KeRXnsA5/y+LdV8L02OugrnKHk/qbR3HSjsHlU0Er7a7TIkWkJKWjs/T p5AYH3GqalkfOt06xUOVV7MI2H3FC4HY1krA4+mzo8hiGEqVZerckzG83lYe3nqY OjmCsyrSGAfQ4KrOeLBJS1DS4VV1ssNajuQ0xQgEK6z/bwg4d6e76EmWCauC1THY lxpRNpHiPq5qGQKK+wRsooLV3umv+f0dn74NHm0H7GPbodx0Os25z92IIlRRWxpt pu+5I4UZBBFwnw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdehgddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu tdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9705D3064683; Sun, 27 Sep 2020 20:00:55 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org, techboard@dpdk.org Cc: david.marchand@redhat.com, bruce.richardson@intel.com, Ray Kinsella , Neil Horman Date: Mon, 28 Sep 2020 02:00:48 +0200 Message-Id: <20200928000049.3245920-1-thomas@monjalon.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200624093627.2603992-1-thomas@monjalon.net> References: <20200624093627.2603992-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2] eal: simplify exit functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The option RTE_EAL_ALWAYS_PANIC_ON_ERROR was off by default, and not customizable with meson. It is completely removed. The function rte_dump_registers is a trace of the bare metal support era, and was not supported in userland. It is completely removed. Signed-off-by: Thomas Monjalon Acked-by: Ray Kinsella Acked-by: Bruce Richardson Acked-by: Konstantin Ananyev Acked-by: Kevin Traynor Acked-by: David Marchand Acked-by: Bruce Richardson Acked-by: Konstantin Ananyev Acked-by: Kevin Traynor Acked-by: Ray Kinsella Acked-by: David Marchand --- The deprecation notice for this removal has been missed. I assume it would not hurt anybody to remove this useless function from DPDK 20.11. Asking the Technical Board for confirmation. --- app/test/test_debug.c | 3 --- doc/guides/howto/debug_troubleshoot.rst | 2 +- doc/guides/rel_notes/release_20_11.rst | 2 ++ lib/librte_eal/common/eal_common_debug.c | 17 +---------------- lib/librte_eal/include/rte_debug.h | 7 ------- lib/librte_eal/rte_eal_version.map | 1 - 6 files changed, 4 insertions(+), 28 deletions(-) diff --git a/app/test/test_debug.c b/app/test/test_debug.c index 25eab97e2a..834a7386f5 100644 --- a/app/test/test_debug.c +++ b/app/test/test_debug.c @@ -66,13 +66,11 @@ test_exit_val(int exit_val) } wait(&status); printf("Child process status: %d\n", status); -#ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR if(!WIFEXITED(status) || WEXITSTATUS(status) != (uint8_t)exit_val){ printf("Child process terminated with incorrect status (expected = %d)!\n", exit_val); return -1; } -#endif return 0; } @@ -113,7 +111,6 @@ static int test_debug(void) { rte_dump_stack(); - rte_dump_registers(); if (test_panic() < 0) return -1; if (test_exit() < 0) diff --git a/doc/guides/howto/debug_troubleshoot.rst b/doc/guides/howto/debug_troubleshoot.rst index 5a46f5fba3..50bd32a8ef 100644 --- a/doc/guides/howto/debug_troubleshoot.rst +++ b/doc/guides/howto/debug_troubleshoot.rst @@ -314,7 +314,7 @@ Custom worker function :numref:`dtg_distributor_worker`. * For high-performance execution logic ensure running it on correct NUMA and non-master core. - * Analyze run logic with ``rte_dump_stack``, ``rte_dump_registers`` and + * Analyze run logic with ``rte_dump_stack`` and ``rte_memdump`` for more insights. * Make use of objdump to ensure opcode is matching to the desired state. diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst index f377ab8e87..c0b83e9554 100644 --- a/doc/guides/rel_notes/release_20_11.rst +++ b/doc/guides/rel_notes/release_20_11.rst @@ -184,6 +184,8 @@ ABI Changes Also, make sure to start the actual text at the margin. ======================================================= +* eal: Removed the not implemented function ``rte_dump_registers()``. + * ``ethdev`` changes * Following device operation function pointers moved diff --git a/lib/librte_eal/common/eal_common_debug.c b/lib/librte_eal/common/eal_common_debug.c index 722468754d..15418e957f 100644 --- a/lib/librte_eal/common/eal_common_debug.c +++ b/lib/librte_eal/common/eal_common_debug.c @@ -7,14 +7,6 @@ #include #include -/* not implemented */ -void -rte_dump_registers(void) -{ - return; -} - -/* call abort(), it will generate a coredump if enabled */ void __rte_panic(const char *funcname, const char *format, ...) { @@ -25,8 +17,7 @@ __rte_panic(const char *funcname, const char *format, ...) rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); va_end(ap); rte_dump_stack(); - rte_dump_registers(); - abort(); + abort(); /* generate a coredump if enabled */ } /* @@ -46,14 +37,8 @@ rte_exit(int exit_code, const char *format, ...) rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); va_end(ap); -#ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR if (rte_eal_cleanup() != 0) RTE_LOG(CRIT, EAL, "EAL could not release all resources\n"); exit(exit_code); -#else - rte_dump_stack(); - rte_dump_registers(); - abort(); -#endif } diff --git a/lib/librte_eal/include/rte_debug.h b/lib/librte_eal/include/rte_debug.h index 50052c5a90..c4bc71ce28 100644 --- a/lib/librte_eal/include/rte_debug.h +++ b/lib/librte_eal/include/rte_debug.h @@ -26,13 +26,6 @@ extern "C" { */ void rte_dump_stack(void); -/** - * Dump the registers of the calling core to the console. - * - * Note: Not implemented in a userapp environment; use gdb instead. - */ -void rte_dump_registers(void); - /** * Provide notification of a critical non-recoverable error and terminate * execution abnormally. diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map index c32461c663..cd1a90b95f 100644 --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -38,7 +38,6 @@ DPDK_21 { rte_devargs_remove; rte_devargs_type_count; rte_dump_physmem_layout; - rte_dump_registers; rte_dump_stack; rte_dump_tailq; rte_eal_alarm_cancel;