From patchwork Mon Sep 21 13:38:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 78187 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 546F0A04CC; Mon, 21 Sep 2020 15:38:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFF261DA47; Mon, 21 Sep 2020 15:38:40 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 946591D942 for ; Mon, 21 Sep 2020 15:38:37 +0200 (CEST) IronPort-SDR: 5YTg3gAzIRAsabTQfnIKXwVf9IyeOJJZzt9Z3Q8+Egux19ytK8iT20FIOxe33PvKAsn8sTYr78 2CxlkzE/fE5A== X-IronPort-AV: E=McAfee;i="6000,8403,9750"; a="140387192" X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="140387192" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 06:38:34 -0700 IronPort-SDR: IKJ2KiivbkpII+9rpVX9S5iGtZpeC2gjaflPkmVNQzc8JK7KNK0KOZ9xm72VEstCwuP8khlAYB LalUMdL2AniA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="510074220" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by fmsmga006.fm.intel.com with ESMTP; 21 Sep 2020 06:38:32 -0700 From: Ferruh Yigit To: Rasesh Mody , Shahed Shaikh Cc: dev@dpdk.org, Ferruh Yigit Date: Mon, 21 Sep 2020 14:38:27 +0100 Message-Id: <20200921133830.1575872-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/4] net/qede: fix build with gcc 11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920 (experimental) build error: ../drivers/net/qede/qede_main.c: In function ‘qed_get_current_link’: ../drivers/net/qede/qede_main.c:587:17: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 587 | if (!ptt) | ^~ ../drivers/net/qede/qede_main.c:590:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 590 | qed_fill_link(hwfn, ptt, if_link); | ^~~~~~~~~~~~~ Signed-off-by: Ferruh Yigit --- I am not clear what the exact intention of the original code is, compiler warning is about wrong indentation of 'qed_fill_link(..)', I have updated the code to keep the behavior same but fix the indentation. Please send a proper fix if the existing behavior needs to be updated. --- drivers/net/qede/qede_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index aecb98261..0f82568d3 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -587,7 +587,7 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link) if (!ptt) DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n"); - qed_fill_link(hwfn, ptt, if_link); + qed_fill_link(hwfn, ptt, if_link); if (ptt) ecore_ptt_release(hwfn, ptt); From patchwork Mon Sep 21 13:38:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 78186 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39F64A04CC; Mon, 21 Sep 2020 15:38:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C6A381D9E4; Mon, 21 Sep 2020 15:38:37 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id ECDAF1D942 for ; Mon, 21 Sep 2020 15:38:36 +0200 (CEST) IronPort-SDR: Ig19IRfQohHR5itH26IZKr0zhg+gE+6RMNmRDSwqNNJRLGp0WwasTtqOkwHR3T4oDYO0N9x+7l COW+bG/3JU+w== X-IronPort-AV: E=McAfee;i="6000,8403,9750"; a="140387195" X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="140387195" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 06:38:35 -0700 IronPort-SDR: TbWpqYLQc7iGGHaJXlJ8mkvrovZ2amQAlBpRl/wxGldWoH5rr4Dg5QlNR8C2RNS1OoFwL/iMD7 XcEtEXp2p8/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="510074226" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by fmsmga006.fm.intel.com with ESMTP; 21 Sep 2020 06:38:34 -0700 From: Ferruh Yigit To: Nipun Gupta Cc: dev@dpdk.org, Ferruh Yigit Date: Mon, 21 Sep 2020 14:38:28 +0100 Message-Id: <20200921133830.1575872-2-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200921133830.1575872-1-ferruh.yigit@intel.com> References: <20200921133830.1575872-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/4] raw/dpaa2: fix build with gcc 11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920 (experimental) build error: ../drivers/raw/dpaa2_qdma/dpaa2_qdma.c: In function ‘rte_qdma_reset’: ../drivers/raw/dpaa2_qdma/dpaa2_qdma.c:454:17: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 454 | if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues != | ^~ ../drivers/raw/dpaa2_qdma/dpaa2_qdma.c:457:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 457 | return -EBUSY; | ^~~~~~ Signed-off-by: Ferruh Yigit --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c index 0b9c4e3d7..2cba71c63 100644 --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c @@ -452,9 +452,10 @@ rte_qdma_reset(void) /* In case there are pending jobs on any VQ, return -EBUSY */ for (i = 0; i < qdma_dev.max_vqs; i++) { if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues != - qdma_vqs[i].num_dequeues)) + qdma_vqs[i].num_dequeues)) { DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", i); return -EBUSY; + } } /* Reset HW queues */ From patchwork Mon Sep 21 13:38:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 78188 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEE09A04CC; Mon, 21 Sep 2020 15:38:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 364D51DA54; Mon, 21 Sep 2020 15:38:42 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 697DB1D942 for ; Mon, 21 Sep 2020 15:38:38 +0200 (CEST) IronPort-SDR: eQJ2D0pVoMLNNN+p7KTXhB5rWfNHbzmO/rk4c32TuHnd7v/bON68Lb9VdgPntXUyuTEUWar8kk e33PH7u7MA/A== X-IronPort-AV: E=McAfee;i="6000,8403,9750"; a="140387198" X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="140387198" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 06:38:38 -0700 IronPort-SDR: huptdtLAr9+tsMXliHA/mB77O7s5bSK61ndJ9jKKhvEfMGCWYYt1I2tvIYG4zi1ZEWBwku7I7Y wUeRSqO/7u2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="510074287" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by fmsmga006.fm.intel.com with ESMTP; 21 Sep 2020 06:38:36 -0700 From: Ferruh Yigit To: Wenzhuo Lu , Beilei Xing , Bernard Iremonger Cc: dev@dpdk.org, Ferruh Yigit Date: Mon, 21 Sep 2020 14:38:29 +0100 Message-Id: <20200921133830.1575872-3-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200921133830.1575872-1-ferruh.yigit@intel.com> References: <20200921133830.1575872-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920 (experimental) ../app/test-pmd/config.c:1777:61: warning: argument 3 of type ‘const uint32_t[n]’ {aka ‘const unsigned int[n]’} declared as a variable length array [-Wvla-parameter] 1777 | port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n]) | ~~~~~~~~~~~~~~~^~~~~~~~ In file included from ../app/test-pmd/config.c:53: ../app/test-pmd/testpmd.h:764:67: note: previously declared as a pointer ‘const uint32_t *’ {aka ‘const unsigned int *’} 764 | void port_flow_list(portid_t port_id, uint32_t n, const uint32_t *group); | ~~~~~~~~~~~~~~~~^~~~~ Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand Reviewed-by: Phil Yang Reviewed-by: Asaf Penso Reviewed-by: David Marchand Reviewed-by: Phil Yang Reviewed-by: Asaf Penso --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index b6eb2a57a..380f3b5f6 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1774,7 +1774,7 @@ port_flow_aged(portid_t port_id, uint8_t destroy) /** List flow rules. */ void -port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n]) +port_flow_list(portid_t port_id, uint32_t n, const uint32_t *group) { struct rte_port *port; struct port_flow *pf; From patchwork Mon Sep 21 13:38:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 78189 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81295A04CC; Mon, 21 Sep 2020 15:39:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 66A2B1DA5A; Mon, 21 Sep 2020 15:38:43 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 49A451DA23 for ; Mon, 21 Sep 2020 15:38:40 +0200 (CEST) IronPort-SDR: dYj5BHNPulgaAKOAwuviUNdEKigDOPa5rqjP31DsRS/W+7lLPaznkqHfpCupCvUvHCfVrlPLwR 4yw29/3XHwew== X-IronPort-AV: E=McAfee;i="6000,8403,9750"; a="140387201" X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="140387201" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 06:38:39 -0700 IronPort-SDR: Z6yfLo/jtTdsT+CDD3YDk1s3/pSU4UZBjN8sQZaDlHmgF8k9E+7doqTCY/WiNXauQtlNSTOGSI xSCevfNvn0Ag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="510074341" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by fmsmga006.fm.intel.com with ESMTP; 21 Sep 2020 06:38:39 -0700 From: Ferruh Yigit To: Neil Horman Cc: dev@dpdk.org, Ferruh Yigit Date: Mon, 21 Sep 2020 14:38:30 +0100 Message-Id: <20200921133830.1575872-4-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200921133830.1575872-1-ferruh.yigit@intel.com> References: <20200921133830.1575872-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 4/4] pmdinfogen: fix build with gcc 11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920 (experimental) build error: In file included from ../buildtools/pmdinfogen/pmdinfogen.c:17: ../buildtools/pmdinfogen/pmdinfogen.c: In function ‘parse_elf’: ../buildtools/pmdinfogen/pmdinfogen.h:78:1: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] 78 | else \ | ^~~~ ../buildtools/pmdinfogen/pmdinfogen.h:83:35: note: in expansion of macro ‘CONVERT_NATIVE’ 83 | #define TO_NATIVE(fend, width, x) CONVERT_NATIVE(fend, width, x) | ^~~~~~~~~~~~~~ ../buildtools/pmdinfogen/pmdinfogen.c:152:28: note: in expansion of macro ‘TO_NATIVE’ 152 | hdr->e_type = TO_NATIVE(endian, 16, hdr->e_type); | ^~~~~~~~~ ../buildtools/pmdinfogen/pmdinfogen.h:80:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘else’ 80 | ___x; \ | ^~~~ Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand --- buildtools/pmdinfogen/pmdinfogen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildtools/pmdinfogen/pmdinfogen.h b/buildtools/pmdinfogen/pmdinfogen.h index 93930e454..38fd3ddcc 100644 --- a/buildtools/pmdinfogen/pmdinfogen.h +++ b/buildtools/pmdinfogen/pmdinfogen.h @@ -77,7 +77,7 @@ if ((fend) == ELFDATA2LSB) \ ___x = le##width##toh(x); \ else \ ___x = be##width##toh(x); \ - ___x; \ +___x; \ }) #define TO_NATIVE(fend, width, x) CONVERT_NATIVE(fend, width, x)