From patchwork Mon Aug 17 05:16:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vipul Ashri X-Patchwork-Id: 75638 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A719DA034C; Tue, 18 Aug 2020 15:51:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 64F491C1B6; Tue, 18 Aug 2020 15:47:24 +0200 (CEST) Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by dpdk.org (Postfix) with ESMTP id AA09B1C0BD; Mon, 17 Aug 2020 07:18:14 +0200 (CEST) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07H5D3CO050336; Mon, 17 Aug 2020 05:18:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=PyGERTMxQIjj1Gc+veOLRN0Vc7P2HSS60BlhuK2xveE=; b=t7O2iY73PfNxJ1/QBDZLWqhQtZccSn7alSLelKsAWiwFqnKRgyDmGKRvWonRyMkIjUpy a4PbMzHi4hIRsuvnnqB7yXNL55vaPBC1bUKXyfPM08fx+LCUSpjuobc6oeokZIleU1L+ ERpFAOXktUDSbZpJPLCHakcmDVcLX727bpealQes0+Z4Zo/WKmDzTB34m/m6cFTxogQe I3fhSjy70mhBy+Rzg7hqTr6YJ8NP42DJaQN7LH7gW52a2xoKAtWNFYSXxC1ckGSVe5AM vXmaArExXsW8+1tchqM3BYnkQFvEYP8k+pLV6O29C4G680mqDdAx+AyBl0G4zf62Zd/E iA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 32x74qvepm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 17 Aug 2020 05:18:13 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07H5EHjX017206; Mon, 17 Aug 2020 05:16:13 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 32xsfpxf3c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 17 Aug 2020 05:16:12 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07H5GCha003766; Mon, 17 Aug 2020 05:16:12 GMT Received: from VASHRI-IN.in.oracle.com (/203.81.240.114) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 16 Aug 2020 22:16:11 -0700 From: Vipul Ashri To: dev@dpdk.org Cc: stable@dpdk.org Date: Mon, 17 Aug 2020 10:46:04 +0530 Message-Id: <20200817051604.1747-1-vipul.ashri@oracle.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9715 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 spamscore=0 suspectscore=1 mlxscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008170041 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9715 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 mlxlogscore=999 priorityscore=1501 phishscore=0 spamscore=0 mlxscore=0 adultscore=0 suspectscore=1 lowpriorityscore=0 bulkscore=0 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008170041 X-Mailman-Approved-At: Tue, 18 Aug 2020 15:47:01 +0200 Subject: [dpdk-dev] [PATCH] net/virtio: fix wrong variable assignment in helper macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always failing as assignment done using var_ having local scope only. This leads to TX packets not going out and found broken due to cleanup malfunctioning. This patch fixes the wrong variable assignment. Fixes: 57f90f894588 ("net/virtio: reuse packed ring functions") Cc: stable@dpdk.org Signed-off-by: Vipul Ashri --- drivers/net/virtio/virtqueue.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h index 105a9c00c..20c95471e 100644 --- a/drivers/net/virtio/virtqueue.h +++ b/drivers/net/virtio/virtqueue.h @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq) /* avoid write operation when necessary, to lessen cache issues */ #define ASSIGN_UNLESS_EQUAL(var, val) do { \ - typeof(var) var_ = (var); \ - typeof(val) val_ = (val); \ - if ((var_) != (val_)) \ - (var_) = (val_); \ + if ((var) != (val)) \ + (var) = (val); \ } while (0) #define virtqueue_clear_net_hdr(hdr) do { \