From patchwork Tue Aug 11 08:52:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75387 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C92B7A04AF; Tue, 11 Aug 2020 10:53:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10E4C1C027; Tue, 11 Aug 2020 10:53:07 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 9EF4E1C01F for ; Tue, 11 Aug 2020 10:53:04 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085303euoutp01983d7e9e8b3748a92de51f940843da54~qKrcb-uoB0646906469euoutp01i; Tue, 11 Aug 2020 08:53:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085303euoutp01983d7e9e8b3748a92de51f940843da54~qKrcb-uoB0646906469euoutp01i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597135983; bh=BG13JEDguLywByJwOXQTWe6Zorck+0Dg5OriYR0Hx5A=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=BHGklrOaPad48h3jooD78okfYhawo4GoitxJA1+VaD7rgEeHYlB/7fgoMEDKxfzIY 6y2N28WGDolw3LwUeU1S0qg8n2OBGIkFdTnUFM8V0C8xMLTcuAvef2TFm0LBv++nMp mcGV2Iq02t1fVJyyUHN3pQUF39HZrMvAQJo6W9Fs= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085303eucas1p1ee60d3e4c37bbc07ccbf81bc38b08e9f~qKrcIxDu01584815848eucas1p1a; Tue, 11 Aug 2020 08:53:03 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 7C.0C.05997.F6C523F5; Tue, 11 Aug 2020 09:53:03 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085302eucas1p22f4a941f6015f378792aae713123fbcc~qKrbn5oyJ0326203262eucas1p2f; Tue, 11 Aug 2020 08:53:02 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085302eusmtrp108824ed0d9c7a4533e7462d71c7d4b41~qKrbm8K_I1606216062eusmtrp16; Tue, 11 Aug 2020 08:53:02 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-7f-5f325c6f81af Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id FA.3D.06017.E6C523F5; Tue, 11 Aug 2020 09:53:02 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085300eusmtip15d311123947fddb10c7e97e94111aafc~qKrZs7Bnw1362413624eusmtip1i; Tue, 11 Aug 2020 08:53:00 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:20 +0300 Message-Id: <20200811085246.28735-2-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA02Sf2wTBRTHfXfXu1td8SgjPNGga0JiTWTsR/QpxokYc8aEGP8gisqschno fqXHGOOvZZiVlLmNboHQ6tyYurFKCrZbZ6lzNkDpurpAGAwdbMJw2YQxxogwN3Dnlch/3+/3 fV7ee8kTWXOQXy5uLdqm2ItsBRbeyHWevNv/XPEHWXmrj51YSr6+RqDLl1pYGmm4yNOeqc8Z GmzPpXDwSwO5hisYqnHdZCjY5uTp2kglR5PTQYaGfooL5D5TKdB0ZEygL/o9QGNzEywdaLoF 1N/YYaC7v4R4ujF3kKOa2QGg2sApoGj1TY4afuwCqnJKNHWoVaCWoRU0PXKKo/gFv0Df3z7N UkffPNDeqA8oUXXf8Gq6PNv0rUFuCY8zcn3zaVY+eWGfIFfHGhn56GQXI9/oHuDlmkA7yL2X 97Cyd/QO/7Zxo/HlzUrB1u2KPeOVj4xbDo+4hBL34zuGaxJCBXyT5oQUEaUc/DN4jHeCUTRL bYCXDnclzQzgoMOVNLcAGyYGhAct3301mSy0Ap6onAfd3AbsqzsLGsVLz2B8dyOjFdKkozwG 584vGFFcIr2EvsH3NYaTVuIfvVOMpk3Sizh91WPQJzyF3iM9rKZTFnCvZ/g/bZZW4PmvZ5L8 YowdGOU0zS7wuzo8rN47I+LZgKLr1/Ha6CHQ9RKciAaSFzyJ8fpqTtsNJQfg3k6/oJs6wF2e 60kqFwN//SpoS7OSFX2hDD1ei3fCTk6LUVqEg9cX6zssQlfnflaPTbi7yqzTFuyJnUnGiPP/ pOqxjN6fo0wdpLsfOsb90DHu/8c2AdsOy5RStTBfUbOKlLJVqq1QLS3KX/VJceEPsPDO8XvR mS4IzX0cAUkES6qpZE1mntlg266WF0YARdaSZnotEd9kNm22le9U7MV59tICRY3AEyJnWWbK Pjj+oVnKt21TPlOUEsX+oMqIKcsr4Iht6GlrWcifNb7609bj6+C+b6Wv+16ZNLQuVPtI7Mrv FeGWDY/a1SA4HjMOW3PKMoJX89oyey/2LeWymzPWHk8t37cpYk2MRV5Qrzw/ttNpFde81Z0e cZzLfmf/xv43RE9D8zm/NfHb7Lut69vfq8+t9TtiG8J/5/Rkv+kNCc07LJy6xZb5LGtXbf8C urc+aMoDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTcRTG+d+73V2twXUt+itktooicHo3zTMte/tyoz4E9aU0deRFLbfJ 7iZZCsvKYpqVWdCWy7KyZmIvmrMyakGma0RFqZRpakUZ8y17EbM2Lerbc87zex44cGhSdlsc RmfpTbxRr81WUMEiz2RLV6Q+WZUabRmKhrrHDgS9b6pI6CnvoqB4aD8BHc6VcKfxtBjKui0E lJYNE9B4yUrB555CEfhGGgl43eyRgO1ZoQRG3B8kcPiJHcGHiU8knKocRfDE0SCGH/dvUTA4 cU4EpeMvEBypf4SgpWRYBOVNLgRFVgaGLldLoOp1OIz0PBKBp/OGBK6MPSWh4fFPBMda6hB4 i36JV83nxisviLmqOx8J7vjZpyT3sPOkhCtpdRDcNZ+L4AbvvqC40non4tp6i0mupv87tTF4 q3K50WA28RGZBsG0QpHEgkrJakCpitEoWXXctnhVrCIqcXk6n52VyxujEtOUmbU9ZZIcW+iu 7lKvxILOy60oiMZMDL5Y4aOsKJiWMRcQrui86B9ov4HxQD85zczCEy+tf5hRhPtuDEwZFLME ew45iIAhZ15R+PnBvaJAeBYTj+s6kgKMiFmE37YNEQEtZTR45J1dPF06D9dcvTfVE+THa+zd U1rGZOG9XU3UtA7H7We+/MmG4NZT/VP1JLMY1zlkgTXpr9nXYCePohDbf5TtH2X7j6pEpBPJ ebOgy9AJKqWg1QlmfYZyu0F3Hfkf5+bDH/UuZPVtciOGRoqZ0pwENlUm1uYKeTo3wjSpkEvX eD0pMmm6Nm83bzSkGs3ZvOBGsf4zj5Fhs7cb/G+oN6WysWwcaNg4dZx6GSjmSA8x95NlTIbW xO/k+Rze+DdH0EFhFoSv5jXMUIf4kguJYtu3qJzebmoHt36rpr55wmkoWpA/GfWgNs17uYCK 6G3LTyoMPbEhsmiwXVa9v9ry3e1be4Xtv02uLdlSkjJfnFjx3u5Ne/tVPTx5YDNtqQ29NBZ+ ps85Furak2Dn18G78QKffmFCRnn74XuC3PzFNZeNWK0QCZladilpFLS/AXjMThFOAwAA X-CMS-MailID: 20200811085302eucas1p22f4a941f6015f378792aae713123fbcc X-Msg-Generator: CA X-RootMTR: 20200811085302eucas1p22f4a941f6015f378792aae713123fbcc X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085302eucas1p22f4a941f6015f378792aae713123fbcc References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 01/24] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is optional. The value ETH_SPEED_NUM_NONE (0) was already part of the API. The value ETH_SPEED_NUM_UNKNOWN (infinite) is added to cover two different cases: - speed is not known by the driver - device is virtual Suggested-by: Morten Brørup Suggested-by: Benoit Ganne Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index a49242bcd..2090af501 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -303,6 +303,7 @@ struct rte_eth_stats { #define ETH_SPEED_NUM_56G 56000 /**< 56 Gbps */ #define ETH_SPEED_NUM_100G 100000 /**< 100 Gbps */ #define ETH_SPEED_NUM_200G 200000 /**< 200 Gbps */ +#define ETH_SPEED_NUM_UNKNOWN UINT32_MAX /**< Unknown */ /** * A structure used to retrieve link-level information of an Ethernet port. @@ -2262,15 +2263,16 @@ int rte_eth_allmulticast_disable(uint16_t port_id); int rte_eth_allmulticast_get(uint16_t port_id); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It might need - * to wait up to 9 seconds in it. + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). + * + * It might need to wait up to 9 seconds. + * @see rte_eth_link_get_nowait. * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. @@ -2279,15 +2281,13 @@ int rte_eth_allmulticast_get(uint16_t port_id); int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It is a no-wait - * version of rte_eth_link_get(). + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. From patchwork Tue Aug 11 08:52:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75388 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89E5FA04AF; Tue, 11 Aug 2020 10:53:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B236C1C0B4; Tue, 11 Aug 2020 10:53:09 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 7D4BD1C027 for ; Tue, 11 Aug 2020 10:53:06 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085305euoutp017700cab035e83a88ec695f868dc2cb04~qKreMUUiq0826508265euoutp01Z; Tue, 11 Aug 2020 08:53:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085305euoutp017700cab035e83a88ec695f868dc2cb04~qKreMUUiq0826508265euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597135985; bh=yjuhr21wJK56U6WY1nzuFW3DUMB8s5LfzNkDjUmUCik=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Gnwp6ehTrK/CQjsgWOka/Qwp2BBAUhfjKjcf8xIYo4LxRgOf7meb1R+7onw3zD6xX Gr5jkdI2efxm57lIxeX1qMiZ8EYloZLgJPu1C5ON1a0OyWF7xfrUXpzute/yxnrQlv ZegS9wV1XQkVio8JSZ1nziuZNDhUQZKBhUDBpQ7Q= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200811085305eucas1p26c584841ada9b17f6673d234840c64b2~qKrd7rdl90327403274eucas1p2n; Tue, 11 Aug 2020 08:53:05 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id D2.A1.06456.17C523F5; Tue, 11 Aug 2020 09:53:05 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200811085304eucas1p150bf23b6f183a28fbceca06b0bced5af~qKrdZOCc11585315853eucas1p1r; Tue, 11 Aug 2020 08:53:04 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085304eusmtrp1009d3c2447cf63ad5568125e233dd0f9~qKrdYWuwe1603916039eusmtrp1S; Tue, 11 Aug 2020 08:53:04 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-dd-5f325c71eb62 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 5E.3D.06017.07C523F5; Tue, 11 Aug 2020 09:53:04 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085302eusmtip18b20bc89818035a60d5f97482751c7f9~qKrbkxqD51792217922eusmtip1H; Tue, 11 Aug 2020 08:53:02 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:21 +0300 Message-Id: <20200811085246.28735-3-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSf0wTdxTPu7veXRvqjsLCC3MSmpBsmqlsmrzpNpxZtksMi8n+Ic4Nz3lB M36tBTaXbEFwzJWuQtVtwCwIGGhLxM7KD6MD6wKygp0Yo0RGiWFrFH9WCOBgjnqY/ff5+d7L N1+RNR3hk8U9+UWqJV/JNfMGrqNvLvTKZ9tfzV57oyqe2gddQDfHmlgaP/wnT5UP9jN03ZNB Zzt/1pEzXMqQw/mQoc5WG093xss4uhftZGj0XFCg2uEygaKBiEDfh+qAIvO3WappeAQUcp3W 0dz5Mzzdn2/kyPH4KtBB/0WgfvtDjg53dwFV2CR64G4RqGl0BUXHL3IUHDklUNv0ZZZODy4A Vfe3Aw1VPNFtSpUfNxzXyU1nbzHyoWOXWblv5AdBtg+4GNl3r4uR7/96lZcdfg/Iv9+sZGXv xCy/1bDN8MYuNXdPiWpZ89YOw263z84XXmiEL8JDQaYUQmVgA72I0jqcOTGziA2iSWoFtA/U 8xqZAgwdaRY08giwdbiHeVbpHq0WYtgktQA6Jwu10DTgidYaLmbw0ksYPOBiYkai5OOxc/7a 03aC9B6WT+zT2UAUOSkNDy4kx6BReh0dgXe1+SnoPdnLxrBe2oDeujCr7VqB1+qnno5E6Q8R x2tDnFZ4B/1j7qXjEvB2v1/Q8HIMHrJzWuFbwOqOU4JGqgDL6+4upTLQP3lJiF3BSi9j+5k1 mvw2tkU8TExGaRlevxsfk9lF6Oz4kdVkIx6oMGlpM/YODC/JiAv/xGmyjLNzI0sPeg7wN69d qIKU2v93NQB4IEkttublqNb0fPXz1VYlz1qcn7P6k4K8X2Dxswb/7Y92wfTwzgBIIpjjjIUb 07NNOqXEujcvACiy5kTj5qHgxybjLmXvl6qlINtSnKtaA/CCyJmTjK813vrIJOUoReqnqlqo Wp65jKhPLoX1bXNpLVuHohU9NZU3Vq1/sTqjrd7hmU+y7Zz5K+LdmDC1xb2vSN2fWf7muuzE k66So74nvi0LYxvavzOnO43elXETV37K3NzzYVVaynMzvYlMVnM339yhj4T/Lij5OnXwfeWD 845vUrM2Xfiq9ooy7a1/Pmtt36X4JndmeHa5ftmdSTNn3a2kr2QtVuU/XXXU/agDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTYRjHe885OztKi8OyevOD5ckiAmdnaj6aWkSXQxAoRR/MsqUHldxm O1OyhHSJybSZZkW35aXIS1JeSg3LWqHVFLF7qTnEkDKmeSPFSy7p2x9+/+fHA8/DkMpJypNJ 1BlFg06TxNHulH2urdc3OVods/nruC/cb7ci6P9WRoKjqJeG3JEsAj5XboPmhhsyKOzLIMBS +JuAhnIzDb8cJgqcow0E9Dyxy+HaW5McRm2DcjjfeR3B4MxPEq4WjyHotD6UwdTzxzQMz5RS YJn+gCC//hWCtrzfFBQ1NSLINrMwUnFXDmU9XjDqeEWB/UudHO5NdJHwsH0WQUHbfQQd2fOy 7d7CdPEdmVDW/IMQLpZ0kULrl8tyIe+1lRBqnI2EMPz0Ay1Y6iuR8KY/lxSqBv7QEe5RqlCD PsUork3QS8Yw7hAPahUfDCp1QLCK9w86HKIO5PzCQ+PEpMRU0eAXflSVUFGTRye/KEUn+zrs RAbqNCEzcmMwG4CbegrkZuTOKNk7CBdmzZNmxCwAjIcGyMXOcjzz0UwvdsYQvtjQTbgAzW7E 9hwr4QIebDeN353LpFxgObsHnx3IlLlEFLse5896uqKCDcYW2+5F5xpc9eDZP78bG4Krrvf9 y0o2EWf2NtGL2Qt/ujVOXEDLitGSSuQhpkjaeK2kVkkarZSii1fF6rW1aOHmj1qn6huR2bnf hlgGcUsVyVv5GKVMkyqlaW0IMyTnodjRYT+iVMRp0k6JBn2MISVJlGwocGG9AtJzRax+4YN0 xhg+kA+CYD7IP8h/C3CrFDns82glG68xisdFMVk0/J8jGDfPDJRv8itZGVqKOb+d8yd4XZ30 ZsPesi3H979XD6TvjexqXdaiiTKs/n7m4NSJkyMVPsb3PuLpm46Mfd5du3SVs7Xd3ybjjl7p cEy8jDf5OHe2HLhNbZpkLlXLIjzU/GVn1etE98ihnJJ1x4rSvS3lt6vZfXP6sN3PGtubV+QG cNZ7ARwlJWj4TaRB0vwFQ1amWAkDAAA= X-CMS-MailID: 20200811085304eucas1p150bf23b6f183a28fbceca06b0bced5af X-Msg-Generator: CA X-RootMTR: 20200811085304eucas1p150bf23b6f183a28fbceca06b0bced5af X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085304eucas1p150bf23b6f183a28fbceca06b0bced5af References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 02/24] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Link status structure keeps complicated values which are hard to represent to end user. e.g. link_speed has INT_MAX value which means that speed is unknown, link_duplex equal to 0 means 'half-duplex' etc. To simplify processing of the values in application, new dpdk function is introduced. This commit adds function which treat link status structure and format it to text representation. User may create custom link status string using format string. If format string is NULL, the function construct standard link status string. Signed-off-by: Ivan Dyukov --- MAINTAINERS | 1 + app/test/Makefile | 3 + app/test/meson.build | 2 + app/test/test_ethdev_link.c | 315 +++++++++++++++++++++++ lib/librte_ethdev/rte_ethdev.c | 160 ++++++++++++ lib/librte_ethdev/rte_ethdev.h | 32 +++ lib/librte_ethdev/rte_ethdev_version.map | 3 + 7 files changed, 516 insertions(+) create mode 100644 app/test/test_ethdev_link.c diff --git a/MAINTAINERS b/MAINTAINERS index 5e706cd7e..f4fb31ea2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -393,6 +393,7 @@ T: git://dpdk.org/next/dpdk-next-net F: lib/librte_ethdev/ F: devtools/test-null.sh F: doc/guides/prog_guide/switch_representation.rst +F: app/test/test_ethdev* Flow API M: Ori Kam diff --git a/app/test/Makefile b/app/test/Makefile index e5440774b..9f43b8c3c 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -251,6 +251,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_SECURITY) += test_security.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c test_ipsec_perf.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec_sad.c + +SRCS-$(CONFIG_RTE_LIBRTE_ETHER) += test_ethdev_link.c + ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y) LDLIBS += -lrte_ipsec endif diff --git a/app/test/meson.build b/app/test/meson.build index 56591db4e..1e6acf701 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -39,6 +39,7 @@ test_sources = files('commands.c', 'test_efd.c', 'test_efd_perf.c', 'test_errno.c', + 'test_ethdev_link.c', 'test_event_crypto_adapter.c', 'test_event_eth_rx_adapter.c', 'test_event_ring.c', @@ -199,6 +200,7 @@ fast_tests = [ ['eal_flags_misc_autotest', false], ['eal_fs_autotest', true], ['errno_autotest', true], + ['ethdev_link_status', true], ['event_ring_autotest', true], ['fib_autotest', true], ['fib6_autotest', true], diff --git a/app/test/test_ethdev_link.c b/app/test/test_ethdev_link.c new file mode 100644 index 000000000..b501deefe --- /dev/null +++ b/app/test/test_ethdev_link.c @@ -0,0 +1,315 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2020 Samsung Electronics Co., Ltd All Rights Reserved + */ + +#include +#include + +#include +#include "test.h" + + +static int32_t +test_link_status_up_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[RTE_ETH_LINK_MAX_STR_LEN + 1]; + + ret = rte_eth_link_to_str(text, sizeof(text), NULL, &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + printf("Default link up #1: %s\n", text); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 2.5 Gbit/s FDX Autoneg", + text, strlen(text), "Invalid default link status string"); + + link_status.link_duplex = ETH_LINK_HALF_DUPLEX; + link_status.link_autoneg = ETH_LINK_FIXED; + link_status.link_speed = ETH_SPEED_NUM_10M, + ret = rte_eth_link_to_str(text, sizeof(text), NULL, &link_status); + printf("Default link up #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 10 Mbit/s HDX Fixed", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + link_status.link_speed = ETH_SPEED_NUM_UNKNOWN; + ret = rte_eth_link_to_str(text, sizeof(text), NULL, &link_status); + printf("Default link up #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at Unknown speed HDX Fixed", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + /* test max str len */ + link_status.link_speed = ETH_SPEED_NUM_UNKNOWN - 1; + link_status.link_duplex = ETH_LINK_HALF_DUPLEX; + link_status.link_autoneg = ETH_LINK_AUTONEG; + ret = rte_eth_link_to_str(text, sizeof(text), NULL, &link_status); + printf("Default link up #4:len = %d, %s\n", ret, text); + RTE_TEST_ASSERT(ret > RTE_ETH_LINK_MAX_STR_LEN, + "String length exceeds max allowed value\n"); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_down_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[RTE_ETH_LINK_MAX_STR_LEN]; + + ret = rte_eth_link_to_str(text, sizeof(text), NULL, &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link down", + text, strlen(text), "Invalid default link status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_string_overflow(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + + ret = rte_eth_link_to_str(NULL, 2, "status %S, %G Gbits/s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Format string should fail, but it's ok\n"); + + ret = rte_eth_link_to_str(text, 2, "status %S, %G Gbits/s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Format string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[2] == 'Y', "String1 overflow\n"); + + ret = rte_eth_link_to_str(text, 8, NULL, + &link_status); + RTE_TEST_ASSERT(ret < 0, "Default format string should fail," + " but it's ok\n"); + RTE_TEST_ASSERT(text[8] == 'Y', "String1 overflow\n"); + + ret = rte_eth_link_to_str(text, 10, NULL, + &link_status); + RTE_TEST_ASSERT(ret < 0, "Default format string should fail," + " but it's ok\n"); + RTE_TEST_ASSERT(text[10] == 'Y', "String1 overflow\n"); + + text[1] = 'Y'; + ret = rte_eth_link_to_str(text, 1, "%S", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[1] == 'Y', "String1 overflow\n"); + + text[1] = 'Y'; + ret = rte_eth_link_to_str(text, 1, "%s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[1] == 'Y', "String1 overflow\n"); + + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_format(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + printf("status format #1: %s\n", text); + ret = rte_eth_link_to_str(text, 128, "status = %S, duplex = %D\n", + &link_status); + printf("status format #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = Up, duplex = FDX\n", + text, strlen(text), "Invalid status string1."); + + ret = rte_eth_link_to_str(text, 128, "%A", &link_status); + printf("status format #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Autoneg", + text, strlen(text), "Invalid status string2."); + + ret = rte_eth_link_to_str(text, 128, + "%G", + &link_status); + printf("status format #4: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("40.0", + text, strlen(text), "Invalid status string3."); + + ret = rte_eth_link_to_str(text, 128, + "%d %M %", + &link_status); + printf("status format #5: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("%d 40000 %", + text, strlen(text), "Invalid status string4."); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_return_value(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + ret = rte_eth_link_to_str(text, 128, "status = %S, ", + &link_status); + printf("return value #1:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_to_str(text + ret, 128 - ret, + "%A", + &link_status); + printf("return value #2:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_to_str(text + ret, 128 - ret, + ", duplex = %D\n", + &link_status); + printf("return value #3:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_to_str(text + ret, 128 - ret, + "%M Mbits/s\n", + &link_status); + printf("return value #4:ret=%u, text=%s\n", ret, text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = Up, Autoneg, duplex = FDX\n" + "40000 Mbits/s\n", + text, strlen(text), "Invalid status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_unknown_specifier(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + + ret = rte_eth_link_to_str(text, 128, "status = %", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string1 is failed\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = %", + text, strlen(text), "Invalid status string1"); + + ret = rte_eth_link_to_str(text, 128, + ", duplex = %d\n", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string2 is failed\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL(", duplex = %d\n", + text, strlen(text), "Invalid status string2"); + + ret = rte_eth_link_to_str(text, 128, + "% Mbits/s\n", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string3 is failed\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("% Mbits/s\n", + text, strlen(text), "Invalid status string3"); + + ret = rte_eth_link_to_str(text, 128, + "%w Mbits/s\n", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string4 should be ok, but it's fail\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("%w Mbits/s\n", + text, strlen(text), "Invalid status string4"); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_format_edges(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_UNKNOWN, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_HALF_DUPLEX + }; + char text[128]; + + ret = rte_eth_link_to_str(text, 4, "%S", &link_status); + printf("format edges #1: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_to_str(text, 6, "123%D", &link_status); + printf("format edges #2: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_to_str(text, 7, "%A", &link_status); + printf("format edges #3: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_to_str(text, 8, "%A", &link_status); + printf("format edges #4: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "It should ok, but it fails\n"); + return TEST_SUCCESS; +} +static struct unit_test_suite link_status_testsuite = { + .suite_name = "link status formatting", + .setup = NULL, + .teardown = NULL, + .unit_test_cases = { + TEST_CASE(test_link_status_up_default), + TEST_CASE(test_link_status_down_default), + TEST_CASE(test_link_status_string_overflow), + TEST_CASE(test_link_status_format), + TEST_CASE(test_link_status_format_edges), + TEST_CASE(test_link_status_unknown_specifier), + TEST_CASE(test_link_status_return_value), + TEST_CASES_END() /**< NULL terminate unit test array */ + } +}; + +static int +test_link_status(void) +{ + rte_log_set_global_level(RTE_LOG_DEBUG); + rte_log_set_level(RTE_LOGTYPE_EAL, RTE_LOG_DEBUG); + + return unit_test_suite_runner(&link_status_testsuite); +} + +REGISTER_TEST_COMMAND(ethdev_link_status, test_link_status); diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index d06b7f9b1..3c00ee7ee 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -2383,6 +2383,166 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) return 0; } +static int +rte_eth_link_to_str_parser(char *str, size_t len, const char *const fmt, + const struct rte_eth_link *eth_link) +{ + size_t offset = 0; + const char *fmt_cur = fmt; + double gbits = (double)eth_link->link_speed / 1000.; + static const char autoneg_str[] = "Autoneg"; + static const char fixed_str[] = "Fixed"; + static const char fdx_str[] = "FDX"; + static const char hdx_str[] = "HDX"; + static const char unknown_str[] = "Unknown"; + static const char up_str[] = "Up"; + static const char down_str[] = "Down"; + char gbits_str[20]; + char mbits_str[20]; + + /* preformat complex formatting to easily concatinate it further */ + snprintf(mbits_str, sizeof(mbits_str), "%u", eth_link->link_speed); + snprintf(gbits_str, sizeof(gbits_str), "%.1f", gbits); + /* init str before formatting */ + str[0] = 0; + while (*fmt_cur) { + /* check str bounds */ + if (offset >= len) { + str[len - 1] = '\0'; + return -EINVAL; + } + if (*fmt_cur == '%') { + /* set null terminator to current position, + * it's required for strlcat + */ + str[offset] = '\0'; + switch (*++fmt_cur) { + /* Speed in Mbits/s */ + case 'M': + if (eth_link->link_speed == + ETH_SPEED_NUM_UNKNOWN) + offset = strlcat(str, unknown_str, + len); + else + offset = strlcat(str, mbits_str, len); + break; + /* Speed in Gbits/s */ + case 'G': + if (eth_link->link_speed == + ETH_SPEED_NUM_UNKNOWN) + offset = strlcat(str, unknown_str, + len); + else + offset = strlcat(str, gbits_str, len); + break; + /* Link status */ + case 'S': + offset = strlcat(str, eth_link->link_status ? + up_str : down_str, len); + break; + /* Link autoneg */ + case 'A': + offset = strlcat(str, eth_link->link_autoneg ? + autoneg_str : fixed_str, len); + break; + /* Link duplex */ + case 'D': + offset = strlcat(str, eth_link->link_duplex ? + fdx_str : hdx_str, len); + break; + /* ignore unknown specifier + * just copy it to target str + */ + default: + str[offset++] = '%'; + fmt_cur--; + break; + + } + if (offset >= len) + return -EINVAL; + + } else { + str[offset++] = *fmt_cur; + } + fmt_cur++; + } + str[offset] = '\0'; + return offset; +} + +int +rte_eth_link_to_str(char *str, size_t len, const char *const fmt, + const struct rte_eth_link *eth_link) +{ + size_t offset = 0; + double gbits = (double)eth_link->link_speed / 1000.; + char speed_gbits_str[20]; + char speed_mbits_str[20]; + /* TBD: make it international? */ + static const char link_down_str[] = "Link down"; + static const char link_up_str[] = "Link up at "; + static const char unknown_speed_str[] = "Unknown speed "; + static const char mbits_str[] = "Mbit/s"; + static const char gbits_str[] = "Gbit/s"; + static const char fdx_str[] = "FDX "; + static const char hdx_str[] = "HDX "; + static const char autoneg_str[] = "Autoneg"; + static const char fixed_str[] = "Fixed"; + + if (str == NULL || len == 0) + return -EINVAL; + /* default format string, if no fmt is specified */ + if (fmt == NULL) { + if (eth_link->link_status == ETH_LINK_DOWN) { + if (sizeof(link_down_str) > len) + return -EINVAL; + return strlcpy(str, link_down_str, len); + } + + /* preformat complex strings to easily concatinate it further */ + snprintf(speed_mbits_str, sizeof(speed_mbits_str), "%u %s ", + eth_link->link_speed, mbits_str); + snprintf(speed_gbits_str, sizeof(speed_gbits_str), "%.1f %s ", + gbits, gbits_str); + + offset = strlcpy(str, link_up_str, len); + /* reserve one byte to null terminator */ + if (offset >= len) + return -EINVAL; + /* link speed */ + if (eth_link->link_speed == ETH_SPEED_NUM_UNKNOWN) { + offset = strlcat(str, unknown_speed_str, len); + if (offset >= len) + return -EINVAL; + } else { + if (eth_link->link_speed < ETH_SPEED_NUM_1G) { + offset = strlcat(str, speed_mbits_str, len); + if (offset >= len) + return -EINVAL; + } else { + offset = strlcat(str, speed_gbits_str, len); + if (offset >= len) + return -EINVAL; + } + } + /* link duplex */ + offset = strlcat(str, eth_link->link_duplex ? + fdx_str : hdx_str, len); + if (offset >= len) + return -EINVAL; + /* link autonegotiation */ + offset = strlcat(str, eth_link->link_autoneg ? + autoneg_str : fixed_str, len); + if (offset >= len) + return -EINVAL; + /* Formatted status */ + } else + offset = rte_eth_link_to_str_parser(str, len, fmt, eth_link); + + return offset; +} + int rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats) { diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 2090af501..4e8fdc891 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -323,6 +323,7 @@ struct rte_eth_link { #define ETH_LINK_UP 1 /**< Link is up (see link_status). */ #define ETH_LINK_FIXED 0 /**< No autonegotiation (see link_autoneg). */ #define ETH_LINK_AUTONEG 1 /**< Autonegotiated (see link_autoneg). */ +#define ETH_LINK_MAX_STR_LEN 60 /**< Max length of default link string. */ /** * A structure used to configure the ring threshold registers of an RX/TX @@ -2295,6 +2296,37 @@ int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); */ int rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *link); +/** + * Format link status to textual representation. This function treats all + * special values like ETH_SPEED_NUM_UNKNOWN, ETH_LINK_DOWN etc. and convert + * them to textual representation. + * + * @param str + * A pointer to a string to be filled with textual representation of + * device status. At least ETH_LINK_MAX_STR_LEN bytes should be allocated to + * store default link status text. + * @param len + * Length of available memory at 'str' string. + * @param fmt + * Format string which allows to format link status. + * If NULL is provided, default formatting will be applied. + * Following specifiers are available: + * - '%M' link speed in Mbits/s + * - '%G' link speed in Gbits/s + * - '%S' link status. e.g. Up or Down + * - '%A' link autonegotiation state + * - '%D' link duplex state + * @param eth_link + * Link status provided by rte_eth_link_get function + * @return + * - Number of bytes written to str array. + * - (-EINVAL) if size of target buffer is too small for the string + * + */ +__rte_experimental +int rte_eth_link_to_str(char *str, size_t len, const char *const fmt, + const struct rte_eth_link *eth_link); + /** * Retrieve the general I/O statistics of an Ethernet device. * diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map index 715505604..afdfd59d6 100644 --- a/lib/librte_ethdev/rte_ethdev_version.map +++ b/lib/librte_ethdev/rte_ethdev_version.map @@ -241,4 +241,7 @@ EXPERIMENTAL { __rte_ethdev_trace_rx_burst; __rte_ethdev_trace_tx_burst; rte_flow_get_aged_flows; + + # added in 20.11 + rte_eth_link_to_str; }; From patchwork Tue Aug 11 08:52:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75389 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB488A04AF; Tue, 11 Aug 2020 10:53:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB3C31C0B8; Tue, 11 Aug 2020 10:53:10 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 9C34C1C07D for ; Tue, 11 Aug 2020 10:53:07 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085307euoutp01ea190603586ad734e478421b5bf76b4a~qKrfynGT-0892608926euoutp01E; Tue, 11 Aug 2020 08:53:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085307euoutp01ea190603586ad734e478421b5bf76b4a~qKrfynGT-0892608926euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597135987; bh=dI+oiTsEKRnvivBB04vQNjKvj/2HACon7g1KeTDyHHI=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Pz4RrXKPbN4/M2c9tr05Yk8NtguSaSbUzo6xA+d9R3uRziZZBlCKis3pRKlXmTEHZ JmOJ8UlF0U4tObriumalQ3KzAljE0ZXjaVcDmJ1DIs4KptrKHRr4o7Q3vbXKKcFO98 SVriL8E6sZbXbchVUL7+nYitMQpTGtXMiAXD2Aag= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085307eucas1p134aece58dc4de4db87cd497976b86cc5~qKrfmcV_01584815848eucas1p1i; Tue, 11 Aug 2020 08:53:07 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 21.1C.05997.37C523F5; Tue, 11 Aug 2020 09:53:07 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085306eucas1p2028e8b747d3a1b5d659e1e554a4aca84~qKrfKk7_v3145931459eucas1p20; Tue, 11 Aug 2020 08:53:06 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085306eusmtrp16c5bc19c51767d6fe2b1bb3c525fc0c3~qKrfJp3TC1606216062eusmtrp1B; Tue, 11 Aug 2020 08:53:06 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-8e-5f325c733453 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 21.4D.06017.27C523F5; Tue, 11 Aug 2020 09:53:06 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085304eusmtip14073110d4a3a4567c33d352a704d85f8~qKrdY9lq-1792217922eusmtip1I; Tue, 11 Aug 2020 08:53:04 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:22 +0300 Message-Id: <20200811085246.28735-4-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf0yUdRzH93me557n4fLs8XTjM3OyzunKFMFqfjSLdK6eP2w526o5la54 htRxsHtAo7XJriI9LkIkKmmIUEl31Gked4SacCWnHUiyDDEQxmqXdAjiMeI6KI4H13+v94/v 9/PZd1+RNX7ELxVzrAWKzWq2mHg952ufurJW3b0+M63PpyNPRw3Q0M16lgYr+3kqHXuXoeuu DDrn/0xHFQPFDJVV3GHI3+DgKTJo5+j2uJ+hvvMhgY512wUaD4QF+qCrGigcH2bp09q7QF01 TTqaamvhaTRex1FZ7BrQh95LQEHnHY4qv2sGKnFINPbVSYHq+5bT+OAljkK9ZwRqnLjKUlPH NNCRoAeos+Rf3dMPyrHaL3Ry/blbjHz0xFVWbu+tEmTn5RpGPn27mZFHv7/Gy2VeF8g/DZWy svv3v/kd+l36zVmKJWe/Ylv31Cv6fd1DQ0J+ZPubEz0n2GKIbXZAkojSY9jY+BvvAL1olBoA wz8EGE1EAZurugRN3AWMzAR09460ButAC04C2iva51sTgG7XJ1yixUsPYehQzdxdS6TTPPrj PUwiWCxtwLjrwhxz0kp8b7gXEmyQNuLU+NesNiIF3ada5zhJ2oTu6oE5NkrLsed4lNE6HSJG 4laNt+GvtR7QeDEOB72CxsswdNTJJZZA6X3AI74zgibKAd+pHplvZaD3ryuzLIqs9DB6WtZp 9hYMNHVyCRulhXh9ZFHCZmexwvcxq9kGPFRi1NombL3cPW8jTv+zQLNl9Pa3zr/PecBB+yko h5Rj/8+qBXBBslKo5mYr6nqrciBVNeeqhdbs1Nfycr+F2c8amglGm6El/moAJBFMCwz5T6Rn GnXm/WpRbgBQZE1LDFs7Q3uNhixz0VuKLS/TVmhR1AA8IHKmZMOjdbf2GKVsc4HyhqLkK7Z7 KSMmLS2GDdPusxfSq9aMObNw7O2RWJljVSxndOvN/rwbRW1P/rz7dcufvHJ2e49fOXhjYQwP 35cvR9P2Hl7z7LDnxZmLvxgzTMkvrXh5j2Xgmecvrow993n5l9sCKZGNO9fuCpvSHrG3/fiH P7V0S/jxycnJ+y0rNhU0dAvRFzqdQuWBqsiybw76TJy6z5y+mrWp5v8AmMZ7AagDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTYRjHfc85O7vU6jSt3iQqR2YUzc7U9mim0afzoSjo8qE0G3pQ0W12 zgwtCLtoMS+ZSlDG8oJks7uaF6x0kaZTRM0bZZkIkZmZaUxdlpf69oPf///wwPPISNUvylMW azTzglEfr6YVlGOuaWCHEKaN2Jn2wQcetVoRDH0oJmEwb4CG9PHLBPTZQqGu6rYEcj6mEJCV 84OAqlILDaODFykYm6gi4P1zhxRudV6UwoT9sxQy2/MRfHaNkHCz4CeCdmulBKYbamn47iqi IGumG8G1ijcImjJ+UJBXU40gzcLA+L27Uih+vwEmBt9Q4Ogvl8L9qQ4SKlt/I7je9AhBW9of yV4vbqagRMIV130huNzCDpJr7L8h5TKarQT3ZKya4L6/6Ka5rAob4lqG0kmubNhJH1Ic1wQL pkQzvynGJJr3qE+woNWwgaDR+gdqWD9deJA2QO0bEhzFx8ee4QXfkFOamM6hIWnC6P6kqd5C MgXNBFuQXIYZf1zfVIQsSCFTMSUIN4+USixINi8w/jpMLmXcsavHQi9lfiI8XD6+KGhmK3Zc tRILwoN5R+OuKxeoBeHO6LDL9pJYYIrxxqkj/WiBlUwgnp548G/qRlz2uH6R5UwQLsv/uMgq JhZfGKihl3gD7r0zSWSjFQXIzYY8+ETREG0QtRpRbxATjdGaSJPhKZq/+bPG6YpqZBk7bEeM DKmXKxN2sxEqif6MmGywIywj1R7KfW2OkypllD75LC+YIoTEeF60o4D5Ba+TnqsjTfMfZDRH sAGsDgJZnZ/Obxeo1yqvMg1hKiZab+bjeD6BF/73CJncMwVZ16+zn195iSlp+WZL2PJJztaq 7neHrzI4jzq9l0VvL/ud5Eq6tzr14fCanDhlT8DcpPfpxsaZg3mTmW8Vrl+dHaNCX2lY0mxH pFfMlDO4t8f6ajZX4vQ44kb5WFd2Ra7bfIA5Efo6SNFcPKeZtNVmpsqN2TWv8e5jyeckJXHe n9SUGKNnt5GCqP8LOHBGfAkDAAA= X-CMS-MailID: 20200811085306eucas1p2028e8b747d3a1b5d659e1e554a4aca84 X-Msg-Generator: CA X-RootMTR: 20200811085306eucas1p2028e8b747d3a1b5d659e1e554a4aca84 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085306eucas1p2028e8b747d3a1b5d659e1e554a4aca84 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 03/24] app: UNKNOWN link speed print X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications and docs Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 13 ++++++----- app/test-pipeline/init.c | 11 ++++----- app/test-pmd/config.c | 23 ++++++++++++------- app/test-pmd/testpmd.c | 12 ++++------ app/test/test_ethdev_link.c | 6 ++--- app/test/test_pmd_perf.c | 17 ++++++-------- doc/guides/sample_app_ug/link_status_intr.rst | 10 ++++---- 7 files changed, 46 insertions(+), 46 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab..a315f22ce 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -672,6 +672,7 @@ show_port(void) struct rte_eth_dev_info dev_info; struct rte_eth_rxq_info queue_info; struct rte_eth_rss_conf rss_conf; + char link_status_text[100]; memset(&rss_conf, 0, sizeof(rss_conf)); @@ -685,12 +686,12 @@ show_port(void) printf("Link get failed (port %u): %s\n", i, rte_strerror(-ret)); } else { - printf("\t -- link speed %d duplex %d," - " auto neg %d status %d\n", - link.link_speed, - link.link_duplex, - link.link_autoneg, - link.link_status); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), + "\t -- link speed: %M, duplex: %D," + " auto neg: %A, status: %S\n", + &link); + printf("%s", link_status_text); } printf("\t -- promiscuous (%d)\n", rte_eth_promiscuous_get(i)); diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c index 67d54ae05..b85db3826 100644 --- a/app/test-pipeline/init.c +++ b/app/test-pipeline/init.c @@ -155,7 +155,7 @@ static void app_ports_check_link(void) { uint32_t all_ports_up, i; - + char link_status_text[50]; all_ports_up = 1; for (i = 0; i < app.n_ports; i++) { @@ -173,12 +173,11 @@ app_ports_check_link(void) all_ports_up = 0; continue; } - - RTE_LOG(INFO, USER1, "Port %u (%u Gbps) %s\n", + rte_eth_link_to_str(link_status_text, sizeof(link_status_text), + "(%G Gbps) %S", &link); + RTE_LOG(INFO, USER1, "Port %u %s\n", port, - link.link_speed / 1000, - link.link_status ? "UP" : "DOWN"); - + link_status_text); if (link.link_status == ETH_LINK_DOWN) all_ports_up = 0; } diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index a7112c998..a34aed123 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -564,6 +564,7 @@ port_infos_display(portid_t port_id) char name[RTE_ETH_NAME_MAX_LEN]; int ret; char fw_version[ETHDEV_FWVERS_LEN]; + char link_status[70]; if (port_id_is_invalid(port_id, ENABLED_WARN)) { print_valid_ports(); @@ -604,10 +605,11 @@ port_infos_display(portid_t port_id) } else printf("\nmemory allocation on the socket: %u",port->socket_id); - printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down")); - printf("Link speed: %u Mbps\n", (unsigned) link.link_speed); - printf("Link duplex: %s\n", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_to_str(link_status, sizeof(link_status), + "\nLink status: %S\n" + "Link speed: %M Mbps\n" + "Link duplex: %D\n", &link); + printf("%s", link_status); if (!rte_eth_dev_get_mtu(port_id, &mtu)) printf("MTU: %u\n", mtu); @@ -730,6 +732,8 @@ port_summary_display(portid_t port_id) struct rte_eth_link link; struct rte_eth_dev_info dev_info; char name[RTE_ETH_NAME_MAX_LEN]; + char status_text[6]; + char speed_text[12]; int ret; if (port_id_is_invalid(port_id, ENABLED_WARN)) { @@ -750,12 +754,14 @@ port_summary_display(portid_t port_id) if (ret != 0) return; - printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\n", + rte_eth_link_to_str(status_text, 6, "%S", &link); + rte_eth_link_to_str(speed_text, 12, "%M", &link); + printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %sMbps\n", port_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], mac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name, - dev_info.driver_name, (link.link_status) ? ("up") : ("down"), - (unsigned int) link.link_speed); + dev_info.driver_name, status_text, + speed_text); } void @@ -3899,7 +3905,8 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) ret = eth_link_get_nowait_print_err(port_id, &link); if (ret < 0) return 1; - if (rate > link.link_speed) { + if (link.link_speed != ETH_SPEED_NUM_UNKNOWN && + rate > link.link_speed) { printf("Invalid rate value:%u bigger than link speed: %u\n", rate, link.link_speed); return 1; diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 4989d22ca..1d294641b 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2991,6 +2991,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status[ETH_LINK_MAX_STR_LEN]; printf("Checking link statuses...\n"); fflush(stdout); @@ -3010,14 +3011,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. speed %u Mbps- %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status, + sizeof(link_status), NULL, &link); + printf("Port %d %s\n", portid, link_status); continue; } /* clear all_ports_up flag if any link down */ diff --git a/app/test/test_ethdev_link.c b/app/test/test_ethdev_link.c index b501deefe..8e2a8be13 100644 --- a/app/test/test_ethdev_link.c +++ b/app/test/test_ethdev_link.c @@ -19,7 +19,7 @@ test_link_status_up_default(void) .link_autoneg = ETH_LINK_AUTONEG, .link_duplex = ETH_LINK_FULL_DUPLEX }; - char text[RTE_ETH_LINK_MAX_STR_LEN + 1]; + char text[ETH_LINK_MAX_STR_LEN + 1]; ret = rte_eth_link_to_str(text, sizeof(text), NULL, &link_status); RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); @@ -51,7 +51,7 @@ test_link_status_up_default(void) link_status.link_autoneg = ETH_LINK_AUTONEG; ret = rte_eth_link_to_str(text, sizeof(text), NULL, &link_status); printf("Default link up #4:len = %d, %s\n", ret, text); - RTE_TEST_ASSERT(ret > RTE_ETH_LINK_MAX_STR_LEN, + RTE_TEST_ASSERT(ret < ETH_LINK_MAX_STR_LEN, "String length exceeds max allowed value\n"); return TEST_SUCCESS; } @@ -66,7 +66,7 @@ test_link_status_down_default(void) .link_autoneg = ETH_LINK_AUTONEG, .link_duplex = ETH_LINK_FULL_DUPLEX }; - char text[RTE_ETH_LINK_MAX_STR_LEN]; + char text[ETH_LINK_MAX_STR_LEN]; ret = rte_eth_link_to_str(text, sizeof(text), NULL, &link_status); RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index 352cd4715..9d38382c2 100644 --- a/app/test/test_pmd_perf.c +++ b/app/test/test_pmd_perf.c @@ -126,6 +126,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status[ETH_LINK_MAX_STR_LEN]; printf("Checking link statuses...\n"); fflush(stdout); @@ -146,16 +147,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) { - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - if (link_mbps == 0) - link_mbps = link.link_speed; - } else - printf("Port %d Link Down\n", portid); + if (link.link_status && link_mbps == 0) + link_mbps = link.link_speed; + + rte_eth_link_to_str(link_status, + sizeof(link_status), NULL, &link); + printf("Port %d %s\n", portid, link_status); continue; } /* clear all_ports_up flag if any link down */ diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst index 04c40f285..2f7eb61c2 100644 --- a/doc/guides/sample_app_ug/link_status_intr.rst +++ b/doc/guides/sample_app_ug/link_status_intr.rst @@ -158,6 +158,7 @@ An example callback function that has been written as indicated below. { struct rte_eth_link link; int ret; + char link_status[RTE_ETH_LINK_MAX_STR_LEN]; RTE_SET_USED(param); @@ -169,11 +170,10 @@ An example callback function that has been written as indicated below. if (ret < 0) { printf("Failed to get port %d link status: %s\n\n", port_id, rte_strerror(-ret)); - } else if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + } else { + rte_eth_link_to_str(link_status, sizeof(link_status), NULL, &link); + printf("Port %d %s\n\n", port_id, link_status); + } } This function is called when a link status interrupt is present for the right port. From patchwork Tue Aug 11 08:52:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75390 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E0E1A04AF; Tue, 11 Aug 2020 10:54:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 66D1D1C0C9; Tue, 11 Aug 2020 10:53:13 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 871C71C0B2 for ; Tue, 11 Aug 2020 10:53:09 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085309euoutp017ec762c0df60e8aae3f91f1999b418ff~qKrhnZSIV0892608926euoutp01H; Tue, 11 Aug 2020 08:53:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085309euoutp017ec762c0df60e8aae3f91f1999b418ff~qKrhnZSIV0892608926euoutp01H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597135989; bh=1R9omrZ5fAPdKYuUkOS/6cuY8buXbZ+pEv8UB5bwG/w=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=GlHUkEXB6M/trMMwPyGmYyyzJ1GVY5Bcug9aubZ6R36xTOYSKD5OJ/d2asY5ZIkCb Qcxb7mySrmblrmQyke/DVbnHH4yXY2nLekNbfvxDP2dSxj+1qCNG7x6RBqXjQR/q6E 2Jet5+B+Evzk6O4OpIWbCNe9uM18XqmuuJyTXKqU= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200811085309eucas1p2acb05bdda71007a9e3abb21d860c3363~qKrhaniMx0929809298eucas1p2y; Tue, 11 Aug 2020 08:53:09 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 57.A1.06456.57C523F5; Tue, 11 Aug 2020 09:53:09 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085308eucas1p2cf3b04f5745c2b0d525b6c57bb8e6876~qKrhCZOy80326603266eucas1p2u; Tue, 11 Aug 2020 08:53:08 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085308eusmtrp17bbd4587c4757d013b242437939d7c79~qKrhBeZQq1603916039eusmtrp1Z; Tue, 11 Aug 2020 08:53:08 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-ec-5f325c75d44d Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 34.4D.06017.47C523F5; Tue, 11 Aug 2020 09:53:08 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085306eusmtip1d03c91ddb9a4c293e8ad352950c442c6~qKrfKSL0A1849018490eusmtip10; Tue, 11 Aug 2020 08:53:06 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:23 +0300 Message-Id: <20200811085246.28735-5-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSe0xTdxTOuff23ku15lpJPFMmoYnGaaYDXHLEbeheucn+MfEPjGGyDu7Q CBV7qQ8yE6YGTUHKK2MTVpH6YOBkaC3gwGizWKAggkF8IOArRh1QwDpUnKNclv33ne/x+05O fiJrLOQXiFstmYrVYk4z8XrOc+Xl1fdtiTFJH7z9haXadifQ/X4XS4Mld3nKDRxg6GZ1PDXV l+uoaCCbofyiUYbqq+w8/TW4j6PhsXqG+pr9Ah3p3ifQmPexQIc7y4AeTz5l6eeKcaBO53kd vbx8gaeRyUqO8l/1ADncLUC+vFGOShobgHLsEgV+PSWQq28RjQ22cOS/dU6g08Euls63vwEq 9NUCdeS81a2Nkl9VnNDJrqYnjFx8rIuVr9z6UZDzWp2MXDfcwMgjF3t4Od9dDXLb/VxWrnk4 wa/Xb9J/lKKkbd2pWFd+8o1+S8uZXRltwu4Hxy/z2eDh7SCKKK3C1sZkO4SJRqkKsPmPRDvo p/BzwMGOAkYTxgEPBNNCOOR3lQZ4zXQK8GTNb6ANQcBnnsB0gpeWov+QkwkJ4VIdj/WTvdPC POkzdPf/xIWqOWkx+s4sCdEGaTXeKCzVaQ2RWPP7JTaEw6Q4rCkbYLUtFmHv0efTb6LULmJx XSurBT7H08V3ZsLz8KnPLWg4Av3FeZwWOAhY6DknaEMB4P6yoRlXPLqfXRVCG7HSe1h7YaVG r8Oe0SCj3WgO3hyaG6LZKVjkKWU12oCHcoya24SXWrtnaMQ3r2drtIxVD5pY7T7NgM6L5XwB RB75v6sCoBrmKzY1PVVRoy3KrhWqOV21WVJXJG9PPwtTH9X/j2+sAYLd33pBEsE025CxJjrJ qDPvVPekewFF1hRu+LTDv9loSDHvyVKs25OstjRF9cJCkTPNN8RWPvnaKKWaM5VtipKhWP9T GTFsQTZYi9yxWY4dxxsH+ieyK9fGV0Ts37xqdezkNXNU4se9KeN3/nx3ONLbknHjumX4HWNb 3tC9mJIRn/DDxsXr53jWfD/Qt2wiEPFF+1cbvvvwYLgty6FmlndFJTge6btfJH+Z4O0Rq9W9 tk7+aHnu6xcNSQm3Zy2PUv/OdDk6yjrj4naMx5g4dYs5ehlrVc3/AqnOcLWkAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSbUhTYRjtvffubkqLyzJ6M6wcZBE1u9O5x7ISK7hBaBH+Sc1GXVTa3Nid nz/CaVkuszSpzFgrE00l+5g6wyIl0lpmJmqSppgilfjZh5ZZm9a/h3POc54D55GQsmnKW5KQ aOKNiRqtnPaknPPNfVtM0crYreOX/KD6lRXB4IcSEgYK+2g4N3GKgHcVu6Ch7roICvozCMgr mCSgrtxCw+hAJgVjU3UE9D52iuHa20wxTDWNiOF8WzGCkbnPJBTZphG0WWtEMNv4iIbxuVsU 5P3sRHDB3oKgOXeSgsJ6B4JsCwMTd8rEUNK7BqYGWihw9jwUQ9W3dhJqXv1GkN9cjaA1+48o 1Jf7aSsVcSUNnwju0s12knvec1nM5b6wEtz9MQfBjT/ppLk8ewXiXg6eI7nKoRn6gOdhRYhR n2Ti18XrBdMOeRQLSgUbDAplYLCCDVDHbFOq5P47Q47z2oRk3ui/86givuVuiuGlOPXj7UY6 A9XSFuQhwUwgLrkysTDLmFKEv9vCLUjiwjH+MkQuSpbjuS6LS+Lpkkwj/GO4mnATNLMRO89a CTfhxbyncccZM+UmljO7sf3DVcptRDHrcfNdPzcsZYJxV/4V0aLpWlx57+nCAQ9mG64s7icX MyRgc1/9vzxrcPeNr8RFtMyGllQgLz5J0MXpBKVC0OiEpMQ4xTG97gFyFV77fNbuQJaxQ02I kSD5UqlhOxsrE2mShTRdE8ISUu4lDWt1HpFJj2vS0nmjPtaYpOWFJqRy5csnvVcc07veJ9EU y6pYNQSz6gB1QBDIV0rPMo3RMiZOY+JP8LyBN/7fIyQe3hloj+dqx3RRRGfVtcKeGS4kJlC7 b8Jgvr3qNRmaExGVF+LbkSJKXV0ZJek2OdJb6tRHDZsjE3zC3rQrHJk54eVFg3ue5h40Z+09 YN2uihz2k893qOqXmkfnzeNMypSWrS3r/yWtTo7cEeMozDqZjX7sOz25/5m9eIPTp+BRTlCv WE4J8Rp2E2kUNH8BTqtZBQYDAAA= X-CMS-MailID: 20200811085308eucas1p2cf3b04f5745c2b0d525b6c57bb8e6876 X-Msg-Generator: CA X-RootMTR: 20200811085308eucas1p2cf3b04f5745c2b0d525b6c57bb8e6876 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085308eucas1p2cf3b04f5745c2b0d525b6c57bb8e6876 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 04/24] net/ixgbe: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov Reviewed-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 248f21d14..34a171116 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4300,11 +4300,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, switch (link_speed) { default: case IXGBE_LINK_SPEED_UNKNOWN: - if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T || - hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L) - link.link_speed = ETH_SPEED_NUM_10M; - else - link.link_speed = ETH_SPEED_NUM_100M; + link.link_speed = ETH_SPEED_NUM_UNKNOWN; break; case IXGBE_LINK_SPEED_100_FULL: From patchwork Tue Aug 11 08:52:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75391 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D186A04AF; Tue, 11 Aug 2020 10:54:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B27321C0D1; Tue, 11 Aug 2020 10:53:14 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id EE1301C0C0 for ; Tue, 11 Aug 2020 10:53:11 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085311euoutp01baa57c377e4fc6730dc06e21ce9c63b3~qKrjzubKY0892608926euoutp01J; Tue, 11 Aug 2020 08:53:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085311euoutp01baa57c377e4fc6730dc06e21ce9c63b3~qKrjzubKY0892608926euoutp01J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597135991; bh=zbg2xoSaiDgck4H57R7Z3rwqX+vJJlCAoA2nccHDMek=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=vcIcjklECh6yaypIPksw5jbiaQpRJtlJi/UE1XmnJjDa67rzdvbFeVj/RHZiLXP9m WoDL7PBUe16zgJKXGq8od20eesEiiC7czu5ryZueU0CpWvUa/PUh/JKEQuOA3NmZyD SsF+evBpEoYhWwos9IkSA2DeSBJd6KbSrdgeolYI= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200811085311eucas1p2eb91c7c0040883fc6a0a7f0b8b0b71ff~qKrjbBM0J0327403274eucas1p26; Tue, 11 Aug 2020 08:53:11 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id B4.1C.05997.77C523F5; Tue, 11 Aug 2020 09:53:11 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200811085310eucas1p148e7b8704bc9eff714520b96b24d9df0~qKri0qdTP1584215842eucas1p11; Tue, 11 Aug 2020 08:53:10 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200811085310eusmtrp21912fb25aac700ff1340bd5fd9b3327f~qKriylKJh2198021980eusmtrp2Q; Tue, 11 Aug 2020 08:53:10 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-9a-5f325c77fec7 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 11.0B.06314.67C523F5; Tue, 11 Aug 2020 09:53:10 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085308eusmtip15fac9f39704bad870124f1ee7587b45f~qKrg-qpO01666316663eusmtip1E; Tue, 11 Aug 2020 08:53:08 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:24 +0300 Message-Id: <20200811085246.28735-6-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSb0xTZxTGc+69vffSUHMtEt84Ilo18U+GwDQ5m0YcIeYmm9FolMToWJ03 gFIgLX/m9mGVEWSFoTCYQRQZzIBUx9QKpUGD/QDSFhkEAhqUgjiUzSIVAroyRntr9u33POc8 7/uek5en1RXsKj41PUvSp2vTNKySae54+/DD3KOxSdG+P1XY5KoGHHtaR6O7/AmLRa/zKRxq jMO2lksKLBsxUlhSNk1hS4OJxb/deQx6vC0UDt91cnixL49Dr32Cwx97qgAnfJM0Vta8Aeyp vqPAt/dtLE75ahkseTcAeM7yALCzeJrB8lYrYIFJwNfX6jmsG16NXvcDBp2PbnN4fbaXxjuu BcDSzibA7oJFxe614ruaqwqxru0lJf70Sy8tdjz6mROLu6op8abHSolT9wZYscTSCKJjrIgW zePz7H7lEeXOE1Jaao6k37rrS2VKYe9jLvOPZV8322ooI1wONUEIT4RtpMz9A2sCJa8WGoB0 /HZZIYsZIEVWDyWLN0C6+02cCfhAxDSRKPv1QPoqz4AsZoF0OeZY/7mssJE4C6sD6RXCTZa0 +AYpfyFMiCe3at2cnxlhAymuMDN+Vgkfk97GNkZ+VCQx/95O+zlE+ISYq0YCrBZWk8ErM4FD ieDiSWmlF+RAAnHcm6dlDiOTnRZO5giy2HolGDgLpLT5NieL80C+r3oV7Iojlr8eBoajhU2k ybZVtj8lPc8dtDzzMjL0arnfppewrPlC0FaRwgK13K0h7V19QZuQhX+C+xWXxnq/xbtAjIvj 9HmIvPj/XTUAjbBSyjbokiVDbLqUG2XQ6gzZ6clRX2XobsHSZ3X+2zljBZvvuB0EHjShqswd MUlqhTbHcFpnB8LTmhWq+G7nF2rVCe3pbyR9RpI+O00y2OEDntGsVH1U+/KYWkjWZkmnJClT 0r+vUnzIKiMkzWfAnrDusLzRF+H5XLQvcS65K6+j6pA3f3fUr+J3UJ+65fDoyEG3Y03llhun 1sSFNiUc2DHgGT60Z/uTiEjxSIp5sPBztFgZy/YDz0/uq4jNnY2si7r2TDKus6S96Oczpbmd uvKZ2inv5vCznrmIyazP9i7EuOa/tbe51tumj2sYQ4o2ZjOtN2j/A2+sNW+oAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdnYUF6dp9McPVoNKjE6dme2dlcU+1IG+BH0Quq2hJ5Xc JjtTsoJ0RMqmVmZBaeYl01SYl/KGhY5Sc4XNSLtoSpSiK+clu5hdvNC3H8/zXh54X4ZUzlLB TILJKlpMhkQV7U+5/3QObkk5qtZv8w2tBeezQgQf3peSMJw3SINj8gIBryv3QGtjgQxyh9II yMmdIqCxwk7D52EbBRPTjQQMPHTL4WavTQ7TrlE5ZPfkIxidHyfhRtEMgp7CBzL42d5Cg2++ hIKcuVcILt3vQtCZNUVBXnMTgot2FibvlcuhdCAEpoe7KHC/qZdD9ayHhAfPfiO40ulE8Pzi X9ne9cJcUZlMKG0dI4SrxR5S6HhzXS5kPS0khNqJJkLwPXpFCzn3K5HQ/cFBClUff9AH/Q9z uyzmZKu4Lt4sWXerjvCg5ngtcOrtWo4P1xyLVEeotkbtihUTE1JEy9aoE1x8puetPOnFytMN LUVEGroVYEcMg9nt2D4abUf+jJItQ9hxp1y2rGPs/Ujakd8CBuL5Pju9XDODcEbujGzRoNlQ 7M4sJBaNIPYdjV9mpFOLRiCrw3Ulw/JFptgNOOta1ZKuYLXYU9lKLU9di6tq2pY2+LGRuCp/ aImVbAJOH2ymlzkE99/+SlxGK4vQikoUJCZLxjijxHOSwSglm+K4GLOxDi2cvKHjZ30T6q09 5EIsg1QBiqSdvF4pM6RIqUYXwgypClLonruPKxWxhtQzosWstyQnipILRSwEvEIGr44xLzyQ yarnI3gNaHlNuCZ8B6jWKDLZ9qNKNs5gFU+JYpJo+d9HMH7BaUiv+3v9V1hNpHagN3CE//Q2 VPLWFIwJ2rD9fQ3eAc634lRLhimx795IvzP7bitmgudDzOTm/pMh/l9s9W2bur0PneURzSUb h7p9qw9AraP4kO5s7b7LhvHvsz2r/rAlE3N7K2ibPXqq2hPwa6p4usDIfTu45/zjfNcTzbnM PE5FSfEGPoy0SIZ/wCFY+ggDAAA= X-CMS-MailID: 20200811085310eucas1p148e7b8704bc9eff714520b96b24d9df0 X-Msg-Generator: CA X-RootMTR: 20200811085310eucas1p148e7b8704bc9eff714520b96b24d9df0 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085310eucas1p148e7b8704bc9eff714520b96b24d9df0 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 05/24] net/i40e: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c | 5 ++++- drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 472ce2a9e..f718356b5 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2891,7 +2891,10 @@ update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link, link->link_speed = ETH_SPEED_NUM_40G; break; default: - link->link_speed = ETH_SPEED_NUM_NONE; + if (link->link_status) + link->link_speed = ETH_SPEED_NUM_UNKNOWN; + else + link->link_speed = ETH_SPEED_NUM_NONE; break; } } diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index eca716a6a..cf931bf9c 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2163,15 +2163,15 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, new_link.link_speed = ETH_SPEED_NUM_40G; break; default: - new_link.link_speed = ETH_SPEED_NUM_NONE; + if (vf->link_up) + new_link.link_speed = ETH_SPEED_NUM_UNKNOWN; + else + new_link.link_speed = ETH_SPEED_NUM_NONE; break; } /* full duplex only */ new_link.link_duplex = ETH_LINK_FULL_DUPLEX; - new_link.link_status = vf->link_up && - new_link.link_speed != ETH_SPEED_NUM_NONE - ? ETH_LINK_UP - : ETH_LINK_DOWN; + new_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN; new_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); From patchwork Tue Aug 11 08:52:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75392 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80909A04AF; Tue, 11 Aug 2020 10:54:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE1F31C0D8; Tue, 11 Aug 2020 10:53:15 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id BB3D41C0CF for ; Tue, 11 Aug 2020 10:53:13 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085313euoutp01caba7c4cf2d96cd8d6df9dc379f6217e~qKrlgLQMK0826508265euoutp01l; Tue, 11 Aug 2020 08:53:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085313euoutp01caba7c4cf2d96cd8d6df9dc379f6217e~qKrlgLQMK0826508265euoutp01l DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597135993; bh=8FgdUe6Aml3rB/AWNSgZoZqeJOx9OS3/lqpbs6iX2+c=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=B0ZuXGdvEDHd3IBs0ZeGIPK7otCrpLv+iS2Q6x4FGmCmn1nt7qcju2Hq0AvET3vZz +EUx2ZRGvl9Hj/4EVe6oj0FJwiinB7KzjrXLcK43fPLOn/b8t+y1SApJhcAJDEC/+W 1WGddKsYu0CX9lOjawrOQFLBm9CkOmETq1c85NyA= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200811085313eucas1p25dee6e12f1ea0a3bef948d2706f8c5d0~qKrlGf02j3145931459eucas1p2-; Tue, 11 Aug 2020 08:53:13 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id D7.1C.05997.87C523F5; Tue, 11 Aug 2020 09:53:12 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200811085312eucas1p178f45d37ab3a8fa4da5885d5a86668e3~qKrknpgYP1585815858eucas1p1r; Tue, 11 Aug 2020 08:53:12 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085312eusmtrp1272bb61c16c61c243517b221f1ddfd31~qKrkm3twQ1606216062eusmtrp1K; Tue, 11 Aug 2020 08:53:12 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-a1-5f325c782cba Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 47.4D.06017.87C523F5; Tue, 11 Aug 2020 09:53:12 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085310eusmtip16a440abc509add36e7ec17b46ecc994b~qKriwu2Tc1725317253eusmtip1h; Tue, 11 Aug 2020 08:53:10 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:25 +0300 Message-Id: <20200811085246.28735-7-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSW1ATZxTH/XY3u0vG6Bqtnqr1sqUzrZ2iaB+O1SnadnTfdHzqdFowlDWG BmSyIGr7EMVB5RKFUKugAcM0IDBSFQlkoCqOgoaLQRG8x8tIsUUuohYK2iQbx7ffOf/zP/8z 33w8rS9gZ/Om5FTZkmwwi6yWqb002vHZtu+Xxi2xu1ZgdauD4MN7pTT6C+6ymD24m8Keihhs cB/RYP59K4W2/CEK3eVZLP7j38Xgs2E3hXcavRwWdu7icLipl8PcjiKCveNPaTxc8pxgh+OM BkfPe1gcGHcyaBvrIri/poVgc84QgwX1dQQzswQcPF7GYemdeTjsb2HQe/M0h1UvfDSeaZ0g mNdcTbAt841m1UJprOR3jVTa0EdJ9mM+Wrp08yAn5Vx2UNLJZ3WUNPBnFyvZaiqIdOVhNi1V Pv6XXa/9TrsyQTabtsqWxV9u1G5uuPeYSWnntr3yXSdWcoLNIhE8CJ/D1Yn6AGt5vVBO4Ibz ZUjQCyMEBk6YVOE5AecFH/fW0efpp1WhjICvs4WoxQsCWX/ZqOAUK3wM3r0OKijMEE6y4B7v DgnThdVw9kGeJsiM8BFc2VkeytMJy+HoWBmtRsyHyj/OhThC+AIqi+7T6k3zoLt4JLQUhFYe epyljGr4Bi725oZ5OjxtrgnfOhe89hxGNewhkFd7mlOLAwQyivrDUzFQ83d7gHmeFj6Bas/i IELg0v5CUcUp0NM/LThMBzC/9jdabetgb6Ze3SHCucud4TbAxH+T1bYER6+WhB+rkcD+vFHu AJlf+C6qhJAKMktOU5KMsrI0WU6PUgxJSlqyMerHLUmnSOCvel83j9QRz3h8ExF4Ik7WpayI jtNrDFuV7UlNBHhanKH7qs0bq9clGLbvkC1b4ixpZllpInN4RpylW+bs+0EvGA2p8k+ynCJb 3qoUHzHbSlz1GxJvRTg22apc1/rS96xNLfZbzekmRo4RD6fE5rRsbLQe7NZoPnCKSlenPTph UoHnlLY90rxhpKHx2Ori99eNrhyr+nnRt4mm7qlvHn0aG+kyLlizu8x4+8O2mLnH12Yccfkj 43OjBg5lvPeLe8o1ZVr2E1Pt0L6LXw8mzrTHz/lVZJTNhuhFtEUx/A9ldsg0pwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTURSGuTPTmUKsjgXjDYmKNRqXWJ0C9iAIanyYN0kgagCtFSeAMi3p tCo+GDAKpiAKIlHBUiRu1F2wgLiAUZCCBKQqUWQJxr0o7gTUAvr2Jd9/luQcOan8TgXKUwxm wWTQp6poP8r1u7F78a4EjW5py5sguNxiQ9D/spyE3sJuGnI+7SPgWUUU1DlLZFDQk0FAXsFn ApznrDR86N1LgWfIScCLWy4GTnTsZWCo4TUDB9uKEbweeUfCcfsXBG22Khn8qq+lYXDkFAV5 w24EhyqbEDTmfqagsKYaQZaVhU/nzzJQ/mImDPU2UeDqus7AhW/tJFS1jCLIb7yMoDXrj2zl bH7YflrGl9e9JfgjZe0k/6CriOFzH9oI/qqnmuAHb7tpPq+yAvHN/Tkk7xj4SUf7xakjTEaL WQhKNkrmFap4DjRqLgzUmpAwNRes3bhcE6paEhmxVUhN2SGYlkRuVifXvRyg0h4xu360d6IM dIm2Il85ZkPw29qPpBX5yZXsaYQ77zm9Qu4VGL8fICcy/njkiZWeyHxBuN/Wy4wJmp2PXQds xJgIYJ/T+HF2JjUm/NlV+E5fvmyMKXYubs48Nz5NwYbhk8Nn/3WdhR1X7o6zL7scO4p7xlnJ puDM7hp6gmfip6VficNosh35VKAAwSKJSaKkUUt6UbIYktSJRvEa8t78xoNfldXI6olpQKwc qSYp0sI5nVKm3yGliw0Iy0lVgGJ1q2uTUrFVn75bMBl1JkuqIDWgUO+C+WTgtESj94MMZh0X ymkhjNMGa4OXgWq64gBbn6Bkk/RmYbsgpAmm/3WE3DcwA6F3om6NZ3390JQz4adquCDPk0jR uT83JPvi5nBWjM7yu7mHXHc/dafmfoW70L27fXBRV5k1rolJKeGOWaa+ilnQWpteWrTFUGWZ t+2CQ5s8xxwwL3Gnz0gc4Q4U7VXT/TeYZvw8+rAvs7Wj9KtxbW3slNIosyM23mf4g320zr1C RUnJem4haZL0fwEgUOkoCQMAAA== X-CMS-MailID: 20200811085312eucas1p178f45d37ab3a8fa4da5885d5a86668e3 X-Msg-Generator: CA X-RootMTR: 20200811085312eucas1p178f45d37ab3a8fa4da5885d5a86668e3 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085312eucas1p178f45d37ab3a8fa4da5885d5a86668e3 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 06/24] net/ice: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Reviewed-by: Ferruh Yigit --- drivers/net/ice/ice_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index b51fa2f17..76f797de0 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3135,8 +3135,11 @@ ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) link.link_speed = ETH_SPEED_NUM_100G; break; case ICE_AQ_LINK_SPEED_UNKNOWN: - default: PMD_DRV_LOG(ERR, "Unknown link speed"); + link.link_speed = ETH_SPEED_NUM_UNKNOWN; + break; + default: + PMD_DRV_LOG(ERR, "None link speed"); link.link_speed = ETH_SPEED_NUM_NONE; break; } From patchwork Tue Aug 11 08:52:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75393 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2AD3A04AF; Tue, 11 Aug 2020 10:54:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D0A41C113; Tue, 11 Aug 2020 10:53:17 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E6A381C0DA for ; Tue, 11 Aug 2020 10:53:15 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085315euoutp015c4277bde14b2a2f605164f3c417bae2~qKrnixvZG0826508265euoutp01o; Tue, 11 Aug 2020 08:53:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085315euoutp015c4277bde14b2a2f605164f3c417bae2~qKrnixvZG0826508265euoutp01o DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597135995; bh=fgiYd6i2vA5tgF+67PLgyOKYf0isxQoJ4Cnk9IPoyJU=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=XpX0kr27uh49x9/7sgOr09QHNpLaTzZ8CizyT9AOgpEqnX0k/NLnYZIaVDmoSE9eX s/fpjEy7/59o4Vt6twpfFb2I1z+JD6JUM6kXriU8xnlSlQPuVOPScNurW2cxFyan2M 46NgWKxO9KpWXDSgTXT71v7k3QJsDlNnMlLwPUpM= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085315eucas1p1fb5b7cd34dcce0b78be2e7edfe8d49b4~qKrnA3qEX2534225342eucas1p1A; Tue, 11 Aug 2020 08:53:15 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 2B.1C.05997.B7C523F5; Tue, 11 Aug 2020 09:53:15 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085314eucas1p267b60944d8b8b480521723275cd99415~qKrmfLl-S0122701227eucas1p2v; Tue, 11 Aug 2020 08:53:14 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085314eusmtrp1c157a4bab8c023773050c2b7c22d0076~qKrmePZUl1606216062eusmtrp1R; Tue, 11 Aug 2020 08:53:14 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-ab-5f325c7bfdce Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id AA.4D.06017.A7C523F5; Tue, 11 Aug 2020 09:53:14 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085312eusmtip1ab70307f21661feaafc51c2d9a1d28c8~qKrkpCqfg1725317253eusmtip1i; Tue, 11 Aug 2020 08:53:12 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:26 +0300 Message-Id: <20200811085246.28735-8-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxTGc+43jZ131cQTZ2TULNtMlIEmO/sSXTZzl+hmsn8Wsw27eQdO qKQFNlmygRAkBZlQp9K6ijK/AFNBviRIAJ0XLMI0c7SLCiFmCCoi0KisiNxdzP77ned5zntO Tl6JtfwiLJa22dNVh92WYhVMXMOlJz0rfvg8PvGNCz0s+bt9QIO3Klga2HdToMKxPIaClQnU 0niIp9L+bIaKSx8y1HjSJdC9gV0cjY43MnTjfEAkz7VdIo13DIm0p9cLNBQZYamsfAKo11fP 05P2ZoEeRI5yVDx1Hejnuk4greghR/vONQHlu2QaO3VCpIobS2l8oJOjQOisSNXhqyzVd08D lWh+oCv5M/zaGGWq/BivVLQMM4r7yFVWuRTaLypFXT5GqRltYpQHrdcFpbiuEpTLg4WsUnX7 sbDJtNn07lY1ZVum6ohds8WUnFf9N5c2mPB9XpdfzIZf410QJaG8GkuqfuN0tsgnAUcKWBeY ZnkS8EB2A2cUE4BFo2Xc846yYfdc6gTgQX89GEUYMHL5d15PCfJrGCjwMbqxUK4RsDHSx+jG AnktuqeCos6c/AoOB0Ogs1l+C4/neHhjRDRWnWljdY6S38Yqbz9rLLgU+w5P/vcoyn9IeGbG M7fTB1h60C0YvABHtDrR4CUYcBdxRsNuwJKGs6JR7AXM9d6fSyVg3d2eWZYkVn4d/c2xhrwO zz16yusyyi9g8P6LuszOYmnDAdaQzViQbzHSVmzrujYnI07/O8+QFTzSWi0aBzoP6O11MXsh 2vP/rHKASlikZjhTk1RnvF39bqXTlurMsCet/HpHai3MftbAU22yCZojX3WALIF1njntnbhE C2/LdO5M7QCUWOtC8/tXAl9azFttO7NUx45ER0aK6uyAlyTOusi86ujwFxY5yZaublfVNNXx 3GWkqMXZsJ4PqUFtSJVupoQe17RvfC/dd/rRN6vLPn7Vc+/lwJ2JPaENnfa+ZbtbK/+MfKv9 VR0bE774z9ipZq04I7owULscuvvjtPGWJfUbPyn0ttqzckUt58OPTKvCcm7/rZ9yYlZ82ja9 PXOmPat2ICa5LZhzm83rWfPZ/h9NNpifsDn8ppVzJtvilrMOp+0ZyylP76gDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe1BMcRTH/e69e+8t1ty2NX7TNGRpJoatu71OSe34x/UHozGMIdaqa4u2 bfZuefyjkrCSRxiFLCmUmdJDSRr2j16bSYhCStNMwpQ2r5LHVuO/75nP95zznTmHJRXfKS82 IckimpP0iSranXL8aepZcTBGowsYy1oIZW0FCPrfFZLQd66HhhNfMgnoKomC+prLMjjbm0ZA ztlRAmpuWWn43JdBwbCzhoC3Dx0M5D/LYMBpH2TgZPslBIOTH0nIs40haC+olsH44zoaRiav U5Az0YngVFUzgqbsUQrO3a9FkGXl4MvtmwwUvl0Azr5mChzdlQzc+dZBQnXbbwRnmsoQPMn6 K9MuEiZsRTKhsH6IEHKvdZBCY/cFRshuKSCEu8O1hDDS0EkLOVUlSGjtP0EKpQM/6Q3uW9UR ZlOKRfSJN0mWVaptPGjUfBioNUFhaj4wdHu4JljlHxkRJyYmpIpm/8id6vjMO6+p5P6o/Zkt ZUwauqKxIjcWc0E4byiXtCJ3VsEVIXzjwXtXwboAxp8GyBmPJ558aaVnPGMI/yosZaYAzflh x7ECYgoouTc0fn40nZoCnpwW5050TZsozhcPdXWjKS3nwnBxer5sZupCXFr+aHqDGxeOSy/1 TmsFl4DTe+7TM3oBfnX1K3EazbWhWSVIKaZIRoNR0qglvVFKSTKoY03GCuS6+b3G8apaZB3e aEcci1Rz5MkreZ1Cpk+VDhjtCLOkSilf/cSxQyGP0x84KJpNOnNKoijZUbAr4BnSa16syfVB SRYdH8yHQhgfGhgaGAKq+fJj3OMYBWfQW8S9opgsmv/3EaybVxoK4G0NXO5y7TWfiaUfojfL t5w36Zzl62LjQlozfrCzKw3RTXtOMYqrzSeLW0rqtYGzoo9UrC1vDyrrStiUrfV+4T2+KCvy u6xzl2Gfx6H1a3g/ZZ3v8btEr8fi3XkZUTvttsq2j8qOjWtJ5cWnmY8MF53g077ksPEogcIj fBsnV6koKV7PLyPNkv4f32WPugkDAAA= X-CMS-MailID: 20200811085314eucas1p267b60944d8b8b480521723275cd99415 X-Msg-Generator: CA X-RootMTR: 20200811085314eucas1p267b60944d8b8b480521723275cd99415 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085314eucas1p267b60944d8b8b480521723275cd99415 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 07/24] examples: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov --- examples/ipv4_multicast/main.c | 14 ++++++------ examples/l2fwd-jobstats/main.c | 13 +++++------ examples/l2fwd-keepalive/main.c | 13 +++++------ examples/l3fwd/main.c | 13 +++++------ examples/link_status_interrupt/main.c | 31 +++++++++++---------------- 5 files changed, 34 insertions(+), 50 deletions(-) diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c index 7e255c35a..92bc13047 100644 --- a/examples/ipv4_multicast/main.c +++ b/examples/ipv4_multicast/main.c @@ -572,6 +572,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -591,14 +592,11 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, + &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index 47a3b0976..62ff2d9d5 100644 --- a/examples/l2fwd-jobstats/main.c +++ b/examples/l2fwd-jobstats/main.c @@ -689,6 +689,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -708,14 +709,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c index b2742633b..cf4db2820 100644 --- a/examples/l2fwd-keepalive/main.c +++ b/examples/l2fwd-keepalive/main.c @@ -453,6 +453,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -472,14 +473,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 24ede4290..0e3b75c97 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -810,6 +810,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -833,14 +834,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/link_status_interrupt/main.c b/examples/link_status_interrupt/main.c index 9bbcadfcf..3dcef4921 100644 --- a/examples/link_status_interrupt/main.c +++ b/examples/link_status_interrupt/main.c @@ -118,6 +118,7 @@ print_stats(void) const char clr[] = { 27, '[', '2', 'J', '\0' }; const char topLeft[] = { 27, '[', '1', ';', '1', 'H','\0' }; int link_get_err; + char link_speed_text[16]; /* Clear screen and move to top left */ printf("%s%s", clr, topLeft); @@ -131,9 +132,10 @@ print_stats(void) memset(&link, 0, sizeof(link)); link_get_err = rte_eth_link_get_nowait(portid, &link); + rte_eth_link_to_str(link_speed_text, 16, "%M", &link); printf("\nStatistics for port %u ------------------------------" "\nLink status: %25s" - "\nLink speed: %26u" + "\nLink speed: %26s" "\nLink duplex: %25s" "\nPackets sent: %24"PRIu64 "\nPackets received: %20"PRIu64 @@ -141,8 +143,7 @@ print_stats(void) portid, link_get_err < 0 ? "Link get failed" : (link.link_status ? "Link up" : "Link down"), - link_get_err < 0 ? 0 : - (unsigned int)link.link_speed, + link_get_err < 0 ? "0" : link_speed_text, link_get_err < 0 ? "Link get failed" : (link.link_duplex == ETH_LINK_FULL_DUPLEX ? \ "full-duplex" : "half-duplex"), @@ -445,6 +446,7 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, { struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; RTE_SET_USED(param); RTE_SET_USED(ret_param); @@ -457,13 +459,9 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, port_id, rte_strerror(-ret)); return ret; } - if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", - port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + rte_eth_link_to_str(link_status_text, sizeof(link_status_text), + NULL, &link); + printf("Port %d %s\n\n", port_id, link_status_text); return 0; } @@ -478,6 +476,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -497,14 +496,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Aug 11 08:52:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75394 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3FB1A04AF; Tue, 11 Aug 2020 10:55:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A52D51C124; Tue, 11 Aug 2020 10:53:19 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 910641C0B1 for ; Tue, 11 Aug 2020 10:53:17 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085317euoutp0210d442c78a21706427ba5f15b314f60e~qKrpD1aca0724507245euoutp02Y; Tue, 11 Aug 2020 08:53:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200811085317euoutp0210d442c78a21706427ba5f15b314f60e~qKrpD1aca0724507245euoutp02Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597135997; bh=0M5Z/0O/tlUlQAEPKCdBM4aV4GGJpfe6kt6DsPfxqak=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=WIMeyVLM2SQgtkMQC4S1y1IzdaST8E5cA0o/+Eyw0kCMQbQ2djZMaxI8Z4uZI/jfp DKWuDS2P9WndHEbTlrQ8yOnIevT/6aJrVHWuh64pMTQt6V/YRzoNr8VPf9Gy+VshXN pTS45z0G60Of6FmvElf1iSU0DWyeHiN9ZEXZpks4= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085316eucas1p175f9fdb9f730b3df78d38d83b5eb3649~qKromVoWk1187911879eucas1p1R; Tue, 11 Aug 2020 08:53:16 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id EE.1C.05997.C7C523F5; Tue, 11 Aug 2020 09:53:16 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085316eucas1p255142c8a00f15cba187e92509c2196cc~qKroQid8N0326203262eucas1p2u; Tue, 11 Aug 2020 08:53:16 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085316eusmtrp13d7f863dee904e635eaeaa533ebddaa0~qKroPowzL1606216062eusmtrp1a; Tue, 11 Aug 2020 08:53:16 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-b3-5f325c7ce02d Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id ED.4D.06017.C7C523F5; Tue, 11 Aug 2020 09:53:16 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085314eusmtip117df5c030f4a994420c83a40a534d1cf~qKrmek3OY1849018490eusmtip13; Tue, 11 Aug 2020 08:53:14 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:27 +0300 Message-Id: <20200811085246.28735-9-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHc+69vfe2sXqtZhxfG7uY6BZ1usU908W3aHLjJ/lgzJwTu3GH OiisV9w0GhEQCW8KJaAUEMEJgwlzILAOGZJAYa0iZKY62SDEpC9ooYA6sKiUi/rt9///z3nO ycnD07o8diF/yHREMpuM0QZWw9S3j99ZdWLfuoiPCrtXkRpnMZCB/8po0p/7L0vSh5Mpcr9y M2lqKFSRnL4EimTlBCjSUJHGksf9iQzxjzRQpPemgyMFPYkcGWl1cySzywrEHfTR5GLJKJCu 4hsqMn7LxpKhYClDsibuATlX1wHEnhFgSO7vjUBS0gQy/HM5R8p6l5KR/g6GOB7UcuSXp900 ueGcBJJtrwFyO+WVassycaLkJ5VY1uSlRMvlblpsf5DHiRmdxZR43d9IiUPN91gxq64SxL8G 0mmx6tH/7C7NXs3nkVL0oaOSec2mA5qDac5cVdyf6h8tIx4qATxcGqh5FD5Bb7pvijW8TqgA 7Kq4BooYA3RcG2IUMQro6hh829Li62GVoBzw1rlmlSKeArYleahQFSusQEdqMRUK5gvXWWwI uqaDecJOtPmtTIgZYTleshRAiLXCZ3jBk08rI/RY9WvLNKuFDVhl7ZtmnbAUXZfGph9F4S6P SbWumZ22Y2WRj1V4HvrsdTP+YnRYMhil4Sxgdn0tp4jzgEnWJzNVm7Fu8M4U8zwtrMQa2xrF 3or5mc8gZKMwG+8/mRuy6SnMqQ8tGrK1mJqiU6oN2NLZM2MjTr6YpdgiXvXcpZUD3QQM+Pvg POgL3s0qAaiEMClejomS5HUm6YfVsjFGjjdFrf4mNuY3mPqtjpf2sUawBb9uBYEHwyxt3Ma1 ETqV8ah8LKYVkKcN87Xbbjv267SRxmPHJXNshDk+WpJbYRHPGMK0H5d6v9IJUcYj0neSFCeZ 36QUr16YAN9++X1K7IUFO9r0JdbhydpkfZb+YaI7z1seXh2ZvOdw/o6rzwOnFmxtdz/3qKvD vdF7/YG20X+cK5bsHn9voO3Mpj9ediR+aLE3f/p39WBTV81pZ+G+pEdLUt8vitudwR2eE3v8 ZGfOlYlJ93o5/GR82BelG4uyrbuCtvLHpl44kOm6aGDkg8a1H9Bm2fgaAMi6hKkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917dzetxWVa/hDUHCkROd107WhmUkaX+qOHBT18NPKilnO2 O0VTyCy0rmaZUi1lamIPjazUfGClQmlNkYpKUVNM8pH4zMwwy0f994HP93s4cI6ElP2g7CWR 0UbOEK2NktPWlGW+qdstKUgV6pHWiaGsxYyg73MRCb053TSkj18goL1kG9RV5YngWk8yAZnX JgiouifQMNKbQsHoZBUBXc8sYrj1LkUMk40DYrjclotgYG6YBFPBFII2c6UIZhtqaRibu01B 5q8PCK5UNCNoypigIKemGkGqwMD4/btiKOpyhMneZgosHeVieDD9loTKlt8IsprKELSm/hH5 O7O/CopFbFHdEMFmF74l2Vcd18VsxmszwT4erSbYsecfaDazogSxb/rSSba0/ye9z/qowteg jzVy6yL0vHGr/JgSVAqlNyhUXt4Kpacm2Eellrv7+YZxUZFxnMHd77giQmjJEcW8sIrPnhwk ktGgWEBWEsx44frhd7SArCUyphjhmfyvpIAkCwLjb/3kcsYGz30U/mWmEJ5+3kwtCprZgC0X zcSisGU6afw+7dySsGF249rR3CWmGBecn30LLbKU8cY3B2/8m+qESx/VL7EV44NLc3uWWMZE 4nPdNfQyO+JP+d+Jq2h1AVpRgmy5WF4XruNVCl6r42OjwxUn9LonaOHmT1/NVlQjYTSwETES JF8ljdmiDJWJtHF8gq4RYQkpt5Vub7WEyKRh2oQznEEfaoiN4vhGpF5YMIu0X3NCv/BB0cZQ pVqpAW+lxlPjuRnkdtKLTEOQjAnXGrlTHBfDGf73CImVfTLa9FKz027PcVOhS8ZAgOtcVVpr 7X1enVj42KZzKhGEo/WawB0rjYfNY/HlR3a1HGlfv9Fp5sDEydQbag+vztNnf2RFJQQkPXRY 4SeYDh08XzHUtjszeP8sG9lmCQox1RS7znckOlwf8e/5srdBMbT2DriFh3k4+z65VLMuJc8z bd4gp/gIrXIjaeC1fwE0QYnjCQMAAA== X-CMS-MailID: 20200811085316eucas1p255142c8a00f15cba187e92509c2196cc X-Msg-Generator: CA X-RootMTR: 20200811085316eucas1p255142c8a00f15cba187e92509c2196cc X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085316eucas1p255142c8a00f15cba187e92509c2196cc References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 08/24] examples/bbdev_app: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/bbdev_app/main.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 68a46050c..2eff5441a 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -313,6 +313,7 @@ check_port_link_status(uint16_t port_id) uint8_t count; struct rte_eth_link link; int link_get_err = -EINVAL; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status."); fflush(stdout); @@ -323,11 +324,9 @@ check_port_link_status(uint16_t port_id) link_get_err = rte_eth_link_get_nowait(port_id, &link); if (link_get_err >= 0 && link.link_status) { - const char *dp = (link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - "full-duplex" : "half-duplex"; - printf("\nPort %u Link Up - speed %u Mbps - %s\n", - port_id, link.link_speed, dp); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("\nPort %u %s\n", port_id, link_status_text); return 0; } printf("."); From patchwork Tue Aug 11 08:52:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75395 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D245BA04AF; Tue, 11 Aug 2020 10:55:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACA8B1C12A; Tue, 11 Aug 2020 10:53:20 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 6BAFB1C122 for ; Tue, 11 Aug 2020 10:53:19 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085319euoutp014870c485c0fee5583708a137a1cd2389~qKrq0Uba90892608926euoutp01R; Tue, 11 Aug 2020 08:53:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085319euoutp014870c485c0fee5583708a137a1cd2389~qKrq0Uba90892608926euoutp01R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597135999; bh=dvfFw37UQuDLpsrBIxFOndEZRyFbf9bRa3Rm/liUUPQ=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=NrYrRvJ2hKsxau20MyIwQaBnCAmnCetCu2X+lDPdBcQpRQpyL8IemjO/x6BkhZPV/ NdkGKEIqF63VIykRwJfP/PnLhPyWG9I7XakoJIy0L3KMJFKDkCuhLi14NCGxpZHOuv 6VVuIAK4Qi85VfGsvRrgbSkMn2OB+u0CELzmNitE= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085318eucas1p18e6bb5c13e66e93669204c0b9e619cef~qKrql_dMg1187911879eucas1p1W; Tue, 11 Aug 2020 08:53:18 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id F5.ED.06318.E7C523F5; Tue, 11 Aug 2020 09:53:18 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200811085318eucas1p1bdd1fc51fccb907167a338785d2fdf86~qKrqH18_u1584615846eucas1p18; Tue, 11 Aug 2020 08:53:18 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085318eusmtrp10cb8017ac6a5744332c1483ab298cb07~qKrqGpj6r1606216062eusmtrp1k; Tue, 11 Aug 2020 08:53:18 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-fe-5f325c7ee86a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 49.0B.06314.E7C523F5; Tue, 11 Aug 2020 09:53:18 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085316eusmtip18b0054b4af7cbd83ca18585e7b3601ec~qKroPixON1725317253eusmtip1j; Tue, 11 Aug 2020 08:53:16 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:28 +0300 Message-Id: <20200811085246.28735-10-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSe1BMcRT2u/fuvbed1lyb4TcxjDvDxCDkccabwVzGcxgznlncyaPS7C3P GROR3S3RYzZERcyyxZLVLiPDotKGqampHVZJNG0pRYZsaLtr/Ped73zfOd/5zY8l1al0MLs7 OlbURmsieVpJFZX8fDXh6OYp4ZMqz88AS0U2gsZ3eSQ0ZLhpSPpygoA68zx4aLuogLT6eAJS 0joJsF030NDWcJyC9i4bAW+LnQxcqDrOQJejmYHTr7MQNHs9JJzP/YrgdfY9Bfx88oCGDu8V ClJ6ahCcsZYhKE3upCDjvh1BooGDLzdMDOS9HQFdDWUUOF13GSjoriThXkUvgtRSC4KXiX8U 80cJPbnXFELewxZCSL9cSQolLiMjJL/IJoQ77XZC6HhUQwspVjMSyhuTSCG/6Qe9WrlROXun GLl7v6gNnbtNueuY+yIV8z7gYJL1ExOPvjMGFMBibio26UwKA1Kyau46wjkZpylfQ819Q7iz ZJ2MvyKsd40zILbf0NxyWNabEE7VFxFy0Y3wtQQb7TPQXAh26rL7G4O5OzS2eWsJnzuIW4zd 54J9Goobjd9UNfSnUHEzcas+hZITjcT5tx+TPhzQx+dn1ZNyiBG4Nudb/0zMVbA4QRdPy4ZF uMdT4sdB2FNq9Z82HDvTkynZcKovatFdRi7OIpyQ9dmvmoetra8YXzqSG4stD0LlMxfgukxe hgNx3edBPjHZB9OKMkmZVmFdolqewePHL6r8NMa9vwJlWsAF1en+5ylG+Jb5Nn0Wjbzwf1Uu QmY0VIyToiJEKSxaPDBR0kRJcdERE3fsiypEfR/V+bu0244eebc7EMciPlAVM2tyuFqh2S8d inIgzJL8YNXCl86tatVOzaHDonZfuDYuUpQcaBhL8UNVYVdatqi5CE2suFcUY0Ttvy7BBgTH I4I3cnOmu460RdrXeo2n2tZJ3qcdBYmBng3TQp/v2Y5PGkLeMSGWHzXV6+khtcuK7SuG/x6w cqXrKlv2LCh1zRsL0WPqbcoVY8W1br1x4EFX4/g9oln/0dP0AfHLnl1SFReGLUlYetNNzCyc Ur7csWlM+6rvxk/d1eXT0nTb6g/wlLRLM3kcqZU0fwEsRiCQpAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zds5RXByW1Z8RZoNIwlZn3l6tVKzgUB9SpIiybOVJJedk Z5MuFNpN29S8dFVbloilgZaaFia5D2pNES3NyOUFScwy08o0u2xJ3348z/Ne4H1ZUvGVUrKJ yUbRkKxNUtHulP13q2Pd6RhN7IbKNiVUtVsRDL8rJWHwsoMGy+Q5AvoqwqCxvlgG+QNpBOTk fyGg/q6Zho+DZyiYmKonoP+pnYHC7jMMTNlGGcjuLEIwOv+BhBsl0wg6rXUymG1+QsPn+TsU 5Mz1ILhU24agNesLBZcfNyC4YOZg8l45A6X9XjA12EaB/U0NA/e/dZFQ1/4LQV5rFYKOC39k 4auEuZIymVDaOEYIBbe7SKHlzVVGyHpuJYQHEw2E8LmphxZyaiuQ8GLYQgqVIz/oSPe96k0G vckoeifoJeNm1T4eNGo+GNQa/2A17xe0P0QToFofuilOTEpMFQ3rQw+qE9IdxVTKkNsxS+17 Jg19Z8yIZTHnj0fHTpiRO6vgyhAub5tGCzrG4yOkGbk5cQme7zXTC5lphC2WWdpl0JwPtmda CZfhyb2l8cuMdMpVvITbhh3Xla4Mxa3Gb7sHGRfLuRA8fjGHWmi6EldWP/s3wM2pVxYN/GMF l4jTHY/pBfbCr299JXLR4hK0qAJ5iiZJF6+TeLWk1Umm5Hj1Yb3uIXJe/FHLbE0D6n4QbUMc i1Qe8pSNfKxCpk2VjutsCLOkylMe0WE/oJDHaY+fEA36WIMpSZRsKMC5YB6pXHpY7/yfZGMs H8AHQTAf5BfkFwiq5fJMrjlGwcVrjeJRUUwRDf/rCNZNmYYyrkWtSHOf2bPxrHmR/3hhoKOm CoSuyVeRtpWK39aJPq+ddR+zxjtTC84nbpkjt4YFtp6CyEZDwbBHflQuzp4nloW3V28P6Nea 6lnvQ7JrRUc0PtnFwzM3+4ZCZgmPik+h5g2NvU2+0T93XNnlq9Ts7pgJzH90SpKvYU5aSvdG qCgpQcuvJQ2S9i+k0VuFBwMAAA== X-CMS-MailID: 20200811085318eucas1p1bdd1fc51fccb907167a338785d2fdf86 X-Msg-Generator: CA X-RootMTR: 20200811085318eucas1p1bdd1fc51fccb907167a338785d2fdf86 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085318eucas1p1bdd1fc51fccb907167a338785d2fdf86 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 09/24] examples/ioat: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ioat/ioatfwd.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index b66ee73bc..bb8cff7c1 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -700,6 +700,7 @@ check_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret, link_status = 0; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status\n"); RTE_ETH_FOREACH_DEV(portid) { @@ -715,15 +716,12 @@ check_link_status(uint32_t port_mask) } /* Print link status */ - if (link.link_status) { - printf( - "Port %d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, link_status_text); + + if (link.link_status) link_status = 1; - } else - printf("Port %d Link Down\n", portid); } return link_status; } From patchwork Tue Aug 11 08:52:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75396 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A10FDA04AF; Tue, 11 Aug 2020 10:55:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE91A1C132; Tue, 11 Aug 2020 10:53:21 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 557281C131 for ; Tue, 11 Aug 2020 10:53:21 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085321euoutp01ba8552d7986a0e4b4cfbe43b49d05900~qKrslLRKd0904509045euoutp01D; Tue, 11 Aug 2020 08:53:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085321euoutp01ba8552d7986a0e4b4cfbe43b49d05900~qKrslLRKd0904509045euoutp01D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136001; bh=9QX3+yApojQ0Y1V6AqGi/iZB/2dabEsOXfmQeYdwTzs=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=HRcenCgPaurq+5EbqS5MCvdFNfsQ7C0/WTZaDlCuSBtEpJ21WgYG7OdRmikslXCMN x9Cta/3JnUYNLzBZn6I8vJ79qsCkVLtZAxHSiJa/DLD1/2jRtiFlfm2kSPvAzTdtpz rjBTtT1pBr+8mb9U1+/pVo3HEZZMZP1KIc9TYo5c= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085320eucas1p1edf9b945efc783d4d44dfc7eda519da8~qKrsO_82M1975819758eucas1p1q; Tue, 11 Aug 2020 08:53:20 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id C3.2C.05997.08C523F5; Tue, 11 Aug 2020 09:53:20 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200811085320eucas1p183ac15f1cc9c1eb937b7e7f559b11c9d~qKrr5M4-51586915869eucas1p16; Tue, 11 Aug 2020 08:53:20 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085320eusmtrp1e7715af2b2627b50c5559d553788f25b~qKrr4TvzU1667616676eusmtrp1N; Tue, 11 Aug 2020 08:53:20 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-c1-5f325c807f22 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 03.5D.06017.08C523F5; Tue, 11 Aug 2020 09:53:20 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085318eusmtip1aa0e52a1a1fbe30199faffc1a72a3adf~qKrqIgfBV1422614226eusmtip18; Tue, 11 Aug 2020 08:53:18 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:29 +0300 Message-Id: <20200811085246.28735-11-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSb0xTZxSHd+69vffSWL1WEs502Fg1m0umQ/1wNs3QTbabLCZmH8zmBKx6 g2SA2ArDfVgIc0xLVyoQdWIKwhwdHUFnpUjAYMdArMhgq9AEByEmBsYfKVVnV+agV7Nvz3ne 3+89yZtXZPUV/HIxM+eoYs4xZRl5LdfU+fTOG4V7N6a/+ev1V6nxthNo9M9alkYq7vFU8vA4 Q4P1ydTqPa+hsuFChuxlMwx5XVaeJkaKOJoKeRkaavMLdK6/SKCQ74FA3/ZWAj2IjrP0XfUs UK/zqoae3mjhaTpaw5E9EgAq9dwE6rLNcFRxrRmo2CrRwx/rBKodWkmhkZsc+YNXBPrpUR9L V2/PAZ3qagTqKX6m2bZKjlRf1Mi1rWOMXH6hj5U7g6cF2dbtZOTLU82MPH09wMt2Tz3It0ZL WNl9/29+l3aPdutBJSszXzFveGef9lDHmfhcR2JBb0kJFEJpghXiRJQ2Y83jBt4KWlEvuQCn wy5BHcKAFb9fY9RhFjDQOaZ5UbGPX+QWWC/VAdbZU9TQI0DbuDcW4qXX0H/CGWvHS5d59EYH mIWDZVIKOh0TsMCctBY7HaMx1klv41zzH6y6wYDuS+0xjpv37sphVt22EgeqwrFLUeoQ0eqe ArWwA+eGfuBVXobjXR5B5VfQX27j1MI3gKeargjq4AD8qnLyeSoZPX/dmWdRZKV12NiyQdXb 8WTV9zGN0mIcnFy6oNl5LGs6w6pahyeK9WraiO3d/c814tw/i1QtY7A/rFEfqA1wxtYHDjCc +39XNUA9JCh5luwMxbIxR/l8vcWUbcnLyVh/4HD2zzD/V/3/doWboSW63weSCMZFutwtSel6 jSnfcizbByiyxnjduz3+NL3uoOnYF4r5cLo5L0ux+GCFyBkTdJtqxlL1UobpqPKZouQq5hen jBi3vBDKF++vKkjWPXl/zfSga7srLa3jE0NP60sf7Vx7PzLxOPjx6pChLIBPZlfle34hJnHH rfOZcZdSB1KLzqa89UFpQyRp272z5aGXfesEpcCl/S3yYfDZ3trqiZHEk18H9mw1tO9q2308 uoRxD3+6tPtLIS93prHhSNJdP9exb8mBG+9NnjZylkOmpNdZs8X0H80/GDOnAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3eVVpe18DroNQq0x+zOzKNlDym6EFTUf2nZxS5T2pzt br3wjxVpclfTTFIrliX20MxHmloaOUKtaWJlJWmZSJbJXJbRSqup9d+H8/mew4FzKFw5Rqip 5BSLYE7hDRoykHD/buldYYvXJaxslFRQ3uZE0P+2CIe+3F4S7N6TGLwuWQ8NtZdkkPPOhoEj 5wsGtTckEob7ThDgGa3FoKfRLYcLz07IYdQ1KIczHRcRDI4P4VBQ+BVBh7NGBr6meySMjF8l wPGzC0FWdSuCltNfCMitr0OQIdHgvXldDkU982G0r5UAd/cdOdwa68Shpm0CwdmWcgTtGX9k GxZxPwuLZVxRwyeMO3elE+eau8/LudOPnRhX6anDuJEHXSTnqC5B3JN+O86VDvwgdwTu1q41 m6wWYWGSSbTEaOJY0GnZKNDqVkVp2fDIPdG6CE3YurX7BUPyIcEctm6fNulRnio1e96RDrsd 2VBWkIQCKIZexTiGigkJBVJKuhgxPsd7JCHKLxjm8wA+nZnDjL+UyOnMV8R4O3PQpCDpEMad 6cQmhYp+QzLPTx0nJsUcejPjzB6eChH0EqY5u3+KFXQ0M1H34t/UBUxpxcMpDvDXSy++m2Il ncwc760np3k+8+ryNywbzSpEM0qQSrCKRr1R1GlF3ihaU/TaRJOxCvlPfrfZV12HJM8uF6Ip pJmpSF3DJihl/CHxqNGFGArXqBSx7e69SsV+/ugxwWxKMFsNguhCEf4Fz+LquYkm/wOlWBLY CDYSotjI8Mjw1aAJUmTSTfFKWs9bhAOCkCqY//dhVIDahuzbtyo8sT/MYb77bkufA8rb532I i91oy99ydXZt2YL0j67D28Lvft/+tNJzbmw5G53UNaG+dntncK91GdJjNWVp3jgTd1CXN8Ng oQo+kd1VFYvVH6zpVfRQVmtpMB/jHjEYH6fpOheGanxPNv3SVzWFDdLe0LYQEy/mSwpWQ4hJ PLsUN4v8X1sGiU0IAwAA X-CMS-MailID: 20200811085320eucas1p183ac15f1cc9c1eb937b7e7f559b11c9d X-Msg-Generator: CA X-RootMTR: 20200811085320eucas1p183ac15f1cc9c1eb937b7e7f559b11c9d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085320eucas1p183ac15f1cc9c1eb937b7e7f559b11c9d References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 10/24] examples/ip_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications: * ip_fragmentation * ip_reassembly * l3fwd-acl Signed-off-by: Ivan Dyukov --- examples/ip_fragmentation/main.c | 13 +++++-------- examples/ip_reassembly/main.c | 13 +++++-------- examples/l3fwd-acl/main.c | 13 +++++-------- 3 files changed, 15 insertions(+), 24 deletions(-) diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c index 4afb97109..b94d226c9 100644 --- a/examples/ip_fragmentation/main.c +++ b/examples/ip_fragmentation/main.c @@ -593,6 +593,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -612,14 +613,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up .Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index 494d7ee77..4da827704 100644 --- a/examples/ip_reassembly/main.c +++ b/examples/ip_reassembly/main.c @@ -712,6 +712,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -731,14 +732,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index f22fca732..5625306cf 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -1815,6 +1815,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1834,14 +1835,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Aug 11 08:52:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75397 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9203A04C3; Tue, 11 Aug 2020 10:56:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 17F531C139; Tue, 11 Aug 2020 10:53:25 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id BDF7D1C13A for ; Tue, 11 Aug 2020 10:53:23 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085323euoutp020ee43345abd8c484ec24b97bd423f170~qKrugxEQR0711807118euoutp022; Tue, 11 Aug 2020 08:53:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200811085323euoutp020ee43345abd8c484ec24b97bd423f170~qKrugxEQR0711807118euoutp022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136003; bh=m59DocdpBmz6zpeYlI/lYCa1xdU/4ezlcOeXWIanCQY=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=c8jnwDpUT6oa1ivfdo+jh6MXzFpY/4e2drEt2rebt+FzG75WTwhZSJMlEubo2rRs8 KU89tCnkXPPnePipIqLndZuYO38pklNwx0ni1t1ZnNKdK/Gqgn1upYfvAmXsQc8V+u WZv6j8jD+utXqhISNpPyQad4uSyj9r4Im3lB8Vvg= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085322eucas1p1354d2345a6ead2aa65e840bfad0a78bb~qKruOvAIB1585315853eucas1p1B; Tue, 11 Aug 2020 08:53:22 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 6A.ED.06318.28C523F5; Tue, 11 Aug 2020 09:53:22 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085322eucas1p25b30133706c03257172cd3348f7feb7d~qKrtxQ1DY0327003270eucas1p28; Tue, 11 Aug 2020 08:53:22 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200811085322eusmtrp25cfbffb2889daa41df15a26d8b062b3e~qKrtwE4Ym2198021980eusmtrp2U; Tue, 11 Aug 2020 08:53:22 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-0b-5f325c82b7c6 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 90.1B.06314.28C523F5; Tue, 11 Aug 2020 09:53:22 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085320eusmtip17543bd08263709779dde1aebf25b1878~qKrr5huyT1666316663eusmtip1H; Tue, 11 Aug 2020 08:53:20 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:30 +0300 Message-Id: <20200811085246.28735-12-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf2wTdRjG895d726VkrOQ8DplwyZmTLHjV/BVUcCYeIkalmAiM8BW5bIt bmNp2RTjH7Mzkwy2lbJpoK7rWIS5uoyyri1kYF2EDjucW0BGRLY0CgEcbKVTtxWw7ZX43+d9 nvd53zfffEVW38xniqUVuxVzhanMwGs537nZ4eet21YXrgwfXE09Q06gyLUOliaaf+dp39Tn DI11baB+/9caso/XMNRon2bI31nP018TVo7uRP0MXT0dFujwqFWg6MANgRqGHUA34rdYOuS6 BzTs7NPQ7A+neLobP8JR49wloCbvIFBo/zRHzScDQHX1Ek19e0ygjqtZFJ0Y5Ch8pVeg72ZG WOobug90INQDdKHuoWbj0/Kc6xuN3NF/k5EPto+w8rkrXwry/vNORvbcCTDy3TOXeLnR2wXy T5F9rOz+418+X/uedv1Opay0WjHnvVqkLYnZIkLloYUfuzsdUAMjj9VDhojSWvw1GufqQSvq pU7Af1qbIWnopRhgw+h61bgHGJnqEx4lYlYbrxrHAOfdtYxazABedLWk4ry0HMN7nSljseTh 0R+/zCSNRdJb2BQ4yiWZk57B7smZFOukl3AkMM2qK7LRfTyY4oyE7naMs+pNWXi5LZYaitKQ iD2nOkANvI4NnphG5UV4K+RN3/oUPjzZlg58AXjA1yuohQ2w1jGZ7tqA3ts/J1gUWSk3MTVP lTfhib/n2KSM0kIcm3w8KbMJtPu+Sss63FunV7sNGDw/mpYR788vUFHG1sYX1fc5DRi0Wxkb ZB/+f5ULoAuWKFWW8mLFsqZC+choMZVbqiqKjR/sKj8Bib8afhCaCcCZ+PsDIIlgWKCrfHlV oV5jqrbsKR8AFFnDYt1rF8I79Lqdpj2fKOZdheaqMsUyAE+KnGGJbs2Rm9v1UrFpt/KholQq 5kcuI2Zk1kCR0BvMyn3w6Sst1bPjxs1Rb+TaOv/3K50/ltizBWdR5qatS9tDbWffbvcfjxRc zPWsM2//7LkVdUrL2aa13bXFS7e2et7ZNjWoLVgWXNFtNN/OnwfDG76S5aXvurYYfb7+ggmb 63rOjpzrOPbmC76GZcyf+aNVvz2x0TGc90vZ5swcA2cpMa16ljVbTP8BcBa/UacDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH/d17dzet2WVNuohZjpIymt2p7fjIIjIukRAERaatoRe13Ca7 03KU6YySaaYmgRnLsvIZurJcYpFCak0pe4euTCLtpU4tVMyaj/77cD7fczhwjgiX/Ca8Rcla A6fXqlNkpAdhn+1wbDTFKlSb+i56QX2XBcHAhwoc+kscJOSNnsbgXc1WaGm6LIDij1kYFBQ7 MWiqMpPwo99EwPBYEwZ9D+xCuPTCJISxtkEhnHtWhmBw5hsOpeXjCJ5Z7gpgqrWZhJGZawQU TL9GcL6xE0FHvpOAkvs2BGfMFIxWVwqhos8Xxvo7CbC/vyOEul89ONzt+oOgqKMeQfeZv4Jt fux0+Q0BW9HyFWMvXO3B2fb3F4Vs/hMLxlqHbRg78vA1yRY01iD26UAeztZ+niT3eMTII/S6 NAO3OknHG7bIDjKgkDOhIFcEh8qZIGVcmCJEFhgZkcClJKdz+sDIw/KkicIBYWqp5/HaqjKU hXqWmJG7iKaC6QlTIWlGHiIJdQPRZXXXkRmJXIKmv3/GFzLL6Zk35sXMOKK7bTmCOUFS62h7 rgWbE1Kql6Rfns0m5sRyajd93nZznglqLX3r5695FlNhdI/NuTh1FV3b8Gie3V312rKP8yyh kulsx31ygX3pt1cmsELkWY7capCUS+M1iRqekfNqDZ+mTZTH6zS3kevm99qn7tjQC+veNkSJ kGypODWcUUkE6nQ+Q9OGaBEuk4q3d9sPScQJ6gwjp9ep9GkpHN+GQlwLFuHeXvE61wdpDSom hFFCKKMMUgZtBtkKcS7VGiuhEtUG7ijHpXL6/32YyN07Cy3b/cn9RFf2bJes8prjQPQxTVSR ob439clRe3Wd/2RA7P5lk3U7FT5sc/4a+5rnk3Fwu2TlpoH1p77scvKRrW5/91mLjUpnimdD jA8f3cxsCHyVGXXE8XjwqjHEs/HVWS9T+NC7Q1prSVXGBal/5gSHW4ZW+O0wnoxqif5kz0mP kRF8kpoJwPW8+h+moVL9CQMAAA== X-CMS-MailID: 20200811085322eucas1p25b30133706c03257172cd3348f7feb7d X-Msg-Generator: CA X-RootMTR: 20200811085322eucas1p25b30133706c03257172cd3348f7feb7d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085322eucas1p25b30133706c03257172cd3348f7feb7d References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 11/24] examples/ip_pipeline: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ip_pipeline/cli.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index d79699e2e..236553aae 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -249,7 +249,8 @@ print_link_info(struct link *link, char *out, size_t out_size) struct rte_eth_link eth_link; uint16_t mtu; int ret; - + char link_speed_text[16]; + char link_status_text[10]; memset(&stats, 0, sizeof(stats)); rte_eth_stats_get(link->port_id, &stats); @@ -268,18 +269,19 @@ print_link_info(struct link *link, char *out, size_t out_size) } rte_eth_dev_get_mtu(link->port_id, &mtu); - + rte_eth_link_to_str(link_speed_text, 16, "%M", ð_link); + rte_eth_link_to_str(link_status_text, 10, "%S", ð_link); snprintf(out, out_size, "\n" "%s: flags=<%s> mtu %u\n" "\tether %02X:%02X:%02X:%02X:%02X:%02X rxqueues %u txqueues %u\n" - "\tport# %u speed %u Mbps\n" + "\tport# %u speed %s Mbps\n" "\tRX packets %" PRIu64" bytes %" PRIu64"\n" "\tRX errors %" PRIu64" missed %" PRIu64" no-mbuf %" PRIu64"\n" "\tTX packets %" PRIu64" bytes %" PRIu64"\n" "\tTX errors %" PRIu64"\n", link->name, - eth_link.link_status == 0 ? "DOWN" : "UP", + link_status_text, mtu, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], @@ -287,7 +289,7 @@ print_link_info(struct link *link, char *out, size_t out_size) link->n_rxq, link->n_txq, link->port_id, - eth_link.link_speed, + link_speed_text, stats.ipackets, stats.ibytes, stats.ierrors, From patchwork Tue Aug 11 08:52:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75398 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D094CA04C3; Tue, 11 Aug 2020 10:56:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B86A01C19C; Tue, 11 Aug 2020 10:53:27 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 9285F1C191 for ; Tue, 11 Aug 2020 10:53:25 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085325euoutp023f3734bc6de5334e4a5d3aba5a5bd56e~qKrwbM9R70681906819euoutp027; Tue, 11 Aug 2020 08:53:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200811085325euoutp023f3734bc6de5334e4a5d3aba5a5bd56e~qKrwbM9R70681906819euoutp027 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136005; bh=2YRxl3RkBrUYoDHIpEwq3S3SIsgsWy/LjzHhR+mNsQg=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Kmf4E0da6neRxLbjfs2JTfDN60LU7okwbD9zPy+kvhAqM6mqJRVrDHo4lXs3H9K/F HW+D+NcJHARdQyrAk5vtzv75KIN3V3+ODw/tTN64iHntvpY0rFrOT5c4BHp48VSZ7G Z6U4Ulo8DHuKgGLKUV9gpBYxOVHyYa9ULqzlM/0c= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200811085324eucas1p22e2d9bfab88bea4d8c51a009da12069e~qKrwHBeeG0929809298eucas1p2G; Tue, 11 Aug 2020 08:53:24 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id C4.B1.06456.48C523F5; Tue, 11 Aug 2020 09:53:24 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085324eucas1p26b6e10bd94763582538fbad8603427d2~qKrvoasGv1587115871eucas1p2D; Tue, 11 Aug 2020 08:53:24 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200811085324eusmtrp24acd453506ef68772cc896cf0abb690b~qKrvnZjRJ2198021980eusmtrp2Y; Tue, 11 Aug 2020 08:53:24 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-22-5f325c84f920 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 43.1B.06314.48C523F5; Tue, 11 Aug 2020 09:53:24 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085322eusmtip16545f104a5b6a7736e5314e6ee07a1ae~qKrtyBexP1748717487eusmtip1R; Tue, 11 Aug 2020 08:53:22 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:31 +0300 Message-Id: <20200811085246.28735-13-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSfUwTdxj2vbveHQ3FW9XwAxWyJsaPBBX0jzdjglsWc0vcYqZ/GJ1inRcg AmJLnbLNMGRAKitYCQRrCpMYKzgZpXyKG+MPPiyIlBBAUaqSERyCoF1AEcZxXfbf8z7P+/Hk ycvTWisbyiempEmGFH2SjlUzdW1zPRFZX0fFbfe1RGFVlx3w2ZNyGr2Fj1m8+CqLwsGKWGyu v6pC60gGhRbrNIX1DjOLE95MBidn6ikcvuvm8Ionk8OZ1jEOf+6xAY7Nv6CxpOw1YI+9VoVz fzaxODV/jUHL237AfFcHYHveNIOFjQ2A2WYBX928wWH5cBjOeDsYdA/VcHjL10tjbdd7wEvt VYDd2Yuq3R+Kb8uuq8Ty5nFKvPxLLy22DRVxYl6nnRKrJxsocer3fla0uCpAvPfsIi1Wjs6y +9SH1B+fkJISz0iGbTHH1AmTjeGpz9Vnc9tCMqCXNwPPE2EnyXIGmUHNawUHkLyiYtoMAUvF GyDOprWK8BrIxJ0+RhbkgYePHrGKcAPIgLeEVgofkNJxJyt3scIm4s61U7KwWqhmSf38ACUL q4S9xDrm4mTMCBvI6PTwMtYIH5HaX4s55UQ4qfytZdlHwBJfaRvxewojA6VvlpcSoYsnP/40 6vf0GfF4HKyCV5EX7S7/onVksbHUP5AD5FJdDacUBUAu2F76u2KJ6+/7nBwHLWwmVU3bFPoT YrnXwCkpBZHBlx/INL0ErXVySDKtIbnZWqVbR1o6PX6akPfvAhVaJE6Hh1MCugvkQVMfXQDh V/6/VQZQAcGSyZgcLxkjU6Rvtxr1yUZTSvzWb04lO2HpU90L7TMN4PMcbwWBB12gJjU6Mk6r 0p8xnktuBcLTutWaT7vdR7WaE/pz6ZLhVJzBlCQZW2Etz+iCNTuujR/RCvH6NOmkJKVKhv9U ig8IzYD939UcPhD1x57+vlxfYt1X+dWHjn05q8lck3a0ZEXHRPQ63mf5fnL/jn0xfyX+c7zW En26cTAw9uxl3e31AtBp0vzzgxHdX0S4phLGb28s/sFbNBR20j6SU7G30Obd2bby8/PwIGn6 QmdM+tP+kPS40aDm0lnTYkjmxC7TQrBj7k6oTccYE/SRW2iDUf8vwf9N+6UDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTcRDG+e9ut9vGmrWiLsQANtGoicUFkQERDA9kTUg00QcPtFZZOduS bqvCixwepCCXBrxSUUQRPBCoHEGjNQG1EAWCILdIxIMALSBC8Cigb1/m983Ml8xQuHyScKdi tAZer1XHK0gpYfvd2LvpTISPavObrmXwqMmMYLCvCIeBS70kZIyfwaCzNATqq6+LIK8/GYOs PDsG1SUmEkYGUgkYdVRj0PPUJoarralicFiHxXDh7TUEw3PfcLhSOIHgrdkigpkXdSSMzd0i IGu2HUF21SsEjZl2Ai7V1iA4Z6Jh/N5dMRT1eIBj4BUBtg+VYrg/1YKDpekXgtzGRwiaz/0R 7VjDzRYWi7ii+q8Yd/FmC841fMgXc5mvzRj3eLQG48aetZNcVlUp4t4MZuBc2dBPcrf0gDJI rzMaeK9onWDYrjjIgo+SDQClz5YAJevrfyjQx0/hHRwUycfHnOD13sFHlNGjtZ4Jn6Sn0hvc klELZUISiqG3MF3d3aQJSSk5XYyY6qHLyIQoJ2CY70P4omc5M/fe9M8zgZiuiXfieUDS6xlb uhmbB650N8m0nU8h5sFyOpzJG65aMBH0WmbI3rOgZXQgY3lQIF6c6smUlT9f2CBx1suu9S9o OR3DpPTWkovag+m4MYnloKWFyKUUufJGQROlEViloNYIRm2U8phOU4GcF3/SMFNZg1of77Ei mkKKJbKEbaxKLlKfEBI1VsRQuMJVFtpsOyyXRaoTk3i9TqU3xvOCFfk5A+bi7iuO6Zz/ozWo WD/WHwJYf19/362gWCVLp19EyOkotYGP4/kEXv+/D6Mk7sloc867nGzhoWf+15uW0Nv18S4u q2unz54tH9D+mPbyHtvZl3aRPJ46Wl589POy2JHOjw7ifETQM3tHUhp32utl6rQurG28YJfE TW7ZViKNvW+dkbwsUXXvP9DIu1gd+8yDe2um2Nmw8JNfRu5UhHzekGZfqTHWr+P/mOM6D6vG 6yYVhBCtZjfiekH9F4chybwHAwAA X-CMS-MailID: 20200811085324eucas1p26b6e10bd94763582538fbad8603427d2 X-Msg-Generator: CA X-RootMTR: 20200811085324eucas1p26b6e10bd94763582538fbad8603427d2 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085324eucas1p26b6e10bd94763582538fbad8603427d2 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 12/24] examples/ipsec-secgw: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ipsec-secgw/ipsec-secgw.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index f777ce2af..8fb3d2ad9 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -1775,6 +1775,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1794,14 +1795,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Aug 11 08:52:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75399 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 773D3A04C3; Tue, 11 Aug 2020 10:56:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1C941C1A7; Tue, 11 Aug 2020 10:53:28 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 838901C19B for ; Tue, 11 Aug 2020 10:53:27 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085327euoutp013c35d16e8397f8ccba15f61395af6ee4~qKryUqLKQ0826508265euoutp011; Tue, 11 Aug 2020 08:53:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085327euoutp013c35d16e8397f8ccba15f61395af6ee4~qKryUqLKQ0826508265euoutp011 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136007; bh=1HUBFNSbsGccIr2R0MvGSWz7oQhbKklL110HJB3GrNg=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=i+YrBUKckZG7+Rh3OLIlir82TuRnCMgUTSdC5W/AaSYy6XfKi9Pg+KAfmRXlExIB1 OAJZFOX3L7qnP85zrs+BB3NMPb+MW3gaUvw4rrZSrX1Km+WwLXtPWLLhdK/grh3LEW x1CKVBJ3sT7dm0sm/xzz1972HCy7aHeJjnYNUzbI= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200811085326eucas1p224ca079f33a79ff13d229d8a123bb9de~qKrx04fbt0326603266eucas1p2I; Tue, 11 Aug 2020 08:53:26 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 79.2C.05997.68C523F5; Tue, 11 Aug 2020 09:53:26 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085326eucas1p2f064d67234e0adff5d7ddbf0a1bef2a9~qKrxe7z710122701227eucas1p22; Tue, 11 Aug 2020 08:53:26 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085326eusmtrp17efaffcde7eb4f977ef8c24b8d6af32b~qKrxd-2eF1667616676eusmtrp1d; Tue, 11 Aug 2020 08:53:26 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-d5-5f325c860401 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 68.5D.06017.68C523F5; Tue, 11 Aug 2020 09:53:26 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085324eusmtip1b9fce021e73a580d9651391e2ed03ce6~qKrvlekoo1748717487eusmtip1S; Tue, 11 Aug 2020 08:53:24 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:32 +0300 Message-Id: <20200811085246.28735-14-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSbUwTdxjPc3e9OxrOnIcvT9SANi7TGUXQD3/3JjN8uI9Llmg0c10dFzDQ QnoWJ/EDU1O1MLBFtygbVF4UgQUVbCuxpmC0YEGEhQhJVcZenJ34AnQDBDfK1ezb7/V5nvzz 52mpgl3B77ccUKwWU56B1TOeO9N9G+2fpxs3V7vWkZaeKiCjj2ppMnL6IUtKXh6jyFDjdnLD +4OOuB4XU6TM9Yoi3gYHS56NHGHI83EvRcL+EEfODRzhyHjnE45821cJ5MlshCZn3RNA+qqu 6ch0RztLXszWMKRsZhBIeVsXkGDpK4acvu4DYneI5OWlixypDSeT8ZEuhoSGWznSHO2nybWe OSDOYAuQXvu/uow18oy7XifX3nhKyRXn+2n5zvB3nFzaXUXJV577KPnFzUFWLmtrBPnuaAkt N/02xX6q36P/MEvJ21+oWFM//lKfU9rTzBWMiV9XPLzFFINfcEACj+JWvGePggP0vCQ2AIb9 NTqNTAL+U3yM08gE4PnyMPO28qjaE09dBKyf+obSSBTwdscAF0ux4joMnahaMJaIV1j0zj6g YkaSmIkTztvzIZ5nxHcwGEyIQUF8H0PlirYgBZsuB+gYTpiXmyofL2BJTMYH1ZMLI1G8z2N9 rY/TCpnoPzsavy4JI8G2uL4KQxWljFY4Duj0tHIaOQV4tHIsntqObX/dWziIFtdjS3tqDKL4 CU5HaQ0uwqGxxbEwPQ9dnu/jsoAn7JI2w4CB7oG4jDj3OlGTZZwIDMff0A/YHLgPpyDl3P+r 3ACNsFyxqeZsRU23KAc3qSazarNkb/oq33wV5r9q6E1w0gfts/s6QeTBkCgUfJBmlHSmQvWQ uROQpw1LhB29oS8kIct0qEix5huttjxF7YSVPGNYLmypebpXErNNB5RcRSlQrG9dik9YUQz1 Rb/YVCHX43FYSvb+NFnnW9r97pmf/3D+biyaSny2bI2L+zFgS57yuvoy0lL+HGw4+ZE+dcPc 3Uj/+rquSycjvVvX7vv1sw7TXOTg2Izz+OXDK5ktu9jXQm5Of2vS4I663WxGvnmnOz2atdq4 +EJmzrbD2/a4U8Oru68O/S01SoVHDYyaY0p7j7aqpv8A/YitJaYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH/d17d+8mrW7T6iJmuQgiaLapeXxkEgX3j+hlgT1Mh12c5Jzs buEjcFqZbGb5IEprrnzlDHr5ykfUKlfNCCstSdMkGlr5tqzssSX99+V8vufLge8R4pJpwkeY lKLjtCnKZCnpSTh+2/vX5R5UxK1/Y5DA9U4zgqF3FTgMlvSTYBo/gcEb6yZoa7oogKIBAwYF RRMYNF01kvB5MIeA0ckmDPraHRSUvsihYNLmpOD08zIEzrkRHC5YphA8NzcI4Pv9FhLG5q4Q UPCjG8GZ+scI7PkTBJTcaUaQa6RhvLaGgoo+P5gcfEyAo/c2BddmunBo6PyFoNB+HcGz3D+C KH/2h6VKwFa0DWNs8eUunO3oPUex+U/MGHtztBljx+52k2xBvRWxT4dMOFv3YZbc6blfFqHV 6HXcSpWG122UHpCDQiYPBZkiKFQmDwyJDVMESwMiIw5zyUlHOW1AZLxMld95jUr9QqcV9z8g DKhdbEQiIUMHMe/KGwVG5CmU0FWI+TkzgBmR0AUY5tMHfN7jxcz1GMl5zxRiTHlO5AYkvYZx 5JkxN/Cm35LMy1PZhBt40VuYqcJHlDuIoFczdrvILcV0GOM4w81nrmDqbtz7ly9yjevKBv5p CZ3EZPffIee1H/O6fBo7ixZakIcVeXN6Xp2o5hUyXqnm9SmJsgSN+hZyNd7Y8b2+GRlHo22I FiLpAnFquDxOIlAe5dPVNsQIcam3ePMzxyGJ+LAyPYPTauK0+mSOt6Fg13mFuM+SBI3rf1J0 cfJgeQiEykMCQwI3gHSZOI++f1BCJyp13BGOS+W0//cwocjHgFKrq2eyLp5f3heuH+pZMeZp +Hpooms2JjnC532JyZ/bu2NVZnqNrQmZwrZ/vBET9RB/1drSW7+NqsLKO9qz1DXdvreP1C6K nou9MBz7rad2Q9GeS6J9lsrSV0G+GZmtHjXaRbsDjnupPsarrMeetm5NW5rhNXJlcUVp5eKT 5l3Ls51Sglcp5WtxLa/8C6CktJwHAwAA X-CMS-MailID: 20200811085326eucas1p2f064d67234e0adff5d7ddbf0a1bef2a9 X-Msg-Generator: CA X-RootMTR: 20200811085326eucas1p2f064d67234e0adff5d7ddbf0a1bef2a9 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085326eucas1p2f064d67234e0adff5d7ddbf0a1bef2a9 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 13/24] examples/kni: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/kni/main.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index f5d12a5b8..f1045b284 100644 --- a/examples/kni/main.c +++ b/examples/kni/main.c @@ -661,6 +661,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status\n"); fflush(stdout); @@ -680,14 +681,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %uMbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ @@ -717,19 +713,15 @@ check_all_ports_link_status(uint32_t port_mask) static void log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link) { + char link_status_text[60]; if (kni == NULL || link == NULL) return; - if (prev == ETH_LINK_DOWN && link->link_status == ETH_LINK_UP) { - RTE_LOG(INFO, APP, "%s NIC Link is Up %d Mbps %s %s.\n", + rte_eth_link_to_str(link_status_text, 60, NULL, link); + if (prev != link->link_status) + RTE_LOG(INFO, APP, "%s NIC %s", rte_kni_get_name(kni), - link->link_speed, - link->link_autoneg ? "(AutoNeg)" : "(Fixed)", - link->link_duplex ? "Full Duplex" : "Half Duplex"); - } else if (prev == ETH_LINK_UP && link->link_status == ETH_LINK_DOWN) { - RTE_LOG(INFO, APP, "%s NIC Link is Down.\n", - rte_kni_get_name(kni)); - } + link_status_text); } /* From patchwork Tue Aug 11 08:52:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75400 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C129A04C3; Tue, 11 Aug 2020 10:56:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFDB51C1AE; Tue, 11 Aug 2020 10:53:30 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 443BE1C1AC for ; Tue, 11 Aug 2020 10:53:29 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085329euoutp023819595dc158ae112228790e93ba8b33~qKrz9B69L0724507245euoutp02i; Tue, 11 Aug 2020 08:53:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200811085329euoutp023819595dc158ae112228790e93ba8b33~qKrz9B69L0724507245euoutp02i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136009; bh=TIVv8jtUIUUjQpoFfPW2Uq8iZzgFgtt0hRv53s5mn9E=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=QIz+BFgN5yLKISsMXbAqkTottqXkHIFS4H5TXJuCCGF96B0ca7UTORcbH40js5qAY U67cQ/z1ColW+nKB4kEjBAyMNRwF5+40G2GG8qBairbIAv1YhtkeR/teQLRxX8Y43Z 6yJMXzh0Vimz2vcM7CkuNzveR4nL3WuZvpeInSNM= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085328eucas1p1a595187467c0e452ae6b4910081f00ba~qKrzvuYJU1187911879eucas1p1l; Tue, 11 Aug 2020 08:53:28 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id E8.B1.06456.88C523F5; Tue, 11 Aug 2020 09:53:28 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085328eucas1p27b1c8ff1901fd75ecb06c180c6c29d3d~qKrzWYdlW0326103261eucas1p2G; Tue, 11 Aug 2020 08:53:28 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085328eusmtrp1403886d7881a93cd1ba41bf44ddb80e0~qKrzVZ_NI1667616676eusmtrp1l; Tue, 11 Aug 2020 08:53:28 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-2f-5f325c8862bb Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id FB.5D.06017.88C523F5; Tue, 11 Aug 2020 09:53:28 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085326eusmtip1b58954b18ffcddf2a9844274905dc2ec~qKrxdCkPs1792217922eusmtip1L; Tue, 11 Aug 2020 08:53:26 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:33 +0300 Message-Id: <20200811085246.28735-15-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUwTdxjH87u73h2NNbfq4hMwMJu4TI127MU86qIMSXZL/IP5h8kWFA65 gAqIPVCZyQKoiBUR8G2CwQqZYLEiWgoSRQRDYW3XgQElYUCMWsCJimAUYYxyNf73eb4vz5P8 8uNp/Wk2mN+Rmi6bUqVkA6tlHG3vvCvzYr6K/bLy6EqscZcRfNRfQePgqX9YPPbyEIUPrRvw Vv15DRYPZFFYUPyKwvoqM4v/DuYwODpWT2HfbReHJV05HI61+Dg87i0l6JsaofGc5TVBb1md Bt/dbWTxxVQ5gwWT3QRP2NsJOvNfMXjqZgPBXLOALy9XcljRF4pjg+0MunpvcHhlopPGOvc0 wSJnDUFP7owmYok4aflDI1bcGqbEkxc7abGt9wwn5neUUWLtaAMlvmjqZsUCu5WIfz46RovV j9+y0dpftN8lyMk79som4/o4bZJn1Mak2bX7h4a6uSxylTeTIB6Eb8DiuMyZiZbXC1UE+t78 rlGHcQLW8WxGHV4TuORzMR8qJw63BlKVBJqzhwP9CQIj169x/hQrfAGuvDLKbywUalmon3pA +Y0FwiYw20pZPzPCUijptM3pOmEtlLd20OqJMKi+1jzHQbN6denAHOuFUHhwYXxuKQhuHp4U v2XVQhQM3XNzKi+AEac9wIvBdTKfUQtHCBQ5bnDqUEjgYOnzQGoD2J/9Ncs8TwvLoKbR6EcQ voec5hgV58PD55/4w/QsFjvO0qqsg7xcvbrDAM0dXQEZYPr9PFUWwXPUF3is2wRmauu4QhJW 8vGUhRArWSRnKCmJshKeKu9bpUgpSkZq4qrtu1Ouk9nP6vrPOdZAJrriW4jAE8M8Xdq68Fi9 RtqrZKa0EOBpw0JdpMe1Ta9LkDJ/lU27Y00ZybLSQkJ4xrBI93X58Fa9kCily7tkOU02fXAp Pig4i9g29hd8fiDq025vzw+V/SOZVYek9b+dDo9eVufY5V239r3HyBh+rMhoS+vt+ds4fT4i etx3h6cvQLmzNSR9iV05HL9pi+T+zBcaFx22evWa+0uZpsUX9xTt4+MG5DWFlsl4jVkuerq9 1Rq5c/OKI+0xUc+cP/8Ukm2OtG059+2BTqOBUZKk8OW0SZH+B0UdpIuoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3eVFrdldBlkORAianWn5tHMIohukiQV9LJs6c1Zm7Pd zbKI1ltu5avRw9UyRy/NnitXWaRGmnOJxXpQlkn2bpplpc1qav334Xy+53DgHAqXfycUVEam iTdmanRKMphw/65rmZibrE6Z7MwfDucb7QjaXjhwaLW2kLCncwcGT8qmQ1XlEQkUvbRgkFf0 BYPK0yIJn1q3EeDrqsTg+U23FIofbJNCV81bKexrsiF46/+Aw+GSrwia7Fck0FN9nYQOfykB eb1eBPnOegR1e78QYL3mQrBLpKHzzCkpOJ6HQldrPQHup5elcLa7GYcrjX0ICuvOI/Ds+iOZ Ecb1lpyQcI6q9xi3/3gzzt19ekDK7b1nx7iLPhfGddzyklyeswxxDW17cK789U8yKXipKs5o MJv4sVqDYJqmXMaCWsXGgEodGaNiI6KXx6qjlJPi49J4XUY2b5wUv1Kl9fgqiCxn8IZ377xS CzpHiSiIYuhIJn9nrUREwZScPoEY+/GDhIiogGCYj6/xwcwIxv9IJAczXxHT7nUPCJIex7hz 7Vi/CKGfkczD3VuJfjGCnsuIFTaynwk6nClursD6WUbHMqW19/5NHcOUX7g9wEGBernt5QDL 6Qxma8s1cpBDmcfHvmEFaFgJGlKGQnizoE/XC2qVoNEL5sx0VapBfwkFbn71bo/ThUTfghpE U0g5VJY1lU2RSzTZQo6+BjEUrgyRzfS4V8hlaZqcjbzRkGI063ihBkUFFizEFSNTDYEPyjSl sFFsNMSw0RHREVNAOUqWS1cny+l0jYlfy/NZvPF/H0YFKSzoJBV2tH11w7pLL2q1810zItxw 45X1c9ona+/N7Uu6E2d7vNc1G5MdZ5SJS1bNWz8rTHerL3Wduf3+Z0/VSS789GLnos7qeIWf 1Xdk1zdNYF3aOaWWjARrpCLWsnlNW8Lo3ZtsPx6yR5vuhCYp4uiDju7iQ1sWFuocjpzcN7+e iAVKQtBq2PG4UdD8Bbhh3CcJAwAA X-CMS-MailID: 20200811085328eucas1p27b1c8ff1901fd75ecb06c180c6c29d3d X-Msg-Generator: CA X-RootMTR: 20200811085328eucas1p27b1c8ff1901fd75ecb06c180c6c29d3d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085328eucas1p27b1c8ff1901fd75ecb06c180c6c29d3d References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 14/24] examples/l2fwd-crypt: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-crypto/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 827da9b3e..da3b12f4f 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -1734,6 +1734,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1753,14 +1754,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Aug 11 08:52:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75401 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83679A04C3; Tue, 11 Aug 2020 10:57:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BC4D1C1B9; Tue, 11 Aug 2020 10:53:32 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5E96A1C1B3 for ; Tue, 11 Aug 2020 10:53:31 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085331euoutp0149649b4aa6e1671ae2231d93899bced5~qKr17To7z0904909049euoutp01L; Tue, 11 Aug 2020 08:53:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085331euoutp0149649b4aa6e1671ae2231d93899bced5~qKr17To7z0904909049euoutp01L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136011; bh=SucFH4l3rSaiHqLe5lm4cnqm4i9He+Oklu5r03FX5EY=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=odo2bCqXmCewyF0dgT/0d11WlmtT2kdhXv8Czl3h4MsNGnKDXuh2U2PWqKM8giMtv NQRG/GdJYob6XbRK6zbnZOW3m7lmKHIRlPJ4OXSvzOaahrWI1RLIKUMHsdd4sJmc98 s/tEqZCY6h0+IV9Kg+fD5PIhdSlEUKwMGBhy0twY= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085330eucas1p1cd52bc67f04be0a784b60a1004df6dcb~qKr1dkJPn1188011880eucas1p1U; Tue, 11 Aug 2020 08:53:30 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id CD.2C.05997.A8C523F5; Tue, 11 Aug 2020 09:53:30 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200811085330eucas1p15e9a44970a46fa161477c76d90bd44c6~qKr1IXGoX1584615846eucas1p1I; Tue, 11 Aug 2020 08:53:30 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200811085330eusmtrp257d61ccb80fcc5f2ed517a809bfa5d6a~qKr1HaX-T2338923389eusmtrp2F; Tue, 11 Aug 2020 08:53:30 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-e4-5f325c8ae84b Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id E9.1B.06314.A8C523F5; Tue, 11 Aug 2020 09:53:30 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085328eusmtip1230748e5bb076d5b034a70fb9a4a014e~qKrzTlF3u1748717487eusmtip1T; Tue, 11 Aug 2020 08:53:28 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:34 +0300 Message-Id: <20200811085246.28735-16-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxTG9957e++l2nlXJJ4ggdhI0EVFUJMTXUANiTeLiYtbZmKGrJMb bIDCesGvvxgzDAuiQoMbkJaBRj6MHRYoMnBYE74KGEiYlIA0+IGIgHwlU2FKuRj/+53nnOc8 J29entYWsIG8wZgmmYz6JB2rZupb3/RsN/8QGbdzyhGK9i4rwdHH5TR6LcMs5ry+QOFAVTQ2 OUtUmD+SQWFe/gyFzgozi6+8mQxOzTopHGp2c1jUl8nhrGuMw0sPiwmOLb6k8Y/SOYIPrXUq fHO/kcXpxTIG8972E7xc206wLXeGQcvdBoJZZgFfV97ksHwoGGe97Qy6PQ4Oby300ljXtUTw apudYHfWe9X+TeLb0hsqsbxpnBIL/uylxVZPISfmdlgpsWaqgRKn7/WzYl5tFRE7R3Nosfrp f+w36uPqr+KlJMNpyRQe9aP6VGGmlU79V332+WQNm0FcvJn48SDshvJX7bSZqHmtUEGgMHea U4p5AiXDWUQp5gh0DixRHy227tuMj7XCTQLFlYeUoQUCzot9rK/BClvAnW2lfI31Qg0LzsVH K25/4TA0Z9uWA3meEULBNmXwyRphLzTl3KaVgBCo/qtlhf2W9eriEVoJC4ZHtvmVnSB08dA4 1ssqhhiwND9YZX942VbLKRwE7+/aVg2/Ebha7+CU4gqBX4snV6eioXaih/NdRAtbwd4Y7kMQ DkDTxD4FP4eByS98w/Qy5tdfoxVZA9lZWmWHDlo6+lZlgKV3axVZhIL5Z6zyPM0EvGUt1BUS UvQpqpSQKrJBSpeTEyQ50iid2SHrk+V0Y8KOkynJd8jyV3X/3zbfQBoXf3IRgSe6tZrUfRFx WpX+tHwu2UWAp3XrNQe73Se0mnj9ufOSKSXOlJ4kyS6ykWd0GzS7ysZjtUKCPk1KlKRUyfSx S/F+gRnkgmrcYswMOP+tJ6XT/6jR0Hl0wj743fV/9ngMg9uGtvNHPgs5EmU+nlcRfjnANBp0 K8gR23LneVyENTz1sGshl+lQq4ti0n5OnNTsDJajE8M8BylV6N/iid/j7z2J+doedez7gB7H xZMTrpmwul8sz2xl29Z5+1sTxko2vVgTcGNzrI6RT+kjvqRNsv4DZ7l8q6YDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSfUgTcRjH+93dbudweiyjwz+0DoqKWt1MfTSzF0HujwIp+qcsW3rpyDnZ bVJRpGYm0zRNpNI2bfSmYVmaGlY6Qq1ppeUbtrKSpCxfM1Rmtmn99+X7+T5fHngeCldMEb6U Jskg6JPUiSwpI+x/WhwbTNGqmE03sz3hXpsZwecPVhwGCh0kZI9lYNBbvg0aakskUPAxFYPc gnEMam+bSPgxkE7AyEQtBu+f2KVwtTNdChO2ISlceF2MYMj5HYcrpZMIXptrJDDT9JiEUed1 AnJnuxDkVbciaMkZJ6Cwvg5BpomGsTu3pGB97wcTA60E2PseSuHuVAcONW1zCPJb7iFoz5yX bF/Jz5bekPDWhm8Yf6msA+eb+4qkfM4LM8ZXjdRh/OjTLpLPrS5H/MvP2ThfMThNRsn2K8P0 OqNBWJGgEw1b2QMcqJRcCChVm0OUXEDwwVBVILsxPCxOSNSkCPqN4YeVCUXpZjy5W3b8688q MhXZKBPyoBh6M2NpryRMSEYp6BuImUztkpgQ5QIMMzyIL2aWMs5uE7mYmUTM2ZGvyA1Ieg1j zzJjbuBD95PM2/NphBsspXcxT7IsuLuIoFcxlhGN25bToUxDduW/Un+m4n7jgvZw+RXFHxe0 gtYwaY56clH7MT2WX9hF5FWKlpQjH8EoauO1IqcU1VrRmBSvjNVpHyDXyR81zzysQ51Ve22I phDrKU/ewsUoJOoU8YTWhhgKZ33kO9vthxTyOPWJk4JeF6M3JgqiDQW69svHfZfF6lwPlGSI 4QK5YAjhggOCA4KAXS7PopuiFXS82iAcE4RkQf9/DqM8fFMRhBZMl73LuNbe780PzLBUZO9v +UGSQ8bmFGt4ZW2P7HlZyW7nz4po1avS+Tzvc2/Gnn3aL1l/KjzOHNF4fvWRHY5RHdsyTp2O L2laG7HP5wVvbCsc7m7zl1yf9yIj5/Yc9S/4cCQtb/1g8ZdbjjdBSy6HpUVFbEs50/MjKGe1 Vy9LiAlqbh2uF9V/Acjk/sAIAwAA X-CMS-MailID: 20200811085330eucas1p15e9a44970a46fa161477c76d90bd44c6 X-Msg-Generator: CA X-RootMTR: 20200811085330eucas1p15e9a44970a46fa161477c76d90bd44c6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085330eucas1p15e9a44970a46fa161477c76d90bd44c6 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 15/24] examples/l2fwd-event: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-event/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c index 4fe500333..f43b61daf 100644 --- a/examples/l2fwd-event/main.c +++ b/examples/l2fwd-event/main.c @@ -366,6 +366,7 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status..."); fflush(stdout); @@ -389,14 +390,10 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - port_id, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", port_id); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", port_id, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Aug 11 08:52:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75402 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FD49A04C3; Tue, 11 Aug 2020 10:57:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B451F1C1C8; Tue, 11 Aug 2020 10:53:34 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1F1341C1BF for ; Tue, 11 Aug 2020 10:53:33 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085332euoutp02bcad0a2bdaaed3cf02f9bf33ac64011c~qKr3h5o8F0724507245euoutp02k; Tue, 11 Aug 2020 08:53:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200811085332euoutp02bcad0a2bdaaed3cf02f9bf33ac64011c~qKr3h5o8F0724507245euoutp02k DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136012; bh=b/FcqPCd9j+W8IX9nJTt/R8XFTRep+NsEaK9WjFu1tY=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=VVrYLOcBxe7lsEH2pmLgy4R9mqBsKR4gW+8pat+7/MSP0nuz2uY/xR2+ZpD36hNUR 2JB9uHy4wfM68IJiI05PBzW96g2lYv2ZkFXKNJ43Gqlvu2H+kqPIFxWZDwQi16UbtS 1x/LFG7fmGwmfc86LIqzMMWdjCDP+sSb5OsYVsfw= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200811085332eucas1p2c4185cb372c143918b7594b9da54fca9~qKr3WAV_Q1587515875eucas1p2Z; Tue, 11 Aug 2020 08:53:32 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id E4.FD.06318.C8C523F5; Tue, 11 Aug 2020 09:53:32 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085332eucas1p2a859ec9426e0c58abbda7c1bd4ef1b44~qKr24xnnP0327403274eucas1p2R; Tue, 11 Aug 2020 08:53:32 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085332eusmtrp1a229f74050a2364864686d10e05728ec~qKr235hOw1680216802eusmtrp1G; Tue, 11 Aug 2020 08:53:32 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-33-5f325c8c5e1a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id DF.5D.06017.C8C523F5; Tue, 11 Aug 2020 09:53:32 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085330eusmtip136deace1e04cac37513d983beaf841c3~qKr1F9LfY1748717487eusmtip1U; Tue, 11 Aug 2020 08:53:30 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:35 +0300 Message-Id: <20200811085246.28735-17-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSa0xTZxjOd87pOYdqzbGY8AaNxibNZJm3yfSNDJ1mm+cHP5Zlf7YxSzeP IELBFvDywzBdmGKHpVSnYiqXMCpgEOXa4GWNWOVwkU7CJdw0RgNORJTFsqK2nBr/PZf3ed8n Xz6e1trZaH6PKUsym4xpOlbNNN72d622Jn5qWNdQp8faDifBhyPlNI45hlk8MfUbhf1VW7G1 6bwK7aO5FBbYX1DY5Mpn8d+xIwxOTjdROHRN5vCc7wiH054nHP7RXUzwSWCCxrMlLwl2OxtU 6P/bzeLzQBmDBbO9BE/W3yHotb5g0NHSTDAvX8Cpi5Uclg8tx+mxOwzKA1c5rJnpobGhY45g obeWYGfeW9UXK8XZkgqVWN46TolFpT20eHvgNCda7zopsW6ymRKfX+9lxYL6KiK2PzxBi9WP XrPfqH9Qf75LStuTI5nXbklSp/SdraAyneoDl/oHVbnEyueTCB6EWJjw3VPlEzWvFVwELnSe pxXyioDP18sq5CWBHrubex+5P9hGFKOSQIt3OJyfCeZripjQFCusAvmYkwoZS4Q6FpoCfUHC 85HC1zBi3xiCjKCHEZs5BDXCZhj7NUXZvwKqL9+kQzgiKFcXj85jrbAc+i68mt8Iwi0e5nra KSXwJchuZ7hcJEx468N4GchFVkYJ/E6gsPEqpxAbgaPFz8JTW6H+aRcXakELMVDrXqvI2+D4 tDxfGYRF0P9scUimg9De+CetyBo4lqdVpnVw864vLAPM/b9QkUXw951ilfrXgm8ox9vIinMf TpUQUkWipGxLerJk2WCS9q+xGNMt2abkNb9kpF8hwZ8qv/HONJPrgZ89ROCJbqEmM269Qasy 5lgOpnsI8LRuiWZ7p7xTq9llPHhIMmcYzNlpksVDlvKMLkqzoWz8J62QbMyS9kpSpmR+71J8 RHQuSfAvm7zxl0Oz6m3AdTiqMNK5TfpsE/3gwIBLP9TxkUwZ4tIqHGVZJ6XX0Y9TF2zqbltq g7akf3YUlMRDS2/M1H/fx+oTBjsyDJW7jYmPSxv2+Q+/ac08dMNV6hmyTX53Rj/OqWbjUn+8 lZVKcr51HC+Dr0xTZzwL3Pc/aY+/kvBIx1hSjOs/ps0W4zui2Ce0pQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3cdTS5z0cWgbBSF1GybtqPZg4K69FfZH8XS1sUuznKb 7G6iRaT2kmWmpuKLZYr5qizfRkkKpbVEzHyWTkSSUnytMsMeU+m/D+f74MA5FC5zE75UtMnK W0xcjIKUEM4/7cM7U8PV+l2OmxRUv3MgGBspwWE0a5iEW7PXMBio3A/PGwtFkOlKxCAtcw6D xnI7CVOjyQRMzzdi8OmFUwz575PFMN82IYbbXQUIJpa+4pBX5EbQ5agXwWLrMxJmlooJSPvV i+BOXQeC9tQ5ArKamxDcsNMwW1EmhpJPG2F+tIMA52CtGB5+78ah/t1vBBnt1Qg6b/wVHdjM /ioqFbElz79g7N373Tj7ejBHzKa+cWDs0+kmjJ1p6SXZtLpKxL4du4WzVeM/yWMSnTLUYrZZ eT+DWbDuVZxWgVqpCgalOjBYqdJoI0LUQYqAfaHn+JjoON4SsO+s0tCfV4rFOiTxjwaGRIko lbIjL4qhA5kPQ6+QHUkoGV2KmM7ufsKOKI/AMJPj+KrHh1nqs5OrHjdiPj/OFy8LJL2dcaY4 sGVBTn8kmZ6bSSthH/owM5K5exkJeiszkm5ZRikdwowmGVYrNzFVT16u1Ht5xlUFrhWW0dFM 0nAzucobmf5737B05F2E1lQiOW8TjFFGQa0UOKNgM0UpI83GGuQ5eMPrxbomZJ8+0YZoCinW SmP3qPQyERcnJBjbEEPhCrn0YKfzjEx6jku4yFvMeosthhfaUJBnvQzcd12k2fM+JqteFaTS QrBKq9FqdoNivTSFbg2X0VGclb/A87G85X8Oo7x8E1HS0Rm/bZ25BeXrdVlhfgvnJX2S3MPy eVNhWc4pw4ZKXfyOyDB3LXn1wZ3rJon+0tCSvqZidjLX1DOh08iv8+lT3sP5DVfyDCddLu7B 4KG4Tce5ddmX4UTxEfuhmZSwiLs6PmRB+7PFP7G3b0vkYnH2ENaR+cMmzXDpFOz33lgFIRg4 lT9uEbh/bwFcCwYDAAA= X-CMS-MailID: 20200811085332eucas1p2a859ec9426e0c58abbda7c1bd4ef1b44 X-Msg-Generator: CA X-RootMTR: 20200811085332eucas1p2a859ec9426e0c58abbda7c1bd4ef1b44 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085332eucas1p2a859ec9426e0c58abbda7c1bd4ef1b44 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 16/24] examples/l2fwd: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index e04c601b5..b229a760a 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -571,6 +571,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -594,14 +595,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Aug 11 08:52:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75403 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2066CA04C3; Tue, 11 Aug 2020 10:57:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA47C1C1D5; Tue, 11 Aug 2020 10:53:36 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5CB4B1C1D0 for ; Tue, 11 Aug 2020 10:53:35 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085335euoutp0142067bf8074604de6970f6cb671f0ea4~qKr5pThdv0826508265euoutp017; Tue, 11 Aug 2020 08:53:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085335euoutp0142067bf8074604de6970f6cb671f0ea4~qKr5pThdv0826508265euoutp017 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136015; bh=8B29X3PKtMuTPHh3rG9R91AskagKWcSpF4U/3CmUWwQ=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Hzz9TikMPZ6PLDE/RKjevDbFD18/Lq0bMxJAfMGpoiJgghsaaMazWqF+KFi6+Pnu7 W5Y1MCxECvnOkdtSPCN+kg5wlNQsnNmXjFMTFuImcyqASoC28KZxppi2RgdhLhQbam UaKBgPV8zmQ3Pwx+FOVHBe0RWz7AClhax896ju8A= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085334eucas1p131f0796e9b71f9fe90b21320f191e83a~qKr5bjO7v1188011880eucas1p1Y; Tue, 11 Aug 2020 08:53:34 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 5E.B1.06456.E8C523F5; Tue, 11 Aug 2020 09:53:34 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085334eucas1p261a004aefcdd3819a9c5e029ddc9808d~qKr4xSWmM1587515875eucas1p2d; Tue, 11 Aug 2020 08:53:34 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200811085334eusmtrp29cc379b865d4218176bee3ad5dc77389~qKr4ubNfr2338923389eusmtrp2M; Tue, 11 Aug 2020 08:53:34 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-45-5f325c8e2dd6 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 3E.1B.06314.E8C523F5; Tue, 11 Aug 2020 09:53:34 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085332eusmtip128df9b1f326910b0bfe19fb17dac9c68~qKr25CoY11849018490eusmtip18; Tue, 11 Aug 2020 08:53:32 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:36 +0300 Message-Id: <20200811085246.28735-18-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTdxTGc+69vffS2e1aTTjTRWcTk00jwvTDCXtxb1mu2ZaMD2q26LDO GzSWii3gIGYhbGOmMEBEySirIBoRtiADWmpksmYBtAUGRBEVachcAwhCgSmvjvbW7Nt5fud5 zjn55y+y+jP8GvGwOVWxmI0mA6/lnK2znVvy976RGJs7F0u1PgfQ0INKlvzFAzzlTnzH0J3q HXTNVaahosEshvKLJhlyVdl4euTP5mg86GLofrNXoNKebIGCnoBAP3bZgQILIyz9VD4F1OVo 1NDsH1d5erxwnqP8uVtABQ3tQG15kxwVu5uAcmwSTVy+JFDl/XUU9Ldz5O2vF+iXmW6WGn2L QKfaaoE6cp5p3t0gz5Vf1MiV14YZ+XRFNyu39p8V5LwbDkauG29i5Me/3+Ll/IZqkG8O5bJy zd9P+c+0X2jfOqiYDqcrlq3v7NceKrAnpNzVft01eQGywC7aIEpEaTu2PvBobKAV9VIV4MI/ FZwqpgGf9vsYVUwBDvlHhOeRsTMFoDYuAQ603BZUMQPoXhpkQy5eeg29Jx3h+GqpjkfXQh8T aqySPsGZnzvDozhpI/7pXgoHdFI8jhXksOqK9VhzpSVcRy3zGrs6VC+tw75z0+GhKP0lYu/l OkYNfIhV4/WcWq/CkbaGyK2v4DP3uUjgB8BTznpBFYWA39rHIq4d2DAaOkkUWel1rL26VcXv YcAxwoQwSi/inbGVIcwul0XOElbFOjyZo1fdBmy50RPBiIvzK1QsY6/bGXngZsBHPhtXCOtL /99VDlAN0UqaNTlJscaZleMxVmOyNc2cFPPV0eTfYPmzepfagk0w03PAA5IIhhW6lDfjEvUa Y7o1I9kDKLKG1br3O7xf6nUHjRmZiuVooiXNpFg9sFbkDNG6beeH9+mlJGOqckRRUhTL8y4j Rq3JgvhjijfwaVln6+iJvmy2tKl5X3F3dObkroltHR+vfHhsj2XKa9o423/63vV7aSXcdB5k nn3yfSD1RELP5oEXBud5l63Q2ZKwMyneNdz+8nXzaPDVX5XFDxpjtjyZz+hk0tdu3/CSIyvx 7d3/fsQsLvl27i0JlMVC7/7jpoffVPhzP0cDZz1kjNvEWqzG/wAlm+ANqAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsVy+t/xu7p9MUbxBu19HBbrz8xjtHh0bzGz xYMpd9ksuj+0MFncWGVvsWf7HFaLSfcbmCz6Jn1ksti+oovN4s2DJhaLd5+2M1nc2Xua3WLW pSZ2i0+HnrNb9J6fzWjx/M8rZouZCz4zWpyft5XV4ufBXWwW7/8sYrHo+3WV0aJ/ywlGi+M9 H1kspuzcwWjR1iVg8WHlcnaLxXfkLD49OMFicfrmZnaLNV8vMltsPfOX0WLi8fWMFmfb/rM6 KHr8WrCU1WPxnpdMHpMXXmT2OHZzGrtHz8l5TB4b3+1g8ni/7yqbR9+WVYwepx51M3usfvKD LYArSs+mKL+0JFUhI7+4xFYp2tDCSM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS+j f3ZgwS2uivMflzA2MM7m6GLk5JAQMJF4O7WfsYuRi0NIYCmjRMvF1UxdjBxACQmJ10+YIWqE Jf5c62KDqPnMKPHl7G52kASbgIbE6Y55TCAJEYHbbBKX2xtZQBLCAj4SX+eeAytiEVCVOLLz H9gkXgEribf9bVBT5SVWbzgAZnMCxVfPvg9mCwlkSjTe3ckGYctJXJ//hWkCI98CRoZVjCKp pcW56bnFhnrFibnFpXnpesn5uZsYgVG+7djPzTsYL20MPsQowMGoxMNbYG0YL8SaWFZcmXuI UYKDWUmE1+ns6Tgh3pTEyqrUovz4otKc1OJDjKZAB05klhJNzgcmoLySeENTQ3MLS0NzY3Nj Mwslcd4OgYMxQgLpiSWp2ampBalFMH1MHJxSDYwCwjkXCzmLSk7dz++9OMfxh3If7zrVIvX9 e7/kZjkLGDg5LX8ob8j9+KgKt5/i9PeJbl4p54xXP1+YmRZSl63lY/RM2upIZLqOr2rF0521 4TqLYtPlMjmkeY7enCy86HFV5o9LO/aLqu2akClc4GT0dNLXja6rJr1arBP5Xs576+biI+tn /VdiKc5INNRiLipOBAA81NqeCAMAAA== X-CMS-MailID: 20200811085334eucas1p261a004aefcdd3819a9c5e029ddc9808d X-Msg-Generator: CA X-RootMTR: 20200811085334eucas1p261a004aefcdd3819a9c5e029ddc9808d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085334eucas1p261a004aefcdd3819a9c5e029ddc9808d References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 17/24] examples/l3fwd-graph: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-graph/main.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index c70270c4d..ccf55859f 100644 --- a/examples/l3fwd-graph/main.c +++ b/examples/l3fwd-graph/main.c @@ -599,6 +599,7 @@ check_all_ports_link_status(uint32_t port_mask) struct rte_eth_link link; uint16_t portid; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -623,16 +624,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* Print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port%d Link Up. Speed %u Mbps " - "-%s\n", - portid, link.link_speed, - (link.link_duplex == - ETH_LINK_FULL_DUPLEX) - ? ("full-duplex") - : ("half-duplex\n")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* Clear all_ports_up flag if any link down */ From patchwork Tue Aug 11 08:52:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75404 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67373A04C3; Tue, 11 Aug 2020 10:58:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2453C1C1DD; Tue, 11 Aug 2020 10:53:39 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id CE0221C1D2 for ; Tue, 11 Aug 2020 10:53:36 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085336euoutp01fb831d90ccafbf4d98eeffe7475c16d1~qKr7BqFdU0904509045euoutp01P; Tue, 11 Aug 2020 08:53:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085336euoutp01fb831d90ccafbf4d98eeffe7475c16d1~qKr7BqFdU0904509045euoutp01P DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136016; bh=Saq1UnDTMyInlHRQMQ1mmtOASs5FmeYLGJOeDi0MAGU=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=UGy3kCSEcdDMKmvdSlcASw8XtFepeFlMRowDd6v324sG/p8+XHe3tJ9B6GYwvgWmR ivxlfSZQewbATEb1Mfrwwnc+EHHzaeNb5hmULxOQcfSSvWKu7KiCidcrhQ3KHoyVfW xZtQZ6gxTfDTZq9onu+R+oIfkWKJjxt9bcJhhgZ4= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085336eucas1p1d155caffdee6b1562cfd86298f67875c~qKr61O4_R1537215372eucas1p1A; Tue, 11 Aug 2020 08:53:36 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 71.C1.06456.09C523F5; Tue, 11 Aug 2020 09:53:36 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085336eucas1p239879bd738b4725f673b033e25056a30~qKr6h4mYU1211012110eucas1p2k; Tue, 11 Aug 2020 08:53:36 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085336eusmtrp17bc2e56cef0ffbeb93d48b0d571c33be~qKr6gjS1j1680216802eusmtrp1J; Tue, 11 Aug 2020 08:53:36 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-49-5f325c90d6f1 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id A3.6D.06017.F8C523F5; Tue, 11 Aug 2020 09:53:36 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085334eusmtip19cf7241a5333c4e7ebf2e0886ddc8992~qKr4wNptD1807218072eusmtip1X; Tue, 11 Aug 2020 08:53:34 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:37 +0300 Message-Id: <20200811085246.28735-19-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSf0wTdxTPu7veHdXqWYx8g78vbtnMpjDM8rK5icbEW6LGmDgTsg1PvIAR KulZnRo3xKVqqcgP0Qy0ImyCxYwBpXQMjBIDavkhbAxYdLLKYqwKpdo4lKrQY9l/n5/vJS+P p42FbCy/07RHMZvkdJHVM+7Wsc738774IDmu6M85WN3uAPT9VU7j4Km7LOYEvqOw37kKmxrO 6rDgXhaFuQWjFDZU2lh8PJjN4HCwgcI7zV4Oi3uyOQy2PODwRFcJ4INxP43flz4F7HLU63Ds WiOLI+NlDOa+6AU86boB2GYfZfDULx5Aq03AwKUKDsvvLMDg4A0GvQN1HF4OddNY3x4GzG+r BuywvtYlLpZelP6ok8qbHlJS4YVuWmodOM1J9psOSqoZ9lDSyJVeVsp1OUG65cuhpaqhf9lN +iT9yh1K+s69inn5p9v0acOeITqzU/+1+4cVWeDmbcDzRFhBjpyLtoGeNwqVQHKKL1MaeQak 7ETrFHkKpKi+n7ZBVKRRc78XNKMCiP/6SVYjoYmKs4+bTLHCO8R7zBGpzxZqWNIw3kdNGtHC evLb3aFIiBHeIkWDhyNjDcJHJHCtndVWLCRVP1+N6FETelXJvQg2CgtI3/lnkaFEuM2TsT9u gVZYSxyBMZ2Go4m/zcVpeB7xFtoZrXAUSL67jtNIHpAjJU+mUquI61EnN3kPWniXVDcu1+TV pNt+jtHONIP0P5k1KdMTsMB9htZkAzlmNWppkVy92TMlExJ+OV2DErmfHaPdpxlIbb4f8mBh 8f+rSgGcEKNY1IxURY03KfuWqXKGajGlLkvZnVELE6/qfdUW9ECoZ3sLCDyI0w2ZH8cnG3Xy XnV/RgsQnhZnG9Z0eL8yGnbI+w8o5t3JZku6orbAXJ4RYwwJZQ+/NAqp8h5ll6JkKub/XIqP is2C95Z0hn+qmNcjbv62asuZ24v01rSL8xc9EgOe2n98dR82v/TNOvC3+2KrmPL71sN5oSse n2nDN03WhPMVzfL6TY1Zz8Of2Y4mDRz63DonmFDZkTgtbiAplbUdH0nsqLb8WiQ//qQmZPHz r9fFbqx3v21fGtbFqd3OroOu0blLzs5M8YqMmibHL6XNqvwGfByg/KYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdnYcLk5T65+R1cKKoNWmtlcziz7EgbKSCLpYOuwwRedk Z2oWhoqYHUvtZpRllrdyUVnzFnbRIrN5ScXKdCkqihZm60KJXabSt4fn9zwvL7wvQyq+U55M VKyZN8XqYpS0jLL9abSvyQ3VhK27WIHgbnMBgoEPRST0n7fTkDWRTsC78k1QV31FAmf7UgjI PvuFgOqbIg2f+tMoGHdUE9D7yCaFyx1pUnA0jEjhdFs+gpGpMRIuFX5F0FZQKYFf9Q9p+Dx1 g4LsyS4EOdaXCBpPfaHgfG0NggyRhYlbZVIo6vUCR/9LCmzdD6Rw+3s7CZXNvxGcabyLoCXj r2TzMm6ysETCFdWNEty56+0k96I7T8qdaioguIrxGoL7/LiL5rKt5Yh7NZBFcpahn/Qu2X5V oMkYb+aXRhoF80blATVoVGp/UGl8/VVqH+3BAI2fcm1Q4GE+JiqBN60NCldFjtcMkXGtsiNV xb4pqIoRkQuDWV9cMdiFRCRjFGwJwil5JVIRMU6A8cchcjbjhqfeiPRs5ivCg8WvZwDNrsK2 zAJiGrizPTTuPJFKTQM3djvutA9JpzXFeuML/akzBTkbgCfqm+nZqUuw5d7TGd/F6Vvy+2a0 go3CqfZaelZ74bfXvhG5aG4hmlOO3Pl4waA3CBqVoDMI8bF6VYTRcB85T1714pe1BonjuxsQ yyClqzxugzpMIdElCEmGBoQZUuku39JiO6SQH9YlHeVNxjBTfAwvNCA/54JnSE+PCKPzgWLN YWo/tRb81Vofrc96UC6QZ7L1oQpWrzPz0Twfx5v+9wjGxTMFhSTnnSuhFj1b+J4azpm/xmY9 odmjsnQcE/cvchX3Na3oxY6dwXTp8r1cdNxS8kdFuL6NCJ4XnPj03fDzHRHa49scZd5jzclB QuIdNvP5m57WrVeLn9AnK6M9YpLqrIGhqcmPtpzUTy6+6DMafkmbftNeHrBymUd66aZei2Ey ZK9MSQmROvVq0iTo/gHh2SwFCAMAAA== X-CMS-MailID: 20200811085336eucas1p239879bd738b4725f673b033e25056a30 X-Msg-Generator: CA X-RootMTR: 20200811085336eucas1p239879bd738b4725f673b033e25056a30 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085336eucas1p239879bd738b4725f673b033e25056a30 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 18/24] examples/l3fwd-power: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-power/main.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 9db94ce04..ff862fbc8 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1945,6 +1945,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1964,15 +1965,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint8_t)portid, - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Aug 11 08:52:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75405 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17BD1A04C3; Tue, 11 Aug 2020 10:58:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53B0A1C1E5; Tue, 11 Aug 2020 10:53:42 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 0BAFD1C1DC for ; Tue, 11 Aug 2020 10:53:39 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085338euoutp02323e5f98eac6921a0234b04239ca3195~qKr9Di6uA0724507245euoutp02o; Tue, 11 Aug 2020 08:53:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200811085338euoutp02323e5f98eac6921a0234b04239ca3195~qKr9Di6uA0724507245euoutp02o DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136018; bh=eiFmzpP/WtyT5kv8HiwRyX/NJBmfHYjorTGhRagslq4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=snwN3vBO9SKWTuuOT60KS7ET1PKpRQ4pp3mRYJ3xZpw58wrDjnHIdc5292UXVkrHR ly6GDnvUyQ/me4+D/0Hwxuc1ZWsEKfXtLDqVntgXGEAvACeBTgCE6AIQlZxXn7tvlU X/AlRHTOo7xv82z6kheB8OndN7KrOjMT7r4SJMok= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200811085338eucas1p28f7790644ebba32399379a80223a3282~qKr8vP6_P1211012110eucas1p2o; Tue, 11 Aug 2020 08:53:38 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 15.C1.06456.29C523F5; Tue, 11 Aug 2020 09:53:38 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085338eucas1p22bc87cd8b124722fc751b15c341e5549~qKr8YyRG-3145931459eucas1p2e; Tue, 11 Aug 2020 08:53:38 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085338eusmtrp15ea9d244f2ac6e434007bd763f681997~qKr8X32xM1680216802eusmtrp1L; Tue, 11 Aug 2020 08:53:38 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-51-5f325c9267a4 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 56.6D.06017.19C523F5; Tue, 11 Aug 2020 09:53:38 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085336eusmtip11b63d742faa8457ba8c16d1398fc840f~qKr6gw4YV1865118651eusmtip1Y; Tue, 11 Aug 2020 08:53:36 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:38 +0300 Message-Id: <20200811085246.28735-20-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTdxTGd+69vffSWHNXiZ7UBWK3ZZtGGc7Ek7kNMftwsyyLiV+MOliV GzSDii34lixBRhgryLAwja0yFJkKJEXBljedJdMCrYBkHS9hgrjNtylQqJmKMuit2bfn/M7z nHPyz19k9eW8QdxlzlYsZlOGkddy7utPu1fat61OfT90ykCuQAXQ2K0qlkbL/+CpaCKfoYGa JGrznNCQfSSXoRL7JEOeczae/hnN4+hxyMPQ8GW/QI6+PIFC7XcFOtzjBLo784Cl45VTQD0V lzT01NvC0/jMaY5KngWBfmjsAPIVT3JU3twEVGCTaOL8WYGqhuMoNNrBkX+wQaC68E2WLgVe AB3xuYBuFMxq1i+Tn1VWa+SqtvuMXHbqJitfHzwqyMWdFYx84XETI49fCfJySWMNyF1jRaxc ++e//EbtFu1HaUrGrr2KJeGTr7Q7G44vz2pdvH/UfQxyoUhvgxgRpTUYyK/jbKAV9dI5wN5g j6AW04DNrSejnSlAX8EvzKvIvZfdjNo4C3j0yQCrFmFA+9RDYd7FS++iv7Ai4oqVLvDomemP xBdJn+O1v3MjJk56G89PDrHzWid9iNPD+YK6Ih5r669GeMwcr3WORLReisP+n6YjQ1HqELHu 2m1eDXyKbbNhUPUifOBrjA56A/1lxZwa+A7wiLtBUItSwG+dj6KuJGx82D2nRZGV3kNXS4KK k/FXbzc7j1FaiAOPXp/H7Jy0u49FsQ4LC6IvacSrnX1RjPji+QIVy3jC5wH1/MuAv/caSyHe 8f+qSoAaWKLkWDPTFWuiWdm3ymrKtOaY01ft2J15Eeb+qv+lL9QE4b7t7SCJYFygy1qXmKrX mPZaD2S2A4qsMVa34YY/Ra9LMx04qFh2p1pyMhRrOywVOeMS3Qen73+pl9JN2crXipKlWF51 GTHGkAux468NdFV77d6DKanfM4Z7axd/497fu1U8uXph618jCdr0hJWHCkVpa8sG1+E7wjuO bNdEadmeofoz/UPO2q7OZkf4+SBTH0jeNJbxc9aetM9+DK772Psk3mk2KEmGQHjEsvnQphbb b1WFccKbNcGL295KXja4tOSLjdWzeetXpDgmjZx1pylxOWuxmv4DRyZSH6cDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG/Z/bprY6TKt/QhcHUZnNzry9ZtkFgkNIFME+pLWGnlRym+xM qT5Nu9k0yymJGsuSVWrRzVtlocu0Wks0ulheVkR2NS8Fqctak749PL/neXnhfaWk/CcVIs3Q mwSjXpupYAIo53Rn/yprskqzuu8EgqtPbAjeDVST4C7tZ6Bg5DABr2rXQ0vTGRqsg2YCiqyj BDRdsjDw1Z1HwfBYEwF9d50SqOjJk8CYY0gCJ7oqEQx5PpNQXjWOoMvWQMNE220GvnvOU1A0 +RzByfqHCDoLRykovdWM4KiFhZGaixKo7lsEY+6HFDh7b0rg8s9uEhqe/EZQ3HkVgevoH3pD KD9ZZaf56pZPBF9yrpvkO3pPS/jCRzaCvz7cTPDf7z1n+KL6WsQ/fldA8nXvfzHbAnYq1xoN 2SZhSbpBNK1TJHGgUnJxoFRFxSm5yNhda1TRioiEtalCZkaOYIxI2KNMv1kelnVn3n53Yxky owK5BflLMRuFP04/JSwoQCpn7QgfsQ7QFiT1Aoy/vCdnMkHY88LCzGTGEW4ef+EDDLscO/Nt vnIw+4bBz47lUv9AEJuIH3wwS/5pil2Ka0Zf+woydg3+0XdYMjN1Ma671urz/b1+XeWgT8vZ DJzbf4uZ0Yvwy7M/iFNodhXyq0XBQraoS9OJKqWo1YnZ+jRlikF3A3lP3tgxUd+MLMM7HIiV IsUsWVY8p5HT2hzxgM6BsJRUBMs2uZy75bJU7YGDgtGgMWZnCqIDRXsXLCZD5qYYvA+kN2m4 aC4W4rjYyNjIGFDMl+WzbclyNk1rEvYJQpZg/N8jpP4hZmQu8JuKiSp2bfRsdI202y7L7Elz PEWl7Vv1NW8JHFGWX7iwh20/Eiq4J8esmik6cRyh8pj7Nn+HPd6gU6cFbrlSor6dcjypKfDC 9m664luxusxQ2XaodfO069XgAnUCZ6fjV2g2qMMDa26E2yyVx6fxsui2vSsrShN/a0teKigx XcuFkUZR+xerYRF7CAMAAA== X-CMS-MailID: 20200811085338eucas1p22bc87cd8b124722fc751b15c341e5549 X-Msg-Generator: CA X-RootMTR: 20200811085338eucas1p22bc87cd8b124722fc751b15c341e5549 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085338eucas1p22bc87cd8b124722fc751b15c341e5549 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 19/24] examples/multi_proc*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- .../client_server_mp/mp_server/init.c | 15 ++++++--------- examples/multi_process/symmetric_mp/main.c | 13 +++++-------- 2 files changed, 11 insertions(+), 17 deletions(-) diff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c index c2ec07ac6..bb194fecf 100644 --- a/examples/multi_process/client_server_mp/mp_server/init.c +++ b/examples/multi_process/client_server_mp/mp_server/init.c @@ -185,6 +185,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -204,15 +205,11 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", ports->id[portid], - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)ports->id[portid]); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", + (uint8_t)ports->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c index 9a16e198c..d3aec32cb 100644 --- a/examples/multi_process/symmetric_mp/main.c +++ b/examples/multi_process/symmetric_mp/main.c @@ -365,6 +365,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -384,14 +385,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Aug 11 08:52:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75406 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D0EAA04D9; Tue, 11 Aug 2020 10:58:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 850961C1EF; Tue, 11 Aug 2020 10:53:43 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1A2861C1C2 for ; Tue, 11 Aug 2020 10:53:41 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085340euoutp0243c20fddc9a9a811d1329f2ab61c411d~qKr__FsVR0724507245euoutp02p; Tue, 11 Aug 2020 08:53:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200811085340euoutp0243c20fddc9a9a811d1329f2ab61c411d~qKr__FsVR0724507245euoutp02p DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136020; bh=SmiMTd0WaHVmbH+/Z7cpYx5nxYplTVxbf/UObRyYs1o=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=aWvXd7F2hO12V6fGJ9onZh/wNBOSHFssIcJX005l34yQR93ZVR8BaJYDBQjZyb04y DZnHW5zh1BaJiGIJoQ2D6UgNpOSzhL2ivLshUzNZ41SptXo4bkXSo0yFhpxy6CngdT x37Rr5G1u6nV8FarrG1juu7emB5gIHSS+1fXx/s4= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085340eucas1p18cda1b5d78089a5bc390d5ff8202ea22~qKr_t2ECQ1584815848eucas1p1I; Tue, 11 Aug 2020 08:53:40 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 13.3C.05997.49C523F5; Tue, 11 Aug 2020 09:53:40 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200811085340eucas1p133dfbd6a70d75c7a4c7ddb285d9cddf4~qKr_QLJJP1585815858eucas1p1S; Tue, 11 Aug 2020 08:53:40 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085340eusmtrp18947bbc95e8f2de98e2d2bbeb094b9d6~qKr_PRYLk1680216802eusmtrp1N; Tue, 11 Aug 2020 08:53:40 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-05-5f325c9460d2 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id F8.6D.06017.39C523F5; Tue, 11 Aug 2020 09:53:40 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085338eusmtip1763e1d81ed9248af180f68a8730fc074~qKr8XyOtc1801618016eusmtip1V; Tue, 11 Aug 2020 08:53:38 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:39 +0300 Message-Id: <20200811085246.28735-21-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUwUZxDGO7t7u8uFM+tByoQ2GjZpYk0qRZpmog2UxqQbbSJRExNTi2fZ nlZAuAVb/ItQpeZERMAPQI+vKh4YUTk+RUBMOOAOKaaCJKhIqMQPRBEpULTl2Gv63/P8npl3 JpNXZM0n+VBxb1KqakuyJMi8kavvnOv7pODbtXGf/tkmU43XATT6oIKlkYL7PB19eYihe1XR 1NJw1kB5DzMYysl7xVDDRTtPz0cyOXox1cDQ8A2PQEV3MgWa6hgX6FhfMdD4wlOWCktfA/U5 6gw0d7OZp8mFco5y5u8CHXd1AbmzX3FU0NQIlGWX6KWzUqCK4RU0NdLFkWeoVqBLb/pZqvO+ BTrhrgHqzfrH8GWYMl963qBUtDxhlPyyflbpHDolKNndDka5+qKRUSZb7/JKjqsKlJ7Ro6xS PTbLxxp3GL+IVxP2HlBt4VG7jHuKBroMyV7x55nOdj4DRng7BIgofYaZY3+BHYyiWboI2HJ/ itPNNGBv/1l/8hrw1jlforcU5wwwelAJ2FRyxW/eAA6d9jK+Kl5ahZ4jjqUgWLrKY8PC4FIQ JG3Asgtewac56SNsnnQubiKKJmkdPptL0SesxOor7axPByzi6uKHS9osrcDBkumlN1HqErF8 7BajN2zAY48nWV0H4VO3S9D1h+jJz+b0hl8BT9TXCrrJBfyleMJfFY2uZ7cF3xas9DHWNIfr OAZLWp0GH0ZpGd6bWO7D7KLMqz/N6tiER7LMerWM7d13/Bjx7d+BOlawrtbhv88NQGe+B3Jh ZdH/s0oBqiBETdMSraq2Nkn9aY1mSdTSkqxrvt+feA0WP6vnnXu6EZoXdneAJIIcaEpeHxFn NlgOaOmJHYAiKwebvur1fGc2xVvSD6q2/XG2tARV64APRE4OMUWWP9lplqyWVHWfqiartv9S RgwIzYAw72/ZjvfOXHK3HWyaKFSVLbGHwlNuG8PeP/x44POAmWujMWrEzpDklNBp1/mt89+s Co7S8uMvR+/ujHy0cXvk74oczG3f3PN10L7Y1L7xqPWbytI3XpiVN8X8GDjzh3MQu3uGHcdP Pmizt/6wbTaCnyt8Z626fvjcxDbr88qyxp7+XJnT9lgiVrM2zfIvuSxCMqgDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzVSe0hTcRTud+/d3Z05u02jy/4wG0URNNvUdlxmEUE3qOgBCaWuoVddOae7 MzIi1KJs1UqTKI35zMoFLdN89FRBrWnioqWUTmwQZfhOcthjTvrv43yP88E5FC6ZIaSULsPE GTO06TIygHD86RzcWByv1Gzy5MCjbiuCkaEqHIaLB0m4PHEeg/7abfC88Y4Aity5GFiKJjFo vG8m4cdwPgFjU40YfH7hEEKJM18IU21fhXC1txTB1/nvONwun0bQa20QwFxrCwnj85UEWLwf EFyr70LQeWWSgOLmJgQXzDRMPLgnhKrPoTA13EWAY+CJEB7+7MOhofs3gsLORwh6LvwVbF/N esvvCtiq598w9kZFH852DNwUslfeWDH28VgTxo6//ECylvpaxL4duYyzNs8vcn/AEXmM0ZBt 4sLSDLxpq+yoApRyRTTIlZHRckWEKkGtjJKFx8Ykc+m6k5wxPPaYPK3E1SXI7KZOzXa8JnPR MGlGIoqhI5lSiwszowBKQt9FzI9qO25GlI9gmFEPvqgJZuZdZnJRM42YgpIi4QJB0usZR4HV bw6hP5HM+4t5xAIRTO9kKmq6/SKCXsu0jD8gF0LFtJoZnctaDF3F2Oyv/QtEvrGt1O3HElrH 5A02k4s4lPlYNoNdR0HlaEktCuGyeX2qnlfKea2ez85IlScZ9HXId/GnHXP1Tcg8dqgN0RSS BYoztyg0EoH2JJ+jb0MMhctCxDt6HIkScbI25zRnNGiM2ekc34aifP0KcemKJIPvfzJMGkWU QgXRClWEKmIzyFaKC+jWeAmdqjVxJzgukzP+92GUSJqLXDOSx4G7lwfOWnPfHQ59Vh2nyzw3 GR+1LCby7Br1yBLn9/7fznMaZBBpHyYeurV0jSalcFS6/W+ZKj/xmrTde2mfZqhyXc+uvc+q 7C1BwV6nyO5xJtXtkwYJUmL07ZsdZ94n61pD3Aez4o5vsiTUhKE9tsDYL68OhKmb565Wu6/L CD5Nq9iAG3ntPxKgPzsHAwAA X-CMS-MailID: 20200811085340eucas1p133dfbd6a70d75c7a4c7ddb285d9cddf4 X-Msg-Generator: CA X-RootMTR: 20200811085340eucas1p133dfbd6a70d75c7a4c7ddb285d9cddf4 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085340eucas1p133dfbd6a70d75c7a4c7ddb285d9cddf4 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 20/24] examples/ntb: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ntb/ntb_fwd.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index eba8ebf9f..abb05a612 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -729,6 +729,7 @@ start_pkt_fwd(void) struct rte_eth_link eth_link; uint32_t lcore_id; int ret, i; + char link_status_text[ETH_LINK_MAX_STR_LEN]; ret = ntb_fwd_config_setup(); if (ret < 0) { @@ -747,11 +748,11 @@ start_pkt_fwd(void) return; } if (eth_link.link_status) { - printf("Eth%u Link Up. Speed %u Mbps - %s\n", - eth_port_id, eth_link.link_speed, - (eth_link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, + ð_link); + printf("Eth%u %s\n", eth_port_id, + link_status_text); break; } } From patchwork Tue Aug 11 08:52:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75407 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00C91A04D9; Tue, 11 Aug 2020 10:58:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2C571C202; Tue, 11 Aug 2020 10:53:44 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id D792E1C1EB for ; Tue, 11 Aug 2020 10:53:42 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085342euoutp0221e6f5bce62a52a2e2d22f050b006a1d~qKsApEd0l0674006740euoutp02T; Tue, 11 Aug 2020 08:53:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200811085342euoutp0221e6f5bce62a52a2e2d22f050b006a1d~qKsApEd0l0674006740euoutp02T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136022; bh=LRORBOggtz49UEFwPLXkqDJxBG0kESiE4Ao8Fn0DyTQ=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=MTzIj5AvQSlR+7UTLWYVwMvUoqS8iWUVfea86teHs0OXH/Llh5/d0YCfk2psufTAv /ywdBLl3krXZilw3mOAv6tD88GlUaxN89ndTzkKThQ45PTHZvmX6ZA1izgAoVOrTFJ O9L/Ry4IklywOSckzTW6QEUgbf92lgzpMsAB77w8= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200811085342eucas1p20fa2556e69251c9a416610fe3b1c9b97~qKsAbnsHJ1791917919eucas1p2U; Tue, 11 Aug 2020 08:53:42 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id A9.C1.06456.69C523F5; Tue, 11 Aug 2020 09:53:42 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200811085342eucas1p18fc9692be1516b1b97db78406696a78d~qKsABoi4d1584215842eucas1p1Q; Tue, 11 Aug 2020 08:53:42 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085341eusmtrp1faef40d10a5ce7103a56ea428729a672~qKsAAptmY1680216802eusmtrp1P; Tue, 11 Aug 2020 08:53:41 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-5d-5f325c961530 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id EB.6D.06017.59C523F5; Tue, 11 Aug 2020 09:53:41 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085340eusmtip14b770f13aa05e846ee0e357ed415ba23~qKr_O9OyY1807218072eusmtip1Y; Tue, 11 Aug 2020 08:53:40 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:40 +0300 Message-Id: <20200811085246.28735-22-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSa0wTaRT1m5nODMWa2RHDDRqMTYy68bH4ylUJihozPzTR+EeNLltlRGNB 0gqIibE+QFMQsRKMoAXBB4K7FUEKBFltFChF1KoBE1QEEwUFeUekPlqmxn/nnHvuufd++Xha zGJD+L1xB2RDnE6vZdVMRd1o87zs7Quj/nL2BaGtyUqw43Uhje1Zr1hM6ztBYWvxSqyxX1Sh 5Y2JwgxLP4X2IjOLn9qPMdg7YKew7a6Lwxz3MQ4HHO85PP04l+B7TzeNF/IHCT623lHh6P1q Fj97ChjM+PqC4JnyBoL16f0MZlVVEkw1C9h34zqHhW2hONDewKDrZRmHN4ef0nin6RvBs/U2 go9Sf6hWzZC+5l9VSYU1XZR07vJTWqp7mc1J6U4rJZX2VlLS59oXrJRRXkykxo40Wip594Xd qN6mDo+W9XsTZcOCiH/Ue67dsKnirYEHn9hv0iZiCTCTAB6ExfA2N4c1EzUvCkUE+itGOIUM eUnaGKOQQQJnPzXSv1rMzzxEKVwnMNLUSitkmEBZyn+Mz8UKs8F1ykr5CkFCKQt2T4uX8Pxk YT0UPV/q8zDCTHjd8mE8VSMsB0vTA06ZMB1Kbt0b1wO8eknum3EsCqHQkjc0ngnCAx66s2uI 0rAWqjoc/vUmQ3d9uT9oGrjOpTNKw0nvDRVlnEIyCRzP7fG7VkL5x2bOtx0tzAFb9QIfBCES 8t2sAidBa88fPjPthZaK87Qia+BUqqhkaOGe0+2XAb6NTVRkCVyjdf5HvEugpN3BZZLpOb9H 5RNSTILlBGNsjGwMi5OT5ht1scaEuJj5u/bH3ibev+r6Xj9QSYbdOx1E4Il2oiZ+RViUqNIl GpNjHQR4WhukWf3I9beoidYlH5IN+6MMCXrZ6CBTeUYbrFlU0LVDFGJ0B+R9shwvG35VKT4g xESi5cU9R1QRyfr7S6yvdqREHj6xTny2NThjmWPDlPCO25dWuPSbQ0xpdGdfdbKtcmy3M685 dE1NzBCTFHExzxo42jnLBHM3OSdkdvbu6zo6Ei7uvpV5fpe7oKrh37Vb5LmB89quPLywc3sw +9CTsrl2zswzWzQfVzemlH6RI2GQ+79Wyxj36ML+pA1G3U9saIiCpwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzVSeUhTcRzv965t1uw1rX5IaQ2CCFq9qe2rnQTBi4rCIKJLRz6m5JzsbaZF MUVMnmW5LtRampgnmjZTuxuS5TS11C41CaHD0LRLZVZT6b8Pn4svfL5yUvWTCpDHxlsEc7w+ Ts34UO4/Tb0rLx7QRq5urtVBVYsDwYe+QhL6L/QykPktjYDXZRvhXt0VGuzvbQRk2UcIqCuR GPjan0rB0GgdAT333TLIfZEqg1HXRxmcactD8NHzhYSc/O8I2hy1NIw/vsPAsOc6BVkTXQjO Op8iaDo9QsGFhnoE6RIL30qLZVDYEwij/U8pcL+5JYOKnx0k1LZMIshuqkLQmv6X3rSUn8gv ovnCe58J/nxBB8k/eXNJxp9+5iD46qF6gh9+0MXwWc4yxDd/yCT58oExZpfPPs06s8lqEZbE mETLevV+DrQaLgw02pAwDResOxiuDVWv2rAuWoiLTRTMqzZEaWJulFbRCY7ZSe11FaQN2RUS UsgxG4Kllx4kIR+5ii1C+OpYCSEhuVfAeHCAnPH4YU+3xMx4viP89vczYkpg2OXYneEgpgR/ 9h2DX55KoabCfux2XNK5ZspDsctw36tP00VKNhzbWxplM6VBuPzmo2le4eXL895PYxUbi1N6 G5gZHIhfXftBnEO++WhWGfIXrKLRYBS1GlFvFK3xBs1hk7EGeSe//WTcWY+kod0uxMqReo4y YS0XqaL1iWKy0YWwnFT7Kze3ug+plNH65GOC2RRptsYJoguFeg/MJgPmHzZ5HyjeEsmFcjoI 43TBuuA1oF6ozGAfH1CxBr1FOCIICYL5f46QKwJsqJNf1HX8V5BfbL+hJj0l1LWnPbr1Vu3J 3LlbncWVfRn3A4Mj7PtNdGt12LbLc/xHimja91DePJuU2xi1QyEbIhcc7EqcTG4frIlofDhW tBPnlK580fN8kWq9sziN5Hz33l2cdGK3snKLrftydl5IgWH84t5J60C4J0hMSBSr246qKTFG z60gzaL+H8/QopQIAwAA X-CMS-MailID: 20200811085342eucas1p18fc9692be1516b1b97db78406696a78d X-Msg-Generator: CA X-RootMTR: 20200811085342eucas1p18fc9692be1516b1b97db78406696a78d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085342eucas1p18fc9692be1516b1b97db78406696a78d References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 21/24] example/performance*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/performance-thread/l3fwd-thread/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 84c1d7b3a..15aa25054 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -3433,6 +3433,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -3452,14 +3453,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Aug 11 08:52:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75408 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CBC7A04D9; Tue, 11 Aug 2020 10:59:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA1C71C20A; Tue, 11 Aug 2020 10:53:45 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id DC60B1C204 for ; Tue, 11 Aug 2020 10:53:44 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085344euoutp018c1cec1311ee601357792456a7215629~qKsCfvC_G0904509045euoutp01Z; Tue, 11 Aug 2020 08:53:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085344euoutp018c1cec1311ee601357792456a7215629~qKsCfvC_G0904509045euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136024; bh=+UcMist8Ega1rfcImf6H5u2W7IOStGDetiboH2IeCCg=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=u38CBT7t48osU9+gmQbxOw9yUlPvQdy3ads4ziDW2N0mqWjhLvlZPs5ce5Nz1BmzX kZERXrjZw7cSAFk2aSiXubo706UjpDgaE8oe3SL69ZT4T7D+0oij7C7/ZbT05YCCli ruBwW6y0xPPKLAmkcjnYwLhchWSVMUXvmppGQW8g= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085344eucas1p11aedea324284a7dfe911d8f1d915b5fa~qKsCOTSFk1585815858eucas1p1c; Tue, 11 Aug 2020 08:53:44 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id BC.C1.06456.89C523F5; Tue, 11 Aug 2020 09:53:44 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085344eucas1p2301dcc589febbf13d1d3d72713e55404~qKsB424c50326203262eucas1p2T; Tue, 11 Aug 2020 08:53:44 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085343eusmtrp1a61a189661de0f79e1d9f6c1a097565f~qKsB4BUq81667616676eusmtrp12; Tue, 11 Aug 2020 08:53:43 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-64-5f325c98afc7 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 2F.6D.06017.79C523F5; Tue, 11 Aug 2020 09:53:43 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085341eusmtip1bbc0ace3b9990f9c295c9a79a54f1314~qKr--k-r31664316643eusmtip17; Tue, 11 Aug 2020 08:53:41 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:41 +0300 Message-Id: <20200811085246.28735-23-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSaUxUVxiGPXdnZMx10PjFEpcx2g0X2pp8sUaK0eRGjfpDSWqwdIRbRFkm c4FWf1TKKDWAA4JREcVhkICDlVKGRQItjgvLoIRBCgQXJFaCBUEc0iqLZbiY/nvP877v+b6c HIHWZXOLhajYeNkUa4jWcxqm8u6b1tXnQz8LW+dq9sPSljyCfY8LaOw984jDtJHjFHbZg7C2 6iKLWU+SKLRkvaKwqjiVw8HeZAZfjlZR+LDOxeMFdzKPo85+Hk+15hLsn3hBY471NcHWvAoW 39ys4XB4wsag5W0HwQxHI8GG9FcMnrlRTTAlVcSRq0U8FjxcgqO9jQy6ust5vDbWRmNFyyTB 0w2lBO+lvGO/Wi69tRayUkHtACVl57fR0t3us7yU3pRHSWUvqylp+PcOTrI47ERq7kujpZJn /3K7Nfs0GyPk6KhE2bR207eag41XPjX2an4w2wrpJOIRUomPAOIX8G7oJpNKNIJOLCZwYmqE 9Ro60UPA4Q5SjdcEespq+PeN7vEeVjWKCFhvWWfrYwSSr9tmUpz4EbhO5lFeY4FYxkHVRCfl NfzEbdB8Z4TxakZcCRbP4ExBK26A5mt1RB2xFEp+rae92meal+Q+odWdlkDnZc/MpSC2CPDg 0lNWLWyBc035tKr94EWDY3ZXf3BlpzNq4WcCpyvLefWQScCcOzSbCgLH3/entSDQ4sdQWrNW xcHwrMfOeDGI86BraL4X09Myq/IcrWItnEzRqWk91De5ZzHA5LivKiXILFfU96kjUNyaxmeS pRf+H2UlxE4WyQlKTKSsBMbK369RDDFKQmzkmvC4mN/I9Fd1TTWMVpMx9wEnEQWi99UavwwM 07GGROVIjJOAQOsXaDffc32j00YYjhyVTXFhpoRoWXGSDwRGv0j7uW1gv06MNMTLh2XZKJve u5TgsziJhH49d3dGl+NQ1HpLj2eP7+O+zPG/ds4JWLGKXeYw/0HFHU8xfjiHn9jQ/qjrR+3t 9QPtlyqDL3ZmZ4QM337+0w5um32Xrvxp0NXnwb+Y7yQeZY4VKr7h3211bs85UM+EhoSY4s3L /LnBjRVb9BFt/Tf+8V9oC5j6c9K019/oLknsjw7XM8pBQ+AntEkx/AeoPevPpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSeUhTcRzA+7339vZmLh5L6bkgbRVJ0Wwz9auZHUQ++qegg/DIhr7U2mF7 m2RFeGEyrzQrOlDT7FCpvFLDo6R0ucoONEVNEUMqm9eEPGsq/ffh+/le8P1SuGSKkFLRWgOn 16rUMtKBsCy09m27GaIM2/6h2BuevstDMPitCIeB3D4S0saSMegq2Q31NXcFkNMfj0FmzjgG NY9MJIwMJBJgnajBoLfBIoTbnxOFMNE8LISM9jsIhud+4nCrYBJBe161AKZfvSBhdK6QgMyZ DgRZVWYErenjBOTW1SJIMdEw9vihEIp618HEgJkAS3elEMqmPuFQ/W4eQXbrUwTvU/4K9qxn ZwqKBWxR/Q+MvXbvE862dN8Qsulv8zC23FqLsaONHSSbWVWC2LbBNJwtHfpDHnYIkvvrdUYD 5xal4w27ZMEKUMoVviBX7vCVKzx9Qv2UXjKPAP8ITh0dy+k9Ak7Jo8z3t8YMOJxPKizG45GN MiERxdA7mO7ZHoEJOVASuhgx09YGzIQou2CYX0P4cs5qZq7TRC7nTCIm2XadXBQk7c5YUvOw ReFE95DMlysJxKJYTR9k2t6MLTFBb2IybSPCRRbTfkxbWQNa7urKlD57uTRBZI+X3ulfYgkd zST01ZHLvI75mm/DrqJVBWhFCXLijLwmUsMr5bxKwxu1kfJwnaYC2U/+vGW6qhaZrEeaEU0h maM4ZqciTCJQxfJxmmbEULjMSbzvveWkRByhirvA6XVheqOa45uRl33BbFzqHK6zP5DWEKbw UviAr8LH08fTG2RrxKn0qxAJHakycGc5LobT/6/DKJE0HrkksY2ujie260Lcz02awy/Kft+/ PPpRwrZmOY8Eth91qex61BOX36QuMjVVSN2E453lodKM4JUTrl3Hnlgp2nXqTIf38eHSoAx2 reiB0+tVNy9tmD0lDvSfP9N44JB2Y0uN7dJt9cm47+oO3/0LibHVL7vSPIyBe2dOu4hUm81z zjKCj1IptuB6XvUPy2VATAgDAAA= X-CMS-MailID: 20200811085344eucas1p2301dcc589febbf13d1d3d72713e55404 X-Msg-Generator: CA X-RootMTR: 20200811085344eucas1p2301dcc589febbf13d1d3d72713e55404 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085344eucas1p2301dcc589febbf13d1d3d72713e55404 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 22/24] examples/qos_sched: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/qos_sched/init.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 9626c15b8..99521bc4a 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -76,6 +76,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) uint16_t rx_size; uint16_t tx_size; struct rte_eth_conf local_port_conf = port_conf; + char link_status_text[ETH_LINK_MAX_STR_LEN]; /* check if port already initialized (multistream configuration) */ if (app_inited_port_mask & (1u << portid)) @@ -160,14 +161,10 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) "rte_eth_link_get: err=%d, port=%u: %s\n", ret, portid, rte_strerror(-ret)); - if (link.link_status) { - printf(" Link Up - speed %u Mbps - %s\n", - (uint32_t) link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else { - printf(" Link Down\n"); - } + rte_eth_link_to_str(link_status_text, sizeof(link_status_text), + NULL, &link); + printf("%s\n", link_status_text); + ret = rte_eth_promiscuous_enable(portid); if (ret != 0) rte_exit(EXIT_FAILURE, From patchwork Tue Aug 11 08:52:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75409 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9F06A04D9; Tue, 11 Aug 2020 10:59:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 248A31C215; Tue, 11 Aug 2020 10:53:48 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 02FB71C211 for ; Tue, 11 Aug 2020 10:53:47 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085346euoutp0201936b587dc78b7807c0c345480749bd~qKsEdV02Y0674006740euoutp02W; Tue, 11 Aug 2020 08:53:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200811085346euoutp0201936b587dc78b7807c0c345480749bd~qKsEdV02Y0674006740euoutp02W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136026; bh=hLGhAsT2cVQHkuOVemN2w0DT3uZyUZ6vteJJJYvUoWo=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=ALgJNoMGu9/KYuV2h2U3gOnOUrDkLtKtnNycHQhbBXxzS082bdcjySK9E1ukdwUv2 Xtce7RuXmTPYwH8FSicxHsBeu/eDfovy2owzgqnSB3Vp8aqYEAKRePfIXKYmiQZUHy nBcoQ+agFzuSIvfxOAA50+Keq4ovKifG+BsXNwpU= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085346eucas1p131aad1f277cb053b04881dd151bae1b7~qKsEEPjxa1188011880eucas1p1t; Tue, 11 Aug 2020 08:53:46 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id FF.C1.06456.A9C523F5; Tue, 11 Aug 2020 09:53:46 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200811085345eucas1p2c9484c5266788e3748bb86b48b4a1862~qKsDqOOFq1791917919eucas1p2a; Tue, 11 Aug 2020 08:53:45 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085345eusmtrp14d66341c5e3c2b9ea40c6a889e010a39~qKsDpYZR91667616676eusmtrp15; Tue, 11 Aug 2020 08:53:45 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-6c-5f325c9a6a21 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 32.7D.06017.99C523F5; Tue, 11 Aug 2020 09:53:45 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085343eusmtip16946246105e7b60a9f72fedfe4d58f45~qKsB1mhov1801618016eusmtip1Y; Tue, 11 Aug 2020 08:53:43 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:42 +0300 Message-Id: <20200811085246.28735-24-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHc+69vfe2WnOtZjxRB7GLEd9QlA9nanQuy3a3mMgH3+Yb1HID RKisV1RwWTpQRloGUl6MxQBKUNZuooItIgo204IVjShBHCpxJCgqr5IAwhzlsuzb///7n3Oe 5zx5eFpXwM7j402HJLPJkKBnNYz7zuj9FY49q6NWeU9osfJeMeDL52U0duY/Y9HWf5zCJ86N WOc5o0L7CwuF2fYBCj0VVhbfdqYx2DvoobDjhp9DR0sah4Pebg5/fVAE2D3eQ+Pp0iHAB8VX VTh6q5bFvvFzDGaPtQLmVDcC+rIGGMy/VgOYYRWw/7cLHJZ1BONgZyOD/vYqDn8ffkjj1XsT gLm+SsDmjI+qLxaKY6XlKrGs7jUl5p19SIt32gs5MaupmBIv99ZQYt/NVlbMrnaCePeljRZd XSNspGaXZn2MlBB/WDKv3BCtiXtq/xmSLs446rPXshbIVltBzRMhgty97WKtoOF1QgUQ5+Ny UMx7IOdbXdNmCEiJp56yAj/VMlK3VeEXgJy1tKkUMwyk7w87HZjLCqHEn1lMBYK5wmWWeMbb qEAwR9hMSno+cgHNCIvIq5a/2IDWCmtJ+p9dlHKpEOK61DA1SD3JXUUvprROCCZtJe+nhhKh kSf1J9y00vAVmXjUAIqeQ3p81ZyiFxB/XhajNPwCJNddxSnmJJD0onfTVRtJ9Zv7XGA5WlhC KmtXKngTcbaPMMrOs8iTd7MDmJ6UdvcpWsFakpmhU6r1pKGpZRoTMvFhpoJFUp5znFEe6AaQ ukIbexJCHP+fVQrghCApWU6MleRwk3QkTDYkysmm2DDjwcQrMPlZ/f/4BmtguGW/FwQe9DO1 SevCo3Qqw2E5JdELhKf1c7VfNvv36bQxhpRUyXwwypycIMlemM8z+iDtmnOv9+qEWMMh6YAk JUnm/1KKV8+zwLKBnUnLzZGf7fqwPf9745rhT1Zvehqh3qcJqZrVlbkkcmHY4m+3UMbzyz8d bd52xlGearsuxO0INreJCf0dj2I6FxX+tNfSZDyVWm/7Znb3Yyr0+Y+9x4zb5LHoN+FDFQ7H 16Epb02bC27/kB8fPbBhWV6Oy712Dx3vvRix+3Mp6O/vbHpGjjOEL6XNsuFfEXbddagDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdja1yWFa/ROyGkiSNNvUfDW1KMITBEVKRFm29KCWc7Iz I/sQ00Jl2tIlgTm8opWGZs28ZJHmtSmiYWVeEcGymLcMNdM2pW8/nue9PPC+IlKySLmJ4hK0 nCZBGS+lHSnLWsfIgbwIReTBoVpvqO4uQDAxWkrCeO4IDZmzdwn4UnEEmupMAjCO6QgwGOcI qHuip+HneCoF1vk6AobfWITwqD9VCPMtU0K415uPYGp1moS8ogUEvQW1AlhubqRhZrWEAsPK AIL75k4EHVlzFOQ21CNI0zMw+/SxEEqH3WF+vJMCy+BLITxb7COhtvsvgpyOagQ9aeuCo3vZ laIyAVva9J1gHxT3kWz74EMhm9VVQLA11nqCnXk7QLMGcwViP0xkkmzl5BJ9xvGCLEijTtJy e2LVvDZYelEOCpk8AGQK3wCZ3Mf/UqDCT+odEhTNxcfd4DTeIVdksV+NKSixyulmh7GR1iGD gx6JRJjxxUtN4XrkKJIwZQhXZY2QmzrGPyZt6GBDF7z6SU9v1iwgfHfaTNgNmvHElowCwm64 MkM0/pieQtkNF+YULpxeF9qZYjzwt/4h2s5iJhDfaZ0kNqfuxpXP321scLDplfljGyxh4nDK SAO9ye74c+EvIhs5F6EtFciVS+JVMSpeIeOVKj4pIUYWpVa9QLaTv2pfNtcjvTWsBTEiJN0q Tjwsj5QIlDf4ZFULwiJS6io+1mO5LBFHK5NvcRp1pCYpnuNbkJ8tYA7pti1KbXugBG2k3E/u DwFyfx9/n0Mg3SHOYJojJEyMUstd57hETvO/jxA5uOmQ7ubbiogwcfzMdq+rvGd28kB0eE9i tBeuDVUUGcpHPcQ7T2tem9QnJoZMqWsTqU6C9baMky7lzukN+9qby/u8Z/84M+/Lwz4aTed/ v648HlrVllu4Yp2uKlmqyUTZ5tbrZ7uCYoedx4JDdXtdz+3qvO1Ycy2vX20KG59k863FWErx sUr5flLDK/8BcjUbzwgDAAA= X-CMS-MailID: 20200811085345eucas1p2c9484c5266788e3748bb86b48b4a1862 X-Msg-Generator: CA X-RootMTR: 20200811085345eucas1p2c9484c5266788e3748bb86b48b4a1862 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085345eucas1p2c9484c5266788e3748bb86b48b4a1862 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 23/24] examples/server_nod*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/server_node_efd/server/init.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/init.c index 378a74fa5..daf4c452f 100644 --- a/examples/server_node_efd/server/init.c +++ b/examples/server_node_efd/server/init.c @@ -247,6 +247,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -266,16 +267,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - info->id[portid], - link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - info->id[portid]); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", info->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Aug 11 08:52:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 75410 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44BA7A04D9; Tue, 11 Aug 2020 10:59:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8557D1C226; Tue, 11 Aug 2020 10:53:50 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E13221C21A for ; Tue, 11 Aug 2020 10:53:48 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200811085348euoutp01af0b7caf6c21fb3841c1112cd3171cdb~qKsGQHloc0904509045euoutp01a; Tue, 11 Aug 2020 08:53:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200811085348euoutp01af0b7caf6c21fb3841c1112cd3171cdb~qKsGQHloc0904509045euoutp01a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597136028; bh=c/SsShCDywaXv7qsQyrAPBhUXLWfHhov4Jh+TlapfEU=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=fN0vOC3q2y88OC9PrheTExkfoih46H1EDvB47OseE7FaCvVM/EPLPuKeZYsU6UZxk naojnc2OcJOfuYqMDI9bXuYNXsGANLpkt0vw8X0IhzAkQBvakUlcvczd/vdFighJmI FTExpwIh4Z1+DbLiXFndK57FizcPPSs5v7KZ9x+A= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200811085348eucas1p1a693917fcc15726bb41225731a575b52~qKsF_Xacj1586915869eucas1p1Y; Tue, 11 Aug 2020 08:53:48 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 9F.FD.06318.C9C523F5; Tue, 11 Aug 2020 09:53:48 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200811085347eucas1p12d1f10a867d75cec369bdaf0949f32a0~qKsFYkWIK1975819758eucas1p1I; Tue, 11 Aug 2020 08:53:47 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811085347eusmtrp10a014862e184bfbc5caf073dc0573d0b~qKsFXrBgn1680216802eusmtrp1W; Tue, 11 Aug 2020 08:53:47 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-65-5f325c9c435d Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id B4.7D.06017.B9C523F5; Tue, 11 Aug 2020 09:53:47 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200811085345eusmtip11b68c384a66d53054dbb90e9662b55d7~qKsDmMlZi1849018490eusmtip1E; Tue, 11 Aug 2020 08:53:45 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 11 Aug 2020 11:52:43 +0300 Message-Id: <20200811085246.28735-25-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200811085246.28735-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSWUwTURSGvTPTmaFaHQvREzAgTYyocUF9OHHfopP4osb4YFCsMkFlTUfc XkRANAWxLMEADbKoQFFxAVqIGCRKxSIIxrgDrkQU2Y0iqG2nxrfzf/9/7z3n5PK0NpP15Q9E H5IM0fpIHatmqht/ts43hywOXWSK98GK5nyC7zqKaezKesNiSn8Shc8tq/G21azCjM54CtMy Bii0lhpZ/NqVwOC3QSuFr+scHOa2J3A42NDN4dnWPILdYz005hQMEWzNr1Lhz7u1LPaNFTGY NvqU4LnKBwTtqQMMZtXYCCYbBewvK+Gw+LU/DnY9YNDx4haHV0baaKxqHieYbq8g+Cj5j2pN oDhacEklFt/+TImZhW202PgimxNTm/Ip8cY3GyX23XnKimmVFiI+fJdCi+UffrBb1DvVK8Kk yAOHJcPCVXvU+xOHmrjYrIlH7xunxpN+3ki8eBCWgiWlU2Ukal4rlBKoOj3iEcMEXmbXcYoY IlCW0+10ePcRs1mv8BICV/qSiCJGCLx/2EO77mWFIHCcyadcho9wgwXr2DPKZXgLm+G9Pccd YoRZMN57ys01wjKw1aQwSlMBUH693p3xcvLyvE53rRX84dmFYUrJNPNQOxis1BugraPQw72h x17JKfUMcGSmMq4mQDhNIL36FqcIE4HEvF5PajVUfmnhXLPRwhyoqF2o4LWQ0J5IKyNPhue9 U12YdpYZ1ec9WANnkrVKWgf1Te0eDDD+a5KCRfjV0kUr+6lzrtdqUplIQO7/twoIsZDpUpwc FS7JS6KlIwtkfZQcFx2+YF9M1E3i/KqO3/YRG7kztreBCDzRTdLELg8O1ar0h+VjUQ0EeFrn o1n3yLFbqwnTHzsuGWJCDXGRktxA/HhGN12zpOjzLq0Qrj8kRUhSrGT451K8l288CVu1bdP5 7IQkv5MxTGDI4wsXDyaPt0+m7/14XBbEZAkncqXrKMR9sr/1BenU+uEJJ4/O8Av+vmxPxOUp 9dMCG2ue1G1/GTOR3TH7VUnYPEreaAtithQOXD1uga2tO5avVL16uztwbsbHkFF/87UneR/e hJp8Z/6uLRI7CqpvDllb7usYeb8+eC5tkPV/AZBjQxKmAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSeUgUcRjtNzM7O2or02r0S0hrIYuOzV0zP0stCmIgKCGC8mibdFJpD93Z FRMCs1Jbj9JMUDezTPKoNLXUskghtVaTim5dpQOxw8wjKlZrN+m/xzs+HryPIeWTlA+TqDcJ Rj2vVdDulG22e3BtWbRaE9BjXQ31veUI3tkrSRguGqQhZ/wEAa9qN0N7i1UChUPpBOQXfieg pdpCw5fhDArGJloIGLhrk0Lp0wwpTHSOSCGvvwzBiOMTCSUVkwj6y29K4FfHbRq+OS5RkP/7 OYLTzT0IunO/U1DU1oog08LCeM0VKVQO+MLEcA8FttdNUrg6/YSEm70zCAq66xH0Zf6RbFnG /a6oknCV7aMEd/biE5Lrel0s5XIflhPcjbFWgvt27znN5TfXIu7RuxySq/vwk45wj1SGGg1m k7A0wSCawhRRKlArVSGgVK8PUaoCg2M2qoMU68JD4wRtYopgXBd+QJlwfPKhNKnII/WBZUE6 GmcsiGEwux5brbwFuTFytgrhDIfvHI3x5w+ki8asF3a8sNAW5O60TCJsz3sscQk0uxLbsssJ l+DNvqXxs6xjlEvwYnfg990l/9IUuxzPfD1JuLCM3Yhb23Kouat+uK7h/j+Pm5OvKxsi50ok 4mODbfQc9sUvL0wRZ5BnBZpXi7wFs6iL14lqpcjrRLM+Xhlr0DUi5+C3un41tyLL2O5OxDJI MV+WtEmlkUv4FPGIrhNhhlR4y7b22fbLZXH8kTTBaNAYzVpB7ERBzoIFpM/CWIPzffQmjSpI FQwhquDA4MANoFgky2Y7ouVsPG8SDgtCkmD8nyMYN5901NQyVON3qDTPkznhv/VZtvqAh0OX 7xfp69ikPnhZ6Jn6uKvX7iMdmEkbXHr87Y+mfbNvspJDVrA7i+2zGdPXw/afSl6sP9cwbo9K 3ubd1+gfUZ9WHNkRdVqyd81R5Z3qUbOV3zN722Pfm4DYgo4lmeExWo02Vbe96/zLiM9eRPK1 ZgUlJvCqVaRR5P8CcRjUtgYDAAA= X-CMS-MailID: 20200811085347eucas1p12d1f10a867d75cec369bdaf0949f32a0 X-Msg-Generator: CA X-RootMTR: 20200811085347eucas1p12d1f10a867d75cec369bdaf0949f32a0 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085347eucas1p12d1f10a867d75cec369bdaf0949f32a0 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v9 24/24] examples/vm_power_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/vm_power_manager/main.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index 273bfec29..b2bd8b4cf 100644 --- a/examples/vm_power_manager/main.c +++ b/examples/vm_power_manager/main.c @@ -244,6 +244,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid, count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -267,15 +268,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint16_t)portid, - (unsigned int)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint16_t)portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */