From patchwork Sun Aug 9 13:28:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vipul Ashri X-Patchwork-Id: 75329 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F940A04C1; Mon, 10 Aug 2020 10:42:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69708288C; Mon, 10 Aug 2020 10:42:05 +0200 (CEST) Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by dpdk.org (Postfix) with ESMTP id 2CA012B87 for ; Sun, 9 Aug 2020 15:30:26 +0200 (CEST) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 079DUHKw155095 for ; Sun, 9 Aug 2020 13:30:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=NOJBsFa7MeRWOcpCrzmhrqyz38cMHAwFTYVD6Xa5oTI=; b=QOqsRkSStHAfOsIZKF2UQpufIvxgJwgKJcOBDFS0HjhSsTEELvUSqFnZqDjBIaUGNeNl jWbr2R0IzJZ0VA66tcMpKEzWg0gb/uEhNeTNV9Vx2/jUQBrP3/D7Z4mkXv5vwC6vd+OJ 1US7qM+qM7vn2ZKWMlPt8CGtRdvnROV+7xSpE7pKPQt24qgkxf0+ysvoxFUYr2lVik+M 0I+s0kxw0Nr0aihI5WueGcc3z5Nd4BzU/k3uokR5ujmrAPD8vC3RnycXXdRWS/wuTEts eWBrg2ImiepfM9XUt5vKo/1Eg7VyRHfgOt5UPOqR6Jp6AYLkTtv2VFdmGljXucBcRKQb aA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 32t2yd9dpd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sun, 09 Aug 2020 13:30:26 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 079DJLFN117250 for ; Sun, 9 Aug 2020 13:28:25 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 32t5tpk48u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 09 Aug 2020 13:28:25 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 079DSOLP001856 for ; Sun, 9 Aug 2020 13:28:24 GMT Received: from VASHRI-IN.in.oracle.com (/10.166.163.221) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 09 Aug 2020 13:28:23 +0000 From: Vipul Ashri To: dev@dpdk.org Cc: vipul.ashri@oracle.com Date: Sun, 9 Aug 2020 18:58:13 +0530 Message-Id: <20200809132813.622-1-vipul.ashri@oracle.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20200807125731.1287-1-vipul.ashri@oracle.com> References: <20200807125731.1287-1-vipul.ashri@oracle.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9707 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 phishscore=0 malwarescore=0 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=1 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008090099 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9707 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 suspectscore=1 phishscore=0 adultscore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008090100 X-Mailman-Approved-At: Mon, 10 Aug 2020 10:42:04 +0200 Subject: [dpdk-dev] [PATCH] Virtio TX: reverting a small change causing Virtio standard TX broken X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Virtio Standard TX broken : Reverting a small change added few months back which has caused breakage in Virtio Standard TX path. During basic ping Tx/Rx testing of net_virtio pmd driver using standard Tx path, We saw TX is broken since anomaly code added by below patch once submitted http://git.dpdk.org/dpdk/patch/?id=57f90f89458807bccc63425e4b72796870177977 Signed-off-by: Vipul Ashri --- drivers/net/virtio/virtqueue.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h index 105a9c00c..81118d9fb 100644 --- a/drivers/net/virtio/virtqueue.h +++ b/drivers/net/virtio/virtqueue.h @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq) /* avoid write operation when necessary, to lessen cache issues */ #define ASSIGN_UNLESS_EQUAL(var, val) do { \ - typeof(var) var_ = (var); \ - typeof(val) val_ = (val); \ - if ((var_) != (val_)) \ - (var_) = (val_); \ + if ((var) != (val)) \ + (var) = (val); \ } while (0) #define virtqueue_clear_net_hdr(hdr) do { \