From patchwork Thu Jul 23 09:57:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 74637 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7E6FA0521; Thu, 23 Jul 2020 11:58:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 505C11BE9A; Thu, 23 Jul 2020 11:58:19 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40]) by dpdk.org (Postfix) with ESMTP id A42F7199BC for ; Thu, 23 Jul 2020 11:58:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hEHZRKbYzXGNy8ANNDnOQDu+p3qk+7DohPnpb+TGHW8vfmGqxjRkRowkNRYu53HUK/4zPlGfe54ArQX/UgfQAVol+myJ84XE4cY06eT6Pcqgbc9Qj3xZPD1VFlFzFreefkJuHPw7ts1UaqacSTnI4CNVcKbzOiHG/4nftj2bgUOPfKBQHOC+ulNBnna6fwt/18lmoI5zzpY5aq7JCtqc6G3HY6SuSqEJauDgVeRNCIiGp27cSpnNCqOeVY7QeflbZ1qtR0doeVTWCTxYMvpRplQNeiOcrcMBTmo7Su/CCZM0IC1LOopqf0gu+/JLDR89dy9RSiecA8lnWs/i1TtOQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ziM2Lg4OB62YT1yL8IrzAX4mBr0ddYqm4VrOXh51fHI=; b=bNnYm3IUMk/0irY/BMVhoGPCFHpkkMmRRdkfNP8ecrjOxubsFB9HdYeTdRan5/d7oS7lhYWUvbgmH0XSx6Zqlwu28ZeYLta60fUZ8m7qlzSG6Jm+rEjsHUeR5LuR6r+pQ6xFiEN97aAJ6Ru7u+fYeLc8zmyjC2jQrcJWbQNzbV5+G0LP4qwAXFaAUpaWvebiWL8b8c9phja2ou/JmiE4ACnZWbdqevnI4WotC4HTY3G3bbdyvG5VSuT65v4astQg3p2IJzG97A2qFIJyL9hb+xUwwoY7Asl8KZy8al7dBKmE+K8Ycm+lEzQ5Jdq7zmQtYKAcm4K3hBeIrP4t1oTtbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ziM2Lg4OB62YT1yL8IrzAX4mBr0ddYqm4VrOXh51fHI=; b=QjHZo+qJycymkfe1WzikMEqGtHKS4FRDsGmHvou3xViK+ntT2auFaSEMShKTeAqEgqoy2A7jJ0ulo+ZIqomGoeJoJAkgw3Ny6yMkTA5z8eW3GbqBaNS3vi8Bxl9y+9CFTWsdANP+llAM6mCeAcOi6xM1xIb++5bByL2H+xn8GhQ= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from DB8PR05MB6761.eurprd05.prod.outlook.com (2603:10a6:10:139::21) by DB8PR05MB6762.eurprd05.prod.outlook.com (2603:10a6:10:133::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Thu, 23 Jul 2020 09:58:16 +0000 Received: from DB8PR05MB6761.eurprd05.prod.outlook.com ([fe80::5895:a00:3355:eb9f]) by DB8PR05MB6761.eurprd05.prod.outlook.com ([fe80::5895:a00:3355:eb9f%7]) with mapi id 15.20.3216.024; Thu, 23 Jul 2020 09:58:16 +0000 From: Gregory Etelson To: dev@dpdk.org Cc: getelson@mellanox.com, matan@mellanox.com, rasland@mellanox.com, Viacheslav Ovsiienko , Shahaf Shuler Date: Thu, 23 Jul 2020 12:57:54 +0300 Message-Id: <20200723095755.14561-1-getelson@mellanox.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: AM0PR03CA0075.eurprd03.prod.outlook.com (2603:10a6:208:69::16) To DB8PR05MB6761.eurprd05.prod.outlook.com (2603:10a6:10:139::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mellanox.com (176.230.224.223) by AM0PR03CA0075.eurprd03.prod.outlook.com (2603:10a6:208:69::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20 via Frontend Transport; Thu, 23 Jul 2020 09:58:15 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [176.230.224.223] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 152046b5-d9fe-4e8f-7b3b-08d82eeeeb62 X-MS-TrafficTypeDiagnostic: DB8PR05MB6762: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c16jTQqkGuE9YPKARKKGC36pLAns8uw/FmrYzh4nQ1oURCcJWn/XfgEPObPE2+j4YZcYaN5UMfXidCluBeGwBVndOrVQ8T4C9hRtOe66oA4OnwUsIGgqI+y6klRCiCDu29qHKIpTd9JER8gHXLQQc7qTGZIJEJpce1K9A9yn1VZMM0Rt1rdxz+DfMP9PvJ8rbiEh6aUH2BDv9/diAh0M+hMsKc2boBVDbnmvsE0kxxrye3lTG8emtbIfQv7lDmpwl4MyiNbXmc5oGQwBd6bCeIW8JJ6ymfnrHac0HgG5vVdUpYw9pIBx7qwvxYOG7XX6osam+4yxBwZ6Cz7aOfwCJw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB8PR05MB6761.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(396003)(346002)(366004)(39860400002)(316002)(956004)(2616005)(16526019)(186003)(8936002)(54906003)(478600001)(5660300002)(6666004)(66476007)(66946007)(66556008)(86362001)(1076003)(6916009)(8886007)(36756003)(4326008)(7696005)(26005)(55016002)(107886003)(8676002)(52116002)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 7SW9vE1r6OzDMCjdzQBHAn1ZmugIYMEbZ9XVEpXpAxvwmC24IkruJpBe9wZbnQG/1fIWzzPJslkD6XAIzZ1HYeAtyMR1sGSNSIMWitvb75YQ8gsVs5CSMcpl/9RczpKlxqubUIYXx+EGvrvuOuub9p+P+GgztCNK5Pbe+eWh1nWhbmcollyhdG7wANN0xw6TOVhEMnN7Qssmn368VgmzH+WbyoOOi1RSJ2x/DRcK//MnBToqQZSdcWhcv77FYbQwIJDrXYXGRbVP9nJ9tl1zAV+FLkpPr98imap6aRP6whYdYKHqpXrBUOKwWNk6EplPSvqKqv4QGP3FSH/TroqiycyVKgW5C7LKFLMdu2sd9hmJ6TsKWcthsroIz4P6Y+vd3gSU+ufYqNRuUmwLPaCExOTGCWIIL0BbMUEiGLlCP8kyJhqEfpvesUFaXos0d8nBrurC8a9vrO/ZHTo6rpjnCeaOYcvpgLonh/16LkEbRKGJG2BMfwu+bvw22JJVau0q X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 152046b5-d9fe-4e8f-7b3b-08d82eeeeb62 X-MS-Exchange-CrossTenant-AuthSource: DB8PR05MB6761.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2020 09:58:16.1687 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oBEibkcOjZQhmGnnwLtdiED5jesvGzJ6MZ4J8MurdXQFG+zhxLp8CTW+5GPCpXEzejfpB619NdNoUaVgKJUL+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR05MB6762 Subject: [dpdk-dev] [PATCH] net/mlx5: fix no-inline Tx flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch addresses specific configuration: PMD was explicitly configured to inline TX data info WQE with the `txq_inline_min' PMD parameter and run-time TX no-inline dynamic flag was added. TX processing was broken for packets with length less than TXQ minimal inline size. Fixes: cacb44a09962 ("net/mlx5: add no-inline Tx flag") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxtx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 3eb0243603..1b71e94221 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -4739,6 +4739,8 @@ mlx5_tx_burst_single_send(struct mlx5_txq_data *__rte_restrict txq, txq->inlen_mode) || (MLX5_TXOFF_CONFIG(MPW) && txq->inlen_mode)) { + if (inlen <= txq->inlen_send) + goto single_inline; /* * The hardware requires the * minimal inline data header. @@ -4755,6 +4757,7 @@ mlx5_tx_burst_single_send(struct mlx5_txq_data *__rte_restrict txq, } goto single_no_inline; } +single_inline: /* * Completely inlined packet data WQE: * - Control Segment, SEND opcode