From patchwork Tue Jul 21 13:36:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dybkowski, AdamX" X-Patchwork-Id: 74575 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D42C3A0526; Tue, 21 Jul 2020 15:37:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B57021BFEE; Tue, 21 Jul 2020 15:37:45 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C3F411BFEB for ; Tue, 21 Jul 2020 15:37:43 +0200 (CEST) IronPort-SDR: IWHGBa4ANS7z7mwyiySZNtRTJM+3pVyYs1wykSfVDoZNlL7yeaOan+cYSVPAJdLIlIBc7pr0r/ c36Tr+/9JRkg== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="129693855" X-IronPort-AV: E=Sophos;i="5.75,379,1589266800"; d="scan'208";a="129693855" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 06:37:42 -0700 IronPort-SDR: N1peF52djozPNy9Xoy3JUD8dXqYd2aNVZkmzyebkZgI1UOWmwfHDXmw6qNzDZn8MgsDwXQAn4t eIP7I6OIRfwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,379,1589266800"; d="scan'208";a="301615048" Received: from adamdybx-mobl.ger.corp.intel.com ([10.104.125.42]) by orsmga002.jf.intel.com with ESMTP; 21 Jul 2020 06:37:41 -0700 From: Adam Dybkowski To: dev@dpdk.org, fiona.trahe@intel.com, akhil.goyal@nxp.com Cc: Adam Dybkowski Date: Tue, 21 Jul 2020 15:36:58 +0200 Message-Id: <20200721133658.3227-1-adamx.dybkowski@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] common/qat: remove unused fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch removes unused fields from structs qat_qp and qat_qp_config, together with their initializations. Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 1 - drivers/common/qat/qat_qp.h | 8 +------- drivers/compress/qat/qat_comp_pmd.c | 1 - drivers/crypto/qat/qat_asym_pmd.c | 1 - drivers/crypto/qat/qat_sym_pmd.c | 1 - 5 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c index aacd4ab21..f7e478a4f 100644 --- a/drivers/common/qat/qat_qp.c +++ b/drivers/common/qat/qat_qp.c @@ -292,7 +292,6 @@ int qat_qp_setup(struct qat_pci_device *qat_dev, } qp->qat_dev_gen = qat_dev->qat_dev_gen; - qp->build_request = qat_qp_conf->build_request; qp->service_type = qat_qp_conf->hw->service_type; qp->qat_dev = qat_dev; diff --git a/drivers/common/qat/qat_qp.h b/drivers/common/qat/qat_qp.h index 575d69059..74f7e7dae 100644 --- a/drivers/common/qat/qat_qp.h +++ b/drivers/common/qat/qat_qp.h @@ -14,11 +14,6 @@ struct qat_pci_device; #define QAT_QP_MIN_INFL_THRESHOLD 256 -typedef int (*build_request_t)(void *op, - uint8_t *req, void *op_cookie, - enum qat_device_gen qat_dev_gen); -/**< Build a request from an op. */ - /** * Structure with data needed for creation of queue pair. */ @@ -30,6 +25,7 @@ struct qat_qp_hw_data { uint16_t tx_msg_size; uint16_t rx_msg_size; }; + /** * Structure with data needed for creation of queue pair. */ @@ -38,7 +34,6 @@ struct qat_qp_config { uint32_t nb_descriptors; uint32_t cookie_size; int socket_id; - build_request_t build_request; const char *service_str; }; @@ -73,7 +68,6 @@ struct qat_qp { void **op_cookies; uint32_t nb_descriptors; enum qat_device_gen qat_dev_gen; - build_request_t build_request; enum qat_service_type service_type; struct qat_pci_device *qat_dev; /**< qat device this qp is on */ diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c index 73e23c018..311e56168 100644 --- a/drivers/compress/qat/qat_comp_pmd.c +++ b/drivers/compress/qat/qat_comp_pmd.c @@ -124,7 +124,6 @@ qat_comp_qp_setup(struct rte_compressdev *dev, uint16_t qp_id, } qat_qp_conf.hw = qp_hw_data; - qat_qp_conf.build_request = qat_comp_build_request; qat_qp_conf.cookie_size = sizeof(struct qat_comp_op_cookie); qat_qp_conf.nb_descriptors = max_inflight_ops; qat_qp_conf.socket_id = socket_id; diff --git a/drivers/crypto/qat/qat_asym_pmd.c b/drivers/crypto/qat/qat_asym_pmd.c index 968ec54ee..ed8a2a50b 100644 --- a/drivers/crypto/qat/qat_asym_pmd.c +++ b/drivers/crypto/qat/qat_asym_pmd.c @@ -145,7 +145,6 @@ static int qat_asym_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, } qat_qp_conf.hw = qp_hw_data; - qat_qp_conf.build_request = qat_asym_build_request; qat_qp_conf.cookie_size = sizeof(struct qat_asym_op_cookie); qat_qp_conf.nb_descriptors = qp_conf->nb_descriptors; qat_qp_conf.socket_id = socket_id; diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c index c7e323cce..50626754b 100644 --- a/drivers/crypto/qat/qat_sym_pmd.c +++ b/drivers/crypto/qat/qat_sym_pmd.c @@ -181,7 +181,6 @@ static int qat_sym_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, } qat_qp_conf.hw = qp_hw_data; - qat_qp_conf.build_request = qat_sym_build_request; qat_qp_conf.cookie_size = sizeof(struct qat_sym_op_cookie); qat_qp_conf.nb_descriptors = qp_conf->nb_descriptors; qat_qp_conf.socket_id = socket_id;