From patchwork Tue Jul 21 03:05:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng, ZhihongX" X-Patchwork-Id: 74510 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06585A0526; Tue, 21 Jul 2020 05:05:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23E1B1BFD1; Tue, 21 Jul 2020 05:05:31 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id AC0781BFCD; Tue, 21 Jul 2020 05:05:29 +0200 (CEST) IronPort-SDR: z5aXbeJ/sPp4pvhBdG+j3iWq9qR1a9isjrgxhsbFtQNBMnNcj+l80swHNbnTrOyw7tpHZaB9RL i8x88YzKb+zQ== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="137541170" X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="137541170" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 20:05:28 -0700 IronPort-SDR: R0Hx0IcsQnd1vEvIZefav8owHDbSQNNOVF5dEje7cE7Igb9w1kz1nms276bOYH4uVZBDSsiFDD VgXlYsEwadFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="301469972" Received: from ubuntu.sh.intel.com ([10.240.183.163]) by orsmga002.jf.intel.com with ESMTP; 20 Jul 2020 20:05:26 -0700 From: zhihongx.peng@intel.com To: wei.zhao1@intel.com, jia.guo@intel.com Cc: dev@dpdk.org, Peng Zhihong , stable@dpdk.org Date: Mon, 20 Jul 2020 23:05:14 -0400 Message-Id: <20200721030514.18947-1-zhihongx.peng@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200720064849.14795-1-zhihongx.peng@intel.com> References: <20200720064849.14795-1-zhihongx.peng@intel.com> Subject: [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Peng Zhihong The rte_eth_dev_set_vlan_offload function will check vlan rx offload capability, the i350/i210/i211 nics have vlan extend feature but DEV_RX_OFFLOAD_VLAN_EXTEND is not set into the capability, that will cause setting fail. So need to add this capability in igb_get_rx_port_offloads_capa function. Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API") Cc: stable@dpdk.org Signed-off-by: Peng Zhihong Reviewed-by: Wei Zhao --- drivers/net/e1000/igb_rxtx.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index 5717cdb70..6411924e0 100644 --- a/drivers/net/e1000/igb_rxtx.c +++ b/drivers/net/e1000/igb_rxtx.c @@ -1637,8 +1637,10 @@ uint64_t igb_get_rx_port_offloads_capa(struct rte_eth_dev *dev) { uint64_t rx_offload_capa; + struct e1000_hw *hw; + + hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private); - RTE_SET_USED(dev); rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP | DEV_RX_OFFLOAD_VLAN_FILTER | DEV_RX_OFFLOAD_IPV4_CKSUM | @@ -1649,6 +1651,11 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev *dev) DEV_RX_OFFLOAD_SCATTER | DEV_RX_OFFLOAD_RSS_HASH; + if (hw->mac.type == e1000_i350 || + hw->mac.type == e1000_i210 || + hw->mac.type == e1000_i211) + rx_offload_capa |= DEV_RX_OFFLOAD_VLAN_EXTEND; + return rx_offload_capa; }