From patchwork Sat Jul 11 10:43:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73810 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D1AEA0528; Sat, 11 Jul 2020 12:44:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B0C321D99B; Sat, 11 Jul 2020 12:44:29 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 0D4B21D988 for ; Sat, 11 Jul 2020 12:44:28 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104427euoutp023bdef547a06723245883ec5aa09db6f2~grM2oYSMm1781617816euoutp02X; Sat, 11 Jul 2020 10:44:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104427euoutp023bdef547a06723245883ec5aa09db6f2~grM2oYSMm1781617816euoutp02X DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464267; bh=BG13JEDguLywByJwOXQTWe6Zorck+0Dg5OriYR0Hx5A=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=qmW3mdtXLMEGKX5cQXrdFk2A/rOprW64yxJIz79gs1AdBVTlX6gTJh/JVFexxQEhe 9+Q9XbzBRHfauO740ghWryDJaFk+uG10hSP1b/uyuNavG0y12VnlVubBLBX1CWBOlq IYH3AKmDRozdnK3t67Fh6WXIbvqaVcz430B0e9Cg= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104426eucas1p22dc79772974f722005779d39edc9ed3f~grM16-IIN2331023310eucas1p2C; Sat, 11 Jul 2020 10:44:26 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 23.1F.05997.A08990F5; Sat, 11 Jul 2020 11:44:26 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104426eucas1p2309f60cc71b94d6cae864d5a2a1dabb1~grM1ekQ9b2343723437eucas1p2P; Sat, 11 Jul 2020 10:44:26 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104426eusmtrp22af3b51731de05f12701dd91dbe5d602~grM1di_9q1628816288eusmtrp2N; Sat, 11 Jul 2020 10:44:26 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-2d-5f09980a1be4 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 3D.76.06017.A08990F5; Sat, 11 Jul 2020 11:44:26 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104424eusmtip1aa622d32d104a03695b946e3d1bb3e54~grMztcUgi1304313043eusmtip1f; Sat, 11 Jul 2020 10:44:24 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:48 +0300 Message-Id: <20200711104414.15422-2-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA01SbUxTZxjNe+/tvZfOmmsh4RlzLnYu2ZaJA415ZjZ1iz+u//jlEqN2VW/A CJX0il/bD4ITSZGChTgtCuVDUOpCUb4kamqdQlfLlxJEi+2IjsCmCNQMsIAtFzP/nfec8zzn OcnL09pmNoHfZzwomYyGdB2rZprvTXetVp+N0X9dENBh/f0ygkNPq2gMlgyymP/qVwof1W3C Gy3nVWgNZFNosY5T2HLJzOK/wRwGX060UOi/6eXQ1pvD4YR7mMOCrlKCw+FRGs/ZJwl2lTWp cPp2G4tj4UoGLTN9BAsbOwi2nxpnsOR6K8Fcs4CvLtdyWOVfgRPBDga9A9c4vPK6h8am+7ME T7fXE/Tlzqs2rxRn7BdVYtWNEUosruihxXsDZzjxlKeMEhtetlLi2K0+VrQ01hHxz6F8WnQ8 m2JT1NvV3+6V0vcdkkxrNv6kTvs9aOUybR8eCVh8XDapjjOTGB6EdeC/UE2ZiZrXCpcIFLp6 VVFBK4QIhEL7FWGSwFTFC+7dREVRN6sItQSczwOM8nhNYPZhJRN1scLn4M0rW9gbJzSw0BLu p6JCrLABHHfekChmhM/g7mgHHcUa4Rs42x9ilIhPwOF0LfAxEf/sWDet3LQC+stDlOJfBp5z zxb8dMR/vKmUjoaBMM/D/PFxlbJoCzjz7bSCY2G0vXGxw3KYv15OKfhn+O9qP6cM5xF4Wnli 0bQJGv/pjGA+kvAF1LetUejvYXi6YIEGYSk8erFMuWEpWJt/oxVaA3m5WsWtA5end5EGmH2z RIEiXH4eV0RW2t7rYnuvi+3/VDuh60i8lCVnpEpyslE6nCgbMuQsY2ringMZV0nkN3vn2kOt pC28200EnuiWaOwGXq9VGQ7JRzPcBHhaF6f5wefdpdXsNRw9JpkO6E1Z6ZLsJh/xjC5es7Zy ZKdWSDUclPZLUqZkeqdSfExCNrF7bvkn0zrvWOaqa65ZPlif53WMxNY5t++4MjDn+0MsDpZP N7jCHsg5WTRU8Fc6fcY/5Rvs0ae44atVYw7Xg5qTNzeu2qXvTl1tlLeMlAwnpxTzyYPf9ZWu l2cK/+52diYEDz9O+rTV/KM1mNRjyfx465MntXcD2+ITH8vhX25rdYycZkj6kjbJhrdPz+YM yQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02Se1BMcRTH/e7v7r232JlrCz8ZZDGasGypPWtIw5i5/sGM8U9iLe5Uo22b vZtRHpMiZmkpMbWyemioKFHKm0wvqykajyaRJoyY7ekReezaMfz3nXM+3+85Z+ZwWHFD5sfF xJlFU5w+Vsl4046fDZ3zvbO9dAutTgzlD+0Iul8WYujK6mTgcP9+Cp6XLIOb1bkyyHyVTIE1 c4CC6vMWBj52pdDgHKym4MUtBwu2xyksDNa+YyG95RSCd6O9GHLyhhC02KtkMHLvOgN9owU0 WL89QXC0shFBw5EBGrKu1SBIs/DQX3yOhcIX02Cwq5EGR/sVFi58eoSh6uEPBBkN5Qia037J wmcI3/KKZELhzfeUcDz/ERbq20+ywpEmOyVUOGsooe/2E0awVpYg4UH3YSyU9nxl1npHqJaY jAlm0T/aKJmXKjeoIUil1oIqaJFWpQ7WbFwcFKJcELZkmxgbs0M0LQjbrIq+2JXJxtsm73xl bWaT0VlfC/LiCL+I5B9rZSzIm1PwRYjkfrFRFsS5GoR86MEexoeMPrUwbq3ghxBJbVru1gwf QByH7JTb68t3MKTt4D7a3fDhF5PS+9+RW9P8bFLX2/gnSM5rSfazYdoTOp2UXrr7p+7l4n/0 tWLPgBjS8vwA8uhp5NmZYcrjHU+acnpo926Yn0PK7Qp3GbtiUqtO4WNovO0/yvaPsv1H5SFc gnzFBMkQZZCCVJLeICXERam2Gg2XketxrtaPVNYgi3NdLeI5pBwnz9NzOoVMv0NKNNQiwmGl r3x5s2OTQr5Nn5gkmow6U0KsKNWiENeZGdhvwlaj6w3jzDp1iFoDWrUmWBMcCspJ8kP8vUgF H6U3i9tFMV40/fVRnJdfMor80Lgireb26bJd2uw1rzNo1mG1TlGsDv8sC/m1vs05MYK/oyXh /m11w1NvZOz2X9cflp//Ulg5t7OzI6eoIieivaB7iyHg9PT4A1OSBwZu1ZfpwD+mOF3ul168 J1HzdpUQljt30pjQE4G4f2ySUDqvI7EgaWZd1t7eN6Gtsz6+ZpW0FK1XB2KTpP8NIQkKZU4D AAA= X-CMS-MailID: 20200711104426eucas1p2309f60cc71b94d6cae864d5a2a1dabb1 X-Msg-Generator: CA X-RootMTR: 20200711104426eucas1p2309f60cc71b94d6cae864d5a2a1dabb1 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104426eucas1p2309f60cc71b94d6cae864d5a2a1dabb1 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 01/24] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is optional. The value ETH_SPEED_NUM_NONE (0) was already part of the API. The value ETH_SPEED_NUM_UNKNOWN (infinite) is added to cover two different cases: - speed is not known by the driver - device is virtual Suggested-by: Morten Brørup Suggested-by: Benoit Ganne Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index a49242bcd..2090af501 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -303,6 +303,7 @@ struct rte_eth_stats { #define ETH_SPEED_NUM_56G 56000 /**< 56 Gbps */ #define ETH_SPEED_NUM_100G 100000 /**< 100 Gbps */ #define ETH_SPEED_NUM_200G 200000 /**< 200 Gbps */ +#define ETH_SPEED_NUM_UNKNOWN UINT32_MAX /**< Unknown */ /** * A structure used to retrieve link-level information of an Ethernet port. @@ -2262,15 +2263,16 @@ int rte_eth_allmulticast_disable(uint16_t port_id); int rte_eth_allmulticast_get(uint16_t port_id); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It might need - * to wait up to 9 seconds in it. + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). + * + * It might need to wait up to 9 seconds. + * @see rte_eth_link_get_nowait. * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. @@ -2279,15 +2281,13 @@ int rte_eth_allmulticast_get(uint16_t port_id); int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It is a no-wait - * version of rte_eth_link_get(). + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. From patchwork Sat Jul 11 10:43:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73811 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DEFBA0528; Sat, 11 Jul 2020 12:44:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E85431D9A5; Sat, 11 Jul 2020 12:44:33 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 7494F1D9A4 for ; Sat, 11 Jul 2020 12:44:32 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104431euoutp01c78639d696c6cd2658f7a0e16e47b9a4~grM64uewo0814408144euoutp01b; Sat, 11 Jul 2020 10:44:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200711104431euoutp01c78639d696c6cd2658f7a0e16e47b9a4~grM64uewo0814408144euoutp01b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464271; bh=IaBbS8jYu3jf7vBVTgc6LzlYJDJhZg404Kl8o0dQZ9M=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=KCye8FkCUanZN+Ijft7189kt8jqC1pVuoZ6PyAWvn9+2PXDnNlVHb7Ur60P9FI+7s W5WHqTJyxzEVxg4UxWd2ch4imYEVr8UzIGJxtt09ZBJB4uNdNueB+HdCFlyDDs6PdZ ActkghLsFjnzn3aMThh93VrApcS81FOKZJgHFrr4= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200711104430eucas1p1d6bcb6318fa4d3f81f465024af2ad95f~grM56TiA81561415614eucas1p1r; Sat, 11 Jul 2020 10:44:30 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 45.1F.05997.E08990F5; Sat, 11 Jul 2020 11:44:30 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200711104429eucas1p167ce2c188865529b784a9c4e53fad2f6~grM4yFCtI1619116191eucas1p1o; Sat, 11 Jul 2020 10:44:29 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104429eusmtrp1b6dbc65a87ec6744b665108584138c9d~grM4xOTsa2954729547eusmtrp11; Sat, 11 Jul 2020 10:44:29 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-32-5f09980eb1a6 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id EB.07.06314.D08990F5; Sat, 11 Jul 2020 11:44:29 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104427eusmtip1facab9a916db3e94365711109ace1928~grM29Y8RU0882108821eusmtip1j; Sat, 11 Jul 2020 10:44:27 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:49 +0300 Message-Id: <20200711104414.15422-3-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSe0xTdxTOuff23ku1eFdJPFEHWRMTdVr3cMlRN3Fmye5fZokmJmQOO7kD HA/Tis5HFMloSGXQAaubUx5lizzMCgiWEVTsiOjK02iKoSoiSUcFQR5xYJmjvSz77zvf43y/ nPxEVl/CrxRTMw4r5gxTmoHXcldvzXZvjP4xKvGd6uBmcnWWAg09qmRpsOQhT2cnvmWovyae Wt0XNFT0OJuhgqIXDLmrbDyNDuZw9HzSzZD/mleg83dzBJr0BAT6rudnoEAoyNJP5VNAPaVN Gpq92cLTeMjJUcHcfaDCxttAHfkvOCr5vRnIapNoovqSQJX+WJocvM2R98EVgS7P9LHU1DkP 9H2HC6jL+lqz4y15rvxXjVzZOsLIxRV9rHzrgUOQ8++UMnL982ZGHr9+n5cLGmtA/nPoLCvX Dv/Nf6ZN0H6YpKSlHlHMm7bv16ZU9Qe4Qz1O+OaJc0c22HPABqKI0mb0PkuwgVbUS1WAwYF2 UIdpwO65l4w6TAEWFjsWlKhIomwopFGFS4ADU77FYQbwYdDBhV28tBa9eaWReIxUz6M75GPC hculT9E/sD/s4aQ16PqlPbJVJ23B10UuRm2Iw9q6NjaMo6StOD/eG8F6KRZ9ZdORnSh1ivjU buXVwCd45ocKTsXLMdjRKKh4NXqL8xf5E/iywSeo4TzAR87cRVM8Nj7rFsKPY6V16GrZpNIf Y6fdw6hHisb+sTfCNLsAi66eY1Vah3lWveo2YNudu4s04vyrpSoto/tGgaCe5xrg3NhFsEPc +f+7ygFqYIWSZUlPVizvZShHjRZTuiUrI9l4IDO9ARb+qvefjulmaAl96QFJBMNSXblJTNRr TEcsx9I9gCJriNHt7PJ+odclmY4dV8yZieasNMXigVUiZ1ihe985sk8vJZsOK18ryiHF/J/K iFErs2FDX8XRwJvGwoakuIMfrIKtb9vG5nd97jgZ91Gv/NVOjbGsrZ5d8sdewMzkU12zDvv1 x7aU9qerE3L9ufsMNdF+25NtsUZ2d9VvqX+dTh2sHZ641yae0gadgcKDB4bvLYvvPRGzZMtQ 66hv47kZK3O8ztbexMXr141kZ+3Zu8tVF2PgLCmmd9ezZovpXztOPQOnAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdnYmTQ5L6Y+B1SgKq9mcutcwtSI6fQm7ENFtLj2o5Fzu TMuCMCkdU6dZdGctTSotvKYrTcoirU2WRjbxLpVl5VIrSizzQt8e+D3P+7zwvgwp+0n5MYnJ Rt6QrE2S016U429zzxrpJYlmbb5nGZQ7rQgGe4tJ6D/fQ0POt9MEuEsjoaHumggK+zIIsBSO ElB320zDl/5MCkbG6gjofuQQw5X2TDGMNQ2JIc91FcHQ5DAJl23jCFzW+yL4/eQhDZ7JIgos E28Q5Ne0IGjOHaXg/AM7giwzC9/u3BJDcbc/jPW3UODorBbD3R9tJNx3/kFwtrkcQWvWlChq KTdhKxFxxQ2fCO7cjTaSe955QczlvrASXOWIneA8jW9ozlJTiriXgzkkV/buFx3ttVcRbtCn GvklCXrBuF6+TwlBCmUYKIKCwxRKlfrAuqAQeWBEeByflJjGGwIjYhQJt91D1BFXETo2UBSV gQoykRlJGMwG4+uDkyIz8mJkbAnCL/vyKDNipgHGn9+Rc54FeLLDTM95xhG+V+umZwDNrsQO k5WYAT5sF41fZ5+aDS9gt+DurpgZD8Uux+U3n82WSdkwPFVYTswNXYzLKh7PFkjYdfiP59Ws lrGJ2OU+g+a0P357/TtRgLxtaF4p8uFTBV28TlAqBK1OSE2OV8TqdVVo+ua1z39X21F75c4m xDJIPl9q0zIamUibJqTrmhBmSLmPdGOr46BMGqdNP84b9BpDahIvNKGQ6QXPkn6+sfrpD0o2 apQhSjWEKdUqtSoU5AulJvbJfhkbrzXyh3n+CG/4nyMYiV8Got93HEWVofaL0c80ppOmE9uj ErYtU1tumtK+mlqzjfWFG6boo6beFvJCtOzXeFyE3jTcUCUf2bQ7futEUMXmGLB/2pN3MqfR 1+zr/KIqIlFkvf/qD1mvt3p7AtY+2pZiq7WXAbbscDtaV2WlOVOing4s2q3Y9fAqt8La/PGQ Tk4JCVplAGkQtP8Amvz+pgkDAAA= X-CMS-MailID: 20200711104429eucas1p167ce2c188865529b784a9c4e53fad2f6 X-Msg-Generator: CA X-RootMTR: 20200711104429eucas1p167ce2c188865529b784a9c4e53fad2f6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104429eucas1p167ce2c188865529b784a9c4e53fad2f6 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 02/24] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" link status structure keeps complicated values which are hard to represent to end user. e.g. link_speed has INT_MAX value which means that speed is unknown. To simplify processing of the values in application, new dpdk function is introduced. This commit adds function which treat link status structure and format it to text representation. Signed-off-by: Ivan Dyukov --- MAINTAINERS | 1 + app/test/Makefile | 3 + app/test/meson.build | 2 + app/test/test_ethdev_link.c | 306 +++++++++++++++++++++++ lib/librte_ethdev/rte_ethdev.c | 174 +++++++++++++ lib/librte_ethdev/rte_ethdev.h | 56 +++++ lib/librte_ethdev/rte_ethdev_version.map | 4 + 7 files changed, 546 insertions(+) create mode 100644 app/test/test_ethdev_link.c diff --git a/MAINTAINERS b/MAINTAINERS index 5e706cd7e..f4fb31ea2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -393,6 +393,7 @@ T: git://dpdk.org/next/dpdk-next-net F: lib/librte_ethdev/ F: devtools/test-null.sh F: doc/guides/prog_guide/switch_representation.rst +F: app/test/test_ethdev* Flow API M: Ori Kam diff --git a/app/test/Makefile b/app/test/Makefile index e5440774b..9f43b8c3c 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -251,6 +251,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_SECURITY) += test_security.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c test_ipsec_perf.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec_sad.c + +SRCS-$(CONFIG_RTE_LIBRTE_ETHER) += test_ethdev_link.c + ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y) LDLIBS += -lrte_ipsec endif diff --git a/app/test/meson.build b/app/test/meson.build index 56591db4e..1e6acf701 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -39,6 +39,7 @@ test_sources = files('commands.c', 'test_efd.c', 'test_efd_perf.c', 'test_errno.c', + 'test_ethdev_link.c', 'test_event_crypto_adapter.c', 'test_event_eth_rx_adapter.c', 'test_event_ring.c', @@ -199,6 +200,7 @@ fast_tests = [ ['eal_flags_misc_autotest', false], ['eal_fs_autotest', true], ['errno_autotest', true], + ['ethdev_link_status', true], ['event_ring_autotest', true], ['fib_autotest', true], ['fib6_autotest', true], diff --git a/app/test/test_ethdev_link.c b/app/test/test_ethdev_link.c new file mode 100644 index 000000000..01e57a0f3 --- /dev/null +++ b/app/test/test_ethdev_link.c @@ -0,0 +1,306 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2020 Samsung Electronics Co., Ltd All Rights Reserved + */ + +#include +#include + +#include +#include "test.h" + + +static int32_t +test_link_status_up_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + + ret = rte_eth_link_to_str(text, 128, NULL, &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + printf("Default link up #1: %s\n", text); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 2.5 Gbit/s FDX Autoneg\n", + text, strlen(text), "Invalid default link status string"); + + link_status.link_duplex = ETH_LINK_HALF_DUPLEX; + link_status.link_autoneg = ETH_LINK_FIXED; + link_status.link_speed = ETH_SPEED_NUM_10M, + ret = rte_eth_link_to_str(text, 128, NULL, &link_status); + printf("Default link up #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 10 Mbit/s HDX Fixed\n", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + link_status.link_speed = ETH_SPEED_NUM_UNKNOWN, + ret = rte_eth_link_to_str(text, 128, NULL, &link_status); + printf("Default link up #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at Unknown speed HDX Fixed\n", + text, strlen(text), "Invalid default link status " + "string with HDX"); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_down_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + + ret = rte_eth_link_to_str(text, 128, NULL, &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link down\n", + text, strlen(text), "Invalid default link status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_string_overflow(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + + ret = rte_eth_link_to_str(NULL, 2, "status %S, %G Gbits/s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Format string should fail, but it's ok\n"); + + ret = rte_eth_link_to_str(text, 2, "status %S, %G Gbits/s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Format string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[2] == 'Y', "String1 overflow\n"); + + ret = rte_eth_link_to_str(text, 8, NULL, + &link_status); + RTE_TEST_ASSERT(ret < 0, "Default format string should fail," + " but it's ok\n"); + RTE_TEST_ASSERT(text[8] == 'Y', "String1 overflow\n"); + + ret = rte_eth_link_to_str(text, 10, NULL, + &link_status); + RTE_TEST_ASSERT(ret < 0, "Default format string should fail," + " but it's ok\n"); + RTE_TEST_ASSERT(text[10] == 'Y', "String1 overflow\n"); + + text[1] = 'Y'; + ret = rte_eth_link_to_str(text, 1, "%S", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[1] == 'Y', "String1 overflow\n"); + + text[1] = 'Y'; + ret = rte_eth_link_to_str(text, 1, "%s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[1] == 'Y', "String1 overflow\n"); + + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_format(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + printf("status format #1: %s\n", text); + ret = rte_eth_link_to_str(text, 128, "status = %S, duplex = %D\n", + &link_status); + printf("status format #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = Up, duplex = FDX\n", + text, strlen(text), "Invalid status string1."); + + ret = rte_eth_link_to_str(text, 128, "%A", &link_status); + printf("status format #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Autoneg", + text, strlen(text), "Invalid status string2."); + + ret = rte_eth_link_to_str(text, 128, + "%G", + &link_status); + printf("status format #4: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("40.0", + text, strlen(text), "Invalid status string3."); + + ret = rte_eth_link_to_str(text, 128, + "%d %M %", + &link_status); + printf("status format #5: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("%d 40000 %", + text, strlen(text), "Invalid status string4."); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_return_value(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + ret = rte_eth_link_to_str(text, 128, "status = %S, ", + &link_status); + printf("return value #1:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_to_str(text + ret, 128 - ret, + "%A", + &link_status); + printf("return value #2:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_to_str(text + ret, 128 - ret, + ", duplex = %D\n", + &link_status); + printf("return value #3:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_to_str(text + ret, 128 - ret, + "%M Mbits/s\n", + &link_status); + printf("return value #4:ret=%u, text=%s\n", ret, text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = Up, Autoneg, duplex = FDX\n" + "40000 Mbits/s\n", + text, strlen(text), "Invalid status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_unknown_specifier(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + + ret = rte_eth_link_to_str(text, 128, "status = %", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string1 is failed\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = %", + text, strlen(text), "Invalid status string1"); + + ret = rte_eth_link_to_str(text, 128, + ", duplex = %d\n", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string2 is failed\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL(", duplex = %d\n", + text, strlen(text), "Invalid status string2"); + + ret = rte_eth_link_to_str(text, 128, + "% Mbits/s\n", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string3 is failed\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("% Mbits/s\n", + text, strlen(text), "Invalid status string3"); + + ret = rte_eth_link_to_str(text, 128, + "%w Mbits/s\n", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string4 should be ok, but it's fail\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("%w Mbits/s\n", + text, strlen(text), "Invalid status string4"); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_format_edges(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_UNKNOWN, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_HALF_DUPLEX + }; + char text[128]; + + ret = rte_eth_link_to_str(text, 4, "%S", &link_status); + printf("format edges #1: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_to_str(text, 6, "123%D", &link_status); + printf("format edges #2: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_to_str(text, 7, "%A", &link_status); + printf("format edges #3: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_to_str(text, 8, "%A", &link_status); + printf("format edges #4: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "It should ok, but it fails\n"); + return TEST_SUCCESS; +} +static struct unit_test_suite link_status_testsuite = { + .suite_name = "link status formatting", + .setup = NULL, + .teardown = NULL, + .unit_test_cases = { + TEST_CASE(test_link_status_up_default), + TEST_CASE(test_link_status_down_default), + TEST_CASE(test_link_status_string_overflow), + TEST_CASE(test_link_status_format), + TEST_CASE(test_link_status_format_edges), + TEST_CASE(test_link_status_unknown_specifier), + TEST_CASE(test_link_status_return_value), + TEST_CASES_END() /**< NULL terminate unit test array */ + } +}; + +static int +test_link_status(void) +{ + rte_log_set_global_level(RTE_LOG_DEBUG); + rte_log_set_level(RTE_LOGTYPE_EAL, RTE_LOG_DEBUG); + + return unit_test_suite_runner(&link_status_testsuite); +} + +REGISTER_TEST_COMMAND(ethdev_link_status, test_link_status); diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index d06b7f9b1..d844a5b7b 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -2383,6 +2383,180 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) return 0; } +static int +rte_eth_link_to_str_parser(char *str, size_t len, const char *const fmt, + const struct rte_eth_link *eth_link) +{ + size_t offset = 0; + const char *fmt_cur = fmt; + double gbits = (double)eth_link->link_speed / 1000.; + static const char autoneg_str[] = "Autoneg"; + static const char fixed_str[] = "Fixed"; + static const char fdx_str[] = "FDX"; + static const char hdx_str[] = "HDX"; + static const char unknown_str[] = "Unknown"; + static const char up_str[] = "Up"; + static const char down_str[] = "Down"; + char gbits_str[20]; + char mbits_str[20]; + + /* preformat complex formatting to easily concatinate it further */ + snprintf(mbits_str, sizeof(mbits_str), "%u", eth_link->link_speed); + snprintf(gbits_str, sizeof(gbits_str), "%.1f", gbits); + /* init str before formatting */ + str[0] = 0; + while (*fmt_cur) { + /* check str bounds */ + if (offset >= len) { + str[len - 1] = '\0'; + return -EINVAL; + } + if (*fmt_cur == '%') { + /* set null terminator to current position, + * it's required for strlcat + */ + str[offset] = '\0'; + switch (*++fmt_cur) { + /* Speed in Mbits/s */ + case 'M': + if (eth_link->link_speed == + ETH_SPEED_NUM_UNKNOWN) + offset = strlcat(str, unknown_str, + len); + else + offset = strlcat(str, mbits_str, len); + break; + /* Speed in Gbits/s */ + case 'G': + if (eth_link->link_speed == + ETH_SPEED_NUM_UNKNOWN) + offset = strlcat(str, unknown_str, + len); + else + offset = strlcat(str, gbits_str, len); + break; + /* Link status */ + case 'S': + offset = strlcat(str, eth_link->link_status ? + up_str : down_str, len); + break; + /* Link autoneg */ + case 'A': + offset = strlcat(str, eth_link->link_autoneg ? + autoneg_str : fixed_str, len); + break; + /* Link duplex */ + case 'D': + offset = strlcat(str, eth_link->link_duplex ? + fdx_str : hdx_str, len); + break; + /* ignore unknown specifier + * just copy it to target str + */ + default: + str[offset++] = '%'; + fmt_cur--; + break; + + } + if (offset >= len) + return -EINVAL; + + } else { + str[offset++] = *fmt_cur; + } + fmt_cur++; + } + str[offset] = '\0'; + return offset; +} + +int +rte_eth_link_printf(const char *const fmt, + const struct rte_eth_link *eth_link) +{ + char text[200]; + int ret; + + ret = rte_eth_link_to_str(text, 200, fmt, eth_link); + if (ret > 0) + printf("%s", text); + return ret; +} + +int +rte_eth_link_to_str(char *str, size_t len, const char *const fmt, + const struct rte_eth_link *eth_link) +{ + size_t offset = 0; + double gbits = (double)eth_link->link_speed / 1000.; + char speed_gbits_str[20]; + char speed_mbits_str[20]; + /* TBD: make it international? */ + static const char link_down_str[] = "Link down\n"; + static const char link_up_str[] = "Link up at "; + static const char unknown_speed_str[] = "Unknown speed "; + static const char mbits_str[] = "Mbit/s"; + static const char gbits_str[] = "Gbit/s"; + static const char fdx_str[] = "FDX "; + static const char hdx_str[] = "HDX "; + /* autoneg is latest param in default string, so add '\n' */ + static const char autoneg_str[] = "Autoneg\n"; + static const char fixed_str[] = "Fixed\n"; + + if (str == NULL || len == 0) + return -EINVAL; + /* default format string, if no fmt is specified */ + if (fmt == NULL) { + if (eth_link->link_status == ETH_LINK_DOWN) { + if (sizeof(link_down_str) > len) + return -EINVAL; + return strlcpy(str, link_down_str, len); + } + + /* preformat complex strings to easily concatinate it further */ + snprintf(speed_mbits_str, sizeof(speed_mbits_str), "%u %s ", + eth_link->link_speed, mbits_str); + snprintf(speed_gbits_str, sizeof(speed_gbits_str), "%.1f %s ", + gbits, gbits_str); + + offset = strlcpy(str, link_up_str, len); + /* reserve one byte to null terminator */ + if (offset >= len) + return -EINVAL; + /* link speed */ + if (eth_link->link_speed == ETH_SPEED_NUM_UNKNOWN) { + offset = strlcat(str, unknown_speed_str, len); + if (offset >= len) + return -EINVAL; + } else { + if (eth_link->link_speed < ETH_SPEED_NUM_1G) { + offset = strlcat(str, speed_mbits_str, len); + if (offset >= len) + return -EINVAL; + } else { + offset = strlcat(str, speed_gbits_str, len); + if (offset >= len) + return -EINVAL; + } + } + /* link duplex */ + offset = strlcat(str, eth_link->link_duplex ? + fdx_str : hdx_str, len); + if (offset >= len) + return -EINVAL; + /* link autonegotiation */ + offset = strlcat(str, eth_link->link_autoneg ? + autoneg_str : fixed_str, len); + if (offset >= len) + return -EINVAL; + /* Formatted status */ + } else + offset = rte_eth_link_to_str_parser(str, len, fmt, eth_link); + + return offset; +} + int rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats) { diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 2090af501..eeb6ac50c 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -2295,6 +2295,62 @@ int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); */ int rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *link); + +/** + * print formatted link status to stdout. This function treats all + * special values like ETH_SPEED_NUM_UNKNOWN, ETH_LINK_DOWN etc. and convert + * them to textual representation. + * + * @param fmt + * Format string which allows to format link status. + * If NULL is provided, default formatting will be applied. + * Following specifiers are available: + * - '%M' link speed in Mbits/s + * - '%G' link speed in Gbits/s + * - '%S' link status. e.g. Up or Down + * - '%A' link autonegotiation state + * - '%D' link duplex state + * @param eth_link + * Link status provided by rte_eth_link_get function + * @return + * - Number of bytes written to stdout. + * - (-EINVAL) if fmt is too long + * + */ +__rte_experimental +int rte_eth_link_printf(const char *const fmt, + const struct rte_eth_link *eth_link); + +/** + * Format link status to textual representation. This function treats all + * special values like ETH_SPEED_NUM_UNKNOWN, ETH_LINK_DOWN etc. and convert + * them to textual representation. + * + * @param str + * A pointer to a string to be filled with textual representation of + * device status. + * @param len + * Length of available memory at 'str' string. + * @param fmt + * Format string which allows to format link status. + * If NULL is provided, default formatting will be applied. + * Following specifiers are available: + * - '%M' link speed in Mbits/s + * - '%G' link speed in Gbits/s + * - '%S' link status. e.g. Up or Down + * - '%A' link autonegotiation state + * - '%D' link duplex state + * @param eth_link + * Link status provided by rte_eth_link_get function + * @return + * - Number of bytes written to str array. + * - (-EINVAL) if size of target buffer is too small for the string + * + */ +__rte_experimental +int rte_eth_link_to_str(char *str, size_t len, const char *const fmt, + const struct rte_eth_link *eth_link); + /** * Retrieve the general I/O statistics of an Ethernet device. * diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map index 715505604..79eb99ccd 100644 --- a/lib/librte_ethdev/rte_ethdev_version.map +++ b/lib/librte_ethdev/rte_ethdev_version.map @@ -241,4 +241,8 @@ EXPERIMENTAL { __rte_ethdev_trace_rx_burst; __rte_ethdev_trace_tx_burst; rte_flow_get_aged_flows; + + # added in 20.08 + rte_eth_link_to_str; + rte_eth_link_printf; }; From patchwork Sat Jul 11 10:43:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73812 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C76AA0528; Sat, 11 Jul 2020 12:44:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB9D81D9B7; Sat, 11 Jul 2020 12:44:36 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1B02B1D9AC for ; Sat, 11 Jul 2020 12:44:35 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104434euoutp02afe1f7e92785cdf0af1d187675ea0ab5~grM9mb8_K2273222732euoutp02q; Sat, 11 Jul 2020 10:44:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104434euoutp02afe1f7e92785cdf0af1d187675ea0ab5~grM9mb8_K2273222732euoutp02q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464274; bh=RFy0yPNPCG/l5HzYILZl0igxrZPOmUjRrnAYrQUbFJM=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Ih9q8fZKLqREkD1VvfKoq8sXLHJFumQmnvViMEtHEwCND7Nr5hKTRANogouGMXqgV 0Xr7GpYqi+MxjlE8+QarCsXFzcsxmAgZT+kUh+7f2q2QaWVT/r+asyErhPvQh5Mret iz3hcTTFNV3+bviCe795Ib2lJ4zUPPv1VsCdcDJM= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104433eucas1p256e48d9023764f9eb1c0a6b31fa54c1e~grM8tAVoR2332923329eucas1p2S; Sat, 11 Jul 2020 10:44:33 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id DD.77.06318.118990F5; Sat, 11 Jul 2020 11:44:33 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200711104433eucas1p1dab66feada324094b4e223d57e66594f~grM755Uum1558215582eucas1p1f; Sat, 11 Jul 2020 10:44:33 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104433eusmtrp13a5c6c5dec6802abf91539f793d75deb~grM748mjD2954729547eusmtrp12; Sat, 11 Jul 2020 10:44:33 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-3d-5f0998119466 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 7F.76.06017.018990F5; Sat, 11 Jul 2020 11:44:32 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104431eusmtip1f05ba0e4e7ef9065ad5c6cff90a99ee5~grM6JFali1304313043eusmtip1g; Sat, 11 Jul 2020 10:44:31 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:50 +0300 Message-Id: <20200711104414.15422-4-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxTGc+5XL9WSSzHxxBmIzbYwo7DNZR4XM9xYlhuXRf42Kla9ASOt plf83DIUQVZYHYVg1a0ghKBghjCkyIAxzFqwfEnCgKlIDLPRjQ8pOFGQUS5m/z3v73nO+5y8 eUXWWCCsEvdbDys2qznVJOi5Ou9M1/oIV1jSu6N336eqDjfQw6FSloYL7guUM3GGoYGKeGr0 /MCT80E6Qw7nU4Y8V+wC/TN8mqOxSQ9D95r8OrrYe1pHk60BHX3XfQkoMPuEpQvFQaBu9w2e Zn5rEGh8toQjx4s+oHO1bUC+3KccFdysB8qySzRxtVxHpfeiaHK4jSP/4M86ujZ9h6UbHXNA eb4qoM6seX7LGvlFcRkvlzY+ZuT8y3dY2TtYqJNz292MXD1Wz8jjzX2C7KitAPn2wxxWrhx5 LiTqt+s371NS9x9RbHEf79anODqCcKh707HLjQNMOgTW2SFMROkDPOXM4e2gF43SFcDBjiYu ZBilKcCiX77UjCDgSLqXfz3xKFAmaEY54OitXE47TAPam89BKCVIMejPdjMhY4VULaBntp8J GZHSRpy+2bioOektfDbVtdhnkDah98KPoFVEY+X1Fjakw6SPcG68h9V2isL+oqnFS1HqETHP e2pp4DO8VVjOaToSn/hqdZpejf783CV+Ev+t6ddpw9mAQyWZS6F4rP27a0GLIiu9g1UNcRr+ BM+PFEAIoxSOA6MRIcwuSGfdeVbDBszOMmppE7a09y5hxLmXyzUsY1l7Hmjv0wTY+8e33PcQ ffH/rmKAClippKmWZEXdYFWOxqpmi5pmTY7de9BSAwt/1f/KN10PzbN7WkESwbTcUGwWk4y8 +Yh63NIKKLKmFYZPO/27jIZ95uMnFNvBJFtaqqK2whsiZ1pp2FDyeKdRSjYfVg4oyiHF9tpl xLBV6bB3iGvbuK2o5uSOZbvedjtdzoyUzxP+fPbTN7E2PqrB89X4QN/Xrl9jMpp/T6rcllmT mRgZVxdujZ/4i3/0smfmrM+1u3CZ61q+4vCvrr7bmXFp/oA4F8mvu73lQV1EeEuCZWvimq7q wPo3y7ZvFb9Qx+a7j0anYILS9Or+h2tjgzFBE6emmN9by9pU838067n1pwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTcRDG/e9utwuxuhaUv8QDakzU4GK5OjV4xAey8qAYHkyQww1sgEgp 6RYiPoFBIJVLNEZAKoqIovEsUhSNYCxq0SpSgQhKCJF4pOUQAwRBDn37Mr9vZr5khiGVvylf JjXdKBrShTQV7UnZZ9v7t7MXPBJ2OM3hcKfDjGDwcy0JA+f6aTg9kkdAT8MeaGm6KIPyLzkE lJSPEtB03UTDz4GTFLjGmgjoe2KXQ2XnSTmMtQ3LodhRhWB45jsJFTXjCBzmRhlMtT6iwT1z hYKSaSeCUstLBO1FoxSca7YiyDexMHKjXg61fRtgbOAlBfbeB3K4NfGehMaOPwjOtN9B8CZ/ TrbXn5+uqZPxtS3fCP7s5fckb+s9L+eLXpkJ/p7LSvDup06aL7E0IP714GmSvzk0SUd5xnDh Bn2mUfRL0UvGXaojagji1FrggkK0nDpYE7czKFQVuDs8SUxLzRINgbuPciklHeMow6E9frml h8hBwwEm5MFgNgR/Ha6jTciTUbJ1CI8V1BMmxMwDjH8MkUseLzzz0fTPM45wxY08agHQ7BZs LzQTC8Cb/UTjDwW5i8CL1eCJ5hZiQVPsZvz719vFuoLVYltFNVqauhHfvPtscYMHuxP/cb9b 1Eo2FTt6TqElvQF3X/pFlKEVNWhZA/IWMyVdsk4K4iRBJ2WmJ3OJet19NH/zh7YpixWZXNFt iGWQarmiRmASlDIhS8rWtSHMkCpvxb439nilIknIPiEa9AmGzDRRakOh8wHPkL6rE/XzH5Ru TFCHqjWgVWuCNcFhoPJRFLKtsUo2WTCKx0QxQzT87yMYD98c1FVXGrHdvTYn1RWWJaiGAqL6 Pj9/G98UdqBnNmbluk5n9ON6y0Tlar/DV/Nzx19Yy6sjp23G6o1bTf5lr8Ob8dWLNs+H8XH8 8oPckUiOKrZ1+/XeruryNlYfWvVuptC1XxMz6Q7en3GlqjtuLik7NqJ/k0+0M+/abPT6wDWh xyIrVJSUIqi3kQZJ+AuFx+gNCQMAAA== X-CMS-MailID: 20200711104433eucas1p1dab66feada324094b4e223d57e66594f X-Msg-Generator: CA X-RootMTR: 20200711104433eucas1p1dab66feada324094b4e223d57e66594f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104433eucas1p1dab66feada324094b4e223d57e66594f References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 03/24] app: UNKNOWN link speed print X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications and docs Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 9 +++------ app/test-pipeline/init.c | 11 +++++----- app/test-pmd/config.c | 20 +++++++++++-------- app/test-pmd/testpmd.c | 9 +-------- app/test/test_pmd_perf.c | 17 +++++++--------- doc/guides/sample_app_ug/link_status_intr.rst | 10 +++++----- 6 files changed, 33 insertions(+), 43 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab..4a4c572c3 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -685,12 +685,9 @@ show_port(void) printf("Link get failed (port %u): %s\n", i, rte_strerror(-ret)); } else { - printf("\t -- link speed %d duplex %d," - " auto neg %d status %d\n", - link.link_speed, - link.link_duplex, - link.link_autoneg, - link.link_status); + rte_eth_link_printf("\t -- link speed: %M, duplex: %D," + " auto neg: %A, status: %S\n", + &link); } printf("\t -- promiscuous (%d)\n", rte_eth_promiscuous_get(i)); diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c index 67d54ae05..7abc62544 100644 --- a/app/test-pipeline/init.c +++ b/app/test-pipeline/init.c @@ -155,7 +155,7 @@ static void app_ports_check_link(void) { uint32_t all_ports_up, i; - + char link_status_text[50]; all_ports_up = 1; for (i = 0; i < app.n_ports; i++) { @@ -173,12 +173,11 @@ app_ports_check_link(void) all_ports_up = 0; continue; } - - RTE_LOG(INFO, USER1, "Port %u (%u Gbps) %s\n", + rte_eth_link_to_str(link_status_text, 50, "(%G Gbps) %S", + &link); + RTE_LOG(INFO, USER1, "Port %u %s\n", port, - link.link_speed / 1000, - link.link_status ? "UP" : "DOWN"); - + link_status_text); if (link.link_status == ETH_LINK_DOWN) all_ports_up = 0; } diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index a7112c998..7ee8c4c4d 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -604,10 +604,9 @@ port_infos_display(portid_t port_id) } else printf("\nmemory allocation on the socket: %u",port->socket_id); - printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down")); - printf("Link speed: %u Mbps\n", (unsigned) link.link_speed); - printf("Link duplex: %s\n", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_printf("\nLink status: %S\n" + "Link speed: %M Mbps\n" + "Link duplex: %D\n", &link); if (!rte_eth_dev_get_mtu(port_id, &mtu)) printf("MTU: %u\n", mtu); @@ -730,6 +729,8 @@ port_summary_display(portid_t port_id) struct rte_eth_link link; struct rte_eth_dev_info dev_info; char name[RTE_ETH_NAME_MAX_LEN]; + char status_text[6]; + char speed_text[12]; int ret; if (port_id_is_invalid(port_id, ENABLED_WARN)) { @@ -750,12 +751,14 @@ port_summary_display(portid_t port_id) if (ret != 0) return; - printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\n", + rte_eth_link_to_str(status_text, 6, "%S", &link); + rte_eth_link_to_str(speed_text, 12, "%M", &link); + printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %sMbps\n", port_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], mac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name, - dev_info.driver_name, (link.link_status) ? ("up") : ("down"), - (unsigned int) link.link_speed); + dev_info.driver_name, status_text, + speed_text); } void @@ -3899,7 +3902,8 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) ret = eth_link_get_nowait_print_err(port_id, &link); if (ret < 0) return 1; - if (rate > link.link_speed) { + if (link.link_speed != ETH_SPEED_NUM_UNKNOWN && + rate > link.link_speed) { printf("Invalid rate value:%u bigger than link speed: %u\n", rate, link.link_speed); return 1; diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 4989d22ca..a1b9c1c1c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3010,14 +3010,7 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. speed %u Mbps- %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_printf(NULL, &link); continue; } /* clear all_ports_up flag if any link down */ diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index 352cd4715..892fb419d 100644 --- a/app/test/test_pmd_perf.c +++ b/app/test/test_pmd_perf.c @@ -126,6 +126,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status[50]; printf("Checking link statuses...\n"); fflush(stdout); @@ -146,16 +147,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) { - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - if (link_mbps == 0) - link_mbps = link.link_speed; - } else - printf("Port %d Link Down\n", portid); + if (link.link_status && link_mbps == 0) + link_mbps = link.link_speed; + + rte_eth_link_to_str(link_status, 50, NULL, + &link); + printf("Port %d %s\n", portid, link_status); continue; } /* clear all_ports_up flag if any link down */ diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst index 04c40f285..11733ded1 100644 --- a/doc/guides/sample_app_ug/link_status_intr.rst +++ b/doc/guides/sample_app_ug/link_status_intr.rst @@ -158,6 +158,7 @@ An example callback function that has been written as indicated below. { struct rte_eth_link link; int ret; + char link_status[200]; RTE_SET_USED(param); @@ -169,11 +170,10 @@ An example callback function that has been written as indicated below. if (ret < 0) { printf("Failed to get port %d link status: %s\n\n", port_id, rte_strerror(-ret)); - } else if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + } else { + rte_eth_link_to_str(link_status, 200, NULL, &link); + printf("Port %d %s\n\n", port_id, link_status); + } } This function is called when a link status interrupt is present for the right port. From patchwork Sat Jul 11 10:43:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73813 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DDDFA0528; Sat, 11 Jul 2020 12:45:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F245D1D9C6; Sat, 11 Jul 2020 12:44:39 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 8073C1D9C3 for ; Sat, 11 Jul 2020 12:44:38 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104438euoutp019c804494e1e7b386448720c62a3a99de~grNAyhu9F0814708147euoutp01U; Sat, 11 Jul 2020 10:44:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200711104438euoutp019c804494e1e7b386448720c62a3a99de~grNAyhu9F0814708147euoutp01U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464278; bh=1R9omrZ5fAPdKYuUkOS/6cuY8buXbZ+pEv8UB5bwG/w=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=J14y3gfANobOrvRgTEXwV53DG6u+e/DJ44woqHX2QXCQbgcMFg5HqGDpXatFsBDJa 6ZRegHXLy6RZZlPWa/m4AIwrDUCmUvm8sj2KDre12d07j8Q6qbRRJ5ylICLXrmW3JK OzlPrMFpu3l0rZ0prRbH8V5znh+9cIypsqOmK/BE= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104437eucas1p2fe63fb538a77114e04b38dec56174ec1~grM-vBYHx2330823308eucas1p2d; Sat, 11 Jul 2020 10:44:37 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 42.55.06456.418990F5; Sat, 11 Jul 2020 11:44:37 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104435eucas1p2672c6948de9e152526837ff520e37513~grM_kDgFL2340023400eucas1p2P; Sat, 11 Jul 2020 10:44:35 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104435eusmtrp1d173840b7d1767af72dcb957ee915dea~grM_jAfp42954729547eusmtrp13; Sat, 11 Jul 2020 10:44:35 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-24-5f099814e8a8 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 0E.07.06314.318990F5; Sat, 11 Jul 2020 11:44:35 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104434eusmtip1af9682c4537b6464b8e255658daeaae6~grM80IX-f0946309463eusmtip1x; Sat, 11 Jul 2020 10:44:33 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:51 +0300 Message-Id: <20200711104414.15422-5-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTdxTGc+69vfe2sXqpLJ7olNhlyWYizGwfjptRHESvX5bFJUs2s+Gd 3gEZraZXfNmyjDVIWOlQK9EpW61lG2+bCJZSFQw0atEiDjYGxpcRXWJQC1IFBwLOcrvs2/M8 55zfOfnnL7KW/fxCMd++Q3XYlQIrb+KCFye6l7/wnTHnta4Shhq6vEC3b1WxNFhxk6eyh8UM DdStodaW7w3k+auIoXLPKEMtNS6eHgw6ORqOtzB0oy0q0NFep0Dx8F2Bvr1aCXR36h5LR3yP gK56mw000XGGp5EpP0flk31A+wKdQBH3KEcVp0NAJS6JHtZWC1R1YwnFBzs5il47JdAvYz0s NXdNAx2INABdKXlmyFwqT/p+MshVrUOMfPB4DytfvHZIkN2XvIzcOBxi5JFzfbxcHqgD+fLt Mlau//sf/l3Th6ZVW9WC/J2qI2P1ZlNe54ld2y8Lu+/82MEXQZB3gVFE6Q08UFfLusAkWqQa wCaPl9HNY8D6gWZBN48AKyfGOReIsyM3G3g9rwYc7atPmjHAp20BQ4LLS69gtFRHpUqNPLZM 9TOJwnwpC/1+9yyJk17GkDM/EZullehuvi7oN6Vh/cl2NqGN0ps4PfLbrLZIS7D/2ONZJkpd Ip74ZpLXL8rG4V9lfXY+3osEkpwXMXowsSqhv8AnTf2CPlsKeMu/N9m0BgP3u4UEh5VexYYz GTpyLf4xtE6Xc3EglpJoZp9LT/Awq8dmLC2x6Awrtl/qTcaI00/n6LGM461nk2/bBvhnXwz2 Q9rR/1f5AOpggVqo2XJVbYVd3ZWuKTat0J6bvmWbrQme/9PoTCQegrHeT8IgiWCdY/YpYo7F oOzU9tjCgCJrTTW/fSX6scW8VdnzuerYluMoLFC1MCwSOesC8+v+oY8sUq6yQ/1MVberjv+q jGhcWARfZ0X4Hu+4G1NzszGWIVWmXHhvXVXaxt+div/n4LF5NZu4LzOdp7or36q9cLosS9h4 B8jQ5mlH3yr2QWZ6b3bKXltwy/nYZGhR7KVPdxcu3rQ8vP4r+7Ifzlc8sQ8Xx/w+0weHyowb tJmVxWsj78ysX329ujFovJ8XN9V0ZL5/xMppecqKZaxDU/4FxhuiI6MDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSbVBMcRTG+997995b0+baMv31Aa0xgxk3u5XOkkJf7pgx3r+gssNVqW2z d/M2g0RSEiWGYq3NayF60aKinUnL1uRlvCTRJNMUU6mYpGK3+Pab5znnOWfmHJZUDFB+bFyi UTQkahOUtAflGKtvned91j16/ulhNZQ0mBC0fywkoS2vlYZjfYcJeFcUDlWV52WQ+ymFgOzc 7wRUXs+k4VtbKgU9/ZUEfKh2MJD/MpWBflsnA8ebChB0jnSTcM48gKDJVCGDX7UPaOgdsVCQ PfwawYlyO4L6rO8U5N23IjiSyUHfjWsMFH6YBv1tdgoczWUM3PzxgoSKhlEEOfUlCBqP/JEt 8ReGzVdkQmFVFyGcuvSCFJ40n2GErKcmQrjbYyWE3prXtJBdXoSEZ+3HSKG4Y4he5bGBDzXo k43ijFi9ZFys3KgCNa/SAK8O0vCqwJDIhepgZUBY6FYxIW6naAgI28zH2m/vSnrG7P58uZZO QffoTMSymAvCrSVO9GAV3BWEm2vSyQkd468dTnR3ojceeZP5r2YA4TRrJ+MyaG42dhw1ES7D h2uh8av0g5TL8OYisMWSRbmCKG4WtqbGuWQ5p8FZFS3MROh0XHzn8fgAd24hHu19Ps4KLg43 vUtDEzwNv704SJxEXmbkVoR8xGRJF6OTVLyk1UnJiTH8Fr2uFDkPfu/JrzIrenl3rQ1xLFJ6 ys1aNloh0+6U9uhsCLOk0ke+rNERpZBv1e7ZKxr00YbkBFGyoWDnfjmk35Qteuf7JBqjVcGq ENCoQgJDAheA0ld+lKvdpOBitEYxXhSTRMP/PoJ190tBM6iZng99DYFXG6LsHTtG501eOudL dZP/+iQ8ZmmJ9Lq/5sKGbZNyXg19qR5xzOzqa+8bExaF5ZTWBfTzat/4/NWWrnX79nelH9gR niHoH9Zp0m65DZ3ZOFhARZTL9ZErOiOnrmwxO/IfPNKZMj6Hvx+0891vf6ax6YeWx//ebqv7 qaSkWK1qLmmQtH8BYjTKUAYDAAA= X-CMS-MailID: 20200711104435eucas1p2672c6948de9e152526837ff520e37513 X-Msg-Generator: CA X-RootMTR: 20200711104435eucas1p2672c6948de9e152526837ff520e37513 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104435eucas1p2672c6948de9e152526837ff520e37513 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 04/24] net/ixgbe: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov Reviewed-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 248f21d14..34a171116 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4300,11 +4300,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, switch (link_speed) { default: case IXGBE_LINK_SPEED_UNKNOWN: - if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T || - hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L) - link.link_speed = ETH_SPEED_NUM_10M; - else - link.link_speed = ETH_SPEED_NUM_100M; + link.link_speed = ETH_SPEED_NUM_UNKNOWN; break; case IXGBE_LINK_SPEED_100_FULL: From patchwork Sat Jul 11 10:43:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73814 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93BD3A0528; Sat, 11 Jul 2020 12:45:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A5BC1D9C3; Sat, 11 Jul 2020 12:44:43 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id AE1741D9C3 for ; Sat, 11 Jul 2020 12:44:41 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104441euoutp026a31ae7e1fd7b29f7122f33cd6fc37a6~grNDgK73d1781817818euoutp02a; Sat, 11 Jul 2020 10:44:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104441euoutp026a31ae7e1fd7b29f7122f33cd6fc37a6~grNDgK73d1781817818euoutp02a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464281; bh=zbg2xoSaiDgck4H57R7Z3rwqX+vJJlCAoA2nccHDMek=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=d7VViYkvOjVk8VMGj21zC3drCF3I7LPncS42/LcMecOHVLll2jZ0GKxxYJ7YS8YFo X1t2KAhhfxJGbSx8unE6wo+y5aKUecn7ZDEk/3c1q2y3rQHcz0olX0Qkrand2hBAbi PIKPyZSxccpgdR+lTkBnqLD7MWyvpmfPTU5Nil8U= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104440eucas1p27a5ab9cf38cf226797c5ed8f5cf23dd2~grNDCdINC1984019840eucas1p2x; Sat, 11 Jul 2020 10:44:40 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id FF.77.06318.818990F5; Sat, 11 Jul 2020 11:44:40 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104439eucas1p278753181e040c94f95e9b47deccccbbb~grNB3mcsX1983519835eucas1p2t; Sat, 11 Jul 2020 10:44:39 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104439eusmtrp27877abd35fb4c5febf61e84053d995be~grNB2hlBX1628816288eusmtrp2P; Sat, 11 Jul 2020 10:44:39 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-45-5f099818667d Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 91.86.06017.718990F5; Sat, 11 Jul 2020 11:44:39 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104437eusmtip1eb265644b639efa474eea8bda6dddc32~grNAD_8Nm0882108821eusmtip1k; Sat, 11 Jul 2020 10:44:37 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:52 +0300 Message-Id: <20200711104414.15422-6-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUwTaRDH8+xud7cNJWslYQJGQhONLxHP4MucEUHvNJtojDHxi6hQcQPk oJKWl/PuC0ElTcFygqKiYoWgiEZQKi0EOawXKhaFapSXQ64hGgPciaL1jYLSbs19+8385z8z z+ThaU0FG8Vn6nMlg16XpWVVTEvX594VcEaZ8kNZ5RJs7KkmODpSS6P35HMWS94cpXCgIRHb 7ecVWP5PIYWW8rcU2uvNLP7rLWLw9ZSdwuE7bg6rHhdxOOV8xeHx3nMEX/nHaTxrfUewt/q2 Aj/fbWNx0l/DoOXLU4JltvsEXaVvGTzZ6iBYbBbwzdUrHNYOL8Qp730G3YPNHF73eWi83TND 8ISrkeDD4q+KpFjxi7VOIda2j1FixSUPLXYNVnJiaXc1Jd587aDEyY6nrGixNRDxwWgJLV57 8Yndqdqj2nBQysrMlwwrN6aqMkyeIS6nL/zXljYrVUguhJkJz4OwGkauxpiJitcI9QTu2itY OXhPYLq1WSEH7wiMfKzhzEQZdBzprCSycIVA2acyWg58BFy1z4NVrLAE3KZqKiBECDdZsPv7 qYAwX9gMjZYHigAzwiKwe8pJgNXCj/Bk/AUtj4iBa02dQVYK62Fmsi/IGmEh9F98H2wKQg8P JeZTIcPP4BjzMTLPh3GXLbTrAvjaepGS+Xf4eKufk82muQfVHAsVJYJt4hEXOActLIXGtpXy ZTbBdPNyGcNh4L95gWJ6DstbTtNyWg2mYo3cQwud3Y9DaYCZ6TA5LcKzEyWhi94h4PT52T9I TNX/o6yENJBIKc+YnS4Z4/VSQZxRl23M06fHpR3KvkXmvqp71uVzkA7/AScReKINU1t1fIpG ocs3Hs52EuBpbYR680P3fo36oO7wb5LhUIohL0syOkk0z2gj1fE1Y/s0QrouV/pFknIkw3eV 4pVRhWRL0lDU37m2NiFGmaT/MN7UtNXXNGtpcHi8XRlbrzsylr2Mju7euMOndKV6BetE5mBR wbqEBEdyjykx2RI/unuo/mXftHfN3svdVcnbw2NjZ/O1w9vqhtbuiE8csOecnk1/Mpjz5+Lz 6yNvdEz8VTq8vwC2jaQxuy70RZxLuEf9tFzLGDN0q5bRBqPuG8cANsGmAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3cnrm5T8YeV1kCIotU2bUfTHhJxoajAoEhrjbqp5Jzt bpL9EWZlNst8YU/XTEyzwB4+lmimhppL5iNfPcUkS8NnSYZWPui/D3y+38OBcxhSNkl5MVEx Jt4Yo4uW0y6U40/Dh3We1yXaDdYmNyh+bUXQ9zGPhN6sDzSkjJ4noLtoC1SW3xZBxqcEAlIz xggoL7TQ8L03kYLh8XIC3lc5xHCzLVEM47UDYrjivIVgYHqQhBu2CQROa6kIpmoqaBiZvktB 6u8OBFdLGhE0XB6jIOuZHUGShYXR+wViyHvvDeO9jRQ4ep6K4eHPVhJKX88gSG8oRtCc9Fe0 dRX325Yv4vIqvxFcZm4rydX3ZIu5y6+sBPd42E5wI887aC61pAhxTX0pJPeg/xe91+WgIsho MJv4lZEGwRQsD1OCSqEMAIXKL0ChVGsOBar85es3Bx3jo6PieOP6zUcUkcmtb8WxLYtPlVXY iASU42pBEgazfvjci2xkQS6MjM1H+P61h7QFMbMC46F+ciHjhqc7LfRCZgLh0aphNCdodjV2 JFuJOeHOvqNx+8Wz1JxwY0NwcWqTaI4p1heXt2bMF6RsAG4f/D/VBz949GKeJWwgnhlpmWcZ G4Wd3RfQAnvjrjs/iDS02IYWFSF33izoI/SCSiHo9II5JkJx1KB/gmZvXlY/VWJHluHQWsQy SO4qtekYrUykixPi9bUIM6TcXRrS7Dgskx7TxZ/mjQat0RzNC7XIf3bBdNLL46hh9oNiTFql v1IDAUqNWqPeCHJPaTJbEy5jI3Qm/gTPx/LG/z2CkXgloIPVK6rq+/d5kQUehX6f2Y4p+57H ya+SGiYngsLUtv1R90KXntzu6pMZvtZ5fGhsZ0LbpgM7wpftdgZ31XkIN83BuZe2DS258PTr uZwsVXeKCM30+XhXZ0/uqMtV2jvqNSHq6gqjxJDbuSssk/AdOVOqffllue2NsyYto0a9U9Pu J6eESJ1yDWkUdP8AaswoBgkDAAA= X-CMS-MailID: 20200711104439eucas1p278753181e040c94f95e9b47deccccbbb X-Msg-Generator: CA X-RootMTR: 20200711104439eucas1p278753181e040c94f95e9b47deccccbbb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104439eucas1p278753181e040c94f95e9b47deccccbbb References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 05/24] net/i40e: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c | 5 ++++- drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 472ce2a9e..f718356b5 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2891,7 +2891,10 @@ update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link, link->link_speed = ETH_SPEED_NUM_40G; break; default: - link->link_speed = ETH_SPEED_NUM_NONE; + if (link->link_status) + link->link_speed = ETH_SPEED_NUM_UNKNOWN; + else + link->link_speed = ETH_SPEED_NUM_NONE; break; } } diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index eca716a6a..cf931bf9c 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2163,15 +2163,15 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, new_link.link_speed = ETH_SPEED_NUM_40G; break; default: - new_link.link_speed = ETH_SPEED_NUM_NONE; + if (vf->link_up) + new_link.link_speed = ETH_SPEED_NUM_UNKNOWN; + else + new_link.link_speed = ETH_SPEED_NUM_NONE; break; } /* full duplex only */ new_link.link_duplex = ETH_LINK_FULL_DUPLEX; - new_link.link_status = vf->link_up && - new_link.link_speed != ETH_SPEED_NUM_NONE - ? ETH_LINK_UP - : ETH_LINK_DOWN; + new_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN; new_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); From patchwork Sat Jul 11 10:43:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73815 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89C92A0528; Sat, 11 Jul 2020 12:45:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 823F81D9D5; Sat, 11 Jul 2020 12:44:46 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 648FD1D9D3 for ; Sat, 11 Jul 2020 12:44:44 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104444euoutp0174523a6f8ec5debd67c2437337c409d6~grNGRKnnC0814408144euoutp01c; Sat, 11 Jul 2020 10:44:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200711104444euoutp0174523a6f8ec5debd67c2437337c409d6~grNGRKnnC0814408144euoutp01c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464284; bh=8FgdUe6Aml3rB/AWNSgZoZqeJOx9OS3/lqpbs6iX2+c=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=fLiOCQbW71qdvaMhQwTdoOm2LxGCfsZIe9dW/R9vJxhwG1oe1bymrpsEJd2Wu4NkJ MNh6UZdn4W2kkb0Ir31U3vinaD8yTb3UGXpZhFgwqD/BoI1/6MO/v8c77iCZeuE2BA im1IEDuc5FWgGl+Ah1CbnSykcAzEKB6+rGbsibb4= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200711104443eucas1p1da7f11bcf8561f053c92079abff4c424~grNFRnWnq0930309303eucas1p1o; Sat, 11 Jul 2020 10:44:43 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 67.1F.05997.A18990F5; Sat, 11 Jul 2020 11:44:42 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200711104442eucas1p1cdbc60cbc6a7d7c6902e7797a8245d4a~grNEnn46d1558215582eucas1p1h; Sat, 11 Jul 2020 10:44:42 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104442eusmtrp2c63fb275d65c97a0e4488cab64ba8252~grNEmk2jI1628816288eusmtrp2Q; Sat, 11 Jul 2020 10:44:42 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-3f-5f09981a64c9 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 20.17.06314.A18990F5; Sat, 11 Jul 2020 11:44:42 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104440eusmtip11c7c3d9b63dd3af9936b7bf38b972126~grNC5KzEw0946309463eusmtip1y; Sat, 11 Jul 2020 10:44:40 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:53 +0300 Message-Id: <20200711104414.15422-7-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHd+69vffS2OWuGDniYkfJkmlU0DnzuJGpZEvuR0P2ZYuKVS5g hIq94ssWF+ImkqJlq7qNbqldiZMXx4sWiwS1YrSF0kJxWgiKjDlR5qggTHFlSLmYffud///8 zzl58vC09jibyO8w7pFMRkOenlUzF25MBpcn/hCXmRr2pZG6DjuQwf4KmgycuMuS0idfU6Sn eh1pcf+kItZ7RRSxWEcp4q40s+TxwCGGjIy5KXLnkp8jtu5DHBlrHeLIsc4fgQxFh2lS7ngK pNPeqCKTV5tZEok6GWJ5cQtImcsHxHt0lCEnLjYBKTYL5EnVGY5U3FlMxgZ8DPH3nufI2YkQ TRo7poB8660DEiieVq1PEl84TqvEipZHlHj85xAt3uj9jhOPttkpsWGkiRIjl2+xosVVDWL7 YCkt1tx/zm5Uf6ZOy5LyduyVTCkfblXntvTfZwqC3P5nod+gCGpZM8TxKKzGidPNjBnUvFao BHS22yilGAf8JzQ95zwFdDuvqF5F2m730YpxBtDbY2OVYgKwtzYKsS5WeAf9JfbZWfOFBhbd 0TAVM+KFDRg5EpmJ8zwjvI0PfuFiqBHWYnn7ImWBDmvqPXSM44T3cSrSNctaYTGGT43PjkTB x2Pnn2FGCXyEZYGTnMLxOOx1zfGbOH3xFKXwF/jsXJhTwiWA/c7Dc03r0PVXcPYIWliCdc0p irwBb9ecpGIyCq9jz99vxGR6Bq0XvqcVWYMlxVqlW4+etu45GXHq33mKLKKl9CYor3MJ8Fhj teob0Nn+3+UAqIYEqVDOz5HkVUZp3wrZkC8XGnNWbN+Vfw5mvqr/P+94EzRHt7WCwIN+nsZh 4DO1KsNe+UB+KyBP6+dr0gP+LVpNluHA55JpV6apME+SW2ERz+gTNO86H23WCjmGPdJOSSqQ TK9cio9LLAL74ezdPjFncrieeau067WMLqt7yLgxuQ1uVlYF1vSNdiSZf4+M3k06GArmOrtl 0eH4SvexJ0uToDG/1/epJzk9+d61wW7Hw00ZGaEH2R/oGvqul6cGR5YxC621qX98QvuyCx43 LfhyzOVZkl4VtsTzy39N09ku7zPVr72ekhAo0zNyrmHlUtokG14CjN/FZaYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTYRjHe885O+dstDgspZcFZQe6EGs6L/kY3T/EgcCKsqCbDT04yW22 MyXry7IymTXTRCrLLFmZRmVZmmikkbdlpmXe5oUlWRmuXFGGVlPp2x9+/+fHA8/DkqrvlJpN NFlFi0mfxNMKyvWnsX+V+qI8NuSPLxDuvSxE4BkoJmEor5+GrK+nCOgu3QA1lVdkkDtoI8CR +42AyhI7DV+G0ikYG68kwF3rYuByRzoD4/UjDJxrK0AwMvmZhEtFPgRthY9kMFFXTYN38gYF jt+dCLIrmhA0nv1GQd6TKgQZdg6+3r7FQLF7EYwPNVHg6nnIwJ0f7SQ8ejmFIKfxHoLWjL+y jUuE30VOmVBc84kQLlxvJ4WGnnxGONtcSAjlY1WE4H3aSQuOilIktHiySKFs+Be9XbFXu9Zi TrGKQQazZF3H79NBqFYXBdrQ8CitLizywJrQCD54/dp4MSkxVbQErz+kNdQMDFPJr5ijP9vf Ihu6S9uRnMVcOG5+10fakYJVcU6EfQXZfsD6Acajw+RsZz6efGenZzs+hLMLbDOA5lZgV2Yh MQ0CuD4avzlzgpoG87lN2HvGS06LKG4p/nCTmY5KLgpfalk461yMy+4/m9HIuTV4yvt6Jqu4 RNzWfRrN5kW469p34jyaV4TmlKIAMUUyJhglnVbSG6UUU4I2zmx8gPwXf9ww8bAKdZTvrEcc i/i5yiI9G6uS6VOlNGM9wizJByg3t7oOqpTx+rRjosUca0lJEqV6FOFfL4dUB8aZ/f9jssbq InSREKWLDIsMWw38AmUmV7dfxSXoreJhUUwWLf/nCFautiF+zv3TDpthV3NLjFm2rLfD2dTA Vo1mqUveNyrdSeceO+TMyVUnKzTDE7beGG6lTaHZ8Vx7lTTwGw91B7qViujjn19lPbA6o4+U DO7zuNOXhO2p0WSUb9lQXdby8YXGve0Kkx8S04qau0405QT5zLs9xRqTp7ZV3BoRnL+8upSn JINet5K0SPp/NgFR3gcDAAA= X-CMS-MailID: 20200711104442eucas1p1cdbc60cbc6a7d7c6902e7797a8245d4a X-Msg-Generator: CA X-RootMTR: 20200711104442eucas1p1cdbc60cbc6a7d7c6902e7797a8245d4a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104442eucas1p1cdbc60cbc6a7d7c6902e7797a8245d4a References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 06/24] net/ice: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Reviewed-by: Ferruh Yigit --- drivers/net/ice/ice_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index b51fa2f17..76f797de0 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3135,8 +3135,11 @@ ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) link.link_speed = ETH_SPEED_NUM_100G; break; case ICE_AQ_LINK_SPEED_UNKNOWN: - default: PMD_DRV_LOG(ERR, "Unknown link speed"); + link.link_speed = ETH_SPEED_NUM_UNKNOWN; + break; + default: + PMD_DRV_LOG(ERR, "None link speed"); link.link_speed = ETH_SPEED_NUM_NONE; break; } From patchwork Sat Jul 11 10:43:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73816 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07C99A0528; Sat, 11 Jul 2020 12:45:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 611C21D9F5; Sat, 11 Jul 2020 12:44:48 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id A82061D9B5 for ; Sat, 11 Jul 2020 12:44:46 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104446euoutp027694745a9446f76c3bb6b4b68c581d09~grNIXqODP1781617816euoutp02Y; Sat, 11 Jul 2020 10:44:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104446euoutp027694745a9446f76c3bb6b4b68c581d09~grNIXqODP1781617816euoutp02Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464286; bh=umWDSYfnL7Dz/b6egJP1LVyW6kmgp5G6qaf8A7qGC40=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=k4/wBIDaaUo+QLmKb3eI95PRKCTxONzk+v5BFPpZKWUaH31b4alYHjzzswa0knnK5 rKD3IkHipFSS7GvIQ+vWYxIOssfTkKOUoDL0xrpTJZzahqxeJmeGx5iiIItqMW3+Ji iTsjOziuAL3HuVC7CY4NmKXViyvLnb1Xb0Z8Afbk= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104445eucas1p2f0f6abe55fd26883b07c70f03f1d28e4~grNHvuxNB1984019840eucas1p2z; Sat, 11 Jul 2020 10:44:45 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 64.55.06456.D18990F5; Sat, 11 Jul 2020 11:44:45 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200711104445eucas1p1b870b02e0d7ca36c788344b9ae674640~grNHXCySF0930309303eucas1p1q; Sat, 11 Jul 2020 10:44:45 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104445eusmtrp10187636c40034ff5f7b4267e5d4f6d0c~grNHWPVAW2954729547eusmtrp14; Sat, 11 Jul 2020 10:44:45 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-2d-5f09981de3b5 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id B3.86.06017.D18990F5; Sat, 11 Jul 2020 11:44:45 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104443eusmtip11f61327b1c05692c3926b695a37ce99b~grNFjBRbh1304313043eusmtip1h; Sat, 11 Jul 2020 10:44:43 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:54 +0300 Message-Id: <20200711104414.15422-8-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf0yUBRjH97zve+/73unZ6+niERPnbTXTgbpqe3KZlo69f7SV9Y9rGb3q O0Q4sDtQoVp0AWNAZMDMwAEdS+nIEDw4UCy52uFx/Lx0iBmisthZiZ5gIqBx957rv+/zeb7P jz17RNZUwceKKemZqjVdSTPzBq7VO90Xv+KoPmn95MXnqLGnGujGSB1LoxV/8FR8J4+hy87N 1OE+pqOya7kMlZbdZchdX8TT36N2jm6H3AxdPecXqDJgFyjkGRfoi/4qoPHZWyx9U3sPqL+6 RUfTnWd4mph1cFT68BLQl64LQF0ldzmqaG8DKiiS6M73JwSquxpHodELHPmHTwv0w9QgSy09 c0BfdTUC9RY81m1ZJT+s/U4n13UEGbn820FW9g4fEeQSXzUjN91uY+SJny7xcqnLCXL3jWJW bhh7wL9leNfwyh41LeWAal336geGvVOhx+z+U5sO3R9rZ3Ph6Poi0IsovYgznflMERhEk1QP eL2/SqcFk4CBa/1C2GWS7gG6PNyTip9Hb0ZNJwB90wHQginASnuICbt4aTX6C6sjfZdKTTy6 Z4ciiSXSFgza89iw5qRnsSZoj2ij9DL6PvOBNmIlNpw6H+F6aSPOTQyw2hpxOFQzGWmK0oCI rUFvdKdt+NvJQFQvwVtdLkHTz6C/vCTKP8J/m4cErbgQcMSRHzVtRtdfffNaFFnpeWw8s07D r6Gze4YNY5QW4eV/FocxOy/LWr+OYiMWFpg0txnP+wJRjDg3s1DDMh6v+kXQ7nMOsHmmlD8M Kyv/n1UL4IQYNctmSVZtG9LVgwk2xWLLSk9O2J1haYb5X/U/6gq1wVRglwckEcwLjbWKmGTS KQds2RYPoMialxpf7/W/bzLuUbJzVGtGkjUrTbV5YLnImWOMLziCO01SspKppqrqftX6JMuI +thcSNzWrSQk1kwML8se2dpXd/ig093zpqHT82PnlfumBt3qVY7EB1mpvUd+tzwdb30n/1jc 22X7frUXD+ZA8Y6XOk7mrf0zsGDfJ2PbN25t2eS8OF3ec2hHhe+Kl4nJiE31nh05/sZAzueL E58aF5d9enrn7vhMx4fNi9rrlZT3Pr6pb1ohT5o5215lwxrWalP+A6qA9ACnAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSaUgUcRjG+8/Mzs5KW8Nq9EfQalOQos31fBWPiI6xPiREFGrZqoOKris7 ux32RUVTxrRMCe1QUxZNO6w03W438lrFVMwONTMrtNDSsjTNPOjbw/t7npcXnpchFVOUPROb YOD1CZp4JW1DWf829W9xKJCFu5anyOFWWxGCoYEyEgbz+2nI+pZGwKvKQHhYd1kC598lE5Bz /jsBdRUiDV8HUykYm6gjoO+RVQoXu1KlMGH5LIXsjksIPs+OklBYMomgo6hWAtMN92kYny2l IGemB8HZmmYETWe+U5BvrkdwWmTh27VyKZT1OcLEYDMF1td3pXD9ZycJtW1zCHKbbiFoPz0v 2baBmykxSbiyhyMEl3e1k+QaX1+Qcmdaigju9lg9wY0/7qG5nJpKxLUOZZFc1fBvOtgmROWn 1xkN/PoYnWDwV4aqwU2l9gGVm4ePSu3ufdjXzVO5NcAvio+PPcbrtwYcVcX8nJgnE6v9T0wN m8lkVOAqIhmDWQ/8ZPCDREQ2jII1IWyyFCIRMQsA4y/D5LLHFs++FOllzyTCZc97pYuAZl2w NbOIWAR27Fsad2ekUIvAlt2GR1LTltIU64yLR1KXtJz1wS0pLWh56zpcVf10aS5jffHc+Isl rWBjccerdLSsHXFv8Q/iHFpVglZUIjveKGijtYKbStBoBWNCtCpSp72DFjq/1zhdU4/Esf0W xDJIuVJeomHCFRLNMeGk1oIwQyrt5NvbrUcU8ijNySRerwvXG+N5wYI8Fw7MJe3XROoWPijB EK72VHuDj9rb3dvdC5Rr5ZlsQ5iCjdYY+DieT+T1/3MEI7NPRhnOXjbm0lO9mcGlD5Jcpluv 1L45xQWO2jVlfOw3VcuMz1z6zMfn9hz8U7WRbg1dd50yzcnbcXYFdvI7gA65rtpBpUf+ik4Z jcifjwiqfF8aSe8NictyvLm5MEv6KU00O4UF3Zh0aNyZGGK7OjfbQ79ryN8hvStkoLvYf/e+ D3mikhJiNOpNpF7Q/AOx44LYCQMAAA== X-CMS-MailID: 20200711104445eucas1p1b870b02e0d7ca36c788344b9ae674640 X-Msg-Generator: CA X-RootMTR: 20200711104445eucas1p1b870b02e0d7ca36c788344b9ae674640 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104445eucas1p1b870b02e0d7ca36c788344b9ae674640 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 07/24] examples: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov --- examples/ipv4_multicast/main.c | 12 ++++------- examples/l2fwd-jobstats/main.c | 12 ++++------- examples/l2fwd-keepalive/main.c | 12 ++++------- examples/l3fwd/main.c | 12 ++++------- examples/link_status_interrupt/main.c | 30 +++++++++++---------------- 5 files changed, 28 insertions(+), 50 deletions(-) diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c index 7e255c35a..e32602521 100644 --- a/examples/ipv4_multicast/main.c +++ b/examples/ipv4_multicast/main.c @@ -572,6 +572,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -591,14 +592,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index 47a3b0976..bb86fe654 100644 --- a/examples/l2fwd-jobstats/main.c +++ b/examples/l2fwd-jobstats/main.c @@ -689,6 +689,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -708,14 +709,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c index b2742633b..24c0f5df6 100644 --- a/examples/l2fwd-keepalive/main.c +++ b/examples/l2fwd-keepalive/main.c @@ -453,6 +453,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -472,14 +473,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 24ede4290..274b8fbcd 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -810,6 +810,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -833,14 +834,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/link_status_interrupt/main.c b/examples/link_status_interrupt/main.c index 9bbcadfcf..749471256 100644 --- a/examples/link_status_interrupt/main.c +++ b/examples/link_status_interrupt/main.c @@ -118,6 +118,7 @@ print_stats(void) const char clr[] = { 27, '[', '2', 'J', '\0' }; const char topLeft[] = { 27, '[', '1', ';', '1', 'H','\0' }; int link_get_err; + char link_speed_text[16]; /* Clear screen and move to top left */ printf("%s%s", clr, topLeft); @@ -131,9 +132,10 @@ print_stats(void) memset(&link, 0, sizeof(link)); link_get_err = rte_eth_link_get_nowait(portid, &link); + rte_eth_link_to_str(link_speed_text, 16, "%M", &link); printf("\nStatistics for port %u ------------------------------" "\nLink status: %25s" - "\nLink speed: %26u" + "\nLink speed: %26s" "\nLink duplex: %25s" "\nPackets sent: %24"PRIu64 "\nPackets received: %20"PRIu64 @@ -141,8 +143,7 @@ print_stats(void) portid, link_get_err < 0 ? "Link get failed" : (link.link_status ? "Link up" : "Link down"), - link_get_err < 0 ? 0 : - (unsigned int)link.link_speed, + link_get_err < 0 ? "0" : link_speed_text, link_get_err < 0 ? "Link get failed" : (link.link_duplex == ETH_LINK_FULL_DUPLEX ? \ "full-duplex" : "half-duplex"), @@ -445,6 +446,7 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, { struct rte_eth_link link; int ret; + char link_status_text[60]; RTE_SET_USED(param); RTE_SET_USED(ret_param); @@ -457,13 +459,8 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, port_id, rte_strerror(-ret)); return ret; } - if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", - port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + rte_eth_link_to_str(link_status_text, 60, NULL, &link); + printf("Port %d %s\n", port_id, link_status_text); return 0; } @@ -478,6 +475,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -497,14 +495,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Sat Jul 11 10:43:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73817 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72F1CA0528; Sat, 11 Jul 2020 12:45:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5BB21D9E2; Sat, 11 Jul 2020 12:44:51 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 72AC11DA07 for ; Sat, 11 Jul 2020 12:44:49 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104449euoutp01acb68659be88e22c646d2f1a842627a0~grNK7nO--0814708147euoutp01V; Sat, 11 Jul 2020 10:44:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200711104449euoutp01acb68659be88e22c646d2f1a842627a0~grNK7nO--0814708147euoutp01V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464289; bh=E9gl5DPxg/AQaI7PtF3VdpBf9QeHih+17843ABYmhz8=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=GnaU50ef6CVunUgtNbUtSYeFCI2K4j8m3nZeNqu7JjfhVzWEF01M8h6i6FRquzwa4 Vv+CZ8jMgXxHpipusG6wQm6h51rXJyMb54+AxxifPk5eAxo5hn1xsue+Z8hXRDIMup FNA7RcW98NM9kUdY3RPcr7zoHqRwc+pi+kn2hkqk= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104448eucas1p217e76f840b95d6b44aefd051f8e983e9~grNKThiea2336423364eucas1p2R; Sat, 11 Jul 2020 10:44:48 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 12.87.06318.028990F5; Sat, 11 Jul 2020 11:44:48 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200711104447eucas1p1a81caf54288d1b9b754a80589ea5c1a0~grNJ1RB5t0930809308eucas1p1q; Sat, 11 Jul 2020 10:44:47 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104447eusmtrp280da0b309e366a85d6043de50542ee6b~grNJ0esyb1628816288eusmtrp2R; Sat, 11 Jul 2020 10:44:47 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-4d-5f099820963b Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 42.17.06314.F18990F5; Sat, 11 Jul 2020 11:44:47 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104446eusmtip1ea42739fce2b3fb33c8b6dac161183c3~grNIFEXk20946309463eusmtip1z; Sat, 11 Jul 2020 10:44:46 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:55 +0300 Message-Id: <20200711104414.15422-9-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSbVBMaxyf55yz55zdad1judO/uFwrBjPIeJm/d9e4dw5jhuELGmpxVKNi duXl+lKG1VaSZBGyCqu8lFoq04Y+2LqrUqwY2dvtdqVcbUoUpdvuWXO//eb39v89Mw9PazLY YD46bo+kj9PFaFkVc/dRf930n88ow0PflAVjweNsgi3uXBqbM1+zmNJ1mMIX+UuxvOS8AjP+ TKAwLeMDhSXXkln8t/kQg53dJRQ22Z0cZjUc4rC7so3DY3XnCLYNdNB41tJDsC77jgL7H95j 0TOQw2DaFxfB47Yqgo7UDwxmlpUSNCYL2JVn5TC3aRx2N1cx6HxZzOGN3noa7zweJHjCUUCw xjikWDZB/GK5ohBzy9sp8eSlelp89NLMianV2ZR4u7OUEj0VLlZMs+UT8Y+WFFq83trHrlVt Ui3aLsVE75X0M5dEqKIennpOdqcp99dnGtkEUs4lEyUPwhw4136fSiYqXiNcI/B3opV4BY3w kYDnSJgs9BAoLk1VfE+8evaUkQUrgbw8sz/eS8Bak0J5XawwBZxJ2T5htHCbhZKBRp8wSlgF p97W+KoYYRI0JfYMV/G8WpgP6UZKvjAerhc+oL1YKSyAQc8TWp40DhovfvR1glDFg63iMCMH VoDpWysr41HQ4bD5HzcWhsou+ksPwueiRk4OJxFw5xzxm5aC7V0t5x1BC1Oh4N5Mmf4FzI5C Hw3CCHjxfqSXpodhxt3TtEyrIcmokd1aeFDd4KcBBr8GyLQIFlOtf72dQJt7YzoZn/X/KQsh +SRQijfERkqG2XHSvhkGXawhPi5yxrZdsUVk+Kc6vzl6S0nFwNZKIvBEG6C26PhwjUK313Ag tpIAT2tHq5fXOLdo1Nt1B36X9LvC9fExkqGSjOEZbaB6dk77Zo0Qqdsj7ZSk3ZL+u0rxyuAE EnTDut+1sV5pGvEZz6we+sm1sHnH0csFKT9OfJe+PsJ+4WT/rYX/qLi5qxcHHNtQ1xoU4f60 ztQX9swdvCPs1/yW9jVBRa/O/+Yybwq56bRUz3s/ecW2kCRH8Vh73zKl0GWa6Pnrh8AtmLg1 /NZkc1TqvM4xHYV0iMIRutIeHXql8+oJLWOI0s2aRusNuv8AcOFeiaUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzVSbUhTYRjtvffu7k5aXOaiF8mvUVBGs7lsj2b28etS/eiDou819KKS23R3 WkbQjDJZZrNmVOa0pDKNzLJcYqFCaW2ippWmqyHS+nSlRhlmTaV/h+ec5zwHzsOQsjEqhEkz mHmTQZeuoIMo12SrZ2n4BYl2WV8nQI3bgWDwbQUJXruHhlPfjhPQW7UaGusvi+DsOwsBhWe/ E1BfaaXhi/cYBcMj9QQMPHKJ4dKLY2IYafGJ4XRHCQLfxCcSLpaPIuhw3BfBeHMDDf6JqxQU /n6J4ExdG4LWgu8U2B86EeRZWfh284YYKgbCYMTbRoGr754Ybv3oIuG++w+CotYaBO15f0Vr Irnf5ddEXEXjR4I7d6WL5J72nRdzBc8cBFc77CQ4/+OXNFdYV4W454OnSK566Be9KWiXMsFk zDLzEalGwbxKsVsFMUpVHChjlscpVWrN3viYWEV0YkIyn56WzZuiE/crU5uLX6GMQsmhLnse bUGNYiuSMJhdjvt7uqkpLGOvIezyM1bEBOYYfx4iZyTBeOKVlbaioIBkFOECp2daT7OLsCvf QUwRcrafxt0nc6eJYHY9Lv7QLprCFLsQD+SOUlOmUjYO2/KIGdNwXH2nafqAhI3Hf/yd5EyG NNzRewLN4DD8umyMsKE55WhWFZLzWYI+RS+olIJOL2QZUpRJRv1dFGj8wdPxe070onZrC2IZ pJgtLdcxWplIly3k6FsQZkiFXLqu3bVPJk3W5RzmTUatKSudF1pQbCBfERkyN8kY+B+DWauK VWkgTqVRa9QrQDFPms8275GxKTozf4DnM3jT/z2CkYRYkCPS59lR9v5MW5TX96ubeJNtHHt9 8F24P+xDByqZZXuz9vbi0o2h821hW8JHjzf7IsShxdvJdveOTO+RzG39DbbK1pUu+/Pgn/H2 DT/q1AuKtJ86D123yN3uyc1PdkslueoEfXVk5u10zxeNZVmP27yzlpGXfi1rONokWhBTIl2i oIRUnSqKNAm6f0jCPR8HAwAA X-CMS-MailID: 20200711104447eucas1p1a81caf54288d1b9b754a80589ea5c1a0 X-Msg-Generator: CA X-RootMTR: 20200711104447eucas1p1a81caf54288d1b9b754a80589ea5c1a0 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104447eucas1p1a81caf54288d1b9b754a80589ea5c1a0 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 08/24] examples/bbdev_app: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/bbdev_app/main.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 68a46050c..ac7166bc9 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -313,6 +313,7 @@ check_port_link_status(uint16_t port_id) uint8_t count; struct rte_eth_link link; int link_get_err = -EINVAL; + char link_status_text[60]; printf("\nChecking link status."); fflush(stdout); @@ -323,11 +324,8 @@ check_port_link_status(uint16_t port_id) link_get_err = rte_eth_link_get_nowait(port_id, &link); if (link_get_err >= 0 && link.link_status) { - const char *dp = (link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - "full-duplex" : "half-duplex"; - printf("\nPort %u Link Up - speed %u Mbps - %s\n", - port_id, link.link_speed, dp); + rte_eth_link_to_str(link_status_text, 60, NULL, &link); + printf("\nPort %u %s", port_id, link_status_text); return 0; } printf("."); From patchwork Sat Jul 11 10:43:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73818 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F3DAA0528; Sat, 11 Jul 2020 12:45:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE0941DA10; Sat, 11 Jul 2020 12:44:53 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id C4AAC1DA10 for ; Sat, 11 Jul 2020 12:44:52 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104452euoutp0130ca4742f6203c12f24123b9ec403a90~grNOGzOar0814708147euoutp01W; Sat, 11 Jul 2020 10:44:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200711104452euoutp0130ca4742f6203c12f24123b9ec403a90~grNOGzOar0814708147euoutp01W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464292; bh=mRx7pBLZbpt5Gw+L5M5nsQty4a6+A6cQBxZj077yqMU=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Cdsruwkj9Qwp/a6ImhBWi3XbEgGBgvYpnNAufUkMAk+IDdc36InNeyPGvsB9cnMzu SSAuPym0tA4RAh29TnLnRxh1rc/h3q3LBcAyquKVSPclguRfzce8MXpr5zxl/AnYel iRlTVT6Fh3yeI6FJY+rzEeGFTv5qVU4+9e3HyW+c= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200711104451eucas1p166905ede5ced1aeede492435de7e155f~grNNAeXsv1560515605eucas1p1e; Sat, 11 Jul 2020 10:44:51 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 89.1F.05997.328990F5; Sat, 11 Jul 2020 11:44:51 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104450eucas1p25d8dcf9ccbddff8d3525c294a3b5b585~grNMTH3XJ2331023310eucas1p2F; Sat, 11 Jul 2020 10:44:50 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104450eusmtrp1e0ae689c1e5e4e921252cd7eebcc8fd5~grNMSU9FO2954729547eusmtrp15; Sat, 11 Jul 2020 10:44:50 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-48-5f0998230f79 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D5.86.06017.228990F5; Sat, 11 Jul 2020 11:44:50 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104448eusmtip19252a07872670e744c593036a62dccea~grNKi3Tf51304313043eusmtip1i; Sat, 11 Jul 2020 10:44:48 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:56 +0300 Message-Id: <20200711104414.15422-10-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHc+69vfe2s+ZadT5Boq6LUUkEX7bkzBh1U7P7zQU/yaLY6Q2i FLVX2NgSA4jIKgMHbAqbpbRRsKBdpQp2OLGJvBXlZSolQyWdkeAbWiEKFlzprdm33/mf//85 OScPT+t+YWP41PRDkindkKZnNczllvFbyz8+pU5e0V41F52dFsDAfTuNg2X3WDz+Io9Cv2M9 NjX8rsKSB9kUFpW8pLChxszi08FcBp8HGygcuOrjsKI3l8Ogd4jDn7p+AxwKPaax3PoKsMty SYXj1z0sjoRsDBZN3AEsdrcBtha+ZLDsSiNgvlnAF+eqObQPLMDgYBuDvv56DuvGemi81DkJ +HOrE/Bm/jvVho/ECesZlWhvGqbE0qoeWmzp/5UTC9stlOh63kiJI3/dYcUitwPEjsBxWqx9 +Ib9SpOkWbtbSkvNlEwJ63Zq9lwby4EDLvV3/mIrZEMHZwY1T4RPyLMzAZUZNLxOqAFyu/ws pxSjQPoddaxSvAJy/+w4/T7S6B6mlEY1kJC3OpofA3IjcIqadrHCUuIrsERccwQXSxpCfZHG bGEzyXO2sNPMCItJ0FysmmatsIb0XLhLKSMWkto/miPj1GF9cqQ7wjphAemrHI08SoRunvT4 b4AS2ER6c2xRnk0et7qj68USX2kho/AP5PXFPk4JF4QXsh2NmtYT95NbYeZ5WlhGnJ4ERf6c DDy4G5GJMJP4n82alukwllw+SSuylhTk6xS3njS390ZlQibfzlBkkVgcj6LHugrk/NQ9OAEL K/6fZQVwwDwpQzamSPKqdOnbeNlglDPSU+J37TdehPBn9U21jjaCJ/SNFwQe9DO0VgOfrFMZ MuUsoxcIT+vnaL+46duh0+42ZH0vmfYnmzLSJNkL83lGP0+72ja8XSekGA5J+yTpgGR636V4 dUw2bO6e5ZK1nrWV+0pj/3n347Ep3cTObZ3/bsn1lwc6qg5+ShKd88sqatm8uA9WSJW+mV+/ iavoXjP8We6ixGRb0d519sol+Gfzia7yvfFJp7Vbc44sr/8w2LYt0X5lCA5ff5JFp3pcSdu/ zFTH1hubuo4w1zxLXyewix7l2GL+ho1ZD/WMvMewMo42yYb/AN0fVCOoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3cnLi7T6OIfaosiesw2tR3FtCzpBkmBUFiZrbqotYft bpL1j5WVXc1n9NC0lUillpkrzV7qH2pOMYt8UJaJZJo4nRpp05pK/3043+/3nAPnULjsF+FF JehNnFGv0cpJN8I219S7QX5DErtx6uZKqGgtQtD/pRiHvqu9JKSPpWLQXRoGL6tviSD3awoG mbnjGFTfF0gY6TtHwKijGoPPr2xiyH9/TgyOhkExXGkvQDDoHMbhpmUCQXvRUxFM19eSYHfe JSBz5iOCLGszgqaMcQKuPq9BcFGgYezBPTEUf/YGR18zAbaeKjGUT3Xg8LR1FkFOUwWCtot/ RVtWsDOWEhFb/HIIY/PudOBsY881MZvxtghjK0drMNb++iPJZlpLEdvSn46zZQO/yT1u+xUh RoPZxPnGG3jTZvkBJagUyiBQqAKCFEp/dUywKlDuFxpyjNMmJHFGv9DDivg3U2dRYqXkVHeW BaWgFrGAJBRDBzA11iFMQG6UjC5BTEmPXSQgyiUwzM8BfNHjwTg7BXLRM4GYIaGWnBdIeg1j SytaCHvSn0jmw6WzxLzgQUcwqRWNCyaCXsU4hCzRPEvpYKbjUSe22NWHKXtctzBB4qrP2t8t sIxOYNq7L6BF9ma6bk9i2WipBS0pRZ6cmdfF6XiVgtfoeLM+TnHUoHuCXDd/1jhtrUHCaFQD oikkd5daNFSsTKRJ4pN1DYihcLmnNLzNdkgmPaZJPs0ZDbFGs5bjG1Cga8Ec3GvZUYPrg/Sm WGWgUg1BSrW/2n8TyJdL0+j6gzI6TmPiTnBcImf8n8MoiVcKUqUVbF+dFLHte7S2OvTM+RVH Ynz8ViX8oPdWdUdNv15/YDd6FFk+3DxiPs4T0bvctlrSR8tO1Jt3ZpfnZhf67R8nwqTuT05W Xd/3J9Ka6OwMKfjgYTfXDeSJfb0Lu7qG86YmX6ybq7XrNhjcH+7K35F8Wa8O+pYTGp6uvlyn dfQ55QQfr1GuxY285h+SBxwiCQMAAA== X-CMS-MailID: 20200711104450eucas1p25d8dcf9ccbddff8d3525c294a3b5b585 X-Msg-Generator: CA X-RootMTR: 20200711104450eucas1p25d8dcf9ccbddff8d3525c294a3b5b585 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104450eucas1p25d8dcf9ccbddff8d3525c294a3b5b585 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 09/24] examples/ioat: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ioat/ioatfwd.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index b66ee73bc..7d1164ebd 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -700,6 +700,7 @@ check_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret, link_status = 0; + char link_status_text[60]; printf("\nChecking link status\n"); RTE_ETH_FOREACH_DEV(portid) { @@ -715,15 +716,11 @@ check_link_status(uint32_t port_mask) } /* Print link status */ - if (link.link_status) { - printf( - "Port %d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_to_str(link_status_text, 60, NULL, &link); + printf("Port %d %s", portid, link_status_text); + + if (link.link_status) link_status = 1; - } else - printf("Port %d Link Down\n", portid); } return link_status; } From patchwork Sat Jul 11 10:43:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73819 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 671DEA0528; Sat, 11 Jul 2020 12:46:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 354141DA28; Sat, 11 Jul 2020 12:44:57 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 463CE1DA19 for ; Sat, 11 Jul 2020 12:44:54 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104454euoutp02d612cc1cf6bfb61fd6b92cb3b6b98567~grNPec90U1781617816euoutp02Z; Sat, 11 Jul 2020 10:44:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104454euoutp02d612cc1cf6bfb61fd6b92cb3b6b98567~grNPec90U1781617816euoutp02Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464294; bh=jOyf4J6mQZov9Rj8aTrBZxIfZbEYK4zbTZ0O4mCw93w=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=I6uB6TmOktYkpR4jqEKtDzoq4h+EtHQeiWNZbigGzK2aL8oZI16lb33ESoTat6Sx8 7tGhoylGdfL1yXgKt2ni9GE4YsbIif3CttZvLFEXlt7nf+ZQt9s2Yh21IZ/pSLUh+e n0xL0VWVu6tbDdNn/jW6+wS5gI0AY1CWsrtrqVyo= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104453eucas1p284508d4dfe6ec9e6c6a3c4f8365dad70~grNPDspSA2338123381eucas1p2f; Sat, 11 Jul 2020 10:44:53 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 34.87.06318.528990F5; Sat, 11 Jul 2020 11:44:53 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200711104453eucas1p1dc0da855700e19677dd83aa4b49cfdf5~grNOuLmtd0930809308eucas1p1r; Sat, 11 Jul 2020 10:44:53 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104453eusmtrp118780c429b1e6e4569b44901569c41d0~grNOtUa8e2954729547eusmtrp16; Sat, 11 Jul 2020 10:44:53 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-54-5f099825061f Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id F7.86.06017.528990F5; Sat, 11 Jul 2020 11:44:53 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104451eusmtip1b23ef5f06e2bdffa7c9529fbfed8f362~grNM_0n3X0946309463eusmtip10; Sat, 11 Jul 2020 10:44:51 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:57 +0300 Message-Id: <20200711104414.15422-11-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0iTYRTHe977Rou3KfVkYbUyulpiwaEkKwreL8GIIApqrXyzSE02tTuY mem8VFtXGzq10mbgNS/RrPahrabNJFEpyyKSWXlLTW1Wbq/Rt9/5n//5H57Dw5FKExPEHYlL EHVx2hgVI6dqno+5V4XclGnWlFctgrLGPASf3heR0HW1k4HM/lQC2q2R8LjWTIPxQzIBOcYB AmpLDAx860qhoHewloB3NhcLuS0pLAzau1nIdt9G0O3tIeGW5QcCd95DGsaePWKgz1tIQc54 K4JL1U4EjqwBCq7W1yFIM/DQf7+YhaJ3wTDY5aTA1VHFwoPh1yQ8bJxAcMVRhqAp7Q+9aaEw brlLC0WPPYRgKnhNCs87rrNC1os8QqjorSOEvoZWRsiptiLh5adMUij9PMqo5XvkEVFizJEk Ubd643754RrvWzb+/LwTnp5RIhllzjIgjsP8Wpz5ZKEByTklX4Lw+4vFhFQMIZzfl8NIxQ+E 6+/YkAHJ/BMlNhsrNYoRvtjbSUnFMMLOqmeUz8XwS7ErPc+fFchXMLjW20b4GgH8NjzYbqZ9 TPEh+Lsn1x+r4NfjbruXklbMx6XlT0kfyyb1ib5mPyv5YNyWP+QPxXwjh8duvp0a2IpbjRm0 xAG4x1HNSjwPu0xZU57T+GdlGysNp08+tfDClCkSV399xfrOQfLLcNmj1dJlNuNfoysknIHb v8/0mclJNNbcICVZgdPTlFKGCj990TIlYzzxa7okC7il2UlL57EhfK/0AXUZzc/9v8qCkBXN FhP1sdGiPjxOPB6q18bqE+OiQw8ei61Ek1/V9dsxXIcavAfsiOeQarrCouU0SlqbpD8Za0eY I1WBii1Nrn1KRZT25ClRd0yjS4wR9XY0l6NUsxXhhZ69Sj5amyAeFcV4UfevS3CyoGQUlJSf OmI+NHrWuuRrWOT2flPkutTmgNsJOwYc2xZ3nLjWEGE10XcNmjMbTLsNH+eqVkXFF+wMo81F MndEk6bLPGf7xg+7wtzTmpOMVsv1BQ7vnoyVL8eDKWFxo1o98ia73NypbjV8abv2pV7Tna8I 99QN9w+FyocCzzlD3NFqp4rSH9aGLSd1eu1fe5ITwKYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTYRTA++69u/dOXNym1YeE5ciKwNnUtWNlRRFcoiLov17rmheV3Ca7 MywiTMtqpuWjTCszRXz0sPIxeyxyUMtW2INKm5ZaIJr5mD2slrUl/ffj/M4LzmFJ5TcqhE02 WkSzUUhR0QGUa9LZHRF+Vq5f8ik3EOqflCHoe1dJQk9RNw05o4cJ6KhbBXdt52VQ8D6DgLyC MQJsNVYahnoyKRj22AjosrsYKH2RyYDH0c9Abvs5BP3eQRJKyscRtJc1yeBH620aRrwVFOT9 fIXgZOMjBM4TYxQU3WpBkG3lYLS2moHKrlDw9DyiwNXZwMCVr89JaHryG0G+sx7B0+w/stVh /M/yKhlfeXeA4AsvPSf5h51nGP5EWxnB3xhuIfiRe69oPq+xDvGP+3JI/vLHCXpzwFb1CrMp zSLOSzJJljjVNg1EqTWxoI6KiVVronU7lkVpVZErVySIKcl7RXPkyl3qpGavm0nNmpM+MDhB ZKCcWVYkZzEXg2vsdsaKAlglV4Xw6UwnsiLWJzD+9JGcygnC3tdWeipnHOExWxvjFzS3CLuO lRF+Ecy5afzy6CHKL4K4ddjTcV7mZ4oLx58HSpGfFdwy3O/wUlNd5+LL1+//myD3xX+PPPvH Si4Zt3ccQVMcit9c/EKcQtPL0bQ6FCymSYZEgxSllgSDlGZMVO82GW4i382bH/5obEHW4S0O xLFIFagoF1i9UibslfYZHAizpCpYseapa6dSkSDs2y+aTXpzWoooOZDWt2A+GTJzt8n3QUaL XqPV6CBWo4vWRS8F1WzFMa51u5JLFCziHlFMFc3/6whWHpKBTC3u2gvalGJPTX0gsW78SkLd SLjJfTp+9cHl8qsDfUVD7rWT6MP3TcHC+g0bdQsaFtpLdqQWh804oJg/2GfKCmQWbtDqC6oL 41obPtia4U5+4rX27LWM5YtjonV0zG7kZj547+yM761ua3ob31sxXJD+uDECl/S0/fIct0QW 1qooKUnQLCbNkvAXPoyxQwkDAAA= X-CMS-MailID: 20200711104453eucas1p1dc0da855700e19677dd83aa4b49cfdf5 X-Msg-Generator: CA X-RootMTR: 20200711104453eucas1p1dc0da855700e19677dd83aa4b49cfdf5 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104453eucas1p1dc0da855700e19677dd83aa4b49cfdf5 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 10/24] examples/ip_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications: * ip_fragmentation * ip_reassembly * l3fwd-acl Signed-off-by: Ivan Dyukov --- examples/ip_fragmentation/main.c | 13 +++++-------- examples/ip_reassembly/main.c | 12 ++++-------- examples/l3fwd-acl/main.c | 12 ++++-------- 3 files changed, 13 insertions(+), 24 deletions(-) diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c index 4afb97109..e6990830f 100644 --- a/examples/ip_fragmentation/main.c +++ b/examples/ip_fragmentation/main.c @@ -593,6 +593,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -612,14 +613,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up .Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index 494d7ee77..7c02d3451 100644 --- a/examples/ip_reassembly/main.c +++ b/examples/ip_reassembly/main.c @@ -712,6 +712,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -731,14 +732,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index f22fca732..427e291e6 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -1815,6 +1815,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1834,14 +1835,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Sat Jul 11 10:43:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73820 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 055E6A0528; Sat, 11 Jul 2020 12:46:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD6AE1DA4C; Sat, 11 Jul 2020 12:44:58 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 62FAB1DA31 for ; Sat, 11 Jul 2020 12:44:57 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104457euoutp0101482f25537403fe54f6f8c0bfc43fc4~grNSaT60E0814408144euoutp01e; Sat, 11 Jul 2020 10:44:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200711104457euoutp0101482f25537403fe54f6f8c0bfc43fc4~grNSaT60E0814408144euoutp01e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464297; bh=m59DocdpBmz6zpeYlI/lYCa1xdU/4ezlcOeXWIanCQY=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=niSx7cym8ZAY31gC0gjU7XZmy9AD8nBBik185zbP8R0yKxGDRyO6CwBoyJqP6oRiw CYypq0jBsdVOMvwoHSxoupFdutrrKm+SqEnHj5BRQCnaiiWIhRoVRzfsr3KrEo1DA3 ZOIKWOnF1+V2bUPLZVyRPP2fY88/FXPFLI/yT7Ms= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200711104456eucas1p1f5cdafa2fa1088166650b5a8f993a145~grNSIcXsv1619116191eucas1p1t; Sat, 11 Jul 2020 10:44:56 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id AB.1F.05997.828990F5; Sat, 11 Jul 2020 11:44:56 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200711104456eucas1p18d73e4e8c5def14db58fe74697ea4356~grNRgg_A_1619116191eucas1p1s; Sat, 11 Jul 2020 10:44:56 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104456eusmtrp18c3ef6ce903ee94522504a05af9f71d6~grNRfe3Rj2954729547eusmtrp17; Sat, 11 Jul 2020 10:44:56 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-4e-5f09982824fe Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F4.17.06314.828990F5; Sat, 11 Jul 2020 11:44:56 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104454eusmtip1d95fa1c7554bf2c3c43b572a09fd3b47~grNPr7LvG1304313043eusmtip1j; Sat, 11 Jul 2020 10:44:54 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:58 +0300 Message-Id: <20200711104414.15422-12-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe1BMcRTH53fv3Xtvq+XaMp3xzMV4jTczx2O8pj/uDH80/jHDkMWVR61m V95mGpS1EjYikdUOZTOTHpQlsjPa2JQ1UpkiMQjVlkVUaLtr/Pc5n3O+vzNz5sfT2lR2KL9F v0M26HUxIqtmbpX/rJ4y4VxQ1HTbmRmYV5lJsPmVjcam040sHvMeprDOvgjvFl9QoeV1AoUp lg4Ki3PMLH5pOshgW2cxhQ2lbg7PPzvIYafzA4fHqzMIfuj5RGO69SvB6sybKvz5wMFie08W gym/agieKKog6EruYPD07RKCSWYBvdeyObQ1jMTOpgoG3fWFHF7/5qHxZmUvwVOuPIJPkv6o Fo+WflmvqCTb3RZKSr3soaXy+jROSn6USUn5bSWU1H6vhpVSiuxEetx8jJZy33WxkepV6gUb 5ZgtO2XDtIXr1Jt9J5u5uPSBu3NzMkgC8QwwkyAehNnw0FHHmoma1wo5BNrsVbRS+Ah02xIo pfhKwON5w/6LvHU85/ysFbIJNL4IVvgbgftZK/3MChPAbcrsD4cK+SwU99RS/kaIsBxOpGXT fmaEcdD44KLKzxphHrhS7bSyYBTk3ijr56A+39v+lFYWjITaS77+R0Go5CHXdJVRAhHwtsTF KRwCn1xFAR4O7tTkwMw++FFQyylhE4FXWYmBoUVQ9Lmqj3meFiZCnmOaopeAz1HWr0EYCHWt g/2a7kPLrbO0ojVgStIq0yKUPXoW0AC93cGKluBMlyVw0FICHYfO0ifJqPP/d1kJsZMwOd4Y Gy0bZ+rlXVONulhjvD566obtsQWk76u6f7t8JcTRs95JBJ6IwRqrjo/SqnQ7jXtinQR4WgzV LH3iXqvVbNTt2SsbtkcZ4mNko5MM4xkxTDMrq2WNVojW7ZC3yXKcbPjXpfigoQnk6pRkX2+i mJ9WMLlt05Caw4zHufV+6zp9S7h67fXvk/ePs444ogbTrOqWFZbV36+gOzL01K7S8QMWjN3q 5QsPiK/r4+ayg7o2RZoLS4/O2RchhkZoxZCKqvIfiQ0vVmfs/Vj+8s6Y1ueLw/IXrlm2tNH7 vmrs05j0x+Hdx73zTeHxGSJj3KybMYk2GHV/AV5f9aymAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3e3mlym5c1IcyFI0Gw+2pmpRfTHpTf2V5bpyItKbpN7 NysrMimT+baQylzmkGxGZlmaWbT9sVVLTMvSUhsWSQ80H5WKVlPrvw/nc76HA+dQuPwnEUCl 640cr9dmKEgp4f7t6l8bekGStK6kgISG5xYEgwNWHDzn+0ko+H4agx7bRmhrviyC8vc5GBSX j2LQXGcm4Zsnl4DhsWYM+h66xXCpK1cMY44hMRR1VCIYmvmCw8XqcQQdlrsimLK3kjAyU0NA 8XQ3gpKmJwhchaMEnL/fgiDPTMP369fEYO0LhDHPEwLcvXfEcONHJw53n88iKHM1IGjP+yPa FMxOV9eKWGvbZ4w9d7UTZ529FWK28KkFYxuHWzB25FE3yRY32RD7bLAAZ+s/TpK7pQnKGN5g MnKr0gyCMVaxTwXhSpUGlOGRGqUqQp0YHR6lCIuLSeEy0rM4PiwuWZk2UToozrzoc6S+rhLl oM7FZiShGDqS+dD6SmxGUkpO1yKmpqhCZEaUVzDM14/4Qo8vM/PaTC70jCPG6nETc4KkQxl3 vgWbE370O5J5efbUvPCltzMlFdfm0wQdwvTbq0RzLKOjGdc527+pQUz9rcfzLPHWZ0dezLOc Tmc6es6gBQ5k3lyZwEqRTzVaZEN+nEnQpeoElVLQ6gSTPlV50KC7jbw3v+ecutOCuhr3OBBN IcUSWbWWSpKLtFnCUZ0DMRSu8JNtbncfkMtStEezOd6QxJsyOMGBorwLluEBSw8avB+kNyap olRq0KjUEeqI9aDwl+XT9v1yOlVr5A5xXCbH/89hlCQgByVHD9gGL8gm/a11E57mRC6bP/li Mvz4zr6iGU2668C6+MYHn7bk7wwePtS+q9XevvVR2Dbn/qCeY36hh33jfm0IjhjqDSFWTIl2 S512vpxd7XI0xK9UZ5UKdK5/9uam4PtZAwnOE3tjE+up+IJn9LKbipQdRFVZ2qY9+cvXvNO8 VRBCmla1BucF7V/2WCdmCQMAAA== X-CMS-MailID: 20200711104456eucas1p18d73e4e8c5def14db58fe74697ea4356 X-Msg-Generator: CA X-RootMTR: 20200711104456eucas1p18d73e4e8c5def14db58fe74697ea4356 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104456eucas1p18d73e4e8c5def14db58fe74697ea4356 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 11/24] examples/ip_pipeline: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ip_pipeline/cli.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index d79699e2e..236553aae 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -249,7 +249,8 @@ print_link_info(struct link *link, char *out, size_t out_size) struct rte_eth_link eth_link; uint16_t mtu; int ret; - + char link_speed_text[16]; + char link_status_text[10]; memset(&stats, 0, sizeof(stats)); rte_eth_stats_get(link->port_id, &stats); @@ -268,18 +269,19 @@ print_link_info(struct link *link, char *out, size_t out_size) } rte_eth_dev_get_mtu(link->port_id, &mtu); - + rte_eth_link_to_str(link_speed_text, 16, "%M", ð_link); + rte_eth_link_to_str(link_status_text, 10, "%S", ð_link); snprintf(out, out_size, "\n" "%s: flags=<%s> mtu %u\n" "\tether %02X:%02X:%02X:%02X:%02X:%02X rxqueues %u txqueues %u\n" - "\tport# %u speed %u Mbps\n" + "\tport# %u speed %s Mbps\n" "\tRX packets %" PRIu64" bytes %" PRIu64"\n" "\tRX errors %" PRIu64" missed %" PRIu64" no-mbuf %" PRIu64"\n" "\tTX packets %" PRIu64" bytes %" PRIu64"\n" "\tTX errors %" PRIu64"\n", link->name, - eth_link.link_status == 0 ? "DOWN" : "UP", + link_status_text, mtu, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], @@ -287,7 +289,7 @@ print_link_info(struct link *link, char *out, size_t out_size) link->n_rxq, link->n_txq, link->port_id, - eth_link.link_speed, + link_speed_text, stats.ipackets, stats.ibytes, stats.ierrors, From patchwork Sat Jul 11 10:43:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73821 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDF9CA0528; Sat, 11 Jul 2020 12:46:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 162281DA63; Sat, 11 Jul 2020 12:45:01 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id C865B1DA5F for ; Sat, 11 Jul 2020 12:44:59 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104459euoutp017469f32e91d18c9421996d05eee0877e~grNUoqbHx0814708147euoutp01X; Sat, 11 Jul 2020 10:44:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200711104459euoutp017469f32e91d18c9421996d05eee0877e~grNUoqbHx0814708147euoutp01X DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464299; bh=bHXcIc3rVA86PY8Cp4TbQNC86tRauFvjduaiZR2Y8o8=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=FQ7KKlyfoT+Azo5Qzrf94Uqb3eTVPu+nqZU269CZhDun18OKmKLRy2SlHi2B7Ikfg lF8D8CL9c6QmnMKGa28bcKqkah85AsHZm8+zNUKCTa3Owj4DAy0NVvy9UWC3dCkVxF 9pfbwUD2oC2/TNiqX9ORzn51K+8HgFsxUxMmq+BI= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200711104459eucas1p101b08cf831f0b7ea39a261e0de4b07ed~grNUXiSfn1558215582eucas1p1n; Sat, 11 Jul 2020 10:44:59 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 56.87.06318.B28990F5; Sat, 11 Jul 2020 11:44:59 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200711104458eucas1p103bc1f711ed17c9007c7ef9afa11738f~grNUCKKDb1567615676eucas1p1k; Sat, 11 Jul 2020 10:44:58 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104458eusmtrp261b6e31a3edc3baf8400164962e92657~grNUBQEZl1628816288eusmtrp2T; Sat, 11 Jul 2020 10:44:58 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-5a-5f09982b97b9 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 1A.86.06017.A28990F5; Sat, 11 Jul 2020 11:44:58 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104457eusmtip12782a9b6748c62da5394920f40265227~grNSQ4EvG0946309463eusmtip11; Sat, 11 Jul 2020 10:44:57 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:43:59 +0300 Message-Id: <20200711104414.15422-13-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSb1AUdRied3dvdzk9207NNymdLh3F8u/14R3HUWtq2pl0xi/2IcdwjQ1I OJ070MgvDGMXHUJ4WRLlcUGXBk4gAXeIMnrTCXQQYNpB/oFhmhBJQORGgbuIdWn69vyeP7/3 mXdekTWf4JeK6bYs1W5TMiy8kWu4Otm59qWShOQN5c6nqLrdAzRwp4Kl/pO3eSoYO8ZQT+U2 uuj/xkDuvlyGitwPGPKfdfH0d38eRyPjfoZuXQoLVHotT6Dx4KBAhZ1fAw3G7rH0lfchUKen 3kCTVy7wNBor56ho6gbQZ3WtQC3HH3B0sjEA5HRJNPbDGYEqbi2j8f5WjsK9Pwl0LtrNUn17 HOhESzVQh3PGsP0FecrrM8gVF4cY+fNvu1n5au+Xgny8zcPI50cCjDzafIOXi+oqQf5loICV q/58zO8yvmPckqJmpB9W7eu37jOmBYs/gUPVxg/jTWVcLnwnukAUUXoFfx5+ywVG0SydBfR3 lLIuSJh9TAA6I1t14SHgwOQUaIIWiMT6eN10BnC6YaduigLGpms4TeCl1RjO9zCasEg6z6M/ FmE0YaG0AyNul6BhTlqJPV0Bg1bDJG3G2mlWH7Acq2ouP8EJs3R8tGuu0TKMlE08+ROldhGH 8ibnAq+j9/RNg44X4r2WOkHHz+FMYxmj46P4qDYi6OF8wDvlH8+ZtmHd8K+CVoKVkrD6wnqd fhULPU2MvqIF2HP/aY1mZ6G74RSr0ybMd5p1twUvt12boxHj0/N1WkZfSQ3o67kEeP3TDrYY lpf+P8sLUAlL1GxHZqrqsNrUI+scSqYj25a67r2DmbUwe6jhf1qiAWiO7Q+CJIJlvsmriMlm g3LYkZMZBBRZyyLTax3hd82mFCXnI9V+MNmenaE6gpAocpYlJmv50F6zlKpkqQdU9ZBq/09l xISluVDl3dOdxBb7d694I/RBYFV9iTUa6Hsm8Uf3m8PP59NI/463/9gSuFlgnVl8bHTTxr/a NudA+oGdzz7e3svfX2nL2bXYuTs0r/GRrzk2lrzpd98prmvQeT3gb1oQ8t1NTBsqO/qbXF8R WtVqZV6e+iLl/WicmVCSCu+Gvn8R12atDqsWzpGmbFzD2h3Kv0ECYC6kAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3cnLW7L3MXstQjCcjYf7Si96MUNE4IiIrM17OZWztXu lKz+sNeqZWZmLwtdTclHZL7S1KIGOXOKjzAtn4gQlU2dGlpabVn/ffmez/nyhXMoXDJG+FLa eCNniFfHyUgvwvHL3h3gf0ekWp02HgJFDVkI+nusOPRldJNwZfg8Bh0FG6Cm4r4A0nuTMUhN H8GgIs9MwmDfWQKcrgoMul44hJDZelYILtsnIVxtuofg09QXHO5aRhE0ZZULYPJ1FQlDUw8J SP3RhuBaWR0Ce8oIARnPKxGYzDQM5z8SgrVrEbj66ghwfCgVwuPxFhzKG6YRXLcXIWg0/RZs XMr+sOQKWGvNZ4y98aAFZ2s/3BKyKW+zMLbYWYmxQy/bSDa1rACx9f1XcLZwYILc6bVPvtag TzBySzR63rhOFqWAILkiDORBIWFyRbAyOjwoVBa4fu0hLk6byBkC1x+Ua2xpF9GxIq8T09XZ RDLKocxIRDF0CNM+1Ut6tITORcy5cj8zotw+w3wdwGeQeczUe7Mb8XIjo4gxT1T/5Ul6BeO4 lIV5Bt50J8m8u3iG8Azm0TuY9nSz0KMJejnT0Vwp8ISK6XCm5Oe/0MVM4dNXf7XIbU8PNeMz HbRMU8cFNKMXMe3ZY1gammNBswqQN5fA62J1fJCcV+v4hPhYeYxeV4LcF39WO1lWiczOXTZE U0g2W2xRUyqJQJ3IJ+lsiKFwmbd4U6PjgER8SJ10kjPoVYaEOI63oVB3v+u47/wYvft/4o0q RahCCWEKZbAyeA3IpOJL9Ov9EjpWbeSOctwxzvB/D6NEvslo5arJfm1N8mapgVZGfNwic+3V lHVL791tqgqEGwsz6mNviq1ou21W5FKfzz7fe6JKH+6Q+lQ3bL0TbdqamtM5uaEWdMYUf7vf nmWWb67W3vC826ebf23b5xScyozavDN/7pFiiNh9eDDg+OWqcue5yGipqWbBk9FQP5Ndlf+m JE5G8Bq1wh838Oo/+kjUPAcDAAA= X-CMS-MailID: 20200711104458eucas1p103bc1f711ed17c9007c7ef9afa11738f X-Msg-Generator: CA X-RootMTR: 20200711104458eucas1p103bc1f711ed17c9007c7ef9afa11738f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104458eucas1p103bc1f711ed17c9007c7ef9afa11738f References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 12/24] examples/ipsec-secgw: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ipsec-secgw/ipsec-secgw.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index f777ce2af..de10dfe0e 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -1775,6 +1775,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1794,14 +1795,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Sat Jul 11 10:44:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73822 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DDACA0528; Sat, 11 Jul 2020 12:46:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C69CB1D9C0; Sat, 11 Jul 2020 12:45:03 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 3EE8C1D983 for ; Sat, 11 Jul 2020 12:45:03 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104503euoutp027df2dac9056ec0584cfca5f73fd1247e~grNX3NCzR1781617816euoutp02a; Sat, 11 Jul 2020 10:45:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104503euoutp027df2dac9056ec0584cfca5f73fd1247e~grNX3NCzR1781617816euoutp02a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464303; bh=iuIgHhL58RT/qRhYxgk8qZcH/dfnsAboJDNEGh69aTU=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Jkiap9wkmx3Bn3AJB10lxdYOUsESR649y+tU7KxCD1kigkIP5fCSVdZjkMB4SS705 kYJDAbTZKgyYszVv34A4lJUHiklKRvUqqH7WQLojwV5lfHqzny/enIGo8h8Hm1bNC0 Va6lnAtERfOE3IPpDYkwfyq7kaBi1ccarA3dt69g= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200711104502eucas1p107b04a7cbc0e57a3a481c80bbbaf900f~grNW_gpbJ1619116191eucas1p1w; Sat, 11 Jul 2020 10:45:02 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id CD.1F.05997.D28990F5; Sat, 11 Jul 2020 11:45:02 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104501eucas1p28c4f82e4a618c20c1e673afebb687468~grNWmHFVr1983519835eucas1p2w; Sat, 11 Jul 2020 10:45:01 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104501eusmtrp263559c1c32625252b5e34464ae8bb7bf~grNWlNhO71628816288eusmtrp2U; Sat, 11 Jul 2020 10:45:01 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-55-5f09982d0ad4 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 17.17.06314.D28990F5; Sat, 11 Jul 2020 11:45:01 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104459eusmtip1f9998416ad0b71653548f813b5343a79~grNUvtUNu1304313043eusmtip1k; Sat, 11 Jul 2020 10:44:59 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:00 +0300 Message-Id: <20200711104414.15422-14-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0yTVxjHfd57Gysv1YQT5rw0mYgJOC8fnhiiDjW+MWoMH52KVV6BSKtp wcFMTEcmwYoo9Y6mFojDIQarLcVOBjYZFwtViAw7nWNmREXHHVFWdC0vxm+/5385zznJEWjt aS5WyDRmyyajPkvHqZnapveBhMQLqtSvS6oprGmzAz5/VkFjz5k/OTw++COFj6vW4F3PZRZt f1koLLYNUei5ZuXwTU8+g/3DHgqf1vt5LO3M53HY94LHEw8uAb4I9dF40TEC+MDuZvH9PS+H A6FyBosnugBPuloAm4uGGDxzpw6wwCri4M+VPFY8nYfDPS0M+oO3eawe66DR3TYJWNJcA9he 8JFdu1CacFxlpYq7ryjpdFkHLTUFz/FSUaudkpz9dZQ08GsXJxW7qkC6//w4LV3/5x23Tb1d nZQmZ2Uekk1LV+9WZzQFGumD98Vc7w/nwQJnNVZQCURcSYLvrGAFtaAVrwEpK+xllGEUyB8W F6sMI0Dyxzu4TxW7b2i6UgnkifMYGzG04hiQE85NEebExcRfaKcioTmikyOeUDcVMWaL60mD 6+VUgRG/In2jFVOsEVeRvxsessqG+eT6zUY6wqqwPjnwkFYWzCPdV0anDiVim0COhUZopbCe 9NX2MwrPJn3NLl7hueTjnSuUwofJ+K1uXikXAnlWfnQ6tIa4XgfCLAi0GE9qvEsV+Rtyozfy fiHMs8jjf6MjMh1GW+15WpE1pLBAq6R1pLG1c1omZPK/mYoskaLiXzjl9vVAAg07TsH80s+r HABVECPnmA3psnm5Uf4u0aw3mHOM6Yl7DxhuQfir+j80j9aBN7THB6IAupkah15I1bL6Q+Y8 gw+IQOvmaJLb/bu0mjR93vey6UCqKSdLNvvgC4HRxWhWlL/aqRXT9dnyflk+KJs+uZSgirWA /TdPtTFubPO3H5LY0v2BqNitPy1J+N3WNW5McbWuPhoyvI1xJMft7K3c4I1LaYmOgosTG5z5 JQknA3Nz14Uyn7yFwbUZ2bOWzRjaWBqvC9YXtbv3qdxlTYY9Se4v+eDrLXtX1CQlHIkaMyxa 2NCY19mS/shy+FLutmR7ry1twcphHWPO0C9bQpvM+v8BZ1pjKaYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRTA/d/XruLiMo1u0nMSROW16yOPZhbVh/sl6ElU2hp206HbYneL XsocZbHMMk1Ta1lmpRY9tDQfmYNmOc1qWYlWJoGl4SuNCtM2pW8/zu+84BwaV/wkAmiNziga dOpkJeVDOCeaPgQFXfBWLS/oCIQ7LTYEPR+LcejO+UDBqaFjGLwvWw11VRdJOPfJjEHmuWEM qm5aKfjebSFgYKQKg656pwwKXltkMGLvlcHptkIEveN9OOQX/UDQZntAwu/GGgoGx68SkPmn HcGZymcImjKGCch5VI0g3crAUOkNGRR3zYOR7mcEODsqZHBr7BUOD1r+IshquoOgNX2SXLNQ +FNUQgrFdd8wIfvKK1xwdOTKhIznNky4N1CNCYOP2ykhs7IMCc09p3Ch/MsvaqPPTi7aoDcZ xQWJesm4SrmLhxCOjwQuJCyS40Mj4qJCwpXBMdF7xWTNAdEQHLOHS3S8eILvb2YO1qTlITM6 L7cib5plwlibfRhZkQ+tYEoQ25n1Frci2i1Ytv8LPp3jx46/tVLTOT8Q22DJwzyCYhazzpM2 zCP8mU6KdZ1IIzzCj1nPNlR+JT1MMIvYvtHiKZYzUeznhpfkdNf5bPndJ1MTvN3xv4Mvp1jB aNi298fRNM9j310exc6iGUXIqwz5iyZJm6CVeE5SayWTLoGL12vvI/fNHzp+V1Sj1/e22BFD I6WvvEhNqxSk+oB0SGtHLI0r/eVrW527FfK96kOHRYNeZTAli5IdhbsXzMIDZsbr3R+kM6r4 cD4CIvmI0IjQFaCcJT/JNMYqmAS1UUwSxf2i4X8dRnsHmJFmaZJ59aKkeOVG14UKLCNrpenX 2DXH9atk/VDtkQXjs5O36fJclllvtBP7KnLjfL16tuZsWBZYGJu/2fdpysMtqetSGD41P70v 5Ywm6NLR82sbr7S7fGondy/M3tGfS0506F3G29ub7tuWl+adjUutnWM+2LOmhUuZu8G4iXOW 97qUhJSo5pfgBkn9DxfU0t0JAwAA X-CMS-MailID: 20200711104501eucas1p28c4f82e4a618c20c1e673afebb687468 X-Msg-Generator: CA X-RootMTR: 20200711104501eucas1p28c4f82e4a618c20c1e673afebb687468 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104501eucas1p28c4f82e4a618c20c1e673afebb687468 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 13/24] examples/kni: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/kni/main.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index f5d12a5b8..679b158d4 100644 --- a/examples/kni/main.c +++ b/examples/kni/main.c @@ -661,6 +661,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status\n"); fflush(stdout); @@ -680,14 +681,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %uMbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ @@ -717,19 +713,15 @@ check_all_ports_link_status(uint32_t port_mask) static void log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link) { + char link_status_text[60]; if (kni == NULL || link == NULL) return; - if (prev == ETH_LINK_DOWN && link->link_status == ETH_LINK_UP) { - RTE_LOG(INFO, APP, "%s NIC Link is Up %d Mbps %s %s.\n", + rte_eth_link_to_str(link_status_text, 60, NULL, link); + if (prev != link->link_status) + RTE_LOG(INFO, APP, "%s NIC %s", rte_kni_get_name(kni), - link->link_speed, - link->link_autoneg ? "(AutoNeg)" : "(Fixed)", - link->link_duplex ? "Full Duplex" : "Half Duplex"); - } else if (prev == ETH_LINK_UP && link->link_status == ETH_LINK_DOWN) { - RTE_LOG(INFO, APP, "%s NIC Link is Down.\n", - rte_kni_get_name(kni)); - } + link_status_text); } /* From patchwork Sat Jul 11 10:44:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73823 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8034AA0528; Sat, 11 Jul 2020 12:46:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00C4B1DA35; Sat, 11 Jul 2020 12:45:07 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5135F1D9E0 for ; Sat, 11 Jul 2020 12:45:06 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104506euoutp01ead8d383e392ae3f296236265f6bc2aa~grNatS-UE0814408144euoutp01f; Sat, 11 Jul 2020 10:45:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200711104506euoutp01ead8d383e392ae3f296236265f6bc2aa~grNatS-UE0814408144euoutp01f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464306; bh=AzTeM//HE10jA1C7ap6zAc35J8f1upFdUWdBJzKIaDA=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=BzNoO/oeSCqoN9ffkOCGXsR+eOoBsHAgjYV9i+MW9m+Ki2X8FgKKpjm3LWGLv73Zy yeO2PoVGH0FeoCpihlTlFYnzvvfE/IgXyN0NzBIodUUhUvsGF188oZq/iy0uouOI7j p81PV0pus6/ds5CyJ2BIpFnVsAC4OrOaiA/DEfNE= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104505eucas1p2140320bb679767dda9a8bb84b50c221d~grNaW0bPr2342023420eucas1p2L; Sat, 11 Jul 2020 10:45:05 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id EF.1F.05997.138990F5; Sat, 11 Jul 2020 11:45:05 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200711104504eucas1p1b40755fcc466660a58782714025acb19~grNZY73Ki0930809308eucas1p1v; Sat, 11 Jul 2020 10:45:04 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104504eusmtrp208ddeb1034b8eed2bcb2b0ed6e6399fe~grNZYE36B1628816288eusmtrp2W; Sat, 11 Jul 2020 10:45:04 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-59-5f099831f72b Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 39.17.06314.038990F5; Sat, 11 Jul 2020 11:45:04 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104502eusmtip1feb656c4c6fb69b4f7ac8ce4c8f8fd89~grNXmTlQH1304313043eusmtip1l; Sat, 11 Jul 2020 10:45:02 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:01 +0300 Message-Id: <20200711104414.15422-15-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa1BMYRjH5z3n7NnTshwbeiYmY13GNbc+PCPjNsycwbh8YTDJ0lFGW+x2 UXyohjSL1GqKlUoNXTCpNrubNCxKtouiqajEGLm2dHEttJ2Mb7/3/3/+z/+dd16OViWzntz+ kDBRF6IJVrMK5mblj7r5i865+S9Mfz4dC2syCL7qyKGxM6WdxZOfj1HYUrACyy3pMjS+iKEw 0fiFQkuegcWPnXEMdvdYKGy77ZCjqTFOjj32Ljmerr9AsGvgPY3ns3oJ1meUyvDH3TIWnQPZ DCb+bCJ4xvyQYNWpLwym2KwE4w08fs7PlWNOmxf2dD5k0NFaIsdr/Q00ltYMEkyuKiRYG/9H tnKq8DPrskzIKX9HCWcvNdBCZWuqXDhVnUEJRd1WSnBWNLFCormACI9enaSFq6+/s5sVOxTL AsTg/RGibsHy3YqgjqcrDyYrDt/r6qBiSDxnIG4c8D7wpNLCGoiCU/F5BIoaqlmXoeL7CFgL 9kjcS8CWF/ovUP/ryUggl0B3Sj6RDv0EHNYztGuK5WeBIyGDchnj+SIWLAPNlMtw5zeA05nP uJjhZ0DcA/twnZJfCvcsZ+VSxRS4euPO8CK3IX3Q+ZiWruEFzZl9w0uBr+HA0nSLSIE1YHL0 0RK7w/sq88iiyfDHlklJfAS+FTfLpXACgY7s4yNDK8D8oW6IOY7mZ0Nh2QJJXgXlmQbGJQM/ Blo+jXPJ9BAab6bRkqyEhHiVNK2GO9WNIzLA4K/REgqQl7pOep7bBI431LBJZIrpf1UWIQXE QwzXawNF/eIQMdJbr9Hqw0MCvfeGaovJ0Ed1/K7qs5KygT12wnNEPVqZpeH8VTJNhD5KayfA 0erxytW1jl0qZYAmKlrUhfrrwoNFvZ1M4hi1h3JJ9js/FR+oCRMPiOJBUffPpTg3zxiys+LA triU2NzofnN0+cUxVqN6pp/Z46Xok7rLFu3xssT3ROSo5Z74Jrbk7fqP466IRyPrlI102Fd+ U5J2i3fb3K/7nNVek2u70p5tN97f6p4UW5rLmZJ8g3yKr/dObKuLiijq2TjLr3naWptv8qN5 h9LS/TsN2Qq72Wds+6jWCRNMakYfpFk0h9bpNX8BNNHzZqQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSaUwTYRCG/Xa32y2xZlOLfiERoVHjWV0OOxhU5NeaqDFqYuKFG9wAkbam 2xrxh1YiSCqiHDGiBqtIUFAREYsGEOqBWpFDQYyACAQUlVI8kUML6L8387zvzCQzDKn6Tvkx cQazaDII8Rrah3KN1bQtWXZGEbUsu2sOFD3PQdDZnktCR1YbDccHjhLQUrAayh3nZZDxzkpA WoaHAMcVGw2fOxIp6B90ENBa4ZLD2cZEOQw6e+Vwou4cgt6RPhKy7V8R1OWUymCo+h4N7pFL FKT9bkJw8vYTBDWpHgqy7pYhSLaxMHA1Xw65rf4w2PGEAtebEjlc+95AQunzUQTpNUUIapP/ yCIC+d/2PBmfW/6R4DMvNpD84zen5Xzq0xyCL+4vI3h3ZRPNp90uQPyzzuMkX9j9i97os00b bjJazGJArFEyr9Rs5yBIy4WBNigkTMsF63auCArVLF0VvkeMj9svmpau2q2NbX8VsS/d58CD 3nbCipIZG1IwmA3BdcMvaRvyYVRsHsJPv1SRNsR4AcafuslJz3Q80mz75/mK8JVKKz0OaHY+ dqXkEONAzb6l8ctjR6hxMJ1dh93uqxOaYufixEfOiYCSXYEfODLlk11n48KbVRMTFN76qLt+ QqvYOFzXkoQmtT9+feEbcQpNs6MpBUgtWiR9jF7itJKglyyGGG20UX8LeU9+5/FQSRlqLN7s RCyDNFOVdoGJUsmE/VKC3okwQ2rUysha1y6Vco+QcFA0GaNMlnhRcqJQ74LppJ9vtNH7QAZz FBfK6SCM0wXrgpeDZqYyha3eoWJjBLO4VxT3iab/OYJR+FmRr0a58M6seYcWRYxV3xCaHeZU d1fSecNDtaupNmlB7trM4W2Xda/L62O2PsyeV/uioi9grv+a6xua3s9EjdmBbw/0zPCdKmT8 CMvLONpmSV98uGiautRgqJkVDc0e+RZPT+R8bLV/aR4p4SrXa12ju9p+5r/alD/0oficJ3mg X3FfQ0mxAreQNEnCX5AvigUIAwAA X-CMS-MailID: 20200711104504eucas1p1b40755fcc466660a58782714025acb19 X-Msg-Generator: CA X-RootMTR: 20200711104504eucas1p1b40755fcc466660a58782714025acb19 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104504eucas1p1b40755fcc466660a58782714025acb19 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 14/24] examples/l2fwd-crypt: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-crypto/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 827da9b3e..cdb4f18ab 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -1734,6 +1734,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1753,14 +1754,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Sat Jul 11 10:44:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73824 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02098A0528; Sat, 11 Jul 2020 12:46:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E4691DA89; Sat, 11 Jul 2020 12:45:11 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 9171B1DA9D for ; Sat, 11 Jul 2020 12:45:09 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104509euoutp02b5cb46679cd266700d1531cf06e32c31~grNdwxabk1781817818euoutp02c; Sat, 11 Jul 2020 10:45:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104509euoutp02b5cb46679cd266700d1531cf06e32c31~grNdwxabk1781817818euoutp02c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464309; bh=Gx8oDJpmTpjVn5IyghjT1J24+AE+Pf8nC0ZYfcG7HWE=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=I3Egj1EPfAlrn+c9qFbNyXT8xsC9Zth/W26T3XKjM+Ip53l9+KBFPpCM1/mXnbBxH fQ3Zj/GIP7RBtKCr02b/2MJcImZ/Hajev+YArdjGvnPYzewP+YZpTgALMwghx+GzwF iItYWrPzBM3GsswLc3uPVjC31tJakfr8WTh5wVq4= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200711104508eucas1p1dbb29f1e7f0671d585879b7f16415de9~grNc5RRCO1645216452eucas1p1z; Sat, 11 Jul 2020 10:45:08 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 67.55.06456.438990F5; Sat, 11 Jul 2020 11:45:08 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104507eucas1p2568514a4d979f3ac2a9a6d36c3d7fca6~grNb9OZXE1737917379eucas1p2K; Sat, 11 Jul 2020 10:45:07 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104507eusmtrp1fff37a7b3654728757646c2bb7aab95f~grNb8G-t82954729547eusmtrp18; Sat, 11 Jul 2020 10:45:07 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-47-5f0998342593 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 5C.86.06017.338990F5; Sat, 11 Jul 2020 11:45:07 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104505eusmtip17d0fcd5a4f1a89117ac87ed0c6dc390b~grNaMSvbs0946309463eusmtip13; Sat, 11 Jul 2020 10:45:05 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:02 +0300 Message-Id: <20200711104414.15422-16-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSfUyMcRzf73mee57nTteeLuY3L5nbMmxKw/ZlJi/NniWbTZsY8uBZXrqr 3SlvQxqnnbr0IlTOqSgxJdWlVbg/HK5EXgpJEikUvcxLV9zdk/nv8/18P5/v57vvviypSqMn sTu1e0SdVohW0wqq8t6vxjnzz8oj53aW+UJJvRlBR1s+Ce2Zb2g4+e0YAS3FwVBjzZVB+tsE Akzp3wmwFhlp+NKeSEFvv5WA1loHA9lNiQz027oYSGnMQdDl7CHhnGUAQaO5Qga/7lbT0OfM o8D0+zmC1PL7COzJ3ynIvFWFwGDk4NuVQgbyW/2gv/0+BY6XNxm4NvSEhIr6EQRp9hIEDYY/ sqXT+d+WSzI+v6ab4DMuPiH5ey+zGD75gZngb/RWEXxf3XOaN5UXI/5hx0mSv9r5k16j2KBY vF2M3hkv6gKXbFHsqEvpk8XmKfZVnohNQKdZI2JZzM3HxlyFESlYFVeE8JXXCYRUDCJc+s7G SMUAwhX2AVdH7nHUNN2WSY1ChOs+XENSMYRwT6mBdKtobiZ2JJk9s8ZzN2hsdTYT7kBfLgxf +rzXraE4f3ziYwFyYyW3CF/MfjqWMA1fLb3jmSN38SN9jz1Yxfnh5guDnpmYe8zi4dFntGQI wZbuo2NmX9xjL2ckPAU7MpIpCR/EP8qaGcmchHBb3vExUTAu//yIcS9HcrNwSXWgRC/Dju5U WjqSN2756uOmSRdMrzxDSrQSJxlUklqN7zxoGqMxHhn2kmget1UUEtL2ta5bFficQtOy/0dZ ECpGE8U4vSZK1Adpxb0BekGjj9NGBWyL0ZQh16M6Ru39VWioaasNcSxSeyktAhupkgnx+v0a G8IsqR6vXN7g2KxSbhf2HxB1MZG6uGhRb0OTWUo9UTkvr3uTiosS9oi7RTFW1P3rEqx8UgIK dX7q7QgLjD3klVrp/6I2ea38SGN816h1YUjip11l76rCZTHCV+3qzo+LbKuYqZzFYDJXTw3P 3bhihibOsbRgZU/XrMMBrxe8t4SODNZPCNqs3fgqVH09cX3ElJL0iFa/671ZT3OKHl32Wdw8 nOI8uM6f81bUhCyZ0XA+uCUAmcbtVlP6HULQbFKnF/4CioaeeKQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSbUhTcRTG+997d3cnrW7T9J/S28KIpOmc5lHUIijuh6LIPvVmoy7Ocs52 Z2oRmGTaTMta0euampkvvWpqYS+OynIOU7OUNMWkkYbTWVFi2ab07cd5nuecA+cwpOw75c8k Jht4fbI6SU57Uba/Tb2rVBcl8SF9HX5wt8WMYOBTCQn9pl4a8kaPE9BVsQYa6q6K4GxfJgEF Z8cIqLtlpOFbfxYFI646Anqe2MRwuT1LDC6rQwz5rVcQOCaHSLhkGUfQan4ogt+Nj2lwThZT UDDRieB0zWsETafGKDA9qkdwwsjCaHmZGEp6FoGr/zUFtu5qMVT9aCPhYcsfBIVNdxHYT0yJ 1i7lJiylIq6k4SvBnStqI7lX3RfE3Kk3ZoK7P1JPcM6nnTRXUFOBuOaBPJKrHPxFb/HarojW 61IN/BKNTjDEyHcoIVShjARFaFikQqmK2BUVGi4Pjo3exyclHuL1wbF7FJqn+U5RSrFXem1O SiY6zxiRhMFsGG5ofyYyIi9GxpYi7Oq6KDYixi1gPDxIzni88eR7Iz3jGUfY3l4r9gg0uwLb cs2ER/BhP9K4I+cY5Ql7sxtx6XCax0OxgTjnyw3kYSkbhYsudxAzTRfjynvPpwdI3PU/zrfT LGMTcWtXNprhRfjD9e/EGTTHgmZVIB8+VdAmaIVQhaDWCqnJCYq9Ou0D5L547avfNfXIOBJn RSyD5LOlFjUTLxOpDwkZWivCDCn3ka6z23bLpPvUGYd5vS5en5rEC1YU7l6wkPSfv1fn/p9k Q7wyXBkBkcoIVYRqNcj9pLls404Zm6A28Ad4PoXX/88RjMQ/E6k0Ww//5EzNjdvtFR1pvsO7 bxdnH+WYOTHL5QtXaLpv7z9iD/JzzvWNKRqaWpKeZR4adwRl44P5L8IW/PXetmBZ8GjiHdu3 oMLPIdIpCxdXFbBppK8sYMwhsS5uuXUt45PDJ2n9LFH1hc1d80yt500byt+d3P/s10tXXHVg TlvcTZOcEjRq5UpSL6j/AapPWMkHAwAA X-CMS-MailID: 20200711104507eucas1p2568514a4d979f3ac2a9a6d36c3d7fca6 X-Msg-Generator: CA X-RootMTR: 20200711104507eucas1p2568514a4d979f3ac2a9a6d36c3d7fca6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104507eucas1p2568514a4d979f3ac2a9a6d36c3d7fca6 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 15/24] examples/l2fwd-event: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-event/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c index 4fe500333..3849aaae0 100644 --- a/examples/l2fwd-event/main.c +++ b/examples/l2fwd-event/main.c @@ -366,6 +366,7 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status..."); fflush(stdout); @@ -389,14 +390,9 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - port_id, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", port_id); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", port_id, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Sat Jul 11 10:44:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73825 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD5FFA0528; Sat, 11 Jul 2020 12:46:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C66E51D9FD; Sat, 11 Jul 2020 12:45:13 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 102DD1DA83 for ; Sat, 11 Jul 2020 12:45:11 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104510euoutp011825ef45b2f44a59f611635bbfc6b89c~grNfITgyl0814708147euoutp01Y; Sat, 11 Jul 2020 10:45:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200711104510euoutp011825ef45b2f44a59f611635bbfc6b89c~grNfITgyl0814708147euoutp01Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464310; bh=UBIKSjvQGKvUwJ35oNwL6cz5h7c0u2Igh3CSm1TgPKQ=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=dFencHZb1m1TFhRjx5D6OlKfuRtvR0mywiX0jm7ZyICBdODiWN3ov5D0HDNIMNXud xqcBqOrMbHlv0Gpic+ZaVPsnlWbwc9w35TbESBw88nGODfWMTsngvLvi6i8SCwd0bc FhOjRQCE23eqsyf37X5C/i48PO0WbNt9TMvxxPzU= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200711104510eucas1p1f0cd7a19324377a8822a504f0aa41e81~grNe9e-ju1558215582eucas1p1s; Sat, 11 Jul 2020 10:45:10 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 02.2F.05997.638990F5; Sat, 11 Jul 2020 11:45:10 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104510eucas1p2f4e199a03e2b85311b65c1e1148c9967~grNehIGuA2336423364eucas1p2U; Sat, 11 Jul 2020 10:45:10 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104510eusmtrp2e29c6a55a80b00e0c0f8d093de9d1dd5~grNegIem41628816288eusmtrp2X; Sat, 11 Jul 2020 10:45:10 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-5f-5f0998361725 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 5B.17.06314.638990F5; Sat, 11 Jul 2020 11:45:10 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104508eusmtip106a1609fe51174175f86cf802556a478~grNcvbCXw1304313043eusmtip1m; Sat, 11 Jul 2020 10:45:08 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:03 +0300 Message-Id: <20200711104414.15422-17-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUwTdxjH89xd766VbrdS5QkacF2MolERjfmNzKmbLrdkU7NlWWKmeOoF yXgxrVWcf9gQZQy6biKbExUQ1DJYgmKhwGCRJlKlgKsRkcib+EJEAXnLBFtYy0H87/t8vs/r Lz+e1p1mw/mE5EOyMVlKNLAaprJhomXl+j/UcdGVliWkrCkPSG9XEU16cjpZkvXqBEUelGwk tc7zKpLdbaGILXuYIs7iTJa87EljyOCIkyIddR6O5N5N48iIq48jP985B6TP10+TswWjQO7k VajIRH0NS4Z8hQyxTbYC+cVxC4jbOsyQnOoqIOmZAnn1p50jRR0RZKTnFkM87dc58te4lyYV TX4gp9xlQJrTp1Wb3hcnCy6rxKLa55R4+qKXFhvaf+dE6+08Srw2WEWJQ/+0sqLNUQJiY28W LZY+ec3u0OzUfLRfTkw4LBtXf7xHc2CsvZg72K9O9VqraAt0c5mg5lFYh1OdExDUOqEY8Dfb zkzQBPQY4LObJ0EJRgHP+QdVcxWjdfmMYtgBn9jdrBKMAzqyLtHBLFZYhp6MPCpo6IVrLDp9 bVTQCBU+w87HVwKteJ4RluBF//Eg1gqx2FrUxyoTIrH06o2ZPuoA9w/9Syv7RWBb/thMTxSa eKw43whKwRZMG8+nFB2K/W7H7HGLcLp6jh/D/8rbOKU4A7Cr8ORs0kZ0vGjhggvRQhSW1axW 8GZ8edM+g1F4Bx8MvBfEdEBmV56hFazFjHSdkm3AG7fvzmJE/5sQBYt4Zto3+1Z1gE//9jK/ QmTu21kFACUQJptNSfGyKSZZPrLKJCWZzMnxq/alJJVD4Kt6ptxjVVDj2+sCgQdDiLZA4uN0 Kumw6WiSC5CnDXrtJ82e3TrtfunoD7IxJc5oTpRNLljIM4Yw7drC57t0Qrx0SP5elg/KxjmX 4tXhFpC8+thU0VK7NrTnCIZH54Y81X33weNvIx0RX61wLe2YdD58MzHcIMVHmq2fr6lfMCBG pRROlTzatli2Ru/uPdsy1by+evvCnKuf3vvSd3nTT19882HYYP2z1BPWr+0xtqiM7B8T9BvK t0Fs6VJzNzYu13cNbI1JaL5/f96iC/OXPbrwroExHZDWLKeNJul/a/5M46YDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTcRDG+e9ud7fE6qZU2RDj0WhiUIvL0Q5ECzEeGw2JCT554QobQCkl 3UI8HkSjSMqhYGO8UqsNyqEgXkVFEDxQKynFgCBnECWiAeRIxIDaQnybfL9vvplkhsaVk0QQ nZJmFk1pQqqa9Cdcfxq712ovyuPX1RdQUPnehqC/x4FDn7WbhNzRUxi0l0VDjfOqDIp6szAo KPqJgbPEQsKPvpMEDI85Meh65qLgcstJCsYaBinId19BMDg9hMMl+zgCt+2hDKbqn5AwMn2D gILfrQjOPniDoDHvJwHWx9UIsi0MjJbeosDRtQTG+t4Q4Oq4T8HtSQ8OD9/PIChsrETQlP1X FrOc/20vlvGOmm8Yf/66B+dfd1yg+Ly3NoyvGq7G+JHaVpIveFCG+Hf9uThfPvCL3OG/S7Pe ZMwwi8uSjZJ5g3o3B6EaLhI0oeGRGi5MtzcqNEIdol+fKKamZIqmEP1+TfJERwmVPiQ/7Mmr xrNQL2VBcpplwtnxZ9cIC/KnlUwxYot+NJEWRHsBy34fwOc8Aex0m4Wc84wj1jU0iXyAZFax rhwb5gMqppNkP5w5QfhAALOF7f58U+YLIpiV7PWZ4z5ZwUSxrY5Bci50KVt+9/nsALlXnxlp nq2VTArrbj+N5uol7MdrE9g5NN+O/MqQSsyQDEkGidNIgkHKSEvSJBgN95D35I9eT92vRi1V cQ2IoZF6nsIu0PFKmZApHTE0IJbG1SrFxibXPqUiUThyVDQZ400ZqaLUgCK8+xXiQQsTjN4H SjPHcxGcDiI5XZguTAvqQEUOU79HySQJZvGQKKaLpv99GC0PykKbLNtH/KJtEx5n6eXmqAN3 JsaeZqOda5t1QpwVP/Ypzl0TUWotitmmx75W6CcD3o07Iq05wXXtqpcHY7k1XGVFp0JbGLN5 R0dicnntoi+rne4e7ZMV9oWx+Zj9lf+Lq5aSrTfsyorBvrYFprbbj/cF9sv0mJ+qcvE625Rn uk6rJqRkgQvGTZLwD8sTTYsIAwAA X-CMS-MailID: 20200711104510eucas1p2f4e199a03e2b85311b65c1e1148c9967 X-Msg-Generator: CA X-RootMTR: 20200711104510eucas1p2f4e199a03e2b85311b65c1e1148c9967 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104510eucas1p2f4e199a03e2b85311b65c1e1148c9967 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 16/24] examples/l2fwd: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index e04c601b5..dd9ca43a0 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -571,6 +571,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -594,14 +595,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Sat Jul 11 10:44:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73826 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B316A0528; Sat, 11 Jul 2020 12:47:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E97771DABA; Sat, 11 Jul 2020 12:45:15 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 662851DA46 for ; Sat, 11 Jul 2020 12:45:14 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104514euoutp0210648ee3f97d08f4113c96ca63acbb58~grNiQPbz72273222732euoutp02t; Sat, 11 Jul 2020 10:45:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104514euoutp0210648ee3f97d08f4113c96ca63acbb58~grNiQPbz72273222732euoutp02t DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464314; bh=Mxm/6/TLoP3KY0eoO9SPi3kD8IBKHT08Z4Gze2Q8+Z4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=soZbaqUm+jixEXGpdFXO4Rt+WpuYvvisfWw+gl4wTNtvuix3KHincaexsKs8wfIvL +nGfAxTXCKEWcH2h9CTR1TSnczI9Wagj3XP5oevftIZzgUqF2ZnnUVHUdKj3JsUjCA 7lwMqi02vgtgyNoy5Bv8xp5yp0kzQXmxWn1D0/VQ= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104513eucas1p23003f59d3b9505bdf674e361e1dfb0f4~grNh7lHF62332923329eucas1p2X; Sat, 11 Jul 2020 10:45:13 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 7A.55.06456.938990F5; Sat, 11 Jul 2020 11:45:13 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200711104513eucas1p1d73b9bc2ecf1c7bd3a3bc07bf85fcc2c~grNhc7adG1559215592eucas1p1s; Sat, 11 Jul 2020 10:45:13 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104513eusmtrp171e5d3e70e9910c33f504e39a7f29735~grNhcGZdO2954729547eusmtrp1_; Sat, 11 Jul 2020 10:45:13 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-4f-5f099839a961 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 9E.86.06017.938990F5; Sat, 11 Jul 2020 11:45:13 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104511eusmtip173c3fea1215b6c4083908fa68853e328~grNfjFDcy0946309463eusmtip15; Sat, 11 Jul 2020 10:45:11 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:04 +0300 Message-Id: <20200711104414.15422-18-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSb0xTZxTGc+69vfe2oeZa2TxRA7FOoyaK6JacmUU344f7wWQu24dJ4vAq N+gGFVsQYYlBpAQLogMy+aO1QkSHGhSxRcXNVSNicSgLQYN2BK0ok3/FuhXBjXIxfnvO75zn vO/z5hVZUxk/R9xhSVetFiXFzBs4961w+7JPy/WJK54djKP6NidQr7+GpZ6yxzwVDucx9KBu LTV7juqo5K8chopLRhjynHbw9LInl6PBoIehR9d8AlV25AoU9PYJdLC9CqhvvJ+lCtcoULvz ko7Cv1/haWi8mqPisU6gQ423gVqKRjgqu9wElO+QaPiXUwLVPIqhYM9tjnwPLwp0NnSfpUtt E0A/tdQD3c3/T/f5fHnMdVIn1zS/YOTSE/dZ+dbDnwW5qNXJyBcGmxh56NdOXi5urAP5Tm8h K595+i+/0ZBg+CxJTdmxW7XGrdli2N4c6ufSag17AuO5XA4MCg7Qiyh9jG8vd/EOMIgm6TTg 0YqXgla8AvTt+xO0YhTw2ehxnQPEKcsRP6fxU4DHRvJYrQgB1rde5SJ7eWkx+gqcTKQRLV3g 0TPexUQas6QNWFhdoItoTlqI/d1eiGijtBo9524y2qVi8cz562xE6yf5xNC9KW2SYrDr+Kup pSi1iTgwFgLNsB7vud6ZZ2F/S+N0unnoKy3iNP0j/tPQJWjmAkB/tX16aC02/v2HEMnGSkuw /kqchr/A1/YJQYs8Ax8MzIxgdlKWuI+wGjZiQb5Jmzbj9daOaYw48SZKwzLu9w5Pv881wNJ9 fuEwxFa+P8sFUAez1QxbarJqi7eomcttSqotw5K8fNvO1AaY/Ku+ty3BJgh1bPWCJII5yuhS xESTTtlty0r1AoqsOdq47q7vO5MxScnKVq07E60ZKarNC3NFzjzbuKr6xWaTlKykqz+oappq fddlRP2cHLAnx+bHeb76CDdmuQfCVbW/fZBQ++H8Td192XO7Zwbd7JqAEjrAJjBS4Pukhbu4 8mPpHD7v3dJgP/dJrPXQKrvsvmFOW51nyVwc3hsfcCYtCNDSRXu+hK8vngy3hdozsjfoe5/E RENMpl//7crOBVGqZUbFN48L562rrMKOw+VmzrZdiV/KWm3K/8RrxIynAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSe0hTcRjtd+/d3Z01uUyjHxKm64EYXtvU/Ax7EES3CAqifyyzpReVnLPd LTIETcpkU0vTHhZqqT00sUydlYmO8NGyZWIpWkm5Ih/z0Vs0m0r/Hc453/kOfB9DKr5TXkx8 okHQJ2oSlLQbZfvb9i4g7IosasPsuDtUvyhC8PF9KQmD+e9oME+cIaC3Yis0Wq5LIO9DGgE5 eZMEWO6YaBgdTKfAOWUhYOCpTQqFr9OlMGX9IoVs+zUEX2aGSbha8g2BvahOAn9aHtMwPnOT gpzpHgTna9sRtGVNUpD/qAFBhomFibu3pVA64A1Tg+0U2PoeSuHejy4S6l7MIshtq0bQmTEn 2ebLT5eUS/jSxq8Ef/FGF8m39l2S8lkdRQT/wNlA8ONNPTSfU1uB+OcfzSRfOfSb3ucWwYXr dUaD4BOnEw2blQdVoOZUYcCpg8M4VVBo5CZ1iDJwS3iMkBB/QtAHbjnCxTX+GKaSbrmddMyk U2nIKTUhhsFsML78njIhGaNgyxGuHFm9SGM8MkTO05j1wDNvTLQJubks3xBuGBuTzAs064dt mUXEvODJ9tO4+9zphSAPdg8238xcMFHsWjzcb0XzWM5uwpaqZ8Ri6ipceb95YYPMxc+OvyIX S8Rje+9ZtIi98dvi78QF5F6CllQgT8EoamO1opoTNVrRmBjLReu0Nch18frWP7UNyOTcb0Us g5TL5CUaJkoh0ZwQk7VWhBlS6Snf3mk7rJDHaJJPCXpdlN6YIIhWFOIqmEt6LY/Wuf4n0RCl ClGFQpgqNCg0aCMoV8gz2ZZDCjZWYxCOCUKSoP8/RzAyrzRk2Xk+Y+nntKyXn3Z5tHMOxn66 avZ50v7pUcqwzrfTufKzw9w0V9/CGzv8uJqy5l91u8oii/t/2Y8XOsonL8j8hrvX+KSs3Z0a cGloovfnDRxuQZbIA+r8vausBWMRjs0pnvHeioLAbH9INWcedW8y9AbuKExNqU15krzeOV0D SkqM06j8Sb2o+QerKjv1BwMAAA== X-CMS-MailID: 20200711104513eucas1p1d73b9bc2ecf1c7bd3a3bc07bf85fcc2c X-Msg-Generator: CA X-RootMTR: 20200711104513eucas1p1d73b9bc2ecf1c7bd3a3bc07bf85fcc2c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104513eucas1p1d73b9bc2ecf1c7bd3a3bc07bf85fcc2c References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 17/24] examples/l3fwd-graph: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-graph/main.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index c70270c4d..8af835e15 100644 --- a/examples/l3fwd-graph/main.c +++ b/examples/l3fwd-graph/main.c @@ -599,6 +599,7 @@ check_all_ports_link_status(uint32_t port_mask) struct rte_eth_link link; uint16_t portid; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -623,16 +624,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* Print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port%d Link Up. Speed %u Mbps " - "-%s\n", - portid, link.link_speed, - (link.link_duplex == - ETH_LINK_FULL_DUPLEX) - ? ("full-duplex") - : ("half-duplex\n")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* Clear all_ports_up flag if any link down */ From patchwork Sat Jul 11 10:44:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73827 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 111C7A0528; Sat, 11 Jul 2020 12:47:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21A0A1D99B; Sat, 11 Jul 2020 12:45:19 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1AC5B1DACF for ; Sat, 11 Jul 2020 12:45:18 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104517euoutp02c22e1c1b07928325f4c90845285c8c49~grNlsUtSm1781617816euoutp02b; Sat, 11 Jul 2020 10:45:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104517euoutp02c22e1c1b07928325f4c90845285c8c49~grNlsUtSm1781617816euoutp02b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464317; bh=/4ZIDTeAEPqhZ60Bn9trDwy5rli/mlDUelJbUnJtmzU=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=rFVsey+c1rmGS1soTx1MgEVxsOl9f8sOhSEEsmCaOOy1z9nx4bLj8UNfwgQOO8uhA a0Rk2aXM9yaGZKMMRKSMg8UsrgnbcP1GZxfAKYjQZKGmn4lN25QCwBJ9zfKB5LYqiN abiwxtwpvZ3ayVmaWyDjm3iOpGlBM+5PcW+GpFd4= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200711104516eucas1p17d022483e1dabdd7097311c330ee8df0~grNkrCdhr1599415994eucas1p1j; Sat, 11 Jul 2020 10:45:16 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id B8.87.06318.C38990F5; Sat, 11 Jul 2020 11:45:16 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104516eucas1p2265716f503d39b240109e4957b5ca8bd~grNj9z9-y2341523415eucas1p2N; Sat, 11 Jul 2020 10:45:16 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104516eusmtrp172293f9d4b0ef13b939063d5b373b1b2~grNj8-Ei-2954729547eusmtrp1A; Sat, 11 Jul 2020 10:45:16 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-6e-5f09983cbdc2 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D0.96.06017.B38990F5; Sat, 11 Jul 2020 11:45:15 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104514eusmtip15cfa882940c9001127873694df6570a7~grNiNViN31304313043eusmtip1o; Sat, 11 Jul 2020 10:45:14 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:05 +0300 Message-Id: <20200711104414.15422-19-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0wUZxSGc2ZmZ4aNa6aDiadapW7TRE28X3ogxlvaOrX9YYyXRGxxkQka AckuqNRUCVFCkaIFQivYlbIx3DSAgCABxA264CIsayl4W8mGxCIq96p00bIMxn/Ped/znnPy 5RNZOZOfIx6MiVPNMaYoI6/nrt1+075k3e8BYctvNC2i0lYrkNdjY6kn6zFPZwZPMdRdvIHq qi/oKONJIkPpGUMMVRem8vS8J4mjl8PVDD2qdwqU404SaNj+VKBf2nOBnvqesXQ+bwSo3Vql ozc3a3ka8OVzlD7eCXS2shnIkTbEUdb1GqDkVIkGiwoEsj2aT8M9zRw571cIdHmsg6Wq1gmg Xx2lQHeT3+k2LlDG8y7pFFtdH6Nk/tnBKrfvZwtKWouVUcpf1jDKQEMnr6RXFoNyx3uGVUp6 X/Pb9Hv06yLUqINHVPOy9fv0B8bLr0Bsjv5YmqeeSYSfxVQIEFFajVV/eNhU0IuyVAh4r/Uh aMUoYP9fhTqtGAH05juZ95Fe9x1BMwoA+6wjnFaMAWYXPwF/Fy8tRGeKlfEbs6RyHqt9XVPx QOk7bBvzJ0SRkz7He65wv2yQQrBq8IJO2xCEJWWNrJ8DJvWJAdcUy9J87Lo4OjUTJZeI2f8W CVrgS7R3PgCNA/GZo3Ja/wSdmWmcxsfx1dUuQQunAHryT083bcDK/jbBfxArLcLS2mV+RGkT +twhGs7E7hcf+ZvZScy49huryQZMSZa1GUZsbHFPy4gT/83QZAXrSx5Ov2494LmyFOYcBOV8 WJUHUAyz1XhLdKRqWRWjHl1qMUVb4mMil+4/HH0VJr+q861jrAYafOF2kEQwzjDkmcQwWWc6 YkmItgOKrHGWYfNd5w+yIcKU8KNqPhxmjo9SLXaYK3LG2YZV+X3fy1KkKU49pKqxqvm9y4gB cxLBtnLn/uNrsW5rcFtDcO7avZHeLzZ/1di0JfTWuxNfP9jlODV3W9ZJmtjSHejYLvy9o2Nj wnbXvq1xg0tW2G+9tle45W+GHJ+N214Ft75oKut39R7bHXrRe97z7dsic2yQsjB+gftsxMcJ Lc3/5BrX5MwL6ar4CZJqn4cPfLoydI2MBaNGznLAtGIxa7aY/gelqgwppgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSaUwTYRCG/Xa3uwuxZlMwfsHEo2pCjFa3iAyKd6L7Q4xK1FTRWmWlBEpJ tyVqTESiqCvWC40CqVWCCigIclRBI/wAtWjxQCFepGLwCkcRFQJqK/Hf5H3eeWeSGZZUDVBh bFKqVbSkGlLUdDDl/t30dvbC80H6ufW1MVDW7EDgfVdAQkfOWxqO9R4koK14CdTV5Cvg9PsM Auyn+wiouSbT8K0jk4JuXw0Bb+66Gch9lsmAr6GLgeOePARdw19IuODsR+BxVClgsP4ODT3D lymwD7UiOFH5AEFTdh8FObddCLJkDnqLrjJQ8GYS+DoeUOBuv8XA9YGnJFQ1jyA41VSG4HHW H8XSqcKQs1AhFNR9JoQzl56SQmP7OUbIfugghPJuFyH03GulBXtlMRIeeY+RQknnL3pt8GZN jMVss4pTjGbJuki9hQetho8GjXZetIaPiNq6QBupnrM4JkFMSUoXLXMWb9cYh8pvoLTc4N3Z 7+4SGegoK6MgFnPzcOezR4yMglkVV4hwbbWdlhHrBxh/7SRHPSF4+KVMj3r6EW7M6lYEAM2F Y/cRBxEAodxrGj8/fIAKgBBuNX4y0E8FgihuBn7esiMgK7kFuKo3XzEaOhmX3Lz/b0CQXx/p aflXq7gk7Gk7hEbrSfjVxe/ESTTOicYUo1DRJpkSTZJWIxlMki01UbPTbKpA/pNXNw5WupDc HdeAOBapxyqdBlavUhjSpT2mBoRZUh2qXP7YvU2lTDDs2StazHqLLUWUGlCkf79TZNj4nWb/ A6Va9XwkHwXRfFREVMR8UE9QHuHq41VcosEqJotimmj530ewQWEZ6OxIWUqIduPKCt16XP/j p03a8JvZP7/U8zoxr2W7fDPJ4dWbeOeVDCtjfIKyu2Y1pS2rSA7f3F7t0r03rupfVDNoF53N ayYqvLHTXGr6Q2bamfgZsft2ffmYrCuVI8I//UjuK+1bVyR5fUQcn2DRlH3w7Huxybdmuq5z xdT0hWpKMhr4maRFMvwFMp+vtQgDAAA= X-CMS-MailID: 20200711104516eucas1p2265716f503d39b240109e4957b5ca8bd X-Msg-Generator: CA X-RootMTR: 20200711104516eucas1p2265716f503d39b240109e4957b5ca8bd X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104516eucas1p2265716f503d39b240109e4957b5ca8bd References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 18/24] examples/l3fwd-power: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-power/main.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 9db94ce04..f5bf0a92d 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1945,6 +1945,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1964,15 +1965,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint8_t)portid, - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Sat Jul 11 10:44:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73828 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 351DAA0528; Sat, 11 Jul 2020 12:47:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F234D1DAEE; Sat, 11 Jul 2020 12:45:20 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id A3E841D9D3 for ; Sat, 11 Jul 2020 12:45:19 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104519euoutp01a264dbd5f166a94fdb82e99bf761ab02~grNnJFHbg0814708147euoutp01Z; Sat, 11 Jul 2020 10:45:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200711104519euoutp01a264dbd5f166a94fdb82e99bf761ab02~grNnJFHbg0814708147euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464319; bh=Q3FDVPqYih6h2xo05nFO4KV5xFIKOVLEyZFeSaipgvY=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=gTcMPwuHJRo6docD0iQ5jKSkfCiPvyxh/uT+g3whGjABaiWTP3pkQi92jyJBGDt4k 2g9Q01jr6N87pyp0QcCH55J5UYktDAqPZ7BR6dbu6CybyHSwv/xfE/nv8UijyK9c+h B+po5vu7B75EAW33bcjYfpJLhMlEO7bihn/0HWDA= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200711104519eucas1p1e653baf04abd5c5271997c41e4b57e40~grNm3jF1D0930309303eucas1p1u; Sat, 11 Jul 2020 10:45:19 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id BC.55.06456.F38990F5; Sat, 11 Jul 2020 11:45:19 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104518eucas1p2a5c67adeb9fa512a6b1bb8c05ac8199c~grNmhzlWD2342023420eucas1p2P; Sat, 11 Jul 2020 10:45:18 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104518eusmtrp2a785ccfcb7818cefc7cb391dc66d5843~grNmgyxZZ1628816288eusmtrp2a; Sat, 11 Jul 2020 10:45:18 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-55-5f09983f7192 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 1E.17.06314.E38990F5; Sat, 11 Jul 2020 11:45:18 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104516eusmtip16e3e646c772db4668a81362e9513fef4~grNkvCfMs0946309463eusmtip17; Sat, 11 Jul 2020 10:45:16 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:06 +0300 Message-Id: <20200711104414.15422-20-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHc+57G2quReVEF2VdFtRERbcsj0Rlc8ty9/JBo/GDieJ13iAR kLWiMoZBMxmpDDeozqGWjkZhuFhBpBSBuCbSYlWUiC2+AEEjwRdeqohVCqPcLvv2P7/z/z/n 5OQRaH0pN1dIy9yjGDPldAOnZepbQzeXJJ/QpCQWVLLEcd0KpK/bTpNey0OOHBn+iSKB6mTS 5DzFkpKefIoUl4xQxFll5sjz3kMMGQw6KfKg2ceTso5DPAm6+3nyS/tJIP3jT2nyh+0lkHbr JZaE/mnkyNB4BUOK33YCOVrnBeIpGmGIxdUApMAskuG/KnlifzCfBHu9DPF1XeTJ36O3aXLp ehjIbx4HkBsFk+yn70tvbWdYyd40QEmlf96mpdau47xU1GalpJrBBkoaaunkpOK6apCu9R2h pXOP33DrtJu1q3Yo6Wl7FeOyNdu0O/uGErI6Z++/+66NyYeamWYQBBQ/xqvhBDNoBb1YBei5 bGPU4hXgXb+VU4uXgK8fFlFm0EwnQu7zrNqoBKwa6YlGRgE7LSGIuDhxIfoKrVSkMUus4dA5 7p+Ox4rfor3wFB/RjPghuge9XETrxCS0NL7m1BEL8NyFK3REa6Z4eOjWtNaL89Ff/mr6URRv Cdhj/5lXA19g/TUvqDoWn3rqovw9nHSVR/fOxbFaP6+GCwG7Kw5HTclY9+wmHzkHLS5CR+My FX+GTeP3GPVKMzDwYmYE01OypP53WsU6LCzQq24DXmnriGLE8LsYFUsY6m2n1fs0Az4ud7K/ woKy/2fZAKohTsk2ZaQqpuWZyr6lJjnDlJ2ZuvS73Rm1MPVVfROeYAOMdmx3gyiAIUZnk4UU PSvvNeVkuAEF2jBLt/aGb6tet0PO+UEx7k4xZqcrJjfMExhDnO6jioEtejFV3qPsUpQsxfhf lxI0c/Nh68YPZt8fcfknG5K/WTkxUe3QljpazicdPuYb/sS6ru954LLldMBw/+jAvVy27U5S vC1h9eLKRO0jOb41sSy+66y85dHYvs3hvLwVaSe+//HzZsvJlbHG090bquBA3pN+V5Fmzte1 uV+uxxzvROBgMCYua8x6PO5NmvmZ66uWY3debDIwpp3y8sW00ST/C34cfsKmAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH/d17d3c3W12n0c3IahCJ2HRO89jDRkjcPyKCgqKyueymI+di d5Osf0x66LKVD0QzprnMmpH5ygcluT/UmuYjXEalJoKUpTWz8lVNR/99OZ/v95wD51C4dIYI pLSpRs6QqkmRkWLC+afjw9bYIpE6vHgwBKq7rAhGh2w4jBR8IOHat0sYDNp3w9PG2wLIG87A wJL3HYPG+2YSvoxkEjDpbsTg/TOnEG71ZwrB7RgXwvWeEgTjC59xKC6bRtBjbRDAbFsLCVML 5QRY5gYQ3KjvRNCR852AguYmBFfMNHx7UCkE2/sgcI90EuB8WyeEhzN9ODR0LSLI7ahG0H3l r0C1iZ0rqxCwtqefMDb/Th/Otr8tFLI5L6wYWzPZhLFTrQMka6m3I/bl6DWcrRr7TR4QH5Xv NOhNRm5jsp437pIdU0CEXBED8ojIGLlCGR2/PSJKFha78xSXok3jDGGxCfLk0aktZwdWn3PN vyAyUI2fGYkoho5kZh2PBGYkpqR0BWLuzBQjM6I8gGEmxnCvx59ZcJlJr2caMU7zMLkESDqY cWZZsSUQQL8jmddXLxJLwJ/ex9iybguXNEFvZhyTncsBCb2dKWj5SXq7bmCqHj9fniDy1Ben epe1lNYyPYOXkVcHMW9Kf2A30coy5GNHAZyJ1yXpeIWc1+h4U2qSPFGvq0Wekz9pn61rQv01 Bx2IppBshaRMQ6mlAk0an65zIIbCZQGSPd3OE1LJKU36ec6gVxtMKRzvQFGeBXPxwNWJes8D pRrViihFNMQoopXRym0gWyPJotuOS+kkjZE7w3FnOcP/HEaJAjOQf35ReNrH9rW1tuz4tpUn XY2YnyuBzVRqF0KH5rFu+5MLoh219f1fjryK6OIbDhetunf63O7mk0Oh+9N9TaF+64JL/IfC 030Eh9aXr6+4e+LX+dd6195+91dXR4hviVt1Q12xo1DVO2BRTtC9cZIccZyqUp/dWqpt990U n9RS/llG8MkaRQhu4DX/AAkRpQYIAwAA X-CMS-MailID: 20200711104518eucas1p2a5c67adeb9fa512a6b1bb8c05ac8199c X-Msg-Generator: CA X-RootMTR: 20200711104518eucas1p2a5c67adeb9fa512a6b1bb8c05ac8199c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104518eucas1p2a5c67adeb9fa512a6b1bb8c05ac8199c References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 19/24] examples/multi_proc*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- .../client_server_mp/mp_server/init.c | 14 +++++--------- examples/multi_process/symmetric_mp/main.c | 12 ++++-------- 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c index c2ec07ac6..57f3c24a8 100644 --- a/examples/multi_process/client_server_mp/mp_server/init.c +++ b/examples/multi_process/client_server_mp/mp_server/init.c @@ -185,6 +185,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -204,15 +205,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", ports->id[portid], - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)ports->id[portid]); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", (uint8_t)ports->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c index 9a16e198c..2cfed33d3 100644 --- a/examples/multi_process/symmetric_mp/main.c +++ b/examples/multi_process/symmetric_mp/main.c @@ -365,6 +365,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -384,14 +385,9 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Sat Jul 11 10:44:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73829 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF84EA0528; Sat, 11 Jul 2020 12:47:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D38A1DADC; Sat, 11 Jul 2020 12:45:25 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id C94F51D983 for ; Sat, 11 Jul 2020 12:45:23 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104523euoutp02419e78e00e9cd5e6ebaef2252a311fe8~grNrAOlSb1781817818euoutp02d; Sat, 11 Jul 2020 10:45:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104523euoutp02419e78e00e9cd5e6ebaef2252a311fe8~grNrAOlSb1781817818euoutp02d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464323; bh=tDOhNsNqYHwuHfP7ogSVHuRwK5Yiu32YOkgqAdAwbZU=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=pnw6kzFnqXncGqMPL8EM+W9XSQqn7N156rgriMu2zm9bwVmVyb0K1OdiLHwVFPoV5 /i+q2Glbj7F1ZQ6Etd8eSAgRJXL7ObLSPzVK3x0SXOsjJ2SkXVZr4qRzHKDLgrZIsU 4zdwyiV1DRrV7FbIzWAJIZ1vcZpR3wKJ397n7bYc= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200711104522eucas1p1c8ad7635e5e596327f72b410c24f8252~grNp_52HM1645216452eucas1p12; Sat, 11 Jul 2020 10:45:22 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id DA.87.06318.248990F5; Sat, 11 Jul 2020 11:45:22 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104521eucas1p26cd821c97bf13ecf045dd4419b9576d2~grNpaZUA42332923329eucas1p2a; Sat, 11 Jul 2020 10:45:21 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104521eusmtrp24e8fbe4ae58eac334802b6e0d22859fa~grNpZjpfW1628816288eusmtrp2b; Sat, 11 Jul 2020 10:45:21 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-75-5f099842f2f1 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 30.27.06314.148990F5; Sat, 11 Jul 2020 11:45:21 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104519eusmtip1937a97a1fc417c336df09cfa6951278c~grNnmqNNH1304313043eusmtip1p; Sat, 11 Jul 2020 10:45:19 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:07 +0300 Message-Id: <20200711104414.15422-21-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSWUwTURSGc2emM0O1Zqwk3KBirNG4RNSg8cQYQeRhYjSgRhM1CgVGILK2 gLg8ECMEC7IJLqi0ggQsKC4tUFyCdUEpiJKwGUBcEgRRoC1BEETawfj2n+//zz0nJ5cl5bm0 OxsRHS+oopWRClpKVb0ab17re8UlcH1b7WKobCxE8LmnmITevG4a0ofPEdCh94bH1dclkPsx mYDM3BECqss0NAz2nqXgp7WagK4nFgYKWs4yYDX3MXCh+RqCvskBEq7qbAiaC40SGH9WS8PQ ZBEFmROtCLIMrxHUZ4xQkGeqQZCq4WD4dikDxV0eYO19TYGl8yEDFaPvSTA2TiHIqa9E0JQ6 LfFZyk/oSiR88eN+gr948z3Jv+q8xPAZbwoJ/v7PGoIfetpK85kGPeIbPqeTfPnXX3SA9JB0 a6gQGZEoqNZtC5KGW0wv6Vgtm/StW8ckIwOtQSyLuY04fypCg6SsnCtDOC37HC0WdoSv9udQ YmFDuKpOz2iQi7Nj2t5DObScK51JXdolhkYRvlBWTjgMmluJLWmFhMNw5e7TuHqy3Wks4Pxw tvGyU1PcctzQoHfuIeO2YFveHnHAElx+r450aJcZPDX0jhSHeeB2rd35JubesbhvPGN2Iz9s tHfRol6AB+oNs3wRnjZpCVGfxmMP2hmxOQ3hnqKU2ZA3Nnx/yziWILlVuLJ2nYi346wPTYR4 o3m448d8ByZnZG7VZVLEMpyWKhfTClz3pmUWYzz1e66IeWyyZpDieZ4g/OLRbzIbLSn4P0uH kB65CQnqqDBB7RUtnPBUK6PUCdFhniExUQ/QzE+1/KkfrUFPJ4PNiGORYq5Mp2QD5RJlovpk lBlhllS4ynybLEflslDlyVOCKiZQlRApqM1oIUsp3GReRf1H5FyYMl44LgixguqfS7Au7slo kz19GR/sr/HVhdxsd2+7R5b477t78G528J+shQX+Qzv9B5MWGcx33FJjtSj//JrNg8PXbpza X3be43nHpwo/VJJjDTKyREr+4gMx+vCeW+FuiZ42V092l8+OAm1S0M7jVXvH4uL4gC93Loa5 njgzfNgW5D1iPrZ7jilgBafolAwoKHW4csNqUqVW/gVbqCNgpQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3dnrW7T6CaotRIi6erV1o5WZmVw7a8yKnquoTcVnYvd GRn9YWam85GZVvaYU4lyCj7S1LDIYWrOMBemUZaEvSPzBVmu2pT++3I+3/M9B86hcMUU4U0l JBsFQ7I2SUl6EPY/nUNrt1yVaYLqHBzU9JgRvHtTgcNw0RAJOT8yMBi0bobWphsSKHybhkF+ 4RgGTXdMJHwbTifg+3gTBq8f2KVwzZEuhXHbRynk9V5H8HHmCw4llgkEveZGCUy33SdhdKac gPxf/QguNHQh6MwdI6CopRlBpomGH5W3pVDx2hfGh7sIsL+8K4XqqT4cGnucCC521iB4mvlX ErGC/2W5JeErWj9j/KWyPpzveHlZyuc+MWN83fdmjB992E/y+Q1WxHe/y8H5qpGf5E6PA+xG gz7FKCyP14vGTcqDHASzXCiwwetCWS5EfTgsWKUMDN8YKyQlnBAMgeFH2Xh7y2PyeCl18tOQ RZqGGkgTklEMvY75O/mGMCEPSkHfQkyPswA3IcoFGObrCD7n8WRmXpjIOc8EYiarHVI3IOnV jD3LjLmBF/2KZJ6fP0O4gScdyRQ0XsHcmqD9me5uK+kOldNhzETRrrlQP6aq9tHsAJmr7Bx9 NqsVdALTO3gOzWlfZqB0EitACy1onhV5CSmiLk4ncqyo1YkpyXFsjF5Xj1wnv9cxfbcZOep2 2xBNIeUCuUVLaRQS7QkxVWdDDIUrveRbn9qPKOSx2tRTgkGvMaQkCaINqVz7XcS9l8ToXQ+U bNRwKk4NoZw6RB2yHpRL5Vl02yEFHac1ComCcFww/O/DKJl3Glrs4/8hPTEqArblfVkUtM/X WRqYvz16fln2VHGk1VJePEo1NHZHyxREQI9/wsjlVD4gemlE7U3y2c4Njvasdp9+4nbIsqiy jGt+PhnZ5WzU+0Tb59ZVcQOV9frTl3Z0+e4v2fst9JhaV6gKV3dw3nt+tyjkQRs6Vi4+q0zV jHWplIQYr+XW4AZR+w/lDerUCAMAAA== X-CMS-MailID: 20200711104521eucas1p26cd821c97bf13ecf045dd4419b9576d2 X-Msg-Generator: CA X-RootMTR: 20200711104521eucas1p26cd821c97bf13ecf045dd4419b9576d2 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104521eucas1p26cd821c97bf13ecf045dd4419b9576d2 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 20/24] examples/ntb: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ntb/ntb_fwd.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index eba8ebf9f..1cbaace58 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -729,6 +729,7 @@ start_pkt_fwd(void) struct rte_eth_link eth_link; uint32_t lcore_id; int ret, i; + char link_status_text[60]; ret = ntb_fwd_config_setup(); if (ret < 0) { @@ -747,11 +748,10 @@ start_pkt_fwd(void) return; } if (eth_link.link_status) { - printf("Eth%u Link Up. Speed %u Mbps - %s\n", - eth_port_id, eth_link.link_speed, - (eth_link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_to_str(link_status_text, 60, NULL, + ð_link); + printf("Eth%u %s", eth_port_id, + link_status_text); break; } } From patchwork Sat Jul 11 10:44:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73830 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2FA7A0528; Sat, 11 Jul 2020 12:47:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 91BDC1DADD; Sat, 11 Jul 2020 12:45:27 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id DA1A51DADD for ; Sat, 11 Jul 2020 12:45:26 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104526euoutp015c35e200b289591cc95bd2ac9609f42b~grNt1yfNU0814408144euoutp01i; Sat, 11 Jul 2020 10:45:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200711104526euoutp015c35e200b289591cc95bd2ac9609f42b~grNt1yfNU0814408144euoutp01i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464326; bh=lyPYYv+FI1NhKaZeG18eiYzafVNNzcJQqm8MPr4Fj1k=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=sgBfSbwMLPuvtNMblILR/nVOxsdQLQt1+2JlQwE/Umdj0qrQYFA/WkOJA9aE7B0mQ K05lQp465Yp/W1Kowp0wEhJ74++fFdOWgG+FPHimAniL/zIGkvC/kcJAPb7bmE2zTN KqUPSB9PRs4PwY9LAjozzLpb6xcYSfTlAW4IoU0E= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104525eucas1p20d520e1ad0098cad551f8194ed8aad2f~grNs7siIk2338123381eucas1p2m; Sat, 11 Jul 2020 10:45:25 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id E4.2F.05997.548990F5; Sat, 11 Jul 2020 11:45:25 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104524eucas1p264572a08051556632b4c603907a5f9ac~grNryoRGN1984019840eucas1p25; Sat, 11 Jul 2020 10:45:24 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104524eusmtrp1fe156e498306d6f3cfb5493743b292f7~grNrxxXtl2954729547eusmtrp1D; Sat, 11 Jul 2020 10:45:24 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-71-5f0998459d38 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 43.96.06017.448990F5; Sat, 11 Jul 2020 11:45:24 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104522eusmtip1bd731c96339e4979c0a142ab538cb059~grNp_seE31304313043eusmtip1q; Sat, 11 Jul 2020 10:45:22 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:08 +0300 Message-Id: <20200711104414.15422-22-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTVxjG8957e+9tseaumnlSicYuRjQBP5O9MYuo0eVGTdyfhuiwygWJ tJpWdGJcCEGsBRkCmR+YUttsAhoKWFtkyIA/gFIQ60QgQcYcrOIHVEARBDbKxey/5/k973ue k5PD05oCVssnG09JJqM+RceqGE/TZEf07mvK+A3WgjXoarMBvuhz0thf+JzF7FAmhd1lsVjr vanA/D/TKczNf0eht8TK4pv+DAaHR70U9j70c3jjSQaHo41BDi93FAEGp1/ReN0+Bthhu6/A yYYaFkemHQzmTnUC/uRuAWzOecdg4YNqwCyrgKHS2xw6e1fgaH8Lg/6eexzefR+g8X7bDOCV Zhdge9a/iu2rxCn7LwrRWTtEiQW3ArTY1PMzJ+b4bJRYOVxNiSN1nayY6y4DsfVFNi3eGfjI fqeKU32TIKUkn5ZM67cdVh0bzOxVnAypfhiYamfTYZC3As8TYQt5fVFrBRWvEUqAhKrqFbIZ B+JqGaJlMwakxuOeM8r5jYmZq4wc3Abyt20IZPMeSJ3PqQhPsUIU8VtsVDhYKlSyxDvdRYWD JcI+4v3oZ8PljLCa/N4aEcZqYSt5YykHuWEluVNRP9+mnOMzI4/ntUZYQbqKx+fPJEIbTy5V VFLywi4SKA6wsl5CXjW7OVlHEn9BDiPrc2SiqouTly1A+hwXFoZiifv1Iy58IVpYS1w162W8 g2QXdTPyIy0m3W+/CGN6TuZ7rtIyVhNLlkae1pF635MFTMjMp0UyFknFX7ULz/MQiKNvAPJg 5Y3/u+wAZbBMSjUbkiTzJqN0JsasN5hTjUkxR08YqmDuq/pnm8eroWb6SCMIPOgWqe16Pl6j 0J82nzU0AuFp3VL1znb/9xp1gv5smmQ6EW9KTZHMjbCcZ3TL1JsdQ4c0QpL+lHRckk5Kps8p xSu16RClvDy256vzlc5yk/2f1K+l3Rt+pTLzMgYw8WbPhZf9Pm30b00TkcFbkVcexB06U4oH g+dte6+XpM12nvsjgS1tCA4/a9GNx1KeiqL9oUTLl98emIwafBrdEBcRHxFh2rN91rPJZ+Ce tt7Nq9P2Jaa0fYgpDDiSypOLJz8Zc39Mc+kY8zH9xnW0yaz/D9ea/o+mAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSfUgTcRjud3e7ndbi2FZdBmYLI4xWt2m+K7WIqAvChKA/SrNhh642J3fT rAjMtGSWZkbZ15yJVhapqWnRh81Qa5pZVFqaQxSxzK+MTGa1Kf338DzP+7wPvC+FyycIP8qQ aOGFRL1RRfoSzj9N3au3FPjEri3KVEJ5iw1B75diHFwXuknIHs3AoKNsIzyuvSaB8z1pGOSc H8Og9paVhCFXOgHD47UYdD1xSuHK23QpjDsGpHC27SqCAfdXHC7bfyBos9VI4PfzRySMuG8Q kDP1HkFudTOCpjNjBFx4WIfglJWG0ds3pVDc5Q/jrmYCnJ1VUrj7sx2HmpZpBHlN5QhaT/2V bFrGTdlLJFzx40GMyy9qx7nGzotS7sxLG8ZVDtdh3MjT9ySXU12GuFe92Th3p2+SjPLdow4T zMkWPiDBLFrCVXtZ0KhZHag1wTo1qw2NWa8JUa2JCDvAGw0pvLAmYr86oT+jS5I06pvaN9VK pqF+yop8KIYOZn5NXyK8WE6XIKalf6EVUR6eYb714bMWBeP+YCWtyNdj+YGYjPxKzCuQ9ErG mWXDvIKS/kwy706fmAlS0DuY2kkn6Q0i6EDm2au5XlpGr2eGsu6h2dClzJ2K+pkFPh5+euQN PtvBwLR1ZKJZ7M98LJzAzqH5djSnDCn5ZNEUbxI1alFvEpMT49VxZtN95Ln4g8bf1XXIOrzL gWgKqebJ7HoqVi7Rp4hHTA7EULhKKdvc6twnlx3QHznKC+ZYIdnIiw4U4umXh/stiDN7/ifR EsuGsKGgY0O1odp1oFoky6KfR8vpeL2FP8TzSbzwfw6jfPzSUOqEM3dwlaI1/HZQwEftSZfb kVtKRBmRLa6QbdhwLvr1ckEzpoigItn6T+Vbt5HNBdoV9QL1oOCpO3uxYWlPzJuxKmWZ63KF +4qic8lxPjB3XsfO9GUhh76XznmhPFa/aKhyUDe5wXSw//rBBqPu8Paoot3G6LyG5prIRve2 9C4VISbo2SBcEPX/AMis8bMHAwAA X-CMS-MailID: 20200711104524eucas1p264572a08051556632b4c603907a5f9ac X-Msg-Generator: CA X-RootMTR: 20200711104524eucas1p264572a08051556632b4c603907a5f9ac X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104524eucas1p264572a08051556632b4c603907a5f9ac References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 21/24] example/performance*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/performance-thread/l3fwd-thread/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 84c1d7b3a..8e1492dde 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -3433,6 +3433,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -3452,14 +3453,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Sat Jul 11 10:44:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73831 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BC04A0528; Sat, 11 Jul 2020 12:47:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B875F1DB2C; Sat, 11 Jul 2020 12:45:29 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 360FE1DB1C for ; Sat, 11 Jul 2020 12:45:28 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104528euoutp02878a5ec791e8e642b76b46f3b58f403f~grNvHmMdf1781817818euoutp02e; Sat, 11 Jul 2020 10:45:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104528euoutp02878a5ec791e8e642b76b46f3b58f403f~grNvHmMdf1781817818euoutp02e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464328; bh=S9//0LVQ6riyKwShCCIn8dhf7myi4b0icSVIJbKlCok=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=LzaDVKlZlGPDqSY623JVZAVkhPhleDNYM/7Z/J39KPitt4MaBL0JZ4V7XjZqzCCF+ SAXeXnVYUYOzSFPhBP0BXml+w0J700Po9+e3E0IRUQ55Ds2u1SQYXvvF8H+GXcXEMr IpX6OfhaYEeyqPubkwFQhu0ahLex3Dvhh2Z4mcoQ= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104527eucas1p28ce8eadf240f54e32331ae8a59fd1cc6~grNu260lV2330423304eucas1p2Q; Sat, 11 Jul 2020 10:45:27 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 07.2F.05997.748990F5; Sat, 11 Jul 2020 11:45:27 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200711104527eucas1p1a83283d0ff1d34ffcd2d57f87e9d85f0~grNuKiqx31619116191eucas1p11; Sat, 11 Jul 2020 10:45:27 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104526eusmtrp28b8335e3933b4fb1fa27f7371f549c52~grNuJtfj21628816288eusmtrp2e; Sat, 11 Jul 2020 10:45:26 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-74-5f099847ad41 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 92.27.06314.648990F5; Sat, 11 Jul 2020 11:45:26 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104525eusmtip1d2322e801f1b3ae2f53f89621a252b21~grNsY24w20946309463eusmtip1_; Sat, 11 Jul 2020 10:45:25 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:09 +0300 Message-Id: <20200711104414.15422-23-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUwTdxjH87u73h0NXc5K9IksmNUYXxJkvix7YhbdFqMXjYl/aTRBPOUE Ii/aE8W5TEKQkIIwmENFU2rRqEWtYKXAkDn+EGgRxIggImucBHlRpNBNa1FLr7r/vs/n+31e 8suPp/W/s/P4lPSDsjFdSjWwWqb27tuO2A2nIxK+brUvRHu7meCzgUoaPSefsljwOpfCXtta bHSe02Dp39kUFpVOUOi8bGJxzJPD4Cuvk8L+224Oyx/kcOhtHuLwROdZgkOBERrPWCYJdppv afDtXw0sjgesDBb5uwkWO1oJthROMHiyvo5gnknA11cucVjZH4NeTyuD7sc3Obzq66LxVvs0 wZIWO8F7eR80338l+i0XNWJl4zAl/na+ixbvPi7jxMI2MyVWv6qjxPGmblYsctiI6HpWQItV z9+wW7Q7tN8lyqkph2Rj3Jpd2uQX7z30/houK6evg80mhayJRPAgrIJBWzllIlpeL1wmMPHv WVotpgiYS4ZZtZgMOsO+zy2jL94Q1bhE4H5ZcTjlI/DkUXEoxQqLwZ1vDg2OEqpZcAZ6qBlj trARKnLd9IxmhIXw5/RoqEEnrIZHjeeIumI+VN24E8pEBPn0+P2Q1gsx0FMxFRoKQjsPY4P1 4ZvWQc47P6Xq2TDS4uBU/SV8qK8I86PwX00PpzbnExiwHg+H1oJjtCOoeZ4WloC9IU7FP8BA wXN6BoPwBfS+nDWD6aAsrT0VxjrIz9OraQPcaXsQxgDT7yJVLEKu3c2p73ObwNP+WvpXMr/8 /10WQmxkrpyppCXJyop0+fAyRUpTMtOTlu3JSKshwc/qft8yVUcaArubicATQ6TOIvEJeo10 SDmS1kyApw1Ruh/vuXfqdYnSkZ9kY0aCMTNVVppJNM8Y5upWWofj9UKSdFDeJ8v7ZeMnl+Ij 5mWTb4qaLnRKu68r6877rK4U24K9qzP1Om9q3+aHkcdN26K2eBo6YD0X1z3Z6I2u/vmKq63G keEyR29yOXqvtW5fMAgpyRXRVr/zWMBX9s+iBMb1S1PU0kBMbmxf+Sr/Ccvk0NGSqm9fjmxY n/XHnMUHsuITY7VbKfbwk5VjY51J7V0GRkmWli+ljYr0EbO/bXqoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3c3Wl3mo4uB5SIIqel8tGOkRUTdgsAIIsxaF72otTm5 d4ZGf5io6XyUJlEmaopoKpVmaWGmUqktMy2f+SIKdYqPWaGl1pz03/ec7/dzOHAOhSt/EW5U VLSJF6I5vYqUE5bV1uE9R+7IdN7WRS08el+A4OtICQ5jucMkpM8lYdBfcQAa6vIlkDOagEFW zjwGdeVmEqbHEgmYsdVhMPTSIoW87kQp2FrGpZDZeQ/B+LIVh7tFCwg6C55KYKn5BQmzy8UE ZP3uQXCjtg1Ba8Y8AbnP6xGkmGmYe1AmhZIhd7CNtRFgGXgihaqfXTg8fb+CILv1EYKOlL+S gx7s76JSCVvSMImxt+534ezbgdtSNqO9AGOrZ+oxdraxh2SzaisQ++5rOs5Wflskg+Uh6v2C MdbEb480iqZA1VkN+Kg1AaD28QtQa3y15/b5+Ku8gvaH8/qoy7zgFXRBHTmxOobH1EjjEgc/ kAkogzQjGcXQfszUxCIyIzmlpEsRU7ZQbi8ou8EwU9/w9YwTs9xrJtczC4hJe1PpgEl6F2NJ LcDWDGf6C8l8un6NWDOc6ONMYZLFQRP0TubVypQDUND7mN6GfLQ+dRtT+bjJkZHZ+yuzHx1a SUcxnf3JaF27M32FP7CbaFMR2lCBnPlY0RBhEDVqkTOIsdER6jCjoQbZb/7s7dKTetRdfaoF 0RRSbVQUcZROKeEui/GGFsRQuMpZcajDcl6pCOfir/CCUSfE6nmxBfnbF8zG3VzCjPYPijbp NP4aLQRotL5a372g2qJIpZtDlXQEZ+Iv8XwML/znMErmloAuThzzGgl+bBssKz4hrYoM/Fx+ rTEXuQw92/xwSX449U9f+Mm0TO/v/iHNhckpNv3P0IUjYbV+cf3tr/08Ntgmb7vXOc3LHxxN FmKcy4XDua6K0dqZjjM6zpQk+57ukqdtT9l507Uywrrjal+bdWnc0xL4omn6NO29Vf8jc0gV v1tFiJGcxhMXRO4flBoKdAkDAAA= X-CMS-MailID: 20200711104527eucas1p1a83283d0ff1d34ffcd2d57f87e9d85f0 X-Msg-Generator: CA X-RootMTR: 20200711104527eucas1p1a83283d0ff1d34ffcd2d57f87e9d85f0 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104527eucas1p1a83283d0ff1d34ffcd2d57f87e9d85f0 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 22/24] examples/qos_sched: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/qos_sched/init.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 9626c15b8..4bb975fc9 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -160,14 +160,8 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) "rte_eth_link_get: err=%d, port=%u: %s\n", ret, portid, rte_strerror(-ret)); - if (link.link_status) { - printf(" Link Up - speed %u Mbps - %s\n", - (uint32_t) link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else { - printf(" Link Down\n"); - } + rte_eth_link_printf(NULL, &link); + ret = rte_eth_promiscuous_enable(portid); if (ret != 0) rte_exit(EXIT_FAILURE, From patchwork Sat Jul 11 10:44:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73832 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7752A0528; Sat, 11 Jul 2020 12:48:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 240F31DA99; Sat, 11 Jul 2020 12:45:33 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 3EB221DB47 for ; Sat, 11 Jul 2020 12:45:31 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104531euoutp025f561fb2a66fe188f2495a702f2c1301~grNx6qyo41781617816euoutp02d; Sat, 11 Jul 2020 10:45:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104531euoutp025f561fb2a66fe188f2495a702f2c1301~grNx6qyo41781617816euoutp02d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464331; bh=vt5/65wO/zNN0SJP1aLH1ptRLWzuOqXtrZ48Ij7JIF8=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=cDs+5119QFeNg7IcSy5z9tffgNmD+EQEkdMoSAxl5CuzuRYCR4JP7mQ7YENPFGK4U +ww0j0fEr96Lwa4OHzn6PVj1AzHIcNqf6YlojMBPxfoaf0DG8qBfgOA7TTEmLCRoiP b0DgyFvWSCnsam7lVw6AuyqkDbI22Zn6YgdHZY3U= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104530eucas1p20bede2f3a5375bb4f15bf0f57fed5682~grNxINv8z2330823308eucas1p2j; Sat, 11 Jul 2020 10:45:30 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 69.2F.05997.A48990F5; Sat, 11 Jul 2020 11:45:30 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104529eucas1p26b12b796729eb0b94a42ac78c247bbaf~grNwot6_p2338123381eucas1p2q; Sat, 11 Jul 2020 10:45:29 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200711104529eusmtrp19de620884b965ae016965689f0008104~grNwn4uY52954729547eusmtrp1I; Sat, 11 Jul 2020 10:45:29 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-7a-5f09984aa937 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 46.96.06017.948990F5; Sat, 11 Jul 2020 11:45:29 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104527eusmtip16e7a024360338dbb1a5f4ef2be071297~grNu2iHFh0946309463eusmtip1-; Sat, 11 Jul 2020 10:45:27 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:10 +0300 Message-Id: <20200711104414.15422-24-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0xTZxjG/c45PedQrTtWFt+ogdnF3RJ1m5q9LkSHl+zEmGhiYnbRsU5P isrF9IiKOiUqpBREBLxQtVbIhoNqBQtlBMTVaHVFUYMp9YKNMXFqBQqoqBRHe2r873l+3/N8 75svH09ry9iJ/NqMjZIxQ5+mY9VMw6VX7dMWH45L+bK2XIWONivBB12VNAbK7rFY0LuHws7q edjsOqrCkvs5FBaVhCh0nTSzGAzsYrC7z0Xh3RYvh5abuzjscz/icG/7EYKPhp7QWG7rJ9hu rVfhq3+aWOwZqmCw6PUtgvuclwl6CkMMlv3dSDDPLGDvX1UcVt5NwL7AZQa9/rMc2p/foLG+ LUxwv8dB8GreW9V3U8TXtj9UYmXzY0osPXGDFi/5D3Ji4RUrJdZ2N1Jiz7lbrFjkrCbivw8K aLHm4SC7TP2TOmmNlLZ2k2ScMfdXdWrLn2/YDfmjt1RdzOdyyEPeTOJ4EGaB6Wg9ZyZqXiuc JHCk2UMUM0DgtC1AKaafwICvnH5XCZw5FktVEfDc9sfMcwINjv9UkRQrfAZekzVajxdqWXAN +UYMz48XlsDp/GWRDCNMhY7DFjaiNcK30OQvJcqERKg5cz46LW6Eh3uuR7VWSADf8YHonSB0 8GDvLYkVFsKp5kMxPR6eeJycoieDt7SQUfQ2eFnn45SyiUBXRW4sNA+cT69xkeVo4XNwNM1Q cDL4Td3RnUEYC53PxkUwPSJLGg7RCtaAKU+rpHVw/srNGAYIvxmjYBE6nMOx520hMBgOMsUk 0fJ+lo2QajJBypLTDZL8dYa0ebqsT5ezMgzTV2em15GRv+od9gw0kqah39xE4IlujMam51O0 Kv0mOTvdTYCndfGa+Ve9v2g1a/TZWyVjZooxK02S3WQSz+gmaGZWPF6lFQz6jdJ6SdogGd+d UnzcxBySv3JdUmtq8fBgT00yX+ybprO1Ltr9Y0LAFTqgwlXjLhri21a25tp3DGYuXLJe/Xtd WM72br+eeP/DqbNefPLy+44FodJT4QUFHzQu3bLzB0Pnz9dyl0vVdueKyo/33jGfPda1Y/6F UZbZ27uC64JpckJ90pxg6FPrIss3+5L7HXb3Rxd0jJyq/+oL2ijr/weKyR0EpwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsVy+t/xu7qeMzjjDQ7vU7JYf2Yeo8Wje4uZ LR5Muctm0f2hhcnixip7iz3b57BaTLrfwGTRN+kjk8X2FV1sFm8eNLFYvPu0ncnizt7T7Baz LjWxW3w69Jzdovf8bEaL539eMVvMXPCZ0eL8vK2sFj8P7mKzeP9nEYtF36+rjBb9W04wWhzv +chiMWXnDkaLti4Biw8rl7NbLL4jZ/HpwQkWi9M3N7NbrPl6kdli65m/jBYTj69ntDjb9p/V QdHj14KlrB6L97xk8pi88CKzx7Gb09g9ek7OY/LY+G4Hk8f7fVfZPPq2rGL0OPWom9lj9ZMf bAFcUXo2RfmlJakKGfnFJbZK0YYWRnqGlhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWpRfp2CXoZ e5f9Zivo5K5YfrSTvYHxCUcXIyeHhICJxIMNcxm7GLk4hASWMkrMej2brYuRAyghIfH6CTNE jbDEn2tdbBA1nxkl1n88AZZgE9CQON0xjwkkISJwm03icnsjC0izsICPxLrOAJAaFgFViSsz ZrGB2LwCVhK7bk5mhBgqL7F6wwGwOZxA8b/vL4DZQgKZEudvtDJC2HIS1+d/YZrAyLeAkWEV o0hqaXFuem6xkV5xYm5xaV66XnJ+7iZGYJRvO/Zzyw7GrnfBhxgFOBiVeHgXJHLEC7EmlhVX 5h5ilOBgVhLhdTp7Ok6INyWxsiq1KD++qDQntfgQoynQgROZpUST84EJKK8k3tDU0NzC0tDc 2NzYzEJJnLdD4GCMkEB6YklqdmpqQWoRTB8TB6dUA6Pyhe+sbVz7Z576nl7kttYpZctXW2PW rJPJEiu0DTkFZa1DL+6/dXGff15Yb4xb/tEfkgFuYs1VR3m/vd/4OHv5pVrFpdNWxAk+ubl2 l9+OdwZPN61VjIp5OW9HVeyUQ88PR4Y13UrLkrnCxOIqKahQIKgqqMXX+oBHzLHmznFzpk1n zI8v26XEUpyRaKjFXFScCACVcH2SCAMAAA== X-CMS-MailID: 20200711104529eucas1p26b12b796729eb0b94a42ac78c247bbaf X-Msg-Generator: CA X-RootMTR: 20200711104529eucas1p26b12b796729eb0b94a42ac78c247bbaf X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104529eucas1p26b12b796729eb0b94a42ac78c247bbaf References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 23/24] examples/server_nod*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/server_node_efd/server/init.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/init.c index 378a74fa5..b62ddf68b 100644 --- a/examples/server_node_efd/server/init.c +++ b/examples/server_node_efd/server/init.c @@ -247,6 +247,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -266,16 +267,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - info->id[portid], - link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - info->id[portid]); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", info->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Sat Jul 11 10:44:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73833 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3ABA9A0528; Sat, 11 Jul 2020 12:48:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B2171DB53; Sat, 11 Jul 2020 12:45:36 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 8A9681D9BB for ; Sat, 11 Jul 2020 12:45:34 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200711104534euoutp021bd9976e85e5bc7ec8bc5336c93fdec5~grN0_gnEl3129031290euoutp02B; Sat, 11 Jul 2020 10:45:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200711104534euoutp021bd9976e85e5bc7ec8bc5336c93fdec5~grN0_gnEl3129031290euoutp02B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594464334; bh=LMKl1/5U9x+uii+TKB06k1f6ZYo7iRRo2CAmnc6rzpk=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=mJ50wW8br+KrycnZkF0bwgvfj4UhFs3BwiO1YI9MgKOuKDhmlg0AyOUXEy3nooO1P QtiOGBI4vcV18Ic8Ggca/4eLkibVFz7WVGAKgM60nW0IB3p45rXFOSI0N4vq73Bn/V 0QENDXybYTobcjbgkbUpBVSEoEyg4LJhXetvnp6g= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200711104533eucas1p2d16e62d42582d6f36c48c6c47aa0ecc7~grN0X_UaY2330423304eucas1p2S; Sat, 11 Jul 2020 10:45:33 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 6F.55.06456.D48990F5; Sat, 11 Jul 2020 11:45:33 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200711104532eucas1p2273dfdc1ad227e4730b643dbea7a8da3~grNzMgJvv2337623376eucas1p2Y; Sat, 11 Jul 2020 10:45:32 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200711104532eusmtrp2d39f87a8bb9fc056203d63550c2f0332~grNzLj3sX1628816288eusmtrp2i; Sat, 11 Jul 2020 10:45:32 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-68-5f09984d37d0 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 15.27.06314.C48990F5; Sat, 11 Jul 2020 11:45:32 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200711104530eusmtip1c21cc7dbe08f66b6137f5b4afca9e926~grNxXZdxa1966919669eusmtip1D; Sat, 11 Jul 2020 10:45:30 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Sat, 11 Jul 2020 13:44:11 +0300 Message-Id: <20200711104414.15422-25-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200711104414.15422-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0hTYRjHec/d5eLsJPR2s1oZ3cykPjxE2PXDgQxM+mSknepgkZfYmnah kLIl0yxnVFrMeUtTySx1Kmpmpa5VpiAaZIlGlq3UmZjmMucx+vZ7/v/n/z7w5+VIIZ1ZyB2P OSXrYqQoLaOiKpvGW/333vaK2Fg44gelrywIej/kktBzo5uB5KFEArqKtkGt7S4N5o8JBKSa hwmwFZoYcPZcpOCHy0bA+zoHC5ntF1lwNfazcLX1DoL+yQESMqwjCFotFTSMP61hYHAyh4LU iQ4E18pbEDSnDFNwo7oKgdHEw9D9AhZy3/uCq6eFAse7xyyUjLaRUPHKjSCtuRTBa+MUvX25 OGHNp8Xc2q+EmJ7dRopN726yYordQohlP6oIcbC+gxFTy4uQ+LI3mRSLP/1iQlRhqq1H5ajj cbIuIOiQ6lhZf9jJQdVpU0cimYCaOBPiOMxvxinGWBNScQJfiHCypQcpw0+Ee3tdrDKMIPzl V9W04zWTqM7OoxSjAGFbSfZsZBThsZe1tGeL4VdjR5KF8Bg+fBmDbZOdhMeYx+/BFXeGKA9T vB9O70ic0dX8Fpyf5KaUE0tx8cMG0sNe07p78O0MC7wv7sz6OfMo5ls43N1wnVYCu/HEl0pW 4Xl4oLl8lhfjqeosQuFzeOxRJ6uEkxD+kHN5dmkbLv/2hvXUQfJrcGlNgCLvwGnGB6zS0lzc 9V3jkclpNFfeIhVZjZOMgrKtxQ329lkZY/dvb0UWcf4TO6P0U4fwixIncR0tzfx/y4pQEZov G/TRkbI+MEaO36CXovWGmMgNR2KjH6Hpr+r40+yqQqPthxsRzyGtt9oqcRECLcXpz0Q3IsyR Wh/1zteOcEF9VDpzVtbFRugMUbK+ES3iKO189aacrwcFPlI6JZ+Q5ZOy7p9LcF4LExB7ReN+ 1u6cs8V/n+/zrZGHiicMF3z2Z+wK+6xZb44QNgcjtbNzfEoK+V6yZOXVWr+uc/ErhoPjL2St GvitvdK2z/+a/RJTH244v4yQ1wn3wuPYAHvNEUdQqEwv6A9a6yzuW98gdJv92jTp1tBvtCbE Z3Xa2AFb4dyEzLy+y95LtJT+mBS4ltTppb/nKfnDpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3cVZ5dpePGP0kEQQrNNbUfxUWFywYqooDJNh1516Jzt bpK9MDOTab6Rylg+8QlmvkMjLTSbtlRMJTURw0pRmxoVWk2l/z6cz/ec34Hzo3DxOuFMqRJ0 nDZBGS8hbQnTn76pgyce2IQfas0QQ8OAEcHsdDkOM4VTJGSupGEwXhsAnW2PBZD/KQWD7Pzv GLRVG0hYnEklYMnShsFkl0kIj4ZThWDpmRfCfXMxgvmNbzg8LFlFYDa2COBX93MSljfKCMj+ PYogp/kNgr6s7wQUdrQjSDfQsFJTJYTyyb1gmXlDgGmiSQj160M4tAxsIsjra0AwmP5XcMSV /V1SKWDLO79ibEHpEM72ThQJ2ax+I8Y2LrVj7PKLUZLNbq5F7NvZTJytm/tJnrYNkfpqNXod 5xKr4XV+kksykEtl3iCVe3pLZR6KMB+5l8Td3zeKi1clcVp3/whpbON8SOKy7VXDaBqegnop A7KhGNqT6SitIAzIlhLTlYhZS83BDIiyCoZZmMN3Mg7MxgcDuZNZtWbWVsktQdIHGFOGEdsS jvRHkhm5d5vYEg50MNNSvLLNBL2fKRhNw7ZYRPswlRmbxM7UfUzd05fbL9hY65vL77dZTKsY 8/hdtMN7mbEna1gusi9Bu2qRI6fn1TFqXibllWpenxAjjdSonyHryVt7fzW1o+HGsz2IppDE TlSipMLFAmUSn6zuQQyFSxxFxwZNl8WiKGXyNU6rCdfq4zm+B3lZF8zDnfdEaqwfKEEXLvOS KcBbpvBQeBwGiZMog+4OFdMxSh0Xx3GJnPZ/H0bZOKegwgi1W0X0hYvvjnuNwO5dJyfGAjtb 7rjg4Htj+pzuVlBuceQpednn1t1uZ5LtVZJyfegr/3nTZnRb9dGbbvk/c5Lt7YbOR4SFyR/G FSwEnr7iF7KQrutfiFWZXZyC1/pdZ+euuwd0Bb0qjWvna8aLvpjrLTOve/XSKsstRfMPl0UJ wccqZW64llf+A9coY/YIAwAA X-CMS-MailID: 20200711104532eucas1p2273dfdc1ad227e4730b643dbea7a8da3 X-Msg-Generator: CA X-RootMTR: 20200711104532eucas1p2273dfdc1ad227e4730b643dbea7a8da3 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200711104532eucas1p2273dfdc1ad227e4730b643dbea7a8da3 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200711104414.15422-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v8 24/24] examples/vm_power_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/vm_power_manager/main.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index 273bfec29..b4b960151 100644 --- a/examples/vm_power_manager/main.c +++ b/examples/vm_power_manager/main.c @@ -244,6 +244,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid, count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -267,15 +268,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint16_t)portid, - (unsigned int)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint16_t)portid); + rte_eth_link_to_str(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */