From patchwork Fri Jul 10 07:01:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73685 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBA60A0526; Fri, 10 Jul 2020 09:02:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 635311DB43; Fri, 10 Jul 2020 09:02:41 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id C93551DB40 for ; Fri, 10 Jul 2020 09:02:40 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070240euoutp015b750e5dc5f610efad9d09054bb2d0cd~gUh6909CN1892318923euoutp01c; Fri, 10 Jul 2020 07:02:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710070240euoutp015b750e5dc5f610efad9d09054bb2d0cd~gUh6909CN1892318923euoutp01c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364560; bh=BG13JEDguLywByJwOXQTWe6Zorck+0Dg5OriYR0Hx5A=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=j3qNYAuaB0Ve9+eEXdw2TsViqLT1dTBy0fzuVltrBPV2BgP9T2Ix8UpWwGm+vw6Vv 5lCKacfhUEYEdrW9/mTli8ycQOAmmp9ii3B0HaqTBjEnHagZ9U5pkXEYxJT/xmYgXT QpDd2HKiBLQPuCkbSLKe3DoPd4j/eI7S+l4CsRQw= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200710070239eucas1p2fb1aebdd20479514cd1d143b133ac65f~gUh6tGuhi1868318683eucas1p2K; Fri, 10 Jul 2020 07:02:39 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id CA.21.06318.F82180F5; Fri, 10 Jul 2020 08:02:39 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070239eucas1p1585ae0ea8e64d3f00e58870d9e133fa1~gUh6XGn890906809068eucas1p1y; Fri, 10 Jul 2020 07:02:39 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070239eusmtrp185a60019d86e28bb410e21cee714deb2~gUh6V8qpd1113611136eusmtrp1j; Fri, 10 Jul 2020 07:02:39 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-6a-5f08128f856e Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id C3.F3.06017.F82180F5; Fri, 10 Jul 2020 08:02:39 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070237eusmtip1b943ed57f774aa2fc1e272479b65c068~gUh4mXe3P1592215922eusmtip1H; Fri, 10 Jul 2020 07:02:37 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:01:59 +0300 Message-Id: <20200710070226.6045-2-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0wUZxT1m5mdGTYuGUcSbrWxsolW2/po8cf1VatpzCTVSDUxYoK4ygS0 gGQHtNI2WR8QstBF11dc7BZZDCtqAQUW0VpdjYgDEkkIEB+7otYKBeQloovWcTD137nnnHvP vV8+nhar2Un8ltR02ZpqSTazRqb6+kjTrHyRj58bCH2BZQ1ugh33PTQGD95jMffZXgrbSpfg Rd8xAzoDNgodzj4KfV47i/8GdzPY0++j8O6fKoeu5t0c9vufcPhrUwHBJ6FOGo8WDhBsclcZ cORKLYu9oSIGHS9bCOZX3iBYl9fH4MHzNQSz7QI+O1nCoefuFOwP3mBQbT/H4emh2zRWNYwS 3F9XRrAx+43hmyjpZeEJg+S5+JSSDhy/TUvX2w9zUl69m5IqemooqfdSCys5KkuJdLMjl5ZO PXrBxhjXGxclyMlbtsvWOV9vNCadCTq5NNdHPwYcjZyNFEfYCc+DMA+Gd023EyMvCl4C3UN+ Ri8GCVytsLF6MUDAt/8CsZOwdx0lD+rHXCUE/rrlNujFEIFcb8s7FyvMADXHTWlChFDBgi/U SmnCRGEBNN/ppbVwRpgG/7inarRJQCivyTHoCZ/AqfLLtIbDhPmQZS/iNCwKU6D190FK90+A +qOPGA3Tb/17qgpoLQuENzwEA69YfdC3UNz+YmzoROisq+R0/DGoB/IYHf8Ew2dbOb05h8D9 oqwx0xKo7LrFaYvSwkwoq52j00vhTL7K6Y8XDm3dE/QdwsFZfYTWaRPkZIu62wyX65vHaIDR V+N1WoLWxpOGfSTK9cExrg+Ocf0fW0joUhIpZygpibISnSrvmK1YUpSM1MTZm7elnCVvf7P6 um6ohlwKbfITgSfm8aaNo2y8aLBsV3am+AnwtDnCtKxR3SCaEiw7M2XrtnhrRrKs+MlknjFH mqKLnsaJQqIlXf5BltNk63uV4sMm2cinWcOezK7eDb8s8g+I3tUJy1ct3aoONnSlz0z3xOy5 5sjvYEe6V2Z7Yms7uxcs33TIdqFi+sPy2OgjbfeYNQH1dcy1vp7F4c7jjxeWfr9YjKt1F3SO Wxi+I+orRVrxh/Hn82GRv63e650bx07+vIO60ncumLQVDq1bm/bdidjiv5/vyzQzSpLly89o q2L5D/2hQLXJAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHee69u3dKg9u0ehIqXUQRuJqmnkmZSdGlIiKJqKw17KKic7Y7 7YU+mKXJtbRWRM2Yb5ml+ZaaJha5IrUppqEpaq4SLC1flkGFVpsj6tvhf37n95wHjpSUN0p8 pHGJRt6QqE1Q0J6U7VfLkH+OXKpZb+paDJXtFgTv3xaRYL82REPW1HkC+ko3Q1P9LQmYhlMJ yDZNE1B/V6Thsz2NgglHPQGDj20MmLvTGHBYRxm41JmLYHR2jISb+V8RdFrqJPCjuZGGydlC CrJ/9iDIqW1F0HJxmoJrjxoQZIgsTN0rYaBocDk47K0U2PprGLj/rYuEuvY5BFdaKhF0ZPyW hPtxP/OLJVxR0yeCu1rQRXIv+q8z3MU2C8FVTzQQ3OSTHprLri1F3Mv3WSRXNvKd3uN5ULnR oE828r6xesG4SXFIBQFKlRqUARvUSlVgyOHQgCDFurCNx/iEuBTesC7sqDK23G5iksxLTw5n dzCp6La3iDykmN2AS961Ua5azhYjbC3fISKpM8d4fIR0I154tlekReTpRL4i7KjJR64Gza7B tkwL4Wp4swM0fn3h7LzIiw3F3QOTpEtEsavwR4uvK5axgKsaMiVu6QpcVvV0/gEPVo3TxULG vUMstk7dQe56OX6TN0O4ZxfitpsjlEtJsqtxpUXuikmn5lxdLnkZLTT/R5n/Ueb/qHxEliJv PlnQxeiEAKWg1QnJiTHKaL3uAXLezcMXP2obkDgRaUWsFCkWyI7O0Rq5RJsinNJZEZaSCm9Z RIftiFx2THvqNG/QawzJCbxgRUHOX14hfRZF651XmGjUqIJUIaBWhQSGBAaDYoksk22OkrMx WiMfz/NJvOHvHCH18ElFUSb/cP/26oIbM6XN6Zry5/FRVMy+2dCx/WEnM0qCw3f5iWljKZ2j m7dV7a64x+jH52ybIrgzkV7PvnTL63RTKxcN7/KZ3uvreSKJ7u+rcWwPK3ml6e4fWnauqlfP XT4cseTDFiT7JqFao037MiZys7Ya1RXHl85cP2DP2/lqWdQzBSXEalVrSYOg/QN8IOpJTQMA AA== X-CMS-MailID: 20200710070239eucas1p1585ae0ea8e64d3f00e58870d9e133fa1 X-Msg-Generator: CA X-RootMTR: 20200710070239eucas1p1585ae0ea8e64d3f00e58870d9e133fa1 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070239eucas1p1585ae0ea8e64d3f00e58870d9e133fa1 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 01/25] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is optional. The value ETH_SPEED_NUM_NONE (0) was already part of the API. The value ETH_SPEED_NUM_UNKNOWN (infinite) is added to cover two different cases: - speed is not known by the driver - device is virtual Suggested-by: Morten Brørup Suggested-by: Benoit Ganne Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index a49242bcd..2090af501 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -303,6 +303,7 @@ struct rte_eth_stats { #define ETH_SPEED_NUM_56G 56000 /**< 56 Gbps */ #define ETH_SPEED_NUM_100G 100000 /**< 100 Gbps */ #define ETH_SPEED_NUM_200G 200000 /**< 200 Gbps */ +#define ETH_SPEED_NUM_UNKNOWN UINT32_MAX /**< Unknown */ /** * A structure used to retrieve link-level information of an Ethernet port. @@ -2262,15 +2263,16 @@ int rte_eth_allmulticast_disable(uint16_t port_id); int rte_eth_allmulticast_get(uint16_t port_id); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It might need - * to wait up to 9 seconds in it. + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). + * + * It might need to wait up to 9 seconds. + * @see rte_eth_link_get_nowait. * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. @@ -2279,15 +2281,13 @@ int rte_eth_allmulticast_get(uint16_t port_id); int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It is a no-wait - * version of rte_eth_link_get(). + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. From patchwork Fri Jul 10 07:02:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73686 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C066FA0526; Fri, 10 Jul 2020 09:02:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14AF51DB6D; Fri, 10 Jul 2020 09:02:45 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 51C321DB7F for ; Fri, 10 Jul 2020 09:02:43 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070243euoutp01e4207aac0f207980b88087849585c7bb~gUh90QCIm2059620596euoutp01L; Fri, 10 Jul 2020 07:02:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710070243euoutp01e4207aac0f207980b88087849585c7bb~gUh90QCIm2059620596euoutp01L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364563; bh=2H/ERU8W5zPS4t5Hj4oIefSk0veb6FZ+kOzsHfJho/0=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=K4BPjK+skMmT2oEgaBcgZ7WVLhVEgjk9aopSzrmaWntJNAiHpYXKjc5qoJhtIccW4 BEGRJHCuoi3mdrz69w2c6ir2J7QFfTlNPtQIBa6niKTRwj1PzorE/VAs5aGbQAAjC5 KV65r0Y5WA/WaULyyRDggYI82Dbf1SP3w8zKdy5A= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200710070242eucas1p279dbca2b89ef66d5427f65a73631488c~gUh9kSEC11909719097eucas1p2N; Fri, 10 Jul 2020 07:02:42 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 7E.28.05997.292180F5; Fri, 10 Jul 2020 08:02:42 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070242eucas1p2d638073836aab0f37966a801996ee08b~gUh9Plofk1196811968eucas1p22; Fri, 10 Jul 2020 07:02:42 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200710070242eusmtrp23bbb0804ebf7522745653d1f8b34f4bf~gUh9OcYbF2959129591eusmtrp2p; Fri, 10 Jul 2020 07:02:42 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-fe-5f08129229c9 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C4.74.06314.292180F5; Fri, 10 Jul 2020 08:02:42 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070240eusmtip1d9ae3559becbdbe677d9254270457f56~gUh7Wlos11462214622eusmtip13; Fri, 10 Jul 2020 07:02:40 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:00 +0300 Message-Id: <20200710070226.6045-3-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf2wTZRjH89xd726VmqOgPE4yYiMRiYL4K4+GODQmXEhEiUoIUUaFc6Br Ib1tDky0ma5pOthcXSRO0s1OXdkwY7Pd2rkR3Mx+WNgvM0bj2BacQXBsdGy6QWfd7Ub87/P9 Pt/v875584qs2cunigft2YrDbs2y8EauoX2u53GvWcx4omVgE9We9wFdGa5kabT0Mk+FNz9l 6FJ1OjU3njSQd8TJUJE3zlBjwMPT+Gg+RxNTjQwNtUQFKuvPF2iq9apAx3u+ArqauM7SlxW3 gHp8IQPN/dTE02TCz1HR7QGg4mAnUMexOEelkTCQyyPRzVNVAlUOpdHUaCdH0dgPAp2e6WMp dH4eqKSjFuiCK2nY8pB8u+Jbg1zZfI2RP/+6j5XbY18I8rEuHyPXTYQZefLsAC8XBatB/uVK ISvXjM3yrxl3GzfvV7IO5iqOjS/sNR745Pcq9vCID/Jm2+YNTrj4kQdSRJSext/GvbzGZikA ON633QPGBZ4G/LH3DOjiFuD0TJy/23B2+Rl9UAX4/Tea0OozgBdd2zTmpXUYdfsWQyulOh4b E4MLQhRXSFsxMqlqyElrMTyapsVNEmF/fYjT96/BmjPnWI1TpOewwOMX9PVpOFg+vbgSpV4R u38tFPTCyxgvCBh0XoHXO4JL/mpMRsoZnT/Ef+oHBb3sBhz2FyyF0jH4V7egXYiVHsXapo26 /SJWuVoWbZTuxUs3lms2u4DehhOsbpvQ7TLraQue6+pfshHn7yzTbRn/KKlZesJmwPjlfMNn sKbs/7MqAKphlZKj2jIV9Um78sEG1WpTc+yZG/YdstXDwk+N/tsxHYamxDutIIlgWWbaO89n mA3WXPWIrRVQZC0rTS9diO4xm/ZbjxxVHIcyHDlZitoKD4qcZZXpKf+1t81SpjVbeV9RDiuO u1NGTEl1wlvxzMgO6bvAw8+OnHwvVrdjm3H9UMt9tgfa8sIx79/lewKrJ4++edbo/rMztbuk awoigeTPj5mG83q5j9PndkbJnhJ8nhkI2J0TdwLPHN/yCFWWvX5/MfOq5UTe2A1PLFS8q+GV 2d1t9+T2x3rbx97duj25jxJj6cE3Tm9Olma7QxZOPWDdtJ51qNb/AM9KaYylAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSf0yMcRzHfZ/nued5ah2PE74LyVnTTJfr+vE582v84ekP1og/JOdWzyq6 LvdcrTBLkXYlpBnFSY1+UUrpzjAdCldrshD9OGka0S9aaSX9mP/e2/v1fu+zfd4sKRuh3Njo WKNgiNXGyGlnyv63ocM7W8Zq1hePLYGKRjOC7s5CEhw5HTRkDJ4m4EPpFnhUe00C2V3JBGRl DxFQW2yi4YcjhYL+4VoC2h/bGchtSWFg2NbLwLnmPAS9E99JuJr/C0GzuUYCf+oe0jAwUUBB 1ngrgvPVLxE0ZA5RkGO1IEgzcTBYUsRAYbs7DDteUmBvu8/AnZE3JNQ0TiK42FCBoCltSrJ1 FT+ef0vCFz76RvCXbr4h+fq2ywyf+cpM8JX9FoIfeNJK81nVpYh/3Z1B8mU9Y3Sw837FRoM+ 3ih4ROlF4yZ5qBJ8FUo1KHz91AqlKjBsg6+/3GfzxgghJjpBMPhsPqSISv1SRMZ1mVHi2LNJ STJ6d9KEnFjM+eHkVwWECTmzMu4Wwp0Tk8iE2GkD474eco5ZhCfemeg55hfC57+Pzho054Xt 6ebZsCv3icZvz56iZsKLuB3YOiDOSIrzxBaH+wwu5QC3VNVQc50rcdm9p7M1TpwanzEVMDNa xkVh2+BtNKfd8fsbv4kLaH4+mleKXIV4URepE5UKUasT42MjFeF6XRWafvmD+j/3Lailco8N cSySu0gtU7RGJtEmiEk6G8IsKXeVbmuyH5RJI7RJxwSDXmOIjxFEG/Kfvu8i6bY4XD89oFij RumvDAS1MlAVqAoA+VJpOld3QMZFao3CEUGIEwz/cwTr5JaMTjDbNX0Hnqvez5f6FboHXPdY +DGndHnIvAV/r38NDibXDV1rSgpaPerWuF8fKl2xTEjtTrzis7uE2ns3rNkzryvPeyTEuHM0 9+DRmJ97ynd7Vv5UHXd1CY6uSC8f7e1jrHU9Q5C9D8eFefFLz1lzXuiCyleHVDtaUw637NrW 9nlNqJwSo7TKtaRB1P4DY4v1zAgDAAA= X-CMS-MailID: 20200710070242eucas1p2d638073836aab0f37966a801996ee08b X-Msg-Generator: CA X-RootMTR: 20200710070242eucas1p2d638073836aab0f37966a801996ee08b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070242eucas1p2d638073836aab0f37966a801996ee08b References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit add function which treat link status structure and format it to text representation. Signed-off-by: Ivan Dyukov --- MAINTAINERS | 1 + app/test/Makefile | 3 + app/test/meson.build | 2 + app/test/test_ethdev_link.c | 299 +++++++++++++++++++++++ lib/librte_ethdev/rte_ethdev.c | 174 +++++++++++++ lib/librte_ethdev/rte_ethdev.h | 54 ++++ lib/librte_ethdev/rte_ethdev_version.map | 4 + 7 files changed, 537 insertions(+) create mode 100644 app/test/test_ethdev_link.c diff --git a/MAINTAINERS b/MAINTAINERS index 5e706cd7e..f4fb31ea2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -393,6 +393,7 @@ T: git://dpdk.org/next/dpdk-next-net F: lib/librte_ethdev/ F: devtools/test-null.sh F: doc/guides/prog_guide/switch_representation.rst +F: app/test/test_ethdev* Flow API M: Ori Kam diff --git a/app/test/Makefile b/app/test/Makefile index e5440774b..9f43b8c3c 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -251,6 +251,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_SECURITY) += test_security.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c test_ipsec_perf.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec_sad.c + +SRCS-$(CONFIG_RTE_LIBRTE_ETHER) += test_ethdev_link.c + ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y) LDLIBS += -lrte_ipsec endif diff --git a/app/test/meson.build b/app/test/meson.build index 56591db4e..1e6acf701 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -39,6 +39,7 @@ test_sources = files('commands.c', 'test_efd.c', 'test_efd_perf.c', 'test_errno.c', + 'test_ethdev_link.c', 'test_event_crypto_adapter.c', 'test_event_eth_rx_adapter.c', 'test_event_ring.c', @@ -199,6 +200,7 @@ fast_tests = [ ['eal_flags_misc_autotest', false], ['eal_fs_autotest', true], ['errno_autotest', true], + ['ethdev_link_status', true], ['event_ring_autotest', true], ['fib_autotest', true], ['fib6_autotest', true], diff --git a/app/test/test_ethdev_link.c b/app/test/test_ethdev_link.c new file mode 100644 index 000000000..8a2f133c0 --- /dev/null +++ b/app/test/test_ethdev_link.c @@ -0,0 +1,299 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2020 Samsung Electronics Co., Ltd All Rights Reserved + */ + +#include +#include + +#include +#include "test.h" + + +static int32_t +test_link_status_up_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + printf("Default link up #1: %s\n", text); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 2.5 Gbit/s FDX Autoneg\n", + text, strlen(text), "Invalid default link status string"); + + link_status.link_duplex = ETH_LINK_HALF_DUPLEX; + link_status.link_autoneg = ETH_LINK_FIXED; + link_status.link_speed = ETH_SPEED_NUM_10M, + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + printf("Default link up #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 10 Mbit/s HDX Fixed\n", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + link_status.link_speed = ETH_SPEED_NUM_UNKNOWN, + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + printf("Default link up #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at Unknown speed HDX Fixed\n", + text, strlen(text), "Invalid default link status " + "string with HDX"); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_down_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link down\n", + text, strlen(text), "Invalid default link status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_string_overflow(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + + ret = rte_eth_link_strf(NULL, 2, "status %S, %G Gbits/s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Format string should fail, but it's ok\n"); + + ret = rte_eth_link_strf(text, 2, "status %S, %G Gbits/s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Format string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[2] == 'Y', "String1 overflow\n"); + + ret = rte_eth_link_strf(text, 8, NULL, + &link_status); + RTE_TEST_ASSERT(ret < 0, "Default format string should fail," + " but it's ok\n"); + RTE_TEST_ASSERT(text[8] == 'Y', "String1 overflow\n"); + + ret = rte_eth_link_strf(text, 10, NULL, + &link_status); + RTE_TEST_ASSERT(ret < 0, "Default format string should fail," + " but it's ok\n"); + RTE_TEST_ASSERT(text[10] == 'Y', "String1 overflow\n"); + + text[1] = 'Y'; + ret = rte_eth_link_strf(text, 1, "%S", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[1] == 'Y', "String1 overflow\n"); + + text[1] = 'Y'; + ret = rte_eth_link_strf(text, 1, "%s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[1] == 'Y', "String1 overflow\n"); + + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_format(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + printf("status format #1: %s\n", text); + ret = rte_eth_link_strf(text, 128, "status = %S, duplex = %D\n", + &link_status); + printf("status format #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = Up, duplex = FDX\n", + text, strlen(text), "Invalid status string1."); + + ret = rte_eth_link_strf(text, 128, "%A", &link_status); + printf("status format #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Autoneg", + text, strlen(text), "Invalid status string2."); + + ret = rte_eth_link_strf(text, 128, + "%G", + &link_status); + printf("status format #4: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("40.0", + text, strlen(text), "Invalid status string3."); + + ret = rte_eth_link_strf(text, 128, + "%d %M %", + &link_status); + printf("status format #5: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("%d 40000 %", + text, strlen(text), "Invalid status string4."); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_return_value(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + ret = rte_eth_link_strf(text, 128, "status = %S, ", + &link_status); + printf("return value #1:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_strf(text + ret, 128 - ret, + "%A", + &link_status); + printf("return value #2:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_strf(text + ret, 128 - ret, + ", duplex = %D\n", + &link_status); + printf("return value #3:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_strf(text + ret, 128 - ret, + "%M Mbits/s\n", + &link_status); + printf("return value #4:ret=%u, text=%s\n", ret, text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = Up, Autoneg, duplex = FDX\n" + "40000 Mbits/s\n", + text, strlen(text), "Invalid status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_unknown_specifier(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 128, "status = %", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string1 is failed\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = %", + text, strlen(text), "Invalid status string1"); + + ret = rte_eth_link_strf(text, 128, + ", duplex = %d\n", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string2 is failed\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL(", duplex = %d\n", + text, strlen(text), "Invalid status string2"); + + ret = rte_eth_link_strf(text, 128, + "% Mbits/s\n", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string3 is failed\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("% Mbits/s\n", + text, strlen(text), "Invalid status string3"); + + ret = rte_eth_link_strf(text, 128, + "%w Mbits/s\n", + &link_status); + RTE_TEST_ASSERT(ret > 0, "Status string4 should be ok, but it's fail\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("%w Mbits/s\n", + text, strlen(text), "Invalid status string4"); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_format_edges(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_UNKNOWN, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_HALF_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 4, "%S", &link_status); + printf("format edges #1: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_strf(text, 6, "123%D", &link_status); + printf("format edges #2: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_strf(text, 7, "%A", &link_status); + printf("format edges #3: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_strf(text, 8, "%A", &link_status); + printf("format edges #4: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "It should ok, but it fails\n"); + return TEST_SUCCESS; +} +static struct unit_test_suite link_status_testsuite = { + .suite_name = "link status formatting", + .setup = NULL, + .teardown = NULL, + .unit_test_cases = { + TEST_CASE(test_link_status_up_default), + TEST_CASE(test_link_status_down_default), + TEST_CASE(test_link_status_string_overflow), + TEST_CASE(test_link_status_format), + TEST_CASE(test_link_status_format_edges), + TEST_CASE(test_link_status_unknown_specifier), + TEST_CASE(test_link_status_return_value), + TEST_CASES_END() /**< NULL terminate unit test array */ + } +}; + +static int +test_link_status(void) +{ + rte_log_set_global_level(RTE_LOG_DEBUG); + rte_log_set_level(RTE_LOGTYPE_EAL, RTE_LOG_DEBUG); + + return unit_test_suite_runner(&link_status_testsuite); +} + +REGISTER_TEST_COMMAND(ethdev_link_status, test_link_status); diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index d06b7f9b1..38332b1e4 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -2383,6 +2383,180 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) return 0; } +static int +rte_eth_link_strf_parser(char *str, size_t len, const char *const fmt, + const struct rte_eth_link *link) +{ + size_t offset = 0; + const char *fmt_cur = fmt; + char *str_cur = str; + double gbits = (double)link->link_speed / 1000.; + static const char autoneg_str[] = "Autoneg"; + static const char fixed_str[] = "Fixed"; + static const char fdx_str[] = "FDX"; + static const char hdx_str[] = "HDX"; + static const char unknown_str[] = "Unknown"; + static const char up_str[] = "Up"; + static const char down_str[] = "Down"; + char gbits_str[20]; + char mbits_str[20]; + + /* preformat complex formatting to easily concatinate it further */ + snprintf(mbits_str, sizeof(mbits_str), "%u", link->link_speed); + snprintf(gbits_str, sizeof(gbits_str), "%.1f", gbits); + /* init str before formatting */ + str[0] = 0; + while (*fmt_cur) { + /* check str bounds */ + if (offset > (len - 1)) { + str[len - 1] = '\0'; + return -1; + } + if (*fmt_cur == '%') { + /* set null terminator to current position, + * it's required for strlcat + */ + *str_cur = '\0'; + switch (*++fmt_cur) { + /* Speed in Mbits/s */ + case 'M': + if (link->link_speed == + ETH_SPEED_NUM_UNKNOWN) + offset = strlcat(str, unknown_str, + len); + else + offset = strlcat(str, mbits_str, len); + break; + /* Speed in Gbits/s */ + case 'G': + if (link->link_speed == + ETH_SPEED_NUM_UNKNOWN) + offset = strlcat(str, unknown_str, + len); + else + offset = strlcat(str, gbits_str, len); + break; + /* Link status */ + case 'S': + offset = strlcat(str, link->link_status ? + up_str : down_str, len); + break; + /* Link autoneg */ + case 'A': + offset = strlcat(str, link->link_autoneg ? + autoneg_str : fixed_str, len); + break; + /* Link duplex */ + case 'D': + offset = strlcat(str, link->link_duplex ? + fdx_str : hdx_str, len); + break; + /* ignore unknown specifier */ + default: + *str_cur = '%'; + offset++; + fmt_cur--; + break; + + } + if (offset > (len - 1)) + return -1; + + str_cur = str + offset; + } else { + *str_cur++ = *fmt_cur; + offset++; + } + fmt_cur++; + } + *str_cur = '\0'; + return offset; +} + +int +rte_eth_link_printf(const char *const fmt, + const struct rte_eth_link *link) +{ + char text[200]; + int ret; + + ret = rte_eth_link_strf(text, 200, fmt, link); + if (ret > 0) + printf("%s", text); + return ret; +} + +int +rte_eth_link_strf(char *str, size_t len, const char *const fmt, + const struct rte_eth_link *link) +{ + size_t offset = 0; + double gbits = (double)link->link_speed / 1000.; + char speed_gbits_str[20]; + char speed_mbits_str[20]; + /* TBD: make it international? */ + static const char link_down_str[] = "Link down\n"; + static const char link_up_str[] = "Link up at "; + static const char unknown_speed_str[] = "Unknown speed "; + static const char mbits_str[] = "Mbit/s"; + static const char gbits_str[] = "Gbit/s"; + static const char fdx_str[] = "FDX "; + static const char hdx_str[] = "HDX "; + /* autoneg is latest param in default string, so add '\n' */ + static const char autoneg_str[] = "Autoneg\n"; + static const char fixed_str[] = "Fixed\n"; + if (str == NULL || len == 0) + return -1; + /* default format string, if no fmt is specified */ + if (fmt == NULL) { + if (link->link_status == ETH_LINK_DOWN) { + if (sizeof(link_down_str) > len) + return -1; + return strlcpy(str, link_down_str, len); + } + + /* preformat complex strings to easily concatinate it further */ + snprintf(speed_mbits_str, 20, "%u %s ", link->link_speed, + mbits_str); + snprintf(speed_gbits_str, 20, "%.1f %s ", gbits, gbits_str); + + offset = strlcpy(str, link_up_str, len); + /* reserve one byte to null terminator */ + if (offset > (len - 1)) + return -1; + /* link speed */ + if (link->link_speed == ETH_SPEED_NUM_UNKNOWN) { + offset = strlcat(str, unknown_speed_str, len); + if (offset > (len - 1)) + return -1; + } else { + if (link->link_speed < ETH_SPEED_NUM_1G) { + offset = strlcat(str, speed_mbits_str, len); + if (offset > (len - 1)) + return -1; + } else { + offset = strlcat(str, speed_gbits_str, len); + if (offset > (len - 1)) + return -1; + } + } + /* link duplex */ + offset = strlcat(str, link->link_duplex ? + fdx_str : hdx_str, len); + if (offset > (len - 1)) + return -1; + /* link autonegotiation */ + offset = strlcat(str, link->link_autoneg ? + autoneg_str : fixed_str, len); + if (offset > (len - 1)) + return -1; + /* Formatted status */ + } else + offset = rte_eth_link_strf_parser(str, len, fmt, link); + + return offset; +} + int rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats) { diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 2090af501..9afb566b3 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -2295,6 +2295,60 @@ int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); */ int rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *link); + +/** + * print formatted link status to stdout. This function threats all + * special values like ETH_SPEED_NUM_UNKNOWN, ETH_LINK_DOWN etc. and convert + * them to textual representation. + * + * @param fmt + * Format string which allow to format link status. If NULL is provided + * , default formatting will be applied. + * Following specifiers are available: + * - '%M' link speed in Mbits/s + * - '%G' link speed in Gbits/s + * - '%S' link status. e.g. Up or Down + * - '%A' link autonegotiation state + * - '%D' link duplex state + * @param link + * Link status provided by rte_eth_link_get function + * @return + * - Number of bytes written to stdout. In case of error, -1 is returned. + * + */ +__rte_experimental +int rte_eth_link_printf(const char *const fmt, + const struct rte_eth_link *link); + +/** + * Format link status to textual representation. This function threats all + * special values like ETH_SPEED_NUM_UNKNOWN, ETH_LINK_DOWN etc. and convert + * them to textual representation. + * + * @param str + * A pointer to a string to be filled with textual representation of + * device status. + * @param len + * Length of available memory at 'str' string. + * @param fmt + * Format string which allow to format link status. If NULL is provided + * , default formatting will be applied. + * Following specifiers are available: + * - '%M' link speed in Mbits/s + * - '%G' link speed in Gbits/s + * - '%S' link status. e.g. Up or Down + * - '%A' link autonegotiation state + * - '%D' link duplex state + * @param link + * Link status provided by rte_eth_link_get function + * @return + * - Number of bytes written to str array. In case of error, -1 is returned. + * + */ +__rte_experimental +int rte_eth_link_strf(char *str, size_t len, const char *const fmt, + const struct rte_eth_link *eth_link); + /** * Retrieve the general I/O statistics of an Ethernet device. * diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map index 715505604..6c80597d1 100644 --- a/lib/librte_ethdev/rte_ethdev_version.map +++ b/lib/librte_ethdev/rte_ethdev_version.map @@ -241,4 +241,8 @@ EXPERIMENTAL { __rte_ethdev_trace_rx_burst; __rte_ethdev_trace_tx_burst; rte_flow_get_aged_flows; + + # added in 20.08 + rte_eth_link_strf; + rte_eth_link_printf; }; From patchwork Fri Jul 10 07:02:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73687 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8423FA0526; Fri, 10 Jul 2020 09:03:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39B831DB93; Fri, 10 Jul 2020 09:02:48 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 222F51DB90 for ; Fri, 10 Jul 2020 09:02:46 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070245euoutp011a457295bd9c72a99c7d2904b55c0063~gUiAWULnE2059620596euoutp01M; Fri, 10 Jul 2020 07:02:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710070245euoutp011a457295bd9c72a99c7d2904b55c0063~gUiAWULnE2059620596euoutp01M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364565; bh=xmD2mOfSPYEySXTKCkIqMp30Ohht0MjEUFipNVMWweQ=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=l8WdLhc7Ou68f+sXo077AVLzZCIkKZRY0RyPAyukERaelTlM7MiTiZ7gRce8AdOzK TkSKNkM/xsu5PXwRfXkqrDEE+r8Q0EYWPD5h9nFTEoyIWvVbM7aH2KEg4L3qcRlfBH IiUjzlBNyNYMHuwAypV57m2AUTiPaUpTTNc8QWvw= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070245eucas1p1176823fa684f17a1361a4f0c8762ff14~gUiABolML1572415724eucas1p1-; Fri, 10 Jul 2020 07:02:45 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 1E.21.06318.592180F5; Fri, 10 Jul 2020 08:02:45 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070245eucas1p1f291014b205a97bf72822e820d7b2c8c~gUh-qZ7xY2360623606eucas1p1M; Fri, 10 Jul 2020 07:02:45 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200710070245eusmtrp29540ec3263421678aed6f8f4004e21c6~gUh-pmqp-2959329593eusmtrp2r; Fri, 10 Jul 2020 07:02:45 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-78-5f081295af71 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C8.74.06314.492180F5; Fri, 10 Jul 2020 08:02:44 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070243eusmtip1b79b292a939683a3e6230d8c341f3999~gUh91lb3k1340413404eusmtip1w; Fri, 10 Jul 2020 07:02:43 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:01 +0300 Message-Id: <20200710070226.6045-4-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUwTdxjH89xd747OLkcx8dERzBqJc3HF+ZI8JETcsmX3zzKzOBOXTOz0 hkaopLVqmX8gEwZV2SjMKZqCZYoUDUPOFkw1rIkgFmH4RhtfxhwbQSZVlDEczFEOs/8+v+/L 8zx//ETWWM4vELdZdyo2qyXHxOs5f/tEz1vfGcWsZTeGk6mxywP04H4tS/2V93g68Hg/QxFf JgUDx3Xk/qWAoTL3E4YCp108/dlfyNHIaIChuxfDAlVdLxRoNDQo0KGeY0CDkw9ZOlrzFKjH c15HEz9d4Ck26eWo7PktoG/UK0AdB59wVNnaAlTskuhxfZ1AtXdTaLT/CkfhaLNAZ8Z6WTrf NQVU3tEIdK34hW7N6/LzmpM6uTY4xMgVJ3pZuT16WJAPdnoYuWmkhZFjl27xcpnqA/nqgwOs 3DDwN79W/6k+Y4uSs22XYktbvUm/tfnyMJtXad4zFKmHAvhrkQsSRJRWYkl7WHCBXjRKpwGD pQNc3DBKzwD3jy/V+ClghXvNy8LRI+2zhTrAiLcVtMcYYMz/uy6e4qU3MFziYeLGXKmJx8Bk HxM3kqTVWNVSKMSZk1Kxs8I9oxskwvI/VEZbsRAbfmxj45wgpWORyytoZ6RgX/WzmaEodYlY H5nQaYX38MadQ6zGSfiwQxU0TsYXrdWzQ7/E8XN9glYuAbzvLZoNZaI63D3NoshKS7DxQpom v4PHPOMzMkqvYuRRYlxmp9Ht/57VZAOWFBu1tAnbOq/PyohT/8zRUMbGarN2fBBQPfPxt7Cw 6v9NNQA+mKc47LnZin2FVdlttlty7Q5rtnnzjtxzMP1Rw/92jLXApcnPQyCJYJpj2DTFZxl1 ll12Z24IUGRNcw3vXgtvNBq2WJz5im1Hls2Ro9hD8JrImeYZVniHPjNK2ZadynZFyVNsL11G TFhQAGdXFl5N9A10Ri8nfuGrCnX77+zuSl97yvGV84eJ7R92JzWkLwNzXdB2PPbJvpspsaXS Sat6duSRc8/m9x0Xrc0bMr8ueuXXYsPe/HUFyU36j9a1+W9HDwd+zjD9tkpV8yxHPsjPXpQh 9qYuTrDVpZWemt+0fvloQ59zX+neiuhg6oaIibNvtbz9JmuzW/4DkuO2XqQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSaUgUYRjHe2dmZ0ZpY1iVXvdD5pZlhZvj0T4bphJ9GPoUBBEdbpsOKrpu 7Ox2EWTSIWOZF+GVWWamFeaVW9nhUh6tUlaWYqZZtJThnZRZ5iZ9+8Pv9xzwPCypmqbUbGKK VbSkGJM1tCfl/NPaH5SnYg3BczcjoLqjBMHQ+zISBvP6acgYO0lAT1UUNDUWKyBnIJWAzJxx AhqvyzR8G0yjYGSikYB3D5wMFL5MY2DC4WLg3PMiBK7ZryQUlE4ieF7SoICfzfdoGJ29QkHm TDeC8/VtCFrPjlOQd9eO4LTMwVhlBQNl75bBxGAbBc7eOgZufu8ioaHjN4Ls1moEnafnFNH+ wkxpuUIoa/pCCLmXu0ihpfcCI5xtLyGEmhE7IYw+7KaFzPoqJDwbyiCFG59+0Ns8d2kjLGab VVyeYJasmzS7eQjR8nrQhoTptXyobu/GkHDN+siIODE58aBoWR+5T5tQ93SYPJCnPfylpxKl oumVMvJgMReGC/JbGBl5siquHOEx1zAlI3YeYDz8iVxwvPDsG5lecCYRHph00W5Ac4HYmV5C uIE310fjV2dOUG7gxUXiQnsa484UF4Dbc3MId1ZygLM/1xMLXf3wjduP/03w4PT4lHzln6/i ErBj7BpayMvw20tTRBZaUooWVSFv0SaZ4k0Sr5WMJsmWEq+NNZtq0fzN77T8rLOjlzXbHYhj kWax0j5HG1QK40HpiMmBMEtqvJWbO50xKmWc8chR0WI2WGzJouRA4fMLZpNqn1jz/AelWA18 OK8DPa8L1YVuAM1SZTrXvEfFxRutYpIoHhAt/+sI1kOdiqz5jVNJA6+DPK+OLvb3OdpbcPHB dGLwC9+PPVtv6aO6Vcf7FmV4qR+FNf/y828+JKNtAdXrSPWW/IA1U9ExP8bNgQWV5+UPhjur koqns2odq1882fKLmeq6T1mGK9I7R3S2Ip+dK/aywuehY6UX4iKvV+xIDwxyTZyaWcvvL/Qd P6ahpAQjv5a0SMa/bSjZcQkDAAA= X-CMS-MailID: 20200710070245eucas1p1f291014b205a97bf72822e820d7b2c8c X-Msg-Generator: CA X-RootMTR: 20200710070245eucas1p1f291014b205a97bf72822e820d7b2c8c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070245eucas1p1f291014b205a97bf72822e820d7b2c8c References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 03/25] app: UNKNOWN link speed print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 9 +++------ app/test-pipeline/init.c | 11 +++++------ app/test-pmd/config.c | 20 ++++++++++++-------- app/test-pmd/testpmd.c | 9 +-------- app/test/test_pmd_perf.c | 17 +++++++---------- 5 files changed, 28 insertions(+), 38 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab..4a4c572c3 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -685,12 +685,9 @@ show_port(void) printf("Link get failed (port %u): %s\n", i, rte_strerror(-ret)); } else { - printf("\t -- link speed %d duplex %d," - " auto neg %d status %d\n", - link.link_speed, - link.link_duplex, - link.link_autoneg, - link.link_status); + rte_eth_link_printf("\t -- link speed: %M, duplex: %D," + " auto neg: %A, status: %S\n", + &link); } printf("\t -- promiscuous (%d)\n", rte_eth_promiscuous_get(i)); diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c index 67d54ae05..b59064672 100644 --- a/app/test-pipeline/init.c +++ b/app/test-pipeline/init.c @@ -155,7 +155,7 @@ static void app_ports_check_link(void) { uint32_t all_ports_up, i; - + char link_status_text[50]; all_ports_up = 1; for (i = 0; i < app.n_ports; i++) { @@ -173,12 +173,11 @@ app_ports_check_link(void) all_ports_up = 0; continue; } - - RTE_LOG(INFO, USER1, "Port %u (%u Gbps) %s\n", + rte_eth_link_strf(link_status_text, 50, "(%G Gbps) %S", + &link); + RTE_LOG(INFO, USER1, "Port %u %s\n", port, - link.link_speed / 1000, - link.link_status ? "UP" : "DOWN"); - + link_status_text); if (link.link_status == ETH_LINK_DOWN) all_ports_up = 0; } diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index a7112c998..cb2795a94 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -604,10 +604,9 @@ port_infos_display(portid_t port_id) } else printf("\nmemory allocation on the socket: %u",port->socket_id); - printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down")); - printf("Link speed: %u Mbps\n", (unsigned) link.link_speed); - printf("Link duplex: %s\n", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_printf("\nLink status: %S\n" + "Link speed: %M Mbps\n" + "Link duplex: %D\n", &link); if (!rte_eth_dev_get_mtu(port_id, &mtu)) printf("MTU: %u\n", mtu); @@ -730,6 +729,8 @@ port_summary_display(portid_t port_id) struct rte_eth_link link; struct rte_eth_dev_info dev_info; char name[RTE_ETH_NAME_MAX_LEN]; + char status_text[6]; + char speed_text[12]; int ret; if (port_id_is_invalid(port_id, ENABLED_WARN)) { @@ -750,12 +751,14 @@ port_summary_display(portid_t port_id) if (ret != 0) return; - printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\n", + rte_eth_link_strf(status_text, 6, "%S", &link); + rte_eth_link_strf(speed_text, 12, "%M", &link); + printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %sMbps\n", port_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], mac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name, - dev_info.driver_name, (link.link_status) ? ("up") : ("down"), - (unsigned int) link.link_speed); + dev_info.driver_name, status_text, + speed_text); } void @@ -3899,7 +3902,8 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) ret = eth_link_get_nowait_print_err(port_id, &link); if (ret < 0) return 1; - if (rate > link.link_speed) { + if (link.link_speed != ETH_SPEED_NUM_UNKNOWN && + rate > link.link_speed) { printf("Invalid rate value:%u bigger than link speed: %u\n", rate, link.link_speed); return 1; diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 4989d22ca..a1b9c1c1c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3010,14 +3010,7 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. speed %u Mbps- %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_printf(NULL, &link); continue; } /* clear all_ports_up flag if any link down */ diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index 352cd4715..7ebe4efae 100644 --- a/app/test/test_pmd_perf.c +++ b/app/test/test_pmd_perf.c @@ -126,6 +126,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status[50]; printf("Checking link statuses...\n"); fflush(stdout); @@ -146,16 +147,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) { - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - if (link_mbps == 0) - link_mbps = link.link_speed; - } else - printf("Port %d Link Down\n", portid); + if (link.link_status && link_mbps == 0) + link_mbps = link.link_speed; + + rte_eth_link_strf(link_status, 50, NULL, + &link); + printf("Port %d %s\n", portid, link_status); continue; } /* clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73688 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92395A0526; Fri, 10 Jul 2020 09:03:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F264A1DBC7; Fri, 10 Jul 2020 09:02:50 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 4E97A1DB40 for ; Fri, 10 Jul 2020 09:02:49 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070248euoutp023e147084eac30cfc368a6cf58634bf72~gUiCxDwrA1730917309euoutp02U; Fri, 10 Jul 2020 07:02:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070248euoutp023e147084eac30cfc368a6cf58634bf72~gUiCxDwrA1730917309euoutp02U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364568; bh=uryTUJWnZHC1KobIzwDiYco1DBs90ldLDdgUZPnDwJM=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=XEu/KpiwLgt/SvvOwXu/Gi8aS/7OdstJo0u+otqEaYrwHGs6r8vhdCNENUEt7PvSr oMgoNwHGQ/fZj29BvYBOwSLOl+pRpgnmUabPNn26loogyEKh3waqXHU50lPI31Y0// lqyi4eTv4IQzqz5XdKnFUjhLHwYBOXWxkUwGZc/4= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200710070248eucas1p283291e3436438d69a8c81d07d9f089fc~gUiCY5DJC1196011960eucas1p2K; Fri, 10 Jul 2020 07:02:48 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 90.3F.06456.792180F5; Fri, 10 Jul 2020 08:02:47 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070247eucas1p100e76f67d55a3ab78c21cd197937fed6~gUiCE1DCP2360423604eucas1p1U; Fri, 10 Jul 2020 07:02:47 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200710070247eusmtrp2a993d82a4e2681a35cd806d2ce5aa9d3~gUiCAlbb92959129591eusmtrp2x; Fri, 10 Jul 2020 07:02:47 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-d5-5f081297e96b Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 9E.F3.06017.792180F5; Fri, 10 Jul 2020 08:02:47 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070245eusmtip1772cbb96753bf05a0225a5543acb00d4~gUiARhAZu1592215922eusmtip1L; Fri, 10 Jul 2020 07:02:45 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:02 +0300 Message-Id: <20200710070226.6045-5-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0xTZxjG851zes6ho+Z4cPONc6JdvCYqZi57Xcyclz+O/qPRzFuiUPUE LxRID+DcYkLMaFhliKgQFSpQEKkXRMo1KEgWQYsiTRCIoJU5DZRJKRCngJVyavzveX/P87xv 8uXjafEcO4s/FJsgm2INMXpWy1Tee/doabbIR0a4h1ZjaYuVYO8zG43usz0snvT+QWGnfQ3W VeVoMPN5MoXpmUMUVl2xsDjgPsHgG18Vhd23nRxecJ3g0Nf4msO/Wi8SfD3eT+P5vGGCrdYK Db67W8vi4HgBg+nv2wmecjQTbEobYvBsTTVBs0VAb0kxh7buOehzNzPo7Crn8NpoG40VLRME TzeVEnxo9mt+nie9zyvSSLa6Pko6k99GS/e6sjgp7b6VksreVFPS4J12Vkp32In0oPckLV19 +T+7Rbtbu/qAHHMoSTYt/ylKezClt5CK93/xa/HjHk0yGeMtJIQHYSWMFvUwFqLlReEKgZzC CU4dRghkWp20OgwT+OB5ST5Vmm2eYKWYgC+nSKMOowS81x2aQIoVFoEz1UoFjBlCGQtV4x1U wAgT1kOW5y4d0IwwHxq6nkyt1QkIf3Znc+qJcLh6s2EqEyKsghRLwRQXhTnQcWlkaikILTyY +4cYtbABPGe8wXIY9Dc5gno2+GsuUar+Hd7e6uDUciqBZwUpwdAacHgeTWqep4XFUFq7XMVr oS7NyQYwCNOg87/pAUxPyszKbFrFOkg1i2paDw33XUEMMDEWqmIJJm5mBR+rjkBubT2dQcIv fL6VR4idzJQTFWO0rKyIlY8uUwxGJTE2etn+OOMtMvlZnR+afNVk1LWvkQg80Yfqqv1spKgx JCnHjI0EeFo/Q7fuoXOvqDtgOPabbIqLNCXGyEoj+Zpn9DN13xX07RGFaEOCfESW42XTJ5fi Q2YlEy65wZWbu/l6x5GI47vtupWL4uOWvKXNUcfrS0Kf63sGz18eKVHO1W/Uzkt/kde6K0Sk dw63VrJb+H82HB6g7D9ufeILL+u8MZ6/3b8q6Zd4V1jkV6f//nZTZ8TFuQvH3Kk7BoS+H0RS 5N02Yt6fsEAq//f7p48rv9yRkfHNq2yb645RzygHDSuW0CbF8BE+35NsqAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTYRDH+Xa32wWs2VTULzwoNhqNxoWC0MEIGozJ6oMx0RdPusIGUNqS bgExPoBChYIghxDRIFIQBCOgXBo00AdAiweoaAWUIEqUQ8AjgCByxLd/5vebySQzDKn8Tbkz EXqTaNQLkSrahbL/be3dmqdkgr2sQ+uhsr0AQf8HKwl9Ob00pI4lEvCufCc01l+XQdbHeALS s8YJqC+z0DDcd56C0Yl6Anoe2eWQ33leDhO2QTlcenENweDMNxKuFv5A8KKgVgZTzQ9p+D5T REH69BsEGTVtCFrTxinIedCAwGxhYex2qRysPWtgoq+NArvjvhzu/OogobZ9FkFmayWCZ+Y5 2a51/HRhiYy3Nn4l+OybHSTf4siV82lPCgi+erSB4L8/fkPz6TXliH/an0ryFQOT9AGXI9wO oyHaJHqEGyRTgOqoGrw5tT9w3tv8ObWP5vh2b1+VZ+COUDEyIkY0egZqufCk/mIias71TOnL Xlk8+sNYkDOD2W24zTpEWZALo2RLEK6y2ZEFMfMA46EBcslZgWe6LPSS8wPhktfpi4BmN2F7 cgGxANzYbhq/uphALYAV7G6cO9S8KFHsBtzk6EILWcECTunJky9NXYsrqpoWHWfWHydZihbr SjYc28ZuoaW8Br+98ZO4jJYXIqdy5CZGS7owneTNSYJOitaHcSEG3T00f/O6lqmaBmQZPWhD LINUyxTaWTpYKRNipDidDWGGVLkpgp7ZTygVoULcWdFoCDZGR4qSDfnOL5hJuq8MMcx/kN4U rPZVa8BfrfHR+PiBarUimW0+pmTDBJN4WhSjROP/PoJxdo9HrZvdzNXnuOJG+sKIsGVPd3yW PuSzB7//yamN2fv1h2Mc2pGGCscR4bliUhvgutccynWfvGLvihh2io3LKEuo47YnB/q1Xb37 8L2iMz/SNV8Yuc0QLzUhyn33iaDM2Kgvh6oSWrSVT700zkleq8LIlK1ehsR2p+zquMRbkxGf TqsoKVxQbyaNkvAPw5zG+QkDAAA= X-CMS-MailID: 20200710070247eucas1p100e76f67d55a3ab78c21cd197937fed6 X-Msg-Generator: CA X-RootMTR: 20200710070247eucas1p100e76f67d55a3ab78c21cd197937fed6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070247eucas1p100e76f67d55a3ab78c21cd197937fed6 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 04/25] doc: update sample app with unknown speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- doc/guides/sample_app_ug/link_status_intr.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst index 04c40f285..596782b9d 100644 --- a/doc/guides/sample_app_ug/link_status_intr.rst +++ b/doc/guides/sample_app_ug/link_status_intr.rst @@ -158,6 +158,7 @@ An example callback function that has been written as indicated below. { struct rte_eth_link link; int ret; + char link_status[200]; RTE_SET_USED(param); @@ -169,11 +170,10 @@ An example callback function that has been written as indicated below. if (ret < 0) { printf("Failed to get port %d link status: %s\n\n", port_id, rte_strerror(-ret)); - } else if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + } else { + rte_eth_link_strf(link_status, 200, NULL, &link); + printf("Port %d %s\n\n", port_id, link_status); + } } This function is called when a link status interrupt is present for the right port. From patchwork Fri Jul 10 07:02:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73689 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57C63A0526; Fri, 10 Jul 2020 09:03:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 538701DBE1; Fri, 10 Jul 2020 09:02:53 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 69B9B1DBDA for ; Fri, 10 Jul 2020 09:02:51 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070250euoutp02f99904be40fcb7fb22c27f04d0f0aa12~gUiFCrbz11632016320euoutp02L; Fri, 10 Jul 2020 07:02:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070250euoutp02f99904be40fcb7fb22c27f04d0f0aa12~gUiFCrbz11632016320euoutp02L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364570; bh=1R9omrZ5fAPdKYuUkOS/6cuY8buXbZ+pEv8UB5bwG/w=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=NsBv5zB8WLyXkBTtZtqJbI/EUN6neo2qQ8PT5c/dBZNcK7DwYyR/1mxCEV5JpZGae cnDHReBo3aE+Axe6ABJxafk94UUQZMp39Ykp7lFz2h6YrfI+R+CsQWuCkQb4nyQW5v dZe8Ten7tzU10y4gaqcB7z8Kv+iuDyGXdTvjbtYU= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070250eucas1p171191609106dd0f51ef2ac90df704a25~gUiEv8REa1965019650eucas1p1o; Fri, 10 Jul 2020 07:02:50 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 02.31.06318.A92180F5; Fri, 10 Jul 2020 08:02:50 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070250eucas1p16b6e5acceef4c78f1b73463bb9264b52~gUiEZ8jyK1572015720eucas1p1v; Fri, 10 Jul 2020 07:02:50 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200710070250eusmtrp2c2fb239a7525bcf381f73a4a07ae397a~gUiEZAjwV2959329593eusmtrp23; Fri, 10 Jul 2020 07:02:50 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-87-5f08129ad768 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D1.04.06017.A92180F5; Fri, 10 Jul 2020 08:02:50 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070248eusmtip1b6a9ae81a63f5cb62dd31f5e6c7bddac~gUiCorWsA1544015440eusmtip1d; Fri, 10 Jul 2020 07:02:48 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:03 +0300 Message-Id: <20200710070226.6045-6-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0wTWRTGc2emM0Ol7lA1nrjGrjX4SlbXYMzRmPW9TnaNMTFGdINQlkkx QtHW+kwMC4qkKFVkNQIiFg0PiWC3UjBd1MZYaFGCEfGJBE2QlwpKXLBYKVP1v9/5zvm+c3Ny eVp9ip3CbzfslowGXZKWVTLVd4aafs5T87G/2Ow/YWVjIcGOtmIa23Ofs5j17jCFj8qXoctZ oMCcF6kUZuf0U+gstbDY257G4JsBJ4XP/vNxmHc/jcMBdyeHx5vyCXb6u2k8W/SeYFPhNQUO 3brO4lu/jcHs4RaCVkc9Qc+xfgZza2sIZlgEfFdWwmHxs2k40F7PoO/xvxxWDDbTeK1xhOBJ TyXBuxkBxfLp4nDRJYVY7OqixFMXmmnxzuPTnHisoZASr76pocS3dS2smO0oJ6K3I4sWL7/6 n92g3KpcmiAlbd8jGef/GqdMrL+yd6eX2/fy4i02lVSzFhLGg7AQSnoqKAtR8mqhlMAT6z+0 XHwg0FE5wMrFewKBgP+b5URVfahRQqDzXC8nF4MEcrsLxqZYYTb4MgvHgicKV1lw+lupYGOC sAoyvG1MkBkhEvKHm+kgqwQEpyOXkldo4HLVzTE9TFgMRyw2LshqYRq0nv8wFgpCIw/pPkfo Tash39ofMk+Abo+Dk3kqBGrPh/SD8NHeysnmTAJttiOhoWXg6Lk3yjxPC3Og8vr8IIKwAtKH Vso4Hh71RQSH6VHMqT5Dy7IKMjPUcoYWbjbcD8kAI5/CZVmEp+ldoYu6Ri9qvc2eIJq876uK CCknkyWzKVkvmaIM0t55Jl2yyWzQz/srJdlORr+q77NnsIbU+ePdROCJNlwVN8LGqhW6Pab9 yW4CPK2dqFp517dNrUrQ7T8gGVNijeYkyeQmP/KMdrIqytYVoxb0ut3SDknaKRm/dik+bEoq Ca8NPxQd0aN5WHX45dQbLYmbztR9XOu6pE95nVa6xVsxc1L0rL7GCOb3udPLI52RP5y+Qf/m dTW3rmnJ2jVs7jDHb4nRzI7rZ+32NVHj6qI8BrE0JiF+UsyiPwP81rQyt/629cHaT8gV8Es2 boj9o+FiL27W/H1u4boZSxXrjwb6hrSMKVG3YC5tNOm+AOz08G2mAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTcRDG/e9ud7eEmk3F8A8mqE1IPGK1FGQwgEaNbnxRIz6IIlZYgUBb 7LaI+iAQRFIOAVEjmIoiopUIaKHIodAHilQlaDyIF4IHqEEuo1RQC8S3X2a+75tJZlhSPkH5 sYk6o2DQaZIVtBfl+uN8s6pUzsasyaiUQs1DC4L+txUk9JW8oSF3JIuAl9b10GK/KIHid+kE FBSPEmC/bqbhW18mBcNjdgJet7oYKH2SycCY4zMD+d1lCD5PfSHhQvk4gm5LvQQm25to+D51 hYIC9zMEp22dCJx5oxSU3G1EkG3mYORGFQMVr/1hrK+TAlfvHQaqf/SQUP9wGkGRswbBo+y/ kg1LeXd5pYSvaBki+DOXe0i+o/ccw+c9sBB83XAjwX+/94zmC2xWxHf155L8zQ+/6B1eUcow g95kFJYk6EVjuGKvCgKVqlBQBgaFKlXqkOh1gcGK1RFhcUJyYqpgWB1xQJnQeetISheTNnC1 nU5HDbQZSVnMBeHC2k4Pe7FyrhLhx5VPJGbEehoYf/1AzmkW4Knn5lm9nBtH+KNbPcM0twy7 cizEjNeHe0Xjp6cyqJnGAm4Tzu56O8sUF4DL3D2zQTIOsN1WQsyFLsY3a9tm61IuFJ80X2Hm BiRgx8g1NMf++MWlCaIQzS9H86zIRzCJ2nitGKgUNVrRpItXxuq1t5Hn4g0dk7ZGZB7e5UAc ixTesgPTdIxcokkVj2odCLOkwke28ZFrv1wWpzl6TDDoYwymZEF0oGDPgkWk38JYved/dMYY VbAqBEJVIeoQ9VpQ+MpyuPZ9ci5eYxSSBCFFMPz3EazULx1FbvGJi292Zy2zKZwFtflDbC5M 6HemcC1H6EXWthNX12q9mx/Htm71suum01jT4ETibn1aN8MdPHY7evm7VmvAcX3v9pVJzsix ojpcaMlqejqupj6F/667P//QnprYVu3QwK2qwz+pL5vPTlZHz9uWJH3vTK8+PyJYlVGDvqkq BSUmaFQrSIOo+QfFeh24BwMAAA== X-CMS-MailID: 20200710070250eucas1p16b6e5acceef4c78f1b73463bb9264b52 X-Msg-Generator: CA X-RootMTR: 20200710070250eucas1p16b6e5acceef4c78f1b73463bb9264b52 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070250eucas1p16b6e5acceef4c78f1b73463bb9264b52 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 05/25] net/ixgbe: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov Reviewed-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 248f21d14..34a171116 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4300,11 +4300,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, switch (link_speed) { default: case IXGBE_LINK_SPEED_UNKNOWN: - if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T || - hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L) - link.link_speed = ETH_SPEED_NUM_10M; - else - link.link_speed = ETH_SPEED_NUM_100M; + link.link_speed = ETH_SPEED_NUM_UNKNOWN; break; case IXGBE_LINK_SPEED_100_FULL: From patchwork Fri Jul 10 07:02:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73690 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90332A0526; Fri, 10 Jul 2020 09:03:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5DF771DC11; Fri, 10 Jul 2020 09:02:55 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id D66DF1DC11 for ; Fri, 10 Jul 2020 09:02:53 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070253euoutp0167d80b133aa2129faa74c1c9886bcf99~gUiHl_9YP1892318923euoutp01k; Fri, 10 Jul 2020 07:02:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710070253euoutp0167d80b133aa2129faa74c1c9886bcf99~gUiHl_9YP1892318923euoutp01k DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364573; bh=zbg2xoSaiDgck4H57R7Z3rwqX+vJJlCAoA2nccHDMek=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=XO09GYznzkwopdb2zxOXaMqRzxywKIoN/vxkkVuLqgxgoGm/hsUxnInJs3oTViZIn ZrCFqu+OVeF5jt4dwwNmdpnXJsRKHp1rWYUJkS9X0JCIUKqdRn8pzZCS/xe2UGEd19 4i3Hb6QYkTLSmzuHrmGS3kB2fuuidBf6qPzl8f2U= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200710070253eucas1p232cb59feca5410e77fab57bbf7b2b910~gUiHP8pPq1909319093eucas1p2a; Fri, 10 Jul 2020 07:02:53 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 45.31.06318.D92180F5; Fri, 10 Jul 2020 08:02:53 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070252eucas1p111c3c4698edfd5a44b376c63e9b62822~gUiGyZjsl0824408244eucas1p1b; Fri, 10 Jul 2020 07:02:52 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200710070252eusmtrp20386bc25eb0d8fb28253b8d30e6ecf3a~gUiGxhOye2959129591eusmtrp26; Fri, 10 Jul 2020 07:02:52 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-8f-5f08129dfd5f Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 0E.74.06314.C92180F5; Fri, 10 Jul 2020 08:02:52 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070250eusmtip126d76716ff2e644c7091205e365bd942~gUiFCQwNs1602216022eusmtip1H; Fri, 10 Jul 2020 07:02:50 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:04 +0300 Message-Id: <20200710070226.6045-7-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHfe69vffSUHK9YjxxRrOqiS7zLZh4Fh1OM5dLfP3iFxOtVW7w BdC1otNlCZLZ1KIoiBuiAlJNgToRWtqKDJHEUmzVQSIviyLDF6bTCmij1qKjvTV++53/Of9z nnPy8LRYzE7mt2fvkQ3Z+kwtq2Zc3ne355wVed38wYdqrA2UERzos9LYX3yfxfyhXynsqVmK Te4zKix6kEthQdEwhe4qC4vP+/MYDI64Kbz3p5/D0s48DkdaBzk8euc0wcHIMxpPVbwieKes QYXvrjey+DJSyWBB+C7BY04fwbYjwwwWX/EQNFkEHKq2cWi9NxVH+n0M+nsdHF4MddDYEBgl WNhWS/CW6aPquy+lcMUFlWRtekpJJ8510JK39zdOOtJeRkl1QQ8lvWy+y0oFzhoi3RzIpyX7 o7fsOvUG9ZJ0OXP7XtkwL3Wzepu5429u919JP7kaK6hccjbRQhJ4EBZClz2fsxA1LwpVBMKe S/HgNYHC8mZKCV4R8NrtYxk+Zgn+sVbRbQROVQ/FHSECnoMuNtqXFWaB31wWcycLdSy4I91U NDFBWA52a1eMGWEmXKvPo6OsERDMgSZaedQ0sF9uiXGC8A0cslRyURaFqdBd/jrWFAQfD55/ HIxi+B7O9d6gFJ4Az9qcnMJT4OOV8rj+M7yp7+YUs5lAX+WheNFScP53O7YbLcyG2sZ5irwM uk42EmXlJOh5MT4q02NY5PqdVmQNmE2iUq2FlvbOuAww+j5+XgkevDkcv08TgVBfL3ucTCv9 PKuCkBoySc4xZmXIxpRsed9coz7LmJOdMXfrrqx6MvZX/R/aQh7SHNnSSgSeaBM1m0dZnajS 7zXuz2olwNPaZM3yW/5NoiZdv/+AbNilM+RkysZW8gXPaCdpUiqfbhSFDP0eeacs75YNn7IU nzA5l5i3lqQlHncnlqaaprRP/KH7cerR+evTg1+bmEVWxwrbyKr1Kbbn+bZl3jRHyQDnG/dL qm7mwqurd/b40tIb3H2utWsWhcLhH1e0lCQ9jqzhOofvz1kccGxM3vft23/Pp1QJziVurW4H 21WouzFD/JD5pO5RILip+szo1YFL3gsrTdO1jHGbfsFXtMGo/x+NsSxNpwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSeUgUcRTH+83MzozSyrQq/TC6NoLoGBvN9hmVYf0xEXT+IXTpVJNu7SE7 u5EVZFIq61Vmp7Vt3mlheReatomWq5RFdqdIEHZ4VmhZ5mb99+F93vvy4D2W1HyjAli9ySpb TJJBS3tT7t/Nbxdd0rCRi3+OLYDSVgeC7ne5JHRlvaUhpf84AS+Kw6C2+pIKMjvjCUjPHCCg ushOw+euBAp6B6sJeFPnZuDikwQGBl0fGEh7lI3gw+hHEi44hxA8clSqYOTeHRr6RnMoSP/x DEFGxQMEzakDFGTdrkGQaOeg/1ohA7lvZsBg1wMK3C/LGbj+rZ2EytZfCE41lyJoSxxTrZot /nDmq8Tc2h5CPH21nRSbXp5lxNSHDkK81VtDiH13n9FiekUxElu6U0ix5P0wvdF7K7/cYrZZ 5VkxZsW6QrtNgCBeCAU+aEkoLwTrdiwLCtEGrly+RzboD8iWwJVRfExy+ysm9rHPwao7TiIe XZ5sRyyLuSW498YGO/JmNVw+wvc724iJOsaf3pN25DWOvni0w05P9Awh3Pn6i8ojaG4edic7 CI/w417T+GnSMcojfLlwXJLbQXiY4ubi+rKEv0lqDnBya+2/1Jm45GbDX/biQvEJew7jYQ0X g139BWiCZ+DnV74SJ5GPE00qRn6yTTFGGxWBVySjYjNF87vNxjI0fvKqppHyGvTk1hYX4lik nayuGaMjNSrpgBJndCHMklo/dXibe6dGvUeKOyRbzJEWm0FWXChkfMFTZID/bvP4A5mskUKI oINQQResC14K2qnqZO7edg0XLVnl/bIcK1v+zxGsV0A8uhhRf/65f8v3hsYhMuzLi82GwTDp cIqxb23Eap7R7P15uTLv6Jok1te/UTis39SUVsXyC89+zhGndRHDZ2KFSe7GdZk6ZvMRk2ND njRlv2XXr211RYHlHWVOe0VWwZzCFFtwXcvwesNoxqpP09VxPUXnmqOO7NNHdV9JGykdKM7W UkqMJMwnLYr0B/ZB/mQIAwAA X-CMS-MailID: 20200710070252eucas1p111c3c4698edfd5a44b376c63e9b62822 X-Msg-Generator: CA X-RootMTR: 20200710070252eucas1p111c3c4698edfd5a44b376c63e9b62822 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070252eucas1p111c3c4698edfd5a44b376c63e9b62822 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 06/25] net/i40e: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c | 5 ++++- drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 472ce2a9e..f718356b5 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2891,7 +2891,10 @@ update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link, link->link_speed = ETH_SPEED_NUM_40G; break; default: - link->link_speed = ETH_SPEED_NUM_NONE; + if (link->link_status) + link->link_speed = ETH_SPEED_NUM_UNKNOWN; + else + link->link_speed = ETH_SPEED_NUM_NONE; break; } } diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index eca716a6a..cf931bf9c 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2163,15 +2163,15 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, new_link.link_speed = ETH_SPEED_NUM_40G; break; default: - new_link.link_speed = ETH_SPEED_NUM_NONE; + if (vf->link_up) + new_link.link_speed = ETH_SPEED_NUM_UNKNOWN; + else + new_link.link_speed = ETH_SPEED_NUM_NONE; break; } /* full duplex only */ new_link.link_duplex = ETH_LINK_FULL_DUPLEX; - new_link.link_status = vf->link_up && - new_link.link_speed != ETH_SPEED_NUM_NONE - ? ETH_LINK_UP - : ETH_LINK_DOWN; + new_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN; new_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); From patchwork Fri Jul 10 07:02:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73691 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62F15A0526; Fri, 10 Jul 2020 09:04:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 983641DC46; Fri, 10 Jul 2020 09:02:57 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 3CC8B1DC31 for ; Fri, 10 Jul 2020 09:02:56 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070256euoutp01acd5a022c77bd4c72d7311d23f5a2cc8~gUiJzIBzi2078320783euoutp01B; Fri, 10 Jul 2020 07:02:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710070256euoutp01acd5a022c77bd4c72d7311d23f5a2cc8~gUiJzIBzi2078320783euoutp01B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364576; bh=8FgdUe6Aml3rB/AWNSgZoZqeJOx9OS3/lqpbs6iX2+c=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=IxCHOmF6zB/LmAdOwsceIKmeXCeEEtMR0gDeqYSWE/pTnragFsdkE9yaeirEvs0O/ aHHpS4wVfbt1O/qpEzKJo43mKyTVWCkZL2A010Lc9WoY0dvuOyqVyv5KKkF8ex3TWg 9bUKa4TlFCAfu7nvV/aT2h9k6ljqNUHYjwl5TAyo= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070255eucas1p1625634b49d76c265a3a1852e78a33a10~gUiJkKXfE1572515725eucas1p1v; Fri, 10 Jul 2020 07:02:55 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id E4.38.05997.F92180F5; Fri, 10 Jul 2020 08:02:55 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070255eucas1p2da7a697fa21f92662ce276bba49ba708~gUiJNkb922446524465eucas1p2D; Fri, 10 Jul 2020 07:02:55 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200710070255eusmtrp2a2f7183706676f380a2676ff53e08530~gUiJMrykh2959329593eusmtrp29; Fri, 10 Jul 2020 07:02:55 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-1e-5f08129f9a31 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B0.84.06314.F92180F5; Fri, 10 Jul 2020 08:02:55 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070253eusmtip126d0501bffd698fad641caa4b2153707~gUiHbRtqM1602216022eusmtip1I; Fri, 10 Jul 2020 07:02:53 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:05 +0300 Message-Id: <20200710070226.6045-8-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0xTZxjG/c45Pee0oeasmvBGjZdmS5RlgLiYd+hEjYnH/bVsCYwlinWc IcrNHmC6ZRkSZVgZYnUaGQFsw0C8oFgpEDTYmBYoSpAhknFLwySg447IfbSnZv/98jzP+z5v vnw8rTOza/j4pFTJmGRI0LMapso50/JJkY6PCf119GOsaC4k6Omx0th3uZvF86NnKHxZHoF1 9gIVmnszKMw1j1FoLzOx+KYvk8HhcTuFXQ/dHOY/z+Rw3DHA4W8tfxAcmB+i8VrxBMGWwgcq nHlcy+LIvIXB3Nl2ghdsDQRdOWMMXq6pJphlEnD0RimH1q71ON7XwKC78z6Ht6ZaaXzQvEDw oquC4NOsJdXuTeJscYlKtNYNUuKl66206Oy8wok5jYWUeG+4mhJHHrWzYq6tnIhNnvO0eLP/ Hful5lvNzlgpIT5dMobsOqw5WtfTz6Q8405Ot/5FMsgd1kTUPAifwnD3W8ZENLxOKCPQXz2t 8ho6YZKArf5nxZgg4ByzUu8nPH0vOCVUSmDu72glNEXgXIbTF2KFzeDOLqS8xmrhHgv2+Q6f sUrYAxOzr2kvM8JH0Fa56KvTCgg5F8/RSsMGuHm33sdq4TM4a7L429ZDR9GkbykIDTzc72rg lIF9UFrU5D9vFQy5bH59HSzVFPn1n2C6soNThrMJ9FjO+kMRYHv9bJl5nha2QEVtiBdh+dBX nkgFV8LLfz/whullNFddpRVZC9lZOmWHHuobn/tlgIW5AEUW4cbtAaI8Tx2B5t8z2TyyIf// qmJCykmglCYnxklyWJL0Q7BsSJTTkuKCv0tOrCTLP9W96JqsJrXzRxxE4Ik+QHt4gY3RqQzp 8qlEBwGe1q/W7n3qPqTTxhpO/SgZk2OMaQmS7CBreUYfqN1mGTyoE+IMqdJxSUqRjO9dilev ySD72qIKvqJaja4XJ77euWVOdfyYcGcxL4wpSbOt/GaFsV+7LqhJfbqkt3M/Zw3N+odRRxxZ FDdGh1UNbbd87hzx5CWjY2Yq6sCxtdk7ftl77a6drglOCWp88iQ8vFu40vPhwGTkisD8GgxP bd943byw58Bg/Kjl8Z+sPH31i7aQ5u/1jHzUsDWINsqG/wDR7GvEpQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdjal1Wka/fOD5YEghWZzrb2WZSXUoQikPnTTbNRhi5zT nc0un1TKbJppWdEFt5QuU/Fum6bi9kGtdcEyM0ozk6Iy72HKsqbZt4f3+T0vD7yvhJT9pIIk x5NMvDFJk8jS/pRnpq1njVUmSVjb8iMAKp4WIujvLSahr6CHhuyRswR0l0RDo+O2CC5/SCMg 9/IoAY4HFhoG+zIoGBpzEPC+ySOGmy8zxDDm/iKGiy9uIfji/UbCDds4gheFdSKYcjXQMOwt oiB3+jWCS7XtCNpyRikoqHciyLQwMGK/L4bi98Ew1tdOgedtjRjKfnaQUPf0N4L8tgoEzzL/ iLaEcNO2uyKuuPErwV2500FyrW+vibmcx4UEVzXkJLjh5tc0l1tbgrgn/dkkVzrwi471PyiP MhrMJn6lziCYNrGHFBAhV0SCPGJdpFyhVMdviFCx4ZujjvGJx1N5Y/jmI3JdY+8AlfxcfGqy oxOloXLagvwkmFmH+/u6xLNaxtxFeCpPbUES3xzj7wPkPyQAe7ssPtzfh4wjfPXTpGjWoJnV 2JNVSMwagcw7Gr86n07NGgHMVjw+/X0uTTGr8KvqmbmAlAGck39hfusKXFrZMqf9mEh8zlI0 X0KH3SP30D8djN9YJ4g8tMiGFpSgQN4s6LV6QSEXNHrBnKSVHzXoq5Hv5A9bp2qc6GXVXjdi JIhdKHX+oRNkIk2qcFrvRlhCsoHSbc88h2XSY5rTZ3ijIcFoTuQFN1L5CuaTQUuPGnwPlGRK UKgUaohUqJVq5Xpgl0mzGFecjNFqTPwJnk/mjf9zhMQvKA0p93TabaxKO5RR4Mor2s8uUt+k vNFRuyz2lN7K3cs77IMDqucnHV6L/44DG695k7eLUutbwqyj+vS9Ex9dBW0xJ2LKu5sGd+sf xf/q+RzX1DIoBPfyupSUfYGhjiVj1oadne9c0T3ahaHdqV2LP18P6Q4ZyYhV6pu1XhtZ5rCx lKDTKMJIo6D5CzGIdz0IAwAA X-CMS-MailID: 20200710070255eucas1p2da7a697fa21f92662ce276bba49ba708 X-Msg-Generator: CA X-RootMTR: 20200710070255eucas1p2da7a697fa21f92662ce276bba49ba708 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070255eucas1p2da7a697fa21f92662ce276bba49ba708 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 07/25] net/ice: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Reviewed-by: Ferruh Yigit --- drivers/net/ice/ice_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index b51fa2f17..76f797de0 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3135,8 +3135,11 @@ ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) link.link_speed = ETH_SPEED_NUM_100G; break; case ICE_AQ_LINK_SPEED_UNKNOWN: - default: PMD_DRV_LOG(ERR, "Unknown link speed"); + link.link_speed = ETH_SPEED_NUM_UNKNOWN; + break; + default: + PMD_DRV_LOG(ERR, "None link speed"); link.link_speed = ETH_SPEED_NUM_NONE; break; } From patchwork Fri Jul 10 07:02:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73692 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2F98A0526; Fri, 10 Jul 2020 09:04:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 570601DCA0; Fri, 10 Jul 2020 09:03:01 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 6C1EC1DC77 for ; Fri, 10 Jul 2020 09:02:59 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070259euoutp01c017097eb42bc92fe50c8a74828bfd0d~gUiMw2q3a2059620596euoutp01S; Fri, 10 Jul 2020 07:02:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710070259euoutp01c017097eb42bc92fe50c8a74828bfd0d~gUiMw2q3a2059620596euoutp01S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364579; bh=fNqGGGujtZQoaCNUifIZpoVDm0FLT/KHJy8jVKrEsB4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=bkuDHHIE8RDwXH7Tr9f7Tk/+TplmrNl1sBIBSBMW4IuXjm75ymGkGGCbQ4oP/MTtc ztAcmE2/h2+8PVSn328RUsauEHqe9l5C9bI6wFhQPAiFy88/QnVnQy9LSQ3ttjJi3k RX2fKuxXyt4n4GlnFwWznWubpQW9ac3KH0T1pWk8= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070258eucas1p1b7e6b8dd126dfd6c01dd5d20c187907f~gUiMdJ-Wz1630516305eucas1p1C; Fri, 10 Jul 2020 07:02:58 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id A8.38.05997.2A2180F5; Fri, 10 Jul 2020 08:02:58 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070258eucas1p2a648deb28145bf9041f6b1d6b43f5412~gUiL3ArP52518925189eucas1p2B; Fri, 10 Jul 2020 07:02:58 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070258eusmtrp163a7b3e6162a1aaf5d02889752862c4f~gUiLrx5951176811768eusmtrp1E; Fri, 10 Jul 2020 07:02:58 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-25-5f0812a28a69 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 16.04.06017.1A2180F5; Fri, 10 Jul 2020 08:02:57 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070256eusmtip1aff2fb83fbb560a2bcc940022f75408c~gUiJ7hFeF1465514655eusmtip1F; Fri, 10 Jul 2020 07:02:56 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:06 +0300 Message-Id: <20200710070226.6045-9-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxbZRTHc+69vfdSV73rFjlBhazKIiYWpn44BpVhTLyLM/pNM3Wsuptu ERhpYXO+hSBg05WOlapxuq4Wt9UyZHQdIMEJ/UDBsheGCGQDSaMuvAiMFyejoJTL4rffc57f /5yTJ4/I6o/xKeL+wmLFUmjKN/Barqlz8fLjPr2Yl9VxzkgNPR6g2EgtS6PuYZ6OzJQzNBjI obbmrzXk+q2UIafrFkPNfjtPk6NlHE3NNjN048eoQMevlQk0G74pUNWVr4BuxsdZ+tI7B3TF c0FDix2tPE3HfRw57/QDHQ11AUUctzhy/9ACVGmXaOa7MwLV3kil2dEujqJD5wU6u9DL0oWe ZaBjkQagS5X/arZvke94T2nk2rYxRq75ppeVO4c+F2RHt4eRG6daGHn6Yj8vO0MBkH+OHWHl ut//4V/V7tI+s1fJ339QsWQ+t0e7rzwSY4q8z7630nEdSsGWZYckEaWncCY6JdhBK+olP2DY f5VVD/OA9d+PswlLL80BloW23E2sBM+vJ84AfloVZFRpAbArlJFgXnoUozYPk5A2S408NscH 1qRN0nb0XvRzCeakdAx0j66yKOokwusjW9UBaVh3rn1tcJL0NFbYfYLaPxUHTs6v9UTpqogn a8KcGngB63+t4lXehOORkKDygxitcaw7H+Dt4ICghm2AI76KdSkHQxOXhcQSrJSBDa2ZCUQp F8v6d6p4Lw7+tTEhs6voavqCVcs6tFXq1R4GbO++tl5GXF7aoJZlHHbEePWl2gA9nk+Eakg7 /v8oL0AAkpUSa4FZsT5RqBwyWk0F1pJCs/GdAwVBWP2o0ZXIfAu0xt8OgySCYYNuzzKfp9eY DloPF4QBRdawWff8pehuvW6v6fD7iuVAnqUkX7GG4QGRMyTrnvSNvaWXzKZi5V1FKVIsd28Z MSmlFIwPOW3VGb1DbkUbfvnb3bkpfN3iobPVFcalxUBsx7Tr4T8f+btoajx4f3b4xeKPGqHT fdQpfezoO730xs7cyW2D0fbuP5p0gayFV97sG5tku4Yh0++e2+Eyp77+U3K/5qX07J5894TZ aD5ddeIXV048u/5230Ra+Yf3eO5LjyS99pmBs+4zbXuMtVhN/wFBEZ1KpAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zds5RmhyW0j+DsqUVZquj2d51ry8eQuhGF7o4hx62yDk5 Z9qVMKmUZVoqQTdbmaWrsMtKTTO3D65aItk9rYZI2QU1V6Ri2lT69sDveZ/3hedlSdVvKpzd lW4VpXRDmpoOprzDng/zLqlY/YJfDUug6lkpgo6PZST4Sj7QcLz3CAFvHSugvvq8Aoo+ZRNQ UPSTgOoKGw0/fDkUdPdVE9D+0MvA2dYcBvrcXxg40XIOwZehbyScsfsRtJTeU8CA6wENPUOX KSgYfIWg0PkYgSf/JwUltTUIjtk46K28xkBZ+zTo8z2mwPvuLgM3fj8n4d6zvwhOeaoQNB8b UaycIQzayxVCWf1XQii+9JwUmt6dZoT8J6WEcLu7hhB6Gl7RQoHTgYSnHcdJ4XpnP70ueJtm qWTJtIoRJotsXabezkOshteBJnahTsPHaXcujo1Xz1++NFVM25UlSvOXJ2tMRzwdRIZ92d5h VxvKRnkLbCiIxdxCPHznLmNDwayKK0c4t+4ssiE2ADD+3kmOeybhodc2etzjR7hrZIgZBTQ3 B3vzSolREMq10fhF7mFqFEziVmJ7Q8WYprgo7Hjio0ZDlRzgto+zxkOn4+u3GscWBHE6fNR2 eSxTxZmwu/cqGtfT8JuLv4iTKMSOJjhQqJgpm41mOVYjG8xyZrpRk2Ix30GByu83DThrkK17 oxtxLFJPVCb/pfUqhSFL3md2I8yS6lDl6mZvkkqZati3X5QseikzTZTdKD5w3ykyPCzFEnig dKuej+e1oOO1cdq4RaCerMzjXDtUnNFgFXeLYoYo/Z8j2KDwbJRTuS1mMGTrmraUiuJCsjwm o27W5rWRWZE5LY2exvYDV6SuhMPOzs+1q5tSW12VUw5N3d21pzyx4s8q2mEejpK2aNMG5tb6 kg6GvcynGOFNVELMraIX7uj3M403axI38BFJZZsUj/zrw3MtzvZDRP9sS4y8Y8TktzZfSFoR wa/tV1OyycBHk5Js+AdjuHXICAMAAA== X-CMS-MailID: 20200710070258eucas1p2a648deb28145bf9041f6b1d6b43f5412 X-Msg-Generator: CA X-RootMTR: 20200710070258eucas1p2a648deb28145bf9041f6b1d6b43f5412 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070258eucas1p2a648deb28145bf9041f6b1d6b43f5412 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 08/25] examples: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov --- examples/ipv4_multicast/main.c | 12 ++++------- examples/l2fwd-jobstats/main.c | 12 ++++------- examples/l2fwd-keepalive/main.c | 12 ++++------- examples/l3fwd/main.c | 12 ++++------- examples/link_status_interrupt/main.c | 30 +++++++++++---------------- 5 files changed, 28 insertions(+), 50 deletions(-) diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c index 7e255c35a..0d4957658 100644 --- a/examples/ipv4_multicast/main.c +++ b/examples/ipv4_multicast/main.c @@ -572,6 +572,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -591,14 +592,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index 47a3b0976..740f1c80f 100644 --- a/examples/l2fwd-jobstats/main.c +++ b/examples/l2fwd-jobstats/main.c @@ -689,6 +689,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -708,14 +709,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c index b2742633b..d8be0a727 100644 --- a/examples/l2fwd-keepalive/main.c +++ b/examples/l2fwd-keepalive/main.c @@ -453,6 +453,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -472,14 +473,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 24ede4290..ef0f19a39 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -810,6 +810,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -833,14 +834,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/link_status_interrupt/main.c b/examples/link_status_interrupt/main.c index 9bbcadfcf..5e286060d 100644 --- a/examples/link_status_interrupt/main.c +++ b/examples/link_status_interrupt/main.c @@ -118,6 +118,7 @@ print_stats(void) const char clr[] = { 27, '[', '2', 'J', '\0' }; const char topLeft[] = { 27, '[', '1', ';', '1', 'H','\0' }; int link_get_err; + char link_speed_text[16]; /* Clear screen and move to top left */ printf("%s%s", clr, topLeft); @@ -131,9 +132,10 @@ print_stats(void) memset(&link, 0, sizeof(link)); link_get_err = rte_eth_link_get_nowait(portid, &link); + rte_eth_link_strf(link_speed_text, 16, "%M", &link); printf("\nStatistics for port %u ------------------------------" "\nLink status: %25s" - "\nLink speed: %26u" + "\nLink speed: %26s" "\nLink duplex: %25s" "\nPackets sent: %24"PRIu64 "\nPackets received: %20"PRIu64 @@ -141,8 +143,7 @@ print_stats(void) portid, link_get_err < 0 ? "Link get failed" : (link.link_status ? "Link up" : "Link down"), - link_get_err < 0 ? 0 : - (unsigned int)link.link_speed, + link_get_err < 0 ? "0" : link_speed_text, link_get_err < 0 ? "Link get failed" : (link.link_duplex == ETH_LINK_FULL_DUPLEX ? \ "full-duplex" : "half-duplex"), @@ -445,6 +446,7 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, { struct rte_eth_link link; int ret; + char link_status_text[60]; RTE_SET_USED(param); RTE_SET_USED(ret_param); @@ -457,13 +459,8 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, port_id, rte_strerror(-ret)); return ret; } - if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", - port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + rte_eth_link_strf(link_status_text, 60, NULL, &link); + printf("Port %d %s\n", port_id, link_status_text); return 0; } @@ -478,6 +475,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -497,14 +495,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73693 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F240FA0526; Fri, 10 Jul 2020 09:04:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 61B5F1DD02; Fri, 10 Jul 2020 09:03:03 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id E0D591DCA5 for ; Fri, 10 Jul 2020 09:03:01 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070301euoutp020fb35a41a9b7915cd48712bc0b370ade~gUiPEZOv_1730917309euoutp02Z; Fri, 10 Jul 2020 07:03:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070301euoutp020fb35a41a9b7915cd48712bc0b370ade~gUiPEZOv_1730917309euoutp02Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364581; bh=Mcy1FKB5X97xPHfABEMsRH14jwW9/cdD4WTM5f5JTOo=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=ul8M2E9192v1m1mrLT2J8CDRuX5fPem3XMs0VKtBvw5BWBtXL27hgZiiZFi5ULNEy Tx4Lh2DAA0uMe6n/P7SRvv2yPRZ74ePidbPmRAK3NVtSK252PZuoC0YkQLQg8rrWyq s/2Y9YzcXI1YqH4vj10X7bl7eg4lQ8Ad5IFryHYI= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070301eucas1p15ff4e1100c6e346bcb2adc10b418b24b~gUiOzToYi1573715737eucas1p12; Fri, 10 Jul 2020 07:03:01 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id EF.3F.06456.5A2180F5; Fri, 10 Jul 2020 08:03:01 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070300eucas1p12e2b57b4aabff00ec8920a0658d32fd6~gUiOZqJ6v1572015720eucas1p1_; Fri, 10 Jul 2020 07:03:00 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070300eusmtrp1b9b37f47b975c40fe90759351b5b7cbb~gUiOYx-xm1113611136eusmtrp1u; Fri, 10 Jul 2020 07:03:00 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-f6-5f0812a532e9 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id B8.04.06017.4A2180F5; Fri, 10 Jul 2020 08:03:00 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070259eusmtip16d94c8525eb36464b978ab12b28ca317~gUiMnnp6v1544015440eusmtip1f; Fri, 10 Jul 2020 07:02:58 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:07 +0300 Message-Id: <20200710070226.6045-10-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUwTdxjH87u73l07K7eTyBNfcDaaTBN8iSY+JPNtM3rRLBv+oYmJwyon klEwPXFzSyYSIc2JTCvByWZ5KQxFCQPBlg4nloyqFZEagkTUzmzyIgJWG5WhjHI1++/7fJ7v 8/v+nl9+PC2eYGfxaRkHZGuGOd3EGpjLbW86EipFPnnZndsxWHvLQfDxQyeNwcIHLB4bPUrh veq12Oz6RYf2R9kUFtifU+g6p7I4FMxhcDjkorD3ip/D4kAOhyFvH4fHO34m2Dc+SOOZ0hcE OxyNOnxzzcPiyHg5gwVjXQR/bLhO0Jf/nMHCJjfBPFXA0fNVHDp74zEUvM6gv+cShxfDnTQ2 3npL8KSvlmB73oRu3XxprLRSJzmbByjpVFknLbX1FHFS/g0HJdUNuylp5I8uVipoqCbSzcfH aOnC36/ZLw07DJ+kyOlpB2Xr0jW7DPt6+lbvV/XfXunamk3cnEr0PAgroagmMKkNvCicI9B6 9X60eEmgNzjEasULAo3OfvJ+5MmgSkW0KFQR+Kc1TTOFCTy5G6QjDVb4GPw2BxVpxAp1LLjG u6cmZgibod/dyaiE5xlhIZTlbotgo5AIXnU8GjAPLvzWMnWOfpLnquWcFhYP3SUvKc3TwsNZ 52ZNb4CmP3/SaXoGDPoaorvNAf+pfEbT38Or+u6p1UCwEXhYnhs1rYWGp7e5yH1oYRHUepZq eD3kuMpIBIMwHe49+zCC6Ulpv3ya1rARbHmi5jZBy41AFAO8/XeahiWoH2uKvmczgXCnnT1B 5hX/n1VKSDWJk7MUS6qsLM+Qv1mimC1KVkbqkj2Zlnoy+U/973whNwkHdnuJwBPTNKN7gk0W deaDyiGLlwBPm2KNn7b7vxKNKeZD38nWzGRrVrqseMlsnjHFGVeUD+wUhVTzAflrWd4vW993 KV4/K5tsV1JjEq5uXVAzd92a48n9lqqB+cPP2o58/vRMwehiYdNC/Zy6uc4PXKHDSds8Ker6 2PaitJIxx8aYgOejupovfj/r2TvUuyWh0H6/Qtar4R+SynpszavM7s9+tSbeic+P3WCb+e6v FsXjy7xUIXZMtK6cXTxc6BuJq0wqKWW3JJ4Mmhhln3n5YtqqmP8DD5o0IKMDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzVSa0hTYRj2O+fs7ExaHI5WH/thtSgy6Ni8bK+RJlFw6lcX8kdlc+ZBJbfV ziZaf0zS7FRmd7pg6jJNgy7eVmnYIK2miZqVeElEtMzMS0ETtabSv5fnxgPPy5DcFKVhUix2 0WYxpWppf8oz19S78R7HGDdlvo6AR80FCAb6nCT0X+2l4dz4aQI+l2+Futo7Crj8JZOAvMsT BNSWyTSM9mdRMDZZS0BPvUcJt9qzlDDpHlbChdbbCIZnRki4WTiFoLWgWgHeV89p+DlTTEHe dCeCi1VvEDSdn6Dg6jMXghyZhfEHpUpw9gTBZP8bCjxdlUp4+LuNhOrmWQSXmh4haMn5q4hZ LUwXligEZ903QrhS1EYKjV3XlcL5twWE8GTMRQg/X3bSQl5VORLeDZwjhYrBP/Ru/wP8FpvV YRdXJVsle5T2oA5CeV0k8KHhkbwuzBC3OTRCGxK9JVFMTUkTbSHR8Xxy13DUMVmVXt+5NxO5 lDJSMZgNx0MjMiEjf4ZjSxAe/VCKZMT4CIy/D5KLmgA881GmFzVTCE/ndiwQNLsee3ILFsyB bDeNO86couaJAHYX/upqo+aDKHYtLsqOnYfVbCR2yzNoMXQlrnjcsJCj8uHZcvFCIY5Nxu7x +2jxDsKf7v4i8tHSQuRXjgJFh2ROMkuhvGQySw5LEn/Ean6KfIPXNHqrXEge2+dGLIO0S9Tx s7SRU5jSpAyzG2GG1Aaqt7V4DnPqRFPGCdFmNdocqaLkRhG+fpdIzbIjVt/7WOxGXYTOAJE6 Q5ghTA/aFepc9tUhjk0y2cWjonhMtP33EYxKk4n0BBecMBg4bjamvz9qiF2X4Xrx2m/6Y+NQ mlEf0xUWt40vs6TYqypVDcetKkt+PqFwZi0fKo5J9XJXOgI0IdD3wiHdffs5+4P3Tjx/MUq3 ac8NrnOYxzu85I9uv1J6Q80S5Zq5uP1+er032FCUc7KdX3f22kT0dnqnJmGuXUtJySbdBtIm mf4B1x+77wYDAAA= X-CMS-MailID: 20200710070300eucas1p12e2b57b4aabff00ec8920a0658d32fd6 X-Msg-Generator: CA X-RootMTR: 20200710070300eucas1p12e2b57b4aabff00ec8920a0658d32fd6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070300eucas1p12e2b57b4aabff00ec8920a0658d32fd6 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 09/25] examples/bbdev_app: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/bbdev_app/main.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 68a46050c..44e6952e6 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -313,6 +313,7 @@ check_port_link_status(uint16_t port_id) uint8_t count; struct rte_eth_link link; int link_get_err = -EINVAL; + char link_status_text[60]; printf("\nChecking link status."); fflush(stdout); @@ -323,11 +324,8 @@ check_port_link_status(uint16_t port_id) link_get_err = rte_eth_link_get_nowait(port_id, &link); if (link_get_err >= 0 && link.link_status) { - const char *dp = (link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - "full-duplex" : "half-duplex"; - printf("\nPort %u Link Up - speed %u Mbps - %s\n", - port_id, link.link_speed, dp); + rte_eth_link_strf(link_status_text, 60, NULL, &link); + printf("\nPort %u %s", port_id, link_status_text); return 0; } printf("."); From patchwork Fri Jul 10 07:02:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73694 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E662A0526; Fri, 10 Jul 2020 09:04:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90C1E1DC77; Fri, 10 Jul 2020 09:03:06 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id A3CA21DD2F for ; Fri, 10 Jul 2020 09:03:04 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070304euoutp02f688fd7b1035c88b49b02a95338b1981~gUiRr5YBC1750117501euoutp02G; Fri, 10 Jul 2020 07:03:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070304euoutp02f688fd7b1035c88b49b02a95338b1981~gUiRr5YBC1750117501euoutp02G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364584; bh=sZj87uqkawQ60wf+sT4re4HeKIKPddDywVxgWZ8WdS4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=lFkxIgBXVcTTKNSs3aRxCkReaTl5kfb1Cmb9BfTLQQOHvBkZAqaD/qu7d/vgt0EvS BlK8oiFjgKuc6CJeTGCeDcB1LjqqNmEphhqso90LWGmriFQsx8a+RiP8D2sGsJ/87l 73oYfQsAZSH3yvL/GFnLP8je1530sg7oY2H9RUlU= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200710070304eucas1p2abc12c2669278efec738bd59cc8a82a5~gUiRZ_HHO2518125181eucas1p2K; Fri, 10 Jul 2020 07:03:04 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id AC.31.06318.8A2180F5; Fri, 10 Jul 2020 08:03:04 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070303eucas1p219bcb366ddf53e49827f09e144eddbf4~gUiQ34She1196811968eucas1p2M; Fri, 10 Jul 2020 07:03:03 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200710070303eusmtrp2625e7cebace7695f4992a3c2b0becd9f~gUiQ2wLSu2959129591eusmtrp2E; Fri, 10 Jul 2020 07:03:03 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-ab-5f0812a8a9fb Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 28.84.06314.7A2180F5; Fri, 10 Jul 2020 08:03:03 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070301eusmtip18a3b07b4c3e58332d24cefe6ec38e47f~gUiPF9ry11340413404eusmtip11; Fri, 10 Jul 2020 07:03:01 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:08 +0300 Message-Id: <20200710070226.6045-11-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0wTWRiGPTPTmaFxcKwmfOIt1pisu0E0brKf90uWOL+MP9w/GxW6MkEU qmlFRWPEBrAWRO2iBhTk5nJRA7JIARG1u6FIEReWpqiIhBgJiCK3KJSKlKn6732f9z35vnNy eFpjZYP5aP1h2aDXxWhZNVNZP9YcUqThw1d+yqCxtCmbYHdnPo1d6S9ZTPmQSGF7ySastV1T ofVVAoVp1kEKbUUWFvu7TAy+H7JR2HHfyWFmq4nDIXsPh+eeXiXYM9FHY0bOMMGn2XdVOPao hsWBiTwG08ZdBM9XNBB0pA4ymF5dRTDZIuKH4kIO8zsW4VBXA4POZ39zeGu0hca7TV6CFx2l BJ8kT6o2L5HGc26opPzaXkr6M7eFluqfXeak1MfZlHTnfRUlDdS5WCmtooRIjd0ptHTz9Sd2 h/p39fpIOSb6iGwI3Rih3tdWlkUO3Q445qnzcAmknrOQAB7En6G3s5BYiJrXiEUErlQ6GMWM EPjP1EYrZpjAmXf3Vd+O5JZNa41YSOC5e7dSGiUw4CqYDljxB3CasylfMFe8w4Jtwj1leH6O GAZJWfN9HUZcBv8WnGF8WhDXQJJ1xD9gMdwse0j7dICPW/I4ZdgicF8foZROAw+W578p+lc4 VzzKKnoO9Dkq/HdbAJPV1/39E/Cx3M359gHRTKAzL8lf2gQVb5s53260uBxKa0IVvAVOmwun MYiB0P5utg/TU9JaeYVWsADmZI3S1sLDx61+DOD1zFSwBGmPXP4nrCUw3JJBXyCLM7/PyiGk hATJccbYKNm4Wi8fXWHUxRrj9FEr9h6MLSdTP9X52TFaReom/rATkSfamUKElw3XqHRHjPGx dgI8rZ0rbH3i3KMRInXxx2XDwXBDXIxstJP5PKMNElbn9e7WiFG6w/IBWT4kG76mFB8QnEAe tMZUNkZXp78O9GaYAiMuqkzrmtAx0BgS3rHtr0tJQnz//6Fwdnv5On101vnulMkNuf2z7s2u EdDj2bY2cX8Yd9TzZujszvZfZgzuGlx48sCpgqVtXfYHxbfc6SF7P9bsUP8047JuYebSyFRb z7J/XEHjs5pDXgnqMW/nizDznsR5Wsa4T7fqR9pg1H0BRgtqdaUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSW0gUYRTH+2ZmZ2aljWEz+tJSGwoqaG285NkwC0OYlyIKeihLlxq0cndl Z5XsQcy0ZDVTs6Wbd63UQst7WOQSaq5R3srIW2KIWt6lm2W7Sm/nnP/vnPOHc1hSvUC5sWcN Zslk0EXxtAtl/9vSv/OBmg3btVTqBRXtuQiGB4pIGMrupyF1OomA3rJ90Fh3TwFZgwkEpGfN EFD30ELD16FECiZn6wjoe25n4E5nIgOztlEGrr29i2B0cZyE2/lzCN7m1ijgZ9MzGqYWCylI /9WD4Hp1K4KWtBkKshvqEVyxcDBd+oCBoj4PmB1qpcD+sYqBRwsdJNS0/0GQ2VKB4M2VJcX+ zeKv/BKFWNQ4Rog3CjpIsfmjlRHTXucS4pPJekKcetFDi+nVZUhsG04lxfKRH/Rhl+OaQJMx xix5RRpl817+hAA+GkELGh8/rUbwDTi5x8ef9w4KPCNFnY2VTN5B4ZrI7socFP1YeeH3i99M AmpmLEjJYs4PjxVUKizIhVVzJQjnpHx2JKxDwHhihFxh1uLF9xZ6hZlD+H1/G+UUaG4btqfk Ek7BlftE466rlyhn81ouBCfnuDsZituKXxVfXeZVnBYnZ80rVoZ64vLKl8sLlM66pXDZkJqL xLbp+2gl9sAf8uaJDLQmH60qQ65SjKyP0MuCRtbp5RhDhOa0Uf8UOU5e2/yzqh51PjlqQxyL +NWq+iU6TK3QxcpxehvCLMm7qoLf2E+pVWd0cRclkzHMFBMlyTbk7zCYSbqtO210PJDBHCb4 CwGgFQJ8A3x3A79elcI1haq5CJ1ZOi9J0ZLpfx/BKt0SUNC4rovoncqvycmbaMCXt4RYiz/x wbu0Ezut7hGH9qqO2JWjmYm3hD9WVe25eE3Ds5tVW/cz8b2Z4dSBH97zjX59CtfQb6uY6OJh r6xr2tZAw7u0qvEv/kmjyRs+1A6kLswc2yhGzVr7Bz1T72zvYTLiDg7ye86NabtDN6m+N5Xy lBypE3aQJln3D8SBNGYIAwAA X-CMS-MailID: 20200710070303eucas1p219bcb366ddf53e49827f09e144eddbf4 X-Msg-Generator: CA X-RootMTR: 20200710070303eucas1p219bcb366ddf53e49827f09e144eddbf4 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070303eucas1p219bcb366ddf53e49827f09e144eddbf4 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 10/25] examples/ioat: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ioat/ioatfwd.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index b66ee73bc..8bf80c262 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -700,6 +700,7 @@ check_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret, link_status = 0; + char link_status_text[60]; printf("\nChecking link status\n"); RTE_ETH_FOREACH_DEV(portid) { @@ -715,15 +716,11 @@ check_link_status(uint32_t port_mask) } /* Print link status */ - if (link.link_status) { - printf( - "Port %d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_strf(link_status_text, 60, NULL, &link); + printf("Port %d %s", portid, link_status_text); + + if (link.link_status) link_status = 1; - } else - printf("Port %d Link Down\n", portid); } return link_status; } From patchwork Fri Jul 10 07:02:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73695 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B62BA0526; Fri, 10 Jul 2020 09:04:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D67131DD4C; Fri, 10 Jul 2020 09:03:07 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1D57E1DD34 for ; Fri, 10 Jul 2020 09:03:07 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070306euoutp025486a147aab43806b2c9e8cee797793e~gUiT6VaoN1750317503euoutp02H; Fri, 10 Jul 2020 07:03:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070306euoutp025486a147aab43806b2c9e8cee797793e~gUiT6VaoN1750317503euoutp02H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364586; bh=KYoq+D7jL7TMj8sFJ9dEXZ47ChxgDfY/ELcSA7WUHJo=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=jrCqAiIgZebDTuBjK/xenZBgr5+uffeB8nVys2Yd4GNwvoCkyaVLv/iYUzcQ5EsmO lF+WgxcIRIs5or709YtbKTR2/fSfUNZJqLcpFyJOD4OT8l0Ydn2GzvvbSNTjSrsr/b mlXHxFrbA1HdsYP/6PDZBao/Hk0NWcGmYMKYKX0k= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070306eucas1p10bfb6e4a6207e1186403e78206ad63b6~gUiTp1FXm0824408244eucas1p1r; Fri, 10 Jul 2020 07:03:06 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id F0.41.06318.AA2180F5; Fri, 10 Jul 2020 08:03:06 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070306eucas1p188f37839cc01836fedcafde66583e968~gUiTTbxG11630516305eucas1p1Q; Fri, 10 Jul 2020 07:03:06 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200710070306eusmtrp29f22dcd23219f3aca162183b80929982~gUiTSLeSS2959129591eusmtrp2H; Fri, 10 Jul 2020 07:03:06 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-b4-5f0812aabc68 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 10.94.06314.AA2180F5; Fri, 10 Jul 2020 08:03:06 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070304eusmtip1db16fc446e45e26e1deeb2ff1edc6e6c~gUiRf-DPV1340413404eusmtip12; Fri, 10 Jul 2020 07:03:04 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:09 +0300 Message-Id: <20200710070226.6045-12-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxTGPffe3ntprF6rmUfdxDXZMkymLmzLMTPTLTNeF7f4h9G5ZMNu 3gEbH6YXmLosMrciqYAIbA42S4VNXGUiWClg57DJ+FjrEBYDRKalMdHqEEVAy4dIud387/c+ 53nO8+bNK7LGYn6xmJyWoVjSzCkmXs/Vt4Q7XnQaxYRVXWOxVOO3AwWvVrIUKPmHp4N3v2Go x7mWPO4fdVR0LZuhgqJ7DLlP2Hj6N7CfoztDbob6fvMJVNa1X6Ah7w2B8jt+ALoxcYulUsd9 oA77WR2FLzTxNDhRwVHB2GWgQ642oNa8exyVNDYA5dgkuvtLlUCVfUtpKNDGka/3jEDVI50s nfVPAh1urQG6mDOlW/esPOb4WSdXekKMXHysk5Vber8T5Lx2OyPX3mlg5MHzl3m5wOUE+c/g QVY+ef0hv1n/vn7NTiUlOUuxrHx9hz7pSscRdtf4kt2jgyOQDV8/ZYMYEaWXsbDUy9hALxql E4Blo0GddhgGvNnXx0ZcRuk+YHPo/0SP51deM1UB5gcD0cQI4IHjNoi4eOkF9OXaZ/YukGp5 dE90M5HBfGk9lp47zUWYk57Dr06dmtEN0mpsuWDltYpYPHm6eaY6Zlq32ioE7RpLsbt8eGYp Sn4RR62XGC3wFuZN+UDj+Xir1SVo/DRONZZHPV/gg7puQQvnAl6tsEZNa9F1+69pFkVWisOa ppURROkN9J95T8M52DMwL2Jmp7Go/giryQbMzTFqO0zY3N4VlREnx2drsoxFwZLo63oAj1Zf gUKILXtS5QBwwkIlU01NVNT4NOXzFao5Vc1MS1zxcXpqHUx/Vd+j1pEGOD/xkRckEUyzDTsm +QSjzpyl7kn1AoqsaYHhzYu+D42GneY9exVLeoIlM0VRvbBE5EwLDfEVoQ+MUqI5Q/lMUXYp lv+mjBizOBt+t+ZYNvavnivb9nZt2eRW00PfH/5Dqcta1J8RluKqL3l0ZsMr+bNs/QPvfvJa ceGqffXxfy8/2p6g39wzHnI+U3Uu/Pb1m/E1jWJvuWvLw2XHwva2B46fkj790h8oOFQ7Z0PT 7WtjoW+Hj28dYOOc2+fZrZ3PZ7+aUrp9MtnxTpZ7G5o4Ncn80nLWopofA3fLdjKmAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917dzel2WXOulhYDYS0mt2Z7ViWWRQXC4wiRMvW0ptK7sHu FhkJZpmyzN4PK6ZpZs1SS20rLXJ/OGuKaFRGVmKG9MBnmq+sTem/D+f7Ped84RwRLhkh/EWp WiNn0KrTZKQ34Zp2flxplYhUqzqcJFQ2WxB0fyrBoevSRxJOD5zEoMMaCfW2mwK48DkTg/wL gxjY7ppJ+NmVRUDfkA2DzmcuIVxvzxLCkKNXCGdabyDonfqOQ0HRMIJWS60AxhuektA/VUxA /sQbBGdrmhA48wYJuPTEjuCUmYKBe2VCKOkMgKGuJgJc76uFcH+kDYfa5j8IzjsrEbSc+ivY uJSdKCoVsCX13zD24q02nG18f0XI5r20YOzDPjvG9j9/Q7L5NVbEvuo+jbPlPWPkDu94eYRB ZzJyS1J0vHG9bA8DCjkTDnLF6nA5E6pMWKsIk4VsiEji0lIPc4aQDfvlKR9ar+L6yYVHRvtH UCY6Md+MvEQ0tZruqH9AelhClSJ6rGybGYncdZr+0YPPWnzpqbdmt8XbbRlGdGFVjsAjkNQy 2pVrwTyClPpA0q9zjhMewZfaQhfUVc0wQQXSxysqMA+LqXC6sSGbnJ26mC6vejGzwctdzzYX C2dDpNCOgTtolgPod4W/sHPIpwjNsSIpZ+I1yRqekfNqDW/SJssTdZpHyH3yx43j1XbU/nCX A1EiJJsrtv8lVRKB+jCfrnEgWoTLpOJNLa59EnGSOv0oZ9CpDKY0jnegMHfA87i/X6LO/UBa o4oJY5QQzihDlaFrQLZAnEs17JVQyWojd4jj9Jzhfx8m8vLPRLsDkyYd0uQ1o19/+2B12/Oj yIqInNLl/rdbNDpTTIylfPSyMVdhTBAnKHrMGfrNCVsDWybSoxTT1xq08fpFVpsjMLJRFex9 9sAJe22c30V9LBPb5LfT9KVwzNlnzTF1BmVUzoueFK/w2qvF1inXC5w/+32OHSyXJDbFDQVF l8oIPkXNBOMGXv0PP5debAgDAAA= X-CMS-MailID: 20200710070306eucas1p188f37839cc01836fedcafde66583e968 X-Msg-Generator: CA X-RootMTR: 20200710070306eucas1p188f37839cc01836fedcafde66583e968 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070306eucas1p188f37839cc01836fedcafde66583e968 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 11/25] examples/ip_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications: * ip_fragmentation * ip_reassembly * l3fwd-acl Signed-off-by: Ivan Dyukov --- examples/ip_fragmentation/main.c | 13 +++++-------- examples/ip_reassembly/main.c | 12 ++++-------- examples/l3fwd-acl/main.c | 12 ++++-------- 3 files changed, 13 insertions(+), 24 deletions(-) diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c index 4afb97109..18a6df77e 100644 --- a/examples/ip_fragmentation/main.c +++ b/examples/ip_fragmentation/main.c @@ -593,6 +593,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -612,14 +613,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up .Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index 494d7ee77..910c89ae3 100644 --- a/examples/ip_reassembly/main.c +++ b/examples/ip_reassembly/main.c @@ -712,6 +712,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -731,14 +732,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index f22fca732..ddfec9487 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -1815,6 +1815,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1834,14 +1835,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73696 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8C60A0526; Fri, 10 Jul 2020 09:04:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 643011DDB1; Fri, 10 Jul 2020 09:03:11 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id CA8C61DDB1 for ; Fri, 10 Jul 2020 09:03:09 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070309euoutp01533ed3a9c79d7e33ebc055118cf86770~gUiWeZ7Jc2059620596euoutp01Y; Fri, 10 Jul 2020 07:03:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710070309euoutp01533ed3a9c79d7e33ebc055118cf86770~gUiWeZ7Jc2059620596euoutp01Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364589; bh=q3R1NjSfULTkmVfHv5xauRfm4wQ4m9PAU/4z8Fmz1iI=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=P89OWLX1c7BhmHPDnIsIOYXpw7T0tRBoIZVCyb5J6nPZr4Aewqm4K05AlvwzkiTiy O0nCm9z4rkz1JESPMyJxD5hMUfkVtkbvZNHWHvxyj4Bk44nrg/eQmLhFUN0zGw52Qv 4nJ3OH7tsHiBaAS6JtO8mSCbrCQZxHlgNsGs1tAY= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200710070309eucas1p2c340f84e50498a3550ab581b38f787f1~gUiWBbCZ_2518125181eucas1p2R; Fri, 10 Jul 2020 07:03:09 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 46.4F.06456.DA2180F5; Fri, 10 Jul 2020 08:03:09 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070308eucas1p1fe7a14edec5a90560e8e4f9284ce1796~gUiVpVVDa1630516305eucas1p1S; Fri, 10 Jul 2020 07:03:08 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070308eusmtrp14bab06aaa1dcd7f9aed7eb6b620e3de1~gUiVn40GM1176811768eusmtrp1P; Fri, 10 Jul 2020 07:03:08 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-0d-5f0812ad6a29 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F2.94.06314.CA2180F5; Fri, 10 Jul 2020 08:03:08 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070306eusmtip107231c90cb33a6f31a8d464bf9bed110~gUiT3GddH1602216022eusmtip1K; Fri, 10 Jul 2020 07:03:06 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:10 +0300 Message-Id: <20200710070226.6045-13-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUzMcRzHfX/PHWc/x/QdyZwhNg9h9mHyNNmPNbP5i03nh98u9GB3Qgw3 o9qVc8qYkFyI1HpwXLUkN3pw5ZTVYeQ0k0J1Pank4a7fmf/en9f78/58vvvsy5GqdGYKtzf2 oKSLFaPVjIJ6WDXknJ+v4jSL3rbQUFCXiaC1JZsE94X3DKR0nybgde5qKLddpSHtg4EAU5qH ANsdIwPf3Kco6OyxEfDukYOFjMZTLPTY21g467yCoG2kg4TLWb0InJkPaBh6UsZA14iFAtNw E4Jz1hoE1akeCi6UliBINPLQfTeHhex3wdDjrqHA8eY+C3n9DSQ8qPuF4Hx1AYL6xD/0mhnC cNYtWsgubyeE9BsNpFD15iIrpNZmEkJRZwkhdFU0MYLJmouE560ppHDv0yCzRbFdsXKPFL33 kKRbuGqnIqroYwZ9IH38ke8dYQbkGGtEARzml+LmqhzSiBScir+DcIrpMSMXfQjf+Gig5KIX 4YHaPvZfpPDpI9qnVXwOwqU//Yl+r25vJXwGw4dgR3Im4TMm8UUMto24Ro2JfASuz3MyPk3x s7DH4hmdquSX497HBlreMB3fK6wkfTrAy88YLay8LRi7rveNDsV8HYfzBwykHFiPuwadlKwn 4o5qq/+pQdiRnurnx/CPYhcrh5MRbrGc8TetxtavL7ya40h+Li4oWyjjtfhmUh7jw5gfj19/ n+DDpFemPbxEyliJkxNVcrcaV9Y2+jHGv36Ok7GAv7huI/k+5d4jPrtGmtH0jP+7shDKRYFS vD5GK+lDY6XDC/RijD4+Vrtgd1xMMfJ+Vcfv6p4S1N+4y454DqnHKUv+MBoVLR7SJ8TYEeZI 9STlunpHpEq5R0w4KuniNLr4aElvR1M5Sh2oXGJp36HiteJBab8kHZB0/1yCC5hiQGarRlzC Nt9MMmVsXTtCb9tUfDKhNLLRWh9ScbzOPJy0xR11wjO7G9yLw1es06zaFeSqrAjf1pL6fuP9 eVRxwFN7f0iNuB5tMk/d9yk/R3N3bMQrQ2vQ5w2dwdPGaJc1zyxrGwxvitSuLGx4aQ4kwyaf rrDVXroovlBvvs3EzRGvqSl9lBg6j9Tpxb8OZznQpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTcRDG/e/ZosW1oG4w8aiR4FUthx080Phg1sQHEl88UGxgoQTakm5p BF/qAZKCeOARxVRulJJwVSkGUIopQiEEDIoRFAmKIiqlmCii2EJ8+2W+b2a+ZEaES6eJIFGS 1sDrtaoUGeVHuP62D22tkopitzs/BkN1lwXByNsSHIavD1GQM3kBg4HKvdDUcJeEa+9MGORd c2PQcN9MwcTwOQK+TTVgMNjsouFO3zkaphxjNFzqKUAwNjuOw+1CD4Iey0MSfrU+puD7bDEB eTP9CC7bniNoz3UTcL3RjiDLzMDkgwoaSgZXw9TwcwJcr+tpqPrRi8PDrj8IrrZXI+jOmiP3 reNmCstIrqTpM8blF/XinPP1TZrL7bBgXO03O8Z9b+mnuDxbJeI6R3Jwzjr6k4r2Oybfrdel Gfi1ap1g2CM7roBQuSIS5KHhkXJFmPLEztAI2bao3fF8SpKR12+LOiVX176/Q6bm+5/+Or7H hFyLzUgsYplwtuZZM+ljKVOG2LqaI2Yk8tZZ9ssovmAJYGdfmikz8vNaPIgdz+2a91NMCOvK tmA+IZB5Q7EvLp4lfEIAc4jtruqhfEwwG1h3sZv2sYSJZD1PTOTC1DWstebp/Aaxt55pLqYX QqhZx2Q5WuDV7Kt709gV5F+IFlWiQD5N0CRqBIVcUGmENG2iPE6nqUPeiz9y/qq3o77aww7E iJBsicQ+R8VKSZVRSNc4ECvCZYGS/d2uk1JJvCo9g9frYvVpKbzgQBHegFfxoOVxOu//aA2x igiFEiIVyjBl2A6QrZRkM60xUiZRZeCTeT6V1//vw0TiIBPaVWHLJs19mcZPNxq3bGbSM50J Bz9Yzxf87M9Y6h/eH23SpazPebzJmtCXtYMrcrV1YW1NHROb/+aX1j9Z0erupXdufNXJz8bb z6h/lzvffT3qTgx5VmC71TaosseJywYutcZ16ollyUOmSU2C1GCMWuU5oEy1BA+Uxtg8LXVq GSGoVYpNuF5Q/QPBSpDhBwMAAA== X-CMS-MailID: 20200710070308eucas1p1fe7a14edec5a90560e8e4f9284ce1796 X-Msg-Generator: CA X-RootMTR: 20200710070308eucas1p1fe7a14edec5a90560e8e4f9284ce1796 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070308eucas1p1fe7a14edec5a90560e8e4f9284ce1796 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 12/25] examples/ip_pipeline: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ip_pipeline/cli.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index d79699e2e..ca461ea0c 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -249,7 +249,8 @@ print_link_info(struct link *link, char *out, size_t out_size) struct rte_eth_link eth_link; uint16_t mtu; int ret; - + char link_speed_text[16]; + char link_status_text[10]; memset(&stats, 0, sizeof(stats)); rte_eth_stats_get(link->port_id, &stats); @@ -268,18 +269,19 @@ print_link_info(struct link *link, char *out, size_t out_size) } rte_eth_dev_get_mtu(link->port_id, &mtu); - + rte_eth_link_strf(link_speed_text, 16, "%M", ð_link); + rte_eth_link_strf(link_status_text, 10, "%S", ð_link); snprintf(out, out_size, "\n" "%s: flags=<%s> mtu %u\n" "\tether %02X:%02X:%02X:%02X:%02X:%02X rxqueues %u txqueues %u\n" - "\tport# %u speed %u Mbps\n" + "\tport# %u speed %s Mbps\n" "\tRX packets %" PRIu64" bytes %" PRIu64"\n" "\tRX errors %" PRIu64" missed %" PRIu64" no-mbuf %" PRIu64"\n" "\tTX packets %" PRIu64" bytes %" PRIu64"\n" "\tTX errors %" PRIu64"\n", link->name, - eth_link.link_status == 0 ? "DOWN" : "UP", + link_status_text, mtu, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], @@ -287,7 +289,7 @@ print_link_info(struct link *link, char *out, size_t out_size) link->n_rxq, link->n_txq, link->port_id, - eth_link.link_speed, + link_speed_text, stats.ipackets, stats.ibytes, stats.ierrors, From patchwork Fri Jul 10 07:02:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73697 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B24A4A0526; Fri, 10 Jul 2020 09:05:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 884AD1DDC8; Fri, 10 Jul 2020 09:03:13 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 2520D1DDBE for ; Fri, 10 Jul 2020 09:03:12 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070311euoutp014bd93e56914439af51884f987a5eaf48~gUiYkWm4l2059620596euoutp01Z; Fri, 10 Jul 2020 07:03:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710070311euoutp014bd93e56914439af51884f987a5eaf48~gUiYkWm4l2059620596euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364591; bh=1YhjGGZIH+BiDd1vuZIqrQ6NKJL1whpE3mlU+Xfl3zM=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=hdULp/RYzS1Hq4AxIQO8eNzRhS9zQwNH08N6AB+Y2bLB6bfLnTnH4/IKYO52hacmp aKgCWcx/f95lgQgWm1F1JHTTj9FusD/+a5SqlJU+b2+CfHotAK/iR09CvJxyClcxUy 7fufVYuP83rmJvF75Cm9bdvpt7u22JRRDWERAzlY= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200710070311eucas1p23e713d35f432df6f102126ce3f713dbe~gUiYVU6C22518125181eucas1p2W; Fri, 10 Jul 2020 07:03:11 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 59.4F.06456.FA2180F5; Fri, 10 Jul 2020 08:03:11 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070311eucas1p1f7b48a83f9976449006af9bf453204d1~gUiX-e7GN2075420754eucas1p1G; Fri, 10 Jul 2020 07:03:11 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070311eusmtrp1c5aece4373c8ed22622ea491a233d9ae~gUiX_Rnx_1176811768eusmtrp1T; Fri, 10 Jul 2020 07:03:11 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-12-5f0812af6427 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 41.14.06017.FA2180F5; Fri, 10 Jul 2020 08:03:11 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070309eusmtip1339679f8fd94dce7a43e4af542ae668c~gUiWPqiuT1544015440eusmtip1i; Fri, 10 Jul 2020 07:03:09 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:11 +0300 Message-Id: <20200710070226.6045-14-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0xTZxjG855zes6hUncsGL6o0VlDspmoEF32SrxMoslJdInMJcuWKFY9 ASOgaQFvcTYq2JSLs6JD3ABLHAhmRaG0KN6aaIFKDY0MGBUrmoBMuVSIykClPTX+97y/5718 efLxtLqIncPvzsiUdBnaNA2rZBruv/Mssar55LizVV+i9UEpYF9vBY3+oscs5o2coLCrei02 2f9QoPmJgcJC8yiF9ioTiy/9xxgcCtgp9N10c1jiPcZhwNnPYcHDC4D9k4M0ni9/Dfiw1KbA d3evszg8aWGwcKID8FR9M6Arf5TBokYHYK5JwJHLlRxW+OZjwN/MoLu7jsMr4+002h5MAZ52 WQHbcj8ovlsoTpRfUogVTS8o8czFdlq8332OE/NbSinx6pCDEodvdbBiYX01iK19ebRY8/wt u1n5i3LVLiltd7akW7ZmuzJ16qkb9tUoD5QM5VAGKOdNwPNEWEFyy741gZJXC1VAHv1tpuRi DMjEiWZWLl4DqR14rjBBRGii/Z+ntGxUAnF2tIRHxoEY/BOhLlb4iriNpSEjWrjKEvtkJxU0 ooRNZOB4AQQ1I8QST5+VDWqVsJJ4jb2cfGIBqam9Qwd1xDTPMVlCXC3MJ51lY6GlRGjmyT2f M/ym9cQzYAjrKDLoqg8vmkfcZ/IZWR8mb651cvKwEUivJSfctJbU/+fhgnHQwtfEen2ZjNeR Z8U2hZzSTNL1alYQ09PS3PA7LWMVMeaq5W4NudPiDWNCpv6PlLFIjI9vcHI+TUBOGqvhN1hQ 8vlWOUA1xEhZ+vQUSR+fIe1fqtem67MyUpbu3Jt+Dab/qvu9K+CAce8OJwg8aCJVjg9sslqh zdYfTHcC4WlNtCqxzb1NrdqlPXhI0u1N1mWlSXonzOUZTYxqueXFVrWQos2U9kjSPkn3yaX4 iDkGiPyx7Zuf8YssqTHu/bCQN/aytjjuQHzrOTry+w0JjqNMwJFU7LcssscYLx+JCqSenrpp /0E0d+etH7xncSZJGwoTVZ6ELaNbfo1dkp3ofbLN1/vqr9U5Nlv3Sdb60+zsjZqzvtn/xik2 1rm0vpH+6J5HMeZLxbfHG3sSWmf0HKb+1DD6VG38Ylqn134E+p5BCKcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d+/Vmtym1Q8Lq1tBBM02tZ1F2eOPuFKBYPRHLxt6cZFz sTsj+8uslc33g0orm4plLrLS0sqijchqWmlpRmpzGJXJfKx3ak2l/77nfL7nAeewpOI7Fcru TzGLphRdMk8HUq6J5p6VtQo2flV270yobSlD4OmtJMFd3END1vBxArpq1kNTw3kZFL5PJyC3 cISAhmorDYPuDAq8ow0EdN93MVDansHAqPMjAzkvziH4ODZAQonNh+BF2S0Z/HLcpWForIKC 3N8dCPLqnyBozh6hoPhOI4ITVg6Gr1xmoLI7DEbdTyhwva1j4Oq3NhJutYwjKGiuRdB64q9s w2Lht61KJlQ2fSaEovI2Unj89jQjZD8tI4Qb3kZCGHrQQQu59TVIeObJIgV7/086NnCncq3J mGoWF+mNknkdv0sFaqVKC0p1pFapitDsWaOO4sOj1yaKyfsPiabw6H1K/XifCx20Bx4u9VqI dGRjrSiAxVwkbuvsI60okFVwVQifqn7pD1g/wPhLPzntCcZjnVZ62uND+KwvA00CmluOXZll xCQI4d7R+NXJo9QkCOa24k/HcqZMFLcMP/fU0pNazmlxe2YvM911IbZffzg1IcCft1grpvIK To+dw5fQtA7Dby5+JfJRkA3NqEEhYqpkSDJIaqWkM0ipKUnKBKPhJvLf/PbjX/WNyOqNcyKO Rfws+b5xOl4h0x2S0gxOhFmSD5FvanXtVcgTdWlHRJMx3pSaLEpOFOVfsIAMnZNg9H9Qijle FaXSgFalidBErAZ+njyTc+xWcEk6s3hAFA+Kpv91BBsQmo62eEq3L2BKLJd91dFLBoS6Ca4v tuizeY/DlXv9TKtnbtvAbHsk7ifUTEb45qXXtM/mWwY7HjU3JQbc28j2XFj9AG/7EJMfd+7K j7zEOqqqO4YLNlXerM6x6739ae6dod/0KyZuO/k/XarXixJ2mFsI/ka5w1F48pHeF9Q31GXh KUmvU60gTZLuH34zq60JAwAA X-CMS-MailID: 20200710070311eucas1p1f7b48a83f9976449006af9bf453204d1 X-Msg-Generator: CA X-RootMTR: 20200710070311eucas1p1f7b48a83f9976449006af9bf453204d1 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070311eucas1p1f7b48a83f9976449006af9bf453204d1 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 13/25] examples/ipsec-secgw: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ipsec-secgw/ipsec-secgw.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index f777ce2af..551838229 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -1775,6 +1775,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1794,14 +1795,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73698 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66658A0526; Fri, 10 Jul 2020 09:05:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C7221DDE6; Fri, 10 Jul 2020 09:03:16 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id E12721DDE1 for ; Fri, 10 Jul 2020 09:03:14 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070314euoutp024ee6f412886bf339f86119ccbcbea720~gUibNp6o91730917309euoutp02f; Fri, 10 Jul 2020 07:03:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070314euoutp024ee6f412886bf339f86119ccbcbea720~gUibNp6o91730917309euoutp02f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364594; bh=Gr1Jcl7miAeWLUh9GahLeLAq7ORJTSLyxj+MvXGXDw4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=uZKPs8BgaHnSAXAAyyNHiVBiZ7eOEvj7JI5z67mByB4YWq3XULtuj0AL9dEkfLD0V cgCts4kwsv4pcj7wWuQu5zGWVUAvEGWqSHg0Wqg9Oo10a9sVXQARfr3M/2ilXsgC6C 9DRD/bX4uGrJzTiK66GGqOW+FqLae7Gtwvbfnz5k= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070314eucas1p1a8337ac28dfad7a9de580bd1d6867391~gUiavneiS1964419644eucas1p1L; Fri, 10 Jul 2020 07:03:14 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 98.41.06318.2B2180F5; Fri, 10 Jul 2020 08:03:14 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070313eucas1p2cbf741d65b0e6dbf25b06db2a490b4b5~gUiaZj1nB1919219192eucas1p2q; Fri, 10 Jul 2020 07:03:13 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070313eusmtrp1c55b51ef500f9d9f2534ac89dfadecc0~gUiaYtMP51176811768eusmtrp1Y; Fri, 10 Jul 2020 07:03:13 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-c7-5f0812b2462a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 94.14.06017.1B2180F5; Fri, 10 Jul 2020 08:03:13 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070311eusmtip1e2fd607af9220719126191583ed7c0bd~gUiYm623v1602516025eusmtip1N; Fri, 10 Jul 2020 07:03:11 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:12 +0300 Message-Id: <20200710070226.6045-15-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSYUxTZxSG8917e++lsdvnhcUzNBpvgpEZ0UVizhYmzpjs/jRxfzSZ2MkN GiliS1GnWRonDSldUZA1do4hbII4h2KxgMg6Ni2uIgM1QALSGDYmaFGQbUDR0d6a/XvPc95z 3pMvn8hKFXyyuC+vQDXnGXNlXs9duzXTvbZRErPWR4p4bLhTSfDRwxoWQ6eHeCx5doLB/vpM bPOd1WHZsI1BV9lzBn11Dh6fhI5zGJ70MTh4Iyigp/e4gJMdowJ+2f01wdHIGItnqqYIdlc2 6XDm51YeJyLVHLpmHxAs9XYSDDifc3i6pZmg3UHx2YVaAWsGl+NkqJPD4MBVAX+Y7mGx6c48 wVOBBoJd9le6zSuV2arvdUpN22NGKT/Xwyq3Br4SFOftSka5Em5mlIn2B7zi8tYT5bdHJaxy ceRffpt+pz4jW83dV6ia123ard9733mXz/+VHm4pmxNspNTgIAki0HTo+aWFcRC9KNE6Arab 1+PFCwI/2t2CVkwRuOr9Tng9Uuc5z2mNWgJhfyDumibgnu1noy6eroZgcWVsVxK9woMv0sdE G4l0K7T6wySqOZoCIxUlsQEDfQ/KO2tYLWIFXLzsj+mEBV7kqI5FS3Q59H37IrYU6O8iTNyY id+0FSqaxommE2Es4I3zZRAsd3KaPgr/NPYJ2nAxgYfVRXFTJnjH7y5oUWRpKjS0rtPwh9Ae 6uOjGOgb0P90cRSzC7LsmpvVsAGK7ZLmlsF/uzeOAebnFmlYge7Sxvj7tBEYHypiT5IVnv+z qgipJ0tUq8WUo1o25KmH0ixGk8Wal5O254CpkSx81uDLwHQzaY982kGoSORFht3zfJakMxZa jpg6CIisnGTY0hXcJRmyjUc+U80HsszWXNXSQZaKnLzEsKH68ScSzTEWqPtVNV81v+4yYkKy jfj2uEfGBj7yVwytffrm5e3D7287c0lK3NHllD9PHthpzrBnZGY3GJyjnjX3SsLfnLWfWJ36 1ub8ky0m118p7lVTb4suua33j1LryJqfxuWV1ukPCjfSocV/X1+akn7Uc+xPJk13bDD1XE5o R0HS/SY6vCmr+eAXN1Nt8pO5j9MvLdu+X+Yse43vvsOaLcb/AKujg9WoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSf0yMcRzHfZ/nueeemmvPrqyvmLhhzepyJX3OiFm2h7GFjU3pHD266Lp2 z+VH2CpJey5RfmxKSTdJWYnSlVjdTOnyo5SfRWgM6aesn7iK/177vN6fzz7b58OQ8l+UBxMV Y+KNMdpoBe1M2X/Xd/iUyRnN0uOt3lDalIvg4zsLCZ3nOmgw9yUT8KpoNdRUXpJA5vsEAtIz +wmoLBRp6O5MoqBnoJKA9nt2KWS1JElhwPZFCqeeZiP4Mv6NhIt5gwie5lZIYKSumobe8XwK 0kfbEJwub0BQn9ZPwbkqK4IUkYW+69ekYGmfBwOdDRTYX9+Wwo2hZhIqmiYQZNSXInic8key ZgE3mndVwllqvhLc2SvNJPfw9QUpl/Yol+DKeqwE13u/jebSy4sQ1/jRTHLFXcN0iPMO5Uqj Ic7Ez9cZBNMqRagK/JQqNSj9lqmVKv/AnSv8AhS+QSsj+OioA7zRN2iXUtea9oSOfcAeqsoc kyag0zIROTGYXYYLswooETkzcvYqwo31OYSIGIfA+HsXOZ1xxeMvRHo6M4jwnYxf1KSgWS9s T80lJoUb+5bGz08mTglXNhhX1/agSabYRbjrvHlqkoxV47MNln9TPXHxzdopdnLUT4j50kmW szps6ytA0zwPv7z8kziDXPLQjCLkxscJ+ki94KcUtHohLiZSucegv4UcN7/zcKTcisSerTbE MkgxU7ZrgtbIJdoDwmG9DWGGVLjJ1j62h8tlEdrD8bzRoDHGRfOCDQU4FswgPWbtMTg+KMak UQWoAkGtCvQP9F8OCndZKlsXJmcjtSZ+P8/H8sb/fQTj5JGA/I+sc2/P+XTsx7Ox/lRz6DZx c1rI+bK6mg5NfHL13eULsy+2j3wg5+wuSdx+bGgfW/7pfolX/nr78CqfoYPhY3sjGgfVYVjX EdwS1f9muNZ6wXP2hwmXjRUBZkuLx4a9c9O95flH73W7fF28wbv1yJbCTb1Uxt2Ct832z6FZ Q/ut1RIFJei0qiWkUdD+Ba7pJ88JAwAA X-CMS-MailID: 20200710070313eucas1p2cbf741d65b0e6dbf25b06db2a490b4b5 X-Msg-Generator: CA X-RootMTR: 20200710070313eucas1p2cbf741d65b0e6dbf25b06db2a490b4b5 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070313eucas1p2cbf741d65b0e6dbf25b06db2a490b4b5 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 14/25] examples/kni: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/kni/main.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index f5d12a5b8..8ad7fb532 100644 --- a/examples/kni/main.c +++ b/examples/kni/main.c @@ -661,6 +661,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status\n"); fflush(stdout); @@ -680,14 +681,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %uMbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ @@ -717,19 +713,15 @@ check_all_ports_link_status(uint32_t port_mask) static void log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link) { + char link_status_text[60]; if (kni == NULL || link == NULL) return; - if (prev == ETH_LINK_DOWN && link->link_status == ETH_LINK_UP) { - RTE_LOG(INFO, APP, "%s NIC Link is Up %d Mbps %s %s.\n", + rte_eth_link_strf(link_status_text, 60, NULL, link); + if (prev != link->link_status) + RTE_LOG(INFO, APP, "%s NIC %s", rte_kni_get_name(kni), - link->link_speed, - link->link_autoneg ? "(AutoNeg)" : "(Fixed)", - link->link_duplex ? "Full Duplex" : "Half Duplex"); - } else if (prev == ETH_LINK_UP && link->link_status == ETH_LINK_DOWN) { - RTE_LOG(INFO, APP, "%s NIC Link is Down.\n", - rte_kni_get_name(kni)); - } + link_status_text); } /* From patchwork Fri Jul 10 07:02:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73699 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89CB5A0526; Fri, 10 Jul 2020 09:05:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A94F51DE13; Fri, 10 Jul 2020 09:03:18 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 532601DE09 for ; Fri, 10 Jul 2020 09:03:17 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070317euoutp010bf70db3b55d245f1484d8e71df64d80~gUideKVJu2063820638euoutp01R; Fri, 10 Jul 2020 07:03:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710070317euoutp010bf70db3b55d245f1484d8e71df64d80~gUideKVJu2063820638euoutp01R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364597; bh=0KRTz2AP5FV+jHZTStTVbtq12s0MKBOah3XGntzISPk=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=M+ZEnQbik0iLTtqAzO02qBU3NDmJUxb3IpWVFSMIDtsTGjFdT0nTLw+0l7MQUDNPX dX6dHblqBfvJ1eKOWa7n0ldgoh4UUEgvud9b5pp9lm8+Zn9fB3xgA8zGZH6Q1v0Ht0 LMsp7yKM7qAC21x23QyyxebmeZwOrHyO0s7d2blY= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070316eucas1p1ddf7cc869bec67040a88bdb1ab9cff60~gUidQ6L841630516305eucas1p1e; Fri, 10 Jul 2020 07:03:16 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id A5.48.05997.4B2180F5; Fri, 10 Jul 2020 08:03:16 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070316eucas1p284d925e1ce4839ff2c850c5e82e6fc48~gUic0BqTR1909319093eucas1p2w; Fri, 10 Jul 2020 07:03:16 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070316eusmtrp1e8b8b6c8473233f88dba172738536985~gUiczJvB71176811768eusmtrp1f; Fri, 10 Jul 2020 07:03:16 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-58-5f0812b49d90 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B9.94.06314.4B2180F5; Fri, 10 Jul 2020 08:03:16 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070314eusmtip11471b4bba7690a3b80a4cc293b962803~gUia_7WDA1592215922eusmtip1U; Fri, 10 Jul 2020 07:03:14 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:13 +0300 Message-Id: <20200710070226.6045-16-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSWUwTURSGc2emM0O1Og4mXnFBKySKKbg9HBL3mDgxrvHFaFiqjmDYtCOK +iASWSyLWoniQsXiwqKyFcrmRiIFCmJJsBhRG2LcEQQMQkGlDMa37/zn/P89ObksyV+gvdiD 0UdEXbQ2Uk0rqYr6oecaM8+GLOn5tgSKmo0Iut7mkuDMfENDau8ZAjoK1kCt5boCDO/iCcgw /CDAkqen4ZszgYLvfRYCOh/aGLjalsBAX91HBtJbryH4OPKFhCs5/QhajeUKGHpaTUPPiImC jOF2BOfMDQisaT8oyKyqRJCk56A3/y4DuZ1zoc/ZQIHtVRkD937aSShvHkVwwVqEoCXpj2Lt fGE457ZCyK39TAgXb9pJof7VJUZIazQSQsn3SkLoedROCxnmAiQ0daWSQuH7X/R25W7lyv1i 5MGjoi5gdagy3GmqYQ6lK+OedViIeJTA6pEHi7kVODnrpkKPlCzP5SF8w+Kg5GIAYaPz5UTR j7D901dGj9hxS3lWgKzfRTgzu5uRi58I5zfXUO5cmluIbSlGwt2YzpXQ2DLiINxuT24zHq0f n6E4XzxY4lC4WcUF4tvWLFreyRsXFj8h3ewxpifqTYybeW4udtwYGM/EXAOLm1r6JzbagDtr tsteT/zFamZkno1tF9MomU/iwVIHI3tTEH5rSpwYWoPNX5+P55DcIlxUHSBHrsPJ6TtknII7 uqe5h8kxNFRcJmVZhVOSeDlDjZ80tk3IGI+6JsuygF1lBkI+Tu3YpbpTqfPI++r/p3IQKkAz xFgpKkyUlkWLx/wlbZQUGx3mvy8mqhSNfVTbb+tAJaoe2VuHOBapJ6tCR+kQXqE9Kh2PqkOY JdXTVetbbMG8ar/2+AlRFxOii40UpTo0i6XUM1TLTZ+DeC5Me0SMEMVDou5fl2A9vOLRTu8Y za74O6+zV/nESb6aTdumvgv3cd1rmDk/8Pq8oQ/K0hetpx4PNK2n7V67tGfJsuLAio2Fw0GN pxdMKnalLtCUvQyqsvOec7YOT1lMltwyiOGHg5NrEze5RD47wq9JTPb12ajo9Rb2HDCdGDyb mXvfB65YZxXv2fLgdMFgpYZVU1K4dqkfqZO0fwGesut7pAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzVSe0gTcRz3d3e7ndbqmkbHiNSLIIxm87WvvYuIK4KCIHvb0EMj5+RumhaR iVosXe/QrLkU0zQyS9uqWbnQWbNEzUdoNUKKzGq+KMOyrdF/Hz6v7xe+XwqXjxMK6mCqnhdS NSksGUA4/zjeLq2XU/HLvlbNgdo2E4IP78pxcF18S8Jpdy4GfdVrwGa5KoHz77MxMJ4fwcBS ZSBh2JVDwLdRCwYDjU4pXOnMkcKo/ZMUCttLEHyaGsKh2DyGoN3UIIHJpockfJ8qI8D4qxvB mfpWBI6CEQIuPrAiyDfQ4L5ZKYXygQUw6molwPnmnhRuTXTg0ND2G8E5Ry2Cl/nTkrWh3C9z hYQrt33GuAvXO3Cu5c1lKVfw3IRxdd+sGPf9cTfJGeurEffiw2mcqxn8SW4L2K1cKejS9XxI sk7Ur2L3qCBCqYoFZURUrFIVqd63PCKaDV+9MpFPOZjBC+GrDyiTXWWPpGmFAZnNfRYsG+VQ BkRRDB3FNBSFG1AAJacrENPelUv6eIb5MogbkL8HBjJTPQbS5xlDzLMLZVKvQNKLGecpE+YV guh+kuk6eYLwhgPpLczvFsLrIehFzI+6XokXy+hYpsJRRPpKg5maO0//DfD38HkGX6ecTmbs 7hvIhxcwvaXj2Fk0y4z8qlEQny5qk7SiSilqtGJ6apIyQae9izwXv98yec+KOuu22xFNIXam zDpNxsslmgwxS2tHDIWzQbL1L5375bJETdYRXtDFC+kpvGhH0Z4Fz+GKuQk6z/+k6uNV0So1 xKrUkerIGGDnyU7RTXvldJJGzx/i+TRe+J/DKH9FNjJpnoRmsjtfH3/lLv94zTjUrRw/bF61 i0oL6Rm+VFzqVx1yo+WYrnLhe2GJ+qqlcbSuPy/7yKPC+Zse+Mfs0DpqSjaUTlMrota2iXmK GWlTcX59i1y22Wrb5tvNjyeK+cKNxbMtYXosbmvuQGcn1+Y3N3igMT/DnLNP6F3HHrV2sYSY rFGF4YKo+QtNz7syBwMAAA== X-CMS-MailID: 20200710070316eucas1p284d925e1ce4839ff2c850c5e82e6fc48 X-Msg-Generator: CA X-RootMTR: 20200710070316eucas1p284d925e1ce4839ff2c850c5e82e6fc48 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070316eucas1p284d925e1ce4839ff2c850c5e82e6fc48 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 15/25] examples/l2fwd-crypt: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-crypto/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 827da9b3e..7648ea027 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -1734,6 +1734,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1753,14 +1754,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73700 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BD15A0526; Fri, 10 Jul 2020 09:05:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 11FCF1DE4A; Fri, 10 Jul 2020 09:03:21 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 0DAA91DE45 for ; Fri, 10 Jul 2020 09:03:20 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070319euoutp02aaf69da07572beaa851fd30855879321~gUif9E6ei1730917309euoutp02g; Fri, 10 Jul 2020 07:03:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070319euoutp02aaf69da07572beaa851fd30855879321~gUif9E6ei1730917309euoutp02g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364599; bh=srhawFEXUKW2qnG3XOlQI1DTOaaunL+pDywNZ8YTyIM=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=qt0MSeE+6BZLJAYe9lScI9daOOlIYLXmPjahE9Eu74WY6zmCzr9cuHptaXFPUch5N cloHxYTRGbXloeVSxrSCrmYMpvZn4EuROriT3xNUoUsP3HHp+g91J+gadHpFuDHLyA 6OlU8xx8Fu+sOQNhk2qEyrFTyp9ug/hhQXRGNcto= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200710070319eucas1p203f567d14fe9c51c738257b384a1faca~gUifgBpQN2446524465eucas1p2Z; Fri, 10 Jul 2020 07:03:19 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 08.48.05997.7B2180F5; Fri, 10 Jul 2020 08:03:19 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070318eucas1p29f8796805d5dc353553acf0e8cd4dd40~gUifJ1H712518925189eucas1p2T; Fri, 10 Jul 2020 07:03:18 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070318eusmtrp1c03302b8e2b2d4f1bbe205f602661b5e~gUifI5O081113611136eusmtrp1J; Fri, 10 Jul 2020 07:03:18 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-5d-5f0812b70d0a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id E8.14.06017.6B2180F5; Fri, 10 Jul 2020 08:03:18 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070316eusmtip1605a8d4d01f18cdc0894691f7102fcc2~gUidVPQbM1340413404eusmtip15; Fri, 10 Jul 2020 07:03:16 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:14 +0300 Message-Id: <20200710070226.6045-17-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTVxjHc+69vffSWHZXXHgUhdBkZmh8YbrtIWEojGT3w7KQfdFIECvc oJEX04KbOiMCRVJomZVsymaprRsVTXix0EKQADGgFsY0IpqAVjMxyFApkA0oOMrF+O13fv// k/Pk5PC02sKu5Q/l5ku6XG22hlUyLT2zA5vdaj59W+vEB1jfZyX47LGDRl/VCIvlb0oofFi3 E9vdvynQ8qSQQrNlkkK308jiP74iBl/53RQO3/ByWH2viEN/9wsOTQO/EnwReEnjBdsUwQFr swJnu9pYfB2wM2ieGyRY6bpFsLdiksGqVg/BUqOAb67UcugYjkS/7xaD3kfXObw2c5fG5r4F gmd76wn2l75V7IoW52y/K0RH+xglnrt0lxZ7Hv3MiRW3rZTY+MpDia87BlnR7Koj4p1n5bR4 9e//2BTlXmV8ppR96Kik25qwX3kwUNtJH7Eqf6jssFKF5CxvJCE8CDugY2ReYSRKXi04CRhM 1YpgoBamCYxOfSHzFIHx4dR3A2bbW1YeqCXQ4Jyh5MMMgcvjDi7YYoVPwFtmXQ5WC40suAND VDAIE76BxdHi5RIjfAxnyl3LXiXEQcDgoOQrouBqQycd5JAlbzDaOXmNSBiqmV7p/MXD/Z71 MidDQ1fzig+Dl70uTuZ14D1Xwch8Av5tGuKCC4FQRuCx3bBS2gmu8T+XmOdpIQbq27bKOhHm m0YVQQ1CKDyc+DCo6SW0tPxCy1oFZaVqua2Bztv3VjTAwvwqWYvw5LmTk5+nnUBRzSD5iURV v7/LRkgdCZcK9DlZkv7TXOn7LXptjr4gN2tLRl5OE1n6qd7F3mkPaQsc6CYCTzSrVPsX2HS1 QntUfyynmwBPa1arkvq9+9SqTO2x45IuL11XkC3pu0kEz2jCVdvtY2lqIUubLx2WpCOS7l1K 8SFrC4kjyn/G8MeP0um4mxfTHHMxzw2jN31DNWMl0478b5M83518ui+5sOWEe11o167ZL2N3 71jTt+Ej08DTz9OdvpNt9ztHEvYkdlVtjLdZKhsyopM++/rOYOImT0RUnumricjjCWGZ8ZVT xQbrwmV7ymJ03WS4kjnlf3DjfOiaVPfeHlOyWcPoD2pjN9I6vfZ/m9NY6qUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH/d17d3eVFpeb0U3CclBJ5OpObWfRw4riEhKSRNFLR940dC52 p6SQmeWDqbPZW2NZq6xVmKVpYWaL0lpWKpXmE7PMLDXtYTK1qfXfl/P5fs85cA6FM78IL2pf rEHQx2pi5KQH4RirbvW7y1BhS1+f5qDohQVBZ5sVh44TrSRkDhzFoNG2GirKzkkgtz0ZA1Pu dwzKrhpJ+NqRQkDfYBkGLQ8cUsirT5HCoL1bCtmv8hF0O7/gcLZgCMErS6kE/jy6T0K/8yIB ppE3CHJKahBUZ30n4MS9cgRpRhoGrhVKwdriDYMdNQQ4mu5I4cbPOhxKX4wiMFcXIahNG5cE +fAjBZclvLWiB+OPX6jD+adNp6R81jMLxhf3lWN8f+UbkjeV2BD/vDMT5693DZMhHtsVK/S6 OIMwL0onGlbKd3CgVHBqUCgD1ArOX7VruTJQvmTVigghZl+8oF+yKlwR5SyswvdbPA7kVFqw ZGSmjMidYukA1lQwThqRB8XQlxHbaEshjIhyAZbt7cKnPDNY51vjP88QYocvVWMTgKR9WUeG BZsAnnQzyTakHyYmwAw6mB37dEQ6oQl6PpueWTIZkNFq1plqxaa6zmWv36qanODuqqcaL076 GTqKtQ9cQVPam313/gd2DE0vQG425CnEidpIrahUiBqtGBcbqdij095GrpvfffqnpBwZ+0Lt iKaQfJosfJQMYySaeDFBa0cshcs9ZWtrHbsZWYQmIVHQ68L0cTGCaEeBrgXNuNfMPTrXB8Ua wrhATgVqTuWv8l8G8lmyDPrRToaO1BiEaEHYL+j/5zDK3SsZbeo5tqGhOfh3dvHe/mtrkxqe +GbmJ730PcnU35wzNL6GMa/3e+ZjnZV3MPzxh23KlsQhc+Hj0BCNfnPZbJUzZWHNgjPretvb qN5d7cKVLUmXvsVEfzy+rnYDcswerbdFp+oi6nLdHjZ1VuSrTZ+9tWmLgw4FVxXXbG3kEls2 vg8oqpQTYpSGW4TrRc1fqT3ubAkDAAA= X-CMS-MailID: 20200710070318eucas1p29f8796805d5dc353553acf0e8cd4dd40 X-Msg-Generator: CA X-RootMTR: 20200710070318eucas1p29f8796805d5dc353553acf0e8cd4dd40 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070318eucas1p29f8796805d5dc353553acf0e8cd4dd40 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 16/25] examples/l2fwd-event: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-event/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c index 4fe500333..3e6d1c311 100644 --- a/examples/l2fwd-event/main.c +++ b/examples/l2fwd-event/main.c @@ -366,6 +366,7 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status..."); fflush(stdout); @@ -389,14 +390,9 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - port_id, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", port_id); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", port_id, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73701 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FDEEA0526; Fri, 10 Jul 2020 09:05:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 42EC31DC44; Fri, 10 Jul 2020 09:03:23 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 9C2401DB1B for ; Fri, 10 Jul 2020 09:03:22 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070322euoutp022d754b87cc8f08dfec0861607098ceea~gUiiZ_aDN1750117501euoutp02O; Fri, 10 Jul 2020 07:03:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070322euoutp022d754b87cc8f08dfec0861607098ceea~gUiiZ_aDN1750117501euoutp02O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364602; bh=mj3hE/gu7NzVbUKqiHTNl/YjUhTA6ayvrigfQL+Dyrc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=WaR7HUvxEcHvbcgSae+OZG/mFNe+alA0FlXV6qXMMbOgGXxyh3nyq+ozCb4Tx77NS aqhnXTFdKTlcSy5L4dWX4dXYoE1P5siax5OUsfduG7r7CWtElZycivyRP+xtfV1TOd HUiZbagO6fL/Y7S3BGAd1jAj0lzQZB3H494kr28o= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070322eucas1p12e261afd9e4899bb4b3927c38e2fb987~gUiiLFCfP2360423604eucas1p1y; Fri, 10 Jul 2020 07:03:22 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 0E.41.06318.AB2180F5; Fri, 10 Jul 2020 08:03:22 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070321eucas1p12d981060206d2964c72c0884e7415e6a~gUihwJF1L2360423604eucas1p1x; Fri, 10 Jul 2020 07:03:21 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070321eusmtrp1a6f5f0fa537baa911b16c512c4ffbe60~gUihp9BEp1113611136eusmtrp1M; Fri, 10 Jul 2020 07:03:21 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-d9-5f0812baecab Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 8B.14.06017.9B2180F5; Fri, 10 Jul 2020 08:03:21 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070319eusmtip138d080059e8d235fb47f979376f24675~gUifzBtHp1336213362eusmtip1d; Fri, 10 Jul 2020 07:03:19 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:15 +0300 Message-Id: <20200710070226.6045-18-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSa0hTYRjuO+fsnONocVqCLxZFg8DsZjd4LelmyPkT9COiorJpB5PctC3N tEAqTZZZ2ejeslloli1rNpOZ5Q+1tkqLmJXaMiu0m/NSaZrpzqJ/z/vc3o+Xj6fVZjaUT9Tv lgx6bZKGVTJ36waezqlS87ERZy/QaHNbCLa3FdHoNbeyeKT7EIXNpcvR6bigwIK3WRTmF/go dJSYWPziPcDgtx4HhS3VLg7PPT/AYU/tJw6PPjtP8NNQF41nC3sJPrNUKHDgYRWL34esDOYP viR4zN5AsD7Px6D5XiXBHJOA3deKOSxqmYo93gYGXa/ucHijv4nGCvcwwRP1NoJPckYUK6aL g4VXFWKRs5MST15uosW6V6c4Me+RhRLLv1VS4vf7L1kx315KxMftR2jxescvdq1ykzJqu5SU mCYZ5i3bptzx4r2dTfkYlF5s8zBZ5A1nIjwPwiIYaWRMRMmrhRICNccqaHnoI+Dp9CnkoZeA /aGFNZEgf8JZ3RgQigm4D3speegnUHbrEjfmYoUwcOVa/EKwUM6CY8hDjQmThBjIrivzVzHC DKi+85YewyohEm52/KTlFdPg+q0Hfhw0ymebrP5StTAVPJf6/KUgNPJQ8cPByIHVUJn1J/C+ SdBVb+dkPAVcJ/MCnkz4edvDyeFcAm3W7IBpOdg/P/WfgxZmgq1qnkyvBFfhVVa+0gRo/jpx jKZHYcHd07RMqyA3Ry27NfDg0fMADTD8e7xMi9DQnB84lpOAo9zKHSfTzv3fVUhIKQmRUo26 BMm4UC/tmWvU6oyp+oS58cm622T0r7r+1PdXkvtDcbVE4IlmvGrbMBurVmjTjHt1tQR4WhOs WvXEtVWt2q7dmyEZkmMNqUmSsZZM5hlNiGqhtXOLWkjQ7pZ2SlKKZPinUnxQaBa54rxRHX/G q+tc0n7U4H7XEaWNDN8a0+patlFYOS5t8azp4d6I7NmZIft8Ze4FXVcscd1b+tY0pTZNMav6 nA0paRj37lr0wKqSxAj+YJhtnTl6qfB41/qM16XxZM+uxpbBkdzkKH1GTbL74pLM3sUf9scE Zw6DL6yjZrMqmk3f0KZhjDu088Npg1H7F7u06KunAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3eVJrdp9MPQdCGG1GxO27GHRVHcgkDo8UcvHXZxonOy u0kGgUmWXs3UtLJimpKmpWZZamnlAq2mWUqZj9JMih6ozcoeU5ta/33P+Zzv4QvnMKT8B+XJ xMSbeGO8Nk5Bu1K2qdbXKxrkTMTK3FJvqG6zIBh6U0LCYN5rGjLGjhHwqmI9NNZdlEDuQDIB WblfCai7ItLwZTCFghF7HQH9TTYpnO9MkYLd+kEKJzsuIPjg+ERCQdE4gg7LLQn8ar5Dw6ij mIKs3y8QnKp9hKA18ysFeQ31CI6LLIyVl0mhpN8b7IOPKLD13JTCte/PSbjVNokgp7UaQfvx ackGX+530WUJV9L4keBOX3pOci09Z6Rc5mMLwdWM1BPc6L0XNJdVW4G4J0MZJHd1+Ccd7rpH udZoMJt4H51BMK1T7FVBkFIVCsqg4FClSq3ZvzooRBEYtvYgHxeTyBsDwyKVuq53tXTCe5dD ZdXdVDLqk4rIhcFsMG5seiYRkSsjZy8j3NBgdxaME2D8eZicm3HHjpciPTczjrBlYHAW0Owy bEuzEDPAg+2jcdeJo9QMcGe34NSWSnpGU6wfbro5MGuQsaG4anji39Yl+Or1B7PaxdlPFYtn E8lZHbaOlaI57Y27C78R2citCM2rQB68WdBH64UgpaDVC+b4aGWUQX8DOW9+u+VXbT0SR3ZY EcsgxXxZ5CQdIZdoE4UkvRVhhlR4yDa22w7IZQe1SYd5oyHCaI7jBSsKcQbMIT0XRhmcHxRv ilCFqDQQqtKoNepVoFgkS2Ob98nZaK2Jj+X5BN7430cwLp7JKD1frfbHnW1V2oAvZHDvyETi wrd3Cx0T5tL73Yv33D3U1t8lhuu3et2xL4hafoQqL316OnJ0+ebms7t2+3X1bY198mbTrsiH Pts3uqUzOer8Gt3SqYQhr5XZ1iSh8uLwtEi5bxvN+eMaKykPXOYvd/TF7EzVdPouKEipWFOg 7j3np6AEnVYVQBoF7V+4rdO1CQMAAA== X-CMS-MailID: 20200710070321eucas1p12d981060206d2964c72c0884e7415e6a X-Msg-Generator: CA X-RootMTR: 20200710070321eucas1p12d981060206d2964c72c0884e7415e6a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070321eucas1p12d981060206d2964c72c0884e7415e6a References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 17/25] examples/l2fwd: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index e04c601b5..9d5f7307e 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -571,6 +571,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -594,14 +595,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73702 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0ECEA0526; Fri, 10 Jul 2020 09:06:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 87FD81C032; Fri, 10 Jul 2020 09:03:26 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 6CD531BFD4 for ; Fri, 10 Jul 2020 09:03:25 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070325euoutp020ed898bb907fe034d61684ab9ece588b~gUilA6Xoz1632016320euoutp02X; Fri, 10 Jul 2020 07:03:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070325euoutp020ed898bb907fe034d61684ab9ece588b~gUilA6Xoz1632016320euoutp02X DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364605; bh=FZgu+DseHLusxJkCwaRQ1GfffzIWoM6QnM8E1SGa7oc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=YoVtcEqPaXPtQ6b6I3Uw8T9mhsDTlue33CP9yceavawNJrb2wjnQ28cDWGB2ZGdLu cXBKhYmcv+DEb6sj0+aNiUCdK+MKwfvZtxrTta1Q/HoBfJGrGu3d758CWYObQZYuk5 oEnZIImFPMRrT1xgiYI8qvmPEA1eU0rdsd6wbDEg= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070324eucas1p168556fe1e09fd24c622b2d32ad84e62f~gUiktnYVL2360623606eucas1p1E; Fri, 10 Jul 2020 07:03:24 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id B0.51.06318.CB2180F5; Fri, 10 Jul 2020 08:03:24 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070324eucas1p15a25b22ea53352cb4c4ef4456e3da94a~gUikCwRZW2480724807eucas1p1K; Fri, 10 Jul 2020 07:03:24 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070324eusmtrp1988f48c99418b7aeecf12fdfdc47d932~gUikBt61P1113611136eusmtrp1Q; Fri, 10 Jul 2020 07:03:24 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-df-5f0812bcacb5 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id AE.94.06314.BB2180F5; Fri, 10 Jul 2020 08:03:24 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070322eusmtip19e0d84bc5ae1950f33e461d20cd5296c~gUiiNjf1O1544015440eusmtip1k; Fri, 10 Jul 2020 07:03:22 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:16 +0300 Message-Id: <20200710070226.6045-19-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHfe69vb1tWnMpJpyBEW1kOpKhm8tyTBZRp8s17sM+GpMN6rwC g1ZpeZmbMYxIhYrosL6CtSsYsKigAoVSHDaZBYsQzBxgeIsuQ3ATimJFQYXemn37n9///zzn nCcPR2usbDSXZsgSjQZdhpZVMo23Z7o+9mi4pLXu9rVY22kj+HCogsYR6yCLRyYPUdjnTESP q1yGpcN5FJaUBih0VVtY/Hckn8GnUy4KB1r9cjx3L1+OU95ROR7tLiM4OjtO41n7M4LdtgYZ ztxyszgx62Cw5NV9gsfq2wn6igMMWpubCJotPE5eqpJjxcAynBppZ9Dff0OOl6d7aGzonCP4 q6+W4F3zW9nGFcIr+0WZUOEZo4QTv/XQwu3+U3KhuMNGCdeeNlHCxM37rFBS7yTCnYdHaKHm 75fsN8qdyi92ixlpOaJxzYZkZerpq4Nkn0P5Y1HjKSqPjMstRMEB/xkMzzxiLUTJafhqAv1X 7OHiOYGL/bcYqXhG4Gyzk35/5PfzVrlkVBGoPOYJF9MEpvMd1EKK5VeDv9BGLRhL+GssuGZ7 Q0Yk/zUcsvuYBc3wcXAyYA5dq+bXw4NfKonUIhZq6tpCXDHPCyyO0LQafhn0XnhOSZlODnrL MyW9Bf664GclHQnjvvrwdkvBf6KYkfTPELzeG5oU+EICQ46CcCgR6p90zWuOo/mPoNa9RsKb oOhBQwgDvxj6/otYwPS8LG08TUtYDYVmjZTWQlvHvTAGmHutkrAAPcGx8PN4CJyZ8dPHSey5 /3vZCXGSKDHbpE8RTesMYm6CSac3ZRtSEr7fq79O5v+q/41vuoncnN3lJTxHtCp18hybpJHp ckz79V4CHK1dot581/+dRr1bt/8n0bg3yZidIZq8JIZjtFHqdY6xbzV8ii5LTBfFfaLxvUtx iug8crXkaKwibYfzSd+iO58nB+s6Imyt3PIsV9EVsztupbUz7oPGPyOXLm/JbX7D/FO4uu5l 1GSlYVXwoKrKo9Nz6j3JBd2MflxZllqj2DmasOHA+XJV94uv/vi0ZdG27QVbH0UfNsbkZf4Q SAyUB1vUZR9GxLsf56arVhZt9Q5/6U6JUWoZU6ruk3jaaNK9A6WqlI+nAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTYRSF/Wem0wEtmRSMY01cJlGUhMKw2FtUJPrgPGiiMcYVsYERiJTW TmuE+AAEEYviAiJutYKoLIrIUjQFpS6o1RAhoKgoEQyKCKWuEBQLxLeT8517cpN7KVz+k1BQ iclGwZCsSWJJb8L5t7kr0C6nYoKtHRhUPrMg+PCuGIfu/C4SclyZGLwqWwl223kJnHyfhkHu yWEMbNfMJAx0ZxAw6LZh8LbBKYWzrRlScDv6pHC05RyCvrF+HM5YvyFosdRKYKTpDglDY0UE 5I62IzhW8xhB85FhAvJv1yPIMtPgKr0qheK3c8Hd/ZgAZ2e1FCp+vMCh9tkfBCeaKxE8zxqX RC3gR60lEr7Y/hnj8y69wPlHnQVS/sgTC8ZXDdZj/FBjO8nn1pQh/umHHJwv7/1Nrvfeplxu 0JmMwvwEnWhcwW7nIETJqUEZEqZWcqGq6IiQcDYocnmckJS4TzAERe5SJpy+0YX0Rd77D9cV YGmoX2pGXhRDhzF3L+R7tDclp0sQY8nqwsyI8gCG+dKLT2V8mbEOMzmV+YaYJz1DkglA0osZ Z7YFmwB+9BuSaTuUTkwAX3otk2ltntQEvZA5NZw12SSj1czr9MtoqnUeU37z3qTv5fEPmosm N5LTCYzDdQVN6bnMy4vfsePIx4qmlSE/wSRq47UipxQ1WtGUHK+M1WlvIc/N6x6NVNej1qqN DkRTiJ0hqx8nY+QSzT4xRetADIWzfrJVz5075bI4TUqqYNDFGExJguhA4Z4FT+CKmbE6zwcl G2O4cE4Fak4VqgpdCuwsWTbdtENOx2uMwh5B0AuG/3MY5aVIQ0b3MoMfNfBezV7vyX5g0cOW nPGRP9Nt/nsqOvdGmTbLvvoEt71b0pA7Wnqf1ZTvFtySljU/8sL0IWmKrW66Qz+n4eObTLP9 4WK8vC27poSObC3cZF20WpUYFVjKHfpUVtgSkRodytkCZrvqXM72nEb/bVX6Xxt8g1KWHCDX jbGEmKDhAnCDqPkHcT7sCgkDAAA= X-CMS-MailID: 20200710070324eucas1p15a25b22ea53352cb4c4ef4456e3da94a X-Msg-Generator: CA X-RootMTR: 20200710070324eucas1p15a25b22ea53352cb4c4ef4456e3da94a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070324eucas1p15a25b22ea53352cb4c4ef4456e3da94a References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 18/25] examples/l3fwd-graph: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-graph/main.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index c70270c4d..cd8e3aad1 100644 --- a/examples/l3fwd-graph/main.c +++ b/examples/l3fwd-graph/main.c @@ -599,6 +599,7 @@ check_all_ports_link_status(uint32_t port_mask) struct rte_eth_link link; uint16_t portid; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -623,16 +624,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* Print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port%d Link Up. Speed %u Mbps " - "-%s\n", - portid, link.link_speed, - (link.link_duplex == - ETH_LINK_FULL_DUPLEX) - ? ("full-duplex") - : ("half-duplex\n")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* Clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73703 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1D8CA0526; Fri, 10 Jul 2020 09:06:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90E8E1C1A6; Fri, 10 Jul 2020 09:03:29 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 9E1261C119 for ; Fri, 10 Jul 2020 09:03:27 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070327euoutp0214466577d6c8ef7d1d9f25275081660f~gUinDgiFb1750117501euoutp02P; Fri, 10 Jul 2020 07:03:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070327euoutp0214466577d6c8ef7d1d9f25275081660f~gUinDgiFb1750117501euoutp02P DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364607; bh=O8BZcOjmjjfyos4EN+drgkw7ydPT/VazCurM2vsSk0g=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=hZQbmHpL420NYMIHIZw7UEfrbneFjQsO1HnquME2jhNK6O5Sibar6CrWa8VuGe3hP mnMJ3iK6fLplxLQZuyFFC53aeDhPTm7PU/wRpY56OaceXsJdfJJvYoBLX321FEn36n eWXiXBnyFKKm6bj20d4ce4PQwTXvo+qtDd6jGZTk= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200710070327eucas1p26f3e9c71c2625aecb0b3486b50712a15~gUim26Dug2517925179eucas1p2d; Fri, 10 Jul 2020 07:03:27 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 53.51.06318.FB2180F5; Fri, 10 Jul 2020 08:03:27 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070326eucas1p247203620422acdb424626c9f77eb225f~gUimdq4yZ2518525185eucas1p2d; Fri, 10 Jul 2020 07:03:26 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070326eusmtrp122521f3c9a9d6ff2f9789f0a89b3ad13~gUimc3J6N1176811768eusmtrp1r; Fri, 10 Jul 2020 07:03:26 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-e4-5f0812bf9828 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C0.A4.06314.EB2180F5; Fri, 10 Jul 2020 08:03:26 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070324eusmtip1c16cbe48e6aaa1453f49c28d26d5f8f7~gUikp7Mwq1592215922eusmtip1W; Fri, 10 Jul 2020 07:03:24 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:17 +0300 Message-Id: <20200710070226.6045-20-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0yTZxTG8373Nta8frp4whaMjZq5eQ38cZYYnQtZPqMYNXFbzBA6/VKd gKQF0bkIXiC1YtVaNF5SkeoUdGMqQlVAaJBbEYSNURLnKjESrwUUFVY2qV+N//3O85znfZKT V2JllxAjbUzPVC3pplSjoOcqGobbZ9+UpeR5hb+JWNbqJth7z8Ni0PW3gPv69zAYKF2EVZUn eXT+k8ugwznAYOV5u4BPg7s4fD5YyeDdar+Ixzt3iTjo6xNxf/sJgn3hxyweK3pBsN19lcfh uusChsLFHDpGuggeKG8i2FgwwKHrmpdgvp1if8k5ET13Y3Ew2MShv+eKiBeHOli82jpK8FBj GcHb+f/zX05VRorO8oqn6hGjHD7dwSoNPUdEpaDZzSiXnnsZJVTTJSiO8lKitPTuY5ULD94I K/Rr9AvWq6kbt6iWuQtT9BvONL1hM47ot54+5uFzSZ5kJzoJaDzs3N0l2Ilekul5Ar/+YeO0 4SWBg213RG14QWDnnofs+0jPcAWvGecIOOpquIgh0yECT71JERbop+C3uZnI0iR6SYDKcDcT MSbSZdDZV8tHmKPTobq/l0TYQL+AAfsvotYwBS78XvuuTTem59mLRa0gFrpPvXz3KNBWCQIX A4wWSACHsyUangiPG8uj/An4DxdwGm+H15e7RS1sI3CvOC+6tAjKn7SNsSSxdCaUXZ+ryYuh JVRPIjLQ8RB4NiEis2PorDjKarIBbPmytm2E2ubOqAww+u84TVZgpNARvWgVgSs2L3OQTDn+ oauIkFIyWc2ypplVa1y6mj3HakqzZqWb56zbnHaZjP1V/3+NQ15SE/7BR6hEjOMMKaNCssyb tli3pfkISKxxkuGr2/61smG9adtPqmVzsiUrVbX6yMcSZ5xsiCt+lCRTsylT3aSqGarlvctI uphcsuov3YOV42fdf7JkbXJ18zUoyE7ZmnAzFLuw3re8PvtV+y2aD0U4+Gx1icvk0n2U02z+ hobknNXVmT8HChPMFleiMC2cFPy2gt4f/prfkbA0a+THP2d97ux49V3c3u/nuxMXr1QWLCnJ KItPvNHvseQ0JHJqcMfJthttdfGxMTkzjJx1g2n+Z6zFanoLU3aaAacDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSbUhTYRTHe+69u7tKi8tc9OCHVQOjombzJY+iZUZ4oT4EJdGL2crLtJyT 3SlpZBapscpliaCFLk0ttUxLXaGmK9SaYlpmKzURybfQaW8qlk2lb/9zfv/zAucwpPQX5c5E xxp4faw6RkG7Ura/LX1bG6RMxLbyi5ugoi0PwWB/IQkDWX00XHVcJuBj6U6oq70jgptfUgjI uDlFQO19Iw3fBi5RMDFdS0BvvU0MuV2XxDBtHRbD9Y7bCIbnx0jIMX9H0JFXLYLZpuc0TM4X UJAx143A9LQVQcu1KQqynlkQpBlZcDwoEUNhrxymB1opsNmfiKH8ZycJ1W1/EGS2VCBoT1sQ Ba/n5sxFIq6wbpTgbt3tJLlme7aYu/Y6j+AqJywEN9nQTXMZT0sR92bwKsmVDc3Q+12PKAP1 ungDvy5KJxiCFEdV4KVU+YPSy8dfqfL2Cw/w8lV47giM5GOiE3i9544Tyqh7rTNkXLbr2bs5 haIUlMoYkQuDWR9sn60RGZErI2WLEE4d+u0MGCfAeHyIXPa44fkPRnrZ8x3hFw9TRIuAZjdi 25U8YhHI2M80fpd+kVoEbuw+3DXcuGSiWA9c7xhEi1rC+uMpY7F4uetaXPa4cWmCizOfaixY ykvZKGx1FKNlLcc9+T+IG2iVGa0oRTI+XtBqtIJKKai1QnysRnlKp61CzpvXNM8+saCuygNW xDJIsVJiWaAjpCJ1gpCotSLMkAqZJKTddlwqiVQnJvF6XYQ+PoYXrMjXuWAm6b76lM75QbGG CJWvyg/8VX7eft7bQbFGcoVtOiZlNWoDf4bn43j9/zqCcXFPQRsyf4Q62nJ7e84dLGDZ4Edb kiO5iWhbwGiQZ/guU37cmE+Y5Ajak96YXHCePfy+5LlHf4vydFPazMk5maZbHhkyMvj7ltwU Zv8kDc//GrC7Z7T9wtvJLdnGdfJQbMq1bDZJxotDtv1Mf6l5ZR8JGtp7sirYHFZxCM+O58gu mJMUlBClVm0m9YL6HyKUW6gJAwAA X-CMS-MailID: 20200710070326eucas1p247203620422acdb424626c9f77eb225f X-Msg-Generator: CA X-RootMTR: 20200710070326eucas1p247203620422acdb424626c9f77eb225f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070326eucas1p247203620422acdb424626c9f77eb225f References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 19/25] examples/l3fwd-power: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-power/main.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 9db94ce04..ba6bab4a5 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1945,6 +1945,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1964,15 +1965,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint8_t)portid, - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73704 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAC52A0526; Fri, 10 Jul 2020 09:06:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE1201DB1C; Fri, 10 Jul 2020 09:03:32 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 0B2ED1C131 for ; Fri, 10 Jul 2020 09:03:30 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070329euoutp02137a66fbb801ae096491ef2c3760dd81~gUipUGXiL1749817498euoutp02O; Fri, 10 Jul 2020 07:03:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070329euoutp02137a66fbb801ae096491ef2c3760dd81~gUipUGXiL1749817498euoutp02O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364609; bh=xMUQMNB8i6t8ay1gcbcdZCHyGWgNvOkvIPzWBMqAo/g=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=F/Vnqrw2rFNWRAQSuLSWh0qrQc9azgsFAmFbuebRF5QsuSnWwXHPsG6Jv9S2kCrWk D+nRVQSwcNnqyONg2nW0djg3yBHVZYna8LcTqMFS9OoydCKMn3sJR+ioUmlVVJxnGJ r8DD1uYQdxFtdp2rdgcwWkrilZh2xywyO6docies= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070329eucas1p1594b0d25e50941b0eea427ec1129b4f7~gUipBXof02484724847eucas1p1M; Fri, 10 Jul 2020 07:03:29 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 04.5F.06456.1C2180F5; Fri, 10 Jul 2020 08:03:29 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070329eucas1p24159b4685ac117448ed03004ac2473b5~gUios7a_d2520225202eucas1p2n; Fri, 10 Jul 2020 07:03:29 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070329eusmtrp166a32286ec6c71d156578c8c01d5d914~gUiosFE4h1113611136eusmtrp1X; Fri, 10 Jul 2020 07:03:29 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-3f-5f0812c1baef Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 34.A4.06314.1C2180F5; Fri, 10 Jul 2020 08:03:29 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070327eusmtip19d955e5442f2d55c072c23fa69a8e0b1~gUim9vqUz1544115441eusmtip1p; Fri, 10 Jul 2020 07:03:27 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:18 +0300 Message-Id: <20200710070226.6045-21-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTVxTAc997fe/RWfeoOI/VSGxAnQl+bcmOZtHNaPL+MJnL4kwUxQ7e kEgBW2CwJYboZKwUUCB+oLIC8mGrgligaGe0ElssSiAqNRME58eUqVgFv8oY7euy/37nd869 95yTy9PqMlbDp6RlSoY0XaqWVTKtV952x11S8wlLJvo12NhVSfDeQA2Ng+X9LBaO/Eyhz7oK nW1HFVh6N4/C4tIXFLY1mFj8e3A3g8/8bRTe+d3LYUXvbg79rkccFnUfIfgo8ITGw5aXBLsr WxT49tI5Fp8HqhksfneTYIndQ9BtfsFgebuDYL5JwJET9RzW3JmD/kEPg97bZzk8OdpDY0vX OMH97kaC1/InFF/MFd9ZahVijfMxJZZV9dDildsHONHcWUmJZ545KPH5hZusWGy3EvHqvUJa tN1/w65XblJ+niSlpmRLhsUrtym3D9y3MBnd03MsFR6SR2yRJhLBg/Ap3DrfQZmIklcLDQR8 v7oZOXhFwFlbx8nBSwJVPR6FifChI+NDG2RfT6DofUn4+CiBs7/0MsF7WWEBeAsqQ4ko4QwL bYE+KpiYJqwD38ibUBEjxILHfIMNskpYDgeO3qDkpqLB1nSRDnLEpN9rquaCrBbmQN9vr8I1 XTyY/1LLvAaOnWoJ+2nwxG3nZJ4N3jIzI/NP8Lq5LzQOCAUEBqr3hotWgX34OhccjRY+hsZz i2X9Jfg7Whl54qngexraFz2Jpa0HaVmroCA/3IEWLnb2hjXA+PspshahZ2g4vEMngcvO49w+ El3x/1sWQqxkhpRl1CdLxqVp0g+LjDq9MSsteVFiur6ZTH5V7z9uv4OM9n7nIgJPtFNUjgk2 Qa3QZRtz9S4CPK2NUq2+5t2qViXpcn+UDOkJhqxUyegis3hGO0P1SfXjLWohWZcp7ZCkDMnw X5biIzR5ZEXR5suaDzp3ffXw0CzYOLYhDpcn1sa7L5QPxa52xXXlenLrDzuyvzkd+Vld09iH xzKSvKdTHLHx+qsP1u+Ka7IWzp9ri27eYTN8FDOePo+Jmlmu4fdMbBnetnNJSf71P74NZFbN /zNmWU5/IKf/64S763z2tR0VY1YrZB5Jby8crPteyxi365YupA1G3b+hal6YpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTYRjG+845OztKi9Nc9CE0bSBJ1NGj2d5F2ZU4RJQUQWU1h5002qV2 NksrMDWzaXaToNtaSjcN7LZcZhcHpTXLSi2jMgvByqilRs602pT++/E87+WB92VI5U8qktls tolWs8GoocMp35+Gd9PrlYw+/lkrA9VNTgQfOypI6Cx7R0Oxv4CA9sq5UFdzSgZH3ucSUHrk BwE1Fx00fO3Mo+Bbbw0Bb+/45HDiRZ4cer3dcjjQfBJB99AXEo67+hA0O90yCNTX0vB9qJyC 0sE2BAdvNCJoKPlBQdktD4JCBwv+SxfkUPFWDb2djRT4Xl+Xw+Wfz0lwNw0jONxQjeBJ4V/Z vMnCoOucTKio+0wIR88+J4WHr4/JhZJHTkK4+s1DCN/vttFC6Y1KJDz+WEwKVV0DdEr4Wm62 1WK3idGZFsk2R5PKQwLH64BLmKHj+ETt+lkJSZq45NkbRePmLNEal5zGZXZ0uaitzRN2uE40 olxUNd6BGAazM/Dwh1UOFM4o2XMI3w60UKM6xj1dpAOFBTECD7100KM1fQjnV9+ThQyajcW+ IicRMlTsGxq37NtDhYwIdilu9w+MMMXG4MaSVjrEClaHj51qJUanRuGqK/dHNoQF9b2OcnmI lWwm9vrPo1FW41dn+olDaJwLjalEKtEumTJMEs9JBpNkN2dw6RbTNRQ8+c2Hgese9OLqSi9i GaQZq/D8pfVKmSFLyjZ5EWZIjUqx4Ilvg1Kx0ZCdI1oteqvdKEpelBQMeJiMnJBuCT6Q2abn k3gt6HhtojZxJmgmKorY+nVKNsNgE7eI4lbR+r+PYMIic5HazKXE/loymPT0ZI82tYQLOKPb oowva3uyP+Xzk75E/d7Zsmnh/ojTeE3rlBb8uL1sW87uPt+cmJSm6lTd9n6re2rkap/7zptn ojNtXMyZhvnu5YsWR+eod7O9HZD+oM6/Sh8bv2NZVu2h4kB53QrV/YvdZvWmo+/jdtnbC6aF GzWUlGngp5JWyfAPpZKoMQgDAAA= X-CMS-MailID: 20200710070329eucas1p24159b4685ac117448ed03004ac2473b5 X-Msg-Generator: CA X-RootMTR: 20200710070329eucas1p24159b4685ac117448ed03004ac2473b5 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070329eucas1p24159b4685ac117448ed03004ac2473b5 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 20/25] examples/multi_proc*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- .../client_server_mp/mp_server/init.c | 14 +++++--------- examples/multi_process/symmetric_mp/main.c | 12 ++++-------- 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c index c2ec07ac6..3ca9bcae3 100644 --- a/examples/multi_process/client_server_mp/mp_server/init.c +++ b/examples/multi_process/client_server_mp/mp_server/init.c @@ -185,6 +185,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -204,15 +205,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", ports->id[portid], - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)ports->id[portid]); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", (uint8_t)ports->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c index 9a16e198c..0480874f8 100644 --- a/examples/multi_process/symmetric_mp/main.c +++ b/examples/multi_process/symmetric_mp/main.c @@ -365,6 +365,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -384,14 +385,9 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73705 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49546A0526; Fri, 10 Jul 2020 09:06:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF3061DB57; Fri, 10 Jul 2020 09:03:34 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id DF7E61DB15 for ; Fri, 10 Jul 2020 09:03:32 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070332euoutp027958fb241bcf4df659d73efc9fa864cd~gUir-9SzO1749817498euoutp02Q; Fri, 10 Jul 2020 07:03:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070332euoutp027958fb241bcf4df659d73efc9fa864cd~gUir-9SzO1749817498euoutp02Q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364612; bh=SjcxeTJpiGhJMyyglT2md+9M7XhR8AM1X0pflSOG9+o=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=RqWwoDuIMne/IxZgkyLVQN7GifSbb2caEvDXbbgS9kCpjaDvQsCPn6vi6g0BI+dxV M90Mq75M+UYcwkpRC7ny9ilSlbfwxmsBIrjYx1r4snND8/EPXG8Y/JMmbO5aq95ZJ9 zgzTgiuwyXMzxHjR53YmOqxoappQK/o8R3Qb6YjA= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070332eucas1p19542ed7cbf5cc5d82af10cab2ea92e70~gUir0UAvk1630516305eucas1p1_; Fri, 10 Jul 2020 07:03:32 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 97.5F.06456.4C2180F5; Fri, 10 Jul 2020 08:03:32 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070331eucas1p283cd843b949bc84c80acc65c77d8447c~gUirLAKlP1919219192eucas1p22; Fri, 10 Jul 2020 07:03:31 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070331eusmtrp17594f13fd0d9504625acaaf1ba1a669f~gUirKFqwt1176811768eusmtrp11; Fri, 10 Jul 2020 07:03:31 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-46-5f0812c45acd Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 50.24.06017.3C2180F5; Fri, 10 Jul 2020 08:03:31 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070329eusmtip12e2f97237f904db3b5fc7fb9a573e601~gUipW0YWq1602516025eusmtip1Q; Fri, 10 Jul 2020 07:03:29 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:19 +0300 Message-Id: <20200710070226.6045-22-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe2xLYRjGfeecnnPWqBy12JeRjYYEYYhLXiLmssgh/jASf0iY4pjF1klr c0+6sWW6GTYsm6WrjV3F2Lq2poQGHTWzJWxNara6jLFbZyib6XqK/5739z7P+yRfPpaUX6RD 2TjVQUGtUsYraClleuxtmvdQzsYscN+eCtXP9Ajc7SUkdFx4TUNm/ykC2iojwWoulEDOGy0B 2TkDBJjLdTR86UiloNdjJsB118FAQUsqAx5bFwNnmi4j6BruJiHfMIigSV8nAe+Dehr6hosp yP75EsFZYwMCe9YABRduWxCk6zjoryhjoMQVBp6OBgoczloGrg81k1D3bATBeXs1gsb0Ucmq 6fxPwzUJX2L9RPC5V5pJ/rHzEsNnPdET/K1eC8H33XtJ89nGSsQ/dWeSfNW7H/Qm6Tbpij1C fFyyoJ6/cqd0X621lDyQzx42mWspLbpB61AQi7nF+KHbS+iQlJVz5QibCwol4vAVYcedB4w4 DCKc97H9X6Ty1AASF2UInyx9RYvDEMJFFS1+F83Nwo4Mvf9wMHeLxubhVmJsMYmLwh2pV5kx TXEz8YfSN/6AjFuG9SmFlFgRjqtu3ifHdJCPp+mK/X45F4Zbi776j2KugcV1VSYkBqJw/+ka RtSTcLfdGNBTsSM3K3D0GP5e08qI4QyE24vTAqZIbPz83KdZluRm4+r6+SJejW+kaf0YcxNw W8/EMUz6ZI4pjxSxDGeky0W3At9/0hLAGI/8Gi9iHme+eBd4RauvNM9FnkPhBf+7DAhVohAh SZMQK2gWqoRDERplgiZJFRuxOzGhBvk+q+O33WNBQy27bIhjkWK8zDJKx8glymTNkQQbwiyp CJataXTskMv2KI8cFdSJMeqkeEFjQ1NYShEiW1T8abuci1UeFPYLwgFB/XdLsEGhWpSj6utJ vZL3fc7NyJRzzhm9l2ee6Fy94cfOniVlv7+Fa68Tj8Y15kcvfut6lNgdFVaorTAmn5Et/7Cl 05ubtGB9/dtVzsbOrfs9x02GaOd7S/DWUFvf2tfP2+LsoyHtk7tc0UsVn9d4i+beLT8aFhcx zTDrY1Hz3nUbR6rd21I2WycMFigozT7lwjmkWqP8A72EwBGoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSa0hTYRjuO+fs7ExcHKbSlz/UZkEZzTZbvguziIRD9KMLgV112MFZzsnO jOxPJmYxL6VJoMk0tVUzNJu3wkJnTGuJWHQxb8tudEHdTNCY2dT69/A8z/s+D7wvQ8pmqFAm LcPEGzO06XI6gHL96RnZ1C1jkjZ/90VD4wsLgvHRWhLcZSM0FEzlEfDOtgM62ipFUDqWQ0Bx qYeAtjtmGn66cymY8LYRMPzYJYaKl7li8Dq+iqGo/waCr77vJJRXTyPot7SIYK7rEQ2TvhoK in+/RnCluRdBT6GHgrKH7QjyzSxM3b0thtrhMPC6eylwDdrFcG9mgISWF/MISnoaEfTlL4h2 ruF+V98ScbUd3wju2s0BknMOXhdzhc8sBNc00U5wk09e01xxsw1xz8cLSK7+0yy9L+CIIs5o yDLxETqDYNouP6oElUKpAYVqi0ahjIk9vk2llkfHx53k09PO8Mbo+GSFzt5hJTPLmbOtbXYq BzXQZiRhMLsF2/I8aBHL2FsId3WnmhHj5zH+8YlctgRh3xuz3x7gt0wj3F/3bMlPs+ux67KF WBSC2SEav7p0gVoUgtjd2J1bJ17EFLsOf7GOLYVJWQ22XKiklreG4/r7nUsJEj9/0VwjXi6h w44p679CYfht1S/iKlpZjVbYUDCfJehT9YJKIWj1QlZGqiLFoH+A/Cdvdc41tyPzxEEHYhkk D5Qmz9NJMpH2jJCtdyDMkPJg6a4+1wmZ9KQ2+xxvNCQZs9J5wYHU/oIlZGhIisH/QBmmJKVa GQsaZWxMbMxWkK+SXma7jsnYVK2JP83zmbzx/xzBSEJzUOTMaqmuSDUbvlfz1JJQ6jwc0sBE rB9tqHnsiTzy8b3HWrq5aX+aWlKYGHZRPf2+HOuKiJDs5InJU3ELUV7nRssCJ0lAa5+4I7jA wtoa546mPVtj3lr7Dt0byhxxU1WD5ec7p4PDG/IaAxz7K2zdB5SJH4zDds3Ahs9st3ekV04J Oq0yijQK2r8UYf8uCAMAAA== X-CMS-MailID: 20200710070331eucas1p283cd843b949bc84c80acc65c77d8447c X-Msg-Generator: CA X-RootMTR: 20200710070331eucas1p283cd843b949bc84c80acc65c77d8447c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070331eucas1p283cd843b949bc84c80acc65c77d8447c References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 21/25] examples/ntb: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ntb/ntb_fwd.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index eba8ebf9f..84fe374c4 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -729,6 +729,7 @@ start_pkt_fwd(void) struct rte_eth_link eth_link; uint32_t lcore_id; int ret, i; + char link_status_text[60]; ret = ntb_fwd_config_setup(); if (ret < 0) { @@ -747,11 +748,10 @@ start_pkt_fwd(void) return; } if (eth_link.link_status) { - printf("Eth%u Link Up. Speed %u Mbps - %s\n", - eth_port_id, eth_link.link_speed, - (eth_link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Eth%u %s", eth_port_id, + link_status_text); break; } } From patchwork Fri Jul 10 07:02:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73706 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE056A0526; Fri, 10 Jul 2020 09:06:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0FAC1DAE7; Fri, 10 Jul 2020 09:03:38 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 74E761DBD7 for ; Fri, 10 Jul 2020 09:03:35 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070335euoutp01a758b968a1dfddc3806528dd8603a211~gUiuXD-Tk2063820638euoutp01Z; Fri, 10 Jul 2020 07:03:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710070335euoutp01a758b968a1dfddc3806528dd8603a211~gUiuXD-Tk2063820638euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364615; bh=XtbX4XCFxTlmDt9RDrOth1o/sdpob+sTnBAjVCFknHA=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=ieEsW+z1xZu2b2mRa1OilbNvSGO5od4uDtegQmZZAhSdrq4FXmhbw7KyA7636W1Yq bxAXE10rvY9ArXyV2p5QozO+G28vOM7hsBkwB+xfjbuwjhsZSXSbE/YOk7qtge5BXL AI2zl1pI6OAgyJTSe1sIRZB5UxNFhArnIAQO1w8g= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070334eucas1p1ad5cad0a04c3964dade53aecd36f89be~gUiuF3e5m2360423604eucas1p1F; Fri, 10 Jul 2020 07:03:34 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 69.51.06318.6C2180F5; Fri, 10 Jul 2020 08:03:34 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070334eucas1p258799bbf66182b11ca29d69b78bb3b9c~gUitetfmW1919619196eucas1p2u; Fri, 10 Jul 2020 07:03:34 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070334eusmtrp19c3bf9abc274d38fdf4a5c49784871fe~gUitdp_Ky1113611136eusmtrp1g; Fri, 10 Jul 2020 07:03:34 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-fa-5f0812c641ec Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id C3.24.06017.6C2180F5; Fri, 10 Jul 2020 08:03:34 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070332eusmtip1250f88601665b42bec14ecdac9876935~gUiru6EZ41544015440eusmtip1n; Fri, 10 Jul 2020 07:03:32 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:20 +0300 Message-Id: <20200710070226.6045-23-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUwTdxjH/d1d745i53k6feIWDE1MBgx8w+UxWdTNRW/JTEww2VsYVL0A EQq5E51bQgjhLQVRgW0RSUUaRQvKYECrokFiQCwvAWLADBCVl1AFFYGtFpyUq9l/3+/n+7zl lx9Pi8XsOj7BfFRWzKZEI6tnGlo8XeEtIh+zqd4didXtVoJPhmw0DhcPspj3MpPCfvtObHSU 6rDwUTqFBYWvKHRctrD4fDiDwalpB4UDt1wclvRkcDjdPM7hya5zBMfn3TSeLXtNsMtar0PP nRssvpgvZ7DgzQOCp+ruEWzNf8Vg8XUnwWyLgC+vVHBoGwjC6eF7DLoe/sVh1Ww3jfXtCwTP tFYT7Mj+T7crWHpTdlEn2RonKKnoQjcttTz8nZPy26yUVDPlpKQXtx+wUkGdnUj3n+TRUuXI v+x+/Q/6zw/LiQnHZGXjjlh9/LBbSXmu/7k3M5NLJ495CwngQYiEuVE3sRA9LwqXCZwpGPKb GQIZb3M4zbwm0JlnY963FHkG/EEFgafOAVYzswT6z1VxvipW+ARcuVbKF6wWalhwzPdRvmCV 8A3cnPCyPs0IG2Cmt2RprEHYDnbHDKWtWA+VfzbRPh2wyLMs5UtDRSEI+s7PLA0FoZ2H32pG Oa3hK8hp+5vV9Cpwt9b5+cfgKsr33/0r/FPbx2nNuQSGyrP8RTuh7lnnouZ5WgiB6hsbNfwF jDz1Mj4MwgfQP7nSh+lFWdjwB61hA+Rmi1q1EZraevwYYMG7XMMSXLff9L9PI4EpZw45TdaX /L+rjBA7WSunqklxsrrVLB+PUE1Jaqo5LuJQclItWfyrrrets05ye/5gMxF4YlxuiF1gY0Sd 6Zh6IqmZAE8bVxu+7HD9JBoOm078IivJMUpqoqw2k494xrjWsLV8IloU4kxH5SOynCIr71OK D1iXTvLHIh/LUcFBsZNpVr53ixSZ+H3UNiWsacV3exxX1lyN6i0a3K1c63anBcfvqAgN39OQ NVbvvfpt8Y9ze1dEL9vnPVu67NOTOSuB/+w8Z7pztz/kWkapOGnzqAfWJMwF2uZCzZM9Znk6 JDosb/zDrxciPAmB+wy79x5Rt4ePDu7PvmRk1HjT5lBaUU3vAB4aOa6nAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSbUhTYRjtvffu7jpcXZbhxcJ0UUnQatO5Z2EaBXl/9KOy/pRlyy4abc52 p6QQqVjKXJYfRH5gptnHrLSytFphC3Q1xUpMJc1pgmjmx1zQSrMt69/hnPM8z4HzULjETQRR J1OMnCFFo5WSIsLxu31wc5uEStjqvE9DQ0cVgpHPtTg4SwdJKJjJxaDPEgPW5koBFA9lYVBY PItB820TCZPOHAKmXM0YDLxwCKH8Q44QXLYxIVzsqkAwNj+BQ1n1HIKuqscC8Lx6RsL0fA0B hT97EFxqsiNoN88SUPq0BcEFEw0zd24JoXYgGFxOOwGO/kdCuPv9PQ6POxYQFLU3IOi8sCjY Ecr+rK4TsLXWcYwtuf4eZ9v6rwhZ85sqjH0w1YKx0y97SLawyYLYtyMFOFs/+oPcKzokizLo 04xcSLKeN26XHpaDQiZXg0wRoZbJw1VHtimU0i3RUSc47cl0zrAl+pgs2TlhSJ0UnenOzRVm oWHKhPwoho5gSjwDQh+W0HWIyTNjJkR5eYb5OoovWVYy8x9NpAmJvJY5xLg8HoFPIOkwxpFf hfmEAPoTyXTnZRM+YSW9h3k+/ov0YYJez7i7y//yYlrNWJrd2NLWtUx9Y+vfC35e/ryp5l+I ZMY2cxMt4WCm95obu4yWV6NlFhTApfG6JB2vkPEaHZ+WkiRL1OseIm/jT9o8TS3INBVnQzSF pP7iYwtkgkSgSeczdDbEULg0QLyz03FUIj6hycjkDPoEQ5qW421I6Q1YhAetStR7/yfFmCBX ylWglqvCVeGRIA0U59Ov4iV0ksbIneK4VM7wfw6j/IKyUH1r4/awG3M5EYFx1jstoaej/HfT FnvIgdf5qQ++f6HUKF43lDjg9psYtvRsOh6/y34uEK9eNyXXRmbnnTuqHCcX9+UHvoul5kt7 r94UbOirzDwb/bp3w7Bkekx6UGU9fO+bMrarcf/MxtXdvPmhao3LqmgND6qIKa2bDjWvKHsn JfhkjXwTbuA1fwA1c0MABwMAAA== X-CMS-MailID: 20200710070334eucas1p258799bbf66182b11ca29d69b78bb3b9c X-Msg-Generator: CA X-RootMTR: 20200710070334eucas1p258799bbf66182b11ca29d69b78bb3b9c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070334eucas1p258799bbf66182b11ca29d69b78bb3b9c References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 22/25] example/performance*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/performance-thread/l3fwd-thread/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 84c1d7b3a..bd10014a0 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -3433,6 +3433,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -3452,14 +3453,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73707 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A450BA0526; Fri, 10 Jul 2020 09:06:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7AF11DD29; Fri, 10 Jul 2020 09:03:41 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id C413F1DAAE for ; Fri, 10 Jul 2020 09:03:37 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070337euoutp02c7d301f62632b1ad4a6467760e30f81d~gUiwhwcz71730917309euoutp02n; Fri, 10 Jul 2020 07:03:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070337euoutp02c7d301f62632b1ad4a6467760e30f81d~gUiwhwcz71730917309euoutp02n DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364617; bh=M/wyN4nGPfl8N+dBV9oGDaEn0+uBQWGX9DXEsrG01Ys=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=F9Mp/kDSlQb+DHE9ickLuDmFNd2p2EANijNzqmhkflZgAJ0bdPgUN2zvHtNzI+wQ+ lCA1rRwzzpuLYEBU6E5KpF+3VPR/yM39jSLlzhk83qTP+yA/rtH5eH2TU0dmj4ZZdc 19TZYFDDBa8WTsFwU8+i4DrJAESk8jIr/h/yhWbw= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200710070337eucas1p23c295a571c7498959dd2d8ef43268b7f~gUiwPV0uj1909319093eucas1p2D; Fri, 10 Jul 2020 07:03:37 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 7F.51.06318.9C2180F5; Fri, 10 Jul 2020 08:03:37 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070336eucas1p1cdc02c20c4bb753ad683359f252c7209~gUiv1TN9T1630516305eucas1p1E; Fri, 10 Jul 2020 07:03:36 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070336eusmtrp190dae747f6ce18bdd927a1f6c6a40f44~gUiv0Uyfs1176811768eusmtrp1-; Fri, 10 Jul 2020 07:03:36 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-00-5f0812c9f989 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 76.24.06017.8C2180F5; Fri, 10 Jul 2020 08:03:36 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070334eusmtip198a6228937adeb29f0a017ab7f6f636e~gUiuELK7S1592215922eusmtip1a; Fri, 10 Jul 2020 07:03:34 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:21 +0300 Message-Id: <20200710070226.6045-24-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0wTaRSG881MZ4bGmrFiPBGV2ERXd7Oi0egxGm/xx0QT9Qfxh0agu46A 0Nq04jUqGsCmFFQkXsBUpC4oNYuXVtAAQmMELJdARESkIqhVVBCUiFxtGYz/nvOe9/3OycnH 0+pMdgYfq98nGfXaeA2rZO49/lH3d7Waj1xUV6HEwhobwQ6vncb2zDYWU78kUfi8YA2WFF1W YMarRArTM3opLLpuYfFT+0kGu/uKKHxZ6uEwq/Ekh31uH4dp9dkEfcNdNF7K+Uqw3uZS4I+K Byz2DOcymD7YRPC0s4pgpbWXwcz7xQRTLAJ+uZHPof3lbOxrr2LQ03KXw5v9DTS6akYInq0s JFibMqZYO0cczPlPIdpLPlDiuasNtPi45TwnWqttlHi7u5gSe8qaWDHdWUDEJx2ptOh4M8Bu VW5Xrtolxcful4xhq6OUMbWjL1jDLe5gi8vOJRILayFBPAhLIa/ulJ+VvFq4TqC+qYyTi28E kvIzuIBLLXwl0NM971fC4e5gZFM+gfJWK5GLfn/iVTcVcLHCfPCYbVSgESzcZqFouHm8MVXY CK2FeXSAGWEujLY+HV9EJayAQdtrWh4RCo5b5eMc5NeTLbkTa8yG5ivfxh8F4REPveYBSg5s gIKkEk7mqdBV6ZzgmeA5Z2VkPgLf7zRzcthMwJubPGFaA86PdX7meVpYAIUPwmR5HWS9e6YI yCBMhuefpwRk2o8Z9y7QsqwCc4padmugvLpxQgYYGZokyyI87Kyn5PuUEGjKdjFnSGjW71k5 hBSQ6VKCSRctmZbopQMLTVqdKUEfvfDfvbo7xP9XPaOV/cWkbPgfNxF4opmkihphI9UK7X7T IZ2bAE9rglXraz0RatUu7aHDknFvpDEhXjK5SQjPaKarluR+2KkWorX7pDhJMkjGX12KD5qR SNK8j8bsoTv3OJdFtY85qmJPfFwc7vJFlCbozIa2jf3xQ6l/xa1/t8XrSjOsDW+8eLlrR3Zq zLMg6/33iSHJf5QOHY1JaZg2UDECnYvCjx/3OnzTgit8NZ2W/xtDPMvnjL61bNtS5drcHHZt 9dPteRHn9W3S7r5Nx2ZJWSt3G+LuikoNY4rRLv6TNpq0PwHxcPWApwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSfyyUcRzHfZ/nued5mNOzB/XMlnRb1tocd359CLXa6ln/aMtfUufGM5Rz ds+dUf0hlepIkWlRlwihjepETZbToo7JryIVSbXS/Li0Ykcd6r/X3nu/35/P9vnQODtPeNEp aXpBl6ZOlZEuhHW5851fF0urAswl/tDQbUIw8b4Sh/HidyTkzZ7GYLhuB7Q2X5NA0Vg2BgVF cxg03zaS8H08h4BpWzMGbx9bKSjtz6HAZvlCwYXeMgRf7N9wuFr+A0GvqUkCC+2PSJixVxBQ sDiE4KK5C0Fn/hwBxQ9bEOQaGZitraGg8q032Ma7CLCO3Kfgzs8+HJq6lxAUdjYg6Mn9I9m5 mV8sr5Lwla1fMf7yzT6cfzZSQvH5z00Yf3e6BeNn2oZIvsBch/gXE3k4Xz/5m9zvEiuP0GkN esEnWSvqI2UHFaCUK8JArgwKkysCQw+FK4Nl/lERiUJqSoag84+Klyf3LL8h0xupzJGmSiob GUkjcqY5Joirt0wQK8wyVYib6j9uRLRD57ipSXzN4s7ZX63ZWeYH4p6OKleYZLZy1nMmzIhc aA9mlOQGzp5c7XFn9nGjDdWrYYLZwi2PDq6GpUwYt2j68K90E1ff+GSVnR36GWMFtTYgmbPM VqM19uZe35jHLiG3cuRUhzwEg6hJ0ohKuajWiIa0JHmCVnMPOS7+4NmCuQUZpw9YEEMjmas0 folUsRJ1hpilsSCOxmUe0l091sOsNFGddUzQaVU6Q6ogWlCwY8FC3MszQev4nzS9ShGsCIUw RWhgaGAIyDZIzzHtcSyTpNYLRwUhXdD9z2G0s1c2Mk2y9evNGyNiPH0rqne1NcWUdkd+ctpD 92QubbIPZ4lX+n3yxo7cOu/hWj1u089P4bvdr+ekeM+V+jd27P11s3Zw3UccJ1+ePfHTLfqz PYBNLauLbkvwXXQZ+dxYHn6iI679VGR0a3FI8/Zhs1+uGTMcNQ1sVy3Edtk+DJ+qcY2XEWKy WrEN14nqvxw6IdkHAwAA X-CMS-MailID: 20200710070336eucas1p1cdc02c20c4bb753ad683359f252c7209 X-Msg-Generator: CA X-RootMTR: 20200710070336eucas1p1cdc02c20c4bb753ad683359f252c7209 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070336eucas1p1cdc02c20c4bb753ad683359f252c7209 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 23/25] examples/qos_sched: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/qos_sched/init.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 9626c15b8..4bb975fc9 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -160,14 +160,8 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) "rte_eth_link_get: err=%d, port=%u: %s\n", ret, portid, rte_strerror(-ret)); - if (link.link_status) { - printf(" Link Up - speed %u Mbps - %s\n", - (uint32_t) link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else { - printf(" Link Down\n"); - } + rte_eth_link_printf(NULL, &link); + ret = rte_eth_promiscuous_enable(portid); if (ret != 0) rte_exit(EXIT_FAILURE, From patchwork Fri Jul 10 07:02:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73708 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B119A0526; Fri, 10 Jul 2020 09:07:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E44561DE82; Fri, 10 Jul 2020 09:03:43 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 4AC741DC12 for ; Fri, 10 Jul 2020 09:03:40 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070339euoutp0272e38ef46a73e3efb84be21bd57f489a~gUiyu-BJ31749817498euoutp02V; Fri, 10 Jul 2020 07:03:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200710070339euoutp0272e38ef46a73e3efb84be21bd57f489a~gUiyu-BJ31749817498euoutp02V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364619; bh=WQh0/xZ8D/8NSNS0F/gifzw1wCeRoFQ4rQBL4QRJi0A=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=hH5VC8tYQ/DqGkcpRkgVCyV8BwaBc4qxzblJgpxCFQvGvUQizWYPpSuCqeCJTaPiF roJUGtXfe8ZztdYS6yrWLNJ2vAaJj8QmID16CeUKN+2Jj0kiV2K2Oi2iy1cEImRkYz 5Xqdhz3ah3wIFJOjoGXhFMQYjFUHnBD0z+wnG7k0= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070339eucas1p1d09877b0b7bebf5687cded645be2376a~gUiykUzR82075420754eucas1p1p; Fri, 10 Jul 2020 07:03:39 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id F1.61.06318.BC2180F5; Fri, 10 Jul 2020 08:03:39 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200710070339eucas1p1ccde344530fd438e001e6cc41f2a6236~gUiyQTWvr2075420754eucas1p1o; Fri, 10 Jul 2020 07:03:39 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070339eusmtrp11569da88314659b5cda6d71a09093d9c~gUiyPdjuI1176811768eusmtrp1G; Fri, 10 Jul 2020 07:03:39 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-06-5f0812cbc63d Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 79.24.06017.BC2180F5; Fri, 10 Jul 2020 08:03:39 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070337eusmtip10a42ccdeb0d39d915180a237769a0116~gUiwdssmd1465514655eusmtip1Q; Fri, 10 Jul 2020 07:03:37 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:22 +0300 Message-Id: <20200710070226.6045-25-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSXUxTZxjH855zes6hs+askvFEF9i6uChRcGMXj5mKGl3OhYu72qIGocpJ IUJxrbjhLkQYBMqHUtmHqIAlCqIRkWqrAlYgFCiWj4QBCyJhLAiiWBQRKDjKqdnd//n9/89H 3rw8rS5kV/Px+mOSQa9N0LBK5k7zrHujS81Hb/p7NhSr2osJDg+W0ThU+JjFnJe/UthXGYm1 tgsKND9JpTDf7KHQVmFicWIojcEXUzYKB+pcHBZ1p3E41TDKYV7HeYKj3nEaz5W+IthRfFuB sw/vsTjptTCYP9dD8LS1haAz18Ng4V07wUyTgC+vlnNYNhCMU0MtDLr6azi8Pt1F4+32BYIF ziqCjzLfKbZ/Ks6VXlaIZbVjlHj2UhctNvf/zom5rcWUWP3CTomT9T2smG+tJGLbcA4tXht5 y36n3K/cEislxB+XDOHbYpRxzY4pxdGMD37uXJzkUskQbyIBPAhfwXDBX4yJKHm1UEGg29xF y8VrAvO2Z6xcvCLQNTaneN/S1PaEyEY5gfvpdf7UNIHcmqecL8UK68CVVUz5jEChmgWbt3ep 4PlVwh7oKQ/2ZRhhLTgdI6xPq4TN8K7jOS1vCIFrNx3LOmCJZ5gsyzPVQjD0lrxenglCOw/n 3DVEbtgFLaNuRtarYNxp5WT9MbjO5vr5LzBzq5eTm7MIDFoy/KFIsD5zc77jaGE9VN0Ll/EO cFy+SPswCCuh7/mHPkwvSfOdP/xYBVmZajmtAUdrtx8DLMyvkLEI/3QWcfLz1BLIHrQqzpCQ ov93lRJSSYKkZGOiTjJG6KWfwozaRGOyXhd2OCnxFln6q65F57Sd1HsPNRCBJ5oVqpgFNlqt 0B43piQ2EOBpTaBq5yPXQbUqVptyQjIkRRuSEyRjA1nDM5ogVYRlLEot6LTHpCOSdFQyvHcp PmB1KtF93/yttLetMDsoYiZ+85eP/7zymW7DhhZ3Uq/pQWN13PAPnuuXoreWBu5psqSd2LE4 Mb92m/5M+9P+81uyzTOhgY4q+8HPx35M375//Ibuk93O9H35v+XZ//WutHaWq940fnQhNnLg ZNPugsb6m3mnVN94DoR8vTM2KrwkZ8KTFNNXpwnVMMY47RehtMGo/Q9q977CpwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSW0gUcRTG+8/MzozWxjAqDaKmA0IFru2qeRSzKIJ5CLo9hJmXRQeVXFd2 VsmeNlOrdVvblKC0zbSLaVCZtlYWtoSam6mFlXgXyS7m3co0bTfr7XfO932HA+fQODtPeNNp GXpRl6FO50l3wrHc0h/kYOmErW2VXnD3lRXByEAlDkMl/SQUTuVh8KF6BzTaymRwYdCAgfnC NAa2KiMJ40O5BEzM2DDoe+qg4PKbXApm7GMUnOsoRTC29AWHS+WzCDqs9TJYeP6YhMmlCgLM v7oRFNW1ImgxTRNQ8qgBQYGRganbtyio7PODmaFWAhw9Dyi4M9+FQ/2r3wgsLXcRtBesyHYG CL/Kb8iEysbPmFB8rQsXmnsuUoLppRUT7k80YMLks25SMNdVI6FtpBAXakZ/kvvdjyiidNos veifqpX02/lYJagUyghQqEIjFMqQ8LhIVRgfHB2VLKanZYu64OhERWpz04wsM3/t8c7lScqA hmgjcqM5JpR70TaIjMidZpkbiGuvanIWtFPguK+j+KrHg1t6ZyRXPbOIq8h7TbgEktnEOc5Y MZfgyfSS3NvTJwlX2IPZy3Xf8nN5CCaQa2kaJV0sZyK4lY5v/4Zu5GruNf1lN2c/31hBuZhl Ujn71E20yn7c+6tz2Hm0vhytqUaeYpakSdFIKoWk1khZGSmKJK2mFjlP/rB5oa4BGScO2RFD I36dPPE3mcDK1NlSjsaOOBrnPeW72h3xrDxZnXNC1GkTdFnpomRHYc4FLbi3V5LW+UAZ+gRl mDIcIpThIeEh24DfID/DPD/KMilqvXhMFDNF3f8cRrt5G5DnYvx3awdj/unOe+waSF5mB3x7 XzrU/tRZNtP0Zl90acPYwWbLk86pgN33y2pmP7YWK9vNg3OG9TFrx4s+BYb+8JHPXa+OV+0t shwcHt5jOydbSDQdu8wHrtTmbY6MraU3FC7ujjGl9QUdLjAM7g+w+dLFcT4W/YGuYDLmysQp npBS1cotuE5S/wFZ79WcCAMAAA== X-CMS-MailID: 20200710070339eucas1p1ccde344530fd438e001e6cc41f2a6236 X-Msg-Generator: CA X-RootMTR: 20200710070339eucas1p1ccde344530fd438e001e6cc41f2a6236 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070339eucas1p1ccde344530fd438e001e6cc41f2a6236 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 24/25] examples/server_nod*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/server_node_efd/server/init.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/init.c index 378a74fa5..00224850e 100644 --- a/examples/server_node_efd/server/init.c +++ b/examples/server_node_efd/server/init.c @@ -247,6 +247,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -266,16 +267,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - info->id[portid], - link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - info->id[portid]); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", info->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Fri Jul 10 07:02:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73709 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65F03A0526; Fri, 10 Jul 2020 09:07:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18FDD1DC99; Fri, 10 Jul 2020 09:03:46 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 12F741DD9A for ; Fri, 10 Jul 2020 09:03:43 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710070342euoutp0134a6695c916c9ab35470e09721051809~gUi1dYV_02078320783euoutp01Z; Fri, 10 Jul 2020 07:03:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710070342euoutp0134a6695c916c9ab35470e09721051809~gUi1dYV_02078320783euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594364622; bh=U2zVf/WfC+GxbbAndLEN5cAyOf8BWxrHjaueCQ0L+Sc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=P9AfKyaWJw5QokJY0ImGBfmNmGbgJeWy3E8SIDAzyz3kueOyVxcomV0ZI/A9IvqcX CUsaZgwStmJu57zchDJjcraLRUEpWCRDOi6rkCB5Q7NAGSXN8xS5C2kOZsKzvvsAuT XBzl6CvH7I3NmEzzVtISNmUY2/W5lDyDFB0wfczI= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710070342eucas1p12f2eebfb3b131f2af98469d1efd13afd~gUi1Oo58w1829318293eucas1p15; Fri, 10 Jul 2020 07:03:42 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 1D.5F.06456.EC2180F5; Fri, 10 Jul 2020 08:03:42 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710070342eucas1p209727bb328f2d2dbe6cefa2f7c237525~gUi0ul1M62518525185eucas1p2p; Fri, 10 Jul 2020 07:03:42 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710070342eusmtrp1bb4268c3a4c54ea9807b846cadd5d5a1~gUi0tX6He1241112411eusmtrp1F; Fri, 10 Jul 2020 07:03:42 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-60-5f0812ce95a3 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 5D.A4.06314.DC2180F5; Fri, 10 Jul 2020 08:03:41 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710070340eusmtip1f1e7f1b84780f00c5f09ae2300f38d29~gUiy7iV9S1336213362eusmtip1i; Fri, 10 Jul 2020 07:03:40 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Fri, 10 Jul 2020 10:02:23 +0300 Message-Id: <20200710070226.6045-26-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200710070226.6045-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSe0gUexTuzMzOjItb0xT0wyJpqfBGbwtOFG0vZKigqKDoYrbVYJFa7Krd nnjNbFnNzBUjq83cStsiH7mPSqNW0q21RKE2u14TuxFmaVnetKzNdTb67zvn+873HQ6Hp8Vc NoLflZQsG5L0CVpWzTjrBhpnPBH5uNkXvJFY1mAF7Giz0die/y+LWR8yKHxu12G165wK816m UZiT95FCV6mZxXft6Qx297oobK3xcVjYnM5hr+cNhycazwK+GXxL45miT4CNVocKB+7fZrFn sJjBnK9PAU9WeQHrsz8ymH/LDZhpFvDD1RIOba0Tsbfdy6Cv5SaH1/uaaHQ0fAc8VV8G+Dgz oFoySfpadFkl2ao7KclysYmW6loKOCn7oZWSKrrdlNRz9ykr5VTZQXrUkUVL1/7rZ9eqN6sX 7ZATdqXKhlmLt6p3lrsssLdL/VdnYIBOAw9vBp4nwjzyI7DRDGpeFEqB3PFns0rxGUhtbQ2n FJ+AXLlUMsSEDU9cMfUMY1EoAfLqlkoR9QFx3DhJBwlWiCI+k5UKEmOFCpa4Bv1UMG+MsIrU lOqCGkaYQpzOoCaM1wgLSFtzBaMERJJr5feGfcKG+sfMxZwSNpH4L3we9iRCA0+eef8PbbSC /N3fr1LwGPK2vopT8ATis2SHTA+SL5V+Thk2AWkrPhYS6UhV1xMuuBwt/EHKbs9S7rKUODsj FDiSPH8/Oiimh2Ce8zSttDXElCkqHlpy72FzqE3I92/hCpTI1azQOauBnK99AbkQWfg7qQjA DuPkFGNivGyckyTvm2nUJxpTkuJnbt+TWAlDf+r7Ud/rhr7mbR4QeNCGa9wBNk5U6VON+xM9 QHhaO1az7LFvi6jZod9/QDbsiTOkJMhGD4znGe04TXRxZ6woxOuT5d2yvFc2/GIpPiwiDdZP PhjbZM13b0vWdYmCtM6Q7I+9/mjpdu/8wwduTqspX97yYGTG9Ll13hkwfcSCaNu3qYVd9k2v l6fP3TRQ0D9qdiBr4T/zj4dvXmlnNlweJTlSbZ4SsSG3m4tZczTj9ASdFNVhsTrO+Nx/RllM hypjDsW8f1Vb0LT6iyku+njrEa+WMe7Uz5lGG4z6nwdffrqjAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSbUhTcRTG/d97d+9VXNyW0cUPvQwCK5xOM8+i7AWCC30JKorKbLjLJjln u1PMKFeU2SzzrejFbCVaaTSXL9NKy33QappsobXUkhAlVzrnohTLtqxvD+f5PeccOIfGJX4i kk7LMPD6DGW6lAwjHL+7hqLfSOiU2LdisHRXIvj8sQqH4fIhEgq9ZzF4X7sFntkqRFD6yYhB UekUBrb7JhK+Dp8hYMJnw2CwzUHBDdcZCnz2MQou9d5EMDY3jsN18zSC3somEcx0PCFhcu4u AUWzfQguN75E0HVxioDy1hYE+SYGvA/uUVA1uBx8wy8JcLgbKHj43YlDU/cvBCVdFgQ9+fOi rau4WXO1iKt69gXjyu44ca7TfZXiLr6qxDjrRAvGTbb3kVxRYy3iXn8uxLm6kZ/krrADsk16 XZaBX6nRCYbN0oNyiJPJFSCLW6+QyeMTkzfGJUhjkjap+PS0bF4fk3REpqm3laFMT1jOl/kZ 3IjstAmF0iyznq0pmCRNKIyWMNWI9X5wUiZEBwyW9YzgC8wSdq7f9I+ZRmz7c7MoaJBMFOso qMSCRgQzQLJvz58mguElzE627f6WIEMwq9nm5iATSosZBfvRZSUWmq5g6+pf/B0QGqifM92l glrCaFi7twYt6OXsu9t+rBgtMqOQWhTBZwlatVaQywSlVsjKUMtSddrHKHDx5s6Zhhbksu62 I4ZG0nBxyzyZIhEps4XjWjtiaVwaId7e4zgsEauUx3N5vS5Fn5XOC3aUEFiwBI9cmqoL/E+G IUWeIE8EhTwxPjF+A0iXiQuYjkMSRq008Ed5PpPX/89hdGikERnzqkfEln05oypz8qWK6Y1Y iIe0+lbMJlh1MQWuPSpPDP5u3V5nbmz7yR7fyW3jFpT6tI9qvfLLO1zI9I/fPia75nkUVW1Z tUPf77+Vt+aCv2EsWaFWDK2jBtzGE932mkhNTvSPDlt28T7/N416brTJ715sHAsPT5vYf2pN spQQNEr5WlwvKP8Ann6dRgcDAAA= X-CMS-MailID: 20200710070342eucas1p209727bb328f2d2dbe6cefa2f7c237525 X-Msg-Generator: CA X-RootMTR: 20200710070342eucas1p209727bb328f2d2dbe6cefa2f7c237525 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070342eucas1p209727bb328f2d2dbe6cefa2f7c237525 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v7 25/25] examples/vm_power_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/vm_power_manager/main.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index 273bfec29..05aec1aad 100644 --- a/examples/vm_power_manager/main.c +++ b/examples/vm_power_manager/main.c @@ -244,6 +244,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid, count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -267,15 +268,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint16_t)portid, - (unsigned int)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint16_t)portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */