From patchwork Mon Jul 6 20:37:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73314 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 728E9A00C5; Mon, 6 Jul 2020 22:38:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B43E01DD01; Mon, 6 Jul 2020 22:37:59 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 6F3791DCE2 for ; Mon, 6 Jul 2020 22:37:57 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203756euoutp0184c314b6c30ed20aea4014ae3eab52a0~fREnIQ5tC3113131131euoutp01U; Mon, 6 Jul 2020 20:37:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203756euoutp0184c314b6c30ed20aea4014ae3eab52a0~fREnIQ5tC3113131131euoutp01U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067876; bh=BG13JEDguLywByJwOXQTWe6Zorck+0Dg5OriYR0Hx5A=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=omwI+i/B7ZShQSv0JxkxTNO5CPYGsBsqdhhBNtDvngBoA4PSifno2Cs4JiWQMLqWD Gc+uLkqeqb9A+iyWmb1Mxv44+JnT3XT1TIXHikNxEO+AoKhZrviSj5tPpxj/yCdhBT 13ytMQtO6VORLlQAbtgwHWuPWYGPAP487/GI5MQo= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203755eucas1p2358a7b4cadb3c50611f2e5ddf08ece8d~fREmGpIiM1729817298eucas1p2y; Mon, 6 Jul 2020 20:37:55 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 41.C9.05997.3AB830F5; Mon, 6 Jul 2020 21:37:55 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203754eucas1p2d933772e36fe6ae9d4ad29d6d1684294~fRElAk_XG2126321263eucas1p2l; Mon, 6 Jul 2020 20:37:54 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203754eusmtrp2552b748b2dbe2d9926fe3ae8132c516f~fREk-kKFt0640206402eusmtrp2o; Mon, 6 Jul 2020 20:37:54 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-a0-5f038ba388ea Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 4F.6E.06017.2AB830F5; Mon, 6 Jul 2020 21:37:54 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203752eusmtip106a4a5fc007ea709d82a6809adbeb77e~fREjNFNDI1500415004eusmtip1v; Mon, 6 Jul 2020 20:37:52 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:15 +0300 Message-Id: <20200706203743.29416-2-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUxTZxTH89zn9t5LZ/FSu3lkYmenE5cMp/PD2VzGfEvusi/7pjFR7PQO zWh1rTAdXwgqq7xU5WULRXmrG1BceLG86wJdFLqCBl0DLg6wMTGKCgKNqGWOu1uj3875/X8n zznJI1B9Cxcv7Lcekm1Wc5qJ07KtV55e/cCdR1M+/HtgFTb0lxMMjbgpjhX/w2He5DEGhz3J eLHtjAYLR7MYdBY+ZrCtNpfDB2PZLD6aamPw1qUAj67r2TxO+e7yWHCtjODdyH2KpZXTBK+V t2jwaU8nhxORahadz4IET3r7CPbmP2axuKOdYE6uiJN1NTy6by3DqbE+FgM3L/B4PjxIsaV/ juDp3gaCAzkvNJ8vl55V/qKR3BfvMVJR1SCVrtz8iZfy/eWM1PSonZEmfg9yktPrIdKfoTwq 1d+Z5b7S7tB+uldO258h29Z8tlu777exQv6ga8nhUecAn0XOGXJJjADieigq+ZHmEq2gF2sJ +IPHWLWZIVBV0hNtpgk0d7XyL0fmAh0aNaghcKb+eHQ+TKC9v4QoFicmQsBRziiBQWzioC0y xCjBIvET8Fzwz0uCwIorwTe5S8E68WMYzA6z6gtGqG/spooSM6+fvRyvYL24DIYqZhhVjwN/ 6Z3/dTqvH20po+rorAB1tyW13gLdfaNErRfB/V5v9ICl8KKjglHrTHjSPMQra4LoIDBSfTwq JYN3/Cqv7EDF1dDQuUbFG2HWUcUqGMRYGH4Yp64QC4WtP1MV68CRo1dtE3T7r0cxwNzzBSqW 4Hb1HDlFlrteu8X12i2uV89WEuohi+V0uyVVtq+zyt8n2c0We7o1NWnPAUszmf/MgX97Z9pJ Z+RrHxEFYlqgc3A0Ra8xZ9iPWHwEBGoy6DYNBHbpdXvNR36QbQdSbOlpst1H3hZY02LdR9X3 durFVPMh+VtZPijbXqaMEBOfRei48Y3MG27vu5emNySEd7eGxt96L/3E5uA7ExlJW0/eMJ5t WlGQuG3YUGuRipZuOJWxOphZ5AitKt36xfo3f61I1X5ptBqy/kjoSsTi4m3dI1JlqMvfuCey cHYL+6Qg21mWbOwz9jRsd1324l9LPN99UxNuTEiMTA7ln27OC52LXWti7fvMa9+nNrv5P/n9 XzHIAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA03SWUwTURQGYO/c6cyU2GSsNV4xbk0MrtWynhpc4tO8aEh80LiADYxApK3p FIJEI+BGiqIi0Vi1IosLiriwBxcaFUpBgwtSlUWDEJdgQVAhuHQkRt9uzv+dP7nJ4bC6RhHI JZptotVsTNIyAbTnZ0PH4oJsHLO0rohAWbMTwdvOQgzdeR0MZPv2UdBeshLqqs4oILcrnYKc 3AEKqi7ZGfjUnUlD/2AVBa9ve1hwPMlkYdDVx8Lhx6cR9I19wHAq/wuCx84KBYzU1zLweayA hpzR5wiOlDciaDg0QENeTTWCA3YefJcvslD4eiYMdjfS4PHeYuHqcCuGiuYfCI41lCFoOfBL sWqOMJpfrBAK695TwvHzrVh46D3BCofcTkq40V9NCZ/vPGeEnPISJDS9zcbClZ7vTFTARl2k 1ZJsE2cnWCTbcu0mPQTr9AbQBYcadPqQiC3LgsO0S1ZExolJiSmidcmKrbqE0u5cdodjWmpX Tgubjoo0dqTkCB9KfnhqFHYUwKn5YkT2/cxHdsT5A0I+9uBxM5mMtdmZcfMFkYyDT5AcMPw8 4slyUnKg4V8x5OnBDFoOJvPLSMkt958imp9LXL5oeaziDaQ1c5geL51Frly/h2Wi9POzDwLl p5pPJC+HWFmo+ZnkxbkhanxzEnGf6qFlgvkgUuZUy2PsL9lbcRofRZMc/ynHP+X4T+UjXII0 YrJkijdJwTrJaJKSzfG6WIvpJvKfTeXDkfJqZO9f50I8h7QTVVkMjlErjCnSTpMLEQ5rNarV LZ5otSrOuDNNtFpirMlJouRCYf4/HsOBU2It/iM022L0YfoIMOgjQiJCwkE7VZXF129W8/FG m7hdFHeI1r97FKcMTEcL7xVlP/AUZ9yfQL3ybtVYc1vc8yNLO69lblbZo+dSZV3vBrnpPWvN X3sX7WdDdluUI2lRPsXQydS08LzKOeccQZX923Te+trqxhPuhKxd698MKQueCbGP2N6B4Q0v SgeoPYdxUWfo7KaXaVFtV7/lrcHhd9va41tHZzzymQ0XvFpaSjDqF2CrZPwNFNTjbUwDAAA= X-CMS-MailID: 20200706203754eucas1p2d933772e36fe6ae9d4ad29d6d1684294 X-Msg-Generator: CA X-RootMTR: 20200706203754eucas1p2d933772e36fe6ae9d4ad29d6d1684294 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203754eucas1p2d933772e36fe6ae9d4ad29d6d1684294 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 01/25] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is optional. The value ETH_SPEED_NUM_NONE (0) was already part of the API. The value ETH_SPEED_NUM_UNKNOWN (infinite) is added to cover two different cases: - speed is not known by the driver - device is virtual Suggested-by: Morten Brørup Suggested-by: Benoit Ganne Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index a49242bcd..2090af501 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -303,6 +303,7 @@ struct rte_eth_stats { #define ETH_SPEED_NUM_56G 56000 /**< 56 Gbps */ #define ETH_SPEED_NUM_100G 100000 /**< 100 Gbps */ #define ETH_SPEED_NUM_200G 200000 /**< 200 Gbps */ +#define ETH_SPEED_NUM_UNKNOWN UINT32_MAX /**< Unknown */ /** * A structure used to retrieve link-level information of an Ethernet port. @@ -2262,15 +2263,16 @@ int rte_eth_allmulticast_disable(uint16_t port_id); int rte_eth_allmulticast_get(uint16_t port_id); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It might need - * to wait up to 9 seconds in it. + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). + * + * It might need to wait up to 9 seconds. + * @see rte_eth_link_get_nowait. * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. @@ -2279,15 +2281,13 @@ int rte_eth_allmulticast_get(uint16_t port_id); int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It is a no-wait - * version of rte_eth_link_get(). + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. From patchwork Mon Jul 6 20:37:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73315 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85B5DA00C5; Mon, 6 Jul 2020 22:38:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBACB1DD1D; Mon, 6 Jul 2020 22:38:00 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 6CD861DD01 for ; Mon, 6 Jul 2020 22:37:59 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203758euoutp026455cce955f1005a4cc058111853b604~fREpDn8o21760817608euoutp02W; Mon, 6 Jul 2020 20:37:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706203758euoutp026455cce955f1005a4cc058111853b604~fREpDn8o21760817608euoutp02W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067878; bh=vMec8EIsQzAulmX4sPhJTJM/231q/aaNJYVNXJvukBs=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=pivY/YD2dkYt9isW9P8GYgDD6XVJn/eueI8lfmkwy2YVTjVzZeZFVcd4UaSyBf4nT rTVgwblwzIFoTS/6CC/KVnwLy+NX80weE7KD2/xt8tmijCFlukF5ObIlzdqKlutCzb /zfma2aUpEwO1UQ93L6zBoeXANgHWZKwzRhXnmfM= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706203757eucas1p1e18af4b01670a92025ed1ed161de5ea2~fREoJyHMF2452524525eucas1p18; Mon, 6 Jul 2020 20:37:57 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 2E.B6.06318.5AB830F5; Mon, 6 Jul 2020 21:37:57 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203757eucas1p2f59654f60db48ec7164aad3d29ad6dff~fREnxFSpt2126421264eucas1p2p; Mon, 6 Jul 2020 20:37:57 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706203757eusmtrp1bf933607d0fb02c1354191515ed08272~fREnwCuf32965829658eusmtrp1l; Mon, 6 Jul 2020 20:37:57 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-0e-5f038ba5a927 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 7D.CF.06314.5AB830F5; Mon, 6 Jul 2020 21:37:57 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203755eusmtip1873f504ce548404fbb6eea689eb09010~fREl9Ed5S1560515605eusmtip18; Mon, 6 Jul 2020 20:37:55 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:16 +0300 Message-Id: <20200706203743.29416-3-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTdxTG/d93Kl2u1cQTML50M0ODqNOYw2Z0TpPdxJn4YckSN8WqN0Ck YHrBgcQEnDRd2zEtxQ6cyCCKlClQUSoBg6ggVERhBpugdkQloENexA2tYy0Xs2+/85yX5/lw BFrn4KKE5NR02ZRqSNFzGuZy62TXijM2OmHV1J+rsPp2CcH+R+U0BpwPObSNHKXwgXsjNtb/ yqLjcQ6F+Y5RCuvPWTl8ETjC4PBYPYV9TT4ei7uP8DjWMsDjT10nCQ4Eh2gsKh0n2FVyicXJ aw0cvgyWMZj/5j7Bn+tuEWyzjzLovOIlaLaKOFJZwWN530IcC9xi0Oe/yOPvE/dovHT7HcHj bdUEO81T7OdLpDelZ1ipvHGQkgp+u0dLrf4TvGRvL6Gk2mEvJb28ep+T8uvcROrot9FS1ZN/ uO2aHZr1++SU5IOyaeWG3ZqkH50u9kCri2RWFx5jc0h3ppVECCCuhbGzV6gw68RzBCpdyVai CfErAjWBTlotxgkMF46T9xtlRV5ebVQQyLVYOLWYCBVP7Wx4ihNjwGcpocKNeWItB/XB3mmT ueKXYG9wMGFmxKWQO+mcPqsV48FV4GNVi0VQVdMc8haECPFTOHUzSs23EHpPv5q+CeJdAfKe Hp+JtAWGi2tolefCUFsdr/IC8BXYGZWz4W9PL68uWwg8KsubGdoIdc/v8GEzWlwG1Q0rVXkT XDgfnM4A4gfw4K85YZkOoeOya0bWgsWsU6f10NzePSMDvHsbqaIEvsHVavgmAm5b7DGyqPh/ p1JC3GS+nKEYE2VlTar8fZxiMCoZqYlxe9OMHhL6VN+/bRNecjW4p4WIAtFHagMCnaBjDQeV LGMLAYHWz9N+0enbpdPuM2Qdkk1pCaaMFFlpIdECo5+vXVM2uFMnJhrS5f2yfEA2ve9SQkRU DunxR67VHs62GTN6thVFx+7qi58y1LbTnqb0bz57nTy+7qMbz/JGF7tHC2e99vc//zDO25P2 wyff3nBGmga+/uro7OvN8UNO63dU6YbDVQkvLibtN271mswpStHpj/8YyZrjSfLMmqj45Xy0 ee/SpnjKr2nMvNOxOXdx110PHROb3WHbpGeUJMPq5bRJMfwHkHAJZqUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTYRjHe89tR2lxmlZvRmaDLhTNjqY+62JixE4fgiDrQ7c19KSWc7mz SdnNJMw2M10rs8uyRCoNzbQ0MdGBWi0TNbuaiRlRmbeUctjFJX37w+/3XOB5WFIxSvmx8Ykm 0ZioS1Ay3pTrd9O7ZYVWUru8vQtD6VMHgp6uAhK67e8YsA6eIOBV0VqoqbxMg+19KgFZtiEC Km9aGOjrTqOgf7iSgM6HLhlcbEuTwbDzkwxOt1xC8Gn8Cwl5+d8RtDju0TBWX83AwPh1CrLc HQjOVDxC0JQ5RIH9QRWCdAsHg7duyKCg0x+Gux9R4HpdLoPbo60k3Hv6C0FOUymC5vQ/dMR8 wZ1fSAsFNZ8J4ey1VlJofH1eJmQ+dhBCWX8VIQzUdjBCVkUREp70WEmhuPcns8l7m2q10WA2 iQFxBsm0RrmdhyAVrwZV0Aq1ig8O27kyKEQZGL46RkyITxaNgeG7VXGn7Ln0/sZcdKD0XDad itoOWJAXi7kV+HpelcyCvFkFV4iw44kbWRA7ATD+2ktOOj54/IWFmXS+I3zDnUl5AMMtxq4M B+EBvtxbBrefPP4P+HAanFlt+5cpbgE+PmZHnizn1Dj3rIue7DoPF9+pIz3DvLiV+EqDnycq uHj8ZkTmMRScP355dYTIRtPy0ZQi5CuaJX2sXuJVkk4vmRNjVdEG/V00cfL7jWPlVaitbLMT cSxSTpVnMKRWQeuSpYN6J8IsqfSVRza7dinkMbqDKaLRoDWaE0TJiUIm1ssh/WZEGyYeKNGk 5UP4MFDzYcFhwaGgnCXP4Op3KLhYnUncJ4r7ReP/OoL18ktF5y+7rCeSLxyu+zi9WBP+LTIn nR95PD1pfVTSOm0fO7tuzu/IVb9Co/ZE5Zk3Pj9kod0hgR+2rK/mfmxriFlkK6tn915S19gj skp6Rwe6A7D4Y+vCk0kpFefIF21HOkP7muc2zteod858WfJxYMN2a0TZ0c3jJQH6m9HPptYe W5rm1CgpKU7HLyGNku4vLeipCggDAAA= X-CMS-MailID: 20200706203757eucas1p2f59654f60db48ec7164aad3d29ad6dff X-Msg-Generator: CA X-RootMTR: 20200706203757eucas1p2f59654f60db48ec7164aad3d29ad6dff X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203757eucas1p2f59654f60db48ec7164aad3d29ad6dff References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 02/25] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit add function which treat link status structure and format it to text representation. Signed-off-by: Ivan Dyukov --- MAINTAINERS | 1 + app/test/Makefile | 3 + app/test/meson.build | 2 + app/test/test_ethdev_link.c | 278 +++++++++++++++++++++++ lib/librte_ethdev/rte_ethdev.c | 169 ++++++++++++++ lib/librte_ethdev/rte_ethdev.h | 54 +++++ lib/librte_ethdev/rte_ethdev_version.map | 4 + 7 files changed, 511 insertions(+) create mode 100644 app/test/test_ethdev_link.c diff --git a/MAINTAINERS b/MAINTAINERS index 5e706cd7e..f4fb31ea2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -393,6 +393,7 @@ T: git://dpdk.org/next/dpdk-next-net F: lib/librte_ethdev/ F: devtools/test-null.sh F: doc/guides/prog_guide/switch_representation.rst +F: app/test/test_ethdev* Flow API M: Ori Kam diff --git a/app/test/Makefile b/app/test/Makefile index e5440774b..9f43b8c3c 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -251,6 +251,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_SECURITY) += test_security.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c test_ipsec_perf.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec_sad.c + +SRCS-$(CONFIG_RTE_LIBRTE_ETHER) += test_ethdev_link.c + ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y) LDLIBS += -lrte_ipsec endif diff --git a/app/test/meson.build b/app/test/meson.build index 56591db4e..6df31a4dc 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -39,6 +39,7 @@ test_sources = files('commands.c', 'test_efd.c', 'test_efd_perf.c', 'test_errno.c', + 'test_ethdev_link.c', 'test_event_crypto_adapter.c', 'test_event_eth_rx_adapter.c', 'test_event_ring.c', @@ -199,6 +200,7 @@ fast_tests = [ ['eal_flags_misc_autotest', false], ['eal_fs_autotest', true], ['errno_autotest', true], + ['ethdev_link_status' true], ['event_ring_autotest', true], ['fib_autotest', true], ['fib6_autotest', true], diff --git a/app/test/test_ethdev_link.c b/app/test/test_ethdev_link.c new file mode 100644 index 000000000..6709323ef --- /dev/null +++ b/app/test/test_ethdev_link.c @@ -0,0 +1,278 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2020 Samsung Electronics Co., Ltd All Rights Reserved + */ + +#include +#include + +#include +#include "test.h" + + +static int32_t +test_link_status_up_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + printf("Default link up #1: %s\n", text); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 2.5 Gbit/s FDX Autoneg\n", + text, strlen(text), "Invalid default link status string"); + + link_status.link_duplex = ETH_LINK_HALF_DUPLEX; + link_status.link_autoneg = ETH_LINK_FIXED; + link_status.link_speed = ETH_SPEED_NUM_10M, + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + printf("Default link up #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 10 Mbit/s HDX Fixed\n", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + link_status.link_speed = ETH_SPEED_NUM_UNKNOWN, + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + printf("Default link up #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at Unknown speed HDX Fixed\n", + text, strlen(text), "Invalid default link status " + "string with HDX"); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_down_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link down\n", + text, strlen(text), "Invalid default link status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_string_overflow(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + + ret = rte_eth_link_strf(NULL, 2, "status %S, %G Gbits/s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Format string should fail, but it's ok\n"); + + ret = rte_eth_link_strf(text, 2, "status %S, %G Gbits/s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Format string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[2] == 'Y', "String1 overflow\n"); + + ret = rte_eth_link_strf(text, 8, NULL, + &link_status); + RTE_TEST_ASSERT(ret < 0, "Default format string should fail," + " but it's ok\n"); + RTE_TEST_ASSERT(text[8] == 'Y', "String1 overflow\n"); + + ret = rte_eth_link_strf(text, 10, NULL, + &link_status); + RTE_TEST_ASSERT(ret < 0, "Default format string should fail," + " but it's ok\n"); + RTE_TEST_ASSERT(text[10] == 'Y', "String1 overflow\n"); + + text[1] = 'Y'; + ret = rte_eth_link_strf(text, 1, "%S", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[1] == 'Y', "String1 overflow\n"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_format(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + printf("status format #1: %s\n", text); + ret = rte_eth_link_strf(text, 128, "status = %S, duplex = %D\n", + &link_status); + printf("status format #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = Up, duplex = FDX\n", + text, strlen(text), "Invalid status string1."); + + ret = rte_eth_link_strf(text, 128, "%A", &link_status); + printf("status format #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Autoneg", + text, strlen(text), "Invalid status string2."); + + ret = rte_eth_link_strf(text, 128, + "%G", + &link_status); + printf("status format #4: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("40.0", + text, strlen(text), "Invalid status string3."); + + ret = rte_eth_link_strf(text, 128, + "%M", + &link_status); + printf("status format #5: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("40000", + text, strlen(text), "Invalid status string4."); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_return_value(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + ret = rte_eth_link_strf(text, 128, "status = %S, ", + &link_status); + printf("return value #1:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_strf(text + ret, 128 - ret, + "%A", + &link_status); + printf("return value #2:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_strf(text + ret, 128 - ret, + ", duplex = %D\n", + &link_status); + printf("return value #3:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_strf(text + ret, 128 - ret, + "%M Mbits/s\n", + &link_status); + printf("return value #4:ret=%u, text=%s\n", ret, text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = Up, Autoneg, duplex = FDX\n" + "40000 Mbits/s\n", + text, strlen(text), "Invalid status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_invalid_fmt(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 128, "status = %", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string1 should fail, but it's ok\n"); + ret = rte_eth_link_strf(text, 128, + ", duplex = %d\n", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string2 should fail, but it's ok\n"); + ret = rte_eth_link_strf(text, 128, + "% Mbits/s\n", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string3 should fail, but it's ok\n"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_format_edges(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_UNKNOWN, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_HALF_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 4, "%S", &link_status); + printf("format edges #1: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_strf(text, 6, "123%D", &link_status); + printf("format edges #2: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_strf(text, 7, "%A", &link_status); + printf("format edges #3: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_strf(text, 8, "%A", &link_status); + printf("format edges #4: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "It should ok, but it fails\n"); + return TEST_SUCCESS; +} +static struct unit_test_suite link_status_testsuite = { + .suite_name = "link status formatting", + .setup = NULL, + .teardown = NULL, + .unit_test_cases = { + TEST_CASE(test_link_status_up_default), + TEST_CASE(test_link_status_down_default), + TEST_CASE(test_link_status_string_overflow), + TEST_CASE(test_link_status_format), + TEST_CASE(test_link_status_format_edges), + TEST_CASE(test_link_status_invalid_fmt), + TEST_CASE(test_link_status_return_value), + TEST_CASES_END() /**< NULL terminate unit test array */ + } +}; + +static int +test_link_status(void) +{ + rte_log_set_global_level(RTE_LOG_DEBUG); + rte_log_set_level(RTE_LOGTYPE_EAL, RTE_LOG_DEBUG); + + return unit_test_suite_runner(&link_status_testsuite); +} + +REGISTER_TEST_COMMAND(ethdev_link_status, test_link_status); diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index d06b7f9b1..2234af175 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -2383,6 +2383,175 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) return 0; } +static int +rte_eth_link_strf_parser(char *str, size_t len, const char *const fmt, + struct rte_eth_link *link) +{ + size_t offset = 0; + const char *fmt_cur = fmt; + char *str_cur = str; + double gbits = (double)link->link_speed / 1000.; + static const char AUTONEG_STR[] = "Autoneg"; + static const char FIXED_STR[] = "Fixed"; + static const char FDX_STR[] = "FDX"; + static const char HDX_STR[] = "HDX"; + static const char UNKNOWN_STR[] = "Unknown"; + static const char UP_STR[] = "Up"; + static const char DOWN_STR[] = "Down"; + + char gbits_str[20]; + char mbits_str[20]; + /* preformat complex formatting to easily concatinate it further */ + snprintf(mbits_str, 20, "%u", link->link_speed); + snprintf(gbits_str, 20, "%.1f", gbits); + /* init str before formatting */ + str[0] = 0; + while (*fmt_cur) { + /* check str bounds */ + if (offset > (len - 1)) { + str[len - 1] = '\0'; + return -1; + } + if (*fmt_cur == '%') { + /* set null terminator to current position, + * it's required for strlcat + */ + *str_cur = '\0'; + switch (*++fmt_cur) { + /* Speed in Mbits/s */ + case 'M': + if (link->link_speed == + ETH_SPEED_NUM_UNKNOWN) + offset = strlcat(str, UNKNOWN_STR, + len); + else + offset = strlcat(str, mbits_str, len); + break; + /* Speed in Gbits/s */ + case 'G': + if (link->link_speed == + ETH_SPEED_NUM_UNKNOWN) + offset = strlcat(str, UNKNOWN_STR, + len); + else + offset = strlcat(str, gbits_str, len); + break; + /* Link status */ + case 'S': + offset = strlcat(str, link->link_status ? + UP_STR : DOWN_STR, len); + break; + /* Link autoneg */ + case 'A': + offset = strlcat(str, link->link_autoneg ? + AUTONEG_STR : FIXED_STR, len); + break; + /* Link duplex */ + case 'D': + offset = strlcat(str, link->link_duplex ? + FDX_STR : HDX_STR, len); + break; + /* Error cases */ + default: + return -1; + + } + if (offset > (len - 1)) + return -1; + + str_cur = str + offset; + } else { + *str_cur++ = *fmt_cur; + offset++; + } + fmt_cur++; + } + *str_cur = '\0'; + return offset; +} + +int +rte_eth_link_printf(const char *const fmt, + struct rte_eth_link *link) +{ + char text[200]; + int ret; + ret = rte_eth_link_strf(text, 200, fmt, link); + if (ret > 0) + printf("%s", text); + return ret; +} + +int +rte_eth_link_strf(char *str, size_t len, const char *const fmt, + struct rte_eth_link *link) +{ + size_t offset = 0; + double gbits = (double)link->link_speed / 1000.; + char gbits_str[20]; + char mbits_str[20]; + /* TBD: make it international? */ + static const char LINK_DOWN_STR[] = "Link down\n"; + static const char LINK_UP_STR[] = "Link up at "; + static const char UNKNOWN_SPEED_STR[] = "Unknown speed "; + static const char MBITS_STR[] = "Mbit/s"; + static const char GBITS_STR[] = "Gbit/s"; + static const char FDX_STR[] = "FDX "; + static const char HDX_STR[] = "HDX "; + /* autoneg is latest param in default string, so add '\n' */ + static const char AUTONEG_STR[] = "Autoneg\n"; + static const char FIXED_STR[] = "Fixed\n"; + if (str == NULL || len == 0) + return -1; + /* default format string, if no fmt is specified */ + if (fmt == NULL) { + if (link->link_status == ETH_LINK_DOWN) { + if (sizeof(LINK_DOWN_STR) > len) + return -1; + return strlcpy(str, LINK_DOWN_STR, len); + } + + /* preformat complex strings to easily concatinate it further */ + snprintf(mbits_str, 20, "%u %s ", link->link_speed, MBITS_STR); + snprintf(gbits_str, 20, "%.1f %s ", gbits, GBITS_STR); + + offset = strlcpy(str, LINK_UP_STR, len); + /* reserve one byte to null terminator */ + if (offset > (len - 1)) + return -1; + /* link speed */ + if (link->link_speed == ETH_SPEED_NUM_UNKNOWN) { + offset = strlcat(str, UNKNOWN_SPEED_STR, len); + if (offset > (len - 1)) + return -1; + } else { + if (link->link_speed < ETH_SPEED_NUM_1G) { + offset = strlcat(str, mbits_str, len); + if (offset > (len - 1)) + return -1; + } else { + offset = strlcat(str, gbits_str, len); + if (offset > (len - 1)) + return -1; + } + } + /* link duplex */ + offset = strlcat(str, link->link_duplex ? + FDX_STR : HDX_STR, len); + if (offset > (len - 1)) + return -1; + /* link autonegotiation */ + offset = strlcat(str, link->link_autoneg ? + AUTONEG_STR : FIXED_STR, len); + if (offset > (len - 1)) + return -1; + /* Formatted status */ + } else + offset = rte_eth_link_strf_parser(str, len, fmt, link); + + return offset; +} + int rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats) { diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 2090af501..974fee591 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -2295,6 +2295,60 @@ int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); */ int rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *link); + +/** + * print formatted link status to stdout. This function threats all + * special values like ETH_SPEED_NUM_UNKNOWN, ETH_LINK_DOWN etc. and convert + * them to textual representation. + * + * @param fmt + * Format string which allow to format link status. If NULL is provided + * , default formatting will be applied. + * Following specifiers are available: + * - '%M' link speed in Mbits/s + * - '%G' link speed in Gbits/s + * - '%S' link status. e.g. Up or Down + * - '%A' link autonegotiation state + * - '%D' link duplex state + * @param link + * Link status provided by rte_eth_link_get function + * @return + * - Number of bytes written to stdout. In case of error, -1 is returned. + * + */ +__rte_experimental +int rte_eth_link_printf(const char *const fmt, + struct rte_eth_link *link); + +/** + * Format link status to textual representation. This function threats all + * special values like ETH_SPEED_NUM_UNKNOWN, ETH_LINK_DOWN etc. and convert + * them to textual representation. + * + * @param str + * A pointer to a string to be filled with textual representation of + * device status. + * @param len + * Length of available memory at 'str' string. + * @param fmt + * Format string which allow to format link status. If NULL is provided + * , default formatting will be applied. + * Following specifiers are available: + * - '%M' link speed in Mbits/s + * - '%G' link speed in Gbits/s + * - '%S' link status. e.g. Up or Down + * - '%A' link autonegotiation state + * - '%D' link duplex state + * @param link + * Link status provided by rte_eth_link_get function + * @return + * - Number of bytes written to str array. In case of error, -1 is returned. + * + */ +__rte_experimental +int rte_eth_link_strf(char *str, size_t len, const char *const fmt, + struct rte_eth_link *eth_link); + /** * Retrieve the general I/O statistics of an Ethernet device. * diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map index 715505604..6c80597d1 100644 --- a/lib/librte_ethdev/rte_ethdev_version.map +++ b/lib/librte_ethdev/rte_ethdev_version.map @@ -241,4 +241,8 @@ EXPERIMENTAL { __rte_ethdev_trace_rx_burst; __rte_ethdev_trace_tx_burst; rte_flow_get_aged_flows; + + # added in 20.08 + rte_eth_link_strf; + rte_eth_link_printf; }; From patchwork Mon Jul 6 20:37:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73316 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 861BFA00C5; Mon, 6 Jul 2020 22:38:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A59501DD43; Mon, 6 Jul 2020 22:38:03 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E818F1DD2C for ; Mon, 6 Jul 2020 22:38:02 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203802euoutp0138ac6abdbee56d26f02cc75dab862232~fREsoTkWW0553305533euoutp01f; Mon, 6 Jul 2020 20:38:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203802euoutp0138ac6abdbee56d26f02cc75dab862232~fREsoTkWW0553305533euoutp01f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067882; bh=xmD2mOfSPYEySXTKCkIqMp30Ohht0MjEUFipNVMWweQ=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=u0yAn/PDAezN5scMI8Hst/BOqBJGMRJDDaapmczWoJBho/RrFnnzJHMB/ycpBr+xB Q1nirR6M0bWlZIvvTlvT2RW+XluhK9k6NulJp0e8C54oPeOMjBd+LYyaOxQbwo/m1F BB0dTQZSukZSH2TfivtgwEXd4YDtTn2+IhL9sn68= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706203801eucas1p11f4722e39a78de870354e407bc480a6c~fRErmgyrR0771107711eucas1p1n; Mon, 6 Jul 2020 20:38:01 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 63.C9.05997.9AB830F5; Mon, 6 Jul 2020 21:38:01 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203800eucas1p2e1cb90a305258ac2a02fb5de8abc03cb~fREqUe9uK2121221212eucas1p2z; Mon, 6 Jul 2020 20:38:00 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203800eusmtrp2166d799390963ac5a295ca5efce96d76~fREqTdSvK0640206402eusmtrp2p; Mon, 6 Jul 2020 20:38:00 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-a6-5f038ba9c642 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 61.7E.06017.8AB830F5; Mon, 6 Jul 2020 21:38:00 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203758eusmtip1b17497f360182a942e58171c8d362d30~fREob5DxL1791017910eusmtip1i; Mon, 6 Jul 2020 20:37:58 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:17 +0300 Message-Id: <20200706203743.29416-4-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSa0xbZRj2PV97zqGheOxIeMW5xWaaTSPTqcmrWYa3H0cTM36YeInK6nZk U9otPTB3M+IULJeBFpwbk8uKk8tmGNAV6EC2JqOwMubQpWAQyEIkXdnGgE1Btkp7WPz3fM/l e558+URmKuWTxW22LMVus2SaeYPO0z3X/2R9IUt/ynftYWrsqwS6MlLDaKzsT54Kp77iaLAh lTpaf9CTczSHo2LnTY5a6wp4mhzbr6Pr060cDXcGBCof2C/QtG9CoAMXjwBNLFxldLh6Buhi 5Sk9zZ318nRjwaWj4vnLQCXuHiB/0U0dlbW3AeUVSDRVXytQzfAKmh7r0VFgqEWgE7cuMTrV dwfoW38j0IW8iP7FR+T56mN6uaYjxMmlRy8xuXvooCAX9VZyctP1Nk6+8ctlXi52N4B8/koh k4+P/8OnGd41rN+iZG7bqdjXbthk2NpyLsx2lKXsCg3WQw7cXlUAcSJKz+IXQ3+xAjCIJqkO MHwoV4gKJmkW8Oi4rAkzgM3fuYR7ia6KEtCEWsCprhFOO9wCPF3hjbl4aTUGHJUxIVFq4rF1 IchFhWXSBpxpicSwTnoU/+hojwWM0vM42eXSaxUr8fjJM4ujRDFOegErziVrk1ZgsGo2didK v4pYG/59yf8q/jhdxWt4GV71u5emLsdIexWn4b34d3NQ0MIOwBFX7pIpFd3hfiFaxqQ12Ohd q9EvYWlvE0RplBJw8NoDUZotQqfne6bRRnTkmTS3Gc/0DizRiHf+jddoGZ2Tc4L2PJ2Ad4Mn 2Dewsvz/rmqABkhSslVrhqKusymfpqgWq5pty0jZvN3aDItfNXDXP9sG3oUPfSCJYI43OniW btJbdqq7rT5AkZkTjS9fCHxgMm6x7N6j2Len27MzFdUHD4k6c5LxGVfofZOUYclSPlGUHYr9 nsqJcck5YPh4tNxxrO/1konQpu5Xxu93tNh69iZ8Lbd3DpXtMhnT3KH+I2+dHH1TDf989nDu nvmBjLonUuPXee7b+Njpt5e/k7zev+/2RyPVB79kqqd3/idv22/v1UTy82caXxtI21hefH6y KN+z742ErNTCA4mRpOecxjWrOqzDXOLqzz97MEibvWadutXy9OPMrlr+A/naeDWmAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d++UVpe56IfYw1UQgatNzTPR9YK8f4kWRPTSpbcpOSf3 bqVCpFJm0zTLgl5mmmVWmDpTwzQNs1omVpZmlo3KSpmvlCx7bEn/fTjf7znnC+dISfk45S2N TzTzQqI+QUl7UvbfbX1+Zdlk1KqfHyVQ8aQQgeNtCQn9BX00ZI8cIqC7fA001J6XwIl3aQTk nhgloLbMSsNQfwYFzrFaAt7ctTNw9lkGA2MtAwwc6ziHYGD6KwlnisYRdBTWSGCq+Q4Nw9PF FOT+6EKQZ3uIoC1nlIKC+joEmVYWRq5dZaDkzUIY639Igb2nmoEbE50k1Dz5hSC/rQJBe+Yf yVpf7kdRqYQrafhCcCcvdZLcg57TDJfzqJDgKp11BDfc2EVzubZyxD12ZJPc9Q/f6QjPbaoQ wWQx84vjTKI5VLldDRqVWgsqTYBWpfYP2hmsCVSu1IXE8gnx+3hhpS5aFVfdOkgmFaiSv3Rf Q2locqkVeUgxG4CbLuQhN8vZUoSr0sKsSOqqYzz4gZyxeOHpl1baijxdlnGEu/ryCbdAs8ux PauQcAsKtpfGz4+kU27Bi9Xh8eo//0wUuwy/bqhn3CxjtXioqVgyM3URvn7rHule5sEG4wut 3m6Us/H49TdmJs5C/OriN+I4mlOEZpUjBW8RjQajqFGJeqNoSTSoYkzGKuQ6+O0HU7Y6ZHVu bkGsFClny7JoMkou0e8TU4wtCEtJpUK2vt2+Sy6L1aek8oIpSrAk8GILCnTFyye958WYXO+T aI5SB6qDQKsO8g/yXw3K+bIstnmHnDXozfxenk/ihf99hNTDOw1t0aU6fGKfLt0uO95sWLXR YUkXFLVtvhu2bM0jwi7bGgcmfHw3OQ8X8Ytj/MIfV0Z+HpjamHlwd+flT37hi5Z03S+VvpjM Xze0v/fG4I4rB0S6IiV0rn5P5Puy2Kqv8SlHiyNsyryG1Mbed1nMqZsLdFXDOsGZvN8jWhFJ yUzp5holJcbp1StIQdT/BQ8mMRQGAwAA X-CMS-MailID: 20200706203800eucas1p2e1cb90a305258ac2a02fb5de8abc03cb X-Msg-Generator: CA X-RootMTR: 20200706203800eucas1p2e1cb90a305258ac2a02fb5de8abc03cb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203800eucas1p2e1cb90a305258ac2a02fb5de8abc03cb References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 03/25] app: UNKNOWN link speed print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 9 +++------ app/test-pipeline/init.c | 11 +++++------ app/test-pmd/config.c | 20 ++++++++++++-------- app/test-pmd/testpmd.c | 9 +-------- app/test/test_pmd_perf.c | 17 +++++++---------- 5 files changed, 28 insertions(+), 38 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab..4a4c572c3 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -685,12 +685,9 @@ show_port(void) printf("Link get failed (port %u): %s\n", i, rte_strerror(-ret)); } else { - printf("\t -- link speed %d duplex %d," - " auto neg %d status %d\n", - link.link_speed, - link.link_duplex, - link.link_autoneg, - link.link_status); + rte_eth_link_printf("\t -- link speed: %M, duplex: %D," + " auto neg: %A, status: %S\n", + &link); } printf("\t -- promiscuous (%d)\n", rte_eth_promiscuous_get(i)); diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c index 67d54ae05..b59064672 100644 --- a/app/test-pipeline/init.c +++ b/app/test-pipeline/init.c @@ -155,7 +155,7 @@ static void app_ports_check_link(void) { uint32_t all_ports_up, i; - + char link_status_text[50]; all_ports_up = 1; for (i = 0; i < app.n_ports; i++) { @@ -173,12 +173,11 @@ app_ports_check_link(void) all_ports_up = 0; continue; } - - RTE_LOG(INFO, USER1, "Port %u (%u Gbps) %s\n", + rte_eth_link_strf(link_status_text, 50, "(%G Gbps) %S", + &link); + RTE_LOG(INFO, USER1, "Port %u %s\n", port, - link.link_speed / 1000, - link.link_status ? "UP" : "DOWN"); - + link_status_text); if (link.link_status == ETH_LINK_DOWN) all_ports_up = 0; } diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index a7112c998..cb2795a94 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -604,10 +604,9 @@ port_infos_display(portid_t port_id) } else printf("\nmemory allocation on the socket: %u",port->socket_id); - printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down")); - printf("Link speed: %u Mbps\n", (unsigned) link.link_speed); - printf("Link duplex: %s\n", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_printf("\nLink status: %S\n" + "Link speed: %M Mbps\n" + "Link duplex: %D\n", &link); if (!rte_eth_dev_get_mtu(port_id, &mtu)) printf("MTU: %u\n", mtu); @@ -730,6 +729,8 @@ port_summary_display(portid_t port_id) struct rte_eth_link link; struct rte_eth_dev_info dev_info; char name[RTE_ETH_NAME_MAX_LEN]; + char status_text[6]; + char speed_text[12]; int ret; if (port_id_is_invalid(port_id, ENABLED_WARN)) { @@ -750,12 +751,14 @@ port_summary_display(portid_t port_id) if (ret != 0) return; - printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\n", + rte_eth_link_strf(status_text, 6, "%S", &link); + rte_eth_link_strf(speed_text, 12, "%M", &link); + printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %sMbps\n", port_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], mac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name, - dev_info.driver_name, (link.link_status) ? ("up") : ("down"), - (unsigned int) link.link_speed); + dev_info.driver_name, status_text, + speed_text); } void @@ -3899,7 +3902,8 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) ret = eth_link_get_nowait_print_err(port_id, &link); if (ret < 0) return 1; - if (rate > link.link_speed) { + if (link.link_speed != ETH_SPEED_NUM_UNKNOWN && + rate > link.link_speed) { printf("Invalid rate value:%u bigger than link speed: %u\n", rate, link.link_speed); return 1; diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 4989d22ca..a1b9c1c1c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3010,14 +3010,7 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. speed %u Mbps- %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_printf(NULL, &link); continue; } /* clear all_ports_up flag if any link down */ diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index 352cd4715..7ebe4efae 100644 --- a/app/test/test_pmd_perf.c +++ b/app/test/test_pmd_perf.c @@ -126,6 +126,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status[50]; printf("Checking link statuses...\n"); fflush(stdout); @@ -146,16 +147,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) { - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - if (link_mbps == 0) - link_mbps = link.link_speed; - } else - printf("Port %d Link Down\n", portid); + if (link.link_status && link_mbps == 0) + link_mbps = link.link_speed; + + rte_eth_link_strf(link_status, 50, NULL, + &link); + printf("Port %d %s\n", portid, link_status); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73317 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5CD4A00C5; Mon, 6 Jul 2020 22:38:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4FCB1DD4D; Mon, 6 Jul 2020 22:38:06 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id B38CF1DD4D for ; Mon, 6 Jul 2020 22:38:05 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203805euoutp02ae694034166a5d9f698ca0384710b589~fREvPPgpq1760117601euoutp02U; Mon, 6 Jul 2020 20:38:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706203805euoutp02ae694034166a5d9f698ca0384710b589~fREvPPgpq1760117601euoutp02U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067885; bh=uryTUJWnZHC1KobIzwDiYco1DBs90ldLDdgUZPnDwJM=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=UNHArXEyxz9X1VxsexMxvzRSUP48tXhZSfOgBLgzt///WuseOd32BGf2ru5hXTqy/ sCruTI+2NS2aYt0BGYk0c0KX+KRPCqdcKMb+ot0XUwLEB+QL24pcZ8cCTWVLYOAbON FGH/yMVZUkhCrUaQGhWNLtCrFsZvowK6ziWAc85c= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203804eucas1p2b6597dd7bde6555a3d4c7637ca18b26f~fREuNUuwa2099120991eucas1p2o; Mon, 6 Jul 2020 20:38:04 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 40.C6.06318.CAB830F5; Mon, 6 Jul 2020 21:38:04 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203803eucas1p26fa02f91c1c5f94b8ce724a75b341f31~fREs7J7e92121221212eucas1p20; Mon, 6 Jul 2020 20:38:03 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203803eusmtrp2d1375f922fcafabbc728621b35d70b43~fREs6Wwk20640206402eusmtrp2q; Mon, 6 Jul 2020 20:38:03 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-15-5f038baccfd0 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 83.7E.06017.AAB830F5; Mon, 6 Jul 2020 21:38:02 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203801eusmtip116ff548553f824b861a12723b3d063c5~fRErIEsgk1500415004eusmtip1w; Mon, 6 Jul 2020 20:38:01 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:18 +0300 Message-Id: <20200706203743.29416-5-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0xTZxjG853v9JxDtcuhmPAGF5Aum7JEHWMmr4aIF/44SxbHP0uWJYpV jngBJC143RKCg5HiUC5hEy0UqqviBWFAEYFhEYtUuQbBiIC4xekmCAoMKSDl1Oy/5/09z/s9 yZtPoNo8LkDYl5AkGxL0cTpOzVbfmW5ffSWTRn+WbfPFsnuFBIcHrBSH8h5zmPnqRwb7SiOw zn5OhTmDKQxm5YwxaL9o4vDfoVQWR8btDPbXu3gs6ErlcdzxjMef288SfOZ+QfGM5TXB9sIq FU7fquVw1F3CYtbbHoKnKlsIOk+OsZh3o4ZguknEV5dsPFr7A3F8qIVF18Pfebwy0Umx6t4s wWxnGcH76fOqTcHSW8sFlWSte85IucWdVLrzMJ+XTt4tZKTykRpGGm3o4aSsylIitQ5nUuny n/9xUerv1OExcty+Q7Jh7cad6r1pw+eZxPklR2wdj1UpZEYwER8BxC8ge66RmIha0IoXCcyn 5LPK8IbALXOa13lNYNRxinu/Mv5rrjdlI9DRPcIowwSB4hP9iylOXAWujMJFY5lYzoHd3ct4 DD9xK1iu/UU8mhU/hqa5UurRGnE9/O3OYpWKILh8vXGBC4KPuAHMzQEerBUDobfozeKbIHYI MGO5wCv5SLj9qIAq2g9eOCu9/EOYv1HEKPo4TFX08spyBoGBkjRvKAIq/2njPWVUDIGy2rUK 3gyDzadZDwbxA+h76evBdEHmVP9CFayBjHStktZB490uLwaYnVmqYAmemFKpcp56AtMtRexp ElTwf5eFkFLiLycb42NlY1iCfHiNUR9vTE6IXbP7YHwFWfirrjnnRA1pcO9yEFEguqWaIYFG a1X6Q8aj8Q4CAtUt02y579qh1cTojx6TDQejDclxstFBlguszl8TVvJ8u1aM1SfJB2Q5UTa8 dxnBJyCFyMv35H89wCVt7IxO0y3JDV7X5m4fszXNFN+kkZu7635oC91/ab9pw3RTVZhf30/h f0SsX6UeSUy2Vpujggc26ZqsNz8x/xY0NnXe3uz+furbrxz22daP7D67oObzruanJa0dUStW Xi1+UNsf9KX/E//bkznmA77h3ww6twVOhkROhubqWONefein1GDUvwNbW29ppwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa1BMcRjG/c85e86pLMeW8Z/9EHYwmGmzpXpLch3ON4bxRal26nQZbWv2 bE0xxmrospH7nbUksRmRTSFGK23ZmtCkonSZKDRtbZkhhVbj2zPze97nfWeelyVlY5ScTU7V C7pUdYqC9qQcv+2dfpZ8MmZF95kwKG0wIej9WEhC9+lOGvKHDxHQZlkDVRWXJXCyy0BAwckR AipuGWkY7M6iYMhVQUDHUwcDF99mMeCy9TNwtOkSgv6JryRcMI8iaDKVS+Bn9WManBPXKSgY b0FwzFqHwH5khILTjyoRZBs5GL5dzEBhhy+4uusocLQ/YODO9zcklDdMIjhhL0XQmP1HsnYh P24ukvCFVV8I/tS1NyRf236W4Y/Umwj+/lAlwTuftdB8gdWC+Fe9+SRf0veD3uq5Uxmu06bp hQVJWlG/WhGpggClKhSUAStDlarAkF1hAUEK/4jweCElOV3Q+UfEKpMO994g9vzxyih+3Skx oF+sEXmwmFuJXedPUUbkycq4IoRbc1zIiNgpgPG3PnLa440n3hnpac8owvXnJmk3oLml2JFr ItzAh/tA4+acg5QbeHMbsPnuJ+TWFLcYv/ht+Zck5ULxwEQBNZ06H5fce066l3lwYfjKS7lb yrhk/H6McTtknC9uvTpGHEezzGiGBfkIaaImUSMGKEW1RkxLTVTGaTVlaKrxh7U/rZXIOLTd hjgWKWZKc2kyRiZRp4uZGhvCLKnwka5vdETLpPHqzL2CThujS0sRRBsKmjrvBCmfG6ed+p9U fYwqSBUCoaqQwJDAYFDMk+Zy1VEyLlGtF3YLwh5B93+OYD3kBmQeFwbnDPRI+8sS0rdemHn3 +OHyUjuzRrlx76YeX6up5lCUPPqqZPjmtmUZB7yGmNa4fe+KbfsTkvyO2cXE69ZV8Ck6gZCH V3+P3FFzWWyc3dIoLqnWrnN+znvywzB3s1dTXU77lmChwX99c3PZrq7Yop5CVRPltBvanIuM kXmdCkpMUquWkzpR/Rc2As6wBwMAAA== X-CMS-MailID: 20200706203803eucas1p26fa02f91c1c5f94b8ce724a75b341f31 X-Msg-Generator: CA X-RootMTR: 20200706203803eucas1p26fa02f91c1c5f94b8ce724a75b341f31 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203803eucas1p26fa02f91c1c5f94b8ce724a75b341f31 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 04/25] doc: update sample app with unknown speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- doc/guides/sample_app_ug/link_status_intr.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst index 04c40f285..596782b9d 100644 --- a/doc/guides/sample_app_ug/link_status_intr.rst +++ b/doc/guides/sample_app_ug/link_status_intr.rst @@ -158,6 +158,7 @@ An example callback function that has been written as indicated below. { struct rte_eth_link link; int ret; + char link_status[200]; RTE_SET_USED(param); @@ -169,11 +170,10 @@ An example callback function that has been written as indicated below. if (ret < 0) { printf("Failed to get port %d link status: %s\n\n", port_id, rte_strerror(-ret)); - } else if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + } else { + rte_eth_link_strf(link_status, 200, NULL, &link); + printf("Port %d %s\n\n", port_id, link_status); + } } This function is called when a link status interrupt is present for the right port. From patchwork Mon Jul 6 20:37:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73318 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1FAEA00C5; Mon, 6 Jul 2020 22:38:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 76B9E1DD17; Mon, 6 Jul 2020 22:38:09 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 879DD1DD33 for ; Mon, 6 Jul 2020 22:38:07 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203807euoutp013fa44a49f07bcd972343e5e00df0183a~fREw1fdcY3113131131euoutp01V; Mon, 6 Jul 2020 20:38:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203807euoutp013fa44a49f07bcd972343e5e00df0183a~fREw1fdcY3113131131euoutp01V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067887; bh=1R9omrZ5fAPdKYuUkOS/6cuY8buXbZ+pEv8UB5bwG/w=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Uwu5n5Dm8LK70x9ab+MMO+56w1QF8MOgqiKs1Eycqt0LcijdFpsi0ajrVTVYgutnV 9qO2+cbUfQSnbtqQbtzU7s2QAe0pBd79YjMKeOADlfS+HqZGsWo6ex7LI0KkZfKUFo BHXtFhASb2HYvDdX8ML6AAy+TpsrugOym6Hv/Zws= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706203806eucas1p156a7f508ed49c394902c2e6d9ffb3a0c~fREvy2jIl2654826548eucas1p1z; Mon, 6 Jul 2020 20:38:06 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 85.C9.05997.DAB830F5; Mon, 6 Jul 2020 21:38:06 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203805eucas1p2b8c92ded7d87356c788dec9e936edf43~fREvZqmMg2126821268eucas1p22; Mon, 6 Jul 2020 20:38:05 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706203805eusmtrp1aa475548ce5dc19f68f645570a930959~fREvY1Kxi2965829658eusmtrp1n; Mon, 6 Jul 2020 20:38:05 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-ac-5f038bad7e7a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id BF.CF.06314.DAB830F5; Mon, 6 Jul 2020 21:38:05 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203803eusmtip11ebc3a371d7f55e23ddf4c0ba82f564d~fREti7PCk1791017910eusmtip1j; Mon, 6 Jul 2020 20:38:03 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:19 +0300 Message-Id: <20200706203743.29416-6-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTH89x7e++loXpXNJwwwdjE6Ex8AV9yXBadcx+ufpnJlhh1G9Zx g8RSTCuI7gtz2jRtqQq+RBwvpSgKDkQLBQaKGC1QFK1BZONN1Ck6AYEOQdjG9dbs2++c//85 /5OTh6e1TjaKTzLuk0xGvUHHqpmq2xNtS8vsdPyKyQQsb80j2N/jprHvRDeL9uHDFD4qWY91 3l9UmNWbQaEz6w2F3gs2Fv/qO8Tg4IiXwq56P4c5gUMcjjQ+5zCz7SzB51MvaTxTMEqwLa9S hRM3alkcmipk0DnZTvCop4mgz/GGwRM11QQtNgGHLxZz6O6KwZG+Jgb9nVc5vBS8T2Nl6zTB 475ygncs/6o+XyBOFpxTie66AUrMdt2nxdudpzjR0ZxHiRWD1ZQ4dK2dFZ2eEiK29NtpsfTp W3aLerv6swTJkJQmmZav26ne3VS2f28Ll/6k6AabQapYG+F5EFZBl+UjGwnjtcIFAmUjUTai nuExApl1r1RKMUrAFiyiZZf8oHy4ilaEYgKnJ86HiiCBnyveqWQXKywGvzWPkoU5QgUL3qkO ShYihI0wWOlkZGaEheB2FLwfqxHWwm8Px0MR86H0cgMt7xcmfAq5t6KU/WKgI3+MUiytPPwx lKbwl1D5ooZTOAJe+jwhngf+bAej8I8wfqWDk/cBwUqgp/BIyLQePK/ucnIWLXwC5bXLlbNs gEDJGgVnwaPX7y9Ez2BW1WlaaWvAatEqM3TQ0BwItQGm34UrbRHa3ZcZ5Tj1BH7yuahjZH7O /1EFhJSQSCnVnJwomeOM0v5lZn2yOdWYuOyHlOQrZOaX+v/xjVWT2qldjUTgiS5cY2XpeK1K n2Y+kNxIgKd1czRf3PF/r9Uk6A8clEwp8aZUg2RuJB/zjC5Ss7Jw4DutkKjfJ+2RpL2S6YNK 8WFRGSRyV2mD69eOwNe5beMnJ551GnpWRwQcK/KbLb2eg/b0Ykjp7y7a6h4Ibo5O+zb279Wj D+9tCv8qPdqdk28vZSfVvd6t/Ql9S2ucc7/JXuTa0QWuI9uO/mk1PXjybDwm1xdtunh9S9zV lJbfSXD68aW53doXh1/PNtQvnFVsiDPe7MnUMebd+tgltMms/w82DOEooQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa1BMcRjG/c85e84Wa04r/DVGWsMYk2Xbsu+mcp1xjC9mfMtlLc5Uaneb PbuUT2lUa8tSGhElatGFZLshRqHblktNUW6h0bhlu1BMoS2+PTO/53nfd+Z5xaR0iPIRR+lN vFGvjZHRnpTzd8Or5VdTSc3Kt01+UNqSi+Dd63wSejJf0ZDqOkLA86I1UFN1TgQZbxIIsGUM EFB1xUrDl55ECvoHqwh4ecfJQHZbIgODdX0MHHt8FkHf2CcSzuQNIXicWyGCn7W3aPg2dpEC 268OBMfLGxE0pA1QkHmzGkGylQVX4WUG8l8ugMGeRgqcXQ4GSr4/JaGiZRxBekMpgtbkP6K1 ftyvPLuIy6/5SHAnLzwlufquUwyX1pRLcGX91QT37W4HzdnKixDX/C6V5Ip7R+mtnuHyEKPB bOIXRhoEU6hsuwIC5Ao1yAMC1XKFUrUzOCBItiIsZB8fE3WAN64I2y2PbLx2MLaZiXtfUEsn oEraijzEmA3Epa5K0oo8xVLWjnBJzwfGisQTAOPPveSUZxYe67TSU54hhLM6bZOAZpdipyWX cANv9gWN21MOU24wi92A+ytsk5piF+P8tLzJgIRV49udI/+m+uLi6/dI9zIPNhjnPPRxSykb hbuHGbdDyi7Az84PEyfQzDw0rQh582ZBF6ETFHJBqxPM+gj5XoPuBpoovLL+p6MatZVtq0Os GMlmSCw0qZGKtAeEeF0dwmJS5i1Z3+rcJZXs08Yf4o0GjdEcwwt1KGjivHTSZ/Zew8T76E0a RZBCBWqFSqlSrgLZXImFrd0hZSO0Jj6a52N54/8cIfbwSUBEe47FtajgrKxzdMueo42H4rqI 0KYyzphy6a6f7p6geeSgstQDrukjhnmbHDnXmSCL95N1+3eEf/yhK7w6cj8u+3R2wepVhV5f 7dHjNv/umiXzy9OnfTVneMWUbA4ZdtwMXutffH7jQGpYc6/L3+P+3LGAB3Alqflhkq99TjLp UsooIVKrWEYaBe1faCDrWwYDAAA= X-CMS-MailID: 20200706203805eucas1p2b8c92ded7d87356c788dec9e936edf43 X-Msg-Generator: CA X-RootMTR: 20200706203805eucas1p2b8c92ded7d87356c788dec9e936edf43 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203805eucas1p2b8c92ded7d87356c788dec9e936edf43 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 05/25] net/ixgbe: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov Reviewed-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 248f21d14..34a171116 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4300,11 +4300,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, switch (link_speed) { default: case IXGBE_LINK_SPEED_UNKNOWN: - if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T || - hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L) - link.link_speed = ETH_SPEED_NUM_10M; - else - link.link_speed = ETH_SPEED_NUM_100M; + link.link_speed = ETH_SPEED_NUM_UNKNOWN; break; case IXGBE_LINK_SPEED_100_FULL: From patchwork Mon Jul 6 20:37:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73319 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F1E6A00C5; Mon, 6 Jul 2020 22:38:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE3DE1DD5C; Mon, 6 Jul 2020 22:38:11 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 2E8391DD58 for ; Mon, 6 Jul 2020 22:38:10 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203809euoutp02882c6360ad5a199e37eb276a88e53f1c~fREzZmGZS2313123131euoutp02n; Mon, 6 Jul 2020 20:38:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706203809euoutp02882c6360ad5a199e37eb276a88e53f1c~fREzZmGZS2313123131euoutp02n DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067890; bh=zbg2xoSaiDgck4H57R7Z3rwqX+vJJlCAoA2nccHDMek=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=as9JyEYZ6wwk5bTXT+9BWYcc90u5m8SjwvUcldbqF30G13uR/t97hnwquBMrnZdGj XnO8kqT1v6zHtk3EoPRfHKKszmPxGU5XgVObHJIis7jc5/QwV4q/c+I5tr1aB1nyAv SfQY3jQmit4gfMEkAcXHLs0aizsQAXZepBxr/Jro= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203809eucas1p21e0ffc3cf33b6835355e0c383b926cc6~fREylpNeZ2126821268eucas1p23; Mon, 6 Jul 2020 20:38:09 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 62.C6.06318.0BB830F5; Mon, 6 Jul 2020 21:38:09 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706203808eucas1p149298d8c1de1cea35fe9dd22e5a81ea4~fRExp1q6b0771507715eucas1p1l; Mon, 6 Jul 2020 20:38:08 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706203808eusmtrp1d8614b6a92369aa205ac8661b8b53297~fRExoyO8s2965829658eusmtrp1o; Mon, 6 Jul 2020 20:38:08 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-1b-5f038bb0af59 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id D1.DF.06314.FAB830F5; Mon, 6 Jul 2020 21:38:07 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203806eusmtip19134c09a620660a39f46d64534b7eed6~fREv12HYW1560515605eusmtip1_; Mon, 6 Jul 2020 20:38:06 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:20 +0300 Message-Id: <20200706203743.29416-7-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTdxTGc+69vffSUHapJpygkdhlyVyGbMEPZ8s2nVmym/nFZUtMlih2 8wYNr2mt4vwAcYpNizAK04zxJt1EwYVVSstYJVIHyAoUSEjFIRIlccBErFbR1XWWW7Nvz//3 POclJ3+R1Vfz6eKBwoOKqdCYb+C1nGfgaTDTZWdz3qrLoY7hRqDbM06WZmtv8mRfPs7Q9bat 5PPWa8hxq4yhSscDhrznbTz9PXuMo6Wwl6HpywGB6iaOCRT23xXoVPAHoLvRBZa+b34IFGzs 0tDTvh6e7kdbOKp8NglU5b4GNFjxgKPaX7uBym0SLV9oFcg5vYHCs9c4Ckx1CnQxMs5S1/Bz oOrBDqCR8phm20b5WfNPGtnpm2fkmrPjrDwwdVqQK4YaGdm11M3I93snebnS3QbyH7ftrNw+ t8Lv1H6hfW+fkn/gkGLK+mCvdr91/IZQPJZS4ulpZsqgIdkGSSJKW7BqbJG1gVbUS+cB51sq NOrjEWDDUL0mntJLDwFXTpteVnhc45waagWMnWhPlEcAnef6IJ7ipdcxYG1k4sZaycWjNxpi 4sYaaTu6u3pX23LSa1g9UiXYQBR10ju41FeqTsjA9l+usHGcJL2LDf3p6hIbMNT0aLUlSsMi +u4NCWr+I/RYVxJ6DS4MuhN6PQZqKjhVH8Unl0KCWmwFnGk5kQhtRffi6OoOrLQJO3qyVPwh fvOdg4tjlFLw+r3UOGZfSIfnDKtiHVrL9WragFeGJhIY8fk/iePKGPk5wqvXuQzoOWuDbyGj 7v9ZzQBtkKZYzAW5ijm7UDm82WwsMFsKczd/VVRwCV581MC/g5Fu6I1+6QdJBEOyblZkc/Qa 4yHzkQI/oMga1uq2jwT26HX7jEe+VkxFOSZLvmL2wzqRM6Tpslvmd+ulXONBJU9RihXTS5cR k9LLwLL0e8rGUxf9ywujJa82lK6Plkz/lhf4tGlh59Ws0OefLet2zWTGdmTuam+CHY5zpWf6 gjWjwQzpzY+FmKF1EncXLz4+OTFQkuaC49lP5l7pvFNbX2v4xJ5qT/7Tlxx+31LkvJo6ta3/ R1/enE57I+LNPznWeac/XBqy/1W2N3Y0ZuDM+41vv8GazMb/ALd5p+KkAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSe0hTcRj1d+/dvVdzcplWP4TKRoIVza7PTzOT6HEhgqA/pIetYddXzsnu tJQge1BrmqZJYA/TppQameXU0h5aPmpKzVCbaQ0RJAvN9aDCrE3pv8M55zscOB9LKpyUP5ua YRD1GZp0Je1FWee6R9fV55Pq9cMnYqC+txzB2HszCY7SURryv5wm4G3tJmhrviqDkg95BBSW zBDQfMtEw2fHSQqmnM0EjDyyMnC5/yQDzo4JBs6/uoJgYnaShLKKrwhelVtk8Kv9IQ3Tszco KPw9gKCosQdBd8EMBaUPWhCcMXHwpeYmA+aR5eB09FBgtd9n4PZ3GwmW3j8IirvrEfSd+SuL Wyn8rqiWCea2j4RwsdJGCl32S4xQ8KKcEBqmWghh+vEALRQ21iLh5Vg+KdSN/6R3ee1Vxeh1 WQYxIEUnGTYq9/EQouKjQBUSFqXiQyMTokPClcGxMYfE9NRsUR8ce1CVYrQNM5mvfY42Pawg 8tA1bxPyZDEXhpsabJQbK7hqhOcakkyIdfEYfxonFyy+eHbQRJuQl8vyFeHZO2PzfpoLwlZj OeEW/Lh3NH5z9sS84Mttxo2WxzI3prhAXNxXxLhD5VwUnmo/vhC6AtfdfUq6aU8uGl/r9HdD BZeKh78xC22W46Hr34gLyKcCedQiPzFL0iZrJV4labRSVkayKlGnvYdcezd1/brfgvobdncg jkVKb7mRJtUKmSZbytF2IMySSj/55j7rAYX8kCYnV9Tr1PqsdFHqQOGudsWk/+JEnet7Mgxq PpyPhCg+MjQyNAKUS+VGrn2/gkvWGMTDopgp6v/fEaynfx4qrHpuYRlLUBKVGF158dRQq9PH eOT2It+NiknHqmo1mzBxwRq+9lhgRFlOjTnX4r1ja1Xc+e2e+6drTUfWbHkW7OTOmcdsM/bV rVaHaklVmkfbBnunIb6qLCRxJ/9jcK7Ed0VrmumJFJ/z4PWkNmgZISQYguRlgw77Nk3ungBe SUkpGn4NqZc0/wAQ8yy+BQMAAA== X-CMS-MailID: 20200706203808eucas1p149298d8c1de1cea35fe9dd22e5a81ea4 X-Msg-Generator: CA X-RootMTR: 20200706203808eucas1p149298d8c1de1cea35fe9dd22e5a81ea4 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203808eucas1p149298d8c1de1cea35fe9dd22e5a81ea4 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 06/25] net/i40e: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c | 5 ++++- drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 472ce2a9e..f718356b5 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2891,7 +2891,10 @@ update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link, link->link_speed = ETH_SPEED_NUM_40G; break; default: - link->link_speed = ETH_SPEED_NUM_NONE; + if (link->link_status) + link->link_speed = ETH_SPEED_NUM_UNKNOWN; + else + link->link_speed = ETH_SPEED_NUM_NONE; break; } } diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index eca716a6a..cf931bf9c 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2163,15 +2163,15 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, new_link.link_speed = ETH_SPEED_NUM_40G; break; default: - new_link.link_speed = ETH_SPEED_NUM_NONE; + if (vf->link_up) + new_link.link_speed = ETH_SPEED_NUM_UNKNOWN; + else + new_link.link_speed = ETH_SPEED_NUM_NONE; break; } /* full duplex only */ new_link.link_duplex = ETH_LINK_FULL_DUPLEX; - new_link.link_status = vf->link_up && - new_link.link_speed != ETH_SPEED_NUM_NONE - ? ETH_LINK_UP - : ETH_LINK_DOWN; + new_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN; new_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); From patchwork Mon Jul 6 20:37:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73320 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C9B9A00C5; Mon, 6 Jul 2020 22:39:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 65BE91DD6A; Mon, 6 Jul 2020 22:38:13 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1BCD01DD60 for ; Mon, 6 Jul 2020 22:38:12 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203811euoutp027eb75536888c2931ca53a4cc0b286131~fRE1KPYIC2670026700euoutp02U; Mon, 6 Jul 2020 20:38:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706203811euoutp027eb75536888c2931ca53a4cc0b286131~fRE1KPYIC2670026700euoutp02U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067891; bh=8FgdUe6Aml3rB/AWNSgZoZqeJOx9OS3/lqpbs6iX2+c=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=peHmCu/BlsUbVbdVCw6fOa095V2fNv/cj86XwQMhCUX0pCb1V7CN+o85VCtBvW+Tm al4Q6Kn2u1+we3/0B8kCZwaco3uYre0ToW1whzLi8h/QzjDFrtuVFsWFyh0+IMMvbs rnz6EVSY5bFRw6For7Hqf82jxObWFfsa0C6PiFHw= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203811eucas1p2de07488235622c2366cd389a717bb1fe~fRE003CM31729817298eucas1p22; Mon, 6 Jul 2020 20:38:11 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id A7.C9.05997.3BB830F5; Mon, 6 Jul 2020 21:38:11 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203810eucas1p2d010ecaa97bf03484e61c4629909e76a~fRE0EUe5D2126321263eucas1p2n; Mon, 6 Jul 2020 20:38:10 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706203810eusmtrp1d7801c8b2f6715ab18679027ed9961f8~fRE0DhI7s2965829658eusmtrp1p; Mon, 6 Jul 2020 20:38:10 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-b2-5f038bb3c3b0 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F3.DF.06314.2BB830F5; Mon, 6 Jul 2020 21:38:10 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203808eusmtip14d294ad591c5d24140ebb85f453e7dca~fREyPZRbz1791017910eusmtip1k; Mon, 6 Jul 2020 20:38:08 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:21 +0300 Message-Id: <20200706203743.29416-8-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxTGc+69vffSWHMtZpzhprGJy8Yy2aaJZ8bI1C27WZbFv9yic9iN O2CjSHqLk5kNxEmwfFqMzo9VhDkZGJlQCiOgQgIFKmhRU3GKQFQi20QQw4etSrk1++85v+ec 87zvm1dkjSV8tJicalOsqeYUE6/n3O3TPW/V5rHxb49dXUTVF51AQ/3lLA0cuMVT3sOfGbpe GUdN9cd05LidxVChY4yh+go7T/8OZHP0YLyeoZvNXoGO9GYLNN46LFDBpaNAw4ERlg6XPgK6 5KzT0XRLI0+jgTKOCmeuARW5OoA8+WMcHfirASjHLtHDP04JVH5zMY0PdHDk7asV6PRjH0t1 F4NA+z3VQN05z3TvL5VnSk/q5PKm+4xccsLHyu19BwU5v9PJyGcfNDDy6LlrvFzoqgS5ayiP lavuTPEb9Zv1axKUlOQdijV27TZ9UlP/HS6tR9g56bsKWXCGt0OEiNJKvNVxiLODXjRKFYBT FYWgFROA/qCb14pHgFWT7cKLkdNBh6AZpwD7WobYkGGUHgMWt8khzUuvozfXyYSaFkpneawP +JmQESmtw/ODeyCkOWkZ7t7TM8cN0nvY7qtltIQlWPXnhdmlohghrcZf26K1/YvRf3xibidK l0VsG90dPtEH6C/7JXyhSBzxuML8FfSW5HOa3oWTNX5BG84F7C/bG26KQ9c/PUIojJXewOrG WA2vQ3vB73MYpfl4/b8FIczOSof7EKthA+bmGLVuE17o7A1jxOCTeRqWcfjGvvBTNQNmd08x xbDkyP9ZpQCVEKWkq5ZERX03Vfl+uWq2qOmpicu/3m6pgdmv6n3qmWiAxsBXrSCJYJpnyOXZ eKPOvEPNsLQCiqxpoWF9t/dLoyHBnPGDYt0eb01PUdRWWCRypijDirL7W41SotmmfKcoaYr1 hcuIEdFZsCkusP+Ke/7gmt+2+DqKdxlivB9+1vX3iuMbbvduK76xN+rg4JsJ0y/VfRQf5ej8 ZvTTrszKlIKWVUnBL2b8OrZ7y927rp88qwVbwbdr72WeidyafLI5b+cnTiaNO/+aNJAxokv+ 0aZWWc69HPexv2bwXp3bWvRq0eexmUuf6JowJjvRZuLUJPM7MaxVNT8HkinzX6YDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa1BMcRjG/c85e85uWc5sGX8xyRozxkxbp4ve0kXGjPPNJWaoyKqjmtpd s2e3EV+6kGwJaYxbqzRuaSSVQrrsULFdpghJpKlJGNJFSmJX49sz83ue931nnldKKsYpF2m8 1iDotepEJe1AWWebet3vZpFRnkOvVkJpixlB/7siEvryemnIGjlCwOviEKipuiSB3PcpBOTk fieg6oaJhi99aRR8Ha0i4O0jKwMXOtMYGLUMMXCi/SKCoZlPJJwvGEPQbq6UwFTDAxq+zVyh IGe6C8HJimYETdnfKci7X40gw8TCyM3rDBS9dYXRvmYKrN3lDJRMdJBQ2fIbwemmUgStGX8k 61fw0wVXJXxRzTDBnynsIPnG7rMMn/3UTPBlX6sJ/lttF83nVBQj/ll/FsnfGvhJb3EIVwXq dUaD4BanEw1ByggOvFScP6i8fPxVnLff7gAvX6VHcGCMkBifJOg9gveq4mreDVAH2piDkx0v UAq6TZuQTIpZH1zyO5cxIQepgr2KcOmXfBuQ2gDGnwfIOY8Tnnlpouc8YwjX9VQQdkCzq7E1 00zYgTPbQ+Pnx1IpO3BiQ3Hdh3Rk1xS7Cqemt/0LyFl/3NhRTsxNXY5v3akn7ctkbADOf+Ji lwo2Hr8ZZ+wOBeuKX10eJ06hBQVoXjFyFoyiJlYjcipRrRGN2lhVtE5zF9kav9c4VV6NOsvC LIiVIuV8eSZNRikk6iQxWWNBWEoqneUbWq17FPIYdfIhQa+L0hsTBdGCfG3nnSZdFkXrbP+j NURxvpwf+HN+3n7ea0G5WJ7JNkQq2Fi1QUgQhAOC/n+OkMpcUlB0cKSxcNlHRcSuXZL6QU49 umDYo/xX7RbV9qU7YcPGC5uEILf27efqNvfIHj2eqKo2h/winJTuIwFtGQazo9PhMc2KlUGS O/3E5JS5uaz/2uy+Nyl7PXsKFybJju44HmgM1c5aunsjJwofpnvMW5ewNbJm7f6b4SWDZNcS zbYwxx9KSoxTc2tIvaj+C/+ePXQHAwAA X-CMS-MailID: 20200706203810eucas1p2d010ecaa97bf03484e61c4629909e76a X-Msg-Generator: CA X-RootMTR: 20200706203810eucas1p2d010ecaa97bf03484e61c4629909e76a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203810eucas1p2d010ecaa97bf03484e61c4629909e76a References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 07/25] net/ice: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Reviewed-by: Ferruh Yigit --- drivers/net/ice/ice_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index b51fa2f17..76f797de0 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3135,8 +3135,11 @@ ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) link.link_speed = ETH_SPEED_NUM_100G; break; case ICE_AQ_LINK_SPEED_UNKNOWN: - default: PMD_DRV_LOG(ERR, "Unknown link speed"); + link.link_speed = ETH_SPEED_NUM_UNKNOWN; + break; + default: + PMD_DRV_LOG(ERR, "None link speed"); link.link_speed = ETH_SPEED_NUM_NONE; break; } From patchwork Mon Jul 6 20:37:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73321 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B796A00C5; Mon, 6 Jul 2020 22:39:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58B8C1DD71; Mon, 6 Jul 2020 22:38:15 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 448561DD70 for ; Mon, 6 Jul 2020 22:38:14 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203814euoutp01d7f3e96fd3be68cb9a6b7a2a516c9975~fRE3Mtix73113131131euoutp01W; Mon, 6 Jul 2020 20:38:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203814euoutp01d7f3e96fd3be68cb9a6b7a2a516c9975~fRE3Mtix73113131131euoutp01W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067894; bh=fNqGGGujtZQoaCNUifIZpoVDm0FLT/KHJy8jVKrEsB4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=S4mk3ynTRAmW3nvFcHAGicDvez5pDUyBGRZaLoaFPUP1IEnQJgsRk4+5dbZuwfP7w eNImdooCSZSne9ua89ZHeFlS/G+v2xemd6JgVgUxix1tRLS9+HyMjnmOciL+vGepEQ 5ymzSyBss9pQ9TmaRcIo4Fyg66nkWkMktXOBIfZM= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706203813eucas1p1d70e92506c352a77373ec0fa27fad5bd~fRE3A_H_62654826548eucas1p11; Mon, 6 Jul 2020 20:38:13 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 1A.D4.06456.5BB830F5; Mon, 6 Jul 2020 21:38:13 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706203813eucas1p1fd1cf5ef5ae7ac290dcc2e4de11c6224~fRE2bmbmv2656026560eucas1p15; Mon, 6 Jul 2020 20:38:13 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203813eusmtrp27905e50db7bbc13e1fceef1ca6f215b8~fRE2axy120640206402eusmtrp2t; Mon, 6 Jul 2020 20:38:13 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-f9-5f038bb5ed9f Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 16.7E.06017.5BB830F5; Mon, 6 Jul 2020 21:38:13 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203811eusmtip16f809c480876bc91be86e59ca33e85f2~fRE0ru4ia1500415004eusmtip1y; Mon, 6 Jul 2020 20:38:11 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:22 +0300 Message-Id: <20200706203743.29416-9-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSbUwTWRT1zUxnhoaa2UL0BonGGtfVoMi6iddvNJpMopLV7A+XZMGqE1Sg uq3g12ZDELCCIgKKsmupbQxYdREBQYIGmkgrRbsSK6ioBLXEqghFgh+AUgbjv3PPOfee+24e T6sL2DB+h26PpNdpkzSskrnW9NE9tzqHjp/vuxyB5S0mgl1PrTR2Fj5hMac3g8J22wqsr/lX gfnP0ijMze+jsKYsm8U3nekM9vhrKOy44eKwuDWdQ7+9m8Nj7n8Idg/5aDxj7ifoNlUr8GNj HYvvhiwM5n7yEDxe5SToONrHYOH1WoJZ2QL2Xijl0NoxFf2dTgZdDys5vDRwj8bqlmGCJxzl BO9kfVFETxc/mc8rRGv9K0osOHePFpsenuLEo7dNlFjRU0uJ7256WDG3ykbE5q4cWrz44gP7 qzJWuXSblLQjVdJHLt+s3J7h6KJ2m5ftG2l8TNKIcX42CeJB+AWGbV4umyh5tVBG4EnpIC0X 7wmYL2Qo5KKfwGuvcVThx1rMzlSZLyWQ11U4bhog0F7aQwfmssJP4DKaqIAQKlSwUDPURgWE ECEa+vz1XAAzwkxwp5lJAKuERXCu1snKS02Di1caxtKChMVw9lZYgFYLU6Gt5P3YTBD+56Gp wKeQ/ashL7+VkXEI+BxVnIzD4cv1EkrGB2HwahsnNxsJPLVkjptWQNXru1wgjBZmQ3ldpEyv hNPP/Zz84onQ/vaHAE2PwvxrReOHUIExSy27NdBwu3WcBhj+HCzTIljdXkY+zw0Ch+6epfPI tOLvWWZCbGSylGJITpAMUTpp7zyDNtmQokuYt3VX8lUy+lVdIw5/LRlo3WInAk80wapOno5X K7Sphv3JdgI8rQlVrbrjilOrtmn3H5D0u+L1KUmSwU6m8IxmsmqB5dUfaiFBu0dKlKTdkv6b SvFBYWnkT0dw73/WImrvm+BQ8wnduk1Lepp/q0xdXTbh8mHP+vtXTm5a3P8jfvaGPBrxTNp8 sGHh8fXazLidMX+lt886FbdmSXjEYVve/djwSWt9MQWKnL9VzW1xriMmS6bXY9nYbVv4c2LH ognnPVsetPw+a+ecDbH1RSXOuoroaHvxy+WD0oxYDWPYro2aQ+sN2q8Ps5oRpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3cdzS7T8tc0q0UUQcu5dGeiZoFwg+hBfwi9bNhNLedk dxMN/zATG9OsmRpZrZlJpZE9fGMPtdxqij0oS3uIBWKG6bSXaeWU/vtwvud7zhfOYUjZOCVn klNNvDFVl6KgJZT7j/Pd2rp8Mj7kt00CNZ12BAPvK0joL35HQ/5oLgGvqzZAS8N5ERR9yCag sGiMgIarVhq+9OdQMOJpIODtXbcYyp7niMHTNiiGE93nEAxOfSbhrGMcQbe9TgS/Wptp+Dp1 iYLCyZcITta6EDgLxigobmpEkGdlYfTaFTFUvA0GT7+LAvebO2K4/u0ZCXWd0whszhoEXXl/ RTHLuUlHpYiraBkiuNPlz0iu402pmCt4bCe4WyONBPf13kuaK6ytQtyTgXySq/70k94u2aWM NBrMJn5ZkkEwRSl2qyBUqdKCMnS9VqlSa/ZGhIYp1kVHHuBTktN547ro/cqkXOcAkeaIyvjT 2oeykSXEihgGs+uxw5VuRRJGxlYifPp7u2iujvHwJ9KKfGbQD0+9stJzPeMIT7TbKK9As6ux 22InvII/20fjF8ePzgp+bAwe87SIvUyxK3F3tgN5WcpqcXmji56buhRX33xAepf5sBH4wiO5 F2VsMu6dmHXK2GDcc3GCOIV8HWheFfLnzYI+US+EKgWdXjCnJioTDPrbaObg9R2/ahuRdWRn G2IZpJgvtdBkvEykSxcy9W0IM6TCX7qpy71PJj2gyzzCGw3xRnMKL7ShsJl4NlK+MMEw8z6p pnhVmEoDWpVGrVGHgyJAamFb98jYRJ2JP8zzabzxv49gfOTZqDaAcl8eK4HFidPiXEnWD1GW X7M58PPG6u58HFv5ZLtcdvugzaOdLF1SX7Vq24dYV15kePmK3ibf1ml1rv3hvDjz1R7f4UUl N3rCDFzOsR4NGbFVvWJL2f1DRkvX6mtBGwODjg6kDS0IuGIbj0xhMo4v+ujcsdi8OU4ydObp ZPWwghKSdKo1pFHQ/QN+tFV9BgMAAA== X-CMS-MailID: 20200706203813eucas1p1fd1cf5ef5ae7ac290dcc2e4de11c6224 X-Msg-Generator: CA X-RootMTR: 20200706203813eucas1p1fd1cf5ef5ae7ac290dcc2e4de11c6224 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203813eucas1p1fd1cf5ef5ae7ac290dcc2e4de11c6224 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 08/25] examples: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov --- examples/ipv4_multicast/main.c | 12 ++++------- examples/l2fwd-jobstats/main.c | 12 ++++------- examples/l2fwd-keepalive/main.c | 12 ++++------- examples/l3fwd/main.c | 12 ++++------- examples/link_status_interrupt/main.c | 30 +++++++++++---------------- 5 files changed, 28 insertions(+), 50 deletions(-) diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c index 7e255c35a..0d4957658 100644 --- a/examples/ipv4_multicast/main.c +++ b/examples/ipv4_multicast/main.c @@ -572,6 +572,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -591,14 +592,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index 47a3b0976..740f1c80f 100644 --- a/examples/l2fwd-jobstats/main.c +++ b/examples/l2fwd-jobstats/main.c @@ -689,6 +689,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -708,14 +709,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c index b2742633b..d8be0a727 100644 --- a/examples/l2fwd-keepalive/main.c +++ b/examples/l2fwd-keepalive/main.c @@ -453,6 +453,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -472,14 +473,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 24ede4290..ef0f19a39 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -810,6 +810,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -833,14 +834,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/link_status_interrupt/main.c b/examples/link_status_interrupt/main.c index 9bbcadfcf..5e286060d 100644 --- a/examples/link_status_interrupt/main.c +++ b/examples/link_status_interrupt/main.c @@ -118,6 +118,7 @@ print_stats(void) const char clr[] = { 27, '[', '2', 'J', '\0' }; const char topLeft[] = { 27, '[', '1', ';', '1', 'H','\0' }; int link_get_err; + char link_speed_text[16]; /* Clear screen and move to top left */ printf("%s%s", clr, topLeft); @@ -131,9 +132,10 @@ print_stats(void) memset(&link, 0, sizeof(link)); link_get_err = rte_eth_link_get_nowait(portid, &link); + rte_eth_link_strf(link_speed_text, 16, "%M", &link); printf("\nStatistics for port %u ------------------------------" "\nLink status: %25s" - "\nLink speed: %26u" + "\nLink speed: %26s" "\nLink duplex: %25s" "\nPackets sent: %24"PRIu64 "\nPackets received: %20"PRIu64 @@ -141,8 +143,7 @@ print_stats(void) portid, link_get_err < 0 ? "Link get failed" : (link.link_status ? "Link up" : "Link down"), - link_get_err < 0 ? 0 : - (unsigned int)link.link_speed, + link_get_err < 0 ? "0" : link_speed_text, link_get_err < 0 ? "Link get failed" : (link.link_duplex == ETH_LINK_FULL_DUPLEX ? \ "full-duplex" : "half-duplex"), @@ -445,6 +446,7 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, { struct rte_eth_link link; int ret; + char link_status_text[60]; RTE_SET_USED(param); RTE_SET_USED(ret_param); @@ -457,13 +459,8 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, port_id, rte_strerror(-ret)); return ret; } - if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", - port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + rte_eth_link_strf(link_status_text, 60, NULL, &link); + printf("Port %d %s\n", port_id, link_status_text); return 0; } @@ -478,6 +475,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -497,14 +495,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73322 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85DEEA00C5; Mon, 6 Jul 2020 22:39:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EE261D94C; Mon, 6 Jul 2020 22:38:19 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1C7D61DD77 for ; Mon, 6 Jul 2020 22:38:18 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203817euoutp0256f7627b6cf0c830f089128cd5e3bb95~fRE6zRJxC1760817608euoutp02Y; Mon, 6 Jul 2020 20:38:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706203817euoutp0256f7627b6cf0c830f089128cd5e3bb95~fRE6zRJxC1760817608euoutp02Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067897; bh=Mcy1FKB5X97xPHfABEMsRH14jwW9/cdD4WTM5f5JTOo=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=s6J+OsI9tolRzgEulgf9vbluL0parrsc9VZDjHdzSC2dyN0b9HQrEkxYV6wmAnvXp hvfIFFXupGw8NAOu7ZIdaPzsmE10FQBNTOKeJh59McYts3c48diOEVy0wNnAc+BdDc 1BVXYzPIFcA4yB8yyAEF8BmdsGxCV7dDbR3HujD0= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706203817eucas1p1a86bd46cd1a3578bdc9640ca4cec381d~fRE6ds6L62452524525eucas1p1A; Mon, 6 Jul 2020 20:38:17 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id EC.D4.06456.9BB830F5; Mon, 6 Jul 2020 21:38:17 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706203816eucas1p1e8b84a0dfdd156d6f9a87c2dc96b8bf7~fRE5SN4jx2656026560eucas1p18; Mon, 6 Jul 2020 20:38:16 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203816eusmtrp2de8825c7b6d2e53d5ca041e37cc4a627~fRE5RdkTB0640206402eusmtrp2u; Mon, 6 Jul 2020 20:38:16 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-00-5f038bb9ae6f Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 16.DF.06314.8BB830F5; Mon, 6 Jul 2020 21:38:16 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203814eusmtip12d7609ca5153347cd73333656232dd00~fRE3fDSJE1560515605eusmtip1A; Mon, 6 Jul 2020 20:38:14 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:23 +0300 Message-Id: <20200706203743.29416-10-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa1CUZRSA53zffhd2WH1bbTxDgbVUozaJO/HjQBldx89+ZNM049SkuOUn aLuou+Il/zAaO7hcFHRSVC7ClAQ2KC7uAlKKyqUFHHaidUttRzNCBVaUNgkz1m+d/p3znOec 877vvDJv3C0myGtzNqn2HIvVJOp1pzrv97/UUshnLhp2J1FjbyXQtau1PIX2XRGpMPwlR5fq M+i057BAZb/lcVRSdocjT51LpNuhHToaHfdwdLndJ9FB/w6JxjuGJCq+eAhoaOomT+XVd4Eu VjYLdP9sq0hjUzU6KpkcBNrt7gbqKrqjo30tXiCni1H426MS1V5OovFQt458wZMSHZsY4Km5 9wFQaVcjUJ/zofD6s8pk9deCUnt6mFP2Hhnglc7gV5JS1FPJKSdGvZwy9v2gqJS460H58Voh rzT8/rf4vv5j/aurVevazao95bVV+uzg0OINrrit7YMf5IFXckGcjCwVe3rzeBfoZSOrAzzk 2yloyT3AkRvHxahlZHcBJ5vTHnf89cOgpElHASPlu2LJBODOYKcQtUQ2D30FlVy0MJudENEz FeCihVnsXXSe+2N6oSzr2PPYGs6NYgNLx3xvQNA2zMWG42ceKXHTvOJCgnaIJAxU3Xs0Elm3 jG2RA0LUQfY2lhY/o7XOwptd7tjVnsaHLVWcFm/HSFNA0noLAK/W5MekDHTf6peic3g2Hxtb UzT8Btb+dAO08TPw0sgTUcxPh2Wn9vMaNmCB06jZJjzT449hxAf/xGtYwbDz19hztgMeK20S 9sDcg//vqgaohzlqrsOWpTrMOeqWhQ6LzZGbk7Xws/W2Jpj+pr5/u8a9MOH/tAOYDKZ4Q0jm M42CZbNjm60DUOZNsw1v9vlWGg2rLdu+UO3rM+25VtXRAU/JOtMcw8s1wyuMLMuySf1cVTeo 9sdVTo5LyAPr3iUXXKu2Lk2cObbuT/jucJt57MriFwbS/Fs2brxesTSb/znpufjlI+XX6z5M T/etmfSMFtkaIu94e2ckz2x7JXFgIqPY+c25X85HWOIyMyT3GftZxWjNGr+nKtVvDpa/dbYP UtnydcWdH70XSEl+cXtw0ZPN+efDoSUJ1l1pnxj2mHSObIt5AW93WP4DgsZ6H6IDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzVSe0hTcRjtd+/d3ZQWl2l0GfRaRBI4u07zU9QkCG4aZIV/pNUaepmm22R3 sxQilTSZttJMs4eaopUGZWrOsof2mDVDNHRZllNESXvMR5phj83qv8M55zscOJ8IlzgJqShJ a+D0WlWKjPQkbL+s730t+bhyS8nCcrjVVY5g5EM1Do7i9yTkO09i8KZuG7S1XBZA0VAmBuai KQxarptI+OTIJuDLdAsGgw9sQrjYmy2E6Y5xIZzuvoRgfHECh7LKGQTd5c0CWGi/R8LXxSoC zD/6EJxp6kRgLZgioLjVgiDXRIHzxjUhVA+ugWlHJwG2gUYh3PzWg0Nz108EhdZbCF7l/hZE rGd/VNYI2Oq2jxh77moPzj4fKBGyBS/KMbbhiwVjvz7sI1lzUx1iX47k42z96Hcy2jNWHqrX GQ3cukQdbwiTxTHgL2eCQe4fECxnFEEHQ/wDZX7hoQlcSlIap/cLPyxPHBgPSzV5HHvQtzcT WYQm5CGiqQB67lHfEpZQNYi+YFWYkMjF0/TkKP7X4kUv9ptIE/J0WWYQXXCqHnMLJOVD2/LK MbfgTb0j6densgi34EVF0rlPxnB3EEFtpO85jW5aTIXQORa74G/oWrr+9uMli4eLv/JM6oYS Kol+O/uvzRraXjGLnUUrKtGyOuTNGXmNWsMzcl6l4Y1atTxep7mDXGvffb7QaEG9Dfs6ECVC suXiPBJXSgSqND5d04FoES7zFm9/ZTskESeo0jM4vU6pN6ZwfAcKdLUrxKUr43Wu39EalEwg EwTBTJAiSLEVZKvEeVT7AQmlVhm4ZI5L5fT/7zCRhzQTGc+/SUvwHT4RGtk/350Kc6er6jdM TI517joRX9RmNVtzMoZj6hqdKt8jwVo42rUHMYW3cb8sLsan5vsOyWqpZ+zx/qhnrSeH7s/U fhjNDovYvUnsMNt3zj39XFqxKs5CDHqpy0L3OyZr7bOl0gjjDOOYj/40F6VvV9q55PtTMoJP VDGbcT2v+gObLG72AwMAAA== X-CMS-MailID: 20200706203816eucas1p1e8b84a0dfdd156d6f9a87c2dc96b8bf7 X-Msg-Generator: CA X-RootMTR: 20200706203816eucas1p1e8b84a0dfdd156d6f9a87c2dc96b8bf7 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203816eucas1p1e8b84a0dfdd156d6f9a87c2dc96b8bf7 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 09/25] examples/bbdev_app: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/bbdev_app/main.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 68a46050c..44e6952e6 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -313,6 +313,7 @@ check_port_link_status(uint16_t port_id) uint8_t count; struct rte_eth_link link; int link_get_err = -EINVAL; + char link_status_text[60]; printf("\nChecking link status."); fflush(stdout); @@ -323,11 +324,8 @@ check_port_link_status(uint16_t port_id) link_get_err = rte_eth_link_get_nowait(port_id, &link); if (link_get_err >= 0 && link.link_status) { - const char *dp = (link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - "full-duplex" : "half-duplex"; - printf("\nPort %u Link Up - speed %u Mbps - %s\n", - port_id, link.link_speed, dp); + rte_eth_link_strf(link_status_text, 60, NULL, &link); + printf("\nPort %u %s", port_id, link_status_text); return 0; } printf("."); From patchwork Mon Jul 6 20:37:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73323 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CBD8A00C5; Mon, 6 Jul 2020 22:39:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF6611DCFC; Mon, 6 Jul 2020 22:38:21 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 664921DCF8 for ; Mon, 6 Jul 2020 22:38:20 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203820euoutp017ee9db627bbac820c17477bdc392800d~fRE86Kph10553305533euoutp01j; Mon, 6 Jul 2020 20:38:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203820euoutp017ee9db627bbac820c17477bdc392800d~fRE86Kph10553305533euoutp01j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067900; bh=sZj87uqkawQ60wf+sT4re4HeKIKPddDywVxgWZ8WdS4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=KS3eEcZVls1TgMp5KBMkxoLK+UXZuMmlo0EadYDsYEjyuys2PKH7hp76czBgKU6bq tYWHhivGaYBxgF6z3/cwT3Xe+acdwyOJaVAEnHOuJblqQD8zoHjogBBA7UeajIUz1V KoHv4ZIqpkgXW4HivtklA9PZi8/zQxZIu7t5Y6jk= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203819eucas1p2709a18cdbbb209a7a9e32ec34cf79b4a~fRE8pl--m2126421264eucas1p2v; Mon, 6 Jul 2020 20:38:19 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id C5.C6.06318.BBB830F5; Mon, 6 Jul 2020 21:38:19 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706203819eucas1p194ba5cda089597317d68ba5338d12f12~fRE71x0kb2452524525eucas1p1C; Mon, 6 Jul 2020 20:38:19 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203819eusmtrp2244bd80f81b489bf41826817a747b9f0~fRE70wFy50640206402eusmtrp2v; Mon, 6 Jul 2020 20:38:19 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-2a-5f038bbb074c Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 38.7E.06017.ABB830F5; Mon, 6 Jul 2020 21:38:18 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203817eusmtip1413debf2f9ac25750b266e286d244247~fRE5_0Y9H1791017910eusmtip1l; Mon, 6 Jul 2020 20:38:16 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:24 +0300 Message-Id: <20200706203743.29416-11-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTVxjG8957e++ls8u1sPgGELOaJfNjMMeWvFnMwH3EmyxL/GP6B9nE qnfoRotrBZUlCgaRAGMbI5LJqAxUGEqKWKEwZNCFz5YRmmnRgGvYMgUVFOhEPmSUW7P/nvf3 POc855wckdWX8JHiQfNhxWI2php4LdfY9XTgtV8K2OTXbYE4sntsQKN3qljyl4zwVPAoh6Gh 2gRqbfpRQ8V/ZjFUVPyYoaaafJ4e+E9yNDHVxNDwdbdAZ70nBZpy3RXo64EyoLsL4yz9UDEN NGC7pqGnHS08TS5UclQ0dwPoG0cPUHfhY45Kmp1AufkSPfq5WqCq4Ria8vdw5L51VaDLgUGW rnkWgb7rtgP15y5pEl+W5youaOSq1jFG/v6nQVbuunVGkAt7bYx8ZcLJyJNtN3i5yFELct9o AStf+nuW36FN0m7dr6QezFAsce/s0R74o74cDtWFHZ1vmxeyoEvIhzARpTexvO+ZJh+0ol6q AZxonOHVYQbw1397QR2mAW3t/fzzJT0+H6sa1YD/lN0LpQKASxc6V1K89Cq682xM0IiQrvDY tOBjgka49AF6n2RzQc1Jr+DgWPbKSXTS2+i9OByqWIeX6tuXK0QxbJmXd0YGsV6KQd+5mZU9 UfKIWHDmvkbNv4/1k7Og6nAc73aEbheNS83nGFV/hU8afIK6OA/wTuWpUCgBHfd/F4JlrLQB 7S1xKt6GnQ2lTBCj9CIOPVwdxOyyLG4sZVWsw7xcvZo2YHuvN4QRF+dXqVjGmbJ2Rn2e64DT /iHuW1h39v+uCoBaWKOkW00pijXerByJtRpN1nRzSuy+NFMDLP9V97PugBPaFva6QBLBsErn F9lkvcaYYT1mcgGKrCFC926/e7det994LFOxpCVb0lMVqwuiRM6wRhdfOfapXkoxHla+UJRD iuW5y4hhkVlg2ZlT1bp+kyZz1/qYvpGEzZ+8Z3qw1/lR3e0vJz7bPvpx3ezRjvG/kjMSO3J+ W3u+7aX+tKjoN4pXu+M3RdhNp29Xhx93FTpvll6O9b415wj0mPe0Jh3JZDoTd414PixpPlH7 eU3XQzb6hZb0LTtOp9ijtsfem/Nkd2xVIra5bw4l6RcZA2c9YNyykbVYjf8BSpUmWacDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzVSe0hTcRT2d+/d3SYtrnPSjxVpgyKipnPajmUZRXHpryD/6WG27DYt92h3 M+2PUCuTaSstgh6u1dBKC3tYmlik4KNmlPYw3SxbgVjmYxnmNGsq/fed833f+Q6cIyKlY5Rc lGGwcGaDNlNBh1Lu6dbeVfVFZGpM50kNVLc7EPg+ukjoO99LQ9HICQI+VCZBQ+0VAZR+yiXA XjpKQO1NGw2DffkUDPlrCfA+cQvhUme+EPxN/UI4/eoygv6pbyRcdP5E8MrxUAATjfU0DE9d p8AeeIfgTE0bgtbiUQrOP65DUGBjYOTWDSG4vIvB39dGgbv7gRBu/+og4WH7HwQlrdUIXhb8 FWxYwgac5QLW1TBAsOeudZBsS/cFIVv83EGw94bqCHb46TuatddUIvaFr4hkq77+preF7lQm mo1WCxeVbuQt6xS7VBCrVCWAMjYuQalSa1LWxMYrotcn7ucyM7I4c/T6vcr0t3fLkOmOOHvy 6aQwF7UIbUgswkwcbuvqIm0oVCRlyhGuPvEnWIiCBMbfv5JzmnA89d5Gz2l+Iuwpts+aaWY5 dhc6iBlCxnho/OZUHjVDhDObcef4HKaYpbhjIG/WIGHW4M4KLz03NRJX3X02GyYO9sua5TNQ ymTgnrFZtZRZjLuujhFn0XwnCqlEMs7K63V6PlbJa/W81aBTphn191Hw4o9aJmrqkG1oexNi REgxT1JIk6lSgTaLz9E3ISwiFTLJxpfuPVLJfm3OUc5sTDVbMzm+CcUH1ysh5RFpxuD/GCyp qniVBhJUGrVGvRoUCySFTONuKaPTWrhDHGfizP99hEgsz0UCf/ZKr0e9rdobGLkS9iO5e1FF lMlrfW7o9iT3LFUFXgw0+47kZeknkt479xwoVxrGpl3h08cmZfvGm40XwmTOg/a8TV++dB0n DhzeWvY67YkObxlOWFb4JsQ9ubdRPpgS82hL4g7dPl+kyfWZi3ZkJy9Uv43QT8T0+k+FtKyN VlB8ula1gjTz2n9uGL1YBwMAAA== X-CMS-MailID: 20200706203819eucas1p194ba5cda089597317d68ba5338d12f12 X-Msg-Generator: CA X-RootMTR: 20200706203819eucas1p194ba5cda089597317d68ba5338d12f12 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203819eucas1p194ba5cda089597317d68ba5338d12f12 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 10/25] examples/ioat: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ioat/ioatfwd.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index b66ee73bc..8bf80c262 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -700,6 +700,7 @@ check_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret, link_status = 0; + char link_status_text[60]; printf("\nChecking link status\n"); RTE_ETH_FOREACH_DEV(portid) { @@ -715,15 +716,11 @@ check_link_status(uint32_t port_mask) } /* Print link status */ - if (link.link_status) { - printf( - "Port %d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_strf(link_status_text, 60, NULL, &link); + printf("Port %d %s", portid, link_status_text); + + if (link.link_status) link_status = 1; - } else - printf("Port %d Link Down\n", portid); } return link_status; } From patchwork Mon Jul 6 20:37:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73324 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9B5AA00C5; Mon, 6 Jul 2020 22:39:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 45C421DD77; Mon, 6 Jul 2020 22:38:25 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id A82461DD77 for ; Mon, 6 Jul 2020 22:38:23 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203823euoutp010dd0b93e0a57ade76e4002759e5ed4a1~fRE-_XUcm3113131131euoutp01Z; Mon, 6 Jul 2020 20:38:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203823euoutp010dd0b93e0a57ade76e4002759e5ed4a1~fRE-_XUcm3113131131euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067903; bh=KYoq+D7jL7TMj8sFJ9dEXZ47ChxgDfY/ELcSA7WUHJo=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=oizXWOmovqUsopvEKn9SsXNmwtxcz6NjY2mQlW+JM4rNXM1pJ6skbL9McABJoMqt4 MckJQAEAy/X7D7PRkARqrnVh2OcjI0AO4CkfVMLwLfl0AEh6ET0oTSlRR1DhU4UToZ f3rSgmQjW99rrlO6f0xvA7gsRuZpKmtWKK7eelmE= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203822eucas1p246db0ae1a49560d66c584a6084f1084e~fRE-ZvDlr2067820678eucas1p26; Mon, 6 Jul 2020 20:38:22 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 0F.D4.06456.EBB830F5; Mon, 6 Jul 2020 21:38:22 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706203821eucas1p185226841e82d0270cb03a488cf69e04f~fRE_Ki_5S2655126551eucas1p1E; Mon, 6 Jul 2020 20:38:21 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203821eusmtrp218ea1f6e31584f76e9bd6cdeca1f6a0e~fRE_Jwqmg0640206402eusmtrp2x; Mon, 6 Jul 2020 20:38:21 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-05-5f038bbe6ab3 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 5A.7E.06017.DBB830F5; Mon, 6 Jul 2020 21:38:21 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203819eusmtip1973b33d9066ba91081a50552c58baa52~fRE8bM1zY1560515605eusmtip1B; Mon, 6 Jul 2020 20:38:19 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:25 +0300 Message-Id: <20200706203743.29416-12-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUwTdxjH87u73h2VLmch+gQUtxoT3RyMSeIzY/AlbrlkWabZYqLRdUUv aKTAeuBrYhgqwxaZFqORQUGI4cVNfAEpCKTrpijlpXTBQlCpRHEqCqJMxGpHuRr/+z6f7/d5 vskvP57WFrBR/PbUDMmUakjRsWrm8rVXnZ+2WGj9Z0NVsVjTbiM4eKecRt/x2yxaRg9S2Fu9 Apvqi1RoHciiMN/6jML6SjOLw75sBp+O1VN4q9nFYaEnm8Mx5wMOj3T9RvCB/xGNp0qfE+yy 1anw1Z+NLI74yxjMn+wh+GvtdYKtec8YPN5gJ5hjFnC0qoLD8lsxOOa7zqCr7xKHv49301jX /obgsdYagh05AdXKj8TJ0jMqsbzpISUWnO6mxWt9Jzgx74aNEi88tVPiSEsPK+bXVhOxbdBC i2fvTbBr1RvVy7dKKdt3Sqa4xB/V2/q7TtLpr6N3/zcyTrLIgVlmEsaDkAC/WJycmah5rVBJ oGjSEhpeEKi461Apw3MC/waOMe9WRv0FjGJUTBm+A9OGVhgnMHj0m6BmhYXgyrVRwVCkcIGF er+XChoRwpcQcFinNSMsgKySSjaoNcIyGPi7l1Ia5sHZ8w7aTHg+bIoXX41S7seAt+TF9E0Q 3DzY2qtD+TXQdPiUStER8Ki1llP0HAg0lIQy++DlRS+nLOcSuFN2KBRaAbWPO7lgGS0sgprG OAWvgsI/DqmCGIQPoPfJzCCmp6T18klawRrIzdEqaR04bnhCGODN63AFi9Dm9VLKUzUTaOyq Y46SeYXvu0oJqSazpUzZmCzJ8anSrljZYJQzU5Njt6QZL5Kpr+p62zpmJ+OeJCcReKIL1/h4 Wq9VGXbKe4xOAjyti9Ss7nD9oNVsNezZK5nS9KbMFEl2kmie0c3WLCl7uFkrJBsypB2SlC6Z 3rkUHxaVRc4viI1/m9RAzd0iXxnKrtsfPnNdXtOZTf17X374xPP5RIH9p7QwT9+MCn1EXPJ+ xt23O7EZ1g5/948rZlXEJsci/ycZfFV0SdFfVzKKrYvnLP16/oD+2xP2bi7lvrsqYeLcF4nD 8TdX2tfrirMTLnUHri4W3fjVhu8fL12z3OUeSvrZqGPkbYb4j2mTbPgfTerXxqYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0xScRTH+917uaCF3aHVnZUpq60nhmYcC6vVWvevVmu9LWJx5yORxgWn 9Q9ZGQPTNJfrRRazTDIrNay0KWVWaK6XQZq55nJlUzN0aYhBrv/OOZ/v95yznSPARR4iXJCS rmO16co0MRlMOH3Nn5bVm3HFco9rLlS2WBB86bLi0F30iQTz4AkMXOVroc5+iQeFnw0Y5BX+ xMBeZiLhR3c2Af1Ddgw66518uPAmmw9Djl4+nG67iKDX+x2H8yW/ELRZangw2viQhAHvNQLy xt4jyK9+jqA59ycBRQ9qEeSYKBi8eYMP1s4IGOp+ToDTXcWHW8OvcahpGUdQ0FyJoDVngrcu ihkrKeUx1rpvGHP26muceeY+x2dyX1gw5m5/LcYMPH5PMnnV5Yh5+cWMM7ae3+SW4D0SuVaj 17GRyRpOlyDeK4UYiTQeJDEr4iXSWNm+VTFx4ug1chWblpLBaqPXHJAkd7QV44f/zM4cGRhG BnR8pgkFCWhqBT3oPUuYULBARJUi+muxwZ8I/ICm+3rwSU0o7W03kZOaX4j21Y2TAUBSC2mn 0YIFQBjVQdJvTx0jAiCU2khPNBRigZigFtCGK2X/DEJqFf35qQub7DqPtt1pwAPDgvz1y03h gVBEpdAfPfyAQkRF0B+ueLAzKKQETSlHYayeUyepuRgJp1Rz+vQkyUGN+h7yX/z+s9HqWmTq 3+ZAlACJpwmNJK4Q8ZQZXJbagWgBLg4Trm917hcJVcqsI6xWo9Dq01jOgeL86xXg4TMOavz/ k65TSOOkMoiXymJlsStBPEtopBoTRVSSUsceYtnDrPa/DxMEhRuQYiJnb+/ESFfGzrJMK3Ho ZGpL8Vj7HY+jKnJ1xGZVwrv55tCt8zL7ds0I2Z5w9InPmtW0I3WJec501fWiOW9jq7Y0umQ1 Bquny4bvyZ86y5bUIY+eev9Rgw9/NVJhtHuSxyj55t0bXG41b9G0xCZ3p7e3QlOaG7Wpnb9t pmSp6baY4JKV0sW4llP+BVVYLhkHAwAA X-CMS-MailID: 20200706203821eucas1p185226841e82d0270cb03a488cf69e04f X-Msg-Generator: CA X-RootMTR: 20200706203821eucas1p185226841e82d0270cb03a488cf69e04f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203821eucas1p185226841e82d0270cb03a488cf69e04f References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 11/25] examples/ip_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications: * ip_fragmentation * ip_reassembly * l3fwd-acl Signed-off-by: Ivan Dyukov --- examples/ip_fragmentation/main.c | 13 +++++-------- examples/ip_reassembly/main.c | 12 ++++-------- examples/l3fwd-acl/main.c | 12 ++++-------- 3 files changed, 13 insertions(+), 24 deletions(-) diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c index 4afb97109..18a6df77e 100644 --- a/examples/ip_fragmentation/main.c +++ b/examples/ip_fragmentation/main.c @@ -593,6 +593,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -612,14 +613,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up .Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index 494d7ee77..910c89ae3 100644 --- a/examples/ip_reassembly/main.c +++ b/examples/ip_reassembly/main.c @@ -712,6 +712,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -731,14 +732,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index f22fca732..ddfec9487 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -1815,6 +1815,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1834,14 +1835,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73325 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1940FA00C5; Mon, 6 Jul 2020 22:39:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2AFAE1DD83; Mon, 6 Jul 2020 22:38:27 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 7B8441DD7E for ; Mon, 6 Jul 2020 22:38:25 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203825euoutp02198ae6b6dd4ff540c4e1911cd7ea2e32~fRFBqzTQk2670026700euoutp02W; Mon, 6 Jul 2020 20:38:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706203825euoutp02198ae6b6dd4ff540c4e1911cd7ea2e32~fRFBqzTQk2670026700euoutp02W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067905; bh=q3R1NjSfULTkmVfHv5xauRfm4wQ4m9PAU/4z8Fmz1iI=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=eJTYCmXEZPipDrEcpKoJwY5ORMFK3a983OiZHaITDWDox9cRU8o/tLgAppDzrzi0p Y7RyUz9aSG8z05NlgsGg1Da6PxyMRVsmW5BznP/KEA6ndN5IqQTp1weNh1C+R2/gZf LC4cAFLMIV4+/mpzaYRIvHdNETZBQEZ3eEwoqcA8= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706203825eucas1p182d0ad8656a63eb0252dc028fd7c2bd2~fRFBZuY1V0771507715eucas1p1q; Mon, 6 Jul 2020 20:38:25 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id E7.C6.06318.0CB830F5; Mon, 6 Jul 2020 21:38:24 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706203824eucas1p1de6a23263f1d5289d0844cd01b699054~fRFAjOJ9O2655126551eucas1p1F; Mon, 6 Jul 2020 20:38:24 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203824eusmtrp2c1eb8352512080233ae8894b43ce4f23~fRFAidzzT0640206402eusmtrp2y; Mon, 6 Jul 2020 20:38:24 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-2f-5f038bc0cee9 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 68.DF.06314.FBB830F5; Mon, 6 Jul 2020 21:38:24 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203822eusmtip18ecc7128300d329c090070621ceb9a93~fRE_y1RKT1500415004eusmtip1z; Mon, 6 Jul 2020 20:38:22 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:26 +0300 Message-Id: <20200706203743.29416-13-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0xTZxjG/c6dzpqzYsYrOsyaeNniZEZN3hnwnu2YuMx//Mcb6+RY2Wg1 PeJliwtR6UhBwGKcoKuMasTqRGqhhaAyslGkKMKGQIKCxsi4KFAkXih2lIPZf9/3e57nfd58 +QRaZ+dihRTzPtliNqTqOQ1TUfe66dOaLDrps6s+xNJGB8HHD500dp98wGHW0DEK212rsNp7 lkV7VzqFOfZhCr0lNg4Huo8w+DzopbDzRoDHwpYjPAZre3g83nSGYE+oj8aCohGCTY5yFl// UcXhYKiYwZw3rQRzPfUE/dnDDJ6s9BG02kQcunSRR2dnHAa76xkMdFzn8cpoM43ljeMET/hL Cd6xhtnVH0lvii6wkrO6l5Lyf2umpbqOU7yUfdtBSWXPfZQ0eLOVk3I8LiI1PM6ipctPXnGb NFs0Cclyasp+2RK/8hvN7rJHheze/BkHn/UlppPAezYSJYC4DHoycikb0Qg6sYRAf8coFxF0 4gsC9xo/V4URAiPjF9h3iZ9LnIwqXJxItIV49TJKIGj38BEXJy6EQKZjcu5MsYwDb6iNigjR 4kY4Xz0+aWLEefC7KzzJteIK6Kg8SqkVc+HytRraRgQhaoL/+lesulIctJ17MTkTxHsC5F3J pVX/eshobZ/KRkOfX10CxDkQrjw3xX+El+42Xg1nEnhYnDFlWgWe/rt8pIwWP4bSqngVr4G3 oTougkGcAe3P3o9geuJor/iFVrEWMq061a2HmtstUxhgfGy6iiUoCB9l1ee5QWDAOUzlkbmF /3cVEeIiMXKaYjLKylKzfGCxYjApaWbj4p17TG4y8VMDb/2jPnIz9G0tEQWin67tFugkHWvY rxwy1RIQaP1M7do7gR06bbLh0A+yZU+SJS1VVmrJbIHRx2iXFvdu14lGwz75e1neK1veqZQQ FZtO1npj869uHtr0z5+9CQ23og9/yA78FJzl/e7M3/2yNUFv9djcpl2DX1Y11LtL3U9ndY1l LC9v7qp4uvVl3jRHtnQ/ueBA3teOnRuiF82fduyDYaOv2Xw6rmxbS2KKsuH4vC8sna5E4/I5 62NOL1gUn+4fWxdeeeqr/t6z8V5rn3P7vyV6PaPsNiz5hLYohv8AZ73NJ6UDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3fVJpfN6CJlNYpCanqntmOYlRTdP4SMCKIyW3lRybna nZZCMXuozUf5KEhtaevhZi9L08LnILWmmEoPe/hKEnuYzoSsWW1J/305n+/3nAPnULh0ivCl EpL0vC5JnSgnPQn777b3a5qz8ZjAHyMI7naYEAz3m3EYLHpPQvbEaQxeWzdAfW2pCAoGDBjk FUxiUFthJOHL4EkCxh21GLxrsIuhuOekGBy2UTHkdpUgGHV+wuFS2RSCLlONCGZaHpPwzXmV gLyfLxCcq25H0JYzSUDRozoEGUYaJiw3xWB+5weOwXYC7H0PxHBruhuHmo5ZBPltdxF0ZvwR bVzG/Sy7LuLM9WMYV1jejXOtfRfFXM5TE8ZVjddh3LfGFySXV21F3LPhbJyrHPlBRnnuVoTp tMl6fmm8VtCvl+9hQalgQ0GhDA5VsEGq6HXKEHlAeFgsn5iQwusCwvcr4quGikWHC72Pff20 3oDsXkbkQTF0MJNZYSaMyJOS0tcR03fnhsiIKBdgmM8j+JxHxjhfGsk5zxRiut+akBuQ9CrG nmXC3MCHfksyvZnphBvI6EjmWv2s2K0JegVz2/oHc2sJvY7pe3QKm+u6hKm814y7h3m46pef +LqllE5g3nz/l5TSfsyrK9+x88i7DM2zIh8+WdDEaQRWIag1QnJSnOKgVnMfuQ7+sHXmQR3q qdphQzSF5PMlWSQeIxWpU4RUjQ0xFC73kUR02vdJJbHq1DRep43RJSfygg2FuNbLx30XHNS6 3idJH8OGsCoIZVVBqqC1IF8oyaJb9krpOLWeP8Tzh3nd/xxGefgaUNmwuMey9E7AL43X7+fO /ECZ7vGCUMMRsA/ETcuO+px5gnuU6185NjVtz4lcsuUCYRGojjplY//yhNLKwt5VqzuDpCWq NGFbehhR9eFa9MqhSZXRvDjQErU1kY0+8VBU0XK8ddGuE5aC+TtzNzeVUh+DGxrHnBH1sgPt SjPpf1ZOCPFq1h/XCeq/c3kv9wYDAAA= X-CMS-MailID: 20200706203824eucas1p1de6a23263f1d5289d0844cd01b699054 X-Msg-Generator: CA X-RootMTR: 20200706203824eucas1p1de6a23263f1d5289d0844cd01b699054 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203824eucas1p1de6a23263f1d5289d0844cd01b699054 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 12/25] examples/ip_pipeline: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ip_pipeline/cli.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index d79699e2e..ca461ea0c 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -249,7 +249,8 @@ print_link_info(struct link *link, char *out, size_t out_size) struct rte_eth_link eth_link; uint16_t mtu; int ret; - + char link_speed_text[16]; + char link_status_text[10]; memset(&stats, 0, sizeof(stats)); rte_eth_stats_get(link->port_id, &stats); @@ -268,18 +269,19 @@ print_link_info(struct link *link, char *out, size_t out_size) } rte_eth_dev_get_mtu(link->port_id, &mtu); - + rte_eth_link_strf(link_speed_text, 16, "%M", ð_link); + rte_eth_link_strf(link_status_text, 10, "%S", ð_link); snprintf(out, out_size, "\n" "%s: flags=<%s> mtu %u\n" "\tether %02X:%02X:%02X:%02X:%02X:%02X rxqueues %u txqueues %u\n" - "\tport# %u speed %u Mbps\n" + "\tport# %u speed %s Mbps\n" "\tRX packets %" PRIu64" bytes %" PRIu64"\n" "\tRX errors %" PRIu64" missed %" PRIu64" no-mbuf %" PRIu64"\n" "\tTX packets %" PRIu64" bytes %" PRIu64"\n" "\tTX errors %" PRIu64"\n", link->name, - eth_link.link_status == 0 ? "DOWN" : "UP", + link_status_text, mtu, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], @@ -287,7 +289,7 @@ print_link_info(struct link *link, char *out, size_t out_size) link->n_rxq, link->n_txq, link->port_id, - eth_link.link_speed, + link_speed_text, stats.ipackets, stats.ibytes, stats.ierrors, From patchwork Mon Jul 6 20:37:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73326 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6178EA00C5; Mon, 6 Jul 2020 22:40:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EED8F1DD89; Mon, 6 Jul 2020 22:38:29 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5836E1DD86 for ; Mon, 6 Jul 2020 22:38:28 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203827euoutp015554a0abf74309841cfac5da6e414b2d~fRFEDA14X1241012410euoutp01C; Mon, 6 Jul 2020 20:38:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203827euoutp015554a0abf74309841cfac5da6e414b2d~fRFEDA14X1241012410euoutp01C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067907; bh=1YhjGGZIH+BiDd1vuZIqrQ6NKJL1whpE3mlU+Xfl3zM=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=hwFrQvcFOPBZwju7PWcLklugD4idicR2C8p6HwKqMKeFSieyOIuXJb1u0wPNs8DYZ PgR7D4GkTHuC6KWeZFmh/YturEPiJ07VtniDl1LGQygfpiPY7e3t3sYnW9PO/l0g6i X5JIbQh20T2sumv7yg5XzU7DQhYCVOzCxtmCKLRU= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706203827eucas1p14d486af9513de505e16e33414adb2788~fRFDx_lGW2654826548eucas1p17; Mon, 6 Jul 2020 20:38:27 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 21.E4.06456.3CB830F5; Mon, 6 Jul 2020 21:38:27 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203826eucas1p2cdffffa65bd89e363797b2cfb376abff~fRFC_vDCW2099120991eucas1p2u; Mon, 6 Jul 2020 20:38:26 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203826eusmtrp2efeac18c68f5a89781c3daccfadba8ba~fRFC9jbsG0640206402eusmtrp20; Mon, 6 Jul 2020 20:38:26 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-0b-5f038bc3e1fe Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 8A.DF.06314.2CB830F5; Mon, 6 Jul 2020 21:38:26 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203824eusmtip1f3c9563ef48700ea441deace95bfda7a~fRFBLZ6vc1560515605eusmtip1C; Mon, 6 Jul 2020 20:38:24 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:27 +0300 Message-Id: <20200706203743.29416-14-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0wTaRTFc2famaGhZhzd8C0SjE2MrmZVotncrLgoUTM+Y/zDmN0oW2UC RChsK/jKBjSCpCBqIaJFAduoSDeiWCmKEBeiRccXbAi6AcRHRNQWrAKiFKRMjf/d8zvnfie5 +ThasDDhXJJhp2Q06JN1jEZVc3v4wc9NeXTcAmtzBFbdKwV83mWnsbuok8G8/oMUPq6MwRuu U2q0PM2isMDynkJXhZnBd90HVOj1uSjsqJdZtLYeYNHX2MPi4YclgD0jb2g8Wf4B8GHpVTUO /3udwb4RmwoLPrcBHnE2A7rz36uw6FotYI6Zx/4L51m0d0Sir7tZhfKTKyz+M9BC49V7fsBj 7irA+zlj6qUzxM/lZ9Wi/UYvJRaeaaHF20+Os2L+nVJKvOytpcS+hjZGLHBWgnj3eR4tOl5+ YjZoftdEx0vJSRmScf5vf2oS/c9kSHNodlu92VQWlHNm4DjCLyJe299m0HACXwHE1ttJK+Ij kFdddlDEByCjjjrGDCETGzW5Y5RinAciewaDYgDIUMMJNpBi+NlEzi2dMKbylxniGmmnAsYU fi0pshyCQLmKn0n2N0UGsJb/lVT0n1MrDdOJ49JNOhAJGeenb4UHsMBHkvayjxNPEv4RRy4e 6gQlv5z8X32BUuYp5I3bySpzBBm7Vhbk+8hQdTurLOcC6bJlB0MxxPn2ARsoo/mfSNX1+Qpe Rp71O2nlRpPIY8/kAKbHR0tNcRBrSW6OoKR15Oad1iAmxP8lVMEiyTP71Mp16oEM1hVTR2G6 9XtXOUAlhEnpppQEyRRlkHbNM+lTTOmGhHnbU1OqYfynyqNuXy0MtG5rBJ4DXai2m6PjBLU+ w7QnpREIR+umamPvy1sFbbx+z17JmBpnTE+WTI0wjVPpwrQLbb1bBD5Bv1PaIUlpkvGbS3Eh 4VlgXTn6aJna1bdxnbunpD50/fB/OSssL+Z4NhQm4qjVmxm7KiF+W0Z96ur4rYvgojZs5l9c Ylede0ha7OiraZIboitKTmV6BtI0gv2V3OLJFIpj5nb8En0w+UV+ROGlo0s+lfh/cCRt2bx3 1prXft+mzqjCH1dkHylu3f9HjNYQe4bVqUyJ+qg5tNGk/wqyKX9RpQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdna0Fqdp9Heg2aCIqNm85LuuYiAHCbLsQ5SXRp7U2sXO maJ9MjG1WaYmgVY6k/IWrczaLFu1LrqmhIbdzNSK7GqmCRl22ZS+vTzP73l44X0ZUj5BKZh0 g4kXDFqdkval3H86BlY5i8nk1TV5y8DaVY3gzes6EoYqBmgoHssn4HnTJmi3nZFA+WAuASXl 3wmwNZhp+DKUR8HouI2AV7fcUqjqzZPCuHNECscfn0YwMv2JhErLBILH1dckMHX3Bg3fps9R UPKrD8GJ1k4EHce+U1DRZkdQYGZhrLFeCnWvgmB8qJMC94urUrg42UPCta7fCMo6rAi6C/5K opZwvyznJVxd+0eCO1nbQ3IPX5yScsdc1QR3ZdROcN8cfTRX0tqEuEdvikmu+d1POs53l2q9 YMw08cFpRtG0QblbDaEqtQZUoeEalTosMnFtaIQyZOP6FF6XnsULIRv3qNJ+D7tRRrNvdtXo ESIXWRgz8mEwG46vF/0lzMiXkbPnEb7UcpwyI8ZjYPz5HTnL+OHpp2Z6lplA+FyBnfIaNLsc u4uqZ8L+bD+NnxQenjH82C24orwQeYsodik+fC/IK8vYtbhh7IJktnQxbr58h/QiPh797AOF d5Sz6fjlD6mXkLNB+FnND6IUzbegOU3In88U9al6Ua0StXox05Cq2mvUtyDPwa8/nLpqR71X 4p2IZZBynqyIJpPlEm2WmKN3IsyQSn9ZdLc7SS5L0eYc4gVjspCp40UnivBsV0YqFu41et7H YEpWR6gjQaOODIsMWwPKRbIi9m6CnE3VmvgDPJ/BC/9zBOOjyEU7XD352X3YEd74yPA14HbG /QGXKqBqkng/cUBfGd/f5dDEBG8OKXUM74xqWxl0tn+fZdsiy2Wx3vbg7c3BwP21QuJkbKy2 VIg9atUFJm0tW9B2sNu4a1307rJDLr/aD59GEjq3hyQqCtcVfLTmbyiPITlNa+/QlsDYFN2U fa4rTkmJaVr1ClIQtf8AJSKVwQYDAAA= X-CMS-MailID: 20200706203826eucas1p2cdffffa65bd89e363797b2cfb376abff X-Msg-Generator: CA X-RootMTR: 20200706203826eucas1p2cdffffa65bd89e363797b2cfb376abff X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203826eucas1p2cdffffa65bd89e363797b2cfb376abff References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 13/25] examples/ipsec-secgw: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ipsec-secgw/ipsec-secgw.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index f777ce2af..551838229 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -1775,6 +1775,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1794,14 +1795,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73327 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0518A00C5; Mon, 6 Jul 2020 22:40:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B3D9B1DD92; Mon, 6 Jul 2020 22:38:32 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id DDC371DD88 for ; Mon, 6 Jul 2020 22:38:30 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203830euoutp011d6afa2433af703dea249ea53beafe9d~fRFGszTAK0553305533euoutp01k; Mon, 6 Jul 2020 20:38:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203830euoutp011d6afa2433af703dea249ea53beafe9d~fRFGszTAK0553305533euoutp01k DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067910; bh=Gr1Jcl7miAeWLUh9GahLeLAq7ORJTSLyxj+MvXGXDw4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=HuPFTpQcsQHVbxML9rsUG4aKO26Wa2seHgA+SlpZNn5Lg0YGwp3dUYVBl9M4CpU39 Qt9fLxJBwo9d3QdDcQGj2MIhpqxN1oM6rk0fMzb41Xy7otQPbbvNIgSt7LZ9D28oWb uXsmzgfWt6cKfUKDmcOcGHOtlUXrwf4ctVW7qqvQ= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203830eucas1p2f2f6f6c4d4b70a4c7f1ffad28fdd3b6e~fRFGbnfWN1728517285eucas1p2_; Mon, 6 Jul 2020 20:38:30 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 3B.C9.05997.6CB830F5; Mon, 6 Jul 2020 21:38:30 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203829eucas1p287744dd5ed850265d94669971a98abab~fRFFlXFHK2126821268eucas1p2B; Mon, 6 Jul 2020 20:38:29 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203829eusmtrp27113bd53a9a9304be0ce419a46a48bd8~fRFFklvYl0640206402eusmtrp22; Mon, 6 Jul 2020 20:38:29 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-c9-5f038bc65307 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id AC.DF.06314.5CB830F5; Mon, 6 Jul 2020 21:38:29 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203827eusmtip19ba5b429d752dbf2fc49aff8b5a0b22c~fRFDxXd6-1791017910eusmtip1n; Mon, 6 Jul 2020 20:38:27 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:28 +0300 Message-Id: <20200706203743.29416-15-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTdxTGc+7/9t5LY9m1ungCRmIzE12iTt2Hk8XINjW5X7aRGZdlcbJO 71BXkLTixPmBMCQNMOqq8XUURnUqrwN5KYgL1o2XFUQRBmWgjdnWAK4VRFRe5qgXs2/P8zvP OU/yz19iRqcQI+1NOaBaU8wWk6Dn61qeda1uyWWJb/SXv0qVHS6g+3fdjAInhgTKfZjFUX9J PDXVf68j570MjvKdYxzVX8oR6EEgk6fQeD1Hg9d8Ip3tzhRp3BsU6duuc0DBmRFGZ4oeAXW5 anX07HqjQOGZYp7yp3qBHDVtQK15YzydaPAAZefI9PDyRZHcg8toPNDGk89/RaSyx7cZ1XbM An3XWgnUmf1c9/ZyZarogk5xNw1zyvEfbjOlxX9SVPLaXZxSFfJwSvjnXkHJrykB5bf7uUwp /fOpkKD/RL9xt2rZe1C1rt30mX5PT95NIfUX+VCDc1rMAIchB6IklN/EpqCb5YBeMsqXAEPT FaCZCcD245nz5hGgo/uO8HKlYPQBrw0uAt4Lj4maeQx4rqyOi6QEeSX67C4uMlgsVwlYP9M3 ZyRpkbwFXRfiIhleXoFPB0ZeXDXIb2FZgRe0hjgs/amZReJRc7zg15gINsrLsK9w4sVJlHsk 9LcPiFp+C2bdadBpehGOtNbM86X4vKGQ0/TX+KS6T9SW7YB3i4/Oh+KxZvSmGClj8iqsbFyr 4XcwPDHERzDK0dj/z8IIZnPSWXeKadiA9myjljZhc3v3PEacnV6gSQV/nIrWHucaYHByCo5B 3Nn/q4oASmCJmmZLTlJt61PUr9bYzMm2tJSkNbv2J1fD3E/1/ds64YHGmc+9IEtgWmCwCyzR qDMftKUnewElZlpseLfTt9No2G1OP6xa9yda0yyqzQuxEm9aYthQPPypUU4yH1C/VNVU1fpy yklRMRmwb3PzqVL15OWlk68sPHNk9bGKrQPvbbheZZGStpVudIyU39KF/FeWuz09Cb0Daur6 Q6dvbN0+XJ3dl7jCX2FpS/3mSffVw6uOJjhiZ+2ntwV/H9p164+w7O0ov1qr98TuPJI12fn+ x4ObtjNHeuiL1z6Kry2cvHH+A2VHdODDzX+xv0cDJt62x7zudWa1mf8DPdOjR6UDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d++0Ftdpelk0axCI4ezq1GOYhURc+qMHUX9Uupbepumc 7W6h9UdmZjKXlT0o05ulUq1IK02LHjYzy2mhZaVlikjigx7OSE2rLem/w/l8vocD50hxuYtQ SFPSzbwpXZemIr0J5+/mnpCmAly7fKjDH6paRQT9n8px6DvdQ0LBt1wM3ttXwYO6EgkU9WZj UFj0HYO6q1YSRvtyCPgyVofBx4dOCoo7cigYcwxScOzVBQSD08M4nC9zIXgl1kpg8sl9Er5O XyagcKoTwfGa5wiabd8JOH2vHkGelYZv165QUP5RCWN9zwlwdt2h4MaPdhxqW2cQnGyuQtCW 90eyegk3VVYp4cofDGHcqUvtOPes6yzF2V6IGHfrSz3GfX3USXKFNXbEtfQX4Nz1gQlyo/c2 dYzJaDHzi5ONgnmlajsLYWo2GtRhmmg1Gx4VvyIsQhUaG5PEp6Xs402hsTvVyW9sL8mMp3Tm vaJfVDY6LrMiLylDa5jSkVHCirylcroSMR9cYxIrkroBw4wM4LOOLzP91krOOi7EVMy0kx5A 0kGMM1/EPMCP/kAyr48eIjxhX3oNI1YGehyCXspMdA//82X0CuZGqQPNDg1krlc34B7dy90v bVJ4SjmdwnSPUx5DTiuZdxfHsRNofhmaY0d+vEUw6A0CqxZ0BsGSrlcnGg23kfvgd59N3qlH Hbc2OxAtRap5snwS18olun1ClsGBGCmu8pPFtTkT5LIkXdZ+3mTUmixpvOBAEe71TuKKBYlG 9/ukm7VsBBsF0WxUeFR4JKgCZPn0kx1yWq8z86k8n8Gb/ucwqZciGwWLm+LWKVPjxYWXJ+1b NEkBLbJMn8+Ti7Rb0fo9uzaUVCc+zpp7kyoeFU/4snPn7A0W/WO40IYznT8jGzSByt5Lvm1x xXonpW+rOzK8m7fFHAzS0WsV9tjWxvVT87yCzvrNhCgXvKwI2djX6DNiOZhw8UxAbtjWQJft wLn+ZZrDKkJI1rHBuEnQ/QXD6TuJBgMAAA== X-CMS-MailID: 20200706203829eucas1p287744dd5ed850265d94669971a98abab X-Msg-Generator: CA X-RootMTR: 20200706203829eucas1p287744dd5ed850265d94669971a98abab X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203829eucas1p287744dd5ed850265d94669971a98abab References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 14/25] examples/kni: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/kni/main.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index f5d12a5b8..8ad7fb532 100644 --- a/examples/kni/main.c +++ b/examples/kni/main.c @@ -661,6 +661,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status\n"); fflush(stdout); @@ -680,14 +681,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %uMbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ @@ -717,19 +713,15 @@ check_all_ports_link_status(uint32_t port_mask) static void log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link) { + char link_status_text[60]; if (kni == NULL || link == NULL) return; - if (prev == ETH_LINK_DOWN && link->link_status == ETH_LINK_UP) { - RTE_LOG(INFO, APP, "%s NIC Link is Up %d Mbps %s %s.\n", + rte_eth_link_strf(link_status_text, 60, NULL, link); + if (prev != link->link_status) + RTE_LOG(INFO, APP, "%s NIC %s", rte_kni_get_name(kni), - link->link_speed, - link->link_autoneg ? "(AutoNeg)" : "(Fixed)", - link->link_duplex ? "Full Duplex" : "Half Duplex"); - } else if (prev == ETH_LINK_UP && link->link_status == ETH_LINK_DOWN) { - RTE_LOG(INFO, APP, "%s NIC Link is Down.\n", - rte_kni_get_name(kni)); - } + link_status_text); } /* From patchwork Mon Jul 6 20:37:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73328 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B7B7A00C5; Mon, 6 Jul 2020 22:40:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3604E1DDA3; Mon, 6 Jul 2020 22:38:36 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 23BAE1DD8E for ; Mon, 6 Jul 2020 22:38:34 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203833euoutp011de154ea70a353e41c6abff11c548425~fRFJs93t31241012410euoutp01D; Mon, 6 Jul 2020 20:38:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203833euoutp011de154ea70a353e41c6abff11c548425~fRFJs93t31241012410euoutp01D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067913; bh=0KRTz2AP5FV+jHZTStTVbtq12s0MKBOah3XGntzISPk=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=mymvvG2sv/LCk2eD5zPjceuJ00bJsd7DPWTrR0kI+Nr9zK/FUTpaKBS1UBGuQnCRq ZxBuYopCZBZoP/NAy5hSlhnC+AFSeH5RwNAULXIsDA62bVfoHvfDHyTouUqgY3YVbr jML401B5Xx5oQ0mDhrHvv2i/2qF9Xomjfwu/rMMU= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203832eucas1p2aced045d018bb42f72dc380b6dd5b6ff~fRFIk0QbG2126421264eucas1p2z; Mon, 6 Jul 2020 20:38:32 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 5A.C6.06318.8CB830F5; Mon, 6 Jul 2020 21:38:32 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203832eucas1p2e73d9cadd71c3c3bf564b80e75ea8e75~fRFIMaajR2099120991eucas1p2v; Mon, 6 Jul 2020 20:38:32 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203832eusmtrp2cc41335fc52d95c47650cdf6fa79434a~fRFILowH00640206402eusmtrp24; Mon, 6 Jul 2020 20:38:32 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-39-5f038bc8c78a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id CE.DF.06314.8CB830F5; Mon, 6 Jul 2020 21:38:32 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203830eusmtip106e83353854920df7bc4406458bc12db~fRFGUhe_E1560515605eusmtip1D; Mon, 6 Jul 2020 20:38:30 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:29 +0300 Message-Id: <20200706203743.29416-16-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxNYRzH95xz7jmny7XjZvNbXprrZWSKhf0YkrGdP2zMP16GXDoSdePe Qpi1pqSbUM1L6krRpdgtbp1QIdOLi6hRTLksQ1KJRrm3dJ3Mf599X57vs2cPT2vTWB8+3BAt GQ36CB2rZkqr++pn1ZrpkNlu52S0PbYQfN+aR6Mzo4VFc/cRCpsLgrBczlJh2ts4ClPTvlEo X0lmscMZz2Bnj0zhmwoHh5kN8Rz2VH3k8Hj9eYIfXe00nsv5TrDeUqLCvvu3Wexy5TKY2v+C 4Al7LcGalG8MZtwqI5iYLGD3VSuHeW8mYo+zlkHHq5scXut9TmPJYzfBUzU2gk8SB1VLJ4n9 OZdVYl75Z0pMv/icFqtfnebElDoLJRZ3llFiV+ULVky1FxDx0XszLRa2/WJXqzeoF4VKEeF7 JWPAki3qHc7cO9zu4+r9D5tlKo7E88nEiwdhLhR2mFXJRM1rhSsErp+1Mx5DK/wgcD9hrWJ8 JyAXVZB/DeuvS6xiWAlkxecP13sJ2PpklSfFCtPBkWShPMYYoZgF2dVEeQxvYSWUfsriPMwI U+Gl2/K3oBEWQuaRblqZ8IXContDzPNeQ3r2Qx/lShOh6cKPv2eC8IwHs/sro+SXw6PKhGH2 hvYaO6fweBi8dYFS+CD8vNHEKeUkAq25CcOhILB/ecp5xmhhBthuByhyMBQ1mlmPDMIoaP46 2iPTQ5hWeoZWZA0kJWqVtA7u1TUMywDu3yMVFOFdb4jyOhUE0vtbqZPEN/P/VA4hBWSsFGOK DJNMgQZpn79JH2mKMYT5b4uKvEGGfqpjoKa3jFS6tlYRgSe6kRonT4doVfq9ptjIKgI8rRuj WfbEsVmrCdXHHpCMUSHGmAjJVEXG8YxurCYw9/MmrRCmj5Z2SdJuyfjPpXgvnzhyuj3man+5 4W7gtPP1Ryc1xrbNhNaOPH/dRu+u1NcNg0HVA2FLN64perBz1aH1Kxb4t/u4W9bZLmtc6d0D 2cFTolJeS6GL9zQa3SPaAt5at+dvr1tyoiD6UIbVdriluaR4VeilBL/OluCL84/JM/w+EDmf m+DbddDbcOxn9DxWV3s2XMeYdujn+NFGk/4PQzdbAKUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSaUwTYRCG+Xa324VYsykQPtGArBrQxGo5ZFDAI9EswUQS/eOJVTdApC12 C0H8g4hAyqFUNAG0FCpBQeOBCAJeqFCtRsGAgogN4fAKYsWLgNqi/nszz/vOTDLDkPIJypdJ 0ugFnUaVzNEelO1Xx+ul1nwyfnldySy49NiEYHDAQoK95DUN+ePZBLysXQ2tjaclYHyTSUCR 8TMBjecMNHy0Z1Ew5mgkoP+mTQplXVlScLSNSqHwaTmC0an3JJSavyB4amqQwM+7zTR8mqqi oGiyG8Gxa1YEHQWfKSi50YQgx8DC+PkaKVj6/cBht1Jg662XwoWvnSQ0PJ5GUNxxCcGTnN+S NQH8pLlawlta3xH8icpOkm/vPSXlCx6aCP7KWBPBf7rVTfNF12oR/2gwn+Trhn7QcR7bFJE6 bapemJ+oFfVR3HYlBCuUEaAIDo1QKEPCd64MDuOWRUfuE5KT0gTdsujdikR7VYs0pdAj/cHL RiITZTEG5M5gNhTX/DhLG5AHI2erETaOWEgDYpwA4w9D5F+PJ57qMfzzfEF48lkn7QI0G4Rt eSbCBbzYVzR+nnuYcgFPdiO+/va01KUpdhHumTZJXFrGrsRl2eP/uvrjust3Zoa5O+tnHvi6 pJxNwn0TM0k564dfVEwQx9FsM3KrRV5CqqhOUItKhahSi6maBMVerfoqcl78evvP+ibUdWVz G2IZxM2S5dFkvFyiShMPqtsQZkjOS7buiW2XXLZPdTBD0GnjdanJgtiGwpzrFZO+3nu1zv/R 6OOVYcpwiFCGh4SHrADOR5bH3t0hZxNUemG/IKQIuv85gnH3zUQx62v6clMMF3Ztue29uCh4 j89cbKwKY85uavhufBFjL12y4rc1ZSBWsqplQdDhym8+lrXRCeaRqGYqmXMDx9Z7R3TVbwXu QMYAcTTd4XkobUvZ9KGLgeU7A+5PVKdntcdWWHGgWbEhY6Gmc2A4YPdDN/+TknvWnOG4eXNi aP2mQY4SE1XKJaROVP0BJi0DSgcDAAA= X-CMS-MailID: 20200706203832eucas1p2e73d9cadd71c3c3bf564b80e75ea8e75 X-Msg-Generator: CA X-RootMTR: 20200706203832eucas1p2e73d9cadd71c3c3bf564b80e75ea8e75 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203832eucas1p2e73d9cadd71c3c3bf564b80e75ea8e75 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 15/25] examples/l2fwd-crypt: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-crypto/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 827da9b3e..7648ea027 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -1734,6 +1734,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1753,14 +1754,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73329 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48401A00C5; Mon, 6 Jul 2020 22:40:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5CDA1DD9F; Mon, 6 Jul 2020 22:38:38 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1FB5F1DD15 for ; Mon, 6 Jul 2020 22:38:37 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203836euoutp02b66f094a00d8309f50c18e1b2db1346e~fRFMfcQvJ1760817608euoutp02Z; Mon, 6 Jul 2020 20:38:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706203836euoutp02b66f094a00d8309f50c18e1b2db1346e~fRFMfcQvJ1760817608euoutp02Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067916; bh=srhawFEXUKW2qnG3XOlQI1DTOaaunL+pDywNZ8YTyIM=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Ef0GElAmFi4dkdOdXBlRmj494+NHGd5KYQCLAVh+UzKkAwZd+ISgpzBaViN4ArHOV DHQyM9HGusDCgQai7nZO3OrjAtiuZBe1KBEcVYx/j2Hkj32WDJfKVECkcXkPCrkwLw zcDk0JM3jD5zXUPYcnjGNhuTSJZR4jtmtV9xnTyU= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203836eucas1p28f1b735175efef95455248ed33380608~fRFL7jL3P1729817298eucas1p26; Mon, 6 Jul 2020 20:38:36 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 1D.C6.06318.CCB830F5; Mon, 6 Jul 2020 21:38:36 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706203835eucas1p1ec5020cd607b45703a3b41144182d52c~fRFK7QLoH2656126561eucas1p1A; Mon, 6 Jul 2020 20:38:35 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203835eusmtrp2719686d1a793e2b32b3e9d23f86031c8~fRFK6cqKA0640206402eusmtrp25; Mon, 6 Jul 2020 20:38:35 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-3f-5f038bcc3061 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id DD.7E.06017.BCB830F5; Mon, 6 Jul 2020 21:38:35 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203833eusmtip1ed22dd5d7f14593c05e27e328aacb6bf~fRFJJrCQV1791017910eusmtip1p; Mon, 6 Jul 2020 20:38:33 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:30 +0300 Message-Id: <20200706203743.29416-17-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSWUwTURT1zUxnhsbqWIxc0UBs3Ddc440aUaNmoib64ZeJ1lHGaoSKrbh+ SBAJAWSpRBS1RVDBSkSwUAQklUQWW0U0BDGIDe64IGhd60IZjH9nu+e8j8fTWgsbyu807pVN Rilax6qZivrvzTM8qbR+1ruy4VjisRLs6iyg0Zv9hMXUj4kUPrJHYo3zrAotT+MpTLf0Uugs SmHxnTeBwQ99Tgo7bro5zH2QwGFf3SsOjzefIfjK303j6bxPBJut5Sr8fquKxR5/PoPpP1oJ ZjgaCTak9TKYfaOSYFKKgB8vF3JY0BGGfd5GBt3t1zks9rXQWO75RTCroYTg3aQ/qqXjxB95 F1ViQc0bSjxxvoUW69tPcmJak5USSz9UUmJPbSsrpjvsRLzTlUqLV55/Y9erN6oXR8nRO/fJ poglW9Q7/IUuOtaqPpBRa6XiSRafQoJ4EOZBx5dukkLUvFYoIuCzZLAK+UzAnduoUsgnApfa U+l/JzVH/bRiFBJwVlQPEh+B4qZ2JpBihcngTrZSAWOkUMqC099GBYxgYS2cynGpApgRJsDp L9cGsEZYCJl3ehhlIhyuXHP1t/J8UL9+7nZoQNYKYdBm+zzQCYKHh2NptoEMCCvg1mVJOQ2G 7gYHp+Cx8OeGjVLwYfha1sYpt8kEOvOPDYYiwfH2HhfooYUpUFIVocjLIOHhBUqpHwaP3o8I yHQ/tFTkDK5qIDlJq6R14Gp6MCgD/Po5VJFFeJlpUymPv0ng4e2JmSQ89/9UHiF2EiLHmWMM snmuUd4/0yzFmOOMhpnbdseUkf6f6v7d4Ksktf6tdUTgiW6oxsvTeq1K2mc+GFNHgKd1IzXL 77o3azVR0sFDsmm33hQXLZvryBie0YVo5ua/2aQVDNJeeZcsx8qmfy7FB4XGE2n6kKM6+7Sr G+UDscF6mDhltbu2dN2ix0vGhBRKzMIi4jhElb+oag1fkB+p3rAms2zOul7n9tfXZxsicmqq ticn1e/JNhzZHD7q/HzXczFxFuN9ufyEF2zykPvVLb7irmejI3N741Z1Hm8zsi/sibasRSuj So3jv3m2zq8Om9So1zHmHdLsqbTJLP0FbBCLLqUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3cdTS5T82aUNYheNJvTPPaUiLhUf2gRlJZz2UVF5+Te zbJArKTkWupUVlmulS1LA7U0tcx05SNnqNUqe0oI0YNpZlExqy3pvw/f8z3ne+AcCldMECFU WqaR4zN1GUpSRjh/97xe7izEtSvyxymo67ciePemCoeR8tckFI7nY/C8Zj20NZ+TQOnbPAyK Sr9g0HxFJOHzyBEC3BPNGLy645RCxaMjUphwvJfCyYGzCN57PuJwxvYVwYC1SQI/O2+RMOa5 SEDRLxeC4sZeBD0nvhBQ3tqC4JhIw/jVailUvZoHEyO9BDiHb0jh2rchHJr6pxCYe+oQPDz2 RxKzgP1ls0vYqrYPGFt2YQhnu4ctUvbEAyvGNrhbMHas3UWyRY01iO17V4iztaM/yFhZvGoN bzAZufmpBsG4VpmghnCVOhpU4RHRKrUmas+q8Ehl2Lo1+7iMtGyOD1uXpEr1VHfgWVbZgeJ2 K5aHzJSI/CiGjmDajnpwHytoO2LODq8WEeXVGebTKD5tCWA8T0Vy2vIVMc7hzT4m6cWMs8CK iUhGBdIvSebx8cOErxBAb2VOn+qQ+JigFzJnvtf/Yzm9iinpGyOmh4YytfUduC/Lz6tXdoX4 UEGnMS8mpdNR85hn5yexEuRvQzNqUCBnEvQpeiFcJej0gikzRZVs0F9H3nvf7P7Z2IJE93YH oimknCkvIHGtQqLLFnL0DsRQuDJQvuGhM1Eh36fLOcjxBi1vyuAEB4r0rmfGQ4KSDd7vyTRq 1ZHqKIhWR2miNCtBGSwvoDt3K+gUnZFL57gsjv/fh1F+IXkoSzu6Jxfn08d23d6UsqgyryLf HnovMW7Lzi6/6zuUTw4GJKJlJdorYldbbtMUXeReqHHMNrnucpdfBptze/0r40R2/66YQ7rl G0db65fN6ZzyXKrtZ7NnJdstMwcH03/stTUE2eLnVt6djLG4Y5MsNRURcUE9toRtrqd9ZR+X 3FcSQqpOvRTnBd1fNUwivAUDAAA= X-CMS-MailID: 20200706203835eucas1p1ec5020cd607b45703a3b41144182d52c X-Msg-Generator: CA X-RootMTR: 20200706203835eucas1p1ec5020cd607b45703a3b41144182d52c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203835eucas1p1ec5020cd607b45703a3b41144182d52c References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 16/25] examples/l2fwd-event: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-event/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c index 4fe500333..3e6d1c311 100644 --- a/examples/l2fwd-event/main.c +++ b/examples/l2fwd-event/main.c @@ -366,6 +366,7 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status..."); fflush(stdout); @@ -389,14 +390,9 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - port_id, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", port_id); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", port_id, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73330 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B809A00C5; Mon, 6 Jul 2020 22:40:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 231041DDAB; Mon, 6 Jul 2020 22:38:41 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id E6E101DD76 for ; Mon, 6 Jul 2020 22:38:39 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203839euoutp023ee92059c6930e376cf27389c76f8b5d~fRFPIsp0R2313123131euoutp02r; Mon, 6 Jul 2020 20:38:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706203839euoutp023ee92059c6930e376cf27389c76f8b5d~fRFPIsp0R2313123131euoutp02r DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067919; bh=mj3hE/gu7NzVbUKqiHTNl/YjUhTA6ayvrigfQL+Dyrc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Qi6ctS98RMWrv7EdEw1Izijvm7bf6R6nBzYJmpAW6uzyb58sryPWeOW6Hc9zQX3LU wsorlm8mVVjmLitMXkKLA4YAI1UmY9rU/8UVY9vua8x83D4dIr837H5ugqusSl7T6l WRow/LnmWcljXQCt/69xMxABGpUr2BHisgeoDUXc= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706203838eucas1p168514718b1738aa6305faea92db718b4~fRFOQZXkk2654826548eucas1p1A; Mon, 6 Jul 2020 20:38:38 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 5D.C9.05997.ECB830F5; Mon, 6 Jul 2020 21:38:38 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203838eucas1p25a3b38dc4c1a04f7c15f76f190dff8a2~fRFNmlRWj2126821268eucas1p2D; Mon, 6 Jul 2020 20:38:38 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706203838eusmtrp16c59d13b5ed7031f0441247d0509a7d6~fRFNlhGht2965829658eusmtrp1q; Mon, 6 Jul 2020 20:38:38 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-d2-5f038bce087a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id E0.EF.06314.DCB830F5; Mon, 6 Jul 2020 21:38:38 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203836eusmtip17d8d643f52e6e9bfb0b4c269b649f559~fRFLyIxJC1560515605eusmtip1E; Mon, 6 Jul 2020 20:38:36 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:31 +0300 Message-Id: <20200706203743.29416-18-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSaUxTaRSG892dxpprbeIZxrg0MVHjNuqYM6gjGmPuxIzLHxONUKveIBGq aQF1xh8EEQlF0MJIdBARolUwwWJpEcuInQyLBbQoFjdERRBFWYSMYl1aLsZ/73nOec/7neQT aI2VCxdijQmyyWiI03Eqxln7oXlus4XWLzh2ZS6WNRYQfNZeTGNH7mMOLf2pFLaVrEC3K59F 65NkCrOsAxS6LmRw2NuRwuDbQReFj6q9PJ5qSeFx0NPN49FbfxPsDryi8WThO4K3CipY/HCj isO+QBGDWSOtBLMd9QTrMgcYzL1aSTAtQ8T+izYeix9NwcGOega996/weGnYR2NF4yeCx+vK CDalfWEjp0sjhedYqdjdQ0k5Z320VHv/BC9lNhRQkv1tJSX1/dPKSVmOEiLdfGahpdLO99wG 1RbVsp1yXGySbJr/6zbVrjvPHdzerrD9tjI/k0we8hkkTABxMZzvrAlqlaARLxA45zvKKMUQ gfbjGZRSvCPQZaugvlmcAT+rNGwEHL0eWimGCaTmvxhdzIkzwZteMGrXinYOXAH/qH2iuAac qdlsSDPiDDg08pCEtFqMAG9DD6dETIXSyzXBrYIQFuSn/wsPYY04BfxnhkZ3gtgoQPH1p6wy vxpyruePeSfCqzrH2HWTwZuTySj6T/i/3M8r5vTgcUWHx4ZWgON1Mx8Ko8VZUFY1X8Er4cUX KxPCII6HtjcTQpgOSqszj1awGtLTNMq0DmoaWsYwwKeP4xQpgc8yWXl8NQHL3YhjZOqp70mF hJSQSXKiOT5GNi80yvvmmQ3x5kRjzLwde+LLSfCnej/XDVWSqsB2DxEFohunTudovYY1JJkP xHsICLROq17V5I3WqHcaDvwhm/boTYlxstlDfhQY3ST1oqKeKI0YY0iQd8vyXtn0rUsJYeHJ RH/tLhW9NWvg4Gff4rWlP/c1nahdZ/jl3robz9enaWtva3/47WpJ2781fMvLBO3FcFh6M/bS pogj2blv9Ma/Xg9XO6PrI/dvzJzZdbq81R2j1kmP25cn5LmjIu1R7s2Dvz9I7mfnCLaIvMRD 1gk93dPs2xfsntGd4kpas2Sfve1p58gRHWPeZfhpNm0yG74CpdApjKUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzVSa0hTYRjuO+fsnDNxcViWX/6wGgUVOTva3KvZneT0L+hHVNZcdtCRc7Ez oxuhpSXTVs0ItJrainRGWi61stsiL62SMrMydZRkmeStIKddtqR/D+9zeR94X5ZUjlERrCHT Ipoz9RkqOoTy/m7ujnpeQOqW+tZD9VMHgg89ThJ8Z7ppKBjOJeCNaxU01p+Xgb03mwCbfYSA +gorDYO+IxR8G60n4P1dLwMlL48wMOrpZ+BE2zkE/ZMDJBSXjSFoc9yUwfjD2zQMTV6kwObv QHDS3YKguXCEgjO3GhAcs3IwXHmFAef7SBj1tVDgfVvLwNUfL0i4+fQXgtPN1QieHfsjWz1P 8JddlgnOxi+EUFT+ghSa3p5lhMJWByFc/9ZACEP3OmjB5nYh4cmHAlKo6vtJbwzZqk40m7Is 4tx0k2RZodrGQ4yajwd1zLJ4NR+r3Z4Qo1FFr0zcJWYY9orm6JUp6vT2j256zyf5vivVnVQ2 6mKsSM5ibhmum+yUWVEIq+QuI+warEVWxAYIjL/2kVOaGXjytZWe0owh3NvV/c9McwuxN99B BIkwrovG7cdzqCAxg0vCdbknZUFMcQvwUX8XCmIFl4C9rV/oqdQ5uKrmARlcJg/MLzyOCEIl Z8Dvvv+LV3KRuLP0O3EKTS9D01woTMySjGlGiVdLeqOUlZmmTjUZb6DAweuaxmsb0MvrmzyI Y5EqVJFPkzqlTL9X2m/0IMySqjDF2mfeHUrFLv3+A6LZpDNnZYiSB2kC9U6TETNTTYH3ybTo eA2vhXheG6uNjQNVuCKfe5is5NL0FnG3KO4Rzf99BCuPyEaF2tdR7aX4ftn85Qdi3i1f2GOP Wxee3NkxGL2ZGZlJYjgf+jHpvq/koObHvPnyBldO0aaEa0vjUhYN7Cxas262WcfPWnBoYHY5 KFZrqp1NSfhOOKcrznVX5uzwt21YP3H2VZ/06KfHcKmGn7AXVcCWnlWHXfZXyZ9teUt6PzN5 KkpK1/OLSbOk/wsicQc1BgMAAA== X-CMS-MailID: 20200706203838eucas1p25a3b38dc4c1a04f7c15f76f190dff8a2 X-Msg-Generator: CA X-RootMTR: 20200706203838eucas1p25a3b38dc4c1a04f7c15f76f190dff8a2 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203838eucas1p25a3b38dc4c1a04f7c15f76f190dff8a2 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 17/25] examples/l2fwd: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index e04c601b5..9d5f7307e 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -571,6 +571,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -594,14 +595,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73331 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92CABA00C5; Mon, 6 Jul 2020 22:40:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E83631DDB2; Mon, 6 Jul 2020 22:38:44 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 8B7C81DD99 for ; Mon, 6 Jul 2020 22:38:42 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203842euoutp0104e723e623d6857ec52a07774ca19f63~fRFRjoDfJ0553305533euoutp01l; Mon, 6 Jul 2020 20:38:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203842euoutp0104e723e623d6857ec52a07774ca19f63~fRFRjoDfJ0553305533euoutp01l DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067922; bh=FZgu+DseHLusxJkCwaRQ1GfffzIWoM6QnM8E1SGa7oc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=A5NH4q1oLDV39y1EUiFWQtHe/QS0ul6CsxR8gccwLYRwAxbdgMNMHmx4v4K4W+z2O IccqS5fnhwWtOBr8a0hIPQyDdSKFdv2MiW/Bi3E6bpHAkus6OQ9wKuvBH3BNl8UmkD pcJFhKA3bE+9pBq6RceAJRJO3cNzhLwgmxXXQk2g= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203841eucas1p2140acdc93e341c1f3daeb7063f1a7633~fRFQ3c6N12126421264eucas1p21; Mon, 6 Jul 2020 20:38:41 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 7F.C9.05997.1DB830F5; Mon, 6 Jul 2020 21:38:41 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203840eucas1p2366ef5cffa8f367969343fe9240cd919~fRFQPZZoe1728517285eucas1p2B; Mon, 6 Jul 2020 20:38:40 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203840eusmtrp2725d0473b1c94314d1faedcd87aeb046~fRFQOcHS60640206402eusmtrp26; Mon, 6 Jul 2020 20:38:40 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-d5-5f038bd18b81 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id FF.7E.06017.0DB830F5; Mon, 6 Jul 2020 21:38:40 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203839eusmtip16beb4e6e101d3c739a846710a6772f3e~fRFOcpqDb1791017910eusmtip1q; Mon, 6 Jul 2020 20:38:38 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:32 +0300 Message-Id: <20200706203743.29416-19-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0xTdxTH97tvqtW74uMMN4lNzNjiGzVnxgd7JF6jMcZETZYp6/AGjVBJ r+B8kBAitTxEhwSVasU2vlojqECByIb1AdiCgkE0QSWNzskULY+pXRUpt8b/vudzvt9zcn75 CbTuIBcjbDZuk01GQ4qe0zDVN962Tm/LpxNntZfGYrnPRtD/0EFjd/EDDvNf7aHwnnMJXnYf ZbHoURaFhUUBCt1n8jh83p3NYG+fm8Kuei+Ppe3ZPPZ5nvK475aV4NNQD41HyvoJ3rJVsfj2 Sh2HL0N2BguDHQT3VzYRbCwIMFhcW0PQnCfiq7OneXR0Tca+7iYGvfcv8XhusI3GKt87gn80 lhNsMQ+xCVOkYNlJVnJcfkZJB0+00dKN+yW8VNBso6QLvTWU9PLPDk4qrHQS6aY/n5Zcj99w qzQ/axZulFM2Z8immYt/1Ww6dP4BSbNrfs+tLqGySA+fR6IEEOdCqMJP5xGNoBPPEGj4x8qq xQCBuxV2Si36CXSZg+zHyLV+J6c2ThPw3hmiwg2dOEjAaR0V1pwYB16LbSQ9TrzAgTvUOWKK FleAt9U7MokRp4Jjb4AOa624AOrz2yMbYsFV0TDMBSFqmB+7HqPOnwydxwdGZoLoE8D6l5uo /p9gT85gJBsNPY2VkeO+hKHa45Sqd8Hri528GrYQeGjPiZiWQOW/rXx4GS1+A+V1M1X8Pfif WNgwBnEM3HvxeRjTw7Ko+hCtYi1YzDrVrYeG5vYIBnj3/2gVSxCoHWTUp6onkNvyhj1AYks/ 7SojxEkmyulKarKszDHK22cohlQl3Zg8I2lr6kUy/FW97xsHakhd6DcPEQWiH621cHSijjVk KDtSPQQEWj9O+0OLd4NOu9GwY6ds2ppoSk+RFQ+ZJDD6idp4+7P1OjHZsE3eIstpsuljlxKi YrLIjwnTYuYt230sWJaRsPx5Zpw+Sfos1NS6/evHV+d957qUfM3ZPMVoLdb0zXqybmx2biiu af2EnLTD48foHevWHv17y6KgW1jq6gjYzn111+Pbe7iq4pcBW1LJo/iVNa64uh63Lzg0//qc QHT8AX/t+cwNk24v7f3v1L41BaszJ3xhXtyh6Bllk2H2t7RJMXwAyqkOI6YDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSbUhTcRTG/d97d3dnLi7T6I+C1agowWtzmsdlFtGHGwUV0Rd70Ztd1HLO djdT6YOKqM2XdIbRm6kjKovM8q3I0JlarTKNSivLQpQsfFfSLNu0vh3O73mec+AchlRNUt5M XIJJNCYI8WranXL8ae/1f5VLRm7osAZD1fNSBF8/2UjoO9tLQ+5oJgHdlVvgYf0lGVg/pxFQ YB0joP66hYYffRkUDI/XE/Cx0SGHC10Zchi3D8ohv+MigsG5IRLOl00g6CitlcFM8wMaRuYq KCiYfYPgTM0TBO15YxScvd+AIMvCwuiNa3KwffSF8b4nFDh67snh1lQnCbXPfyMoaq9C8CJr XrZ1FT9bdlXG2x5+I/ji8k6Sb+spkfN5T0sJvnq4geBHHr2h+YKaSsQ/+5pL8jf7f9J73CO4 MKPBbBJXxhok02b1AQ0EcppQ4AKDQjmNNuSQLjBYHRAedlSMj0sSjQHhUVzsudu9KLHCPfl0 XQmRhobkFqRgMBuEH09U0hbkzqjYqwhnWmedgHECjL/3k4saTzz31vJPM4GwpcS2YKbZddiR U0q4gBf7gcavs9MpF/Bkd2HHS4fMVVPsGmzLHltIUrI63JjbJVtMXYFv3mkiXcMUzv7lVm9X qWLj8PvJhXgV64vfXZkkCtHSMuRWibxEs6SP0UuBnCToJXNCDBdt0N9FzovXtc3UNCDL8D47 Yhmk9lDm0GSkSiYkSSl6O8IMqfZSbnvhOKxSHhVSUkWjIdJojhclOwp2rldEei+LNjj/J8EU qQnWhECoJkQbot0I6uXKHLb5oIqNEUzicVFMFI3/fQSj8E5DLT475t1Gk+aTFdNCa4TfdYde u12XIxxxG9Jza2zXTiW/9sNi6l4lc+OY/60685ewoJkmWYNUvp/0WTLX4lu8aXhgGiJKdNS6 Y6s9fANeRRcyvwKO76zyVBzoobnmtfmrT3THN18+YY3Skmj3ycb10+lZn+2T8/t01VMThwbK 1ZQUK2j8SKMk/AVpiZE1BwMAAA== X-CMS-MailID: 20200706203840eucas1p2366ef5cffa8f367969343fe9240cd919 X-Msg-Generator: CA X-RootMTR: 20200706203840eucas1p2366ef5cffa8f367969343fe9240cd919 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203840eucas1p2366ef5cffa8f367969343fe9240cd919 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 18/25] examples/l3fwd-graph: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-graph/main.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index c70270c4d..cd8e3aad1 100644 --- a/examples/l3fwd-graph/main.c +++ b/examples/l3fwd-graph/main.c @@ -599,6 +599,7 @@ check_all_ports_link_status(uint32_t port_mask) struct rte_eth_link link; uint16_t portid; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -623,16 +624,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* Print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port%d Link Up. Speed %u Mbps " - "-%s\n", - portid, link.link_speed, - (link.link_duplex == - ETH_LINK_FULL_DUPLEX) - ? ("full-duplex") - : ("half-duplex\n")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* Clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73332 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C0AFA00C5; Mon, 6 Jul 2020 22:40:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7BDF1DDBA; Mon, 6 Jul 2020 22:38:50 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5ABC61DD68 for ; Mon, 6 Jul 2020 22:38:46 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203846euoutp01c88580e41129cc742b45556a14841fbd~fRFVIR-6j1241012410euoutp01E; Mon, 6 Jul 2020 20:38:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203846euoutp01c88580e41129cc742b45556a14841fbd~fRFVIR-6j1241012410euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067926; bh=O8BZcOjmjjfyos4EN+drgkw7ydPT/VazCurM2vsSk0g=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=SHy/2RF9hhfTdt+ocMXP7OA3dB9TANhNUeBuaK+0VdYNeOR2NUmiPDSEaJ/YX+xYl GUnwWO0sBdmsvI5AEnMSfVINJYOxB2906Uo7ek077RagAVJrkY4tvLp2yfta3ATGT+ j0v8Jo7l+R7nknWQeS9AyEs/QlU0i/meIQsjBMv8= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203845eucas1p24c3a55a9bc8eac98170f2c2ec1159daf~fRFUCQ4471728517285eucas1p2C; Mon, 6 Jul 2020 20:38:45 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 3F.C6.06318.4DB830F5; Mon, 6 Jul 2020 21:38:44 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203843eucas1p2207dc76350211e49c4b81af097499c8a~fRFS6J0VV2126821268eucas1p2E; Mon, 6 Jul 2020 20:38:43 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706203843eusmtrp158e60cc8697ecb3a32cc60b8cc64d987~fRFS5RpV12965829658eusmtrp1s; Mon, 6 Jul 2020 20:38:43 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-48-5f038bd45bb8 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 53.EF.06314.3DB830F5; Mon, 6 Jul 2020 21:38:43 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203841eusmtip1ec46653a3bdfb367282da652eff8f2cc~fRFRI2Sb-1791017910eusmtip1r; Mon, 6 Jul 2020 20:38:41 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:33 +0300 Message-Id: <20200706203743.29416-20-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTVxjGc+69vfdSrbkWEl5xEdcMs5kIbpDsjW4yjZr7h8nMosxsbKzT GyACslbwg38qAUKgQ60EJ1OEVod8BAZUPowQ1kRaVpFP+cgUqxIRN0QrVZACo9wa/3ve3/M+ 5zk5OTytLmRD+MSUo5IuRZukYZVMY8ds96aBfDpus+fNVqy9XULw0aiFRlfhfRbzX2RROFwZ jTebLirQ9MBAYYHpJYVN1/JY/M+VyeBzdxOF91qdHBb3ZXLoto1z+Gv37wTHvc9ovFD6imB3 yXUFzv51g8Upr5nBgrd3CZ62OgjajS8ZLGxpJpiTJ+CLinIOLffWodvlYNA50sBhtaeXxuu3 5wmetdcS7MpZVHz1ofi29KpCtNycoMRzZb202DFSxInGzhJKrHveTIlTbXdZscBaScS/H+XT YtXYDLtX+Z3yi0NSUmK6pIvY9pMy4Ypjhk4tUh4vu2BRGEg2n0cCeBCiYKq0jcsjSl4tXCNw 6skwIw/TBB4PLvidVwQyy9zUu0iBrUEhG+UEzK/7/YOHwILFQXxbrPAxOHNLKJ8RJNSx0OQd Wo4HCntgxlmzrBkhDEaHB2mfVglboMpdw8kVoVD1Z/sS5/mAJX7pVogPq4V1MHR5evlMEHp4 uJQ56L/STpjqeOrPBsIzu9WvPwDnOSMj6wx4Uz/EyeFcAqPmbP9SNFj/vcP5ymjhE6i9ESHj 7ZDlMrI+DMIqGJ5c7cP0kjQ1nqdlrILcHLW8rYH2zj4/BpifWyljERZHyln5eVoJdE1OkjMk tPh9VykhlSRYStMnx0v6yBTpWLhem6xPS4kPP3gkuZ4s/VXngt3TTNq8P9uIwBPNSpWLp+PU Cm26/kSyjQBPa4JUO7qcP6pVh7QnTkq6I3G6tCRJbyNreUYTrIo0T/ygFuK1R6XDkpQq6d65 FB8QYiC6sJOh38ZsdxcGJu2+GP1ktjesJW1/9VxDTIZV2T629rcIx5XvY1t/+bp/zt65KTg8 ape3Mvjs69aNA99kxMSa/qkoXr9hZINx+rzBk5oV9HTNPtNebWNW8ZcB5vkehbpiqymxKH3/ is2frfro1sPFA2dicU+2N8HwR0vP2K7Hn89ExR7UMPoE7acbaZ1e+z+11ifYpwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3cdLm7L6seKpYMiIq9Ns52FaQ+iixSIEb21oTe1nLPd LbK/7KlsZg9jUNrSzB5q9vCZWOmgtKaYWT5KzcSIHpjpKhXLtqT/vud8vucB5zCkwk0pmaQU s2BK0SeraRnl+tPYG9huI2OX/yrl4E6zA8FAXyEJ/Rd6abANnyCgqzgC6qrzJHD+XToB2ee/ E1B900rD1/5jFAyNVBPQ89AlhUsvj0lhxPlRCqdbcxF8nPxMwsX8UQStjkoJjDfU0vBt8ioF 2ROvEZypaELQmPWdggsPahCcsrIwfOuGFAp7VDDS30SBq7tcCqU/2kiobP6N4FzjHQQtp6Yk awL4ifwiCV9Y94ngcwraSP5pt13KZz1zEPy9oRqC//boNc1nVxQj/vmAjeRLBsfoKNlOLsxk tJgF/0SjaF6t3qWBYE6jAy54hY7ThGj3rAoOVQeFh8ULyUmHBFNQ+F4u8VrTGJlqlx0uuFgo SUcnGSvyYTC7Amc7yyVWJGMUbBHCRRldnoDxAIy/DJLTntl4ssNKT3tGEba9aJN4Ac0uwa5M B+EFfuxbGrdnHKW8YDa7CY+5ygivpthFuK+r418nObsKl4yUSae7LsQld+tJ7zAfT/7yE6VX Ktgk/Mb9z6FgVbjzips4i2bmoxnFyE+wiIYEg6jhRL1BtKQkcHFGw33kuXjV0/HyGvTy3hYn Yhmk9pVn0mSsQqI/JKYZnAgzpNpPvq7FFaOQx+vTjggmY6zJkiyIThTqWe8cqZwTZ/T8T4o5 VhOq0YJOow3RhqwE9Tx5JtuwW8Em6M3CAUFIFUz/6wjGR5mOsgLFrUxehP/19nS7oJpKWhtY Devnx6jfZ4QX7/edisppObB5Y+U+35Dnj6fWyXrrIsWKTZlKWZB/wPYlybcPuo/n/twwK+eD VuV+xs3dHL9MZ9eVRttjLEcib+6IWhCwq7O8NvokLtV+XVw0p9ZUt+1V3oYXCyMu21RsTX3V n4B4NSUm6jVLSZOo/wvXqKOPBwMAAA== X-CMS-MailID: 20200706203843eucas1p2207dc76350211e49c4b81af097499c8a X-Msg-Generator: CA X-RootMTR: 20200706203843eucas1p2207dc76350211e49c4b81af097499c8a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203843eucas1p2207dc76350211e49c4b81af097499c8a References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 19/25] examples/l3fwd-power: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-power/main.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 9db94ce04..ba6bab4a5 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1945,6 +1945,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1964,15 +1965,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint8_t)portid, - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73333 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67498A00C5; Mon, 6 Jul 2020 22:41:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 721091DD84; Mon, 6 Jul 2020 22:38:54 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E76CC1DD01 for ; Mon, 6 Jul 2020 22:38:47 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203847euoutp01b9e45394b9cd3d5e5bf90b2660e7a7b7~fRFWkVR8O3113131131euoutp01b; Mon, 6 Jul 2020 20:38:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203847euoutp01b9e45394b9cd3d5e5bf90b2660e7a7b7~fRFWkVR8O3113131131euoutp01b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067927; bh=xMUQMNB8i6t8ay1gcbcdZCHyGWgNvOkvIPzWBMqAo/g=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=SGDGFzX4u+1/FNRUBb+qzNDkQXMwyd4qYUGAnQSGAlZDlaLjUbZPKer2/6i3vyjg/ yg34WlkrxWlevfJjz3XSQcU6LvbZkXrVqtV1gb9gQe4ze3z35Zj4T4jowlKZPzY7Tv fXcCXuLdxI4AWD5xpe2QZKDtiY9cnL9zwErGvoAU= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203846eucas1p262094025f9606b87f765920285d0d48b~fRFVtmCFm2127421274eucas1p25; Mon, 6 Jul 2020 20:38:46 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 12.D9.05997.6DB830F5; Mon, 6 Jul 2020 21:38:46 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203846eucas1p21bbcbf41b435e8fcb0ef75aa0d0c2b82~fRFVXI4k12067820678eucas1p2A; Mon, 6 Jul 2020 20:38:46 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203846eusmtrp21881ce9aaba93e4c98783b2775d101bd~fRFVWWJ2t0640206402eusmtrp28; Mon, 6 Jul 2020 20:38:46 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-dd-5f038bd679cb Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id B2.8E.06017.6DB830F5; Mon, 6 Jul 2020 21:38:46 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203844eusmtip1e5ebfc75dbaa5719d2ef868cc6cb7996~fRFTlMaKd1791017910eusmtip1s; Mon, 6 Jul 2020 20:38:44 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:34 +0300 Message-Id: <20200706203743.29416-21-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf0wTZxjH89xd745ql6NqeIUFs2Yz00S0w+gTNTqNZpfNP5Zlm4kJYtVL QQFND0RmYkClI0WRdYZF1FrASYWZipafosE2AqVAJ4YhiyASnRFFoOIP2DlGOZb9930+3+/z Pk+evDytt7PRfHJaumRJM6UYWC1T0zzRueyPfDpxRWf5UnS3OwAH+8toHDjdx2L+6HEK71ds wMbacxq0P8ymsMA+RmGty8bii4GjDL4M1VL44GaAw+KuoxyGvE85PBk8C/hUGaLxjPMVYNBR rcGJ2w0sjiilDBZMdgOe8rQCtpwYY/B0fR2g1Sbg6OVyDssexGJooJXBQO91Dn97fZfG6vb3 gD+1uAE7rFOazz8SJ52/asSyxmeU+HPJXVps7i3ixBN+ByVWvayjxJFb3axY4KkAsW0wnxYr H79jv9Zu167bI6UkH5Qsy9fv1Cb1P3YyB4ILDjmLWyEbKiNtwPNEWEkmS4w20PJ6wQVkIPdP jVqMA3l70k2rxSsgw75LYIOImY46xxCnGuVArIqPUYvXQJpG3VQ4xQqfkkCegwob84UqltQq PTPGPGErOf/Ox4Y1I3xC/H0dM1onrCG5z6/T6ohFpPJqEx1eMGKan78THcZ6IZb0XBifeZMI v/OksWSQU/ObiW/Ixah6Hhlq8czyD8lU/QVK1YfJ22s9nNqcB6S/NHc2tIF4nndy4WG0sIS4 G5areCOpKq3h1CN9QO4PR4YxPS3tNb/QKtaRPKteTRtIk79rFhPy/u+5KhbJJWsfo25/E4hi 5QphUfH/o5wAFRAlZcipZkn+LE3KjJNNqXJGmjlu9/7UazD9UwP/tIzXQYOyywsCD4a5ujyW TtRrTAflrFQvEJ42zNdt6gjs0Ov2mLJ+kCz7Ey0ZKZLshRieMUTp4kufJegFsyld2idJByTL fy7FR0Rng0XnNqaYjTk5b7IurmVi/HOW+O2rOr/bFlvtMV0c2bzKXz2itH31rXutd2VbXOvY saScQzfqzV8qMfdCfwXPfBFTttctu/g5Hzu1x+LNU92rfWuKfnzSeORK4XpdsND4wrY6cUu7 7DlyK2HjROY35+Izh10Jj5TFm74vuhdKbm6KXGhg5CSTcSltkU3/AnPWKz+lAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917dzelxW0pXUYvF5oEreYjj2Fa/nWj/pD6IyhtLr2otBe7 m+mCsMyyqcvMhLTWzCRfZaU2E61clNY0UdNealOU0kLNjHSYtvX473vO55zvOXCOABfNEmJB ilrP6tQKpYT0JhyLbYNb+nNw+bbORR+o7bAgGBkqw8FZOEhCzvQZDN5WRUGz7SoPCj5mYGAu +IaBrcJEwlfnaQImZ2wYDLQ4+FDcc5oPM/ZPfMjrKkHwaWEChyvW7wi6LA08mG9tImFq4QYB Zlcfggv17Qjacr8RUPiwEcFZEwXTlbf4UDawDmac7QQ43tXxoeZHNw4NHb8QXGyrRdB5dom3 y49xWct5TFnzOMZcKu3GmefvivhM7gsLxtybbMSYqUd9JGOur0LMy5EcnKkenSNjvA9JI3Qa g57dkKzh9Dslh2UQJJWFgzQoJFwqCw6L2xEUKtkaGZHIKlNSWd3WyHhp8tColdB2+aZZi9tR BqpeaUJeApoKoRstE3wT8haIqHJEF+ePuQOBG9D0l1H8b80qeqHfRP6t+Y7oAtsg3wNIKpB2 ZFswD/ChPpB077lThAesovbR1+aekh5NUP70i8HOP1pI7aCzvtT9c11PV999gnuGebnz156J PVJEpdDvZ//Yi6h19Jvrs1g+WmFFy6qQD2vgVEkqLkjKKVScQZ0kTdCo7iP3xR88n69vRKbJ A3ZECZBkuTCbxOUiniKVS1fZES3AJT7C6E7HEZEwUZFuZHUauc6gZDk7CnWvdxEX+yZo3P+j 1stlobIwCJeFBYcFbwfJamE21RoropIUevYYy2pZ3f8+TOAlzkDlfjMu+8nYiM9NFQ/Ux5ei z/tpS8cT4u5UFjl/6jJ/QtLI4/2vDkef+dyuXdsa0DOU62QyVyp9D97Ul4zVumxz8UomK2D3 khFfNC9Lk7puZ54YvrL3fUxNQeCTgIWmPeZ8pd9rY0gUa87aqLneG3+Z2GSUzB8dalmTN+xV F+mfLSG4ZIVsM67jFL8BTvbzJQcDAAA= X-CMS-MailID: 20200706203846eucas1p21bbcbf41b435e8fcb0ef75aa0d0c2b82 X-Msg-Generator: CA X-RootMTR: 20200706203846eucas1p21bbcbf41b435e8fcb0ef75aa0d0c2b82 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203846eucas1p21bbcbf41b435e8fcb0ef75aa0d0c2b82 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 20/25] examples/multi_proc*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- .../client_server_mp/mp_server/init.c | 14 +++++--------- examples/multi_process/symmetric_mp/main.c | 12 ++++-------- 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c index c2ec07ac6..3ca9bcae3 100644 --- a/examples/multi_process/client_server_mp/mp_server/init.c +++ b/examples/multi_process/client_server_mp/mp_server/init.c @@ -185,6 +185,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -204,15 +205,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", ports->id[portid], - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)ports->id[portid]); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", (uint8_t)ports->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c index 9a16e198c..0480874f8 100644 --- a/examples/multi_process/symmetric_mp/main.c +++ b/examples/multi_process/symmetric_mp/main.c @@ -365,6 +365,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -384,14 +385,9 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73334 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DA7CA00C5; Mon, 6 Jul 2020 22:41:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CBEAD1DDC4; Mon, 6 Jul 2020 22:38:57 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 898701DDBF for ; Mon, 6 Jul 2020 22:38:51 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203851euoutp01438931d82220fba9b2b9ac70c9231dfc~fRFZ8dib-0553305533euoutp01m; Mon, 6 Jul 2020 20:38:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203851euoutp01438931d82220fba9b2b9ac70c9231dfc~fRFZ8dib-0553305533euoutp01m DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067931; bh=SjcxeTJpiGhJMyyglT2md+9M7XhR8AM1X0pflSOG9+o=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=cdENy7ewfLUnwZ7gbXFLzYN8vTP8dutN2z+hKsggMpmczHM598gzPIzuXhX4oCV5g Txnora6EcsZWJtWpXOwLmvkrx5AbBtSpIiIZenS7bDeIkY7kfouqqU/dpAcqOkbo/P NghrPkIb1vnUl3GpkFtSg6FojS6KP1oo38YSArFg= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203850eucas1p2c42a088aecee98376ef174c6f5f0be31~fRFZKO42L2126421264eucas1p24; Mon, 6 Jul 2020 20:38:50 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 34.D9.05997.ADB830F5; Mon, 6 Jul 2020 21:38:50 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706203849eucas1p2b573ab867439ead5c864cc7638649079~fRFX9Ur_F2127421274eucas1p27; Mon, 6 Jul 2020 20:38:49 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203849eusmtrp247217959ba8fa44962e3eca2adb72359~fRFX5nQtE0640206402eusmtrp29; Mon, 6 Jul 2020 20:38:49 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-e1-5f038bdab54a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D4.8E.06017.9DB830F5; Mon, 6 Jul 2020 21:38:49 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203847eusmtip1c716ffb8431841cf1ecf8b2a69964e24~fRFWH4-fC1500415004eusmtip11; Mon, 6 Jul 2020 20:38:47 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:35 +0300 Message-Id: <20200706203743.29416-22-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0wTWxSFc2amM0O1ZKwkbNGgNj6uJorXq8mOGvGByfwx4Y+a+LjQKyM2 ApoWVDQqIYpIKyigiI/yiopALlUKhaYawEfB4gWqXBStIjEx+OJhiaCgUqbGf2d9a629T04O T6tz2BBel5Ao6RO0cRpWydQ8GGld1GWko5ZYPNOwssVMsOdlCY3duR4Wjf3HKXxaFo4O22UF Zr9KoTAze4BCW2kGix+6Uxn8NGij8MVtF4cX3akcDja+5fB06yWCb0ff0Zhf+Jlgq7lagSMN dhb7RosZzPzaQTDL2kTQaRpgMLeulmBahoD9N65zWPIiFAe7mxh0PavisGKoncbqljGCZ52V BB+l/VCsmS1+LbyqEEscvZSYU9ROiw+enedEU7OZEm9+qqXEvjsdrJhpLSPiwx4jLZa/GWYj lVuVq2KkON1+SR+2Olq5u8pxjd6Xzx+ssVUxKeRfNoME8CAsgxG3m2QQJa8WSgmYPO8ZWXgJ eBzlCll8JuCtG6Z+VdpTW1jZuE6gyn6FlsUQgSceG+NLscIf4Eo3Uz4jSLjJgm20c6I+VYiA e8aK8QbPM8JcOFer8mGVsAJM+R2cvGEmlFvqJyIB4/zK/RAfVguh0FngnRgJQgsPjqFMIucj wHuh13+7qfDOafXPmQE/6gr8/DB8udXJyeV0Ai+LT/hD4WB9/x/nW0YLC6DSHibjtWCtt0xg EALh6ccpPkyPH7Nr8mgZqyA9TS2nNVDf7PZjgLFvk2UswkmnlZJf5zaB4rFq9gyZefH3rkJC ykiwlGSIj5UMSxOkA4sN2nhDUkLs4p1742+R8a/q+u701hL76D+NROCJZrIqnaWj1ArtfkNy fCMBntYEqdY9cv2tVsVokw9J+r1R+qQ4ydBIpvOMJlj1V3HvDrUQq02U9kjSPkn/y6X4gJAU EtMLAwuXzArN4eerI/PMAUNFDd6lgYu6dKUbe/YU5SV/OD7nqDGr9XVe+DFmrTsm17Q9bNND KWjb+pXDlg3L++4emr1l1/8LNjfYsX9e2+sb2yxdeter6KyBsojnfFNH83xz4Dq3J7Incdb3 tuenvugGV6sKdW2THMHDfUfOPz7LCBrGsFv750Jab9D+BKlqQ/mmAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSe0gTcRzvd3e7u1nLaxldI1IHQliuptm+mllk0YEE0oOih3PkoaZztdtC K0qlbGxmaQ+wbJqytGlq+Sw0cuSjpoiF1cpKyoosfGWRZo8t6b8Pn9f3C98vjUvHCRmdlGrg 9amaFDnpRTh/d7wKcllw9cqb+RRUd1kRvH1disPAhVckWEZPYvDcvg6aGwtFkP8mA4Pc/DEM GsvNJHwZyCJgeLwRg/4WJwWXH2dRMO74SMGZnisIPk4P4VBQ/BVBj7VeBJOtd0kYmS4hIHeq D8HZuk4EHTljBFy404Qg28zA6I0yCkr7l8D4QCcBTlctBZXfenGo7/qFIK+jGkF39h/Ren9u qtgm4kqbP2Hc+Wu9ONfuukRxOQ+tGHdruAnjRu71kVxunR1xj95acK5i8AcZ47VbEaHXGQ28 X6JOMKyV71FCsEIZBorgVWEKZYhqX3hwqHxFZEQ8n5J0mNeviIxTJNY2X8cPFtBpDY21RAaq Is1ITLPMKrY3q8uNvWgpY0NsW20bYUa0W2DZz4P4jGc+O/3U/M8vZb4i9rtJ5cEks5R1mqyY J+vDvCTZJ6czCY8wn9nIPrBU4p4egglgLzZJPLSECWdzCvqomU5ftqLm/j+L2M1fbZN5oJRJ Yl9MUDOTlrDPiiawc2huMZplRz68UdAmaIVghaDRCsbUBMV+nfY2ct+7oX2yrgmZh7c5EEMj +RyJicTVUpHmsJCudSCWxuU+kg3dzlipJF6TfoTX69R6YwovOFCoe7s8XLZgv879PakGtTJU qYIwpSpEFbIa5AslJqZ1r5RJ0Bj4ZJ4/yOv/5zBaLMtAOwqjJ1XWQ/jUYOnOy1HJ/e80/raJ zduvjNp7y+fhrS0bP7Rsifab/T5ww5OSH8NbR6oyAvhdaYZTpmm/fpX/iczN3tiauVPR7fUr 44JsL21RMa6yruhHRw94X1M/OFYUW236ubgmU7QpYbn6tAHNemNc1Lk9/vgy8YeikiF794iv TE4IiRplIK4XNH8BnJlDoAUDAAA= X-CMS-MailID: 20200706203849eucas1p2b573ab867439ead5c864cc7638649079 X-Msg-Generator: CA X-RootMTR: 20200706203849eucas1p2b573ab867439ead5c864cc7638649079 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203849eucas1p2b573ab867439ead5c864cc7638649079 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 21/25] examples/ntb: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ntb/ntb_fwd.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index eba8ebf9f..84fe374c4 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -729,6 +729,7 @@ start_pkt_fwd(void) struct rte_eth_link eth_link; uint32_t lcore_id; int ret, i; + char link_status_text[60]; ret = ntb_fwd_config_setup(); if (ret < 0) { @@ -747,11 +748,10 @@ start_pkt_fwd(void) return; } if (eth_link.link_status) { - printf("Eth%u Link Up. Speed %u Mbps - %s\n", - eth_port_id, eth_link.link_speed, - (eth_link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Eth%u %s", eth_port_id, + link_status_text); break; } } From patchwork Mon Jul 6 20:37:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73335 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E790BA00C5; Mon, 6 Jul 2020 22:41:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 007FE1DDC1; Mon, 6 Jul 2020 22:39:01 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 40BCF1DD84 for ; Mon, 6 Jul 2020 22:38:53 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203853euoutp018674466abcef1a9bb4d72536e328ec90~fRFbgwZ631241012410euoutp01F; Mon, 6 Jul 2020 20:38:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203853euoutp018674466abcef1a9bb4d72536e328ec90~fRFbgwZ631241012410euoutp01F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067933; bh=XtbX4XCFxTlmDt9RDrOth1o/sdpob+sTnBAjVCFknHA=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=lcJrFNGOmTH9NjhoOvEHna7pm4sws/W9YHYr6STMl2y/cXfJ0P6Pyq0njEWaVNjHj LX65AGSXeaX03f03z6wYpWlO/YdcLKK4gjW/p+BiGf6opcJKSZ47h6+gT/JcdtOYaT 2HKRO0NaSeeOAmdl6+89afXoWCH0IIQ+bKvZgWZU= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203852eucas1p2301d29759a202a8f824540ef8b9bf1d0~fRFbHYuRx2121221212eucas1p2-; Mon, 6 Jul 2020 20:38:52 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 91.D6.06318.CDB830F5; Mon, 6 Jul 2020 21:38:52 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706203851eucas1p1aeb631663772fc95d1fa11bb1873dbe7~fRFaheo8o2656026560eucas1p1I; Mon, 6 Jul 2020 20:38:51 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203851eusmtrp2ef39420c24985f7b7f6fa350e76158a1~fRFagtDy40640206402eusmtrp2_; Mon, 6 Jul 2020 20:38:51 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-53-5f038bdc5e17 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id F6.8E.06017.BDB830F5; Mon, 6 Jul 2020 21:38:51 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203850eusmtip1e312f2420c6eca14abe8b24eabf2b843~fRFYuOZTj1560515605eusmtip1I; Mon, 6 Jul 2020 20:38:49 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:36 +0300 Message-Id: <20200706203743.29416-23-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSb0wTdxjH89xd745q9VaNPuCm0sRkMxG2aeITwkAXYy7GbHu1ROKG3TyB CIX0QATfEEQkBVGRTMVREEJgxQR0CEgKYjMELUKAOSAi64gJoaj8kepEEKlX47vv83m+z/N9 8stPZI1FfIiYYElVrBZzoonXc413X/dsG8lnY7+cPP0Z1XXbgcZGK1nyFD/mKX86h6EhRzQ5 m37XUdG/WQwVFs0w1FRj4+mpJ5uj57NNDI20ugUq6c8WaNY1LtCZ3itA4wteli6XvwDqtd/U 0es7LTxNLVRwVDj/EOhsQxdQZ8EMR8W3moFybRJN/1EtUOXIRpr1dHHkHv5ToGu+PpZudi8C ne+sA3qQu6TbFSrPl1fp5ErnBCNfuNrHyneHfxPkgnt2Rr7+vJmRp9oe8nJhgwPk+2P5rFz7 5H/+B32MPvKwkphwTLGGRx3Sx3u81pSn+uMDOTlCFvwn2iBIRGkHtrypZ2ygF41SDWBfdoWg FXOAPV3NgeIFoNP5Uvgw0jbqAK1RDZjjnOO1wgc4U/WS87t46XN059nfL14rXeexaWGQ8TfW SPvxkm14WYsiJ23Bsu5MPzZIETjgnQEtYRPW1rezfkvQMi/tCPFjo7QRB8vm3q9EqVvEkqmx gH8P1i9d0Wl6DXo7GwKXfopLt8oYTZ/AVzcGBW04D3C04lTAFI0Nkz2CP4yVvsC6lnAN78a/ naOcH6O0CoeefeLH7LIsarzIatiAeblGzW3C9nv9AYy4+GalhmUcyK/mtNdpBSx3FcM52FTy MascwAHrlTQ1KU5Rt1uU9DDVnKSmWeLCfk1OugHLP9X9ttPXDG0Lv7hAEsG00uAR2VijznxM zUhyAYqsaa3h2wfun42Gw+aMTMWaHGtNS1RUF2wQOdN6w/aKiZ+MUpw5VTmqKCmK9UOXEYNC skBwBNdyvoR0ODFfEHqhvaujtXbFYnxHxve3hd7wuqp/MqNSSiMd4/u+Djs5eYanvaURE3t+ TD8SfPBqaKTu9IGTF0sbDTUdRx7NXprbvCVyH7faEnVqiIJvu1O9vm3fPHIfzc4bzoxpEQ6k qKsOPfvr+LpxcV5332nfGbMiWg76zmfi1HjzV1tZq2p+B1qkH9elAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSfUgTcRjH+93d7k5rcU2zS3xrEFTQ2abm41KLgjgoKCqCytKlh0rO2W6r phUmS+U0U4vIypeyyFZQlqaJSVq+1BQxyTJfMotEE197UTNtQ/rv4fv5PA8PPA+NKyYIdzo2 3igY4rVxStKZsM019qzvysDDN2RP+cPD5gIE/b3FOPRd7iEhY8yCwQfrZqiuuCGD3E/JGGTl jmNQUSKRMNyXQsDIRAUG3c9tFFx7m0LBRN0ABRdaryMYmB3CIa9oEkFrQbkMpmurSBidvUVA 1sw7BBfLmhA0Zo4TcPlZJYJUiYGxe3cpKO72gom+JgJsnU8oePCzDYfy5r8IchofImhJnZdt WcXPFN2R8cXVgxh/6WYbzjd0XqH4zNcFGF86UonxozXvSD6rzIr4N/0ZOH//6xS52/kgF2zQ m4yCT4xeNIYoD6lAzamCgFP7B3Eqv8DDGnWA0jc0OEqIiz0hGHxDI7iYviFDwrDzqXaLhUpG n2kJOdEs48/W9FqRhJxpBXMHsYPDY5SEaDtg2e9f8QXHhZ3tkMgFZxKxlzo6MAcgmTWsLb0A cwBXpotk29POEQ7gwuxkr0qdmGMQwaxmC5sTHbGc0bDtQ+NoYag3e//RC9yhONnz/Hp3R6lg YtmPPyiHoWC82PeFP7BstLQILbIiV8Ek6qJ1opoTtTrRFB/NRep1j5H93k8bpssqkTSytw4x NFIukaeTeLhCpj0hmnV1iKVxpat8a4vtiEIepTUnCgZ9uMEUJ4h1KMC+XQ7uvjxSb/+eeGO4 KkAVCEGqQL9Av42gXCFPZ2rDFEy01igcE4QEwfC/D6Od3JORj+ppxOc/Uwe+5Idq5EkyTS7k Ly3ftm/Vt2R1edr4spW/Ttf/Nuq5RzGmvKSB85rjJZsqttf6Cm4Wt/aQPS5z173DZj3bOl/d Xjx6YZuTWUo8y3UY36btn2o5aflSHbJj/syu5qDSqhqP2nWh5r9xZWuHPDCx+GWJb5Kn1XzU TxxQEmKMVrUON4jaf0YdVtgFAwAA X-CMS-MailID: 20200706203851eucas1p1aeb631663772fc95d1fa11bb1873dbe7 X-Msg-Generator: CA X-RootMTR: 20200706203851eucas1p1aeb631663772fc95d1fa11bb1873dbe7 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203851eucas1p1aeb631663772fc95d1fa11bb1873dbe7 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 22/25] example/performance*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/performance-thread/l3fwd-thread/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 84c1d7b3a..bd10014a0 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -3433,6 +3433,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -3452,14 +3453,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73336 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5199BA00C5; Mon, 6 Jul 2020 22:41:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBF511DDEC; Mon, 6 Jul 2020 22:39:04 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 682051DD01 for ; Mon, 6 Jul 2020 22:38:55 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203855euoutp025d0ec8630d1f93c18785d21918f4ca9b~fRFdjEvS92313123131euoutp02t; Mon, 6 Jul 2020 20:38:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706203855euoutp025d0ec8630d1f93c18785d21918f4ca9b~fRFdjEvS92313123131euoutp02t DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067935; bh=M/wyN4nGPfl8N+dBV9oGDaEn0+uBQWGX9DXEsrG01Ys=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=RyDm8b+kNFQLbvMPSosjLDB1gvDJB9xFCkXTLs7Wn+E9HgEBhjsS1YLWXbym+MZ5g dTss1t4Z/TwMyPfcAWqNIq4ypUswoKvOTU35srvX31T52QxCOsitIM7MuZMPBq0ef1 aosFjeojNFYkBq5E5zJ6oafY5tWSCYANZIvTIRP8= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706203854eucas1p23eddec3a375a4389d815861516218ebb~fRFdQpVDB2127421274eucas1p28; Mon, 6 Jul 2020 20:38:54 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id B3.D6.06318.EDB830F5; Mon, 6 Jul 2020 21:38:54 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706203854eucas1p190bd0852cecbbede8423d6efa7bf554a~fRFc4AaD02656126561eucas1p1G; Mon, 6 Jul 2020 20:38:54 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706203854eusmtrp165777c9fe2db3d89f9ea81e30349e953~fRFc3LFW62965829658eusmtrp1x; Mon, 6 Jul 2020 20:38:54 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-56-5f038bded397 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 06.EF.06314.EDB830F5; Mon, 6 Jul 2020 21:38:54 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203852eusmtip1a90eb64fd185418d371ca8a43ec12839~fRFbF1xrV1500415004eusmtip12; Mon, 6 Jul 2020 20:38:52 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:37 +0300 Message-Id: <20200706203743.29416-24-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0hTYRjG+c45O+e4mp1W5IfdaBFUlBUFvURXCzpGUX8EQZG68jQl3WJH V1bUihKbS0vtpmm2UTPNLJu3UquRTdu8dBHTzEYFdre8YKVWm2fRf8/7vL/3fV4+PpZUZtDB bIw2XtBr1bEqWk6VPfrZOLczhYyYbzMvgGJ3LoI3nVYSPJmvaEj5doyAFwUroKr8ogzSXxsJ SE3/TkB5vomGz56jFHztKSego9rFQNbTowz0OLoYONmUjaBr6CMJF/J6ETTllsrg54M7NHQP WShI/dWCIM1eh8Bp/k5BZmUFgiQTB9+u2RiwdkyBHk8dBa622wxc739CQql7GMFpZzGChqQ/ spXT+F95V2S8teoDwWdcfkLyj9rOMry5Ppfgb32tIPjumhaaT7UXIP7xmxSSL3z3g94k3ypf GiXExhgE/bzlkfLoht/t9J6bzL62UitjRCbahAJYzC3Cjx/aCBOSs0ouH+G7J7toqehDuPZe D+mjlFwvwsPZy/9NWDo6SQmyeSfa6/1FP8LGVA/jo2huJnYl547sHc/donH5UCvha4zj1uFL 7ecpn6a4GXig6uXIIQpuCW5prkBSxFRcePO+dyvLBnj9nNpg6YopuPVS38hOzDWzuC+njpL4 NbgsM4WU9Dj80WlnJD0JuzLMfuYAHihpZaThZIQ7Lcf90Aps/9TI+MJIbhYuvjNPslfhxgvd IzdgLhC/+DLWZ5NemV52zm8rcHKSUqJV+H79U7+N8fDgaMnm8Z9si/95qhG+OvCMPoWmZv3P ykOoAAUJCWKcRhAXaoW9IaI6TkzQakJ26uJKkPerun47+ytQzdAOB+JYpBqt8LBkhFKmNoiJ cQ6EWVI1XhHa4ApXKqLUifsFvS5CnxAriA40kaVUQYqFlg/blZxGHS/sFoQ9gv5fl2ADgo2o IVu3JWrtxhu6rEhrUbD9sJYLOyhbnNNlWLZ5slv2/PCh8IRTtsrJ2yqfXV71+cicmoDeZW8D 7+r2Vw9OzwsLDzuxftTcwAkbog3WdrezZaNj0r5daeJx9/uQxU1BiRc31E7QFIaWhMZzu89U mjWITetoNr4e0zxqMCY0cnD1ziLDahUlRqsXzCb1ovovK7pcIKYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSeUgUcRTH+83MzqzSyrAaDQZWS1JEbq5HPs8ioob0jyDoj9S2QSe1XDd2 dkXzH5XyWG3LMkmz9cIyFbx1Cyu1PGo1j7Ba88oE6SDzCI/M2lX678v7ft77PnhPjEsXCWdx TJyW18RxsTLSnjCvd4+5jWfhSveK7B1Q02tEMDVehsNk7hgJWT+vYvCh8jC0thSK4NZEMgaG W3MYtFToSfg+mUrAj/kWDEafmikoGEqlYL5jhoLr/fcQzKx9xSG/eAFBv7FJBCvtT0iYXSsl wLA6jOBGYw+C7uw5AnIfmxCk6Wn4+eghBWWjLjA/2UOA2dJAQfWvQRyaev8gyOmuQdCX9ld0 ZDe7WlwuYstav2Ds7ZJBnO2y5FFs9isjxtb9MGHs7LNhkjU0ViL29VQWzlZNL5On7M/KAzRq nZbfFa0WtIGyUAV4yBW+IPfw8pUrPH3C/Ty8ZQeDAiL52Jh4XnMw6Lw8um99hLxcSyVYmsqo ZKQn9chOzNBeTOnoOK5H9mIpXY4YU7NFpEdiq8Ew36bxTcaRWXtn423MAmKWx+oJm0HS+xhz hhGzGU70R5J5m56yYTjSJ5mikbsbmqBdmaXWjxtpEtqPGR4woc2pO5mq2jbcFmZnrd/vdLZJ KR3DjCxSNkJKuzDvixaxm8ihGG2pRE68TlBFqQSFXOBUgi4uSh6hVtUj68Wbu1YaTGio7nQH osVItlWSQeJKqYiLFxJVHYgR4zInydE+8zmpJJJLvMJr1EqNLpYXOpC3db0c3HlbhNr6P3Fa pcJb4QO+Ch9PH89DINsuyaDbw6R0FKflL/H8ZV7zvw8T2zkno0vKpJCUiGBPj3S/wuTO9Sqd 2+83x68VNdv3JOW9yAy/6feGemxcc1g4O00EdM1GSnbnvyworH64Zyo02FBz5gunvd4buNf/ +dLMp6rKRYe2hWNflQeEYVdTuCShK8Kgt5Rc/DzhXnAiJXQuZyDWP4wLfhA13WcXMk42OV3I vDO4IiOEaE6xH9cI3D+SQhHKBwMAAA== X-CMS-MailID: 20200706203854eucas1p190bd0852cecbbede8423d6efa7bf554a X-Msg-Generator: CA X-RootMTR: 20200706203854eucas1p190bd0852cecbbede8423d6efa7bf554a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203854eucas1p190bd0852cecbbede8423d6efa7bf554a References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 23/25] examples/qos_sched: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/qos_sched/init.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 9626c15b8..4bb975fc9 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -160,14 +160,8 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) "rte_eth_link_get: err=%d, port=%u: %s\n", ret, portid, rte_strerror(-ret)); - if (link.link_status) { - printf(" Link Up - speed %u Mbps - %s\n", - (uint32_t) link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else { - printf(" Link Down\n"); - } + rte_eth_link_printf(NULL, &link); + ret = rte_eth_promiscuous_enable(portid); if (ret != 0) rte_exit(EXIT_FAILURE, From patchwork Mon Jul 6 20:37:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73337 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37C12A00C5; Mon, 6 Jul 2020 22:41:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F8DD1DDEF; Mon, 6 Jul 2020 22:39:07 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id C45EE1DD65 for ; Mon, 6 Jul 2020 22:38:58 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203858euoutp01b2da319a54a5d5dd9792e7c597d3c8d8~fRFgt63P53113131131euoutp01c; Mon, 6 Jul 2020 20:38:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203858euoutp01b2da319a54a5d5dd9792e7c597d3c8d8~fRFgt63P53113131131euoutp01c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067938; bh=WQh0/xZ8D/8NSNS0F/gifzw1wCeRoFQ4rQBL4QRJi0A=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=XnATxjCQPC6BWtZfYVJ1GOEa8EEQxQIsuWd8Pcm2EOJuTZJTUUOPvev7oWMmrDldG ToxS8+sAlJKtO0gEYNagQ+phMcYhQAXX9trgrfVZv8W3FUq7KAlYu+wWS5uRk/mg1s hEw+uGu1hfQQirXmoLAj102gSnyoQLQblF8nH0XI= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706203857eucas1p1bae3f1c9f9b96f4a32ddd4ffe379be9a~fRFf3grll2654826548eucas1p1G; Mon, 6 Jul 2020 20:38:57 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 86.D9.05997.1EB830F5; Mon, 6 Jul 2020 21:38:57 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706203857eucas1p1b97d37ca61cda22ff7e93e08e1e01fbe~fRFffbySN2656026560eucas1p1K; Mon, 6 Jul 2020 20:38:57 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706203857eusmtrp236f696e6e99ec0ad4e2ca4d48218a66d~fRFfeX3n80640206402eusmtrp2-; Mon, 6 Jul 2020 20:38:57 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-ea-5f038be10c77 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 19.8E.06017.1EB830F5; Mon, 6 Jul 2020 21:38:57 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203855eusmtip1f5dbb9097b7843e04c59f7fa4993d122~fRFdvIWaz1791017910eusmtip1u; Mon, 6 Jul 2020 20:38:55 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:38 +0300 Message-Id: <20200706203743.29416-25-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0xTZxjH85733OioO1Y3H5nRWYPOy2TMJXumy5yGsfNBExP8oFsEOz0B N6imB5xoog1qV0CwgNHguFTwimYMLNeoqRiorCBIhthEXKcmTN2oFhqUoYxyMPv2e37P5Z+8 eUVqKOSjxB3mdMViNqUaeR1b3/ay68M/c2nSR77exVjdUUbwwf1Kiv5j/TzmPjvE4N2q1Xil oYTDwj+sDOYXPmew4XwOj3/7s1gcDDYweO+qV8CTPVkCBlsGBMzr+pngwNgTisXOIYJdZXUc vrzezGNgrILF/NFegkddNwl6jjxn8VhTI0FbjoTPLpwTsPLeXAz6b7Lo9V0W8FLoNsW6jlcE CzzVBDtt49yX8+VR5xlOrrzymJGLTt2mcpvvuCAfaS9j5JrBRkYOXOvl5XxXFZF/e5BL5YuP XvAbdN/oPt+upO7YrVhivtiqS2lzB7ldh9/a0/06IFiJX8whESJIn0D2hVI+h+hEg3SegLuq W9CKYQLlp1tZrRgikP1LEfdmxdlVS8NskM4RcHbEaxwikJUXGWZe+gC89jImvDxTquGhYayP CTdmSOugvyk0yawUDQ9PDbFh1ksrYTDLMRUwDy7+6p4IEMWICV/aGqXdnwt95cOTN0H6XYRx 3wjR5uMgz/GQ1XgGPPG4BI3nwHhTOaPxPhip7RO0ZTuB+xWHp4ZWg+vpLSEcRqXFUN0co+k1 MHr8p0kN0jS4+8/0sKYTWFh/gmpaD3abQZs2gru9Z0oDvPo3UtMy2LsfUe0JrxJ4eiifOMi8 k/9nOQmpIrOUDDUtWVE/Nis/LldNaWqGOXn5tp1ptWTip3pfe4YbSfPYdy1EEokxUm/naZKB M+1WM9NaCIjUOFO/ttObaNBvN2XuVSw7kywZqYraQt4TWeMs/YqKx1sMUrIpXflBUXYpljdd RoyIshIcf3uFpy7+L1cooPu66ED9thKj786q9er0ZG7BwU02es1qTrRv2ltqK+Fu7H/n+x7H xvZ9jmXvf+sIxTADC/NowWfBPWtuxGUGzqbXDGTPidvqH9nc2ereMi3owLWtI9FttxISYmeL 0XJx4pJlKZ8WF3y1tP9Of+zRd62rUI5flGBk1RRT7BJqUU3/AdeHL8OlAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSfUgTcRjH/d3dbqc5PabVZWE1MERqNs18FK2oiAvCCinp1WZdKrkt7qZk 9YeppcxaTaU3y2YqlQamrjQzXxZpNc00rCxNU0FK8W0T0szakv778v18nxd4HgqX2ggvKl6t 5Xi1MkFGuhCWueaeNd+y8Oi12SZ3KGvJR9D/tRCHvtweErLG0zH4VLIRaqtuiSC7NwUDffYE BlX3dSSM9KUSMDpZhUH3c4sYbnakimHSPCSGS215CIZmf+Bww2hF0Jb/WATTjTUkjM3eJUA/ 04ngsukVguaLEwTkPq1GcEFHw/iDe2Io7PaGyb5XBFi6KsXwcKodh8ctvxEYmssQtF74I9q0 kp0xFovYwtrvGJtT0I6zTV1XxezF1/kYWz5ajbFjdZ0kqzeVIPZNfxbOlg7+JHe57JeH8ZpE LbciTiNow2UHFBAgV4SAPGBdiFwRGHwoNCBI5r8h7BiXEJ/E8f4bjsjjmhomRSfPLzj1bm5M nIL6KB1yphh6HWNsq8B1yIWS0sWIeTFnJXSIsgOGGR7E5zMezOwHHTmfsSKmYrCKdACS9mUs mfmYA3jSX0jmfcY5wgE86B1Mz9MpzKEJ2ocZKLD+8yV0KDOaekU033U5U/qoAXcMc7b7t196 OaSUjmc+28SOhJT2Zj7esWFXkJsROZUgTy5RUMWqhAC5oFQJiepY+VGNqgLZL/6kadpUjXSj kWZEU0jmKskk8WipSJkkJKvMiKFwmadkc6vlsFRyTJl8muM10XxiAieYUZB9PQPutfCoxv4/ am20IkgRDCGK4MDgwPUgWyzJpBsPSulYpZY7wXEnOf5/HUY5e6UgQ23Erus5W97GvHAp7djW bfjVu6JeYbjjVhORXukeFqU/27hl4taeIptvpbwl3du6OjKsIO3ZPqM+58D1DD7Es3d3KNm9 bHeqx4c0wcm/KNyU5Lrzso+7+xK/VXnqJv21pV3h2XVRA+Vbz/A3vsQumpmqGa7PjTk+ErXG RsD2jIK9MkKIUyr8cF5Q/gVz6HcsBwMAAA== X-CMS-MailID: 20200706203857eucas1p1b97d37ca61cda22ff7e93e08e1e01fbe X-Msg-Generator: CA X-RootMTR: 20200706203857eucas1p1b97d37ca61cda22ff7e93e08e1e01fbe X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203857eucas1p1b97d37ca61cda22ff7e93e08e1e01fbe References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 24/25] examples/server_nod*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/server_node_efd/server/init.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/init.c index 378a74fa5..00224850e 100644 --- a/examples/server_node_efd/server/init.c +++ b/examples/server_node_efd/server/init.c @@ -247,6 +247,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -266,16 +267,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - info->id[portid], - link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - info->id[portid]); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", info->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:37:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73338 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14F62A00C5; Mon, 6 Jul 2020 22:41:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE23F1DDF5; Mon, 6 Jul 2020 22:39:09 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 0681D1DDE3 for ; Mon, 6 Jul 2020 22:39:02 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706203901euoutp01627112f026ea05970bbd9cf740f48cef~fRFjsWg1W0553305533euoutp01n; Mon, 6 Jul 2020 20:39:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706203901euoutp01627112f026ea05970bbd9cf740f48cef~fRFjsWg1W0553305533euoutp01n DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067941; bh=U2zVf/WfC+GxbbAndLEN5cAyOf8BWxrHjaueCQ0L+Sc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=NnsszgiDXChJIn5LrXb4Fp/8Io1SQlcf/3ylZ4JmQUzTk7+UBz6gMG5EMHSDw8IYC 7efxufJOScbyY4T86n21BTE3uuTfYaGWfRMIA/ZWjBMazg9NEYackCueIwEeCitDA5 QGyHfOctvzG+Bebo0s4xnAoFDwKO9attOqHpV1PY= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706203901eucas1p1f311bdef850c6435460d7b47bc0dadb1~fRFjgFvhB0771107711eucas1p14; Mon, 6 Jul 2020 20:39:01 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id D5.D6.06318.5EB830F5; Mon, 6 Jul 2020 21:39:01 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706203900eucas1p1da635a7b8512d7c087ea0def6de3223d~fRFiR4HCr2656126561eucas1p1H; Mon, 6 Jul 2020 20:39:00 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706203900eusmtrp162391a1da290811395c319a5109fb92a~fRFiRG_jg2965829658eusmtrp1y; Mon, 6 Jul 2020 20:39:00 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-5d-5f038be505a1 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 28.EF.06314.4EB830F5; Mon, 6 Jul 2020 21:39:00 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706203858eusmtip1235043423b66ee7e8e507fba87bb3302~fRFgby2sP1560515605eusmtip1J; Mon, 6 Jul 2020 20:38:58 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:37:39 +0300 Message-Id: <20200706203743.29416-26-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706203743.29416-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTdxTGOffe3ntp6HKtJJygYmx0bnODKXOeGDcmM+YmfvHL5mIysZMb dFDUFvAtJqjIWGFMwGHkTQYaatmGL2iLinFNpLriKiS8GBnrFNMhiFpAoYMx6q3Zt+f5Pc8/ 5+TkL7L6Mj5W3JGZpZgzjRkGXstdbpv0vveokE153303jpraa4Ae9Nez5Dv+B0+Fz/IY6rUn 0TVHlYZK/8xlqLj0OUMOm5WnYd9hjkYCDob6Wj0CVXQeFijg8gv0nbcSyD/1mKWTtaNA3ppL Gpr89QpPT6fqOCoOdgF933wLyF30nKPjLU6gfKtEz842CFTfF0cB3y2OPPcuCvTTeAdLl9qn gUrcTUB38mc0nyySg7VnNHL9tUFGLvuxg5Xb7pULctHtGkY+P+Jk5KfXu3i5uNkO8m8PClm5 cWCC36jdrF2TqmTsyFHMCR9v1W4/5yiDXUPavYMzk2wuuEQrRIoofYBPxn9graAV9ZINsMf1 UKOaMcAXM1cF1YwCHu2+yb1+8nfesXDQAGi73w6qGQecCHbwoRYvvYWeghomFERL53l0TPUw oWCutAGt5S2akOakJVj5l+0V10mr0dfrZdURC7Hx3I1ZLYqRs7z6ZmwI66U47Dk1xqiVdhF9 eZtUvQ6dV8sFVc/Fx+7msJ6PnrKi8NYH8OWFnldbo1QA2F93NFxKwuah34XQLFZ6G5uuJKh4 Ldqr7BDCKL2BvU/mhDA7K0svn2BVrMOCfL3aNuCN251hjDj9T5SKZXR+WxU+VStg/aEZ4Rgs rPh/Vi2AHWKUbIspTbEkZip74i1GkyU7My1+207TBZj9qp5/3eNOuD71lQskEQxROp/Ipug1 xhzLPpMLUGQN0brkO54tel2qcd9+xbwzxZydoVhcME/kDDG6xLrBL/VSmjFLSVeUXYr5dcqI kbG5EOHl/JuyEn7JiShO2sZ3dA5Uj67/JtGdfvaIEhj6TNf0xanVEem7X4irprmo2En/5mU/ n353S0FVcGmjZuVAoH/Ey+15FBwWE06abDhhuh89Eid93fppat+KipKXW4PdzIdjXftb3lz3 eUNl8rDdH9O2Pj55sOSg50D6Rxe7FyxYttjAWbYbl7/Dmi3G/wAGcU7upgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d+9cLS/T6MeCrKURoatptqOURURd8J9eBGmmyy4+cpvu br3+sgdm00xTJCvNB6JpoqZLJyZtUNOmiYallflgZVZkakGaPTay/z6c7/ec84VzxKRslpKL k3RG3qDTpChoCeX87RgOcmWRsZvLqpZBfXcJgvG3FSSMFgzTkPX1EgGDNTugveW2CK6PpBOQ c32agJZqMw2fRy9Q8GWmhYA3D50M3Oy/wMCMfYKBq723EEwsfCShqHQWQW+JRQRztjYaphbK KciZH0BwrbkTgSN7moICayuCDDMLX+9WMVDxZjXMjHZS4BxqYuDe9z4SLN2/EOQ56hH0ZPwR 7VzLzZdWiriK9kmCyy/rI7knQ4UMl91VQnCNX1oJbqpjgOZymmsQ93Q8i+RqXT/ofZIo5TaD 3mTk1yTqBeN2RbQKgpWqMFAGbwlTqkLUMeHBoYpNEdtO8ClJp3jDpog4ZWJDSz5K/SQ5M/ln jkxHdrEZeYkxuwV/uJTLeFjGViLcZPU2I7G7jvEnF/nP4oMXXphpM5K4LbMI95fn0B6BZjdg Z2YJ4RF82dc0fn75POURfNhIbC60ijxMsQH41lg14WEpG45HB3sXp/rh2oZHpGeZl7te/Fju QRmbhF99W4yzGr+8843IRctL0ZIa5MubBG2CVlApBY1WMOkSlPF67X3kPviDJ3NNrai/8aAd sWKkWCbNpMlYmUhzSjirtSMsJhW+0l09zmMy6QnN2XO8QR9rMKXwgh2FuuPlkfIV8Xr3++iM sapQlRrCVOoQdchWUKyUZrK2ozI2QWPkT/J8Km/430eIveTpaO34kUjXT+vx6i6tafvYuzZp UbG38sDAaakjdbbsRvjyNC9ToHW6NjKh2WIpcqzvjnl2ZcCyNMqmWSU3BWavqHemjeg2BqCM IL8X6ovJtugp296IAn/11aKVcZLk3VPTjCuRCzzWvUvG7u/Aq+rmresOP9zzvq4j7LxPZ7z/ IUZBCYka1UbSIGj+AqZrbeQGAwAA X-CMS-MailID: 20200706203900eucas1p1da635a7b8512d7c087ea0def6de3223d X-Msg-Generator: CA X-RootMTR: 20200706203900eucas1p1da635a7b8512d7c087ea0def6de3223d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706203900eucas1p1da635a7b8512d7c087ea0def6de3223d References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v6 25/25] examples/vm_power_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/vm_power_manager/main.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index 273bfec29..05aec1aad 100644 --- a/examples/vm_power_manager/main.c +++ b/examples/vm_power_manager/main.c @@ -244,6 +244,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid, count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -267,15 +268,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint16_t)portid, - (unsigned int)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint16_t)portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */