From patchwork Mon Jun 29 16:01:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiri Kuzin X-Patchwork-Id: 72432 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E231A0350; Mon, 29 Jun 2020 18:01:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8645C1BFA7; Mon, 29 Jun 2020 18:01:29 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40040.outbound.protection.outlook.com [40.107.4.40]) by dpdk.org (Postfix) with ESMTP id C6F991BFA4 for ; Mon, 29 Jun 2020 18:01:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kSzGmKSyVMfoAnM9FJBpiznTKBDixRPGrnHzfu6U29WTcagG7TaKlpLahh6HXKNEMYulxEWWGPILn9TX5qo4YoBlPQ0ZY57Z1mujNw8kNWZtb7j5DQj2NHodszpjp2vx+5zelXeSC6csjlUe4jdQuSgy6gvcxm/dc3kQ1ype85pHp9R20ayAwEqDNK7nmhwu5Mrg/jUMAyka1rHxY5KVEs/x8BCmqXxSdfwOmSaNCfFMUFixPhqUA70+B0tasgtvgMZgnM3Y53gviFbKbcUstuoPwe6xc5yDVrRotDHWGqKVX431WfhZArIvuiUTNCx4epTcwusRH+ZMY2CGs3hHFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gNx1UDrM/XV6ePaM7guJcZvQBoetYHEkejwQF8ofDes=; b=J7UX2Uz9qfVlW0mLQ5NcmtDKBazLB8ccBOhgSCDFZbQOu2zDygDLyTmMIBfA3/KWXu9k9ozBfsDQvgQfJFQv6Q+Bh0MKPB4L3+vEgXonOMDdtEDlMhBElvfg6i1A0BKBrneFH92cbf1mRj1QXlIuHI0cJh7u3025rcP8UKQVZQOHnhOFdTuYkTmDX0nVReB/p3K/kP/AI1pbeEYRM9maLQM4S/rJLyNKFXgbkm5khpF/A9X89K17ezFya0DW31u7kgeJ/oLci72knboKg+IYmCDN2q5PsCB43ET/AxA+Frez5Lu6coyGfy7HovrvzYfSeehiTfvm4IXpNzxNoryE6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gNx1UDrM/XV6ePaM7guJcZvQBoetYHEkejwQF8ofDes=; b=dCOk0HvgVxNFcoeYOETIwBx1HG26+Umtp2AQs2vMRlrTHJ7wEj8E1vybjVnBf9amD/EnI03Lh65H2dMrJlOZsJmR6bY4KbyhITUQIRnc0yy10wuPsuHiDpUKiEN45x+aWrXN4AoGtpOcR0HRGv8iw6Ih1+9ABXqwJnCz+HiCcTs= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR0502MB3874.eurprd05.prod.outlook.com (2603:10a6:208:1a::29) by AM0PR05MB4948.eurprd05.prod.outlook.com (2603:10a6:208:cc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.26; Mon, 29 Jun 2020 16:01:26 +0000 Received: from AM0PR0502MB3874.eurprd05.prod.outlook.com ([fe80::84e5:30fb:782e:5e60]) by AM0PR0502MB3874.eurprd05.prod.outlook.com ([fe80::84e5:30fb:782e:5e60%4]) with mapi id 15.20.3131.027; Mon, 29 Jun 2020 16:01:26 +0000 From: Shiri Kuzin To: dev@dpdk.org Cc: matan@mellanox.com, viacheslavo@mellanox.com Date: Mon, 29 Jun 2020 19:01:12 +0300 Message-Id: <1593446472-4335-1-git-send-email-shirik@mellanox.com> X-Mailer: git-send-email 1.8.3.1 X-ClientProxiedBy: AM4PR0701CA0003.eurprd07.prod.outlook.com (2603:10a6:200:42::13) To AM0PR0502MB3874.eurprd05.prod.outlook.com (2603:10a6:208:1a::29) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mellanox.com (94.188.199.18) by AM4PR0701CA0003.eurprd07.prod.outlook.com (2603:10a6:200:42::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.11 via Frontend Transport; Mon, 29 Jun 2020 16:01:25 +0000 X-Mailer: git-send-email 1.8.3.1 X-Originating-IP: [94.188.199.18] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b7e7c6bb-563f-4db6-c256-08d81c45ad7d X-MS-TrafficTypeDiagnostic: AM0PR05MB4948: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-Forefront-PRVS: 044968D9E1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WBrgpxsZZpe6DZooE8fD68fDJfEyAAnAanrZJxNzy4DD5w1rOUdrGbSJiWrvTXcfpUzHF3oQDwXM7qAGJ/N0Gup1dzX/gzUcleJAlahFYEPdsDNkSqGf9/OFdEE/e1OllLzG7hZI551B/kFVCPqMMVuixIaR4fkdOT/EWeu6gOsMHPJ54uxopiCKDQZRu0wgcwW/BsTanxhneqE+QtcSEktfE/6AYbU7LGBkvnYFUsHimyE9CCBgaSayS7YlStAn0bXw24AFurGQXNGWkY+5RtjGX/DTRSdrzczMSXnXbaoIgQxONva6VFamiHekB24w X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB3874.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(136003)(396003)(346002)(376002)(6916009)(83380400001)(2906002)(956004)(316002)(4326008)(36756003)(66556008)(66946007)(66476007)(2616005)(8936002)(478600001)(26005)(8886007)(107886003)(8676002)(186003)(55016002)(6666004)(16526019)(7696005)(86362001)(5660300002)(52116002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Quy/O0Ca4qHaaSJhWTvVGM++dq5f7Vs3K8r9XbD1b5B2VlFVx/c9yF+1zPH6jmfXebmzCSnSsgivLNzLvK/BCZc9mE60pCAyH4AifKGInVTVIALAT6ckVlus95VRJ1cSNCw2fJJKbxvUp++NM3LjXjocMtaW5JnA+zF5SVtYn7v5WcYYcOdvxK5slghHFaHQ97pAZg/6tIDSyMxVDMlhZURi3fho+2UdG3lKFm28PHNnLobS9V6QDbVV18BbR898AED5D/BJJocF3/MzhXbcm3HlRCKg/RgLZDHFnJi0dgATN7cLlo0yanzjMCNUoWoTZBDgM1gzUhoteIzxEBxMJ/JxS/3+Jh1H33sq67YMqJdLF8DlfityHNqIOUPsHSGPq0cHoHdojgiyfXd9R/25dOdE3xNciHLXPQrDtgkOOYufNXJrY5jUN6c/i0X3dX62J9Z0wSzAH6vJSHVhZ+oSZW9m1cGtil2rDAALUZG+jHU= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7e7c6bb-563f-4db6-c256-08d81c45ad7d X-MS-Exchange-CrossTenant-AuthSource: AM0PR0502MB3874.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2020 16:01:26.4105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BrM93jHlDQj8akXypWnJvxAoM5mhA/VLzZQY3te6hcNwszSaZOLwz8/CUyTrEGidKkV0mKcTZNty74DJzktGsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4948 Subject: [dpdk-dev] [PATCH] net/mlx5: fix LACP action type casting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The mlx5_flow_lacp_miss flow rule for matching LACP traffic was added to steer LACP traffic to kernel. When setting the action type of rte_flow_action to MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS we get an error since the action is an enum of type mlx5_rte_flow_action_type. To solve this a casting of MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS to rte_flow_action was added. Fixes: 6ff4a90223c4 ("net/mlx5: add default miss action to flow engine") Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 4700ec1..4a031a5 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -5060,7 +5060,8 @@ struct rte_flow * }; struct rte_flow_action actions[] = { { - .type = MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS, + .type = (enum rte_flow_action_type) + MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS, }, { .type = RTE_FLOW_ACTION_TYPE_END,