From patchwork Wed Jun 10 18:53:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 71211 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29A36A051E; Wed, 10 Jun 2020 20:53:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A5211BF78; Wed, 10 Jun 2020 20:53:16 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C24671BF72 for ; Wed, 10 Jun 2020 20:53:14 +0200 (CEST) IronPort-SDR: CZGd6Rk3PeuZQuH5ORX27+Mjm+EBijtWOZrbIs5uSi3HVl9N8aUCwYL5qACkK98iqu/K7LCSqZ dRqiVTFvg/WA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2020 11:53:13 -0700 IronPort-SDR: i2ltTecL3WIap2drdGQqYKCl1RIhUP+rlrxEdWr0Dlpiopltn12wODg7dNgZlZ9ak3virBG42U 9T7hvcgUSXRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,496,1583222400"; d="scan'208";a="380157183" Received: from akusztax-mobl.ger.corp.intel.com ([10.104.121.40]) by fmsmga001.fm.intel.com with ESMTP; 10 Jun 2020 11:53:11 -0700 From: Arek Kusztal To: dev@dpdk.org Cc: akhil.goyal@nxp.com, fiona.trahe@intel.com, arkaduszx.kusztal@intel.com Date: Wed, 10 Jun 2020 20:53:07 +0200 Message-Id: <20200610185308.15220-1-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.19.1.windows.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/2] cryptodev: add function to check if qp was setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Fiona Trahe This patch adds function that can check if queue pair was already setup. This may be useful when dealing with multi process approach in cryptodev. Signed-off-by: Fiona Trahe --- lib/librte_cryptodev/rte_cryptodev.c | 28 ++++++++++++++++++++++++++++ lib/librte_cryptodev/rte_cryptodev.h | 14 ++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index e37b83a..705387b 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -1080,6 +1080,34 @@ rte_cryptodev_close(uint8_t dev_id) } int +rte_cryptodev_get_qp_status(uint8_t dev_id, uint16_t queue_pair_id) +{ + struct rte_cryptodev *dev; + + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { + CDEV_LOG_ERR("Invalid dev_id=%" PRIu8, dev_id); + return -(ENODEV); + } + + dev = &rte_crypto_devices[dev_id]; + if (queue_pair_id >= dev->data->nb_queue_pairs) { + CDEV_LOG_ERR("Invalid queue_pair_id=%d", queue_pair_id); + return -(ENODEV); + } + void **qps = dev->data->queue_pairs; + + if (qps[queue_pair_id]) { + CDEV_LOG_INFO("qp %d on dev %d is initialised", + queue_pair_id, dev_id); + return 1; + } + + CDEV_LOG_INFO("qp %d on dev %d is not initialised", + queue_pair_id, dev_id); + return 0; +} + +int rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id, const struct rte_cryptodev_qp_conf *qp_conf, int socket_id) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index 4aaee73..d01a658 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -727,6 +727,20 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id, const struct rte_cryptodev_qp_conf *qp_conf, int socket_id); /** + * Get the status of queue pairs setup on a specific crypto device + * + * @param dev_id Crypto device identifier. + * @param queue_pair_id The index of the queue pair to check. + * + * @return + * - 0: qp was not configured + * - 1: qp was configured + * - -ENODEV: device was not configured + */ +int +rte_cryptodev_get_qp_status(uint8_t dev_id, uint16_t queue_pair_id); + +/** * Get the number of queue pairs on a specific crypto device * * @param dev_id Crypto device identifier. From patchwork Wed Jun 10 18:53:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 71212 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48EFDA051E; Wed, 10 Jun 2020 20:53:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E9031BF85; Wed, 10 Jun 2020 20:53:17 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 123381BF70 for ; Wed, 10 Jun 2020 20:53:15 +0200 (CEST) IronPort-SDR: huMK546ihnpsJ+EQQHzSAxz8mthxalTOfOiNmgjR/v7Cz06yXIkcjMfHzDTS1wNVuJV/R29VWP VcdDUW69hBbQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2020 11:53:15 -0700 IronPort-SDR: 7O7YcFcTp0mkKM5ODgvCNlGZ8csO27yPh34oZ/s6+iNN2vX5g9NO5yb+NR3Iq6x7oS2kGP2C9a IddnA+rJiTiQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,496,1583222400"; d="scan'208";a="380157187" Received: from akusztax-mobl.ger.corp.intel.com ([10.104.121.40]) by fmsmga001.fm.intel.com with ESMTP; 10 Jun 2020 11:53:14 -0700 From: Arek Kusztal To: dev@dpdk.org Cc: akhil.goyal@nxp.com, fiona.trahe@intel.com, arkaduszx.kusztal@intel.com Date: Wed, 10 Jun 2020 20:53:08 +0200 Message-Id: <20200610185308.15220-2-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.19.1.windows.1 In-Reply-To: <20200610185308.15220-1-arkadiuszx.kusztal@intel.com> References: <20200610185308.15220-1-arkadiuszx.kusztal@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/2] cryptodev: add cryptodev trace in multi process function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Fiona Trahe This patch adds traces to some Cryptodev functions that are used in primary/secondary context. Signed-off-by: Fiona Trahe Acked-by: Fiona Trahe Acked-by: Akhil Goyal --- lib/librte_cryptodev/rte_cryptodev.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 705387b..230c5cf 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -717,8 +717,13 @@ rte_cryptodev_data_alloc(uint8_t dev_id, struct rte_cryptodev_data **data, mz = rte_memzone_reserve(mz_name, sizeof(struct rte_cryptodev_data), socket_id, 0); - } else + CDEV_LOG_DEBUG("PRIMARY:reserved memzone for %s (%p)", + mz_name, mz); + } else { mz = rte_memzone_lookup(mz_name); + CDEV_LOG_DEBUG("SECONDARY:looked up memzone for %s (%p)", + mz_name, mz); + } if (mz == NULL) return -ENOMEM; @@ -749,8 +754,14 @@ rte_cryptodev_data_free(uint8_t dev_id, struct rte_cryptodev_data **data) RTE_ASSERT(*data == mz->addr); *data = NULL; - if (rte_eal_process_type() == RTE_PROC_PRIMARY) + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { + CDEV_LOG_DEBUG("PRIMARY:free memzone of %s (%p)", + mz_name, mz); return rte_memzone_free(mz); + } else { + CDEV_LOG_DEBUG("SECONDARY:don't free memzone of %s (%p)", + mz_name, mz); + } return 0; } @@ -807,8 +818,15 @@ rte_cryptodev_pmd_allocate(const char *name, int socket_id) cryptodev->data->dev_id = dev_id; cryptodev->data->socket_id = socket_id; cryptodev->data->dev_started = 0; + CDEV_LOG_DEBUG("PRIMARY:init data"); } + CDEV_LOG_DEBUG("Data for %s: dev_id %d, socket %d, started %d", + cryptodev->data->name, + cryptodev->data->dev_id, + cryptodev->data->socket_id, + cryptodev->data->dev_started); + /* init user callbacks */ TAILQ_INIT(&(cryptodev->link_intr_cbs));