diff mbox series

[V1] tests/vm2vm_virtio_net_perf_cbdma & vswitch_sample_cbdma: Optimize the Secure Copy file size

Message ID 20230426102256.23323-1-dukaix.yuan@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/vm2vm_virtio_net_perf_cbdma & vswitch_sample_cbdma: Optimize the Secure Copy file size |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Yuan, DukaiX April 26, 2023, 10:22 a.m. UTC 
  Secure Copy (scp) is used to verify whether the vm2vm established connection successful.
1MB file size is too small, which may cause verification failure.
So,change file size from 1MB to 10MB.

Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>
---
 .../TestSuite_vm2vm_virtio_net_perf_cbdma.py  | 28 +++++++++----------
 tests/TestSuite_vswitch_sample_cbdma.py       |  2 +-
 tests/virtio_common.py                        |  4 +--
 3 files changed, 17 insertions(+), 17 deletions(-)

Comments

Ling, WeiX April 27, 2023, 10:06 a.m. UTC | #1 
> -----Original Message-----
> From: Dukai Yuan <dukaix.yuan@intel.com>
> Sent: Wednesday, April 26, 2023 6:23 PM
> To: dts@dpdk.org
> Cc: Yuan, DukaiX <dukaix.yuan@intel.com>
> Subject: [dts][PATCH V1] tests/vm2vm_virtio_net_perf_cbdma &
> vswitch_sample_cbdma: Optimize the Secure Copy file size
> 
> Secure Copy (scp) is used to verify whether the vm2vm established
> connection successful.
> 1MB file size is too small, which may cause verification failure.
> So,change file size from 1MB to 10MB.
> 
> Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>
> ---

Acked-by: Wei Ling <weix.ling@intel.com>
Tu, Lijuan April 28, 2023, 12:40 a.m. UTC | #2 
On Wed, 26 Apr 2023 18:22:56 +0800, Dukai Yuan <dukaix.yuan@intel.com> wrote:
> Secure Copy (scp) is used to verify whether the vm2vm established connection successful.
> 1MB file size is too small, which may cause verification failure.
> So,change file size from 1MB to 10MB.
> 
> Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Applied, thanks
diff mbox series

Patch

diff --git a/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py b/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py
index 8fece79f..176a25af 100644
--- a/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py
+++ b/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py
@@ -475,7 +475,7 @@  class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
 
@@ -528,7 +528,7 @@  class TestVM2VMVirtioNetPerfCbdma(TestCase):
         )
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -547,7 +547,7 @@  class TestVM2VMVirtioNetPerfCbdma(TestCase):
         )
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
 
@@ -741,7 +741,7 @@  class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=16)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
 
@@ -871,12 +871,12 @@  class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -961,12 +961,12 @@  class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -1143,12 +1143,12 @@  class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=16)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -1180,12 +1180,12 @@  class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.start_vms(server_mode=False, vm_queue=1)
         self.BC.config_2_vms_ip()
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -1269,12 +1269,12 @@  class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.start_vms(server_mode=False, vm_queue=8)
         self.BC.config_2_vms_ip()
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
diff --git a/tests/TestSuite_vswitch_sample_cbdma.py b/tests/TestSuite_vswitch_sample_cbdma.py
index 783275f2..feb3b4f2 100644
--- a/tests/TestSuite_vswitch_sample_cbdma.py
+++ b/tests/TestSuite_vswitch_sample_cbdma.py
@@ -649,7 +649,7 @@  class TestVswitchSampleCBDMA(TestCase):
             self.vm0_pmd = PmdOutput(self.vm_dut[0])
             self.vm1_pmd = PmdOutput(self.vm_dut[1])
             self.BC.config_2_vms_ip()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         iperfdata = self.BC.check_iperf_result_between_2_vms()
         return iperfdata
diff --git a/tests/virtio_common.py b/tests/virtio_common.py
index cf1bbe43..eec8999b 100644
--- a/tests/virtio_common.py
+++ b/tests/virtio_common.py
@@ -87,7 +87,7 @@  class basic_common(object):
         fp.write(data)
         fp.close()
 
-        # scp file from tester on VM0
+        # scp file from tester to VM0
         out = self.test_case.vm_dut[0].send_command(
             "scp root@%s:/tmp/payload /tmp" % self.tester_ip, timeout=5
         )
@@ -95,7 +95,7 @@  class basic_common(object):
             self.test_case.vm_dut[0].send_command("yes", timeout=3)
         self.test_case.vm_dut[0].send_command(self.tester_passwd, timeout=3)
 
-        # scp file from VM0 on VM1
+        # scp file from VM0 to VM1
         out = self.test_case.vm_dut[1].send_command(
             "scp root@%s:/tmp/payload /tmp" % self.vm0_ip, timeout=5
         )