diff mbox series

tests/dual_vlan: Explicitly wait for tcpdump

Message ID 20230414124739.67152-1-akihiko.odaki@daynix.com (mailing list archive)
State Accepted
Headers
Series tests/dual_vlan: Explicitly wait for tcpdump |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Akihiko Odaki April 14, 2023, 12:47 p.m. UTC 
  It is observed that sometimes tcpdump do not finish writing the packet
dump immediately after killed. Wait for tcpdump to avoid such race.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 tests/TestSuite_dual_vlan.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tu, Lijuan April 23, 2023, 8:55 a.m. UTC | #1 
On Fri, 14 Apr 2023 21:47:39 +0900, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
> It is observed that sometimes tcpdump do not finish writing the packet
> dump immediately after killed. Wait for tcpdump to avoid such race.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>


Applied, thanks
diff mbox series

Patch

diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index 70395663..694d4b2e 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -197,7 +197,7 @@  class TestDualVlan(TestCase):
 
     def get_tcpdump_package(self):
         self.tester.send_expect("killall tcpdump", "#")
-        self.tester.send_expect(" ", "#")
+        self.tester.send_expect("wait", "#")
         return self.tester.send_expect(
             "tcpdump -nn -e -v -r ./getPackageByTcpdump.cap", "#"
         )