diff mbox series

[V4] tests/pmd_bonded: modify script to support ice nic

Message ID 20230223185421.1139766-1-songx.jiale@intel.com (mailing list archive)
State Accepted
Headers
Series [V4] tests/pmd_bonded: modify script to support ice nic |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test warning SKIPPED

Commit Message

Jiale, SongX Feb. 23, 2023, 6:54 p.m. UTC 
  1.if the link status of the port of the ice nic needs to be
synchronized with the peer, the peer needs to enable 
"link-down-on-close".
2.the value of 'self.dut_ports' does not want to be changed. 
optimize the assignment method.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_pmd_bonded.py | 31 ++++++++++++++++++++++---------
 1 file changed, 22 insertions(+), 9 deletions(-)

v2:
-modify title and description.

v3:
-increase optimization.

v4:
-the value of a does not want to be changed. optimize the assignment method

Comments

Tu, Lijuan March 3, 2023, 5:37 a.m. UTC | #1 
On Fri, 24 Feb 2023 02:54:21 +0800, Jiale Song <songx.jiale@intel.com> wrote:
> 1.if the link status of the port of the ice nic needs to be
> synchronized with the peer, the peer needs to enable 
> "link-down-on-close".
> 2.the value of 'self.dut_ports' does not want to be changed. 
> optimize the assignment method.
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>

Reviewed-by: Lijuan Tu <lijuan.tu@intel.com>
Applied, thanks
diff mbox series

Patch

diff --git a/tests/TestSuite_pmd_bonded.py b/tests/TestSuite_pmd_bonded.py
index 97f76e93..cedcdd36 100644
--- a/tests/TestSuite_pmd_bonded.py
+++ b/tests/TestSuite_pmd_bonded.py
@@ -885,14 +885,18 @@  UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)'
         self.pmdout = PmdOutput(self.dut)
 
         self.tester_bond = "bond0"
-
-        for port in self.dut_ports:
-            tester_port = self.tester.get_local_port(port)
-            intf = self.tester.get_interface(tester_port)
-            driver = self.tester.ports_info[tester_port]["port"].get_nic_driver()
-            if driver == "i40e":
+        tester_port0 = self.tester.get_local_port(self.dut_ports[0])
+        self.tport_iface0 = self.tester.get_interface(tester_port0)
+        self.flag = "link-down-on-close"
+        self.default_stats = self.tester.get_priv_flags_state(
+            self.tport_iface0, self.flag
+        )
+        if self.default_stats:
+            for port in self.dut_ports:
+                tester_port = self.tester.get_local_port(port)
+                intf = self.tester.get_interface(tester_port)
                 self.tester.send_expect(
-                    "ethtool --set-priv-flags %s link-down-on-close on" % intf, "# ", 10
+                    "ethtool --set-priv-flags %s %s on" % (intf, self.flag), "# "
                 )
 
     def set_up(self):
@@ -1052,7 +1056,7 @@  UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)'
         self.dut.send_expect("start", "testpmd> ")
 
         port_disabled_num = 0
-        testpmd_all_ports = self.dut_ports
+        testpmd_all_ports = self.dut_ports[:]
         testpmd_all_ports.append(bond_port)
         for port_id in testpmd_all_ports:
             value = self.get_detail_from_port_info(
@@ -2349,4 +2353,13 @@  UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)'
         """
         Run after each test suite.
         """
-        pass
+        self.dut.kill_all()
+        if self.default_stats:
+            for port in self.dut_ports:
+                tester_port = self.tester.get_local_port(port)
+                tport_iface = self.tester.get_interface(tester_port)
+                self.tester.send_expect(
+                    "ethtool --set-priv-flags %s %s %s"
+                    % (tport_iface, self.flag, self.default_stats),
+                    "# ",
+                )