diff mbox series

[V1] tests/shutdown_api: modify the command to adapt to the changes in ethtool

Message ID 20230116150002.1789209-1-songx.jiale@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/shutdown_api: modify the command to adapt to the changes in ethtool |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Jiale, SongX Jan. 16, 2023, 3 p.m. UTC 
  The ethtool after version 5.4 does not support changing the network card speed 
when automatic negotiation is turned off. therefore, rm 'autoneg off' in script.


Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_shutdown_api.py | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Tu, Lijuan Jan. 29, 2023, 2:27 a.m. UTC | #1 
> -----Original Message-----
> From: Song Jiale <songx.jiale@intel.com>
> Sent: Monday, January 16, 2023 11:00 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/shutdown_api: modify the command to adapt to
> the changes in ethtool
> 
> The ethtool after version 5.4 does not support changing the network card speed
> when automatic negotiation is turned off. therefore, rm 'autoneg off' in script.

Compatibility is very important.
Tu, Lijuan March 7, 2023, 6:22 a.m. UTC | #2 
On Mon, 16 Jan 2023 15:00:02 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> The ethtool after version 5.4 does not support changing the network card speed 
> when automatic negotiation is turned off. therefore, rm 'autoneg off' in script.
> 
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>


Applied, thanks
diff mbox series

Patch

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index fc81c46a..9cd2b273 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -320,11 +320,6 @@  class TestShutdownApi(TestCase):
             self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
             self.used_dut_port = None
 
-        for port in self.ports:
-            self.dut.send_expect(
-                "ethtool -s %s autoneg on " % self.dut.ports_info[port]["intf"], "#"
-            )
-
         self.bind_nic_driver(self.dut_ports, driver=self.used_driver or self.drivername)
 
         if not self.vm_env_done:
@@ -629,7 +624,7 @@  class TestShutdownApi(TestCase):
             for port in self.ports:
                 if len(configs) != 1:
                     self.dut.send_expect(
-                        "ethtool -s %s autoneg off  speed %s duplex %s"
+                        "ethtool -s %s speed %s duplex %s"
                         % (
                             self.dut.ports_info[port]["intf"],
                             config[0],