diff mbox series

[V1] tests/vf_vlan:modify code to adapt avx2 and avx512 on vlan offload

Message ID 20230106180921.354155-1-zhiminx.huang@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/vf_vlan:modify code to adapt avx2 and avx512 on vlan offload |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-doc-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Huang, ZhiminX Jan. 6, 2023, 6:09 p.m. UTC 
  add parameter "--enable-hw-vlan" in testpmd.
the dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35 fixed avx2 not support this parameter.
the avx2 behavior is not appropriate,it has gap between avx2 and avx512.
so we add parameter "enable-hw-vlan" in testpmd,there is no gap in avx2 and avx512 to test vlan strip.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 test_plans/vf_vlan_test_plan.rst | 5 +++++
 tests/TestSuite_vf_vlan.py       | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

Comments

Weiyuan Li Jan. 9, 2023, 3:28 a.m. UTC | #1 
> -----Original Message-----
> From: Zhimin Huang <zhiminx.huang@intel.com>
> Sent: Saturday, January 7, 2023 2:09 AM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts][PATCH V1] tests/vf_vlan:modify code to adapt avx2 and
> avx512 on vlan offload
> 
> add parameter "--enable-hw-vlan" in testpmd.
> the dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35 fixed avx2
> not support this parameter.
> the avx2 behavior is not appropriate,it has gap between avx2 and avx512.
> so we add parameter "enable-hw-vlan" in testpmd,there is no gap in avx2
> and avx512 to test vlan strip.
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> ---
Tested-by: Weiyuan Li <weiyuanx.li@intel.com>
Tu, Lijuan Jan. 10, 2023, 7:56 a.m. UTC | #2 
On Fri,  6 Jan 2023 18:09:21 +0000, Zhimin Huang <zhiminx.huang@intel.com> wrote:
> add parameter "--enable-hw-vlan" in testpmd.
> the dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35 fixed avx2 not support this parameter.
> the avx2 behavior is not appropriate,it has gap between avx2 and avx512.
> so we add parameter "enable-hw-vlan" in testpmd,there is no gap in avx2 and avx512 to test vlan strip.
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>

Reviewed-by: Lijuan Tu <lijuan.tu@intel.com>
Applied, thanks
diff mbox series

Patch

diff --git a/test_plans/vf_vlan_test_plan.rst b/test_plans/vf_vlan_test_plan.rst
index 24877c6c..8612bd84 100644
--- a/test_plans/vf_vlan_test_plan.rst
+++ b/test_plans/vf_vlan_test_plan.rst
@@ -186,6 +186,11 @@  Test case4: VF tagged vlan rx
 Test case5: VF Vlan strip test
 ==============================
 
+.. note::
+   according to dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35,if not add parameter "enable-hw-vlan", the vlan
+   offload should be disable.the avx2 behavior is not appropriate, the avx2 and avx512 shouldn't have gap on vlan
+   offload. so add parameter "--enable-hw-vlan" in testpmd to test vlan strip.
+
 1. Start testpmd with mac forward mode::
 
      testpmd> set fwd mac
diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index d5a29c04..14c675c7 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -423,7 +423,8 @@  class TestVfVlan(TestCase):
         self.vm0_dut_ports = self.vm_dut_0.get_ports("any")
 
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
-        self.launch_testpmd(dcf_flag=self.dcf_mode)
+        param = "--enable-hw-vlan" if not self.dcf_mode else ""
+        self.launch_testpmd(dcf_flag=self.dcf_mode, param=param)
         self.vm0_testpmd.execute_cmd("set fwd rxonly")
         self.vm0_testpmd.execute_cmd("set verbose 1")
         self.vm0_testpmd.execute_cmd("start")