diff mbox series

[V1,2/2] tests/kernelpf_iavf: remove duplicate cases

Message ID 20230104083238.13296-2-weiyuanx.li@intel.com (mailing list archive)
State Accepted
Headers
Series [V1,1/2] test_plans/kernelpf_iavf: remove duplicate cases |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-doc-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Weiyuan Li Jan. 4, 2023, 8:32 a.m. UTC 
  Case kernelpf_iavf/vf_mac_filter and vf_macfilter/kernel_2pf_2vf_1vm_mac_add_filter duplicate remove this test case from kernelpf_iavf.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 42 +-------------------------------
 1 file changed, 1 insertion(+), 41 deletions(-)

Comments

Tu, Lijuan Jan. 5, 2023, 2:28 p.m. UTC | #1 
On Wed,  4 Jan 2023 16:32:38 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote:
> Case kernelpf_iavf/vf_mac_filter and vf_macfilter/kernel_2pf_2vf_1vm_mac_add_filter duplicate remove this test case from kernelpf_iavf.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks
Peng, Yuan Jan. 6, 2023, 2:12 a.m. UTC | #2 
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Wednesday, January 4, 2023 4:33 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/kernelpf_iavf: remove duplicate cases
> 
> Case kernelpf_iavf/vf_mac_filter and
> vf_macfilter/kernel_2pf_2vf_1vm_mac_add_filter duplicate remove this
> test case from kernelpf_iavf.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---

Acked-by: Yuan Peng <yuan.peng@intel.com>
diff mbox series

Patch

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 27daa525..2cc0ff7d 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -78,11 +78,7 @@  class TestKernelpfIavf(TestCase):
 
     def set_up(self):
 
-        if self.running_case == "test_vf_mac_filter":
-            self.destroy_vm_env()
-            if self.env_done is False:
-                self.setup_vm_env(driver="", set_vf_mac=False)
-        elif self.running_case == "test_vf_rx_interrupt":
+        if self.running_case == "test_vf_rx_interrupt":
             self.destroy_vm_env()
         elif self.env_done is False:
             self.setup_vm_env()
@@ -249,40 +245,6 @@  class TestKernelpfIavf(TestCase):
             stats["TX-packets"] != 0 and nums > 0, "vf send packet num is not match"
         )
 
-    def test_vf_mac_filter(self):
-        """
-        Not set VF MAC from kernel PF for this case, if set, will print
-        "not permitted error" when add new MAC for VF.
-        """
-        out = self.launch_testpmd(dcf_flag=self.dcf_mode)
-        self.testpmd_mac = self.get_testpmd_vf_mac(out)
-        self.vm_testpmd.execute_cmd("set fwd mac")
-        self.vm_testpmd.execute_cmd("set promisc all off")
-        self.vm_testpmd.execute_cmd("mac_addr add 0 %s" % self.add_addr)
-        self.vm_testpmd.execute_cmd("start")
-        # send packet with current mac
-        self.send_random_pkt(self.testpmd_mac, count=100)
-        self.verify_packet_count(100)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        # send packet with add mac
-        self.send_random_pkt(self.add_addr, count=100)
-        self.verify_packet_count(100)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        # send packet with wrong mac
-        self.send_random_pkt(self.wrong_mac, count=100)
-        self.verify_packet_count(0)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.vm_testpmd.execute_cmd("mac_addr remove 0 %s" % self.add_addr)
-        self.send_random_pkt(self.add_addr, count=100)
-        self.verify_packet_count(0)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.vm_testpmd.execute_cmd("mac_addr add 0 00:01:23:45:67:11")
-        self.send_random_pkt(self.add_addr, count=100)
-        self.verify_packet_count(0)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.send_random_pkt("00:01:23:45:67:11", count=100)
-        self.verify_packet_count(100)
-
     def get_testpmd_vf_mac(self, out):
         result = re.search("([a-f0-9]{2}:){5}[a-f0-9]{2}", out, re.IGNORECASE)
         mac = result.group()
@@ -926,8 +888,6 @@  class TestKernelpfIavf(TestCase):
         else:
             self.vm_testpmd.execute_cmd("quit", "#")
             time.sleep(1)
-        if self.running_case == "test_vf_mac_filter":
-            self.destroy_vm_env()
         if not self.dcf_mode:
             self.dut.send_expect(
                 "ip link set dev %s vf 0 trust off" % self.host_intf, "# "