[V2] test_plans/dual_vlan: optimize the test steps in the test plan

Message ID 20221229060232.25358-1-weiyuanx.li@intel.com (mailing list archive)
State Accepted
Headers
Series [V2] test_plans/dual_vlan: optimize the test steps in the test plan |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-doc-test success Testing OK
ci/Intel-dts-suite-test warning SKIPPED

Commit Message

Weiyuan Li Dec. 29, 2022, 6:02 a.m. UTC
  modify the test plan need to set port stop first when set the tx_vlan.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---

v2:
-fix typos.

 test_plans/dual_vlan_test_plan.rst | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Tu, Lijuan Jan. 4, 2023, 1:13 a.m. UTC | #1
On Thu, 29 Dec 2022 14:02:32 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote:
> modify the test plan need to set port stop first when set the tx_vlan.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>


Applied, thanks
  

Patch

diff --git a/test_plans/dual_vlan_test_plan.rst b/test_plans/dual_vlan_test_plan.rst
index fd953cd9..11dfa332 100644
--- a/test_plans/dual_vlan_test_plan.rst
+++ b/test_plans/dual_vlan_test_plan.rst
@@ -242,7 +242,9 @@  Enable vlan packet forwarding on port ``0`` first::
 
 Insert VLAN Tag Identifier ``1`` on port ``1``::
 
+    testpmd> port stop all
     testpmd> tx_vlan set 1 1
+    testpmd> port start all
 
 Configure the traffic generator to send VLAN packet without VLAN Tag Identifier
 and send 1 packet on port ``A``. Verify that the packet can been received on port
@@ -250,7 +252,9 @@  and send 1 packet on port ``A``. Verify that the packet can been received on por
 
 Delete the VLAN Tag Identifier ``1`` on port ``1``::
 
+    testpmd> port stop all
     testpmd> tx_vlan reset 1
+    testpmd> port start all
 
 Configure the traffic generator to send VLAN packet without VLAN Tag Identifier
 and send 1 packet on port ``A``. Verify that the packet can been received on port