From patchwork Tue Nov 15 07:42:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, HongboX" X-Patchwork-Id: 119866 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE2AEA0548; Tue, 15 Nov 2022 09:42:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9F81410F2; Tue, 15 Nov 2022 09:42:03 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 6768C40F18 for ; Tue, 15 Nov 2022 09:42:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668501722; x=1700037722; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=inTpYHe3UuVG9ZQOiQcuNmWIgKNdJd4xUbFy7gPWmNM=; b=H1GWnXKWd5wAms84X2TW21wTvQ8qibI0Vq7Rl2/QftNPPeUIl0S9iwsf crMEAp+zYqkdJ893PiTX2keI/6jOpXBi7SxdjiKROL2FkbdIeE96RhhMr WSH7DcgiJlESvQb2UxkololmGkcqDqhKos0ZaLQJ9NmN2T8en8IHCIApb ko2rA8Lktc4BdtxDj4/3uEcMLpicWxhbap0StrIRPCTf0+h77zJHtNCf4 FQVkeAfd7cqYqaWaCi7vlw00kLxkw45OeLCHKsWI1QkrcLA5wNppCsSna DHeDDgJ+WmJRNyjOigXXFoXW9OtDmHfMX4pZw6lWg0Px2TknanJpbn0VD Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="312203188" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="312203188" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2022 00:42:01 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="671919194" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="671919194" Received: from unknown (HELO localhost.localdomain) ([10.239.252.19]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2022 00:42:00 -0800 From: Hongbo Li To: dts@dpdk.org Cc: Hongbo Li Subject: [dts] [PATCH V1 3/3] tests/ice_limit_value_test: optimize scripts Date: Tue, 15 Nov 2022 07:42:14 +0000 Message-Id: <20221115074214.62185-3-hongbox.li@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115074214.62185-1-hongbox.li@intel.com> References: <20221115074214.62185-1-hongbox.li@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org 1.when the dpdk testpmd exits abnormally, the port will not be initialized, and sometimes the test of other cases will be affected. therefore, after the test, should use quit to close the dpdk testpmd normally to avoid the impact between cases. 2.the object named "self.session_third" is undefined, delete useless code. Signed-off-by: Hongbo Li Tested-by: Song Jiale --- tests/TestSuite_ice_limit_value_test.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/TestSuite_ice_limit_value_test.py b/tests/TestSuite_ice_limit_value_test.py index b75cea84..b5bc6dc2 100644 --- a/tests/TestSuite_ice_limit_value_test.py +++ b/tests/TestSuite_ice_limit_value_test.py @@ -1256,13 +1256,10 @@ class TestICELimitValue(TestCase): def tear_down(self): # destroy all flow rule on port 0 - self.dut.kill_all() - self.destroy_env() if getattr(self, "session_secondary", None): self.dut.close_session(self.session_secondary) - if getattr(self, "session_third", None): - self.dut.close_session(self.session_third) + self.destroy_env() + self.dut.kill_all() def tear_down_all(self): self.dut.kill_all() - self.destroy_env()