[V1] tests/kernelpf_iavf: optimize script multicast case cancel trust mode

Message ID 20221018020938.30275-1-weiyuanx.li@intel.com (mailing list archive)
State Superseded
Headers
Series [V1] tests/kernelpf_iavf: optimize script multicast case cancel trust mode |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Weiyuan Li Oct. 18, 2022, 2:09 a.m. UTC
  Case vf_multicast cancel trust model and use 'mcast_addr' add multicast
address to the testpmd.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Lingli Chen Oct. 27, 2022, 7:47 a.m. UTC | #1
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Tuesday, October 18, 2022 10:10 AM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case
> cancel trust mode
> 
> Case vf_multicast cancel trust model and use 'mcast_addr' add multicast
> address to the testpmd.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
Tested-by: Lingli Chen <linglix.chen@intel.com>
  
Huang, ZhiminX Oct. 28, 2022, 5:15 a.m. UTC | #2
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Tuesday, October 18, 2022 10:10 AM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case
> cancel trust mode
> 
> Case vf_multicast cancel trust model and use 'mcast_addr' add multicast
> address to the testpmd.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
>  tests/TestSuite_kernelpf_iavf.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
> index 73435339..494204a2 100644
> --- a/tests/TestSuite_kernelpf_iavf.py
> +++ b/tests/TestSuite_kernelpf_iavf.py
> @@ -334,13 +334,13 @@ class TestKernelpfIavf(TestCase):
>          self.send_random_pkt(self.wrong_mac, count=1)
>          out = self.vm_dut.get_session_output()
>          self.verify(self.wrong_mac in out, "vf receive pkt fail with wrong
> mac")
> +        self.dut.send_expect("ip link set dev %s vf 0 trust off" %
> + self.host_intf, "# ")
> 
>      def test_vf_multicast(self):
>          """
>          enable kernel trust mode
>          """
>          multicast_mac = "01:80:C2:00:00:08"
> -        self.dut.send_expect("ip link set dev %s vf 0 trust on" %
> self.host_intf, "# ")
>          self.launch_testpmd(dcf_flag=self.dcf_mode)
>          self.vm_testpmd.execute_cmd("set fwd mac")
>          self.vm_testpmd.execute_cmd("set promisc all off") @@ -355,6
> +355,7 @@ class TestKernelpfIavf(TestCase):
>          self.verify(multicast_mac not in out, "vf receive pkt with multicast
> mac")
> 
>          self.vm_testpmd.execute_cmd("set allmulti all on")
> +        self.vm_testpmd.execute_cmd(f"mcast_addr add 0
> + {multicast_mac}")
>          self.send_random_pkt(self.vf_mac, count=1)
>          out = self.vm_dut.get_session_output()
>          self.verify(self.vf_mac in out, "vf receive pkt fail with current mac")
> --
> 2.27.0
If you want to replace 'trust on vf' to 'mcast_addr add' in testcase,
Please update the testplan synchronously.
  

Patch

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 73435339..494204a2 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -334,13 +334,13 @@  class TestKernelpfIavf(TestCase):
         self.send_random_pkt(self.wrong_mac, count=1)
         out = self.vm_dut.get_session_output()
         self.verify(self.wrong_mac in out, "vf receive pkt fail with wrong mac")
+        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
 
     def test_vf_multicast(self):
         """
         enable kernel trust mode
         """
         multicast_mac = "01:80:C2:00:00:08"
-        self.dut.send_expect("ip link set dev %s vf 0 trust on" % self.host_intf, "# ")
         self.launch_testpmd(dcf_flag=self.dcf_mode)
         self.vm_testpmd.execute_cmd("set fwd mac")
         self.vm_testpmd.execute_cmd("set promisc all off")
@@ -355,6 +355,7 @@  class TestKernelpfIavf(TestCase):
         self.verify(multicast_mac not in out, "vf receive pkt with multicast mac")
 
         self.vm_testpmd.execute_cmd("set allmulti all on")
+        self.vm_testpmd.execute_cmd(f"mcast_addr add 0 {multicast_mac}")
         self.send_random_pkt(self.vf_mac, count=1)
         out = self.vm_dut.get_session_output()
         self.verify(self.vf_mac in out, "vf receive pkt fail with current mac")