[V1] tests/unit_tests_eal: fix acl script call error and support different rx_mode

Message ID 20220615164925.1583168-1-yux.jiang@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/unit_tests_eal: fix acl script call error and support different rx_mode |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test fail Testing issues

Commit Message

Yu Jiang June 15, 2022, 4:49 p.m. UTC
  Since DTS commit "7eaf4b60 tests/l3fwdacl: modify pmd param for acl" has incorrect usage,
fix script to support different rx_mode.

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 tests/TestSuite_unit_tests_eal.py | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
  

Comments

Tu, Lijuan June 15, 2022, 9:15 a.m. UTC | #1
On Wed, 15 Jun 2022 16:49:25 +0000, Yu Jiang <yux.jiang@intel.com> wrote:
> Since DTS commit "7eaf4b60 tests/l3fwdacl: modify pmd param for acl" has incorrect usage,
> fix script to support different rx_mode.
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>


Applied, thanks
  

Patch

diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index c1de4884..9cac6197 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -465,15 +465,18 @@  class TestUnitTestsEal(TestCase):
         """
         Run acl autotest.
         """
-        eal_params = self.dut.create_eal_parameters(
-            other_eal_param="force-max-simd-bitwidth"
-        )
+        eal_params = self.dut.create_eal_parameters()
         app_name = self.dut.apps_name["test"]
         test_app_cmdline = app_name + eal_params
         test_app_cmdline += "--no-pci"
-
-        if self.dut.dpdk_version >= "20.11.0":
-            test_app_cmdline += " --force-max-simd-bitwidth=0"
+        # When execution.cfg set rx_mode=xxx, it should have priority.
+        print("eal_para = {}".format(eal_params))
+        if "force-max-simd-bitwidth" in eal_params:
+            pass
+        else:
+            # DTS commit 68bb1b92("tests/l3fwdacl: try to use highest available method") when dpdk > 20.11.0 by konstantin.ananyev@intel.com
+            if self.dut.dpdk_version >= "20.11.0":
+                test_app_cmdline += " --force-max-simd-bitwidth=0"
         self.dut.send_expect(test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time)
         out = self.dut.send_expect("acl_autotest", "RTE>>", self.run_cmd_time)
         self.dut.send_expect("quit", "# ")