[V1,2/2] tests/interrupt_pmd: wait for interface up

Message ID 20220224152851.1511890-3-yux.jiang@intel.com (mailing list archive)
State Accepted
Headers
Series optimize script: wait for interface up |

Checks

Context Check Description
ci/Intel-dts-suite-test fail Testing issues

Commit Message

Yu Jiang Feb. 24, 2022, 3:28 p.m. UTC
  optimize script: interrupt_pmd,
use new method: is_interface_up to to ensure iface's link status before send_packets

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 tests/TestSuite_interrupt_pmd.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
  

Comments

Tu, Lijuan Feb. 27, 2022, 2:19 p.m. UTC | #1
> -----Original Message-----
> From: Jiang, YuX <yux.jiang@intel.com>
> Sent: 2022年2月24日 23:29
> To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/interrupt_pmd: wait for interface up
> 
> optimize script: interrupt_pmd,
> use new method: is_interface_up to to ensure iface's link status before
> send_packets
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>

Series applied
  

Patch

diff --git a/tests/TestSuite_interrupt_pmd.py b/tests/TestSuite_interrupt_pmd.py
index db8efe44..dd413aca 100644
--- a/tests/TestSuite_interrupt_pmd.py
+++ b/tests/TestSuite_interrupt_pmd.py
@@ -129,10 +129,11 @@  class TestInterruptPmd(TestCase):
         Send a packet to port
         """
         for i in range(len(self.dut_ports[:portnum])):
+            txport = self.tester.get_local_port(self.dut_ports[i])
+            mac = self.dut.get_mac_address(self.dut_ports[i])
+            txItf = self.tester.get_interface(txport)
+            self.verify(self.tester.is_interface_up(intf=txItf), "Tester's %s should be up".format(txItf))
             for j in range(num):
-                txport = self.tester.get_local_port(self.dut_ports[i])
-                mac = self.dut.get_mac_address(self.dut_ports[i])
-                txItf = self.tester.get_interface(txport)
                 self.tester.scapy_append(
                     'sendp([Ether()/IP(dst="198.0.0.%d")/UDP()/Raw(\'X\'*18)], iface="%s")' % (j, txItf))
         self.tester.scapy_execute()