diff mbox series

[V2] framework/crb:add check link status public method

Message ID 20220113144417.26180-1-zhiminx.huang@intel.com (mailing list archive)
State Superseded
Headers
Series [V2] framework/crb:add check link status public method |

Commit Message

Huang, ZhiminX Jan. 13, 2022, 2:44 p.m. UTC 
  when we meet testpmd or app start but link is not up.
we can loop up the interface to ensure link.

v2:
- add support interface list

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 framework/crb.py | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

Comments

Tu, Lijuan Jan. 14, 2022, 6:27 a.m. UTC | #1 
> -----Original Message-----
> From: Zhimin Huang <zhiminx.huang@intel.com>
> Sent: 2022年1月13日 22:44
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V2] framework/crb:add check link status public method
> 
> when we meet testpmd or app start but link is not up.
> we can loop up the interface to ensure link.
> 	
> v2:
> - add support interface list
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/framework/crb.py b/framework/crb.py
index bd4f565d..72d0d2f5 100755
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -907,3 +907,33 @@  class Crb(object):
         else:
             self.logger.info("NIC %s may be not find %s" % (intf, flag))
             return False
+
+    def check_interfaces_link(self, intf: (list, str), timeout=15):
+        """
+        loop to check port link status
+        """
+        if isinstance(intf, list):
+            for interface in intf:
+                for i in range(timeout):
+                    out = self.send_expect("ethtool {} | tail -1 ".format(interface), "# ")
+                    if 'Link detected: yes' not in out:
+                        self.send_expect("ifconfig {} up".format(interface), "# ")
+                        time.sleep(1)
+                    else:
+                        break
+                else:
+                    self.logger.error("{} link is down".format(interface))
+            else:
+                return True
+        elif isinstance(intf, str):
+            for i in range(timeout):
+                out = self.send_expect("ethtool {} | tail -1 ".format(intf), "# ")
+                if 'Link detected: yes' not in out:
+                    self.send_expect("ifconfig {} up".format(intf), "# ")
+                    time.sleep(1)
+                else:
+                    return True
+            self.logger.error("{} link is down".format(intf))
+        else:
+            raise Exception("unsupported param type, only accept list or str")
+        return False