[V1] test/rxtx_offload:add RSS_HASH display

Message ID 20211112164959.107746-1-leweix.yang@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] test/rxtx_offload:add RSS_HASH display |

Checks

Context Check Description
ci/Intel-dts-suite-test fail Testing issues

Commit Message

Lewei Yang Nov. 12, 2021, 4:49 p.m. UTC
  According to dpdk commit 655eae01f993("app/testpmd: fix RSS hash offload display"),
RSS_HASH is displayed by default

Signed-off-by: Lewei Yang <leweix.yang@intel.com>
---
 tests/TestSuite_rxtx_offload.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
  

Comments

Yu Jiang Nov. 15, 2021, 9:55 a.m. UTC | #1
> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: Saturday, November 13, 2021 12:50 AM
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [dts][PATCH V1] test/rxtx_offload:add RSS_HASH display
> 
> According to dpdk commit 655eae01f993("app/testpmd: fix RSS hash offload
> display"), RSS_HASH is displayed by default
> 
> Signed-off-by: Lewei Yang <leweix.yang@intel.com>
> ---
Tested-by: Lewei Yang <leweix.yang@intel.com>

Test Result as below.
            "rxtx_callbacks/test_rxtx_callbacks": "passed",
            "rxtx_offload/test_rxoffload_port": "failed",
            "rxtx_offload/test_rxoffload_port_all": "passed",
            "rxtx_offload/test_rxoffload_port_cmdline": "passed",
            "rxtx_offload/test_rxoffload_queue": "n/a",
            "rxtx_offload/test_txoffload_port": "passed",
            "rxtx_offload/test_txoffload_port_all": "passed",
            "rxtx_offload/test_txoffload_port_checksum": "passed",
            "rxtx_offload/test_txoffload_port_cmdline": "passed",
            "rxtx_offload/test_txoffload_port_multi_segs": "passed",
            "rxtx_offload/test_txoffload_queue": "passed",
            "shutdown_api/test_check_rxtx_desc_status": "passed",

"rxtx_offload/test_rxoffload_port": "failed" due to dpdk commit b563c1421282("ethdev: remove jumbo offload flag"),
'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag has been removed, will remove jumboframe related tests, pls also help to merge it.
patch link: http://patchwork.dpdk.org/project/dts/patch/20211111160233.19355-1-leweix.yang@intel.com/
  
Tu, Lijuan Nov. 22, 2021, 2:20 p.m. UTC | #2
> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: 2021年11月13日 0:50
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [dts][PATCH V1] test/rxtx_offload:add RSS_HASH display
> 
> According to dpdk commit 655eae01f993("app/testpmd: fix RSS hash offload
> display"), RSS_HASH is displayed by default
> 
> Signed-off-by: Lewei Yang <leweix.yang@intel.com>

Applied, thanks
  

Patch

diff --git a/tests/TestSuite_rxtx_offload.py b/tests/TestSuite_rxtx_offload.py
index 14fd40ac..59d3b821 100644
--- a/tests/TestSuite_rxtx_offload.py
+++ b/tests/TestSuite_rxtx_offload.py
@@ -165,7 +165,10 @@  class TestRxTx_Offload(TestCase):
         scanner = re.compile(result_scanner, re.DOTALL)
         m = scanner.search(outstring)
         if offload == "NULL":
-            self.verify(m == None, "The offload failed to be disabled.")
+            if rxtx == "rx":
+                self.verify(m.group(1).strip() == 'RSS_HASH', "The offload failed to be disabled.")
+            elif rxtx == "tx":
+                self.verify(m == None, "The offload failed to be disabled.")
         else:
             exp_offload = m.group(1).split()
             self.verify(exp_offload != None, "There is no offload configured.")