| Message ID | 20211101152338.22226-1-leweix.yang@intel.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [V1] tests/userspace_ethtool:rename ETH to RTE_ETH | expand |
| Context | Check | Description |
|---|---|---|
| ci/Intel-dts-suite-test | fail | Apply issues |
| ci/Intel-dts-doc-test | success | Testing OK |
> -----Original Message----- > From: dts <dts-bounces@dpdk.org> On Behalf Of Lewei Yang > Sent: 2021年11月1日 23:24 > To: dts@dpdk.org > Cc: Yang, LeweiX <leweix.yang@intel.com> > Subject: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to RTE_ETH > > From: YangLewei <leweix.yang@intel.com> > > According to dpdk commit 295968d17407("ethdev: add namespace"), rename > ETH to RTE_ETH > > Signed-off-by: YangLewei <leweix.yang@intel.com> > --- > test_plans/userspace_ethtool_test_plan.rst | 2 +- > tests/TestSuite_userspace_ethtool.py | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/test_plans/userspace_ethtool_test_plan.rst > b/test_plans/userspace_ethtool_test_plan.rst > index ca86beaf..9dca4b49 100644 > --- a/test_plans/userspace_ethtool_test_plan.rst > +++ b/test_plans/userspace_ethtool_test_plan.rst > @@ -164,7 +164,7 @@ Test Case: Vlan test > > enable vlan filter flag in main.c of dpdk's ethtool:: > > - sed -i -e '/cfg_port.txmode.mq_mode = > ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN > _FILTER;' examples/ethtool/ethtool-app/main.c > + sed -i -e '/cfg_port.txmode.mq_mode = > + > RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_ > VLAN_ > + FILTER;' examples/ethtool/ethtool-app/main.c > > re-compile examples/ethtool:: > > diff --git a/tests/TestSuite_userspace_ethtool.py > b/tests/TestSuite_userspace_ethtool.py > index 4536b7d1..8fae4f2c 100644 > --- a/tests/TestSuite_userspace_ethtool.py > +++ b/tests/TestSuite_userspace_ethtool.py > @@ -449,7 +449,7 @@ class TestUserspaceEthtool(TestCase): > """ > main_file = "examples/ethtool/ethtool-app/main.c" > # enable vlan filter > - self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = > ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN > _FILTER;' %s" % main_file, "# ") > + self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = > + > RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_ > VLAN_ > + FILTER;' %s" % main_file, "# ") Can we test the point and don't modify DPDK. > > # build sample app > self.build_ethtool() > -- > 2.33.1
> -----Original Message----- > From: Tu, Lijuan <lijuan.tu@intel.com> > Sent: Monday, November 22, 2021 11:27 PM > To: Yang, LeweiX <leweix.yang@intel.com>; dts@dpdk.org > Cc: Yang, LeweiX <leweix.yang@intel.com> > Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to > RTE_ETH > > > > > -----Original Message----- > > From: dts <dts-bounces@dpdk.org> On Behalf Of Lewei Yang > > Sent: 2021年11月1日 23:24 > > To: dts@dpdk.org > > Cc: Yang, LeweiX <leweix.yang@intel.com> > > Subject: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to > > RTE_ETH > > > > From: YangLewei <leweix.yang@intel.com> > > > > According to dpdk commit 295968d17407("ethdev: add namespace"), > rename > > ETH to RTE_ETH > > > > Signed-off-by: YangLewei <leweix.yang@intel.com> > > --- > > test_plans/userspace_ethtool_test_plan.rst | 2 +- > > tests/TestSuite_userspace_ethtool.py | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/test_plans/userspace_ethtool_test_plan.rst > > b/test_plans/userspace_ethtool_test_plan.rst > > index ca86beaf..9dca4b49 100644 > > --- a/test_plans/userspace_ethtool_test_plan.rst > > +++ b/test_plans/userspace_ethtool_test_plan.rst > > @@ -164,7 +164,7 @@ Test Case: Vlan test > > > > enable vlan filter flag in main.c of dpdk's ethtool:: > > > > - sed -i -e '/cfg_port.txmode.mq_mode = > > > ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VL > AN > > _FILTER;' examples/ethtool/ethtool-app/main.c > > + sed -i -e '/cfg_port.txmode.mq_mode = > > + > > > RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOA > D_ > > VLAN_ > > + FILTER;' examples/ethtool/ethtool-app/main.c > > > > re-compile examples/ethtool:: > > > > diff --git a/tests/TestSuite_userspace_ethtool.py > > b/tests/TestSuite_userspace_ethtool.py > > index 4536b7d1..8fae4f2c 100644 > > --- a/tests/TestSuite_userspace_ethtool.py > > +++ b/tests/TestSuite_userspace_ethtool.py > > @@ -449,7 +449,7 @@ class TestUserspaceEthtool(TestCase): > > """ > > main_file = "examples/ethtool/ethtool-app/main.c" > > # enable vlan filter > > - self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = > > > ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VL > AN > > _FILTER;' %s" % main_file, "# ") > > + self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = > > + > > > RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOA > D_ > > VLAN_ > > + FILTER;' %s" % main_file, "# ") > > Can we test the point and don't modify DPDK. > If we do not modify DPDK code, it tests failed. More details see the attached. Port 0: VLAN-filtering disabled Port 0: VLAN filtering disabled Test Case test_ethtool_vlan Result FAILED: 'Failed to filter Rx vlan packet' > > > > # build sample app > > self.build_ethtool() > > -- > > 2.33.1
> -----Original Message----- > From: Jiang, YuX <yux.jiang@intel.com> > Sent: 2021年11月23日 14:30 > To: Tu, Lijuan <lijuan.tu@intel.com>; Yang, LeweiX <leweix.yang@intel.com>; > dts@dpdk.org > Cc: Yang, LeweiX <leweix.yang@intel.com>; Lin, Xueqin <xueqin.lin@intel.com> > Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to RTE_ETH > > > -----Original Message----- > > From: Tu, Lijuan <lijuan.tu@intel.com> > > Sent: Monday, November 22, 2021 11:27 PM > > To: Yang, LeweiX <leweix.yang@intel.com>; dts@dpdk.org > > Cc: Yang, LeweiX <leweix.yang@intel.com> > > Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to > > RTE_ETH > > > > > > > > > -----Original Message----- > > > From: dts <dts-bounces@dpdk.org> On Behalf Of Lewei Yang > > > Sent: 2021年11月1日 23:24 > > > To: dts@dpdk.org > > > Cc: Yang, LeweiX <leweix.yang@intel.com> > > > Subject: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to > > > RTE_ETH > > > > > > From: YangLewei <leweix.yang@intel.com> > > > > > > According to dpdk commit 295968d17407("ethdev: add namespace"), > > rename > > > ETH to RTE_ETH > > > > > > Signed-off-by: YangLewei <leweix.yang@intel.com> > > > --- > > > test_plans/userspace_ethtool_test_plan.rst | 2 +- > > > tests/TestSuite_userspace_ethtool.py | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/test_plans/userspace_ethtool_test_plan.rst > > > b/test_plans/userspace_ethtool_test_plan.rst > > > index ca86beaf..9dca4b49 100644 > > > --- a/test_plans/userspace_ethtool_test_plan.rst > > > +++ b/test_plans/userspace_ethtool_test_plan.rst > > > @@ -164,7 +164,7 @@ Test Case: Vlan test > > > > > > enable vlan filter flag in main.c of dpdk's ethtool:: > > > > > > - sed -i -e '/cfg_port.txmode.mq_mode = > > > > > ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VL > > AN > > > _FILTER;' examples/ethtool/ethtool-app/main.c > > > + sed -i -e '/cfg_port.txmode.mq_mode = > > > + > > > > > RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOA > > D_ > > > VLAN_ > > > + FILTER;' examples/ethtool/ethtool-app/main.c > > > > > > re-compile examples/ethtool:: > > > > > > diff --git a/tests/TestSuite_userspace_ethtool.py > > > b/tests/TestSuite_userspace_ethtool.py > > > index 4536b7d1..8fae4f2c 100644 > > > --- a/tests/TestSuite_userspace_ethtool.py > > > +++ b/tests/TestSuite_userspace_ethtool.py > > > @@ -449,7 +449,7 @@ class TestUserspaceEthtool(TestCase): > > > """ > > > main_file = "examples/ethtool/ethtool-app/main.c" > > > # enable vlan filter > > > - self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = > > > > > ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VL > > AN > > > _FILTER;' %s" % main_file, "# ") > > > + self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = > > > + > > > > > RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOA > > D_ > > > VLAN_ > > > + FILTER;' %s" % main_file, "# ") > > > > Can we test the point and don't modify DPDK. > > > If we do not modify DPDK code, it tests failed. More details see the attached. > Port 0: VLAN-filtering disabled > Port 0: VLAN filtering disabled > Test Case test_ethtool_vlan Result FAILED: 'Failed to filter Rx vlan packet' If vlan do need be tested, request DPDK to add the code is more reasonable. > > > > > > > # build sample app > > > self.build_ethtool() > > > -- > > > 2.33.1 >
diff --git a/test_plans/userspace_ethtool_test_plan.rst b/test_plans/userspace_ethtool_test_plan.rst index ca86beaf..9dca4b49 100644 --- a/test_plans/userspace_ethtool_test_plan.rst +++ b/test_plans/userspace_ethtool_test_plan.rst @@ -164,7 +164,7 @@ Test Case: Vlan test enable vlan filter flag in main.c of dpdk's ethtool:: - sed -i -e '/cfg_port.txmode.mq_mode = ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER;' examples/ethtool/ethtool-app/main.c + sed -i -e '/cfg_port.txmode.mq_mode = RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER;' examples/ethtool/ethtool-app/main.c re-compile examples/ethtool:: diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py index 4536b7d1..8fae4f2c 100644 --- a/tests/TestSuite_userspace_ethtool.py +++ b/tests/TestSuite_userspace_ethtool.py @@ -449,7 +449,7 @@ class TestUserspaceEthtool(TestCase): """ main_file = "examples/ethtool/ethtool-app/main.c" # enable vlan filter - self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER;' %s" % main_file, "# ") + self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER;' %s" % main_file, "# ") # build sample app self.build_ethtool()