[V2,2/2] tests/vf_daemon: delete test_mac_antispoof

Message ID 20211026132801.74272-3-yanx.xia@intel.com (mailing list archive)
State Accepted
Headers
Series *** delete test_mac_antispoof *** |

Checks

Context Check Description
ci/Intel-dts-doc-test fail Testing issues

Commit Message

Yan Xia Oct. 26, 2021, 1:28 p.m. UTC
  comfirm with Tu,Lijuan and Lin,Xueqin, delete the case

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 tests/TestSuite_vf_daemon.py | 53 ------------------------------------
 1 file changed, 53 deletions(-)
  

Comments

Lin, Xueqin Oct. 26, 2021, 6:48 a.m. UTC | #1
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Yan Xia
> Sent: Tuesday, October 26, 2021 9:28 PM
> To: dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: [dts] [PATCH V2 2/2] tests/vf_daemon: delete test_mac_antispoof
> 
> comfirm with Tu,Lijuan and Lin,Xueqin, delete the case
> 
> Signed-off-by: Yan Xia <yanx.xia@intel.com>
Acked-by: Xueqin Lin <Xueqin.lin@intel.com>
> ---
>  tests/TestSuite_vf_daemon.py | 53 ------------------------------------
>  1 file changed, 53 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
> index 4d6ae58f..62996ade 100644
> --- a/tests/TestSuite_vf_daemon.py
> +++ b/tests/TestSuite_vf_daemon.py
> @@ -517,59 +517,6 @@ class TestVfDaemon(TestCase):
>          out = self.vm0_testpmd.execute_cmd('show port stats 0')
>          self.verify("RX-packets: 40" in out,
>              "Failed to enable all queues drop!!!")
> -
> -
> -    def test_mac_antispoof(self):
> -        """
> -        Enable/disable mac anti-spoof for a VF from PF
> -        """
> -        fake_mac = '00:11:22:33:44:55'
> -        time.sleep(5)
> -        self.vm0_dut.send_expect("sed -i -e '/int r;/a " +\
> -            "\        struct rte_ether_addr fake_mac = {.addr_bytes = {0x00, 0x11,
> 0x22, 0x33, 0x44, 0x55},};'" +\
> -            " app/test-pmd/macswap_sse.h", "# ", 30)
> -        line_num = self.vm0_dut.send_expect("sed -n '/_mm_storeu_si128/='
> app/test-pmd/macswap_sse.h |sed -n 5p", "# ",30)
> -        self.vm0_dut.send_expect("sed -i -e
> '%sa\\rte_ether_addr_copy(&fake_mac, &eth_hdr[0]->s_addr);'" %
> str(line_num)+\
> -                    " app/test-pmd/macswap_sse.h", "# ", 30)
> -        time.sleep(3)
> -
> -        self.vm0_dut.build_install_dpdk(self.target)
> -        time.sleep(5)
> -
> -        self.check_vf_link_status()
> -        self.vf0_mac = self.vm0_testpmd.get_port_mac(0)
> -
> -        self.vm0_testpmd.execute_cmd('set fwd macswap')
> -        self.dut_testpmd.execute_cmd('set vf mac antispoof 0 0 off')
> -        self.vm0_testpmd.execute_cmd('start')
> -        time.sleep(5)
> -
> -        dumpout = self.send_and_macstrip(self.vf0_mac)
> -        out = self.vm0_testpmd.execute_cmd('stop')
> -
> -        self.verify(fake_mac in dumpout,
> -            "Failed to disable vf mac anspoof!!!")
> -        self.verify("RX-packets: 1" in out, "Failed to receive packet!!!")
> -        self.verify("TX-packets: 1" in out,
> -            "Failed to disable mac antispoof!!!")
> -
> -        self.dut_testpmd.execute_cmd('set vf mac antispoof 0 0 on')
> -        self.vm0_testpmd.execute_cmd('start')
> -        time.sleep(3)
> -        dumpout = self.send_and_macstrip(self.vf0_mac)
> -        out = self.vm0_testpmd.execute_cmd('stop')
> -        self.verify(fake_mac not in dumpout, "Failed to enable vf mac anspoof!!!")
> -        self.verify("RX-packets: 1" in out, "Failed to receive packet!!!")
> -        self.verify("TX-packets: 0" in out, "Failed to enable mac antispoof!!!")
> -
> -        self.vm0_testpmd.quit()
> -        self.dut_testpmd.quit()
> -        self.vm0_dut.send_expect("sed -i '/struct rte_ether_addr fake_mac =
> {.addr_bytes = " +\
> -            "{0x00, 0x11, 0x22, 0x33, 0x44, 0x55},};/d' app/test-
> pmd/macswap_sse.h", "# ", 30)
> -        self.vm0_dut.send_expect("sed -i '%sd'" % line_num +\
> -            " app/test-pmd/macswap_sse.h", "# ", 30)
> -        self.vm0_dut.build_install_dpdk(self.target)
> -
> 
>      def test_vf_mac_set(self):
>          """
> --
> 2.33.1
  
Tu, Lijuan Oct. 26, 2021, 7:51 a.m. UTC | #2
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Lin, Xueqin
> Sent: 2021年10月26日 14:49
> To: Xia, YanX <yanx.xia@intel.com>; dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: Re: [dts] [PATCH V2 2/2] tests/vf_daemon: delete test_mac_antispoof
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Yan Xia
> > Sent: Tuesday, October 26, 2021 9:28 PM
> > To: dts@dpdk.org
> > Cc: Xia, YanX <yanx.xia@intel.com>
> > Subject: [dts] [PATCH V2 2/2] tests/vf_daemon: delete
> > test_mac_antispoof
> >
> > comfirm with Tu,Lijuan and Lin,Xueqin, delete the case
> >
> > Signed-off-by: Yan Xia <yanx.xia@intel.com>
> Acked-by: Xueqin Lin <Xueqin.lin@intel.com>

Applied
  

Patch

diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
index 4d6ae58f..62996ade 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -517,59 +517,6 @@  class TestVfDaemon(TestCase):
         out = self.vm0_testpmd.execute_cmd('show port stats 0')
         self.verify("RX-packets: 40" in out, 
             "Failed to enable all queues drop!!!")
-    
-
-    def test_mac_antispoof(self):
-        """
-        Enable/disable mac anti-spoof for a VF from PF
-        """
-        fake_mac = '00:11:22:33:44:55'
-        time.sleep(5)
-        self.vm0_dut.send_expect("sed -i -e '/int r;/a " +\
-            "\        struct rte_ether_addr fake_mac = {.addr_bytes = {0x00, 0x11, 0x22, 0x33, 0x44, 0x55},};'" +\
-            " app/test-pmd/macswap_sse.h", "# ", 30)
-        line_num = self.vm0_dut.send_expect("sed -n '/_mm_storeu_si128/=' app/test-pmd/macswap_sse.h |sed -n 5p", "# ",30)
-        self.vm0_dut.send_expect("sed -i -e '%sa\\rte_ether_addr_copy(&fake_mac, &eth_hdr[0]->s_addr);'" % str(line_num)+\
-                    " app/test-pmd/macswap_sse.h", "# ", 30)
-        time.sleep(3)
-
-        self.vm0_dut.build_install_dpdk(self.target) 
-        time.sleep(5)
-
-        self.check_vf_link_status()
-        self.vf0_mac = self.vm0_testpmd.get_port_mac(0)
-
-        self.vm0_testpmd.execute_cmd('set fwd macswap')
-        self.dut_testpmd.execute_cmd('set vf mac antispoof 0 0 off')
-        self.vm0_testpmd.execute_cmd('start')
-        time.sleep(5)
-
-        dumpout = self.send_and_macstrip(self.vf0_mac)
-        out = self.vm0_testpmd.execute_cmd('stop')
-
-        self.verify(fake_mac in dumpout, 
-            "Failed to disable vf mac anspoof!!!")
-        self.verify("RX-packets: 1" in out, "Failed to receive packet!!!")
-        self.verify("TX-packets: 1" in out, 
-            "Failed to disable mac antispoof!!!")
-
-        self.dut_testpmd.execute_cmd('set vf mac antispoof 0 0 on')
-        self.vm0_testpmd.execute_cmd('start')
-        time.sleep(3)
-        dumpout = self.send_and_macstrip(self.vf0_mac)
-        out = self.vm0_testpmd.execute_cmd('stop')
-        self.verify(fake_mac not in dumpout, "Failed to enable vf mac anspoof!!!")
-        self.verify("RX-packets: 1" in out, "Failed to receive packet!!!")
-        self.verify("TX-packets: 0" in out, "Failed to enable mac antispoof!!!")
-
-        self.vm0_testpmd.quit()
-        self.dut_testpmd.quit()
-        self.vm0_dut.send_expect("sed -i '/struct rte_ether_addr fake_mac = {.addr_bytes = " +\
-            "{0x00, 0x11, 0x22, 0x33, 0x44, 0x55},};/d' app/test-pmd/macswap_sse.h", "# ", 30)
-        self.vm0_dut.send_expect("sed -i '%sd'" % line_num +\
-            " app/test-pmd/macswap_sse.h", "# ", 30)
-        self.vm0_dut.build_install_dpdk(self.target)
-
 
     def test_vf_mac_set(self):
         """