diff mbox series

[V2] test_plans/cvl_dcf_switch_filter: modify the mask value in testplan

Message ID 20210806020119.83529-1-yuan.peng@intel.com (mailing list archive)
State Accepted
Headers
Series [V2] test_plans/cvl_dcf_switch_filter: modify the mask value in testplan |

Checks

Context Check Description
ci/Intel-dts-test success Testing OK

Commit Message

Peng, Yuan Aug. 6, 2021, 2:01 a.m. UTC 
  the ipv4 pattern, when the action is drop, and the mask is not
255.255.255.255, the rule created is as a acl rule. only the acl rule
table is full, the rule is created as switch rule.
when the mask is 255.255.255.255, the rule is created as switch rule.
so modify all the mask to 255.255.255.255 when the action is drop.

Signed-off-by: Peng Yuan <yuan.peng@intel.com>

Comments

Tu, Lijuan Aug. 10, 2021, 5:43 a.m. UTC | #1 
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Peng Yuan
> Sent: 2021年8月6日 10:01
> To: dts@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>
> Subject: [dts] [PATCH V2]test_plans/cvl_dcf_switch_filter: modify the mask
> value in testplan
> 
> the ipv4 pattern, when the action is drop, and the mask is not 255.255.255.255,
> the rule created is as a acl rule. only the acl rule table is full, the rule is created
> as switch rule.
> when the mask is 255.255.255.255, the rule is created as switch rule.
> so modify all the mask to 255.255.255.255 when the action is drop.
> 
> Signed-off-by: Peng Yuan <yuan.peng@intel.com>


Test plans and test suites with coupled changes should be put in the same series.

So could you please re-submit your patches in the same series:

http://patchwork.dpdk.org/project/dts/patch/20210806020119.83529-1-yuan.peng@intel.com/
http://patchwork.dpdk.org/project/dts/patch/20210809153803.7686-1-zhiminx.huang@intel.com/

Furthermore, please Superseded your old version if you getting a newer one.
Tu, Lijuan Aug. 27, 2021, 8:35 a.m. UTC | #2 
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Peng Yuan
> Sent: 2021年8月6日 10:01
> To: dts@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>
> Subject: [dts] [PATCH V2]test_plans/cvl_dcf_switch_filter: modify the mask
> value in testplan
> 
> the ipv4 pattern, when the action is drop, and the mask is not 255.255.255.255,
> the rule created is as a acl rule. only the acl rule table is full, the rule is created
> as switch rule.
> when the mask is 255.255.255.255, the rule is created as switch rule.
> so modify all the mask to 255.255.255.255 when the action is drop.
> 
> Signed-off-by: Peng Yuan <yuan.peng@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/test_plans/cvl_dcf_switch_filter_test_plan.rst b/test_plans/cvl_dcf_switch_filter_test_plan.rst
index 65b2ccfa..116b2cca 100644
--- a/test_plans/cvl_dcf_switch_filter_test_plan.rst
+++ b/test_plans/cvl_dcf_switch_filter_test_plan.rst
@@ -3236,7 +3236,7 @@  Subcase 2: DCF DROP IPV4 SRC SPEC MASK PACKAGES
 
 1. validate a rule::
 
-     testpmd> flow validate 0 ingress pattern eth / ipv4 dst spec 224.0.0.0 dst mask 240.0.0.0 / end actions drop / end
+     testpmd> flow validate 0 ingress pattern eth / ipv4 dst spec 224.0.0.0 dst mask 255.255.255.255 / end actions drop / end
 
    get the message::
 
@@ -3250,14 +3250,14 @@  Subcase 2: DCF DROP IPV4 SRC SPEC MASK PACKAGES
 
 2. create MAC_IPV4_SRC_SPEC_PAY rule::
 
-     testpmd> flow create 0 ingress pattern eth / ipv4 dst spec 224.0.0.0 dst mask 240.0.0.0 / end actions drop / end
+     testpmd> flow create 0 ingress pattern eth / ipv4 dst spec 224.0.0.0 dst mask 255.255.255.255 / end actions drop / end
      testpmd> flow list 0
 
    check the rule exists in the list.
 
 3. send matched packets::
 
-     sendp([Ether(dst="00:11:22:33:44:55")/IP(dst="239.0.0.0")/TCP()/Raw("x"*80)],iface="enp27s0f0")
+     sendp([Ether(dst="00:11:22:33:44:55")/IP(dst="224.0.0.0")/TCP()/Raw("x"*80)],iface="enp27s0f0")
 
    check port can't receive the packet.
 
@@ -3545,7 +3545,7 @@  Subcase 8:  DCF DROP blend PACKAGES
 1. validate a rule::
 
      testpmd> flow validate 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.1 / end actions drop / end
-     testpmd> flow validate 0 ingress pattern eth / ipv4 dst spec 224.0.0.0 dst mask 240.0.0.0 / end actions drop / end
+     testpmd> flow validate 0 ingress pattern eth / ipv4 dst spec 224.0.0.0 dst mask 255.255.255.255 / end actions drop / end
      testpmd> flow validate 0 ingress pattern eth / ipv4 dst is 192.168.0.1 / nvgre tni is 2 / eth / ipv4 src is 192.168.1.2 dst is 192.168.1.3 / end actions drop / end
      testpmd> flow validate 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 1 / pppoes seid is 3 / pppoe_proto_id is 0x0021 / end actions drop / end
      testpmd> flow validate 0 ingress pattern eth / ipv4 / udp / pfcp s_field is 0 / end actions drop / end
@@ -3566,7 +3566,7 @@  Subcase 8:  DCF DROP blend PACKAGES
 2. create rule::
 
      testpmd> flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.1 / end actions drop / end
-     testpmd> flow create 0 ingress pattern eth / ipv4 dst spec 224.0.0.0 dst mask 240.0.0.0 / end actions drop / end
+     testpmd> flow create 0 ingress pattern eth / ipv4 dst spec 224.0.0.0 dst mask 255.255.255.255 / end actions drop / end
      testpmd> flow create 0 ingress pattern eth / ipv4 dst is 192.168.0.1 / nvgre tni is 2 / eth / ipv4 src is 192.168.1.2 dst is 192.168.1.3 / end actions drop / end
      testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 1 / pppoes seid is 3 / pppoe_proto_id is 0x0021 / end actions drop / end
      testpmd> flow create 0 ingress pattern eth / ipv4 / udp / pfcp s_field is 0 / end actions drop / end
@@ -3579,7 +3579,7 @@  Subcase 8:  DCF DROP blend PACKAGES
 3. send matched packets::
 
      sendp([Ether()/IP(src="192.168.0.1")/Raw("x"*80)],iface="enp27s0f0")
-     sendp([Ether(dst="00:11:22:33:44:55")/IP(dst="239.0.0.0")/TCP()/Raw("x"*80)],iface="enp27s0f0")
+     sendp([Ether(dst="00:11:22:33:44:55")/IP(dst="224.0.0.0")/TCP()/Raw("x"*80)],iface="enp27s0f0")
      sendp([Ether()/IP(dst="192.168.0.3")/NVGRE(TNI=2)/Ether()/IP(src="192.168.1.2", dst="192.168.1.3")/Raw("x"*80)],iface="enp27s0f0")
      sendp([Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=1,type=0x8864)/PPPoE(sessionid=3)/PPP(b'\\x00\\x21')/IP()/Raw("x" * 80)],iface="enp27s0f0")
      sendp(Ether(dst="00:11:22:33:44:11")/IP()/UDP(dport=8805)/PFCP(S=0),iface="enp27s0f0")