[2/2] test_plans/rxtx_offload_test_plan: adapt to CVL NIC

Message ID 20210324112443.29319-3-weix.xie@intel.com (mailing list archive)
State Changes Requested
Headers
Series adapt to CVL NIC |

Commit Message

Xie, WeiX March 24, 2021, 11:24 a.m. UTC
  add CVL NIC supported.

Signed-off-by: xiewei <weix.xie@intel.com>
---
 test_plans/rxtx_offload_test_plan.rst | 29 +++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
  

Comments

Tu, Lijuan March 25, 2021, 7:20 a.m. UTC | #1
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of xiewei
> Sent: 2021年3月24日 19:25
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH 2/2] test_plans/rxtx_offload_test_plan: adapt to CVL NIC
> 
> add CVL NIC supported.
> 
> Signed-off-by: xiewei <weix.xie@intel.com>
> ---
>  test_plans/rxtx_offload_test_plan.rst | 29 +++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/test_plans/rxtx_offload_test_plan.rst
> b/test_plans/rxtx_offload_test_plan.rst
> index 246e1e16..8b034d67 100644
> --- a/test_plans/rxtx_offload_test_plan.rst
> +++ b/test_plans/rxtx_offload_test_plan.rst
> @@ -146,6 +146,21 @@ Test case: Rx offload per-port setting
>     The port can be started normally, but the setting doesn't take effect.
>     Pkt1 still can be distributed to queue 1.
> 
> +Note:
> +
> +But for ice NIC, disable jumboframe per-queue will change the RSS key.
> +So if set jumboframe per-queue, the hash value of received packet will be
> changed, and we can’t judge the test result by queue number.
> +So we disable jumboframe per-queue in all the queues, and if the packet still
> can be received in any queue, the setting doesn't take effect::
> +
> +    testpmd> port stop 0
> +    testpmd> port 0 rxq 0 rx_offload jumbo_frame off
> +    testpmd> port 0 rxq 1 rx_offload jumbo_frame off
> +    testpmd> port 0 rxq 2 rx_offload jumbo_frame off
> +    testpmd> port 0 rxq 3 rx_offload jumbo_frame off
> +    testpmd> port start 0
> +
> +   Pkt1 can be distributed to queues by RSS.
> +

How about use a fixed RSS key., it will keep cases consistency in different cards.

>  4. Succeed to disable jumboframe per_port::
> 
>      testpmd> port stop 0
> @@ -643,6 +658,20 @@ Test case: FVL Tx offload per-queue setting
> 
>     The port fwd can be started normally.
> 
> +Note:
> +
> +But for ice NIC, it failed to enable mbuf_fast_free per_queue::
> +
> +    testpmd> port stop 0
> +    testpmd> port 0 txq 0 tx_offload mbuf_fast_free on
> +    testpmd> port 0 txq 1 tx_offload mbuf_fast_free on
> +    testpmd> port 0 txq 2 tx_offload mbuf_fast_free on
> +    testpmd> port 0 txq 3 tx_offload mbuf_fast_free on
> +    testpmd> port start 0
> +    Configuring Port 0 (socket 0)
> +    Ethdev port_id=0 tx_queue_id=0, new added offloads 0x10000 must be
> within per-queue offload capabilities 0x0 in rte_eth_tx_queue_setup()
> +    Fail to configure port 0 tx queues
> +
>  4. Disable mbuf_fast_free per_queue::
> 
>      testpmd> port stop 0
> --
> 2.17.1
  

Patch

diff --git a/test_plans/rxtx_offload_test_plan.rst b/test_plans/rxtx_offload_test_plan.rst
index 246e1e16..8b034d67 100644
--- a/test_plans/rxtx_offload_test_plan.rst
+++ b/test_plans/rxtx_offload_test_plan.rst
@@ -146,6 +146,21 @@  Test case: Rx offload per-port setting
    The port can be started normally, but the setting doesn't take effect.
    Pkt1 still can be distributed to queue 1.
 
+Note:
+
+But for ice NIC, disable jumboframe per-queue will change the RSS key.
+So if set jumboframe per-queue, the hash value of received packet will be changed, and we can’t judge the test result by queue number.
+So we disable jumboframe per-queue in all the queues, and if the packet still can be received in any queue, the setting doesn't take effect::
+
+    testpmd> port stop 0
+    testpmd> port 0 rxq 0 rx_offload jumbo_frame off
+    testpmd> port 0 rxq 1 rx_offload jumbo_frame off
+    testpmd> port 0 rxq 2 rx_offload jumbo_frame off
+    testpmd> port 0 rxq 3 rx_offload jumbo_frame off
+    testpmd> port start 0
+
+   Pkt1 can be distributed to queues by RSS.
+
 4. Succeed to disable jumboframe per_port::
 
     testpmd> port stop 0
@@ -643,6 +658,20 @@  Test case: FVL Tx offload per-queue setting
 
    The port fwd can be started normally.
 
+Note:
+
+But for ice NIC, it failed to enable mbuf_fast_free per_queue::
+
+    testpmd> port stop 0
+    testpmd> port 0 txq 0 tx_offload mbuf_fast_free on
+    testpmd> port 0 txq 1 tx_offload mbuf_fast_free on
+    testpmd> port 0 txq 2 tx_offload mbuf_fast_free on
+    testpmd> port 0 txq 3 tx_offload mbuf_fast_free on
+    testpmd> port start 0
+    Configuring Port 0 (socket 0)
+    Ethdev port_id=0 tx_queue_id=0, new added offloads 0x10000 must be within per-queue offload capabilities 0x0 in rte_eth_tx_queue_setup()
+    Fail to configure port 0 tx queues
+
 4. Disable mbuf_fast_free per_queue::
 
     testpmd> port stop 0