diff mbox series

[V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf

Message ID 20210323151121.11036-1-qinx.sun@intel.com (mailing list archive)
State Changes Requested
Headers show
Series [V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf | expand

Commit Message

Sun, QinX March 23, 2021, 3:11 p.m. UTC
Confirm with developer that the design of dpdk is changed for VF,

the VLAN ID needs to be set before VF receives VLAN packets.

Signed-off-by: sunqin <qinx.sun@intel.com>
---
 tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py | 5 +++++
 1 file changed, 5 insertions(+)
 mode change 100755 => 100644 tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py

Comments

Sun, QinX March 25, 2021, 3:25 a.m. UTC | #1
> -----Original Message-----
> From: Sun, QinX <qinx.sun@intel.com>
> Sent: Tuesday, March 23, 2021 11:11 PM
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf

Tested-by: Sun Qin <qinx.sun@intel.com>
Tu, Lijuan March 25, 2021, 6:28 a.m. UTC | #2
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of sunqin
> Sent: 2021年3月23日 23:11
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
> 
> Confirm with developer that the design of dpdk is changed for VF,
> 
> the VLAN ID needs to be set before VF receives VLAN packets.
> 
> Signed-off-by: sunqin <qinx.sun@intel.com>
> ---
>  tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py | 5 +++++
>  1 file changed, 5 insertions(+)
>  mode change 100755 => 100644
> tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> 
> diff --git a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> old mode 100755
> new mode 100644
> index 6490dcbf..cadea5d8
> --- a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> +++ b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> @@ -7886,6 +7886,11 @@ class TestCVLAdvancedIAVFRSSGTPU(TestCase):
>              self.pmd_output.quit()
>              self.launch_testpmd(symmetric=symmetric)
>              self.pmd_output.execute_cmd("start")
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 3 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 5 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 7 0')

A little confused, you add this in a common function, and this function will be called by most of cases, not only related to vlan, furthermore, the function will be added multiple time in runtime.
> 
>      def test_mac_ipv4_gtpu_ipv4(self):
>          self.switch_testpmd(symmetric=False)
> --
> 2.17.1
diff mbox series

Patch

diff --git a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
old mode 100755
new mode 100644
index 6490dcbf..cadea5d8
--- a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
+++ b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
@@ -7886,6 +7886,11 @@  class TestCVLAdvancedIAVFRSSGTPU(TestCase):
             self.pmd_output.quit()
             self.launch_testpmd(symmetric=symmetric)
             self.pmd_output.execute_cmd("start")
+        self.pmd_output.execute_cmd('vlan set filter on 0')
+        self.pmd_output.execute_cmd('rx_vlan add 1 0')
+        self.pmd_output.execute_cmd('rx_vlan add 3 0')
+        self.pmd_output.execute_cmd('rx_vlan add 5 0')
+        self.pmd_output.execute_cmd('rx_vlan add 7 0')
 
     def test_mac_ipv4_gtpu_ipv4(self):
         self.switch_testpmd(symmetric=False)