[V1] tests/unit_tests_loopback:rm exists file before cp

Message ID 20201218113632.367094-1-weix.ling@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/unit_tests_loopback:rm exists file before cp |

Commit Message

Ling, WeiX Dec. 18, 2020, 11:36 a.m. UTC
  rm exists file before cp

Signed-off-by: Ling Wei <weix.ling@intel.com>
---
 tests/TestSuite_unit_tests_loopback.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Ling, WeiX Dec. 18, 2020, 3:42 a.m. UTC | #1
Tested-by: Wei Ling <weix.ling@intel.com>

Regards,
Ling Wei

> -----Original Message-----
> From: Ling Wei <weix.ling@intel.com>
> Sent: Friday, December 18, 2020 07:37 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V1] tests/unit_tests_loopback:rm exists file before cp
  
Zhao, HaiyangX Dec. 18, 2020, 5:15 a.m. UTC | #2
Acked-by: Haiyang Zhao <haiyangx.zhao@intel.com>

Best Regards,
Zhao Haiyang

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Ling, WeiX
> Sent: Friday, December 18, 2020 11:42
> To: Ling, WeiX <weix.ling@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] tests/unit_tests_loopback:rm exists file before
> cp
> 
> Tested-by: Wei Ling <weix.ling@intel.com>
> 
> Regards,
> Ling Wei
> 
> > -----Original Message-----
> > From: Ling Wei <weix.ling@intel.com>
> > Sent: Friday, December 18, 2020 07:37 PM
> > To: dts@dpdk.org
> > Cc: Ling, WeiX <weix.ling@intel.com>
> > Subject: [dts][PATCH V1] tests/unit_tests_loopback:rm exists file before cp
  
Tu, Lijuan Dec. 21, 2020, 7:55 a.m. UTC | #3
> rm exists file before cp
> 
> Signed-off-by: Ling Wei <weix.ling@intel.com>

Applied with commit message changed
  

Patch

diff --git a/tests/TestSuite_unit_tests_loopback.py b/tests/TestSuite_unit_tests_loopback.py
index 6babc2a1..0198a913 100644
--- a/tests/TestSuite_unit_tests_loopback.py
+++ b/tests/TestSuite_unit_tests_loopback.py
@@ -71,6 +71,7 @@  class TestUnitTestsLoopback(TestCase):
         self.max_traffic_burst = self.get_max_traffic_burst()
         self.dut.send_expect("sed -i -e 's/#define MAX_TRAFFIC_BURST              %s/#define MAX_TRAFFIC_BURST              32/' app/test/test_pmd_perf.c" % self.max_traffic_burst, "# ", 30)
         self.tmp_path = '/tmp/test_pmd_perf.c'
+        self.dut.send_expect("rm -fr %s" % self.tmp_path, "# ")
         self.dut.send_expect("cp app/test/test_pmd_perf.c %s" % self.tmp_path, "# ")
 
     def set_up(self):
@@ -133,6 +134,7 @@  class TestUnitTestsLoopback(TestCase):
         """
         Run after each test case.
         """
+        self.dut.send_expect("rm -fr app/test/test_pmd_perf.c", "# ")
         self.dut.send_expect("cp %s app/test/test_pmd_perf.c" % self.tmp_path, "# ")
         self.dut.kill_all()
 
@@ -140,7 +142,6 @@  class TestUnitTestsLoopback(TestCase):
         """
         Run after each test suite.
         """
-        self.dut.send_expect("cp %s app/test/test_pmd_perf.c" % self.tmp_path, "# ")
         self.dut.send_expect("sed -i -e 's/#define MAX_TRAFFIC_BURST              32/#define MAX_TRAFFIC_BURST              %s/' app/test/test_pmd_perf.c" % self.max_traffic_burst, "# ", 30)
         self.dut.build_install_dpdk(self.target)        
         self.dut.kill_all()