[V1] tests/TestSuite_vmdq:delete invalid code in set_up_all and tear_down_all

Message ID 20201026133942.51153-1-weix.ling@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/TestSuite_vmdq:delete invalid code in set_up_all and tear_down_all |

Commit Message

Ling, WeiX Oct. 26, 2020, 1:39 p.m. UTC
  delete invalid code in set_up_all and tear_down_all becasue of
CONFIG_RTE_MAX_QUEUES_PER_PORT default is 1024 in new DPDK.

Signed-off-by: lingwei <weix.ling@intel.com>
---
 tests/TestSuite_vmdq.py | 6 ------
 1 file changed, 6 deletions(-)
  

Comments

Ling, WeiX Oct. 26, 2020, 5:45 a.m. UTC | #1
Tested-by: Ling, Wei <weix.ling@intel.com>

Regards,
Ling Wei

> -----Original Message-----
> From: lingwei <weix.ling@intel.com>
> Sent: Monday, October 26, 2020 09:40 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V1] tests/TestSuite_vmdq:delete invalid code in
> set_up_all and tear_down_all
  
Ma, LihongX Oct. 29, 2020, 8:15 a.m. UTC | #2
Acked-by: Lihong Ma<lihongx.ma@intel.com>

Regards,
Ma,lihong

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of lingwei
> Sent: Monday, October 26, 2020 9:40 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_vmdq:delete invalid code in
> set_up_all and tear_down_all
> 
> delete invalid code in set_up_all and tear_down_all becasue of
> CONFIG_RTE_MAX_QUEUES_PER_PORT default is 1024 in new DPDK.
> 
> Signed-off-by: lingwei <weix.ling@intel.com>
> ---
  
Tu, Lijuan Nov. 3, 2020, 2:15 a.m. UTC | #3
> > delete invalid code in set_up_all and tear_down_all becasue of
> > CONFIG_RTE_MAX_QUEUES_PER_PORT default is 1024 in new DPDK.
> >
> > Signed-off-by: lingwei <weix.ling@intel.com>
> Acked-by: Lihong Ma<lihongx.ma@intel.com>

Applied
  

Patch

diff --git a/tests/TestSuite_vmdq.py b/tests/TestSuite_vmdq.py
index dc4f5ae..3f2ccde 100644
--- a/tests/TestSuite_vmdq.py
+++ b/tests/TestSuite_vmdq.py
@@ -56,8 +56,6 @@  class TestVmdq(TestCase):
         self.verify(len(self.dut_ports) >= 2, "Insufficient ports")
         self.ports_socket = self.dut.get_numa_id(self.dut_ports[0])
 
-        self.dut.send_expect("sed -i 's/CONFIG_RTE_MAX_QUEUES_PER_PORT=256/CONFIG_RTE_MAX_QUEUES_PER_PORT=1024/' ./config/common_base", "# ", 5)
-        self.dut.set_build_options({'RTE_MAX_QUEUES_PER_PORT': 1024})
         self.dut.build_install_dpdk(self.target)
         # Update the max queue per port for Fortville.
         self.dut.send_expect("sed -i 's/define MAX_QUEUES 128/define MAX_QUEUES 1024/' ./examples/vmdq/main.c", "#", 5)
@@ -270,8 +268,4 @@  class TestVmdq(TestCase):
         Run after each test suite.
         """
         # resume setting
-        self.dut.send_expect(
-            "sed -i 's/CONFIG_RTE_MAX_QUEUES_PER_PORT=1024/CONFIG_RTE_MAX_QUEUES_PER_PORT=256/' ./config/common_base",
-            "# ", 5)
-        self.dut.set_build_options({'RTE_MAX_QUEUES_PER_PORT': 256})
         self.dut.build_install_dpdk(self.target)