diff mbox series

[V3] tests/link_status_interrupt: optimize link-down-on-close checking method

Message ID 1635152748-95420-1-git-send-email-songx.jiale@intel.com (mailing list archive)
State Superseded
Headers
Series [V3] tests/link_status_interrupt: optimize link-down-on-close checking method |

Checks

Context Check Description
ci/Intel-dts-suite-test fail Testing issues

Commit Message

Jiale, SongX Oct. 25, 2021, 9:05 a.m. UTC 
  some nic no link-down-on-close

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_link_status_interrupt.py | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
diff mbox series

Patch

diff --git a/tests/TestSuite_link_status_interrupt.py b/tests/TestSuite_link_status_interrupt.py
index bdb43f42..b58099b0 100755
--- a/tests/TestSuite_link_status_interrupt.py
+++ b/tests/TestSuite_link_status_interrupt.py
@@ -79,14 +79,16 @@  class TestLinkStatusInterrupt(TestCase):
             set_flag = "ethtool --set-priv-flags %s %s on" % (intf, self.flag)
             out = self.tester.send_expect(check_flag, "#")
             p = re.compile('%s\s+:\s+(\w+)' % self.flag)
-            res = re.search(p, out).group(1)
-            if res == "off":
-                self.tester.send_expect(set_flag, "#")
-                time.sleep(0.5)
-                out = self.tester.send_expect(check_flag, "#")
-                self.verify(re.search(p, out).group(1) == "on", "set %s %s on failed" % (intf, self.flag))
-            elif not res:
-                self.logger.info("NIC %s might not support this case" % intf)
+            match = re.search(p, out)
+            if match:
+                res = match.group(1)
+                if res == "off":
+                    self.tester.send_expect(set_flag, "#")
+                    time.sleep(0.5)
+                    out = self.tester.send_expect(check_flag, "#")
+                    self.verify(re.search(p, out).group(1) == "on", "set %s %s on failed" % (intf, self.flag))
+                elif not res:
+                    self.logger.info("NIC %s might not support this case" % intf)
 
     def set_link_status_and_verify(self, dutPort, status):
         """