diff mbox series

[V1] tests/link_status_interrupt: add link-down-on-close status check and close it

Message ID 1632447782-136897-1-git-send-email-songx.jiale@intel.com (mailing list archive)
State Superseded
Headers show
Series [V1] tests/link_status_interrupt: add link-down-on-close status check and close it | expand

Checks

Context Check Description
ci/Intel-dts-suite-test fail Testing issues

Commit Message

Jiale Song Sept. 24, 2021, 1:43 a.m. UTC
since the link-down-on-close of the tester is turned on, but 
not closed, the subsequent tests are affected

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_link_status_interrupt.py | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 tests/TestSuite_link_status_interrupt.py

Comments

Tu, Lijuan Sept. 29, 2021, 3:44 a.m. UTC | #1
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> Sent: 2021年9月24日 9:43
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/link_status_interrupt: add link-down-on-close
> status check and close it
> 
> since the link-down-on-close of the tester is turned on, but not closed, the
> subsequent tests are affected
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>

Applied
diff mbox series

Patch

diff --git a/tests/TestSuite_link_status_interrupt.py b/tests/TestSuite_link_status_interrupt.py
old mode 100644
new mode 100755
index 2e8c282..5590d94
--- a/tests/TestSuite_link_status_interrupt.py
+++ b/tests/TestSuite_link_status_interrupt.py
@@ -70,6 +70,22 @@  class TestLinkStatusInterrupt(TestCase):
             self.basic_intr_mode = ["msix", "legacy"]
         if self.drivername == "vfio-pci":
             self.basic_intr_mode.append("msi")
+        self.intfs = [self.tester.get_interface(self.tester.get_local_port(i)) for i in self.dut_ports]
+        # check link-down-on-close flag
+        self.flag = "link-down-on-close"
+        for intf in self.intfs:
+            check_flag = "ethtool --show-priv-flags %s" % intf
+            set_flag = "ethtool --set-priv-flags %s %s on" % (intf, self.flag)
+            out = self.tester.send_expect(check_flag, "#")
+            p = re.compile('%s\s+:\s+(\w+)' % self.flag)
+            res = re.search(p, out).group(1)
+            if res == "off":
+                self.tester.send_expect(set_flag, "#")
+                time.sleep(0.5)
+                out = self.tester.send_expect(check_flag, "#")
+                self.verify(re.search(p, out).group(1) == "on", "set %s %s on failed" % (intf, self.flag))
+            elif not res:
+                self.logger.info("NIC %s might not support this case" % intf)
 
     def set_link_status_and_verify(self, dutPort, status):
         """
@@ -193,4 +209,6 @@  class TestLinkStatusInterrupt(TestCase):
         """
         Run after each test suite.
         """
-        pass
+        if self.dut.get_os_type() != 'freebsd':
+            for intf in self.intfs:
+                self.tester.send_expect("ethtool --set-priv-flags %s %s off" % (intf, self.flag), "#", 10)