diff mbox series

[V1] tests/userspace_ethtool: modify the check method of mac

Message ID 1631780638-9232-1-git-send-email-songx.jiale@intel.com (mailing list archive)
State Accepted
Headers show
Series [V1] tests/userspace_ethtool: modify the check method of mac | expand

Commit Message

Jiale Song Sept. 16, 2021, 8:23 a.m. UTC
the case check failed because the mac echoed by the "macaddr" command of dpdk-ethtool 
changed to uppercase letters. modify the script to solve the problem

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100644 => 100755 tests/TestSuite_userspace_ethtool.py

Comments

Tu, Lijuan Sept. 27, 2021, 6:29 a.m. UTC | #1
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> Sent: 2021年9月16日 16:24
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/userspace_ethtool: modify the check method of
> mac
> 
> the case check failed because the mac echoed by the "macaddr" command of
> dpdk-ethtool changed to uppercase letters. modify the script to solve the
> problem
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>

Applied
diff mbox series

Patch

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
old mode 100644
new mode 100755
index 4536b7d..9ae84c0
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -510,7 +510,7 @@  class TestUserspaceEthtool(TestCase):
             port = self.ports[index]
             mac = self.dut.ports_info[port]['mac']
             dump_mac = self.strip_mac(index)
-            self.verify(mac == dump_mac, "Userspace tool failed to dump mac")
+            self.verify(mac.lower() == dump_mac.lower(), "Userspace tool failed to dump mac")
             self.dut.send_expect("macaddr %d %s" % (port, valid_mac), "EthApp>")
             dump_mac = self.strip_mac(index)
             self.verify(dump_mac == valid_mac, "Userspace tool failed to set mac")