mbox series

[V3,0/5] Improve checksum validate and tso packet counting.

Message ID 20221228051503.36747-1-ke1.xu@intel.com (mailing list archive)
Headers
Series Improve checksum validate and tso packet counting. |

Message

Ke Xu Dec. 28, 2022, 5:14 a.m. UTC
  This patch updates checksum_validate method and remove the tunnel one.

Use packet.show(dump) methods and packet reading to validate the
 packets in a faster, more common and more stable way. This allows
 packets other than the plain packets can be verified by method
 checksum_validate. This updated method replaces checksum_validate_tunnel
 in checksum offload cases.

This patch also updates TSO packet checking. Replace the tcpdump
 implementation to a packet reading implementation.

Packet reading implementation is more common to use when to verify the
 received packet count and payload size. The tcpdump method is not
 able to recognize some of the tunnel packets, leading to a wrong output
 failing the validation. Newly added tcpdump_analyse_sniff method is
 implemented by sniff packet reading and analysing and can replace
 the lagacy methods number_of_packets and number_of_bytes.

This patch also removes a redundant variable.

Ke Xu (5):
  tests/vf_offload: Improve checksum_validate method.
  tests/vf_offload: Remove redundant variable used.
  tests/vf_offload: Use modified checksum_validate to replace
    checksum_validate_tunnel.
  tests/vf_offload: Improve tcpdump_analyse_sniff method
  tests/vf_offload: Replace the tcpdump implementation to a packet
    reading implementation.

 tests/TestSuite_vf_offload.py | 247 +++++++++-------------------------
 1 file changed, 66 insertions(+), 181 deletions(-)
  

Comments

Fu, Qi Jan. 3, 2023, 6:05 a.m. UTC | #1
Acked-by: Fu, Qi <qi.fu@intel.com>

> -----Original Message-----
> From: Xu, Ke1 <ke1.xu@intel.com>
> Sent: Wednesday, December 28, 2022 1:15 PM
> To: dts@dpdk.org
> Cc: Fu, Qi <qi.fu@intel.com>; Li, WeiyuanX <weiyuanx.li@intel.com>; Tu,
> Lijuan <lijuan.tu@intel.com>; Xu, Ke1 <ke1.xu@intel.com>
> Subject: [DTS][PATCH V3 0/5] Improve checksum validate and tso packet
> counting.
> 
> This patch updates checksum_validate method and remove the tunnel one.
> 
> Use packet.show(dump) methods and packet reading to validate the
> packets in a faster, more common and more stable way. This allows
> packets other than the plain packets can be verified by method
> checksum_validate. This updated method replaces
> checksum_validate_tunnel  in checksum offload cases.
> 
> This patch also updates TSO packet checking. Replace the tcpdump
> implementation to a packet reading implementation.
> 
> Packet reading implementation is more common to use when to verify the
> received packet count and payload size. The tcpdump method is not  able
> to recognize some of the tunnel packets, leading to a wrong output  failing
> the validation. Newly added tcpdump_analyse_sniff method is
> implemented by sniff packet reading and analysing and can replace  the
> lagacy methods number_of_packets and number_of_bytes.
> 
> This patch also removes a redundant variable.
> 
> Ke Xu (5):
>   tests/vf_offload: Improve checksum_validate method.
>   tests/vf_offload: Remove redundant variable used.
>   tests/vf_offload: Use modified checksum_validate to replace
>     checksum_validate_tunnel.
>   tests/vf_offload: Improve tcpdump_analyse_sniff method
>   tests/vf_offload: Replace the tcpdump implementation to a packet
>     reading implementation.
> 
>  tests/TestSuite_vf_offload.py | 247 +++++++++-------------------------
>  1 file changed, 66 insertions(+), 181 deletions(-)
> 
> --
> 2.25.1
  
Tu, Lijuan Jan. 4, 2023, 1:08 a.m. UTC | #2
> -----Original Message-----
> From: Xu, Ke1 <ke1.xu@intel.com>
> Sent: Wednesday, December 28, 2022 1:15 PM
> To: dts@dpdk.org
> Cc: Fu, Qi <qi.fu@intel.com>; Li, WeiyuanX <weiyuanx.li@intel.com>; Tu, Lijuan
> <lijuan.tu@intel.com>; Xu, Ke1 <ke1.xu@intel.com>
> Subject: [DTS][PATCH V3 0/5] Improve checksum validate and tso packet
> counting.
> 
> This patch updates checksum_validate method and remove the tunnel one.
> 
> Use packet.show(dump) methods and packet reading to validate the  packets in
> a faster, more common and more stable way. This allows  packets other than
> the plain packets can be verified by method  checksum_validate. This updated
> method replaces checksum_validate_tunnel  in checksum offload cases.
> 
> This patch also updates TSO packet checking. Replace the tcpdump
> implementation to a packet reading implementation.
> 
> Packet reading implementation is more common to use when to verify the
> received packet count and payload size. The tcpdump method is not  able to
> recognize some of the tunnel packets, leading to a wrong output  failing the
> validation. Newly added tcpdump_analyse_sniff method is  implemented by sniff
> packet reading and analysing and can replace  the lagacy methods
> number_of_packets and number_of_bytes.
> 
> This patch also removes a redundant variable.
> 
> Ke Xu (5):
>   tests/vf_offload: Improve checksum_validate method.
>   tests/vf_offload: Remove redundant variable used.
>   tests/vf_offload: Use modified checksum_validate to replace
>     checksum_validate_tunnel.
>   tests/vf_offload: Improve tcpdump_analyse_sniff method
>   tests/vf_offload: Replace the tcpdump implementation to a packet
>     reading implementation.

Applied, thanks