diff mbox series

[5/6] eal/windows: fix the curly braces mismatch problem

Message ID tencent_0F918E18589EEC53D388089DA7EF86913C07@qq.com (mailing list archive)
State Superseded, archived
Headers
Series [1/6] bus/dpaa: fix the curly braces mismatch problem |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Weiguo Li Feb. 6, 2022, 12:44 a.m. UTC 
  Supplement the first half of braces for the extern "C" block

Fixes: 99a2dd955fba6 ("lib: remove librte_ prefix from directory names")
Cc: bruce.richardson@intel.com

Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
 lib/eal/windows/include/dirent.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Dmitry Kozlyuk Feb. 6, 2022, 4:23 p.m. UTC | #1 
2022-02-06 08:44 (UTC+0800), Weiguo Li:
> Supplement the first half of braces for the extern "C" block
> 
> Fixes: 99a2dd955fba6 ("lib: remove librte_ prefix from directory names")
> Cc: bruce.richardson@intel.com
> 
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> ---
>  lib/eal/windows/include/dirent.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/eal/windows/include/dirent.h b/lib/eal/windows/include/dirent.h
> index 34eb077f8c..0a399d3145 100644
> --- a/lib/eal/windows/include/dirent.h
> +++ b/lib/eal/windows/include/dirent.h
> @@ -28,6 +28,10 @@
>  #include <sys/stat.h>
>  #include <errno.h>
>  
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  /* Maximum length of file name */
>  #if !defined(PATH_MAX)
>  #   define PATH_MAX MAX_PATH

This file is not public, used only from DPDK C code.
Rather then adding the opening part, the closing part should be removed.
The "Fixes" tag is incorrect, should be:

Fixes: 6e1ed4cbbe99 ("eal/windows: add dirent implementation")
Cc: pallavi.kadam@intel.com
Weiguo Li Feb. 7, 2022, 11:43 a.m. UTC | #2 
On Sun, 6 Feb 2022 19:23:03 +0300, Dmitry Kozlyuk wrote:

> This file is not public, used only from DPDK C code.
> Rather then adding the opening part, the closing part should be removed.
> The "Fixes" tag is incorrect, should be:

> Fixes: 6e1ed4cbbe99 ("eal/windows: add dirent implementation")
> Cc: pallavi.kadam@intel.com
> 

Hi Dmitry,

Thanks for your remind. I'll update the patch later.

-Weiguo
diff mbox series

Patch

diff --git a/lib/eal/windows/include/dirent.h b/lib/eal/windows/include/dirent.h
index 34eb077f8c..0a399d3145 100644
--- a/lib/eal/windows/include/dirent.h
+++ b/lib/eal/windows/include/dirent.h
@@ -28,6 +28,10 @@ 
 #include <sys/stat.h>
 #include <errno.h>
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 /* Maximum length of file name */
 #if !defined(PATH_MAX)
 #   define PATH_MAX MAX_PATH