From patchwork Thu Aug 8 08:22:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Herbelot X-Patchwork-Id: 57564 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7DFCD5424; Thu, 8 Aug 2019 10:23:14 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 37D422BAE for ; Thu, 8 Aug 2019 10:23:00 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id p74so1472581wme.4 for ; Thu, 08 Aug 2019 01:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=uU3vOsC5tYEEbl/Y7A+DbWIseB+egChyotcPE52/iZs=; b=W5fYXOPa2CqK1NBLyRBzI+pNvEXSTEIqSP4a4MeOJwO6wyQBluIhYpDfGLNNZAQu0E wGGT2s+LQs+nZpVuLgu8yvl8QJC6kfOBZGaAQmRrnR0eqbVAoYdVR4JJ3PTEe3SebW9/ ye1WfwGQ8guPzlxV/2OKUfQlz7OgpZZ/wSVpVdE+1lCCyuzHDVchCEABlasfKwPGk3n+ 9cPQ+bc09rL7KwEZzUB0hkgmS8UYEUjWVo9Zga2brkw9/vMLzuklpkxB8DW5aalz6ifY D1jjzqIUbVog+2ciHxxKzydsH94emogRFd2NUUg//qAu66kKVwWZU1IvRIu8QETmIQzB Rq/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=uU3vOsC5tYEEbl/Y7A+DbWIseB+egChyotcPE52/iZs=; b=XWMSC/AkcMXCmCd9DuobfZDX8FGuu9SThHxeQaTbD1qwkf0Zq6GsK3/2HGpV+0/708 DZ6ANL7qbBi1I1qrHVjiwKsWBXJOKYTV05Mb+xIxs7IAlwEYk07ygJfK2KfYtem8h6Th y8jWY44Rm4fkUzpSEPA0A1LU0Jy2EikQ8pAccTAPoQEW9MFFMSadVld0WfiJEwYUH/hc vz8mCukHoWKSQmkyUJTq5TrR1pWkN8DFYm0Hc5tl8nysrsJ5ktOgOkjdwzuZV8jYmPpb Ngkk6Pt+zC2OwvlDp8IM+uKKN0fGrqqpe7QjLgWOd/ncTgVJ9asrzqY1Qtp8gUAX9SFY OAHQ== X-Gm-Message-State: APjAAAVYGYmRGhPauBoJaqd7VwNS/87asPIbDnTOMcXMfJNf8DoRCgeS +Y1Nmd2dChD1WmPhzNhS8u7GFHuzfg== X-Google-Smtp-Source: APXvYqwHgUGFpXQ6XzQjbQL8LME2cVUn2rMvKNkCtiIvGvcXdFDlxp0u10Uwa4/eNt23YV0eKCDcfA== X-Received: by 2002:a1c:c5c2:: with SMTP id v185mr3052174wmf.161.1565252579698; Thu, 08 Aug 2019 01:22:59 -0700 (PDT) Received: from ascain.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id t13sm111437018wrr.0.2019.08.08.01.22.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Aug 2019 01:22:59 -0700 (PDT) From: Thierry Herbelot To: dev@dpdk.org Cc: Thibaut Collet , stable@dpdk.org, Thomas Monjalon Date: Thu, 8 Aug 2019 10:22:14 +0200 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH 19.11 V3 09/12] virtio: get all pending rx packets with vectorized functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thibaut Collet The loop to read packets does not take all packets as the number of available packets (nb_used) is decremented in the loop. Take all available packets provides a performance improvement of 3%. Fixes: fc3d66212fed ("virtio: add vector Rx") Cc: stable@dpdk.org Signed-off-by: Thibaut Collet --- drivers/net/virtio/virtio_rxtx_simple_neon.c | 5 +++-- drivers/net/virtio/virtio_rxtx_simple_sse.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/drivers/net/virtio/virtio_rxtx_simple_neon.c index 70e89fc428e0..992e71f010eb 100644 --- a/drivers/net/virtio/virtio_rxtx_simple_neon.c +++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c @@ -42,7 +42,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, struct virtnet_rx *rxvq = rx_queue; struct virtqueue *vq = rxvq->vq; struct virtio_hw *hw = vq->hw; - uint16_t nb_used; + uint16_t nb_used, nb_total; uint16_t desc_idx; struct vring_used_elem *rused; struct rte_mbuf **sw_ring; @@ -106,9 +106,10 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, virtqueue_notify(vq); } + nb_total = nb_used; ref_rx_pkts = rx_pkts; for (nb_pkts_received = 0; - nb_pkts_received < nb_used;) { + nb_pkts_received < nb_total;) { uint64x2_t desc[RTE_VIRTIO_DESC_PER_LOOP / 2]; uint64x2_t mbp[RTE_VIRTIO_DESC_PER_LOOP / 2]; uint64x2_t pkt_mb[RTE_VIRTIO_DESC_PER_LOOP]; diff --git a/drivers/net/virtio/virtio_rxtx_simple_sse.c b/drivers/net/virtio/virtio_rxtx_simple_sse.c index cb1610e71563..f9ec4ae69986 100644 --- a/drivers/net/virtio/virtio_rxtx_simple_sse.c +++ b/drivers/net/virtio/virtio_rxtx_simple_sse.c @@ -43,7 +43,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, struct virtnet_rx *rxvq = rx_queue; struct virtqueue *vq = rxvq->vq; struct virtio_hw *hw = vq->hw; - uint16_t nb_used; + uint16_t nb_used, nb_total; uint16_t desc_idx; struct vring_used_elem *rused; struct rte_mbuf **sw_ring; @@ -108,9 +108,10 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, virtqueue_notify(vq); } + nb_total = nb_used; ref_rx_pkts = rx_pkts; for (nb_pkts_received = 0; - nb_pkts_received < nb_used;) { + nb_pkts_received < nb_total;) { __m128i desc[RTE_VIRTIO_DESC_PER_LOOP / 2]; __m128i mbp[RTE_VIRTIO_DESC_PER_LOOP / 2]; __m128i pkt_mb[RTE_VIRTIO_DESC_PER_LOOP];