From patchwork Tue Apr 11 12:46:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 23460 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id AD8A12BB0; Tue, 11 Apr 2017 14:46:41 +0200 (CEST) Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 187301DB1 for ; Tue, 11 Apr 2017 14:46:40 +0200 (CEST) Received: by mail-wr0-f177.google.com with SMTP id o21so139780152wrb.2 for ; Tue, 11 Apr 2017 05:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=DvSkIUK1/CpSpdJkj+NOdjstSQjRjA7nl5AqTnA72W4=; b=LViSRN2lmDgkG6TcplJgda4Af/w89Hobrsbc5XCXjXla9ibCObpl2g2HIJGfirA4dd k1z3Q59DDmmvQNP0IzLxzYMZUSkimZC+74xSZTPrT274Ez9pVPa2RDWu9jrHyJr7bCFJ GvqbMjtPETmtX21VrysWefphkwnEFJK5w2gG8SkgFo8rs6uuMwNK6nE4VZKgkSsXdxVO HeVuLFrYbtZDILfv3R9KgTJ8eCD3SS6g8n6l8Ge48xjVFknk9S98qxfLuGsg6f9O89bL JY7QjbKe7epg3Uj+mDz2HkoEgC8EIqTomF1ulwTwkeNHRuvj7OO8kL+bzI+wsEh2Y2+T PMqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=DvSkIUK1/CpSpdJkj+NOdjstSQjRjA7nl5AqTnA72W4=; b=LfKIpT/xhVwJoCssZ/9Ov49FmQa03Fds6hwlS3386+JlX0NaguyfZgoWFhXA2aeiLQ k8t7skZ1HUOv11C7efaiCLbQDQ3mqRY7KdgQGGH2FfIGVbPakRLpOmDjX30hsvTpFzR7 fbR5LFIDt6uNcpXQJKS7FQB5wkljpWqjDrTU9IxNqYRqTz1vb10oS+yUoAaFpY47XH4c EgGewgLojjF2OGPDPBT2puCq1qQ8LezK53jPBGJKh019ldVBrbMsxowPzMTKd+xKORd+ QKSLNaWGXrk4GUh5KrqV+fL5G5qxNjfwg8xfRh6bsFX+uzsaQxnQuXYk52B9e2+fXIbl FrvA== X-Gm-Message-State: AN3rC/4rLxXuZPdOw0TsRh+vL3q0Gd+iFm2BACh1WJLGrZZyAqJ2zdq/t5G94Wtc2VBf9tDt X-Received: by 10.223.172.228 with SMTP id o91mr5932176wrc.122.1491914799321; Tue, 11 Apr 2017 05:46:39 -0700 (PDT) Received: from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 32sm21444101wrq.25.2017.04.11.05.46.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 11 Apr 2017 05:46:38 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil Date: Tue, 11 Apr 2017 14:46:17 +0200 Message-Id: X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH] net/mlx5: remove extra check on Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Removing this check improves performance as VLAN and CRC stripping are enabled most of the time. Convert MLX5_CQE_VLAN_STRIPPED to network order to speed up the check instead of doing it on the completion queue entry field. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxtx.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index fae9d27..2e208bf 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -2041,23 +2041,19 @@ mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) mlx5_flow_mark_get(mark); } } - if (rxq->csum | rxq->csum_l2tun | rxq->vlan_strip | - rxq->crc_present) { - if (rxq->csum) { - pkt->packet_type = - rxq_cq_to_pkt_type(cqe); - pkt->ol_flags |= - rxq_cq_to_ol_flags(rxq, cqe); - } - if (ntohs(cqe->hdr_type_etc) & - MLX5_CQE_VLAN_STRIPPED) { - pkt->ol_flags |= PKT_RX_VLAN_PKT | - PKT_RX_VLAN_STRIPPED; - pkt->vlan_tci = ntohs(cqe->vlan_info); - } - if (rxq->crc_present) - len -= ETHER_CRC_LEN; + if (rxq->csum | rxq->csum_l2tun) { + pkt->packet_type = rxq_cq_to_pkt_type(cqe); + pkt->ol_flags |= rxq_cq_to_ol_flags(rxq, cqe); + } + if (rxq->vlan_strip && + (cqe->hdr_type_etc & + htons(MLX5_CQE_VLAN_STRIPPED))) { + pkt->ol_flags |= PKT_RX_VLAN_PKT | + PKT_RX_VLAN_STRIPPED; + pkt->vlan_tci = ntohs(cqe->vlan_info); } + if (rxq->crc_present) + len -= ETHER_CRC_LEN; PKT_LEN(pkt) = len; } DATA_LEN(rep) = DATA_LEN(seg);