diff mbox series

test: drop 'alarm_autotest' and 'cycles_autotest' from test suite

Message ID f7teedv8y6p.fsf@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series test: drop 'alarm_autotest' and 'cycles_autotest' from test suite | expand

Checks

Context Check Description
ci/iol-mellanox-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance fail Performance Testing issues
ci/iol-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/iol-abi-testing success Testing PASS
ci/checkpatch warning coding style issues

Commit Message

Aaron Conole May 25, 2021, 12:16 a.m. UTC
The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying
system having very accurate and precise timing.  On systems where the timing
isn't as rigid, or the load is particularly high, these tests are unreliable
since the wake latency from the scheduler can be high enough to miss the
timing window.

Remove these tests from the test suites.  Maybe it's useful for these
tests to be present as a diagnostics tool, but for normal unit testing,
they don't provide much value.  They have falsely flagged patches as
FAIL on various infrastructures.

Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 app/test/meson.build | 2 --
 1 file changed, 2 deletions(-)

Comments

Thomas Monjalon May 25, 2021, 8:05 a.m. UTC | #1
25/05/2021 02:16, Aaron Conole:
> The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying
> system having very accurate and precise timing.  On systems where the timing
> isn't as rigid, or the load is particularly high, these tests are unreliable
> since the wake latency from the scheduler can be high enough to miss the
> timing window.
> 
> Remove these tests from the test suites.  Maybe it's useful for these
> tests to be present as a diagnostics tool, but for normal unit testing,
> they don't provide much value.  They have falsely flagged patches as
> FAIL on various infrastructures.

Are sure of the value keeping the source code?
Aaron Conole May 25, 2021, 1:21 p.m. UTC | #2
Thomas Monjalon <thomas@monjalon.net> writes:

> 25/05/2021 02:16, Aaron Conole:
>> The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying
>> system having very accurate and precise timing.  On systems where the timing
>> isn't as rigid, or the load is particularly high, these tests are unreliable
>> since the wake latency from the scheduler can be high enough to miss the
>> timing window.
>> 
>> Remove these tests from the test suites.  Maybe it's useful for these
>> tests to be present as a diagnostics tool, but for normal unit testing,
>> they don't provide much value.  They have falsely flagged patches as
>> FAIL on various infrastructures.
>
> Are sure of the value keeping the source code?

Okay, I think it's fine to remove it as well.

I will submit v2
diff mbox series

Patch

diff --git a/app/test/meson.build b/app/test/meson.build
index 08c82d3d23..8dec48e81c 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -185,14 +185,12 @@  test_deps = [
 # to indicate whether it can run in no-huge mode.
 fast_tests = [
         ['acl_autotest', true],
-        ['alarm_autotest', false],
         ['atomic_autotest', false],
         ['bitops_autotest', true],
         ['byteorder_autotest', true],
         ['cmdline_autotest', true],
         ['common_autotest', true],
         ['cpuflags_autotest', true],
-        ['cycles_autotest', true],
         ['debug_autotest', true],
         ['eal_flags_c_opt_autotest', false],
         ['eal_flags_main_opt_autotest', false],