From patchwork Fri Nov 20 13:13:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Lakkireddy X-Patchwork-Id: 9020 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id AA12A8E62; Fri, 20 Nov 2015 14:14:04 +0100 (CET) Received: from stargate3.asicdesigners.com (stargate.chelsio.com [67.207.115.98]) by dpdk.org (Postfix) with ESMTP id BDCA88E56 for ; Fri, 20 Nov 2015 14:14:02 +0100 (CET) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate3.asicdesigners.com (8.13.8/8.13.8) with ESMTP id tAKDDxmR016235; Fri, 20 Nov 2015 05:13:59 -0800 From: Rahul Lakkireddy To: dev@dpdk.org Date: Fri, 20 Nov 2015 18:43:37 +0530 Message-Id: X-Mailer: git-send-email 2.5.3 In-Reply-To: References: In-Reply-To: References: Cc: Felix Marti , Kumar Sanghvi , Nirranjan Kirubaharan Subject: [dpdk-dev] [PATCH 1/2] cxgbe: fix queue setup failure due to strict min desc requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Most dpdk examples and apps seem to initialize with a minimum of 128 rx descriptors and 512 tx descriptors for queue setup. However, CXGBE PMD enforces a minimum of 1024 descriptors. This causes the dpdk stack to return -EINVAL because the apps do not request the minimum required. The fix is to relax this enforcing in CXGBE PMD. A minimum of 128 descriptors seems to be a good number with the least impact on the performance. Fixes: 946c9ed95616 ("cxgbe: get descriptor limits") Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/cxgbe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/cxgbe.h b/drivers/net/cxgbe/cxgbe.h index adc0d92..0201c99 100644 --- a/drivers/net/cxgbe/cxgbe.h +++ b/drivers/net/cxgbe/cxgbe.h @@ -37,7 +37,7 @@ #include "common.h" #include "t4_regs.h" -#define CXGBE_MIN_RING_DESC_SIZE 1024 /* Min TX/RX descriptor ring size */ +#define CXGBE_MIN_RING_DESC_SIZE 128 /* Min TX/RX descriptor ring size */ #define CXGBE_MAX_RING_DESC_SIZE 4096 /* Max TX/RX descriptor ring size */ #define CXGBE_DEFAULT_TX_DESC_SIZE 1024 /* Default TX ring size */