From patchwork Mon Jul 23 07:18:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 43263 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F72C1B53; Mon, 23 Jul 2018 09:19:01 +0200 (CEST) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 50B081B53 for ; Mon, 23 Jul 2018 09:19:00 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id q10-v6so16785758wrd.4 for ; Mon, 23 Jul 2018 00:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=crIq6Ot8UpP8RoT2YjQYJ548VH1y2pkH5Z5pTL1KDaU=; b=o5U5X/Vff6jWoBcR4kpMSA/a3WXxjt7DZpms8X7hV0TAsySS1yepHsh+cc1ypVwwRa w1+7kgBwj+DVqEjHourOf5zRcuxp+KSbklAQlCw3rmjqPEoa80xf732fYmnyYXVy6hZh O9eGdCJJERQWFp/Mmft7iDkFNb/L89zII7K7cKLmvooVuyrXqf7hP9jxUXIPONoZ2AbJ RGjJiuXw2+9TCK+kn9sbAdCKEGsDDn8dobw9hro0IL6JMRik31Yfi1tAwEiYa/J9fM/O pfWfo/Ksoq+eOPePXV5flPtoDXZclGbfde/y92aP1TM1uJuampVRlxzx/Z/w1X/oEOAu VKUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=crIq6Ot8UpP8RoT2YjQYJ548VH1y2pkH5Z5pTL1KDaU=; b=GPuS+YmD1qLQKMObdwWkvMEQce9/36k0Z8tYZJTp3q3Cj6Mo6gOgCDdHBCzsyKhahA YjD9349Yffp+eu3w+Q5eFnLR8KcxhncsG5eBha9qyTYJxpu8X4vsW/WXPockPRykilGG ZGpptXa/4rXZXwrDUhFOgyS4jJkhasR/m5zZft0X+j6jTu7+KzLHRK4kNlvz+qWMgOeW d+tSdJeSWIH6M8Hfvb1rcuzP2nA1LQFP5zk3VCyLQzIoISNo/71a4zjze3Du8XmGGnm8 i8o+0v97t5ndhvkfOCfM7UJweh2hM62wyIoCoV6cpvY31/s6svO23CNk4eXRxuTJomXD axdQ== X-Gm-Message-State: AOUpUlF0mNowRSytgwm0z2NjKF2T3PH9Q/vgSYGu3UyhNekvLU3wrdbY Z8/oW4Ex5bLkjkv9trIAIdUCODmqRA== X-Google-Smtp-Source: AAOMgpf7ZgDZj98L4XlonuBBXmRL98ZmzYY8vaXvtcnY/C9kHbay1BQtxPqXDWMn4co+JM2eLa5m8w== X-Received: by 2002:a5d:46d1:: with SMTP id g17-v6mr7353599wrs.76.1532330339913; Mon, 23 Jul 2018 00:18:59 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g10-v6sm8735979wru.43.2018.07.23.00.18.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 00:18:59 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org, Yongseok Koh , Shahaf Shuler Cc: stable@dpdk.org Date: Mon, 23 Jul 2018 09:18:40 +0200 Message-Id: X-Mailer: git-send-email 2.18.0 Subject: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing the sub flow engine to reject the rule. Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_trigger.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index 4d2078bbd..d02a626ae 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -300,9 +300,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) struct rte_flow_item_vlan vlan_spec = { .tci = rte_cpu_to_be_16(vlan), }; - struct rte_flow_item_vlan vlan_mask = { - .tci = 0xffff, - }; + struct rte_flow_item_vlan vlan_mask = + rte_flow_item_vlan_mask; ret = mlx5_ctrl_flow_vlan(dev, &bcast, &bcast, &vlan_spec, &vlan_mask); @@ -339,9 +338,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) struct rte_flow_item_vlan vlan_spec = { .tci = rte_cpu_to_be_16(vlan), }; - struct rte_flow_item_vlan vlan_mask = { - .tci = 0xffff, - }; + struct rte_flow_item_vlan vlan_mask = + rte_flow_item_vlan_mask; ret = mlx5_ctrl_flow_vlan(dev, &unicast, &unicast_mask,