From patchwork Thu Nov 17 09:49:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 17070 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E409A5699; Thu, 17 Nov 2016 10:50:17 +0100 (CET) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 9EBD83777 for ; Thu, 17 Nov 2016 10:50:16 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id g23so299146225wme.1 for ; Thu, 17 Nov 2016 01:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=DoZU17A4Acfxdnfmz1sel3n5Ksay+JX7g+ZTOegc6AA=; b=0JK9QIWtamTUyvik8VXwUSRrvBzd5YaJoS7WT90NTXVSc9qLWJqk1VpAyknGHdLPpF sefPxO8Ug0EHNuKFPgx+XM5gdxkXfr+5PDEjygtx7bekfSsN0FNZZaWl+36SYygV22oc PHI0jAv57xlxnkcsqEDxBr9FzvTViVH6E68ejKqigjd9sLpRL94YQ5PlJx69G387NIc6 sQ9Q9Ta3zmUzFmSpA3xPz69oU+X1XEm2z8X40uIYtw6pivSPVPi8rMco0GO5qV0vi7Th o/ZXFRlAs5fBLZVhGNmMkf5JLAFxf0Qfi4PtLBH/3LNi3v+j3iANIym5P2tsxt2NLIv+ aQFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=DoZU17A4Acfxdnfmz1sel3n5Ksay+JX7g+ZTOegc6AA=; b=KFpNOIDYgqTa1kFCYEcl/gp4mB2jSGQDpYWgGXZ8bKXR6l2DF0qtxIOf85NZrfCQLO KC8RW3E1NA1S3Navsb6cjtrmHF/UwpWjb5npJemjMUwmm1F0R9RarF1tZXTDtJhSF4MM 2fLrw267u4doXrxYOV65o+k+QlY7RiiVC0oganAdlRWm4C3dovCebVLGRqXdFG1UHXVM TBTeVhvPX82hNfBhpWtEDCDkPlFbbLCKiY1kYLOyJGPane3l9g72Pqvgw4gB7mwa+eYN i5EdcBuk+Qbval1Dm87Isz85i8XTQZkfB23oMUYnmIpbaxITzqqHle61sAVuTB25avk9 ZJuw== X-Gm-Message-State: AKaTC01xH2KViDMT9g0KJvkV+8ClOnmKxF5g39vYx6tZ6iHGoV4EpG/1mH4Y+cDAblmnjTcQ X-Received: by 10.194.71.228 with SMTP id y4mr1685177wju.136.1479376216333; Thu, 17 Nov 2016 01:50:16 -0800 (PST) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id c202sm17059625wme.1.2016.11.17.01.50.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Nov 2016 01:50:15 -0800 (PST) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil , stable@dpdk.org Date: Thu, 17 Nov 2016 10:49:54 +0100 Message-Id: X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH 1/3] net/mlx5: fix leak when starvation occurs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The list of segments to free was wrongly manipulated ending by only freeing the first segment instead of freeing all of them. The last one still belongs to the NIC and thus should not be freed. Fixes: a1bdb71a32da ("net/mlx5: fix crash in Rx") CC: stable@dpdk.org Reported-by: Liming Sun Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index beff580..9bd4d80 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -1312,10 +1312,10 @@ mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) } while (pkt != seg) { assert(pkt != (*rxq->elts)[idx]); - seg = NEXT(pkt); + rep = NEXT(pkt); rte_mbuf_refcnt_set(pkt, 0); __rte_mbuf_raw_free(pkt); - pkt = seg; + pkt = rep; } break; }