From patchwork Wed Oct 19 12:37:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 16718 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 5393D58DD; Wed, 19 Oct 2016 14:37:46 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 485FA2C58 for ; Wed, 19 Oct 2016 14:37:45 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 19 Oct 2016 05:37:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,514,1473145200"; d="scan'208";a="774529775" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.83]) ([10.237.220.83]) by FMSMGA003.fm.intel.com with ESMTP; 19 Oct 2016 05:37:43 -0700 To: Rasesh Mody , thomas.monjalon@6wind.com, bruce.richardson@intel.com References: <1476850306-2141-1-git-send-email-rasesh.mody@qlogic.com> <1476850306-2141-5-git-send-email-rasesh.mody@qlogic.com> Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com From: Ferruh Yigit Message-ID: Date: Wed, 19 Oct 2016 13:37:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1476850306-2141-5-git-send-email-rasesh.mody@qlogic.com> Subject: Re: [dpdk-dev] [PATCH v4 04/32] net/qede/base: add HSI changes and register defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/2016 5:11 AM, Rasesh Mody wrote: > - add the hardware software interface(HSI) changes > - add register definitions > > These will be required for 8.10.9.0 FW upgrade. > > Signed-off-by: Rasesh Mody <...> > /* > * Igu cleanup bit values to distinguish between clean or producer consumer > */ > @@ -1376,7 +1572,7 @@ struct dmae_cmd { > __le32 src_addr_hi; > __le32 dst_addr_lo; > __le32 dst_addr_hi; > - __le16 length /* Length in DW */; > + __le16 length_dw /* Length in DW */; This cause a compilation error [1] in patch by patch compilation, when debug is enabled. Fix seems straightforward [2]. Do you confirm the fix? If you confirm, you don't need to send a new version, fix can be applied while getting the patch. Thanks, ferruh [1]: (int)p_command->dst_addr_hi, (int)p_command->dst_addr_lo); ==== In file included from .../drivers/net/qede/base/ecore.h:36:0, from .../drivers/net/qede/base/ecore_hw.c:12: .../drivers/net/qede/base/ecore_hw.c: In function ‘ecore_dmae_post_command’: .../drivers/net/qede/base/ecore_hw.c:478:20: error: ‘struct dmae_cmd’ has no member named ‘length’; did you mean ‘length_dw’? (int)p_command->length, ^ .../drivers/net/qede/base/../qede_logs.h:47:11: note: in definition of macro ‘DP_VERBOSE’ ##__VA_ARGS__); \ ^~~~~~~~~~~ .../mk/internal/rte.compile-pre.mk:138: recipe for target 'base/ecore_hw.o' failed [2]: ==== diff --git a/drivers/net/qede/base/ecore_hw.c b/drivers/net/qede/base/ecore_hw.c index 72bc6de..5412ed1 100644 --- a/drivers/net/qede/base/ecore_hw.c +++ b/drivers/net/qede/base/ecore_hw.c @@ -475,7 +475,7 @@ ecore_dmae_post_command(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt) "len=0x%x src=0x%x:%x dst=0x%x:%x\n", idx_cmd, (u32)p_command->opcode, (u16)p_command->opcode_b, - (int)p_command->length, + (int)p_command->length_dw, (int)p_command->src_addr_hi, (int)p_command->src_addr_lo,