From patchwork Wed Feb 15 17:30:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 20441 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 097A32C54; Wed, 15 Feb 2017 18:30:53 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5D893A2F for ; Wed, 15 Feb 2017 18:30:51 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Feb 2017 09:30:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,166,1484035200"; d="scan'208";a="66186423" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by fmsmga006.fm.intel.com with ESMTP; 15 Feb 2017 09:30:49 -0800 To: Thomas Monjalon References: <20170214151326.7554-1-ferruh.yigit@intel.com> <20170215152632.25081-1-ferruh.yigit@intel.com> <20170215152632.25081-2-ferruh.yigit@intel.com> <3106919.K5kYvNu2Ff@xps13> Cc: dev@dpdk.org, Bruce Richardson , John McNamara , Keith Wiles From: Ferruh Yigit Message-ID: Date: Wed, 15 Feb 2017 17:30:48 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <3106919.K5kYvNu2Ff@xps13> Subject: Re: [dpdk-dev] [PATCH 2/4] mk: do not build tests by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/15/2017 4:58 PM, Thomas Monjalon wrote: > 2017-02-15 15:26, Ferruh Yigit: >> +.PHONY: test-buid >> +test-build: >> + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig >> + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk test > > Why not rely on default rule below? > > # all other build targets > %: > $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig > $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk $@ Because generic rule is using "rte.sdkbuild.mk $@" rule, for unit-test, $@ is test-build, but sdkbuild rule is "test" This can be solved with adding following to sdkbuild.mk: I can update if you think this is better? Thanks, ferruh --- a/mk/rte.sdkbuild.mk +++ b/mk/rte.sdkbuild.mk @@ -72,6 +72,9 @@ clean: $(CLEANDIRS) $(Q)$(MAKE) -f $(RTE_SDK)/GNUmakefile gcovclean @echo Clean complete +.PHONY: test-build +test-build: test + .SECONDEXPANSION: .PHONY: $(ROOTDIRS-y) test $(ROOTDIRS-y) test: