[v2] doc: announce change in ETH and VLAN item structs
Checks
Commit Message
Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
to include an additional value, indicating existence or absence of VLAN
headers following the current header, as proposed in RFC
https://mails.dpdk.org/archives/dev/2020-August/177536.html.
Because of ABI break this change is proposed for 20.11.
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
doc/guides/rel_notes/deprecation.rst | 5 +++++
1 file changed, 5 insertions(+)
Comments
06/08/2020 12:45, Dekel Peled:
> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
> to include an additional value, indicating existence or absence of VLAN
> headers following the current header, as proposed in RFC
> https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> Because of ABI break this change is proposed for 20.11.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct rte_flow_item_vlan``
> + structs will be modified, to include an additional value, indicating existence
> + or absence of a VLAN header following the current header, as proposed in RFC
> + https://mails.dpdk.org/archives/dev/2020-August/177536.html.
Specifying match patterns on none or multiple extensions
is difficult to manage with rte_flow.
It seems this approach of adding explicit fields in the items
can work well.
Acked-by: Thomas Monjalon <thomas@monjalon.net>
On 8/6/20 3:25 PM, Thomas Monjalon wrote:
> 06/08/2020 12:45, Dekel Peled:
>> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
>> to include an additional value, indicating existence or absence of VLAN
>> headers following the current header, as proposed in RFC
>> https://mails.dpdk.org/archives/dev/2020-August/177536.html.
>> Because of ABI break this change is proposed for 20.11.
>>
>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>> ---
>> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct rte_flow_item_vlan``
>> + structs will be modified, to include an additional value, indicating existence
>> + or absence of a VLAN header following the current header, as proposed in RFC
>> + https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> Specifying match patterns on none or multiple extensions
> is difficult to manage with rte_flow.
> It seems this approach of adding explicit fields in the items
> can work well.
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Similar to IPv6, it looks required to add extra information to ETH (and may
be VLAN) item, but I'm not sure that proposed solution is 100% OK.
Anyway, the scope of the deprecation notice is ongoing changes, so:
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
On Thu, Aug 6, 2020 at 8:14 AM Andrew Rybchenko <arybchenko@solarflare.com>
wrote:
> On 8/6/20 3:25 PM, Thomas Monjalon wrote:
> > 06/08/2020 12:45, Dekel Peled:
> >> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
> >> to include an additional value, indicating existence or absence of VLAN
> >> headers following the current header, as proposed in RFC
> >> https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> >> Because of ABI break this change is proposed for 20.11.
> >>
> >> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> >> ---
> >> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct
> rte_flow_item_vlan``
> >> + structs will be modified, to include an additional value, indicating
> existence
> >> + or absence of a VLAN header following the current header, as
> proposed in RFC
> >> + https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> > Specifying match patterns on none or multiple extensions
> > is difficult to manage with rte_flow.
> > It seems this approach of adding explicit fields in the items
> > can work well.
> >
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
> Similar to IPv6, it looks required to add extra information to ETH (and may
> be VLAN) item, but I'm not sure that proposed solution is 100% OK.
> Anyway, the scope of the deprecation notice is ongoing changes, so:
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
>
> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
> to include an additional value, indicating existence or absence of VLAN
> headers following the current header, as proposed in RFC
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpd
> k.org%2Farchives%2Fdev%2F2020-
> August%2F177536.html&data=02%7C01%7Corika%40mellanox.com%7Cb5
> 9964d529f14539086008d839f621db%7Ca652971c7d2e4d9ba6a4d149256f461b
> %7C0%7C0%7C637323076576373546&sdata=mWvf%2FeYiYhIXcoFaZMikx
> TqcJIS%2FxLQuNHGUqzcAf6w%3D&reserved=0.
> Because of ABI break this change is proposed for 20.11.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 5201142..2899f56 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -115,6 +115,11 @@ Deprecation Notices
> following the IPv6 header, as proposed in RFC
>
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpd
> k.org%2Farchives%2Fdev%2F2020-
> August%2F177257.html&data=02%7C01%7Corika%40mellanox.com%7Cb5
> 9964d529f14539086008d839f621db%7Ca652971c7d2e4d9ba6a4d149256f461b
> %7C0%7C0%7C637323076576373546&sdata=CR3%2B3iKBdLnGo4oRYy1ev
> MMsKxwVy%2Fzf6R44dQt2An8%3D&reserved=0.
>
> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct rte_flow_item_vlan``
> + structs will be modified, to include an additional value, indicating existence
> + or absence of a VLAN header following the current header, as proposed in
> RFC
> +
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpd
> k.org%2Farchives%2Fdev%2F2020-
> August%2F177536.html&data=02%7C01%7Corika%40mellanox.com%7Cb5
> 9964d529f14539086008d839f621db%7Ca652971c7d2e4d9ba6a4d149256f461b
> %7C0%7C0%7C637323076576373546&sdata=mWvf%2FeYiYhIXcoFaZMikx
> TqcJIS%2FxLQuNHGUqzcAf6w%3D&reserved=0.
> +
> * traffic manager: All traffic manager API's in ``rte_tm.h`` were mistakenly
> made
> ABI stable in the v19.11 release. The TM maintainer and other contributors
> have
> agreed to keep the TM APIs as experimental in expectation of additional spec
> --
> 1.8.3.1
Acked-by: Ori Kam <orika@mellanox.com>
Thanks,
Ori
> > >> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
> > >> to include an additional value, indicating existence or absence of VLAN
> > >> headers following the current header, as proposed in RFC
> > >> https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> > >> Because of ABI break this change is proposed for 20.11.
> > >>
> > >> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > >> ---
> > >> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct
> > rte_flow_item_vlan``
> > >> + structs will be modified, to include an additional value, indicating
> > existence
> > >> + or absence of a VLAN header following the current header, as
> > proposed in RFC
> > >> + https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> > > Specifying match patterns on none or multiple extensions
> > > is difficult to manage with rte_flow.
> > > It seems this approach of adding explicit fields in the items
> > > can work well.
> > >
> > > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > Similar to IPv6, it looks required to add extra information to ETH (and may
> > be VLAN) item, but I'm not sure that proposed solution is 100% OK.
> > Anyway, the scope of the deprecation notice is ongoing changes, so:
> >
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Ori Kam <orika@mellanox.com>
Applied
@@ -115,6 +115,11 @@ Deprecation Notices
following the IPv6 header, as proposed in RFC
https://mails.dpdk.org/archives/dev/2020-August/177257.html.
+* ethdev: The ``struct rte_flow_item_eth`` and ``struct rte_flow_item_vlan``
+ structs will be modified, to include an additional value, indicating existence
+ or absence of a VLAN header following the current header, as proposed in RFC
+ https://mails.dpdk.org/archives/dev/2020-August/177536.html.
+
* traffic manager: All traffic manager API's in ``rte_tm.h`` were mistakenly made
ABI stable in the v19.11 release. The TM maintainer and other contributors have
agreed to keep the TM APIs as experimental in expectation of additional spec