diff mbox series

net/mlx5: fix redundant flow after RSS expansion

Message ID d081a6fa197cfd508778f2ff0cc9665241a09f3e.1617111457.git.jackmin@nvidia.com (mailing list archive)
State Accepted
Delegated to: Raslan Darawsheh
Headers show
Series net/mlx5: fix redundant flow after RSS expansion | expand

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot success github build: passed
ci/travis-robot success travis build: passed
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Jack Min March 30, 2021, 1:40 p.m. UTC
When RSS expand, if there is no expansion happened but completion happened
because user only input next protocol field instead of item
i.e, ether type == 0x8100 instead of VLAN, an extra flow is created with
missing item in order to filter traffic strictly.

However, after [1] and [2] the rte_flow_item_eth itself is enough to
filter out VLAN traffic, the VLAN item is not needed.

This redundant flow will cause faiure in some scenarios on group 0 due
to they are the same FTE.

Fixes: fc2dd8dd492f ("ethdev: fix expand RSS flows")
Cc: stable@dpdk.org

[1]:
commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and
VLAN items")

[2]:
commit 86b59a1af671 ("net/mlx5: support VLAN matching fields")

Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.c | 16 ----------------
 1 file changed, 16 deletions(-)

Comments

Matan Azrad April 8, 2021, 9:23 a.m. UTC | #1
From: Xiaoyu Min
> When RSS expand, if there is no expansion happened but completion happened
> because user only input next protocol field instead of item i.e, ether type ==
> 0x8100 instead of VLAN, an extra flow is created with missing item in order to
> filter traffic strictly.
> 
> However, after [1] and [2] the rte_flow_item_eth itself is enough to filter out
> VLAN traffic, the VLAN item is not needed.
> 
> This redundant flow will cause faiure in some scenarios on group 0 due to they
> are the same FTE.
> 
> Fixes: fc2dd8dd492f ("ethdev: fix expand RSS flows")
> Cc: stable@dpdk.org
> 
> [1]:
> commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN
> items")
> 
> [2]:
> commit 86b59a1af671 ("net/mlx5: support VLAN matching fields")
> 
> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
Raslan Darawsheh April 11, 2021, 9:04 a.m. UTC | #2
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaoyu Min
> Sent: Tuesday, March 30, 2021 4:41 PM
> To: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Jack Min
> <jackmin@nvidia.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix redundant flow after RSS
> expansion
> 
> When RSS expand, if there is no expansion happened but completion
> happened
> because user only input next protocol field instead of item
> i.e, ether type == 0x8100 instead of VLAN, an extra flow is created with
> missing item in order to filter traffic strictly.
> 
> However, after [1] and [2] the rte_flow_item_eth itself is enough to
> filter out VLAN traffic, the VLAN item is not needed.
> 
> This redundant flow will cause faiure in some scenarios on group 0 due
> to they are the same FTE.
> 
> Fixes: fc2dd8dd492f ("ethdev: fix expand RSS flows")
> Cc: stable@dpdk.org
> 
> [1]:
> commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and
> VLAN items")
> 
> [2]:
> commit 86b59a1af671 ("net/mlx5: support VLAN matching fields")
> 
> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
> ---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index c347f8130e..668c32cf51 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -385,22 +385,6 @@  mlx5_flow_expand_rss(struct mlx5_flow_expand_rss *buf, size_t size,
 		}
 		node = *next_node ? &graph[*next_node] : NULL;
 	};
-	/* no expanded flows but we have missed item, create one rule for it */
-	if (buf->entries == 1 && missed != 0) {
-		elt = 2;
-		lsize += elt * sizeof(*item) + user_pattern_size;
-		if (lsize <= size) {
-			buf->entry[buf->entries].priority = 1;
-			buf->entry[buf->entries].pattern = addr;
-			buf->entries++;
-			flow_items[0].type = missed_item.type;
-			flow_items[1].type = RTE_FLOW_ITEM_TYPE_END;
-			rte_memcpy(addr, buf->entry[0].pattern,
-				   user_pattern_size);
-			addr = (void *)(((uintptr_t)addr) + user_pattern_size);
-			rte_memcpy(addr, flow_items, elt * sizeof(*item));
-		}
-	}
 	return lsize;
 }