From patchwork Mon Oct 23 14:49:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 30717 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B87A61B61D; Mon, 23 Oct 2017 16:50:15 +0200 (CEST) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 9D1C41B600 for ; Mon, 23 Oct 2017 16:50:14 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id r68so10396844wmr.3 for ; Mon, 23 Oct 2017 07:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=SUADeibJ+VjLbkCqbq23cKXFMuFUeab/xHtGLvwsoRM=; b=wLbnQqZ7+W7DiFzS9CwjMcFV/etBUO0O8VXY/p2xrETU9aWaUYLMhPGGcZusyyJDyT b2aCex9Kta5u6WlEiOElQR2ETV0Gk5ELaerLYgnjE7ivH1LMsh+gIj6PT9Nm615q13ji VFBnNCduGnb7viGKviG8C1eL0bQQJwQyl7+BAo3SN+i9LgSnNUeBW9iYyvkRKXYTKyjy SaK3PJmag3MQnVbk7izVVa6hj7FHTYZr1KbvIe1NX7GlFJv2iBcDpTm7M+bqMA0rOTQE fziKYKt4ZJ21PRjx5BIotevUP/nSP7uOdabPsB5oYhXw4xyTws/gFFZFCrtJR0ku680V cxgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=SUADeibJ+VjLbkCqbq23cKXFMuFUeab/xHtGLvwsoRM=; b=hqHssU2YYpzeSG69a3aBn6BkcOQoJ74bEkoXcp8jXlfbihLrObNtqaJf0FvZkQRYHn DkpubxMxlitOXh00MzpsQfLAKn4CFD/hsxeVEL69/gpABXZEi9kXYCEcVkpEvl5rpzD0 OVIoQJNo9sfUJCqEMVDIjIe7kSRbQX54St23KBr5pt9ERg9fbQQRnBnpmg+hyLzqCZxD pP57G2yZ8PHNq8YtIbyjgnmge/33OJowGiBDBeZMdJVi+lpgu2Fy482UfWP77SeOh75X SNGARaigHRvnBhEEDiTLGL+elOKhU05USnXvwPodttIb7q8EafklUnQ3kXGSX/R+v5zF xUFA== X-Gm-Message-State: AMCzsaURPnsxNDdVq1vlF8ANWnw2t0X+tBAbQEZpehMg/NWWxWpQwnPE v9bv380xs3i5ODV+BNXapBwHxd79Aw== X-Google-Smtp-Source: ABhQp+SGJVwO32of4BtB06VkWGGlp9TaGep/3hWV+P+z2crnjvgHdsaghCNjvRN7HDoUfmHJqfGB7Q== X-Received: by 10.28.67.133 with SMTP id q127mr6119665wma.71.1508770214178; Mon, 23 Oct 2017 07:50:14 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s196sm4908234wmb.26.2017.10.23.07.50.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Oct 2017 07:50:13 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Yongseok Koh , Adrien Mazarguil Date: Mon, 23 Oct 2017 16:49:51 +0200 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 1/7] net/mlx5: fix segfault on flow creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When ports are stopped, the hash Rx queue should not be created. Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 440bda9a1..452fde588 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -1743,6 +1743,8 @@ priv_flow_create_action_queue_rss(struct priv *priv, flow->frxq[i].ibv_attr = parser->queue[i].ibv_attr; parser->queue[i].ibv_attr = NULL; hash_fields = hash_rxq_init[i].hash_fields; + if (!priv->dev->data->dev_started) + continue; flow->frxq[i].hrxq = mlx5_priv_hrxq_get(priv, parser->rss_conf.rss_key,